decidim-initiatives 0.29.1 → 0.30.0.rc1

data/app/permissions/decidim/initiatives/admin/permissions.rb

@@ -39,6 +39,7 @@ module Decidim
           initiative_export_action?
           initiatives_settings_action?
           moderator_action?
+          share_tokens_action?
           allow! if permission_action.subject == :attachment
 
           permission_action
@@ -134,8 +135,8 @@ module Decidim
           return unless permission_action.subject == :initiative
 
           case permission_action.action
-          when :read
-            toggle_allow(Decidim::Initiatives.print_enabled)
+          when :print
+            toggle_allow(Decidim::Initiatives.print_enabled && user.admin?)
           when :publish, :discard
             toggle_allow(initiative.validating?)
           when :unpublish
@@ -179,6 +180,12 @@ module Decidim
           allow!
         end
 
+        def share_tokens_action?
+          return unless permission_action.subject == :share_tokens
+
+          allow!
+        end
+
         def read_initiative_list_action?
           return unless permission_action.subject == :initiative &&
                         permission_action.action == :list

data/app/permissions/decidim/initiatives/permissions.rb

@@ -4,6 +4,8 @@ module Decidim
   module Initiatives
     class Permissions < Decidim::DefaultPermissions
       def permissions
+        return permission_action if initiative && !initiative.is_a?(Decidim::Initiative)
+
         # Delegate the admin permission checks to the admin permissions class
         return Decidim::Initiatives::Admin::Permissions.new(user, permission_action, context).permissions if permission_action.scope == :admin
         return permission_action if permission_action.scope != :public
@@ -19,6 +21,7 @@ module Decidim
         create_initiative?
         edit_public_initiative?
         update_public_initiative?
+        print_initiative?
 
         vote_initiative?
         sign_initiative?
@@ -51,7 +54,8 @@ module Decidim
         return unless [:initiative, :participatory_space].include?(permission_action.subject) &&
                       permission_action.action == :read
 
-        return allow! if initiative.published? || initiative.rejected? || initiative.accepted?
+        return allow! if initiative.open? || initiative.rejected? || initiative.accepted?
+        return allow! if user_can_preview_space?
         return allow! if user && authorship_or_admin?
 
         disallow!
@@ -107,11 +111,11 @@ module Decidim
       end
 
       def access_request_without_user?
-        (!initiative.published? && initiative.promoting_committee_enabled?) || Decidim::Initiatives.do_not_require_authorization
+        (!initiative.open? && initiative.promoting_committee_enabled?) || Decidim::Initiatives.do_not_require_authorization
       end
 
       def access_request_membership?
-        !initiative.published? &&
+        !initiative.open? &&
           initiative.promoting_committee_enabled? &&
           !initiative.has_authorship?(user) &&
           (
@@ -121,6 +125,17 @@ module Decidim
         )
       end
 
+      def print_initiative?
+        return unless permission_action.action == :print &&
+                      permission_action.subject == :initiative
+
+        toggle_allow(Decidim::Initiatives.print_enabled && (authorship_or_admin? || committee_member?))
+      end
+
+      def committee_member?
+        InitiativesPromoted.by(user).exists?(id: initiative.id)
+      end
+
       def vote_initiative?
         return unless permission_action.action == :vote &&
                       permission_action.subject == :initiative
@@ -181,6 +196,12 @@ module Decidim
       )
       end
 
+      def user_can_preview_space?
+        context[:share_token].present? && Decidim::ShareToken.use!(token_for: initiative, token: context[:share_token], user:)
+      rescue ActiveRecord::RecordNotFound, StandardError
+        nil
+      end
+
       def initiative_committee_action?
         return unless permission_action.subject == :initiative_committee_member
 

data/app/queries/decidim/initiatives/outdated_validating_initiatives.rb

@@ -23,7 +23,7 @@ module Decidim
       def query
         Decidim::Initiative
           .where(state: "validating")
-          .where("updated_at < ?", @period_length)
+          .where(updated_at: ...@period_length)
       end
     end
   end

data/app/queries/decidim/initiatives/support_period_finished_initiatives.rb

@@ -10,9 +10,9 @@ module Decidim
       def query
         Decidim::Initiative
           .includes(:scoped_type)
-          .where(state: "published")
+          .where(state: "open")
           .where(signature_type: "online")
-          .where("signature_end_date < ?", Date.current)
+          .where(signature_end_date: ...Date.current)
       end
     end
   end

data/app/serializers/decidim/initiatives/download_your_data_initiative_serializer.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    class DownloadYourDataInitiativeSerializer < OpenDataInitiativeSerializer
+      # Serializes a Debate for download your data feature
+      #
+      # Remove the author information as it is the same of the user that
+      # requested the data
+      def serialize
+        super.except!(:authors)
+      end
+    end
+  end
+end

data/app/serializers/decidim/initiatives/initiative_serializer.rb

@@ -2,33 +2,14 @@
 
 module Decidim
   module Initiatives
-    class InitiativeSerializer < Decidim::Exporters::Serializer
+    class InitiativeSerializer < Decidim::Initiatives::OpenDataInitiativeSerializer
       # Serializes an initiative
       def serialize
-        {
-          id: resource.id,
-          title: resource.title,
-          description: resource.description,
-          state: resource.state,
-          created_at: resource.created_at,
-          published_at: resource.published_at,
-          signature_end_date: resource.signature_end_date,
-          signature_type: resource.signature_type,
-          signatures: resource.supports_count,
-          scope: {
-            name: resource.scope&.name
-          },
-          type: {
-            title: resource.type&.title
-          },
-          authors: {
-            id: resource.author_users.map(&:id),
-            name: resource.author_users.map(&:name)
-          },
-          area: {
-            name: resource.area&.name
+        super.merge(
+          {
+            components: serialize_components
           }
-        }
+        )
       end
     end
   end

data/app/serializers/decidim/initiatives/open_data_initiative_serializer.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    class OpenDataInitiativeSerializer < Decidim::Exporters::ParticipatorySpaceSerializer
+      # Public: Exports a hash with the serialized data for this initiative.
+      #
+      # Note that we do not merge the original serialize method here, as the Initiative
+      # model does not have the same attributes as the other Spaces models.
+      def serialize
+        {
+          reference: resource.reference,
+          title: resource.title,
+          url: EngineRouter.main_proxy(resource).initiative_url(resource),
+          description: resource.description,
+          state: resource.state,
+          created_at: resource.created_at,
+          updated_at: resource.updated_at,
+          published_at: resource.published_at,
+          signature_start_date: resource.signature_start_date,
+          signature_end_date: resource.signature_end_date,
+          signature_type: resource.signature_type,
+          signatures: resource.supports_count,
+          answer: resource.answer,
+          answered_at: resource.answered_at,
+          answer_url: resource.answer_url,
+          hashtag: resource.hashtag,
+          first_progress_notification_at: resource.first_progress_notification_at,
+          second_progress_notification_at: resource.second_progress_notification_at,
+          online_votes: resource.online_votes,
+          offline_votes: resource.offline_votes,
+          comments_count: resource.comments_count,
+          follows_count: resource.follows_count,
+          scope: {
+            id: resource.scope.try(:id),
+            name: resource.scope.try(:name) || empty_translatable
+          },
+          type: {
+            id: resource.type&.id,
+            title: resource.type&.title
+          },
+          authors: {
+            id: resource.author_users.map(&:id),
+            name: resource.author_users.map(&:name)
+          },
+          area: {
+            id: resource.area.try(:id),
+            name: resource.area.try(:name) || empty_translatable
+          }
+        }
+      end
+    end
+  end
+end

data/app/services/decidim/initiatives/data_encryptor.rb

@@ -9,7 +9,7 @@ module Decidim
       def initialize(args = {})
         @secret = args.fetch(:secret) || "default"
         @key = ActiveSupport::KeyGenerator.new(secret).generate_key(
-          Rails.application.secrets.secret_key_base, ActiveSupport::MessageEncryptor.key_len
+          Rails.application.secret_key_base, ActiveSupport::MessageEncryptor.key_len
         )
         @encryptor = ActiveSupport::MessageEncryptor.new(@key)
       end

data/app/services/decidim/initiatives/pdf_signature_example.rb

@@ -50,8 +50,6 @@ module Decidim
       private
 
       def signature_widget(doc)
-        doc.pages.add.document
-
         form = doc.acro_form(create: true)
         form.signature_flag(:append_only)
 

data/app/views/decidim/initiatives/admin/committee_requests/index.html.erb

@@ -56,4 +56,5 @@
   </table>
 </div>
 
+<%= append_stylesheet_pack_tag "decidim_initiatives_admin" %>
 <%= append_javascript_pack_tag "decidim_initiatives_admin" %>

data/app/views/decidim/initiatives/admin/initiatives/edit.html.erb

@@ -73,8 +73,7 @@
             <% if allowed_to? :export_pdf_signatures, :initiative, initiative: current_initiative %>
               <%= link_to t(".export_pdf_signatures"),
                           export_pdf_signatures_initiative_path(current_initiative, format: :pdf),
-                          class: "button button__sm button__secondary",
-                          data: { confirm: t(".confirm") } %>
+                          class: "button button__sm button__secondary" %>
             <% end %>
        </div>
      </div>

data/app/views/decidim/initiatives/admin/initiatives/index.html.erb

@@ -45,6 +45,13 @@
             <td class="table-list__date"><%= l initiative.created_at, format: :short %></td>
             <td class="table-list__date"><%= initiative.published_at? ? l(initiative.published_at, format: :short) : "" %></td>
             <td class="table-list__actions">
+
+              <% if allowed_to? :read, :share_tokens, current_participatory_space: initiative %>
+                <%= icon_link_to "share-line", decidim_admin_initiatives.initiative_share_tokens_path(initiative), t("actions.share_tokens", scope: "decidim.admin"), class: "action-icon--new" %>
+              <% else %>
+                <span class="action-space icon"></span>
+              <% end %>
+
               <% if allowed_to? :edit, :initiative, initiative: initiative %>
                 <%= icon_link_to "pencil-line",
                                  decidim_admin_initiatives.edit_initiative_path(initiative.to_param),
@@ -60,7 +67,7 @@
                 <%= icon "chat-1-line", scope: "decidim.admin", class: "action-icon action-icon--disabled", role: "img", "aria-hidden": true %>
               <% end %>
 
-              <% if allowed_to? :read, :initiative, initiative: initiative %>
+              <% if allowed_to? :print, :initiative, initiative: initiative %>
                 <%= icon_link_to "printer-line",
                                  decidim_initiatives.print_initiative_path(initiative),
                                  t(".print"),

data/app/views/decidim/initiatives/committee_requests/new.html.erb

@@ -1,11 +1,10 @@
 <% add_decidim_meta_tags({
-                           image_url: current_initiative.type.attached_uploader(:banner_image).url,
+                           image_url: resolve_meta_image_url(current_initiative),
                            description: translated_attribute(current_initiative.description),
                            title: translated_attribute(current_initiative.title),
                            url: initiative_url(current_initiative.id)
                          }) %>
 
-<% add_decidim_page_title(translated_attribute(current_initiative.title)) %>
 <% provide :meta_image_url, current_initiative.type.attached_uploader(:banner_image).url %>
 
 <%= render layout: "layouts/decidim/shared/layout_center" do %>

data/app/views/decidim/initiatives/create_initiative/fill_data.html.erb

@@ -47,10 +47,10 @@
     <% if initiative_type.attachments_enabled? %>
       <%= f.attachment :documents,
                        multiple: true,
-                       label: t("decidim.initiatives.form.add_documents"),
-                       button_label: t("decidim.initiatives.form.add_documents"),
+                       label: t("decidim.initiatives.form.add_attachments"),
+                       button_label: t("decidim.initiatives.form.add_attachments"),
                        button_class: "button button__lg button__transparent-secondary w-full",
-                       button_edit_label: t("decidim.initiatives.form.edit_documents"),
+                       button_edit_label: t("decidim.initiatives.form.edit_attachments"),
                        help_text: t("attachment_legend", scope: "decidim.initiatives.form") %>
       <%= f.attachment :photos,
                        multiple: true,

data/app/views/decidim/initiatives/create_initiative/select_initiative_type.html.erb

@@ -27,8 +27,16 @@
         <div class="initiatives__selection__text">
           <h2 class="h5 text-secondary"><%= translated_attribute(type.title) %></h2>
           <span><%= decidim_sanitize_admin(translated_attribute(type.description)) %></span>
-          <%= authorized_create_modal_button(type, remote: true, class: "button button__sm button__secondary") do %>
-            <%= t("verification_required", scope: "decidim.initiatives.create_initiative.select_initiative_type") %>
+          <%= action_authorized_link_to(
+                :create,
+                fill_data_create_initiative_index_path(initiative: { type_id: type.id }),
+                authorizations_modal_path: authorization_create_modal_initiative_path(type),
+                permissions_holder: type,
+                class: "button button__sm button__secondary",
+                "data-dialog-open": "not-authorized-modal",
+                onclick: "event.preventDefault();"
+              ) do %>
+              <%= t("verification_required", scope: "decidim.initiatives.create_initiative.select_initiative_type") %>
           <% end %>
         </div>
       </div>

data/app/views/decidim/initiatives/initiatives/_form.html.erb

@@ -51,10 +51,10 @@
 <% if current_initiative.type.attachments_enabled? %>
   <%= form.attachment :documents,
                       multiple: true,
-                      label: t("decidim.initiatives.form.add_documents"),
-                      button_label: t("decidim.initiatives.form.add_documents"),
+                      label: t("decidim.initiatives.form.add_attachments"),
+                      button_label: t("decidim.initiatives.form.add_attachments"),
                       button_class: "button button__lg button__transparent-secondary w-full",
-                      button_edit_label: t("decidim.initiatives.form.edit_documents"),
+                      button_edit_label: t("decidim.initiatives.form.edit_attachments"),
                       help_text: t("decidim.initiatives.form.attachment_legend") %>
 
   <%= form.attachment :photos,

data/app/views/decidim/initiatives/initiatives/_new_initiative_button.html.erb

@@ -1,27 +1,30 @@
 <% if Decidim::Initiatives.creation_enabled %>
-  <% if current_user && available_initiative_types.size > 1 %>
-    <%= link_to create_initiative_path(:select_initiative_type), class: "!px-4 title-action__action button button__xl button__secondary w-full" do %>
-      <%= t("new_initiative", scope: "decidim.initiatives.initiatives.index_header") %>
-      <%= icon "add-fill" %>
-    <% end %>
-  <% elsif current_user %>
-    <% if allowed_to?(:create, :initiative, { initiative_type: available_initiative_types.first }) %>
+  <% if available_initiative_types.size > 1 %>
+    <% if current_user %>
       <%= link_to create_initiative_path(:select_initiative_type), class: "!px-4 title-action__action button button__xl button__secondary w-full" do %>
         <%= t("new_initiative", scope: "decidim.initiatives.initiatives.index_header") %>
         <%= icon "add-fill" %>
       <% end %>
     <% else %>
-      <%= authorized_create_modal_button(available_initiative_types.first, remote: true, class: "!px-4 title-action__action button button__xl button__secondary w-full") do %>
+      <% content_for(:redirect_after_login) { create_initiative_url(:select_initiative_type) } %>
+      <button type="button" class="button button__xl button__secondary w-full" data-dialog-open="loginModal" aria-controls="loginModal" aria-haspopup="dialog" tabindex="0">
         <%= t("new_initiative", scope: "decidim.initiatives.initiatives.index_header") %>
         <%= icon "add-fill" %>
-      <% end %>
+      </button>
     <% end %>
-  <% else %>
-    <% content_for(:redirect_after_login) { create_initiative_url(:select_initiative_type) } %>
-    <button type="button" class="button button__xl button__secondary w-full" data-dialog-open="loginModal" aria-controls="loginModal" aria-haspopup="dialog" tabindex="0">
+  <% elsif (initiative_type = available_initiative_types.first).present? %>
+    <% content_for(:redirect_after_login) { fill_data_create_initiative_index_path(initiative: { type_id: initiative_type.id }) } unless current_user %>
+    <%= action_authorized_link_to(
+          :create,
+          fill_data_create_initiative_index_path(initiative: { type_id: initiative_type.id }),
+          authorizations_modal_path: authorization_create_modal_initiative_path(initiative_type),
+          permissions_holder: initiative_type,
+          "data-dialog-open": allowed_to?(:create, :initiative, { initiative_type: }) ? "" : "not-authorized-modal",
+          class: "!px-4 title-action__action button button__xl button__secondary w-full"
+        ) do %>
       <%= t("new_initiative", scope: "decidim.initiatives.initiatives.index_header") %>
       <%= icon "add-fill" %>
-    </button>
+    <% end %>
   <% end %>
 <% end %>
 

data/app/views/decidim/initiatives/initiatives/_vote_button.html.erb

@@ -34,8 +34,14 @@
       </button>
     <% end %>
   <% else %>
-    <%= authorized_vote_modal_button(initiative, remote: true, class: "button button__xl w-full button__secondary") do %>
-      <%= verification_label %>
-    <% end %>
+    <%= action_authorized_link_to(
+      :vote,
+      t("vote", scope: "decidim.initiatives.initiatives.vote_cabin"),
+      steps ? initiative_signatures_path(initiative_slug: current_initiative.slug) : initiative_path(current_initiative),
+      resource: current_initiative,
+      permissions_holder: current_initiative.type,
+      authorizations_modal_path: authorization_sign_modal_initiative_path(current_initiative),
+      class: "button button__xl w-full button__secondary"
+    ) %>
   <% end %>
 <% end %>

data/app/views/decidim/initiatives/initiatives/_vote_cabin.html.erb

@@ -4,7 +4,6 @@
                  initiative:,
                  vote_label: t("vote", scope: "decidim.initiatives.initiatives.vote_cabin"),
                  unvote_label: t("already_voted", scope: "decidim.initiatives.initiatives.vote_cabin"),
-                 verification_label: t("verification_required", scope: "decidim.initiatives.initiatives.vote_cabin"),
                  steps: signature_has_steps?
                } %>
 <% else %>

data/app/views/decidim/initiatives/initiatives/show.html.erb

@@ -1,9 +1,8 @@
-<% add_decidim_meta_tags({
-                           image_url: current_initiative.type.attached_uploader(:banner_image).url,
-                           description: translated_attribute(current_initiative.description),
-                           title: translated_attribute(current_initiative.title),
-                           url: initiative_url(current_initiative.id)
-                         }) %>
+<% add_decidim_meta_tags(
+  description: translated_attribute(current_initiative.description),
+  title: translated_attribute(current_initiative.title),
+  url: initiative_url(current_initiative.id),
+  resource: current_initiative) %>
 
 <%
 edit_link(
@@ -210,8 +209,8 @@ edit_link(
   <% if current_initiative.commentable? && current_initiative.published? %>
     <%= cell "decidim/comments_button", nil, display: current_initiative.commentable? && current_initiative.published? %>
   <% end %>
-  <div class="ml-auto">
-    <%= cell "decidim/share_button", nil %>
+  <div class="ml-auto lg:ml-0">
+    <%= cell "decidim/share_widget", current_initiative %>
   </div>
 </section>
 

data/app/views/layouts/decidim/admin/_manage_initiatives.html.erb

@@ -0,0 +1,11 @@
+<div class="inline-block relative">
+  <%= button_tag data: { component: "dropdown", target: "initiatives-dropdown-menu-settings" }, class: "dropdown__trigger button button__transparent" do %>
+    <span>
+      <%= t("menu.manage", scope: "decidim.admin") %>
+    </span>
+    <%= icon "arrow-down-s-line" %>
+  <% end %>
+  <div id="initiatives-dropdown-menu-settings" class="process-title-content-dropdown" aria-hidden="true">
+    <%= dropdown_menu(:admin_initiatives_menu).render %>
+  </div>
+</div>

data/app/views/layouts/decidim/admin/initiatives.html.erb

@@ -1,13 +1,5 @@
 <% content_for :breadcrumb_context_menu do %>
-  <div class="inline-block relative">
-    <%= button_tag data: { component: "dropdown", target: "initiatives-dropdown-menu-settings" }, class: "dropdown__trigger button button__transparent" do %>
-      <%= t("actions.manage", scope: "decidim.admin") %>
-      <%= icon "arrow-down-s-line" %>
-    <% end %>
-    <div id="initiatives-dropdown-menu-settings" class="process-title-content-dropdown" aria-hidden="true">
-      <%= dropdown_menu(:admin_initiatives_menu).render %>
-    </div>
-  </div>
+  <%= render partial: "layouts/decidim/admin/manage_initiatives" %>
 <% end %>
 
 <%= render "layouts/decidim/admin/application" do %>

data/config/assets.rb

@@ -5,7 +5,5 @@ base_path = File.expand_path("..", __dir__)
 Decidim::Webpacker.register_path("#{base_path}/app/packs")
 Decidim::Webpacker.register_entrypoints(
   decidim_initiatives: "#{base_path}/app/packs/entrypoints/decidim_initiatives.js",
-  decidim_initiatives_admin: "#{base_path}/app/packs/entrypoints/decidim_initiatives_admin.js",
-  decidim_initiatives_print: "#{base_path}/app/packs/entrypoints/decidim_initiatives_print.js",
-  decidim_initiatives_initiatives_votes: "#{base_path}/app/packs/entrypoints/decidim_initiatives_initiatives_votes.js"
+  decidim_initiatives_admin: "#{base_path}/app/packs/entrypoints/decidim_initiatives_admin.js"
 )

data/config/locales/ar.yml

@@ -96,8 +96,8 @@ ar:
             initiative_start_date: تاريخ البدء
             initiative_title: عنوان المبادرة
             name_and_surname: اسم ولقب
+            nickname: الاسم المستعار
             postal_code: الكود البريدى
-            time_and_date: الوقت و التاريخ
             timestamp: الطابع الزمني
       titles:
         initiatives: المبادرات
@@ -124,8 +124,8 @@ ar:
       badges:
         initiatives:
           conditions:
-            - انتقل إلى مساحة مشاركة المبادرات
-            - اتبع الخطوات لإنشاء مبادرة جديدة
+          - انتقل إلى مساحة مشاركة المبادرات
+          - اتبع الخطوات لإنشاء مبادرة جديدة
           description: تُمنح هذه الشارة عند إطلاق مبادرات جديدة ، وإقامة شراكة مع الآخرين لتنفيذها.
           description_another: حصل هذا المشارك على %{score} مبادرة تم نشرها.
           name: المبادرات المنشورة
@@ -201,7 +201,6 @@ ar:
       admin_states:
         created: تمّ إنشاؤه
         discarded: التخلص منها
-        published: نشرت
         validating: المصادقة الفنية
       application_helper:
         filter_state_values:
@@ -252,6 +251,10 @@ ar:
           email_outro: لقد تلقيت هذا الإشعار لأنك تتابع %{author_nickname}. يمكنك إيقاف تلقي الإخطارات باتباع الرابط السابق.
           email_subject: المبادرة التي أقرتها %{author_nickname}
           notification_title: تمت الموافقة على مبادرة <a href="%{resource_path}">%{resource_title}</a> من قبل <a href="%{author_path}">%{author_name} %{author_nickname}</a>.
+      form:
+        add_attachments: إضافة مرفقات
+        attachment_legend: إضافة مستند أو صورة
+        edit_attachments: تعديل المرفقات
       initiative_signatures:
         fill_personal_data:
           continue: استمر
@@ -325,7 +328,6 @@ ar:
           other: " التوقيعات"
         vote_cabin:
           already_voted: وقعت بالفعل
-          verification_required: تحقق من حسابك لتوقيع المبادرة
           vote: إشارة
           votes_blocked: توقيع المعوقين
         votes_count:
@@ -358,6 +360,9 @@ ar:
     menu:
       initiatives: المبادرات
     resources:
+      initiative:
+        actions:
+          comment: تعليق
       initiatives_type:
         actions:
           title: أفعال