decidim-core 0.28.5 → 0.29.0.rc1

data/lib/decidim/core/test/shared_examples/system_endorse_resource_examples.rb

@@ -5,27 +5,27 @@ require "spec_helper"
 shared_context "with resources to be endorsed or not" do
   include_context "with a component"
 
-  # Should be overriden and create one main resource
+  # Should be overridden and create one main resource
   let!(:resource) { nil }
   # the name of the resource to be clicked from the component view
   let(:resource_name) { nil }
-  # Should be overriden and create 3 extra resources in the current component
+  # Should be overridden and create 3 extra resources in the current component
   let!(:resources) { nil }
 end
 
 shared_examples "Endorse resource system specs" do
   def expect_page_not_to_include_endorsements
-    expect(page).not_to have_button("Like")
-    expect(page).not_to have_css("#resource-#{resource.id}-endorsements-count")
+    expect(page).to have_no_button("Like")
+    expect(page).to have_no_css("#resource-#{resource.id}-endorsements-count")
   end
 
   def visit_resource
     visit_component
-    click_link resource_name
+    click_on resource_name
   end
 
   context "when endorsements are not enabled" do
-    let(:component_traits) { [:with_endorsements_disabled] }
+    let(:component_traits) { [:with_votes_enabled, :with_endorsements_disabled] }
 
     context "when the user is not logged in" do
       it "does not show the endorse resource button and counts" do
@@ -51,17 +51,17 @@ shared_examples "Endorse resource system specs" do
 
     it "shows the endorsements count and the endorse button is disabled" do
       visit_resource
-      expect(page).to have_css("#resource-#{resource.id}-endorsement-block button[disabled='true']")
+      expect(page).to have_css("[data-buttons] button[disabled='true']")
     end
   end
 
   context "when endorsements are enabled" do
-    let(:component_traits) { [:with_endorsements_enabled] }
+    let(:component_traits) { [:with_votes_enabled, :with_endorsements_enabled] }
 
     context "when the user is not logged in" do
       it "is given the option to sign in" do
         visit_resource
-        within "#resource-#{resource.id}-endorsement-block" do
+        within "[data-buttons]", match: :first do
           click_on "Like"
         end
 
@@ -77,7 +77,7 @@ shared_examples "Endorse resource system specs" do
       context "when the resource is not endorsed yet" do
         it "is able to endorse the resource" do
           visit_resource
-          within "#resource-#{resource.id}-endorsement-block" do
+          within "[data-buttons]" do
             click_on "Like"
             expect(page).to have_button("Dislike")
           end
@@ -89,15 +89,15 @@ shared_examples "Endorse resource system specs" do
 
         it "is not able to endorse it again" do
           visit_resource
-          within "#resource-#{resource.id}-endorsement-block" do
+          within "[data-buttons]" do
             expect(page).to have_button("Dislike")
-            expect(page).not_to have_button("Like")
+            expect(page).to have_no_button("Like")
           end
         end
 
         it "is able to undo the endorsement" do
           visit_resource
-          within "#resource-#{resource.id}-endorsement-block" do
+          within "[data-buttons]" do
             click_on "Dislike"
             expect(page).to have_button("Like")
           end
@@ -124,7 +124,7 @@ shared_examples "Endorse resource system specs" do
         context "when user is NOT verified" do
           it "is NOT able to endorse" do
             visit_resource
-            within "#resource-#{resource.id}-endorsement-block" do
+            within "[data-buttons]", match: :first do
               click_on "Like"
             end
             expect(page).to have_css("#authorizationModal", visible: :visible)
@@ -142,111 +142,13 @@ shared_examples "Endorse resource system specs" do
 
           it "IS able to endorse", :slow do
             visit_resource
-            within "#resource-#{resource.id}-endorsement-block" do
+            within "[data-buttons]", match: :first do
               click_on "Like"
             end
             expect(page).to have_button("Dislike")
           end
         end
       end
-
-      context "when user being a part of a group" do
-        let(:component_traits) { [:with_endorsements_enabled] }
-        let!(:user_group) do
-          create(
-            :user_group,
-            :verified,
-            name: "Tester's Organization",
-            nickname: "test_org",
-            email: "t.mail.org@example.org",
-            users: [user],
-            organization:
-          )
-        end
-
-        before do
-          organization.update(user_groups_enabled:)
-          login_as user, scope: :user
-          visit_resource
-        end
-
-        context "when organization is not allowing user groups" do
-          let(:user_groups_enabled) { false }
-
-          it "is able to endorse the resource" do
-            within "#resource-#{resource.id}-endorsement-block" do
-              click_on "Like"
-              expect(page).to have_button("Dislike")
-            end
-          end
-        end
-
-        context "when organization allows user groups" do
-          let(:user_groups_enabled) { true }
-
-          it "opens a modal where you select identity as a user or a group" do
-            click_on "Like"
-            expect(page).to have_content("Select identity")
-            expect(page).to have_content("Tester's Organization")
-            expect(page).to have_content(user.name)
-          end
-
-          def add_likes
-            click_on "Like"
-            within "#user-identities" do
-              click_on "Tester's Organization"
-              click_on user.name
-              click_on "Done"
-            end
-            visit_resource
-            click_on "Dislike"
-          end
-
-          context "when both identities picked" do
-            it "likes the post as a group and a user" do
-              add_likes
-
-              within ".identities-modal__list" do
-                expect(page).to have_css(".is-selected", count: 2)
-              end
-            end
-          end
-
-          context "when like cancelled as a user" do
-            it "does not cancel group like" do
-              add_likes
-              find(".is-selected", match: :first).click
-              click_on "Done"
-              visit current_path
-              click_on "Like"
-
-              within ".identities-modal__list" do
-                expect(page).to have_css(".is-selected", count: 1)
-                within ".is-selected" do
-                  expect(page).to have_content("Tester's Organization")
-                end
-              end
-            end
-          end
-
-          context "when like cancelled as a group" do
-            it "does not cancel user like" do
-              add_likes
-              page.all(".is-selected")[1].click
-              click_on "Done"
-              visit current_path
-              click_on "Dislike"
-
-              within ".identities-modal__list" do
-                expect(page).to have_css(".is-selected", count: 1)
-                within ".is-selected" do
-                  expect(page).to have_text(user.name, exact: true)
-                end
-              end
-            end
-          end
-        end
-      end
     end
   end
 end

data/lib/decidim/core/test/shared_examples/translated_event_examples.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 shared_examples_for "a translated event" do
-  context "when it is not machine machine translated" do
+  context "when it is not machine translated" do
     let(:organization) { create(:organization, enable_machine_translations: false, machine_translation_display_priority: "original") }
 
     it "does not perform translation" do
@@ -25,7 +25,7 @@ shared_examples_for "a translated event" do
     end
   end
 
-  context "when is machine machine translated" do
+  context "when is machine translated" do
     let(:user) { create :user, organization:, locale: "ca" }
 
     around do |example|

data/lib/decidim/core/test/shared_examples/uncommentable_component_examples.rb

@@ -14,8 +14,8 @@ shared_examples "an uncommentable component" do
 
     visit_component
 
-    resources.each do |ressource|
-      expect(page).not_to have_link(resource_locator(ressource).path)
+    resources.each do |resource|
+      expect(page).to have_no_link(resource_locator(resource).path)
     end
   end
 end

data/lib/decidim/core/test/shared_examples/with_endorsable_permissions_examples.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-# users of this test should delare the `subject` variable.
+# users of this test should declare the `subject` variable.
 shared_examples "with endorsable permissions can perform actions related to endorsable" do
   let(:action_subject) { :endorsement }
   let(:resource) { create :dummy_resource, component: }

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.28.5"
+      "0.29.0.rc1"
     end
   end
 end

data/lib/decidim/core.rb

@@ -53,6 +53,8 @@ module Decidim
   autoload :Menu, "decidim/menu"
   autoload :MenuItem, "decidim/menu_item"
   autoload :MenuRegistry, "decidim/menu_registry"
+  autoload :AdminFilter, "decidim/admin_filter"
+  autoload :AdminFiltersRegistry, "decidim/admin_filters_registry"
   autoload :ManifestRegistry, "decidim/manifest_registry"
   autoload :AssetRouter, "decidim/asset_router"
   autoload :EngineRouter, "decidim/engine_router"
@@ -102,7 +104,6 @@ module Decidim
   autoload :ShareableWithToken, "decidim/shareable_with_token"
   autoload :RecordEncryptor, "decidim/record_encryptor"
   autoload :AttachmentAttributes, "decidim/attachment_attributes"
-  autoload :CarrierWaveMigratorService, "decidim/carrier_wave_migrator_service"
   autoload :ReminderRegistry, "decidim/reminder_registry"
   autoload :ReminderManifest, "decidim/reminder_manifest"
   autoload :ManifestMessages, "decidim/manifest_messages"
@@ -124,6 +125,14 @@ module Decidim
   autoload :IconRegistry, "decidim/icon_registry"
   autoload :HasConversations, "decidim/has_conversations"
 
+  module Commands
+    autoload :CreateResource, "decidim/commands/create_resource"
+    autoload :UpdateResource, "decidim/commands/update_resource"
+    autoload :DestroyResource, "decidim/commands/destroy_resource"
+    autoload :ResourceHandler, "decidim/commands/resource_handler"
+    autoload :HookError, "decidim/commands/hook_error"
+  end
+
   include ActiveSupport::Configurable
   # Loads seeds from all engines.
   def self.seed!
@@ -171,7 +180,7 @@ module Decidim
 
   def self.seed_gamification_badges!
     Gamification.badges.each do |badge|
-      puts "Setting random values for the \"#{badge.name}\" badge..."
+      puts "Setting random values for the \"#{badge.name}\" badge..." # rubocop:disable Rails/Output
       User.all.find_each do |user|
         Gamification::BadgeScore.find_or_create_by!(
           user:,
@@ -305,7 +314,7 @@ module Decidim
     end
   end
 
-  # Exposes a configuration option: the whitelist ips
+  # Exposes a configuration option: the IPs that are allowed to access the system
   config_accessor :system_accesslist_ips do
     []
   end
@@ -432,7 +441,7 @@ module Decidim
     ";"
   end
 
-  # Exposes a configuration option: HTTP_X_FORWADED_HOST header follow-up.
+  # Exposes a configuration option: HTTP_X_FORWARDED_HOST header follow-up.
   # If a caching system is in place, it can also allow cache and log poisoning attacks,
   # allowing attackers to control the contents of caches and logs that could be used for other attacks.
   config_accessor :follow_http_x_forwarded_host do
@@ -542,17 +551,6 @@ module Decidim
     "/"
   end
 
-  # This is the maximum time that the cache will be stored. If nil, the cache will be stored indefinitely.
-  # Currently, cache is applied in the Cells where the method `cache_hash` is defined.
-  config_accessor :cache_expiry_time do
-    24.hours
-  end
-
-  # Same as before, but specifically for cell displaying stats
-  config_accessor :stats_cache_expiry_time do
-    10.minutes
-  end
-
   # Enable/Disable the service worker
   config_accessor :service_worker_enabled do
     Rails.env.exclude?("development")
@@ -563,6 +561,11 @@ module Decidim
     %w(terms-of-service)
   end
 
+  # The default max last activity users to be shown
+  config_accessor :default_max_last_activity_users do
+    6
+  end
+
   # List of additional content security policies to be appended to the default ones
   # This is useful for adding custom CSPs for external services like Here Maps, YouTube, etc.
   # Read more: https://docs.decidim.org/en/develop/configure/initializer#_content_security_policy
@@ -768,6 +771,10 @@ module Decidim
     @icons ||= Decidim::IconRegistry.new
   end
 
+  def self.admin_filter(name, &)
+    AdminFiltersRegistry.register(name.to_sym, &)
+  end
+
   # Public: Stores an instance of ViewHooks
   def self.view_hooks
     @view_hooks ||= ViewHooks.new
@@ -832,11 +839,11 @@ module Decidim
   end
 
   def self.register_assets_path(path)
-    Rails.autoloaders.main.ignore(path) if Rails.configuration.autoloader == :zeitwerk
+    Rails.autoloaders.main.ignore(path)
   end
 
   # Checks if a particular decidim gem is installed and needed by this
-  # particular instance. Preferrably this happens through bundler by inspecting
+  # particular instance. Preferably this happens through bundler by inspecting
   # the Gemfile of the instance but when Decidim is used without bundler, this
   # will check:
   # 1. If the gem is globally available or not in the loaded specs, i.e. the

data/lib/decidim/dependency_resolver.rb

@@ -86,7 +86,7 @@ module Decidim
       File.exist?(path)
     end
 
-    # Checks if the module for the gem speficiation has been loaded through
+    # Checks if the module for the gem specification has been loaded through
     # `require "decidim/foo"`.
     #
     # @param spec [Bundler::LazySpecification, Gem::Specification, String] The
@@ -179,8 +179,8 @@ module Decidim
       # @yield [dependency] Yields each dependency to be processed to the
       #   provided block to check if that dependency needs to be processed or
       #   not.
-      # @yieldparam [Gem::Dependency] The runtime dependency being processed.
-      # @yieldreturn [Boolean] A boolean indicating whether this dependency
+      # @yield param [Gem::Dependency] The runtime dependency being processed.
+      # @yield return [Boolean] A boolean indicating whether this dependency
       #   needs to be processed or not. True indicates it needs to be processed
       #   and false indicates processing is not needed.
       # @return [Bundler::LazySpecification, nil] The specification for the gem

data/lib/decidim/diffy_extension.rb

@@ -13,24 +13,6 @@ module Decidim
         str = wrap_lines(@diff.map { |line| wrap_line(line) })
         ActionView::Base.new(ActionView::LookupContext.new(nil), {}, nil).sanitize(str, tags: TAGS)
       end
-
-      private
-
-      def wrap_line(line)
-        cleaned = clean_line(line)
-        case line
-        when /^(---|\+\+\+|\\\\)/
-          "    <li class=\"diff-comment\"><div>#{line.chomp}</div></li>"
-        when /^\+/
-          "    <li class=\"ins\"><ins>#{cleaned}</ins></li>"
-        when /^-/
-          "    <li class=\"del\"><del>#{cleaned}</del></li>"
-        when /^ /
-          "    <li class=\"unchanged\"><div>#{cleaned}</div></li>"
-        when /^@@/
-          "    <li class=\"diff-block-info\"><div>#{line.chomp}</div></li>"
-        end
-      end
     end
 
     # Adding a new method to Diffy::Format so we can pass the
@@ -41,7 +23,7 @@ module Decidim
       end
     end
 
-    # The private "split" method SplitDiff needs to be overriden to take into
+    # The private "split" method SplitDiff needs to be overridden to take into
     # account the new :unescaped_html format, and the fact that the tags
     # <ins> <del> are not there anymore
     Diffy::SplitDiff.module_eval do

data/lib/decidim/download_your_data_serializers/download_your_data_user_serializer.rb

@@ -5,6 +5,7 @@ module Decidim
   module DownloadYourDataSerializers
     class DownloadYourDataUserSerializer < Decidim::Exporters::Serializer
       include Decidim::ResourceHelper
+      include Decidim::TranslatableAttributes
 
       # Public: Exports a hash with the serialized data for this user.
       def serialize
@@ -16,7 +17,7 @@ module Decidim
           locale: resource.locale,
           organization: {
             id: resource.organization.try(:id),
-            name: resource.organization.try(:name)
+            name: translated_attribute(resource.organization.try(:name))
           },
           newsletter_notifications_at: resource.newsletter_notifications_at,
           notifications_sending_frequency: resource.notifications_sending_frequency,

data/lib/decidim/engine_router.rb

@@ -42,12 +42,12 @@ module Decidim
       route_helper?(method_name) || super
     end
 
-    def method_missing(method_name, *args)
+    def method_missing(method_name, *)
       return super unless route_helper?(method_name)
 
       filter_slug_params!(method_name)
 
-      send(engine).send(method_name, *args)
+      send(engine).send(method_name, *)
     end
 
     private

data/lib/decidim/events/base_event.rb

@@ -77,6 +77,25 @@ module Decidim
 
       def resource_text; end
 
+      # The cell that will be used to render the action or nil if not action needs to be rendered.
+      #
+      # @return [nil] - if no action needs to be rendered
+      # @return [String] - if String, it is the cell to be rendered. Make it return with "decidim/notification_actions/buttons"
+      #                    in your event implementation to render the buttons cell
+      def action_cell; end
+
+      # The data that will be passed to the action cell
+      #
+      # @return [nil] - If no data needs to be rendered
+      # @return [Array<Hash{Symbol => String}>] - For the buttons cell, it should be an array of hashes with the following keys:
+      #   - url: the URL to which the button will point
+      #   - label: the label of the button (optional if i18n_label is present)
+      #   - i18n_label: the i18n key of the label (optional if label is present)
+      #   - icon: the icon of the button (optional)
+      #   - method: the HTTP method of the request (optional)
+      #   - class: the class of the button (optional)
+      def action_data; end
+
       def organization
         resource.try(:organization)
       end

data/lib/decidim/events/simple_event.rb

@@ -11,6 +11,7 @@ module Decidim
       include Decidim::Events::EmailEvent
       include Decidim::Events::NotificationEvent
       include Decidim::ComponentPathHelper
+      include Decidim::OrganizationHelper
 
       delegate :created_at, to: :resource
 

data/lib/decidim/exporters/export_manifest.rb

@@ -32,7 +32,7 @@ module Decidim
       end
 
       # Public: Sets the +collection block+ when a block is given, or returns
-      # the previously setted +collection block+ if no block is provided.
+      # the previously set +collection block+ if no block is provided.
       #
       # The +collection block+ knows how to obtain the collection of elements
       # to be serialized by the +Serializer+.

data/lib/decidim/faker/localized.rb

@@ -135,9 +135,9 @@ module Decidim
         end.with_indifferent_access
       end
 
-      # Wrapps a text build by the block with some other text.
+      # Wraps a text build by the block with some other text.
       #
-      # before - The String text to inject at the begining of each value.
+      # before - The String text to inject at the beginning of each value.
       # after  - The String text to inject at the end of each value.
       # block  - A Block that generates a Hash with a text for each locale.
       #
@@ -164,7 +164,7 @@ module Decidim
       end
 
       # Runs the given block for each of the available locales in Decidim,
-      # momentarilly setting the locale to the current one.
+      # momentarily setting the locale to the current one.
       #
       # Returns a Hash with a value for each locale.
       def self.localized

data/lib/decidim/form_builder.rb

@@ -122,7 +122,7 @@ module Decidim
     def hashtaggable_text_field(type, name, locale, options = {})
       options[:hashtaggable] = true if type.to_sym == :editor
 
-      content_tag(:div, class: "hashtags__container") do
+      content_tag(:div) do
         if options[:value]
           send(type, name_with_locale(name, locale), options.merge(label: options[:label], value: options[:value][locale]))
         else
@@ -202,7 +202,7 @@ module Decidim
 
       content_tag(
         :div,
-        class: "editor #{"hashtags__container" if editor_options[:editor]["class"].include?("js-hashtags")}",
+        class: "editor",
         id: "#{sanitize_for_dom_selector(@object_name)}_#{sanitize_for_dom_selector(name)}"
       ) do
         template = ""
@@ -390,7 +390,7 @@ module Decidim
     # options      - A Hash with options to build the field. See upload method for
     # more detailed information.
     def attachment(attribute, options = {})
-      object_attachment = object.respond_to?(:attachment) && object.attachment.present?
+      object_attachment = object.attachment.present?
       record = object_attachment ? object.attachment : object
       options = {
         titled: options[:multiple],
@@ -416,9 +416,9 @@ module Decidim
     # options      - A Hash with options to build the field.
     #              * max_file_size: Maximum size for the file (If you really want to change max
     #                 file size you should probably change it in validator).
-    #              * resouce_name: Name of the resource (e.g. user)
+    #              * resource_name: Name of the resource (e.g. user)
     #              * resource_class: Attribute's resource class (e.g. Decidim::User)
-    #              * resouce_class: Class of the resource (e.g. user)
+    #              * resource_class: Class of the resource (e.g. user)
     #              * required: Whether the file is required or not (false by default).
     #              * titled: Whether the file can have title or not.
     #              * show_current: Whether the current file is displayed next to the button.

data/lib/decidim/hashtag.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Decidim
-  # A hasthag is used to categorize components
+  # A hashtag is used to categorize components
   class Hashtag < ApplicationRecord
     self.table_name = "decidim_hashtags"
 

data/lib/decidim/jsonb_attributes.rb

@@ -4,7 +4,7 @@ require "active_support/concern"
 
 module Decidim
   # A set of convenient methods to generate dynamic jsonb objects in a way is
-  # compatible with AttirubteObject and ActiveModel thus making it easy to
+  # compatible with AttributeObject and ActiveModel thus making it easy to
   # integrate into Rails forms and similar workflows.
   module JsonbAttributes
     extend ActiveSupport::Concern
@@ -20,15 +20,15 @@ module Decidim
       #   jsonb_attribute(:settings, [[:custom_setting, String], [:another_setting, Boolean])
       #   # This will generate `custom_setting`, `custom_setting=` and
       #   # `another_setting`, `another_setting=` and will keep them
-      #   # syncronized with a hash in `settings`:
+      #   # synchronized with a hash in `settings`:
       #   # settings = { "custom_setting" => "demo", "another_setting" => "demo"}
       #
       # Returns nothing.
-      def jsonb_attribute(name, fields, *options)
+      def jsonb_attribute(name, fields, *)
         attribute(name, { String => Object }, default: {})
 
         fields.each do |f, type|
-          attribute f, type, *options
+          attribute(f, type, *)
           define_method f do
             field = public_send(name) || {}
             field[f.to_s] || field[f.to_sym]

data/lib/decidim/manifest_messages.rb

@@ -16,8 +16,8 @@ module Decidim
       @store[key] = block
     end
 
-    def render(key, context = nil, **extra)
-      context.instance_exec(**extra, &@store[key]) if @store[key]
+    def render(key, context = nil, **)
+      context.instance_exec(**, &@store[key]) if @store[key]
     end
   end
 end

data/lib/decidim/map/autocomplete.rb

@@ -42,7 +42,6 @@ module Decidim
           @autocomplete_utility ||= Decidim::Map.autocomplete(
             organization: @template.current_organization
           )
-
           return text_field(attribute, options) unless @autocomplete_utility
 
           # Decidim::Map::Autocomplete::Builder

data/lib/decidim/organization_settings.rb

@@ -79,7 +79,7 @@ module Decidim
       #   Decidim.organization_settings(org).target_config_accessor
       #   #=> returns the organization specific setting
       #
-      #   Decidim.organization_settings(model_beloging_to_org).target_config_accessor
+      #   Decidim.organization_settings(model_belonging_to_org).target_config_accessor
       #   #=> returns the organization specific setting for model's organization
       #
       #   Decidim.organization_settings(nil).target_config_accessor
@@ -104,9 +104,9 @@ module Decidim
         {
           "upload" => {
             "allowed_file_extensions" => {
-              "default" => %w(jpg jpeg png pdf rtf txt),
-              "admin" => %w(jpg jpeg png pdf doc docx xls xlsx ppt pptx ppx rtf txt odt ott odf otg ods ots csv json md),
-              "image" => %w(jpg jpeg png)
+              "default" => %w(jpg jpeg png webp pdf rtf txt),
+              "admin" => %w(jpg jpeg png webp pdf doc docx xls xlsx ppt pptx ppx rtf txt odt ott odf otg ods ots),
+              "image" => %w(jpg jpeg png webp)
             },
             "allowed_content_types" => {
               "default" => %w(
@@ -125,10 +125,7 @@ module Decidim
                 application/vnd.oasis.opendocument
                 application/pdf
                 application/rtf
-                application/json
-                text/markdown
                 text/plain
-                text/csv
               )
             },
             "maximum_file_size" => {
@@ -193,7 +190,7 @@ module Decidim
 
     private
 
-    # Generates a final settigns configuration struct from the given settings
+    # Generates a final settings configuration struct from the given settings
     # hash. Combines the given defaults with the settings hash.
     #
     # @param hash [Hash] The configurations hash.