decidim-core 0.28.5 → 0.29.0.rc1

data/app/packs/stylesheets/decidim/_tabs_x.scss

@@ -6,13 +6,17 @@
   }
 
   &[aria-expanded="true"],
-  &:hover {
+  &:hover[disabled="false"] {
     @apply text-secondary border-secondary;
 
     svg {
       @apply text-secondary;
     }
   }
+
+  &[disabled] {
+    @apply opacity-50 cursor-not-allowed;
+  }
 }
 
 .tabs-1 {

data/app/packs/stylesheets/decidim/_tooltip.scss

@@ -1,16 +1,6 @@
 [role="tooltip"] {
   @apply absolute bg-black z-10 px-4 py-2 w-max max-w-xs rounded text-left text-white;
 
-  /*
-    NOTE: the calculated value is the sum of the arrow offset position plus the half of the arrow size:
-    - offset position: 20%
-    - arrow size: 16px
-  */
-  --arrow-offset: 20%;
-  --arrow-size: 16px;
-  --arrow-visible-size: var(--arrow-size) * 0.5;
-  --arrow-margin: var(--arrow-visible-size) * 1.4142135623730951; // due to the rotation, the margin is SQRT2 times the visible size
-
   & > * {
     @apply relative z-20;
   }
@@ -51,6 +41,16 @@
     }
   }
 
+  /*
+    NOTE: the calculated value is the sum of the arrow offset position plus the half of the arrow size:
+    - offset position: 20%
+    - arrow size: 16px
+  */
+  --arrow-offset: 20%;
+  --arrow-size: 16px;
+  --arrow-visible-size: var(--arrow-size) * 0.5;
+  --arrow-margin: var(--arrow-visible-size) * 1.4142135623730951; // due to the rotation, the margin is SQRT2 times the visible size
+
   &.top {
     @apply -translate-x-[calc(100%-var(--arrow-offset))] -translate-y-[calc(100%+var(--arrow-margin))] before:content-[''] before:absolute before:-z-10 before:right-[calc(var(--arrow-offset)-var(--arrow-visible-size))] before:-bottom-[var(--arrow-visible-size)] before:w-[var(--arrow-size)] before:h-[var(--arrow-size)] before:rotate-45 before:bg-black before:rounded-br;
   }

data/app/packs/stylesheets/decidim/application.scss

@@ -57,8 +57,12 @@
   @import "stylesheets/decidim/_toggle_switch.scss";
   @import "stylesheets/decidim/_hero.scss";
   @import "stylesheets/decidim/_actions.scss";
+  @import "stylesheets/decidim/_emoji.scss";
 }
 
+@import "stylesheets/decidim/vendor/datepicker_light.scss";
+@import "stylesheets/decidim/datepicker.scss";
+
 // On the other hand, the following styles match with specific routes
 @import "stylesheets/decidim/_header.scss";
 @import "stylesheets/decidim/_footer.scss";

data/app/packs/stylesheets/decidim/editor.scss

@@ -21,7 +21,7 @@
 }
 
 .editor-container {
-  @apply editor-props editor-suggestions-props flex flex-col mt-4 border editor-border;
+  @apply editor-props editor-suggestions-props flex flex-col mb-6 border editor-border;
 
   &.editor-disabled {
     .editor-input .ProseMirror {

data/app/packs/stylesheets/decidim/legacy/conference-diploma.scss

@@ -37,6 +37,7 @@
 }
 
 .conference-diploma .diploma__logo {
+  border: 1px solid #333;
   padding: 2rem;
 }
 
@@ -46,12 +47,10 @@
     max-height: 100%;
     max-width: 100%;
     margin: 0;
-    padding-top: 10%;
   }
 
   .conference-diploma .diploma__border {
     margin: 0;
-    margin-top: 15%;
     -moz-border-image: url("../images/decidim/pattern.png") 20 repeat;
     -webkit-border-image: url("../images/decidim/pattern.png") 20 repeat;
     -o-border-image: url("../images/decidim/pattern.png") 20 repeat;

data/app/packs/stylesheets/decidim/legacy/leaflet.scss

@@ -43,7 +43,7 @@
   display: block;
 }
 
-/* .leaflet-container svg: reset svg max-width decleration shipped in Joomla! (joomla.org) 3.x */
+/* .leaflet-container svg: reset svg max-width declaration shipped in Joomla! (joomla.org) 3.x */
 
 /* .leaflet-container img: map is broken in FF if you have max-width: 100% on tiles */
 .leaflet-container .leaflet-overlay-pane svg {

data/app/packs/stylesheets/decidim/vendor/_datepicker_light.scss

@@ -0,0 +1,228 @@
+// Extracted from wc-datepicker
+// https://github.com/Sqrrl/wc-datepicker
+// Copyright @Sqrrl (c) 2022 - MIT License
+
+.sc-wc-datepicker-h,
+.sc-wc-datepicker-h *,
+.sc-wc-datepicker-h *::before,
+.sc-wc-datepicker-h *::after {
+  margin: 0;
+  padding: 0;
+  box-sizing: border-box;
+}
+
+.sc-wc-datepicker-h {
+  display: inline-flex;
+}
+
+.wc-datepicker {
+  display: block;
+  width: min-content;
+  min-width: 17rem;
+  max-width: 24rem;
+  border: 0.0625rem solid #f2f3f5;
+  color: #111;
+  background-color: #fff;
+  font-family: ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont,
+    "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif,
+    "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
+  font-size: 1rem;
+  font-weight: 400;
+  line-height: 1.5;
+}
+
+.wc-datepicker--disabled *:disabled {
+  opacity: 0.5;
+  cursor: default;
+}
+
+.wc-datepicker--disabled .wc-datepicker__weekday {
+  color: #767676;
+}
+
+.wc-datepicker--disabled .wc-datepicker__date:focus > * {
+  outline: none;
+}
+
+.wc-datepicker--disabled .wc-datepicker__date {
+  cursor: default;
+  opacity: 0.5;
+}
+
+.wc-datepicker--disabled .wc-datepicker__date:hover > * {
+  background-color: transparent;
+}
+
+.wc-datepicker--disabled .wc-datepicker__date--in-range:hover > * {
+  background-color: #f2f3f5;
+}
+
+.wc-datepicker--disabled .wc-datepicker__date--selected:hover > * {
+  color: #fff;
+  background-color: #00f;
+}
+
+.wc-datepicker__header {
+  display: flex;
+  padding: 0.75rem;
+  align-items: center;
+  gap: 0.5rem;
+}
+
+.wc-datepicker__current-month {
+  display: flex;
+  flex-grow: 1;
+  gap: 0.5rem;
+}
+
+.wc-datepicker__month-select,
+.wc-datepicker__year-select {
+  display: flex;
+  height: 2rem;
+  padding-right: 0.5rem;
+  padding-left: 0.5rem;
+  align-items: center;
+  border: none;
+  border-radius: 0.25rem;
+  color: #111;
+  background: #f2f3f5;
+  font: inherit;
+  line-height: 1.125;
+}
+
+.wc-datepicker__month-select {
+  flex-grow: 1;
+  cursor: pointer;
+  appearance: none;
+}
+
+.wc-datepicker__year-select {
+  max-width: 5rem;
+}
+
+.wc-datepicker__previous-month-button,
+.wc-datepicker__next-month-button,
+.wc-datepicker__previous-year-button,
+.wc-datepicker__next-year-button {
+  display: inline-flex;
+  width: 2rem;
+  height: 2rem;
+  padding: 0.375rem;
+  flex-shrink: 0;
+  justify-content: center;
+  align-items: center;
+  border: none;
+  border-radius: 0.25rem;
+  color: #111;
+  background-color: transparent;
+  background-color: #f2f3f5;
+  cursor: pointer;
+}
+
+.wc-datepicker__body {
+  padding-right: 0.75rem;
+  padding-bottom: 0.75rem;
+  padding-left: 0.75rem;
+}
+
+.wc-datepicker__calendar {
+  width: 100%;
+  table-layout: fixed;
+  border-collapse: collapse;
+}
+
+.wc-datepicker__weekday > span {
+  display: flex;
+  padding: 0.125rem;
+  justify-content: center;
+  align-items: center;
+  font-weight: 600;
+  aspect-ratio: 1;
+}
+
+.wc-datepicker__date {
+  padding: 0.125rem;
+  text-align: center;
+  cursor: pointer;
+}
+
+.wc-datepicker__date:focus {
+  outline: none;
+}
+
+.wc-datepicker__date:focus > * {
+  outline: 0.125rem solid #00f;
+}
+
+.wc-datepicker__date:hover > * {
+  background-color: #f2f3f5;
+}
+
+.wc-datepicker__date > * {
+  display: flex;
+  justify-content: center;
+  align-items: center;
+  border-radius: 0.25rem;
+  aspect-ratio: 1;
+}
+
+.wc-datepicker__date--today > * {
+  font-weight: 700;
+  font-style: normal;
+}
+
+.wc-datepicker__date--in-range > * {
+  background-color: #f2f3f5;
+}
+
+.wc-datepicker__date--selected > *,
+.wc-datepicker__date--selected:hover > * {
+  color: #fff;
+  background-color: #00f;
+  font-weight: 500;
+}
+
+.wc-datepicker__date--disabled {
+  color: #767676;
+  cursor: default;
+}
+
+.wc-datepicker__date--disabled:not(.wc-datepicker__date--selected):not(
+    .wc-datepicker__date--in-range
+  ):hover
+  > * {
+  background-color: transparent;
+}
+
+.wc-datepicker__date--disabled.wc-datepicker__date--in-range:not(
+    .wc-datepicker__date--selected
+  ):not(.wc-datepicker__date--in-range)
+  > * {
+  background-color: transparent;
+}
+
+.wc-datepicker__footer {
+  display: flex;
+  padding-right: 0.75rem;
+  padding-bottom: 0.75rem;
+  padding-left: 0.75rem;
+  align-items: center;
+  gap: 0.5rem;
+}
+
+.wc-datepicker__clear-button,
+.wc-datepicker__today-button {
+  display: inline-flex;
+  height: 2rem;
+  padding-right: 0.5rem;
+  padding-left: 0.5rem;
+  justify-content: center;
+  align-items: center;
+  border: none;
+  border-radius: 0.25rem;
+  color: #111;
+  background-color: #f2f3f5;
+  font: inherit;
+  line-height: 1;
+  cursor: pointer;
+}

data/app/permissions/decidim/default_permissions.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 module Decidim
-  # Default permissions class for all components and spaces. It disauthorizes all
+  # Default permissions class for all components and spaces. It deauthorizes all
   # actions by any kind of user. Also works as a default implementation so other
-  # components can inherit from it and get some cenvenience methods.
+  # components can inherit from it and get some convenience methods.
   class DefaultPermissions
     def initialize(user, permission_action, context = {})
       @user = user

data/app/presenters/decidim/admin_log/organization_presenter.rb

@@ -15,7 +15,7 @@ module Decidim
       private
 
       def diff_fields_mapping
-        return { external_domain_whitelist: :string } if action == "update_external_domain"
+        return { external_domain_allowlist: :string } if action == "update_external_domain"
 
         settings_attributes_mapping
           .merge(omnipresent_banner_attributes_mapping)

data/app/presenters/decidim/admin_log/static_page_presenter.rb

@@ -24,7 +24,7 @@ module Decidim
 
       # Private: Caches the object that will be responsible of presenting the static page.
       # Overwrites the method so that we can use a custom presenter to show the correct
-      # path for ther page.
+      # path for their page.
       #
       # Returns an object that responds to `present`.
       def resource_presenter

data/app/presenters/decidim/attachment_presenter.rb

@@ -6,7 +6,7 @@ module Decidim
   #
   class AttachmentPresenter < SimpleDelegator
     def attachment_file_url
-      attachment.attached_uploader(:file).url
+      attachment.attached_uploader(:file).url(host: attached_to.organization.host)
     end
 
     def attachment

data/app/presenters/decidim/authorization_transfer_presenter.rb

@@ -37,7 +37,7 @@ module Decidim
     # Returns an array of the translated record counts containing only the
     # texts to be displayed for the user.
     #
-    # @return [Array<String>] The translated records names with their coutns.
+    # @return [Array<String>] The translated records names with their counts.
     def translated_record_texts
       translated_record_counts.values
     end

data/app/presenters/decidim/component_attachment_collection_presenter.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+module Decidim
+  #
+  # Decorator attachments of a component acting as an attachment collection
+  #
+  class ComponentAttachmentCollectionPresenter < SimpleDelegator
+    include Decidim::TranslatableAttributes
+
+    def initialize(resource, opts = {})
+      super(resource)
+
+      @include_component_name = opts[:include_component_name]
+    end
+
+    def attachments
+      @attachments ||= if [resource_model_name, resource_table_name].all?(&:present?)
+                         base_query = Decidim::Attachment.joins(resource_join.join_sources)
+                                                         .where(resource_table_name => { decidim_component_id: __getobj__.id })
+                         if resource_model&.include?(Decidim::Publicable)
+                           base_query.where.not(resource_table_name => { published_at: nil })
+                         else
+                           base_query
+                         end
+                       else
+                         Decidim::Attachment.none
+                       end
+    end
+
+    def documents
+      @documents ||= attachments.with_attached_file.order(:weight).select(&:document?)
+    end
+
+    def documents_visible_for(user)
+      return documents unless resource_model.respond_to?(:visible_for)
+
+      attachments.merge(resource_model.visible_for(user)).with_attached_file.order(:weight).select(&:document?)
+    end
+
+    def unused?
+      documents.blank?
+    end
+
+    def id
+      "component-#{__getobj__.id}"
+    end
+
+    def name
+      base_name = I18n.t(manifest_name, scope: "decidim.application.documents.component_documents")
+
+      return base_name unless @include_component_name
+
+      "#{base_name} - #{translated_attribute(__getobj__.name)}"
+    end
+
+    def description; end
+
+    private
+
+    def resource_join
+      resource_table = Arel::Table.new(resource_table_name)
+      attachments_table = Decidim::Attachment.arel_table
+      attachments_table.join(resource_table).on(
+        resource_table[:id].eq(attachments_table[:attached_to_id]),
+        attachments_table[:attached_to_type].eq(resource_model_name)
+      )
+    end
+
+    def resource_model_name
+      @resource_model_name ||= Decidim.resource_registry.find(manifest_name)&.model_class_name
+    end
+
+    def resource_model
+      @resource_model ||= resource_model_name&.safe_constantize
+    end
+
+    def resource_table_name
+      @resource_table_name ||= resource_model&.table_name
+    end
+  end
+end

data/app/presenters/decidim/footer_menu_presenter.rb

@@ -4,7 +4,7 @@ module Decidim
   # A presenter to render footer menu
   class FooterMenuPresenter < MenuPresenter
     def render
-      content_tag(:nav, role: "navigation", "aria-label" => @options[:label]) do
+      content_tag(:nav, :role => "navigation", "aria-label" => @options[:label]) do
         safe_join([content_tag(:h2, @options[:label], class: "h5 mb-4"), render_menu])
       end
     end

data/app/presenters/decidim/home_stats_presenter.rb

@@ -45,7 +45,7 @@ module Decidim
       stats = {}
       Decidim.component_manifests.flat_map do |component|
         component
-          .stats.except([:supports_count])
+          .stats.except([:votes_count])
           .filter(conditions)
           .with_context(published_components)
           .each do |name, data|

data/app/presenters/decidim/menu_item_presenter.rb

@@ -26,7 +26,7 @@ module Decidim
     delegate :content_tag, :safe_join, :link_to, :active_link_to_class, :is_active_link?, :icon, to: :@view
 
     def render
-      content_tag :li, role: :menuitem, class: link_wrapper_classes do
+      content_tag :li, class: link_wrapper_classes do
         output = if url == "#"
                    [content_tag(:span, composed_label, class: "sidebar-menu__item-disabled")]
                  else

data/app/presenters/decidim/organization_presenter.rb

@@ -4,7 +4,7 @@ module Decidim
   # A general presenter to render organization logic to build a manifest
   class OrganizationPresenter < SimpleDelegator
     def html_name
-      name.html_safe
+      translated_attribute(name).html_safe
     end
 
     def translated_description

data/app/queries/decidim/last_activity.rb

@@ -55,25 +55,14 @@ module Decidim
         klass = manifest.model_class_name.constantize
 
         condition = if klass.include?(Decidim::HasPrivateUsers)
-                      Arel.sql(
-                        <<~SQL.squish
-                          (
-                            decidim_action_logs.participatory_space_type = '#{manifest.model_class_name}' AND#{" "}
-                            decidim_action_logs.participatory_space_id IN (#{Arel.sql(klass.visible_for(current_user).select(:id).to_sql)})
-                          ) OR#{" "}
-                          (
-                            decidim_action_logs.resource_type = '#{manifest.model_class_name}' AND#{" "}
-                            decidim_action_logs.resource_id IN (#{Arel.sql(klass.visible_for(current_user).select(:id).to_sql)})
-                          )
-                        SQL
-                      ).to_s
-                    else
                       Arel.sql(
                         [
-                          "decidim_action_logs.resource_type = '#{manifest.model_class_name}'",
-                          "decidim_action_logs.participatory_space_type = '#{manifest.model_class_name}'"
-                        ].join(" OR ")
+                          "decidim_action_logs.participatory_space_type = '#{manifest.model_class_name}'",
+                          "decidim_action_logs.participatory_space_id IN (#{Arel.sql(klass.visible_for(current_user).select(:id).to_sql)})"
+                        ].join(" AND ")
                       ).to_s
+                    else
+                      Arel.sql("decidim_action_logs.participatory_space_type = '#{manifest.model_class_name}'").to_s
                     end
 
         conditions << "(#{condition})"

data/app/queries/decidim/metric_measure.rb

@@ -4,7 +4,7 @@ module Decidim
   # This class executes some measures related to Metrics, and return its results
   #
   #  - day: Date object
-  #  - resource: Object used to make measurements. Object class is dependant within each measure
+  #  - resource: Object used to make measurements. Object class is dependent within each measure
   class MetricMeasure
     def initialize(day, resource)
       @day = day.try(:to_date) || Time.zone.yesterday

data/app/queries/decidim/public_activities.rb

@@ -14,7 +14,7 @@ module Decidim
   #
   # :resource_name - an optional name for a resource for searching only that
   #    type of resources.
-  # :user - an optional `Decidim::User` that performed the activites
+  # :user - an optional `Decidim::User` that performed the activities
   # :current_user - an optional `Decidim::User` for defining whether to show the
   #   private log entries that relate to the current user.
   # :follows - a collection of `Decidim::Follow` resources. It will return any

data/app/queries/decidim/user_groups/admin_memberships.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module UserGroups
-    # Use this class to find the the admins of the given user group with the
+    # Use this class to find the admins of the given user group with the
     # "admin" role. It returns memberships.
     class AdminMemberships < Decidim::Query
       # Syntactic sugar to initialize the class and return the queried objects.

data/app/queries/decidim/user_groups/member_memberships.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module UserGroups
-    # Use this class to find the the members of the given user group with the
+    # Use this class to find the members of the given user group with the
     # "member" role. It returns memberships.
     class MemberMemberships < Decidim::Query
       # Syntactic sugar to initialize the class and return the queried objects.

data/app/services/decidim/action_logger.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   # Use this class to log actions by any user. You probably should not
-  # use this class dfirectly, but rather use `Decidim.traceability` instead.
+  # use this class directly, but rather use `Decidim.traceability` instead.
   # Check the docs on `Decidim::Traceability` for more info.
   #
   # Usage:
@@ -14,7 +14,7 @@ module Decidim
     #
     # action - a String representing the name of the action
     # user - the Decidim::User that performed the action
-    # resource - the resource onn which the action was performed
+    # resource - the resource on which the action was performed
     # version_id - the ID of the `PaperTrail::Version` that was created on that action
     # resource_extra - a Hash with resource_extra info to be recorded
     #
@@ -27,7 +27,7 @@ module Decidim
     #
     # action - a String representing the name of the action
     # user - the Decidim::User that performed the action
-    # resource - the resource onn which the action was performed
+    # resource - the resource on which the action was performed
     # version_id - the ID of the `PaperTrail::Version` that was created on that action
     # resource_extra - a Hash with resource_extra info to be recorded
     def initialize(action, user, resource, version_id = nil, resource_extra = {})

data/app/services/decidim/base_diff_renderer.rb

@@ -41,7 +41,7 @@ module Decidim
     end
 
     def parse_i18n_changeset(attribute, values, type, diff)
-      (values.last.keys - ["machine_translations"]).each do |locale, _value|
+      values.last.keys.each do |locale, _value|
         first_value = values.first.try(:[], locale)
         last_value = values.last.try(:[], locale)
         next if first_value == last_value
@@ -56,27 +56,6 @@ module Decidim
           }
         )
       end
-
-      return diff unless values.last.has_key?("machine_translations")
-
-      values.last.fetch("machine_translations").each_key do |locale, _value|
-        next unless I18n.available_locales.include?(locale.to_sym)
-
-        first_value = values.first.try(:[], "machine_translations").try(:[], locale)
-        last_value = values.last.try(:[], "machine_translations").try(:[], locale)
-
-        attribute_locale = :"#{attribute}_machine_translations_#{locale}"
-
-        diff.update(
-          attribute_locale => {
-            type:,
-            label: generate_i18n_label(attribute, locale, "decidim.machine_translations.automatic"),
-            old_value: first_value,
-            new_value: last_value
-          }
-        )
-      end
-
       diff
     end
 
@@ -129,8 +108,7 @@ module Decidim
     end
 
     # Returns a String.
-    # i18n-tasks-use t("decidim.machine_translations.automatic")
-    def generate_i18n_label(attribute, locale, postfix = "")
+    def generate_i18n_label(attribute, locale)
       label = I18n.t(attribute, scope: i18n_scope)
       locale_name = if I18n.available_locales.include?(locale.to_sym)
                       I18n.t("locale.name", locale:)
@@ -138,8 +116,6 @@ module Decidim
                       locale
                     end
 
-      locale_name = I18n.t(postfix, locale_name:, locale:) if postfix.present?
-
       "#{label} (#{locale_name})"
     end