decidim-core 0.21.0 → 0.22.0

data/lib/decidim/core/test/shared_examples/admin_resource_gallery_examples.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+shared_examples "admin creates resource gallery" do
+  context "when uploading images", processing_uploads_for: Decidim::AttachmentUploader do
+    let(:uploaded_photos) do
+      [
+        Decidim::Dev.test_file("city.jpeg", "image/jpeg"),
+        Decidim::Dev.test_file("city2.jpeg", "image/jpeg")
+      ]
+    end
+    let(:photos) { [] }
+
+    it "creates a gallery for the resource" do
+      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_photos.count)
+
+      resource = resource_class.last
+      expect(resource.photos.count).to eq(2)
+      last_attachment = Decidim::Attachment.last
+      expect(last_attachment.attached_to).to eq(resource)
+    end
+
+    context "when gallery is left blank" do
+      let(:uploaded_photos) { [] }
+
+      it "broadcasts ok" do
+        expect { command.call }.to broadcast(:ok)
+      end
+    end
+  end
+end
+
+shared_examples "admin manages resource gallery" do
+  context "when managing images", processing_uploads_for: Decidim::AttachmentUploader do
+    let(:uploaded_photos) do
+      [
+        Decidim::Dev.test_file("city.jpeg", "image/jpeg"),
+        Decidim::Dev.test_file("city2.jpeg", "image/jpeg")
+      ]
+    end
+    let(:photos) { [] }
+
+    it "creates a gallery for the resource" do
+      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_photos.count)
+      resource = resource_class.last
+      expect(resource.photos.count).to eq(2)
+      last_attachment = Decidim::Attachment.last
+      expect(last_attachment.attached_to).to eq(resource)
+    end
+
+    context "when gallery is left blank" do
+      let(:uploaded_photos) { [] }
+
+      it "broadcasts ok" do
+        expect { command.call }.to broadcast(:ok)
+      end
+    end
+
+    context "when images are removed" do
+      let!(:image1) { create(:attachment, :with_image, attached_to: resource) }
+      let!(:image2) { create(:attachment, :with_image, attached_to: resource) }
+      let(:uploaded_photos) { [] }
+      let(:current_photos) { [image1.id.to_s] }
+
+      it "to decrease the number of photos in the gallery" do
+        expect(resource.attachments.count).to eq(2)
+        expect(resource.photos.count).to eq(2)
+        expect { command.call }.to change(Decidim::Attachment, :count).by(-1)
+        expect(resource.attachments.count).to eq(1)
+        expect(resource.photos.count).to eq(1)
+      end
+    end
+  end
+end
+
+shared_examples "admin destroys resource gallery" do
+  it "destroys the attached image" do
+    expect { command.call }.to change(Decidim::Attachment, :count).by(-1)
+  end
+end

data/lib/decidim/core/test/shared_examples/back_to_list_button_examples.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+shared_examples "going back to list button" do
+  it "shows the back button" do
+    expect(page).to have_link(href: main_component_path(component) + manifest_name)
+  end
+
+  context "when clicking the back button" do
+    before do
+      click_link(href: main_component_path(component) + manifest_name)
+    end
+
+    it "redirect the user to component index" do
+      expect(page).to have_current_path(main_component_path(component) + manifest_name)
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -13,7 +13,7 @@ shared_examples "comments" do
     visit resource_path
 
     expect(page).to have_selector("#comments")
-    expect(page).to have_selector("article.comment", count: comments.length)
+    expect(page).to have_selector(".comment", count: comments.length)
 
     within "#comments" do
       comments.each do |comment|
@@ -34,7 +34,13 @@ shared_examples "comments" do
     expect(page).to have_css(".comment", minimum: 1)
     page.find(".order-by .dropdown.menu .is-dropdown-submenu-parent").hover
 
-    click_link "Best rated"
+    within ".comments" do
+      within ".order-by__dropdown" do
+        click_link "Older" # Opens the dropdown
+        click_link "Best rated"
+      end
+    end
+
     expect(page).to have_css(".comments > div:nth-child(2)", text: "Most Rated Comment")
   end
 
@@ -229,6 +235,15 @@ shared_examples "comments" do
           expect(page).not_to have_selector(".tribute-container")
         end
       end
+
+      context "when mentioning a group" do
+        let!(:mentioned_group) { create(:user_group, :confirmed, organization: organization) }
+        let(:content) { "A confirmed user group mention: @#{mentioned_group.nickname}" }
+
+        it "shows the tribute container" do
+          expect(page).to have_selector(".tribute-container")
+        end
+      end
     end
 
     describe "mentions", :slow do

data/lib/decidim/core/test/shared_examples/edit_link_shared_examples.rb

@@ -1,10 +1,14 @@
 # frozen_string_literal: true
 
+# When using these shared examples, make sure there are no prior requests within
+# the same group of examples where this is included. Otherwise you may end up
+# in race conditions that cause these to fail as explained at:
+# https://github.com/decidim/decidim/pull/6161
 shared_examples "editable content for admins" do
   describe "edit link" do
     before do
       relogin_as user
-      visit current_path
+      visit target_path
     end
 
     context "when I'm an admin user" do

data/lib/decidim/core/test/shared_examples/endorsable_interface_examples.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "endorsable interface" do
+  describe "endorsementsCount" do
+    let(:query) { "{ endorsementsCount }" }
+
+    it "returns the amount of endorsements for this query" do
+      expect(response["endorsementsCount"]).to eq(model.endorsements.count)
+    end
+  end
+
+  describe "endorsements" do
+    let(:query) { "{ endorsements { name } }" }
+
+    it "returns the endorsements this query has received" do
+      endorsement_names = response["endorsements"].map { |endorsement| endorsement["name"] }
+      expect(endorsement_names).to include(*model.endorsements.map(&:author).map(&:name))
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/endorsements_controller_shared_context.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "when in a resource" do
+  routes { Decidim::Core::Engine.routes }
+
+  let(:resource) { create(:dummy_resource, component: component) }
+  let(:user) { create(:user, :confirmed, organization: component.organization) }
+  let(:params) do
+    {
+      id: resource.to_gid.to_param,
+      component_id: component.id,
+      participatory_process_slug: component.participatory_space.slug
+    }
+  end
+
+  before do
+    request.env["decidim.current_organization"] = component.organization
+    request.env["decidim.current_component"] = component
+    request.env["decidim.current_participatory_space"] = component.participatory_space
+    sign_in user
+  end
+end

data/lib/decidim/core/test/shared_examples/follows_examples.rb

@@ -44,7 +44,7 @@ shared_examples "follows" do
       it "makes the user follow the followable" do
         visit resource_locator(followable).path
         expect do
-          click_button "Already following the participatory space"
+          click_button "Already following #{translated(followable.participatory_space.title)}"
           expect(page).to have_content "Stop following"
         end.to change(Decidim::Follow, :count).by(1)
       end

data/lib/decidim/core/test/shared_examples/input_sort_examples.rb

@@ -103,3 +103,24 @@ shared_examples_for "connection has input sort" do |connection, field|
     end
   end
 end
+
+# This example requires a let!(:most_endorsed)
+shared_examples_for "connection has endorsement_count sort" do |connection|
+  describe "ASC" do
+    let(:query) { %[{ #{connection}(order: {endorsementCount: "ASC"}) { edges { node { id } } } }] }
+
+    it "returns the most endorsed last" do
+      expect(response[connection]["edges"].count).to eq(4)
+      expect(response[connection]["edges"].last["node"]["id"]).to eq(most_endorsed.id.to_s)
+    end
+  end
+
+  describe "DESC" do
+    let(:query) { %[{ #{connection}(order: {endorsementCount: "DESC"}) { edges { node { id } } } }] }
+
+    it "returns the most endorsed first" do
+      expect(response[connection]["edges"].count).to eq(4)
+      expect(response[connection]["edges"].first["node"]["id"]).to eq(most_endorsed.id.to_s)
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/logo_email.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples "email with logo" do
+  context "when organization has a logo" do
+    let(:organization_logo) { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
+    let(:organization) { create(:organization, logo: organization_logo) }
+    let(:mail) { described_class.event_received(event, event_class_name, resource, user, :follower, extra) }
+
+    it "includes organization logo" do
+      expect(mail.body).to include(organization.logo.medium.url)
+    end
+
+    it "includes organization logo with full link" do
+      expect(mail.body).to include("alt=\"#{organization.name}\"")
+      expect(mail.body).to match(%r{http[s]{0,1}:\/\/#{organization.host}#{organization.logo.medium.url}})
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/metric_manage_shared_context.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "when managing metrics" do
+  def generate_metric_registry(date = nil)
+    metric = described_class.for(date, organization)
+    metric.save
+    Decidim::Metric.all.load
+  end
+end

data/lib/decidim/core/test/shared_examples/permissions.rb

@@ -0,0 +1,143 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "general conversation permissions" do
+  let(:context) { { conversation: conversation } }
+  let(:another_user) { create :user }
+  let(:group) { create :user_group }
+
+  context "when the originator of the conversation is the user" do
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: user,
+        interlocutors: [another_user],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq true }
+  end
+
+  context "when the user is an interlocutor" do
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: another_user,
+        interlocutors: [user],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq true }
+  end
+
+  context "when the user is not in the conversation" do
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: another_user,
+        interlocutors: [create(:user)],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq false }
+  end
+
+  context "when the interlocutor is specified in the context" do
+    let(:context) { { conversation: conversation, interlocutor: interlocutor } }
+    let(:originator) { interlocutor }
+    let(:interlocutor) { create :user }
+
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: originator,
+        interlocutors: [another_user],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq true }
+
+    context "and accessing user's conversation" do
+      let(:originator) { user }
+
+      it { is_expected.to eq false }
+    end
+  end
+
+  context "when the originator of the conversation is a group" do
+    let(:context) { { conversation: conversation, interlocutor: group } }
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: group,
+        interlocutors: [another_user],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq true }
+  end
+
+  context "when the group is an interlocutor" do
+    let(:context) { { conversation: conversation, interlocutor: group } }
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: another_user,
+        interlocutors: [group],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq true }
+
+    context "and group is not specified as interlocutor" do
+      let(:context) { { conversation: conversation } }
+
+      it { is_expected.to eq false }
+    end
+  end
+
+  context "when the group is not in the conversation" do
+    let(:context) { { conversation: conversation, interlocutor: group } }
+    let!(:conversation) do
+      Decidim::Messaging::Conversation.start!(
+        originator: another_user,
+        interlocutors: [create(:user_group)],
+        body: "who wants apples?"
+      )
+    end
+
+    it { is_expected.to eq false }
+  end
+end
+
+shared_examples_for "restricted conversation permissions" do
+  let(:context) { { conversation: conversation } }
+  let(:user) { create :user }
+  let(:interlocutor) { create :user, organization: user.organization }
+  let!(:conversation) do
+    Decidim::Messaging::Conversation.start(
+      originator: user,
+      interlocutors: [interlocutor],
+      body: "who wants apples?"
+    )
+  end
+
+  context "when interlocutor does not restrict communications" do
+    it { is_expected.to eq true }
+  end
+
+  context "when interlocutor restricts communications" do
+    let(:interlocutor) { create :user, direct_message_types: "followed-only" }
+
+    context "and does not follow the user" do
+      it { is_expected.to eq false }
+    end
+
+    context "and follows the user" do
+      let!(:follow) { create :follow, user: interlocutor, followable: user }
+
+      it { is_expected.to eq true }
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/reports_examples.rb

@@ -5,11 +5,11 @@ shared_examples "reports" do
     it "gives the option to sign in" do
       visit reportable_path
 
-      expect(page).to have_no_css("body.is-reveal-open")
+      expect(page).to have_no_css("html.is-reveal-open")
 
       click_button "Report"
 
-      expect(page).to have_css("body.is-reveal-open")
+      expect(page).to have_css("html.is-reveal-open")
     end
   end
 
@@ -28,7 +28,7 @@ shared_examples "reports" do
           page.find("button").click
         end
 
-        expect(page).to have_css(".flag-modal", visible: true)
+        expect(page).to have_css(".flag-modal", visible: :visible)
 
         within ".flag-modal" do
           click_button "Report"
@@ -53,7 +53,7 @@ shared_examples "reports" do
           page.find("button").click
         end
 
-        expect(page).to have_css(".flag-modal", visible: true)
+        expect(page).to have_css(".flag-modal", visible: :visible)
 
         expect(page).to have_content "already reported"
       end

data/lib/decidim/core/test/shared_examples/rich_text_editor_examples.rb

@@ -3,7 +3,7 @@
 shared_examples "having a rich text editor" do |css, toolbar|
   it "has a form with a rich text editor" do
     within "form.#{css}" do
-      expect(page).to have_selector("input[toolbar='#{toolbar}']", visible: false)
+      expect(page).to have_selector("div.editor-container[data-toolbar='#{toolbar}']", visible: :all)
     end
   end
 end
@@ -30,7 +30,7 @@ shared_examples "rendering safe content" do |css|
 
   it "sanitizes potentially malicious HTML tags" do
     within css do
-      expect(page).not_to have_selector("script", visible: false)
+      expect(page).not_to have_selector("script", visible: :all)
       expect(page).to have_content("alert('SCRIPT')")
     end
   end
@@ -52,7 +52,7 @@ shared_examples "rendering unsafe content" do |css|
 
   it "strips potentially malicious HTML tags" do
     within css do
-      expect(page).not_to have_selector("script", visible: false)
+      expect(page).not_to have_selector("script", visible: :all)
       expect(page).not_to have_content("alert('SCRIPT')")
     end
   end