decidim-core 0.15.2 → 0.16.0

data/lib/decidim/core/test/shared_examples/amendable/amendment_rejected_event_examples.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+shared_examples "amendment rejected event" do
+  include_context "when a simple event"
+
+  let(:resource) { emendation }
+  let(:event_name) { "decidim.events.amendments.amendment_rejected" }
+
+  it_behaves_like "a simple event"
+
+  let(:amendable_title) { amendable.title }
+  let(:emendation_author_nickname) { "@#{emendation.creator_author.nickname}" }
+  let(:emendation_path) { Decidim::ResourceLocatorPresenter.new(emendation).path }
+  let(:emendation_author_path) { Decidim::UserPresenter.new(emendation.creator_author).profile_path }
+  let(:amendable_path) { Decidim::ResourceLocatorPresenter.new(amendable).path }
+
+  describe "email_subject" do
+    it "is generated correctly" do
+      expect(subject.email_subject).to eq("An amendment rejected for #{amendable_title} from #{emendation_author_nickname}")
+    end
+  end
+
+  describe "email_intro" do
+    it "is generated correctly" do
+      expect(subject.email_intro)
+        .to eq("An emendation has been rejected for #{amendable_title}. You can see it from this page:")
+    end
+  end
+
+  describe "email_outro" do
+    it "is generated correctly" do
+      expect(subject.email_outro)
+        .to eq("You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link.")
+    end
+  end
+
+  describe "notification_title" do
+    it "is generated correctly" do
+      expect(subject.notification_title)
+        .to include("The <a href=\"#{emendation_path}\">emendation</a> created by <a href=\"#{emendation_author_path}\">#{emendation_author_nickname}</a> has been rejected for <a href=\"#{amendable_path}\">#{amendable_title}</a> #{amendable_type}.") # rubocop:disable Metrics/LineLength
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/amendable/create_amendment_examples.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+shared_examples "create amendment" do
+  context "when the form is valid" do
+    it "broadcasts ok" do
+      expect { command.call }.to broadcast(:ok)
+    end
+
+    it "creates an amendment and the emendation" do
+      expect { command.call }
+        .to change(Decidim::Amendment, :count)
+        .by(1)
+        .and change(amendable.resource_manifest.model_class_name.constantize, :count)
+        .by(1)
+    end
+
+    it "traces the action", versioning: true do
+      expect(Decidim.traceability)
+        .to receive(:perform_action!)
+        .with(
+          :create,
+          form.amendable_type.constantize,
+          form.current_user,
+          kind_of(Hash)
+        ).and_call_original
+
+      expect { command.call }.to change(Decidim::ActionLog, :count).by(1)
+    end
+
+    it "notifies the change" do
+      expect(Decidim::EventsManager)
+        .to receive(:publish)
+        .with(
+          event: "decidim.events.amendments.amendment_created",
+          event_class: Decidim::Amendable::AmendmentCreatedEvent,
+          resource: amendable,
+          followers: kind_of(Array),
+          affected_users: kind_of(Array),
+          extra: kind_of(Hash)
+        )
+
+      command.call
+    end
+  end
+
+  context "when the form is invalid" do
+    let(:title) { "Too short" }
+
+    it "broadcasts invalid" do
+      expect { command.call }.to broadcast(:invalid)
+    end
+
+    it "doesn't create an amendment and the emendation" do
+      expect { command.call }
+        .to change(Decidim::Amendment, :count)
+        .by(0)
+        .and change(amendable.resource_manifest.model_class_name.constantize, :count)
+        .by(0)
+    end
+  end
+
+  context "when the emendation doens't change the amendable" do
+    let(:title) { amendable.title }
+    let(:body) { amendable.body }
+
+    it "broadcasts invalid" do
+      expect { command.call }.to broadcast(:invalid)
+    end
+
+    it "doesn't create an amendment and the emendation" do
+      expect { command.call }
+        .to change(Decidim::Amendment, :count)
+        .by(0)
+        .and change(amendable.resource_manifest.model_class_name.constantize, :count)
+        .by(0)
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/amendable/promote_amendment_examples.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+shared_examples "promote amendment" do
+  describe "when the form is valid" do
+    it "broadcasts ok" do
+      expect { command.call }.to broadcast(:ok)
+    end
+
+    it "creates an amendable type resource" do
+      expect { command.call }
+        .to change(amendable.resource_manifest.model_class_name.constantize, :count)
+        .by(1)
+    end
+
+    it "traces the action", versioning: true do
+      expect(Decidim.traceability)
+        .to receive(:perform_action!)
+        .with(
+          "promote",
+          emendation.resource_manifest.model_class_name.constantize,
+          emendation.creator_author,
+          visibility: "public-only",
+          promoted_from: emendation.id
+        ).and_call_original
+
+      expect { command.call }.to change(Decidim::ActionLog, :count).by(1)
+    end
+
+    it "notifies the change" do
+      expect(Decidim::EventsManager)
+        .to receive(:publish)
+        .with(
+          event: "decidim.events.amendments.amendment_promoted",
+          event_class: Decidim::Amendable::EmendationPromotedEvent,
+          resource: emendation,
+          affected_users: kind_of(Array),
+          followers: kind_of(Array)
+        )
+
+      command.call
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/amendable/reject_amendment_examples.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+shared_examples "reject amendment" do
+  describe "when the form is valid" do
+    it "broadcasts ok" do
+      expect { command.call }.to broadcast(:ok)
+    end
+
+    it "changes the emendation state to rejected" do
+      expect { command.call }.to change(emendation, :state)
+        .from("evaluating").to("rejected")
+    end
+
+    it "traces the action", versioning: true do
+      expect(Decidim.traceability)
+        .to receive(:update!)
+        .with(
+          amendment,
+          amendable.creator_author,
+          { state: "rejected" },
+          visibility: "public-only"
+        ).and_call_original
+
+      expect { command.call }.to change(Decidim::ActionLog, :count).by(1)
+    end
+
+    it "notifies the change" do
+      expect(Decidim::EventsManager)
+        .to receive(:publish)
+        .with(
+          event: "decidim.events.amendments.amendment_rejected",
+          event_class: Decidim::Amendable::AmendmentRejectedEvent,
+          resource: emendation,
+          affected_users: kind_of(Array),
+          followers: kind_of(Array)
+        )
+
+      command.call
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/amendable/withdraw_amendment_examples.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+shared_examples "withdraw amendment" do
+  context "when current user IS the author of the amendment" do
+    context "and the amendment has no supports" do
+      it "withdraws the amendment" do
+        expect do
+          expect { command.call }.to broadcast(:ok)
+        end.to change { Decidim::Proposals::Proposal.count }.by(0)
+        expect(emendation.amendment.state).to eq("withdrawn")
+        expect(emendation.state).to eq("withdrawn")
+      end
+    end
+
+    context "and the amendment HAS some supports" do
+      before do
+        emendation.votes.create!(author: current_user)
+      end
+
+      it "is not able to withdraw the amendment" do
+        expect do
+          expect { command.call }.to broadcast(:invalid)
+        end.to change { Decidim::Proposals::Proposal.count }.by(0)
+        expect(emendation.amendment.state).not_to eq("withdrawn")
+        expect(emendation.state).not_to eq("withdrawn")
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/has_contextual_help.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+shared_examples "shows contextual help" do
+  before do
+    Decidim::ContextualHelpSection.set_content(
+      organization,
+      manifest_name,
+      en: "<p>Some relevant help</p>"
+    )
+  end
+
+  it "shows the contextual help on the root path on first visit, hides it on subsequent ones" do
+    visit index_path
+
+    within ".floating-helper-container" do
+      expect(page).to have_content("Some relevant help")
+      find(".floating-helper__content-close").click
+    end
+
+    visit current_path
+
+    expect(page).to have_no_content("Some relevant help")
+
+    find(".floating-helper__text").click
+
+    within ".floating-helper__content" do
+      expect(page).to have_css("p", text: "Some relevant help")
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/resourceable.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "resourceable" do
+  describe "resource_title" do
+    it "is defined" do
+      expect(subject.resource_title).to be_present
+    end
+  end
+
+  describe "resource_description" do
+    it "is defined" do
+      expect(subject.resource_title).to be_present
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/searchable_results_examples.rb

@@ -21,7 +21,7 @@ shared_examples "searchable results" do
       expect(page).to have_current_path decidim.search_path, ignore_query: true
       expect(page).to have_content(/results for the search: "#{term}"/i)
       expect(page).to have_selector(".filters__section")
-      expect(page.find("#results-count").text.to_i).to be_positive
+      expect(page.find("#search-count .section-heading").text.to_i).to be_positive
     end
   end
 end

data/lib/decidim/core/test/shared_examples/simple_event.rb

@@ -3,11 +3,14 @@
 require "spec_helper"
 
 shared_context "when a simple event" do
-  subject do
+  subject { event_instance }
+
+  let(:event_instance) do
     described_class.new(
       resource: resource,
       event_name: event_name,
       user: user,
+      user_role: user_role,
       extra: extra
     )
   end
@@ -20,6 +23,7 @@ shared_context "when a simple event" do
     end
   end
   let(:user) { create :user, organization: organization }
+  let(:user_role) { :follower }
   let(:extra) { {} }
   let(:resource_path) { resource_locator(resource).path }
   let(:resource_url) { resource_locator(resource).url }
@@ -55,30 +59,35 @@ shared_examples_for "a simple event" do |skip_space_checks|
   describe "email_subject" do
     it "is generated correctly" do
       expect(subject.email_subject).to be_kind_of(String)
+      expect(subject.email_subject).not_to include("translation missing")
     end
   end
 
   describe "email_intro" do
     it "is generated correctly" do
       expect(subject.email_intro).to be_kind_of(String)
+      expect(subject.email_intro).not_to include("translation missing")
     end
   end
 
   describe "email_outro" do
     it "is generated correctly" do
       expect(subject.email_outro).to be_kind_of(String)
+      expect(subject.email_outro).not_to include("translation missing")
     end
   end
 
   describe "email_greeting" do
     it "is generated correctly" do
       expect(subject.email_greeting).to be_kind_of(String)
+      expect(subject.email_greeting).not_to include("translation missing")
     end
   end
 
   describe "notification_title" do
     it "is generated correctly" do
       expect(subject.notification_title).to be_kind_of(String)
+      expect(subject.notification_title).not_to include("translation missing")
     end
   end
 
@@ -95,6 +104,12 @@ shared_examples_for "a simple event" do |skip_space_checks|
     end
   end
 
+  describe "resource_title" do
+    it "responds to the method" do
+      expect(subject).to respond_to(:resource_title)
+    end
+  end
+
   unless skip_space_checks
     describe "participatory_space_url" do
       it "is generated correctly" do
@@ -110,7 +125,14 @@ shared_examples_for "a simple event" do |skip_space_checks|
     it { is_expected.to include(resource_path: satisfy(&:present?)) }
     it { is_expected.to include(resource_title: satisfy(&:present?)) }
     it { is_expected.to include(resource_url: start_with("http")) }
-    it { is_expected.to include(scope: i18n_scope) }
+
+    it "includes the i18n scope" do
+      if event_instance.event_has_roles?
+        expect(subject).to include(scope: "#{i18n_scope}.#{user_role}")
+      else
+        expect(subject).to include(scope: i18n_scope)
+      end
+    end
 
     unless skip_space_checks
       it { is_expected.to include(participatory_space_title: satisfy(&:present?)) }

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.15.2"
+      "0.16.0"
     end
   end
 end

data/lib/decidim/events/base_event.rb

@@ -40,11 +40,14 @@ module Decidim
       # event_name - a String with the name of the event.
       # resource - the resource that received the event
       # user - the User that receives the event
+      # user_role - the role the user takes for this event (either `:follower` or
+      #   `:affected_user`)
       # extra - a Hash with extra information of the event.
-      def initialize(resource:, event_name:, user:, extra:)
+      def initialize(resource:, event_name:, user:, user_role: nil, extra: {})
         @event_name = event_name
         @resource = resource
         @user = user
+        @user_role = user_role
         @extra = extra.with_indifferent_access
       end
 
@@ -80,9 +83,21 @@ module Decidim
         true
       end
 
+      def resource_text; end
+
+      def resource_title
+        return unless resource
+
+        if resource.respond_to?(:title)
+          translated_attribute(resource.title)
+        elsif resource.respond_to?(:name)
+          translated_attribute(resource.name)
+        end
+      end
+
       private
 
-      attr_reader :event_name, :resource, :user, :extra
+      attr_reader :event_name, :resource, :user, :user_role, :extra
 
       def component
         return resource.component if resource.is_a?(Decidim::HasComponent)
@@ -93,16 +108,6 @@ module Decidim
         return resource if resource.is_a?(Decidim::ParticipatorySpaceResourceable)
         component&.participatory_space
       end
-
-      def resource_title
-        return unless resource
-
-        if resource.respond_to?(:title)
-          translated_attribute(resource.title)
-        elsif resource.respond_to?(:name)
-          translated_attribute(resource.name)
-        end
-      end
     end
   end
 end