decidim-core 0.10.1 → 0.11.0.pre1

data/lib/decidim/core/test/shared_examples/has_component.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "has component" do
+  context "without a component" do
+    before do
+      subject.component = nil
+    end
+
+    it { is_expected.not_to be_valid }
+  end
+
+  context "without a valid component" do
+    before do
+      subject.component = build(:component, manifest_name: "foo-bar")
+    end
+
+    it { is_expected.not_to be_valid }
+  end
+end

data/lib/decidim/core/test/shared_examples/has_reference.rb

@@ -14,7 +14,7 @@ shared_examples_for "has reference" do
 
     context "when there is a custom resource reference generator present" do
       before do
-        allow(Decidim).to receive(:reference_generator).and_return(->(resource, _feature) { "1234-#{resource.id}" })
+        allow(Decidim).to receive(:reference_generator).and_return(->(resource, _component) { "1234-#{resource.id}" })
       end
 
       it "generates a valid reference" do
@@ -37,7 +37,7 @@ shared_examples_for "has reference" do
     it "stores the reference" do
       subject.reference = nil
       subject.save!
-      expect(subject.reload.reference).to_not be_blank
+      expect(subject.reload.reference).not_to be_blank
     end
   end
 end

data/lib/decidim/core/test/shared_examples/localised_email.rb

@@ -14,7 +14,7 @@ shared_examples "localised email" do
     end
   end
 
-  context "otherwise" do
+  context "when the user does not have a custom locale" do
     let(:locale) { nil }
 
     it "uses the default locale" do

data/lib/decidim/core/test/shared_examples/paginated_resource_examples.rb

@@ -4,7 +4,7 @@ shared_examples "a paginated resource" do
   let(:collection_size) { 30 }
 
   before do
-    visit_feature
+    visit_component
   end
 
   it "lists 20 resources per page by default" do

data/lib/decidim/core/test/shared_examples/reportable.rb

@@ -3,9 +3,9 @@
 require "spec_helper"
 
 shared_examples_for "reportable" do
-  context "is reportable" do
+  context "when reportable" do
     let(:user) { create(:user, organization: subject.organization) }
-    let(:participatory_space) { subject.feature.participatory_space }
+    let(:participatory_space) { subject.component.participatory_space }
     let(:moderation) { create(:moderation, reportable: subject, participatory_space: participatory_space, report_count: 1) }
     let!(:report) { create(:report, moderation: moderation, user: user) }
 
@@ -13,29 +13,31 @@ shared_examples_for "reportable" do
       context "when the resource has not been reported by the given user" do
         let!(:report) { nil }
 
-        it { expect(subject.reported_by?(user)).to be_falsey }
+        it { expect(subject).not_to be_reported_by(user) }
       end
 
       context "when the resource has been reported" do
-        it { expect(subject.reported_by?(user)).to be_truthy }
+        it { expect(subject).to be_reported_by(user) }
       end
     end
 
-    context "#hidden?" do
+    describe "#hidden?" do
       context "when the resource has not been hidden" do
         it { expect(subject).not_to be_hidden }
       end
 
       context "when the resource has been hidden" do
         let(:moderation) { create(:moderation, reportable: subject, participatory_space: participatory_space, report_count: 1, hidden_at: Time.current) }
+
         it { expect(subject).to be_hidden }
       end
     end
 
-    context "#reported?" do
+    describe "#reported?" do
       context "when the report count is equal to 0" do
         let(:moderation) { create(:moderation, reportable: subject, participatory_space: participatory_space, report_count: 0) }
         let!(:report) { nil }
+
         it { expect(subject).not_to be_reported }
       end
 

data/lib/decidim/core/test/shared_examples/reports_examples.rb

@@ -2,7 +2,7 @@
 
 shared_examples "reports" do
   context "when the user is not logged in" do
-    it "should be given the option to sign in" do
+    it "gives the option to sign in" do
       visit reportable_path
 
       expect(page).to have_no_css("body.is-reveal-open")

data/lib/decidim/core/test/shared_examples/scopable_interface_examples.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "scopable interface" do
+  let!(:scope) { create(:scope, organization: model.participatory_space.organization) }
+
+  before do
+    model.update(scope: scope)
+  end
+
+  describe "scope" do
+    let(:query) { "{ scope { id } }" }
+
+    it "has a scope" do
+      expect(response).to include("scope" => { "id" => scope.id.to_s })
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/scope_helper_examples.rb

@@ -6,9 +6,9 @@ shared_examples "scope helpers" do
   let(:organization) { create(:organization) }
   let(:scopes_enabled) { true }
   let(:participatory_space_scope) { nil }
-  let(:feature) { create(:feature, manifest_name: "dummy", participatory_space: participatory_space) }
+  let(:component) { create(:component, manifest_name: "dummy", participatory_space: participatory_space) }
   let(:scope) { create(:scope, organization: organization) }
-  let(:resource) { create(:dummy_resource, feature: feature, scope: scope) }
+  let(:resource) { create(:dummy_resource, component: component, scope: scope) }
 
   before do
     allow(helper).to receive(:current_participatory_space).and_return(participatory_space)
@@ -29,29 +29,34 @@ shared_examples "scope helpers" do
 
     context "when the process has not scope enabled" do
       let(:scopes_enabled) { false }
+
       it { is_expected.to be_falsey }
     end
 
     context "when the process has a different scope than the organization" do
       let(:participatory_space_scope) { create(:scope, organization: organization) }
+
       it { is_expected.to be_truthy }
     end
 
     context "when the process has the same scope as the organization" do
       let(:participatory_space_scope) { scope }
+
       it { is_expected.to be_falsey }
     end
 
     context "when the resource has not a scope" do
       let(:scope) { nil }
+
       it { is_expected.to be_falsey }
     end
   end
 
   describe "scope_name_for_picker" do
-    let(:global_name) { "Global name" }
     subject { helper.scope_name_for_picker(scope, global_name) }
 
+    let(:global_name) { "Global name" }
+
     context "when a scope is given" do
       context "when the scope has a scope type" do
         it { is_expected.to include(scope.name["en"]) }

data/lib/decidim/core/test/shared_examples/simple_event.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-shared_context "simple event" do
+shared_context "when a simple event" do
   subject do
     described_class.new(
       resource: resource,

data/lib/decidim/core/test/shared_examples/user_localised_email_examples.rb

@@ -14,7 +14,7 @@ shared_examples "user localised email" do
     end
   end
 
-  context "otherwise" do
+  context "when the user does not have a custom locale" do
     let(:locale) { nil }
 
     it "uses the default locale" do

data/lib/decidim/core/test.rb

@@ -5,7 +5,7 @@ require "decidim/core/test/shared_examples/publicable"
 require "decidim/core/test/shared_examples/localised_email"
 require "decidim/core/test/shared_examples/has_attachments"
 require "decidim/core/test/shared_examples/has_attachment_collections"
-require "decidim/core/test/shared_examples/has_feature"
+require "decidim/core/test/shared_examples/has_component"
 require "decidim/core/test/shared_examples/has_scope"
 require "decidim/core/test/shared_examples/has_category"
 require "decidim/core/test/shared_examples/has_reference"

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.10.1"
+      "0.11.0.pre1"
     end
   end
 end

data/lib/decidim/core.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "decidim/core/engine"
+require "decidim/core/api"
 require "decidim/core/version"
 
 # Decidim configuration.
@@ -9,7 +10,7 @@ module Decidim
   autoload :FormBuilder, "decidim/form_builder"
   autoload :AuthorizationFormBuilder, "decidim/authorization_form_builder"
   autoload :FilterFormBuilder, "decidim/filter_form_builder"
-  autoload :FeatureManifest, "decidim/feature_manifest"
+  autoload :ComponentManifest, "decidim/component_manifest"
   autoload :ParticipatorySpaceManifest, "decidim/participatory_space_manifest"
   autoload :ResourceManifest, "decidim/resource_manifest"
   autoload :Resourceable, "decidim/resourceable"
@@ -20,16 +21,16 @@ module Decidim
   autoload :Participable, "decidim/participable"
   autoload :Publicable, "decidim/publicable"
   autoload :Scopable, "decidim/scopable"
-  autoload :ScopableFeature, "decidim/scopable_feature"
+  autoload :ScopableComponent, "decidim/scopable_component"
   autoload :ContentParsers, "decidim/content_parsers"
   autoload :ContentRenderers, "decidim/content_renderers"
   autoload :ContentProcessor, "decidim/content_processor"
-  autoload :Features, "decidim/features"
+  autoload :Components, "decidim/components"
   autoload :HasAttachmentCollections, "decidim/has_attachment_collections"
   autoload :HasAttachments, "decidim/has_attachments"
-  autoload :FeatureValidator, "decidim/feature_validator"
+  autoload :ComponentValidator, "decidim/component_validator"
   autoload :HasSettings, "decidim/has_settings"
-  autoload :HasFeature, "decidim/has_feature"
+  autoload :HasComponent, "decidim/has_component"
   autoload :HasCategory, "decidim/has_category"
   autoload :Followable, "decidim/followable"
   autoload :FriendlyDates, "decidim/friendly_dates"
@@ -50,6 +51,9 @@ module Decidim
   autoload :ViewHooks, "decidim/view_hooks"
   autoload :NewsletterEncryptor, "decidim/newsletter_encryptor"
   autoload :QueryExtensions, "decidim/query_extensions"
+  autoload :ParticipatorySpaceResourceable, "decidim/participatory_space_resourceable"
+  autoload :HasPrivateUsers, "decidim/has_private_users"
+  autoload :ViewModel, "decidim/view_model"
 
   include ActiveSupport::Configurable
 
@@ -123,7 +127,7 @@ module Decidim
   config_accessor :geocoder
 
   # Exposes a configuration option: a custom method to generate references.
-  # If overwritten, it should handle both feature resources and participatory spaces.
+  # If overwritten, it should handle both component resources and participatory spaces.
   # Default: Calculates a unique reference for the model in
   # the following format:
   #
@@ -135,12 +139,12 @@ module Decidim
   # 2017-02: Year-Month of the resource creation date
   # 6589: ID of the resource
   config_accessor :reference_generator do
-    lambda do |resource, feature|
+    lambda do |resource, component|
       ref = ""
 
-      if resource.is_a?(Decidim::HasFeature) && feature.present?
-        # It's a feature resource
-        ref = feature.participatory_space.organization.reference_prefix
+      if resource.is_a?(Decidim::HasComponent) && component.present?
+        # It's a component resource
+        ref = component.participatory_space.organization.reference_prefix
       elsif resource.is_a?(Decidim::Participable)
         # It's a participatory space
         ref = resource.organization.reference_prefix
@@ -190,7 +194,7 @@ module Decidim
   config_accessor :base_uploads_path
 
   # Public: Registers a global engine. This method is intended to be used
-  # by feature engines that also offer unscoped functionality
+  # by component engines that also offer unscoped functionality
   #
   # name    - The name of the engine to register. Should be unique.
   # engine  - The engine to register.
@@ -226,18 +230,18 @@ module Decidim
     @global_engines ||= {}
   end
 
-  # Public: Registers a feature, usually held in an external library or in a
+  # Public: Registers a component, usually held in an external library or in a
   # separate folder in the main repository. Exposes a DSL defined by
-  # `Decidim::FeatureManifest`.
+  # `Decidim::ComponentManifest`.
   #
-  # Feature manifests are held in a global registry and are used in all kinds of
-  # places to figure out what new components or functionalities the feature provides.
+  # Component manifests are held in a global registry and are used in all kinds of
+  # places to figure out what new components or functionalities the component provides.
   #
-  # name - A Symbol with the feature's unique name.
+  # name - A Symbol with the component's unique name.
   #
   # Returns nothing.
-  def self.register_feature(name, &block)
-    feature_registry.register(name, &block)
+  def self.register_component(name, &block)
+    component_registry.register(name, &block)
   end
 
   # Public: Registers a participatory space, usually held in an external library
@@ -255,12 +259,12 @@ module Decidim
     participatory_space_registry.register(name, &block)
   end
 
-  # Public: Finds all registered feature manifest's via the `register_feature`
+  # Public: Finds all registered component manifest's via the `register_component`
   # method.
   #
-  # Returns an Array[FeatureManifest].
-  def self.feature_manifests
-    feature_registry.manifests
+  # Returns an Array[ComponentManifest].
+  def self.component_manifests
+    component_registry.manifests
   end
 
   # Public: Finds all registered participatory space manifest's via the
@@ -271,13 +275,13 @@ module Decidim
     participatory_space_registry.manifests
   end
 
-  # Public: Finds a feature manifest by the feature's name.
+  # Public: Finds a component manifest by the component's name.
   #
-  # name - The name of the FeatureManifest to find.
+  # name - The name of the ComponentManifest to find.
   #
-  # Returns a FeatureManifest if found, nil otherwise.
-  def self.find_feature_manifest(name)
-    feature_registry.find(name.to_sym)
+  # Returns a ComponentManifest if found, nil otherwise.
+  def self.find_component_manifest(name)
+    component_registry.find(name.to_sym)
   end
 
   # Public: Finds a participatory space manifest by the participatory space's
@@ -297,12 +301,12 @@ module Decidim
   #
   # Returns a ResourceManifest if found, nil otherwise.
   def self.find_resource_manifest(resource_name_or_klass)
-    feature_registry.find_resource_manifest(resource_name_or_klass)
+    component_registry.find_resource_manifest(resource_name_or_klass)
   end
 
-  # Public: Stores the registry of features
-  def self.feature_registry
-    @feature_registry ||= ManifestRegistry.new(:features)
+  # Public: Stores the registry of components
+  def self.component_registry
+    @component_registry ||= ManifestRegistry.new(:components)
   end
 
   # Public: Stores the registry of participatory spaces
@@ -333,10 +337,4 @@ module Decidim
   def self.traceability
     @traceability ||= Traceability.new
   end
-
-  module Core
-    autoload :ParticipatorySpaceInterface, "decidim/api/participatory_space_interface"
-    autoload :ComponentInterface, "decidim/api/component_interface"
-    autoload :AuthorInterface, "decidim/api/author_interface"
-  end
 end

data/lib/decidim/events/base_event.rb

@@ -71,7 +71,7 @@ module Decidim
       def notifiable?
         return false if resource.is_a?(Decidim::Publicable) && !resource.published?
         return false if participatory_space.is_a?(Decidim::Publicable) && !participatory_space&.published?
-        return false unless feature&.published?
+        return false unless component&.published?
 
         true
       end
@@ -80,13 +80,13 @@ module Decidim
 
       attr_reader :event_name, :resource, :user, :extra
 
-      def feature
-        return resource.feature if resource.is_a?(Decidim::HasFeature)
-        return resource if resource.is_a?(Decidim::Feature)
+      def component
+        return resource.component if resource.is_a?(Decidim::HasComponent)
+        return resource if resource.is_a?(Decidim::Component)
       end
 
       def participatory_space
-        feature&.participatory_space
+        component&.participatory_space
       end
 
       def resource_title

data/lib/decidim/events/simple_event.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module Events
-    # Extends the BaseEvent to add common features to most events so you don't
+    # Extends the BaseEvent to add common components to most events so you don't
     # need to write each time the same code.
     #
     # The only convention you need to keep in mind is that the event name will be
@@ -10,7 +10,7 @@ module Decidim
     class SimpleEvent < BaseEvent
       include Decidim::Events::EmailEvent
       include Decidim::Events::NotificationEvent
-      include Decidim::FeaturePathHelper
+      include Decidim::ComponentPathHelper
 
       class_attribute :i18n_interpolations
       self.i18n_interpolations = []
@@ -59,16 +59,16 @@ module Decidim
         default_i18n_options.merge(event_interpolations)
       end
 
-      # Caches the path for the given resource when it's a Decidim::Feature.
+      # Caches the path for the given resource when it's a Decidim::Component.
       def resource_path
-        return super unless resource.is_a?(Decidim::Feature)
-        @resource_path ||= main_feature_path(resource)
+        return super unless resource.is_a?(Decidim::Component)
+        @resource_path ||= main_component_path(resource)
       end
 
-      # Caches the URL for the given resource when it's a Decidim::Feature.
+      # Caches the URL for the given resource when it's a Decidim::Component.
       def resource_url
-        return super unless resource.is_a?(Decidim::Feature)
-        @resource_url ||= main_feature_url(resource)
+        return super unless resource.is_a?(Decidim::Component)
+        @resource_url ||= main_component_url(resource)
       end
 
       # Caches the URL for the resource's participatory space.

data/lib/decidim/form_builder.rb

@@ -79,26 +79,71 @@ module Decidim
       safe_join [label_tabs, tabs_content]
     end
 
+    # Public: Generates an form field for each social.
+    #
+    # type - The form field's type, like `text_area` or `text_input`
+    # name - The name of the field
+    # handlers - The social handlers to be created
+    # options - The set of options to send to the field
+    #
+    # Renders form fields for each locale.
+    def social_field(type, name, handlers, options = {})
+      tabs_id = options[:tabs_id] || "#{object_name}-#{name}-tabs"
+
+      label_tabs = content_tag(:div, class: "label--tabs") do
+        field_label = label_i18n(name, options[:label] || label_for(name))
+
+        tabs_panels = "".html_safe
+        if options[:label] != false
+          tabs_panels = content_tag(:ul, class: "tabs tabs--lang", id: tabs_id, data: { tabs: true }) do
+            handlers.each_with_index.inject("".html_safe) do |string, (handler, index)|
+              string + content_tag(:li, class: tab_element_class_for("title", index)) do
+                title = I18n.t(".#{handler}", scope: "activemodel.attributes.#{object_name}")
+                tab_content_id = "#{tabs_id}-#{name}-panel-#{index}"
+                content_tag(:a, title, href: "##{tab_content_id}")
+              end
+            end
+          end
+        end
+
+        safe_join [field_label, tabs_panels]
+      end
+
+      tabs_content = content_tag(:div, class: "tabs-content", data: { tabs_content: tabs_id }) do
+        handlers.each_with_index.inject("".html_safe) do |string, (handler, index)|
+          tab_content_id = "#{tabs_id}-#{name}-panel-#{index}"
+          string + content_tag(:div, class: tab_element_class_for("panel", index), id: tab_content_id) do
+            send(type, "#{handler}_handler", options.merge(label: false))
+          end
+        end
+      end
+
+      safe_join [label_tabs, tabs_content]
+    end
+
     # Public: generates a hidden field and a container for WYSIWYG editor
     #
     # name - The name of the field
     # options - The set of options to send to the field
-    #           :label   - The Boolean value to create or not the input label (optional) (default: true)
+    #           :label - The Boolean value to create or not the input label (optional) (default: true)
     #           :toolbar - The String value to configure WYSIWYG toolbar. It should be 'basic' or
     #                      or 'full' (optional) (default: 'basic')
-    #           :lines   - The Integer to indicate how many lines should editor have (optional) (default: 10)
+    #           :lines - The Integer to indicate how many lines should editor have (optional) (default: 10)
+    #           :disabled - Whether the editor should be disabled
     #
     # Renders a container with both hidden field and editor container
     def editor(name, options = {})
       options[:toolbar] ||= "basic"
       options[:lines] ||= 10
+      options[:disabled] ||= false
 
       content_tag(:div, class: "editor") do
         template = ""
         template += label(name, options[:label].to_s || name) if options[:label] != false
         template += hidden_field(name, options)
         template += content_tag(:div, nil, class: "editor-container", data: {
-                                  toolbar: options[:toolbar]
+                                  toolbar: options[:toolbar],
+                                  disabled: options[:disabled]
                                 }, style: "height: #{options[:lines]}rem")
         template += error_for(name, options) if error?(name)
         template.html_safe

data/lib/decidim/has_attachment_collections.rb

@@ -3,7 +3,7 @@
 require "active_support/concern"
 
 module Decidim
-  # A concern with the features needed when you want a model to be able to create
+  # A concern with the components needed when you want a model to be able to create
   # links from it to another resource.
   module HasAttachmentCollections
     extend ActiveSupport::Concern

data/lib/decidim/has_attachments.rb

@@ -3,7 +3,7 @@
 require "active_support/concern"
 
 module Decidim
-  # A concern with the features needed when you want a model to be able to create
+  # A concern with the components needed when you want a model to be able to create
   # links from it to another resource.
   module HasAttachments
     extend ActiveSupport::Concern

data/lib/decidim/has_category.rb

@@ -3,7 +3,7 @@
 require "active_support/concern"
 
 module Decidim
-  # A concern with the features needed when you want a model to have a category.
+  # A concern with the components needed when you want a model to have a category.
   module HasCategory
     extend ActiveSupport::Concern
 
@@ -22,7 +22,7 @@ module Decidim
 
       def category_belongs_to_organization
         return unless category
-        errors.add(:category, :invalid) unless feature.categories.where(id: category.id).exists?
+        errors.add(:category, :invalid) unless component.categories.where(id: category.id).exists?
       end
     end
   end

data/lib/decidim/has_component.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require "active_support/concern"
+require "decidim/component_validator"
+
+module Decidim
+  # A concern with the components needed when you want a model to have a component.
+  module HasComponent
+    extend ActiveSupport::Concern
+
+    included do
+      belongs_to :component, foreign_key: "decidim_component_id", class_name: "Decidim::Component"
+      delegate :organization, to: :component, allow_nil: true
+      delegate :participatory_space, to: :component, allow_nil: true
+    end
+
+    class_methods do
+      def component_manifest_name(manifest_name)
+        validates :component, component: { manifest: manifest_name || name.demodulize.pluralize.downcase }
+      end
+    end
+  end
+end

data/lib/decidim/has_private_users.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require "active_support/concern"
+
+module Decidim
+  # A concern with the features needed when you want a model to be able to create
+  # private users
+  module HasPrivateUsers
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :participatory_space_private_users, class_name: "Decidim::ParticipatorySpacePrivateUser", as: :privatable_to, dependent: :destroy
+      has_many :users, through: :participatory_space_private_users, class_name: "Decidim::User", foreign_key: "private_user_to_id"
+
+      scope :visible_for, lambda { |user|
+                            joins("LEFT JOIN decidim_participatory_space_private_users ON
+                            decidim_participatory_space_private_users.privatable_to_id = #{table_name}.id")
+                              .where("(private_space = ? and decidim_participatory_space_private_users.decidim_user_id = ?) or private_space = ? ", true, user, false)
+                          }
+
+      def self.public_spaces
+        super.where(private_space: false)
+      end
+    end
+  end
+end

data/lib/decidim/has_reference.rb

@@ -3,7 +3,7 @@
 require "active_support/concern"
 
 module Decidim
-  # A concern with the features needed when you want a model to have a
+  # A concern with the components needed when you want a model to have a
   # reference.
   module HasReference
     extend ActiveSupport::Concern
@@ -20,12 +20,12 @@ module Decidim
       private
 
       # Public: Calculates a unique reference for the model using the function
-      # provided by configuration. Works for both feature resources and
+      # provided by configuration. Works for both component resources and
       # participatory spaces.
       #
       # Returns a String.
       def calculate_reference
-        Decidim.reference_generator.call(self, respond_to?(:feature) ? feature : nil)
+        Decidim.reference_generator.call(self, respond_to?(:component) ? component : nil)
       end
 
       # Internal: Sets the unique reference to the model. Note that if the resource