decidim-core 0.10.1 → 0.11.0.pre1

data/lib/decidim/{feature_manifest.rb → component_manifest.rb}

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 require "decidim/settings_manifest"
-require "decidim/features/export_manifest"
+require "decidim/components/export_manifest"
 
 module Decidim
-  # This class handles all the logic associated to configuring a feature
+  # This class handles all the logic associated to configuring a component
   # associated to a participatory process.
   #
   # It's normally not used directly but through the API exposed through
-  # `Decidim.register_feature`.
-  class FeatureManifest
+  # `Decidim.register_component`.
+  class ComponentManifest
     include ActiveModel::Model
     include Virtus.model
 
@@ -31,21 +31,24 @@ module Decidim
     # it can use the scss variables and mixins provided by Decidim::Admin.
     attribute :admin_stylesheet, String, default: nil
 
-    # A String with the feature's icon. The icon must be stored in the
+    # A String with the component's icon. The icon must be stored in the
     # engine's assets path.
     attribute :icon, String
 
-    # Actions are used to validate permissions of a feature against particular
+    # Actions are used to validate permissions of a component against particular
     # authorizations or potentially other authorization rules.
     #
     # An example would be `vote` on participatory processes, or `create_meeting`
     # on meetings.
     #
-    # A Feature can expose as many actions as it wants and the admin panel will
+    # A Component can expose as many actions as it wants and the admin panel will
     # generate a UI to handle them. There's a set of controller helpers available
     # as well that allows checking for those permissions.
     attribute :actions, Array[String]
 
+    # The cell path to use to render the card of a resource.
+    attribute :card, String
+
     validates :name, presence: true
 
     # Public: Registers a hook to this manifest. Hooks get fired when some
@@ -84,21 +87,21 @@ module Decidim
       self.hooks = {}
     end
 
-    # Public: A block that gets called when seeding for this feature takes place.
+    # Public: A block that gets called when seeding for this component takes place.
     #
     # Returns nothing.
     def seeds(&block)
       @seeds = block
     end
 
-    # Public: Creates the seeds for this features in order to populate the database.
+    # Public: Creates the seeds for this components in order to populate the database.
     #
     # Returns nothing.
     def seed!(participatory_space)
       @seeds&.call(participatory_space)
     end
 
-    # Public: Adds configurable attributes for this feature, scoped to a name. It
+    # Public: Adds configurable attributes for this component, scoped to a name. It
     # uses the DSL specified under `Decidim::SettingsManifest`.
     #
     # name - Either `global` or `step`
@@ -106,7 +109,7 @@ module Decidim
     #
     # Examples:
     #
-    #   feature.settings(:global) do |settings|
+    #   component.settings(:global) do |settings|
     #     settings.attribute :voting_enabled, type: :boolean, default: true
     #   end
     #
@@ -119,7 +122,7 @@ module Decidim
       settings
     end
 
-    # Public: Registers a resource inside a feature manifest. Exposes a DSL
+    # Public: Registers a resource inside a component manifest. Exposes a DSL
     # defined by `Decidim::ResourceManifest`.
     #
     # Resource manifests are a way to expose a resource from one engine to
@@ -130,21 +133,21 @@ module Decidim
     # Returns nothing.
     def register_resource
       manifest = ResourceManifest.new
-      manifest.feature_manifest = self
+      manifest.component_manifest = self
       yield(manifest)
       manifest.validate!
       resource_manifests << manifest
     end
 
     # Public: Registers an export artifact with a name and its properties
-    # defined in `Decidim::Features::ExportManifest`.
+    # defined in `Decidim::Components::ExportManifest`.
     #
-    # Export artifacts provide an unified way for features to register
+    # Export artifacts provide an unified way for components to register
     # exportable collections serialized via a `Serializer` than eventually
     # are transformed to their formats.
     #
     # name  - The name of the artifact. Should be unique in the context of
-    #         the feature.
+    #         the component.
     # block - A block that receives the manifest as its only argument.
     #
     # Returns nothing.
@@ -155,12 +158,12 @@ module Decidim
     end
 
     # Pubic: Returns a collection of previously registered export manifests
-    # for this feature.
+    # for this component.
     #
-    # Returns an Array<Decidim::Features::ExportManifest>.
+    # Returns an Array<Decidim::Components::ExportManifest>.
     def export_manifests
       @export_manifests ||= @exports.map do |(name, block)|
-        Decidim::Features::ExportManifest.new(name).tap do |manifest|
+        Decidim::Components::ExportManifest.new(name).tap do |manifest|
           block.call(manifest)
         end
       end
@@ -179,13 +182,13 @@ module Decidim
       @stats ||= StatsRegistry.new
     end
 
-    # Public: Registers a stat inside a feature manifest.
+    # Public: Registers a stat inside a component manifest.
     #
     # name - The name of the stat
     # options - A hash of options
     #         * primary: Whether the stat is primary or not.
     #         * priority: The priority of the stat used for render issues.
-    # block - A block that receive the features to filter out the stat.
+    # block - A block that receive the components to filter out the stat.
     #
     # Returns nothing.
     def register_stat(name, options = {}, &block)

data/lib/decidim/{feature_validator.rb → component_validator.rb}

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
-# A custom validator to make sure features are correctly assigned to a model.
+# A custom validator to make sure components are correctly assigned to a model.
 #
 # Adds a presence validation and checks that the manifest is the correct one.
-class FeatureValidator < ActiveModel::EachValidator
+class ComponentValidator < ActiveModel::EachValidator
   # Validates the arguiments passed to the validator.
   def check_validity!
-    raise ArgumentError, "You must include a `manifest` option with the name of the manifest to validate when validating a feature" if options[:manifest].blank?
+    raise ArgumentError, "You must include a `manifest` option with the name of the manifest to validate when validating a component" if options[:manifest].blank?
   end
 
   # The actual validator method. It is called when ActiveRecord iterates
   # over all the validators.
-  def validate_each(record, attribute, feature)
-    unless feature
+  def validate_each(record, attribute, component)
+    unless component
       record.errors[attribute] << :blank
       return
     end
 
-    record.errors[attribute] << :invalid if feature.manifest_name.to_s != options[:manifest].to_s
+    record.errors[attribute] << :invalid if component.manifest_name.to_s != options[:manifest].to_s
   end
 end

data/lib/decidim/{features → components}/export_manifest.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 module Decidim
-  module Features
+  module Components
     # This class serves as a DSL to declarative specify which artifacts are
-    # exportable in a feature. It is used via the `FeatureManifest`.
+    # exportable in a component. It is used via the `ComponentManifest`.
     #
     class ExportManifest
       attr_reader :name
@@ -11,7 +11,7 @@ module Decidim
       # Initializes the manifest.
       #
       # name - The name of the export artifact. It should be unique in the
-      #        feature.
+      #        component.
       #
       def initialize(name)
         @name = name.to_sym
@@ -20,7 +20,7 @@ module Decidim
       # Public: Sets the collection when a block is given, or returns it if
       # no block is provided.
       #
-      # The collection will get passed an instance of `Decidim::Feature` when
+      # The collection will get passed an instance of `Decidim::Component` when
       # it's evaluated so you can easily find the elements to export.
       #
       # &block - An optional block that returns the collection once evaluated.

data/lib/decidim/components/namer.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Components
+    # This class automatically names components for the given organization.
+    # In order to do so, it uses the i18n keys of the component, fallback to English,
+    # searching for the key `"decidim.components.<component name>.name"`
+    #
+    # This is intended to be used from the component seeds section.
+    #
+    # Examples:
+    #
+    #   Decidim::Component.create!(
+    #     participatory_space: process,
+    #     name: Decidim::Component::Namer.new(organization.available_locales, :my_component_name).i18n_name
+    #     manifest_name: :my_component_name
+    #   )
+    class Namer
+      def initialize(locales, component_name)
+        @locales = locales
+        @component_name = component_name
+      end
+
+      def i18n_name
+        locales.inject({}) do |names, locale|
+          names.update(locale => I18n.t("decidim.components.#{component_name}.name", locale: locale))
+        end
+      end
+
+      private
+
+      attr_reader :locales, :component_name
+    end
+  end
+end

data/lib/decidim/components.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Decidim
+  # This module contains all logic related to decidim's Components, the main
+  # building block to extend functionalities in a participatory process.
+  module Components
+    autoload :BaseController, "decidim/components/base_controller"
+  end
+end

data/lib/decidim/content_parsers/user_parser.rb

@@ -28,7 +28,7 @@ module Decidim
       # @return [String] the content with the valid mentions replaced by a global id
       def rewrite
         content.gsub(MENTION_REGEX) do |match|
-          if (user = Decidim::User.where(nickname: Regexp.last_match[2], organization: context[:current_organization]).first)
+          if (user = Decidim::User.find_by(nickname: Regexp.last_match[2], organization: context[:current_organization]))
             Regexp.last_match[1] + user.to_global_id.to_s
           else
             match

data/lib/decidim/core/api.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Core
+    autoload :ParticipatorySpaceInterface, "decidim/api/participatory_space_interface"
+    autoload :ComponentInterface, "decidim/api/component_interface"
+    autoload :AuthorInterface, "decidim/api/author_interface"
+    autoload :AuthorableInterface, "decidim/api/authorable_interface"
+    autoload :CategorizableInterface, "decidim/api/categorizable_interface"
+    autoload :ScopableInterface, "decidim/api/scopable_interface"
+    autoload :AttachableInterface, "decidim/api/attachable_interface"
+  end
+end

data/lib/decidim/core/engine.rb

@@ -15,7 +15,12 @@ require "foundation-rails"
 require "foundation_rails_helper"
 require "autoprefixer-rails"
 require "active_link_to"
+
+# Until https://github.com/andypike/rectify/pull/45 is attended, we're shipping
+# with a patched version of rectify
 require "rectify"
+require "decidim/rectify_ext"
+
 require "carrierwave"
 require "high_voltage"
 require "rails-i18n"
@@ -32,6 +37,10 @@ require "invisible_captcha"
 require "premailer/rails"
 require "geocoder"
 require "paper_trail"
+require "cells/rails"
+require "cells-erb"
+require "doorkeeper"
+require "doorkeeper-i18n"
 
 require "decidim/api"
 
@@ -56,8 +65,8 @@ module Decidim
         app.config.assets.paths << File.expand_path("../../../app/assets/stylesheets", __dir__)
         app.config.assets.precompile += %w(decidim_core_manifest.js)
 
-        Decidim.feature_manifests.each do |feature|
-          app.config.assets.precompile += [feature.icon]
+        Decidim.component_manifests.each do |component|
+          app.config.assets.precompile += [component.icon]
         end
 
         app.config.assets.debug = true if Rails.env.test?
@@ -92,10 +101,13 @@ module Decidim
         app.config.i18n.fallbacks = true
       end
 
-      initializer "decidim.query_extensions" do
+      initializer "decidim.graphql_api" do
         Decidim::Api::QueryType.define do
           Decidim::QueryExtensions.define(self)
         end
+
+        Decidim::Api.add_orphan_type Decidim::Core::UserType
+        Decidim::Api.add_orphan_type Decidim::Core::UserGroupType
       end
 
       initializer "decidim.i18n_exceptions" do
@@ -207,6 +219,67 @@ module Decidim
       initializer "paper_trail" do
         PaperTrail.config.track_associations = false
       end
+
+      initializer "add_cells_view_paths" do
+        Cell::ViewModel.view_paths << File.expand_path("#{Decidim::Core::Engine.root}/app/cells")
+        Cell::ViewModel.view_paths << File.expand_path("#{Decidim::Core::Engine.root}/app/views") # for partials
+      end
+
+      initializer "doorkeeper" do
+        Doorkeeper.configure do
+          orm :active_record
+
+          # This block will be called to check whether the resource owner is authenticated or not.
+          resource_owner_authenticator do
+            current_user || redirect_to(new_user_session_path)
+          end
+
+          # The controller Doorkeeper::ApplicationController inherits from.
+          # Defaults to ActionController::Base.
+          # https://github.com/doorkeeper-gem/doorkeeper#custom-base-controller
+          base_controller "Decidim::ApplicationController"
+
+          # Provide support for an owner to be assigned to each registered application (disabled by default)
+          # Optional parameter confirmation: true (default false) if you want to enforce ownership of
+          # a registered application
+          # Note: you must also run the rails g doorkeeper:application_owner generator to provide the necessary support
+          enable_application_owner confirmation: false
+
+          # Define access token scopes for your provider
+          # For more information go to
+          # https://github.com/doorkeeper-gem/doorkeeper/wiki/Using-Scopes
+          default_scopes :public
+          optional_scopes []
+
+          # Change the native redirect uri for client apps
+          # When clients register with the following redirect uri, they won't be redirected to any server and the authorization code will be displayed within the provider
+          # The value can be any string. Use nil to disable this feature. When disabled, clients must provide a valid URL
+          # (Similar behaviour: https://developers.google.com/accounts/docs/OAuth2InstalledApp#choosingredirecturi)
+          #
+          native_redirect_uri "urn:ietf:wg:oauth:2.0:oob"
+
+          # Forces the usage of the HTTPS protocol in non-native redirect uris (enabled
+          # by default in non-development environments). OAuth2 delegates security in
+          # communication to the HTTPS protocol so it is wise to keep this enabled.
+          #
+          # Callable objects such as proc, lambda, block or any object that responds to
+          # #call can be used in order to allow conditional checks (to allow non-SSL
+          # redirects to localhost for example).
+          #
+          # force_ssl_in_redirect_uri !Rails.env.development?
+          #
+          force_ssl_in_redirect_uri false
+
+          # WWW-Authenticate Realm (default "Doorkeeper").
+          realm "Decidim"
+        end
+      end
+
+      initializer "OAuth inflections" do
+        ActiveSupport::Inflector.inflections do |inflect|
+          inflect.acronym "OAuth"
+        end
+      end
     end
   end
 end

data/lib/decidim/core/test/factories.rb

@@ -4,6 +4,7 @@ require "decidim/faker/localized"
 require "decidim/dev"
 
 require "decidim/participatory_processes/test/factories"
+require "decidim/assemblies/test/factories"
 require "decidim/comments/test/factories"
 
 FactoryBot.define do
@@ -113,6 +114,16 @@ FactoryBot.define do
     end
   end
 
+  factory :participatory_space_private_user, class: "Decidim::ParticipatorySpacePrivateUser" do
+    user
+    privatable_to { create :participatory_process, organization: user.organization }
+  end
+
+  factory :assembly_private_user, class: "Decidim::ParticipatorySpacePrivateUser" do
+    user
+    privatable_to { create :assembly, organization: user.organization }
+  end
+
   factory :user_group, class: "Decidim::UserGroup" do
     name { Faker::Educator.course }
     document_number { Faker::Number.number(8) + "X" }
@@ -208,7 +219,7 @@ FactoryBot.define do
     end
   end
 
-  factory :feature, class: "Decidim::Feature" do
+  factory :component, class: "Decidim::Component" do
     transient do
       organization { create(:organization) }
     end
@@ -261,21 +272,24 @@ FactoryBot.define do
 
   factory :dummy_resource, class: "Decidim::DummyResources::DummyResource" do
     title { generate(:name) }
-    feature { create(:feature, manifest_name: "dummy") }
-    author { create(:user, :confirmed, organization: feature.organization) }
+    component { create(:component, manifest_name: "dummy") }
+    author { create(:user, :confirmed, organization: component.organization) }
   end
 
   factory :resource_link, class: "Decidim::ResourceLink" do
     name { generate(:slug) }
     to { build(:dummy_resource) }
-    from { build(:dummy_resource, feature: to.feature) }
+    from { build(:dummy_resource, component: to.component) }
   end
 
   factory :newsletter, class: "Decidim::Newsletter" do
     author { build(:user, :confirmed, organization: organization) }
     organization
 
+    # rubocop:disable RSpec/EmptyLineAfterSubject
+    # Bug in rubocop-rspec
     subject { Decidim::Faker::Localized.sentence(3) }
+    # rubocop:enable RSpec/EmptyLineAfterSubject
     body { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(4) } }
 
     trait :sent do
@@ -285,7 +299,7 @@ FactoryBot.define do
 
   factory :moderation, class: "Decidim::Moderation" do
     reportable { build(:dummy_resource) }
-    participatory_space { reportable.feature.participatory_space }
+    participatory_space { reportable.component.participatory_space }
 
     trait :hidden do
       hidden_at { 1.day.ago }
@@ -339,14 +353,14 @@ FactoryBot.define do
     organization { user.organization }
     user
     participatory_space { build :participatory_process, organization: organization }
-    feature { build :feature, participatory_space: participatory_space }
-    resource { build(:dummy_resource, feature: feature) }
+    component { build :component, participatory_space: participatory_space }
+    resource { build(:dummy_resource, component: component) }
     action { "create" }
     extra do
       {
-        feature: {
-          manifest_name: feature.try(:manifest_name),
-          title: feature.try(:name) || feature.try(:title)
+        component: {
+          manifest_name: component.try(:manifest_name),
+          title: component.try(:name) || component.try(:title)
         }.compact,
         participatory_space: {
           manifest_name: participatory_space.try(:class).try(:participatory_space_manifest).try(:name),
@@ -363,4 +377,23 @@ FactoryBot.define do
       }.deep_merge(extra_data)
     end
   end
+
+  factory :oauth_application, class: "Decidim::OAuthApplication" do
+    organization
+    sequence(:name) { |n| "OAuth application #{n}" }
+    sequence(:organization_name) { |n| "OAuth application owner #{n}" }
+    organization_url { "http://example.org" }
+    organization_logo { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") }
+    redirect_uri { "https://app.example.org/oauth" }
+    scopes { "public" }
+  end
+
+  factory :oauth_access_token, class: "Doorkeeper::AccessToken" do
+    resource_owner_id { create(:user, organization: application.organization).id }
+    application { build(:oauth_application) }
+    token { SecureRandom.hex(32) }
+    expires_in { 1.month.from_now }
+    created_at { Time.zone.now }
+    scopes { "public" }
+  end
 end

data/lib/decidim/core/test/shared_examples/announcements_examples.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 shared_examples "manage announcements" do
-  it "customize a general announcement for the feature" do
-    visit edit_feature_path(current_feature)
+  it "customize a general announcement for the component" do
+    visit edit_component_path(current_component)
 
     fill_in_i18n_editor(
-      :feature_settings_announcement,
+      :component_settings_announcement,
       "#global-settings-announcement-tabs",
       en: "An important announcement",
       es: "Un aviso muy importante",
@@ -14,7 +14,7 @@ shared_examples "manage announcements" do
 
     click_button "Update"
 
-    visit main_feature_path(current_feature)
+    visit main_component_path(current_component)
 
     within ".callout.secondary" do
       expect(page).to have_content("An important announcement")
@@ -23,7 +23,7 @@ shared_examples "manage announcements" do
 
   context "when the general announcement is set" do
     before do
-      current_feature.update!(
+      current_component.update!(
         settings: {
           announcement: {
             en: "An important announcement",
@@ -35,11 +35,11 @@ shared_examples "manage announcements" do
     end
 
     it "customize an announcement for the current step and it has more priority" do
-      visit edit_feature_path(current_feature)
-      step_id = current_feature.participatory_space.steps.first.id
+      visit edit_component_path(current_component)
+      step_id = current_component.participatory_space.steps.first.id
 
       fill_in_i18n_editor(
-        :"feature_step_settings_#{step_id}_announcement",
+        :"component_step_settings_#{step_id}_announcement",
         "#step-#{step_id}-settings-announcement-tabs",
         en: "An announcement for this step",
         es: "Un aviso para esta fase",
@@ -48,7 +48,7 @@ shared_examples "manage announcements" do
 
       click_button "Update"
 
-      visit main_feature_path(current_feature)
+      visit main_component_path(current_component)
 
       within ".callout.secondary" do
         expect(page).to have_no_content("An important announcement")

data/lib/decidim/core/test/shared_examples/attachable_interface_examples.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "attachable interface" do
+  let!(:attachments) { create_list(:attachment, 3, attached_to: model) }
+
+  describe "attachments" do
+    let(:query) { "{ attachments { url } }" }
+
+    it "includes the attachment urls" do
+      attachment_urls = response["attachments"].map { |attachment| attachment["url"] }
+      expect(attachment_urls).to include(*attachments.map(&:url))
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/authorable_interface_examples.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "authorable interface" do
+  describe "author" do
+    describe "with a regular user" do
+      let(:author) { create(:user, organization: model.participatory_space.organization) }
+      let(:query) { "{ author { name } }" }
+
+      before do
+        model.update(author: author, user_group: nil)
+      end
+
+      it "includes the user's ID" do
+        expect(response["author"]["name"]).to eq(author.name)
+      end
+    end
+
+    describe "with a user group" do
+      let(:user_group) { create(:user_group, organization: model.participatory_space.organization) }
+      let(:query) { "{ author { name } }" }
+
+      before do
+        model.update(user_group: user_group, author: nil)
+      end
+
+      it "includes the user's ID" do
+        expect(response["author"]["name"]).to eq(user_group.name)
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/categorizable_interface_examples.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "categorizable interface" do
+  let!(:category) { create(:category, participatory_space: model.participatory_space) }
+
+  before do
+    model.update(category: category)
+  end
+
+  describe "category" do
+    let(:query) { "{ category { id } }" }
+
+    it "has a category" do
+      expect(response).to include("category" => { "id" => category.id.to_s })
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -115,7 +115,7 @@ shared_examples "comments" do
     end
 
     describe "arguable option" do
-      context "commenting with alignment" do
+      context "when commenting with alignment" do
         before do
           visit resource_path
 
@@ -146,7 +146,7 @@ shared_examples "comments" do
         visit resource_path
       end
 
-      context "upvoting a comment" do
+      context "when upvoting a comment" do
         it "works according to the setting in the commentable" do
           within "#comment_#{comments[0].id}" do
             if commentable.comments_have_votes?
@@ -160,7 +160,7 @@ shared_examples "comments" do
         end
       end
 
-      context "downvoting a comment" do
+      context "when downvoting a comment" do
         it "works according to the setting in the commentable" do
           within "#comment_#{comments[0].id}" do
             if commentable.comments_have_votes?

data/lib/decidim/core/test/shared_examples/follows_examples.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 shared_examples "follows" do
-  include_context "with a feature"
+  include_context "with a component"
 
   before do
     login_as user, scope: :user