RubyGems - cookstyle - Versions diffs - 7.5.2 → 7.8.3 - Mend

cookstyle 7.5.2 → 7.8.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (226) hide show

data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb CHANGED Viewed

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   require 'chef/mixin/command'
         #   include Chef::Mixin::Command
         #
         #   run_command('/bin/foo')
         #   run_command_with_systems_locale('/bin/foo')
         #
-        #   # good
+        #   #### correct
         #   shell_out!('/bin/foo')
         #
         class UsesRunCommandHelper < Base

data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        # bad:
+        #### incorrect:
         #  search(:node, '*:*', 0, 1000, { :ip_address => ["ipaddress"] })
         #  search(:node, '*:*', 0, 1000)
         #  search(:node, '*:*', 0)
-        # good
+        #### correct
         #
         # query(:node, '*:*')
         #  search(:node, '*:*', start: 0, rows: 1000, filter_result: { :ip_address => ["ipaddress"] })

data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   use_inline_resources
         #   use_inline_resources if defined?(use_inline_resources)
         #   use_inline_resources if respond_to?(:use_inline_resources)

data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb CHANGED Viewed

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   {"foo" => "bar"}.to_yaml
         #
-        #   # good
+        #   #### correct
         #   YAML.dump({"foo" => "bar"})
         #
         class UseYamlDump < Base

data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   user "betty" do
         #     supports({
         #       manage_home: true,
@@ -35,7 +35,7 @@ module RuboCop
         #     supports :manage_home => true
         #   end
         #
-        #   # good
+        #   #### correct
         #   user "betty" do
         #     manage_home true
         #     non_unique true

data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   file '/etc/nginx.conf' do
         #     verify 'nginx -t -c %{file}'
         #   end
         #
-        #   # good
+        #   #### correct
         #   file '/etc/nginx.conf' do
         #     verify 'nginx -t -c %{path}'
         #   end

data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   windows_feature 'DHCP' do
         #     install_method :servermanagercmd
         #   end
         #
-        #   # good
+        #   #### correct
         #   windows_feature 'DHCP' do
         #     install_method :windows_feature_dism
         #   end

data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb CHANGED Viewed

@@ -24,14 +24,14 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   windows_package 'AppveyorDeploymentAgent' do
         #     source 'https://www.example.com/appveyor.msi'
         #     installer_type 'msi'
         #     options "/quiet /qn /norestart /log install.log"
         #   end
         #
-        #   # good
+        #   #### correct
         #   windows_package 'AppveyorDeploymentAgent' do
         #     source 'https://www.example.com/appveyor.msi'
         #     installer_type :msi

data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   windows_task 'chef ad-join leave start time' do
         #     task_name 'chef ad-join leave'
         #     start_day '06/09/2016'
@@ -32,7 +32,7 @@ module RuboCop
         #     action [:change, :create]
         #   end
         #
-        #   # good
+        #   #### correct
         #   windows_task 'chef ad-join leave start time' do
         #     task_name 'chef ad-join leave'
         #     start_day '06/09/2016'

data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb CHANGED Viewed

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   Windows::VersionHelper.nt_version
         #   Windows::VersionHelper.server_version?
         #   Windows::VersionHelper.core_version?
         #   Windows::VersionHelper.workstation_version?
         #
-        #   # good
+        #   #### correct
         #   node['platform_version'].to_f
         #   node['kernel']['product_type'] == 'Server'
         #   node['kernel']['server_core']

data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   include_recipe 'xml::ruby'
         #
         class IncludingXMLRubyRecipe < Base

data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   include_recipe 'yum::dnf_yum_compat'
         #
         class IncludingYumDNFCompatRecipe < Base

data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb CHANGED Viewed

@@ -24,22 +24,22 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   require 'chef-vault'
         #
-        #   # bad
+        #   #### incorrect
         #   ChefVault::Item
         #
-        #   # bad
+        #   #### incorrect
         #   include_recipe 'chef-vault'
         #
-        #   # bad
+        #   #### incorrect
         #   chef_gem 'chef-vault'
         #
-        #   # bad
+        #   #### incorrect
         #   chef_vault_item_for_environment(arg, arg1)
         #
-        #   # bad
+        #   #### incorrect
         #   chef_vault_item(arg, arg1)
         #

data/lib/rubocop/cop/chef/effortless/data_bags.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   data_bag_item('admins', login)
         #   data_bag(data_bag_name)
         class CookbookUsesDatabags < Base

data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   depends 'chef-vault'
         #

data/lib/rubocop/cop/chef/effortless/node_environment.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   node.environment == "production"
         #   node.chef_environment == "production"
         #

data/lib/rubocop/cop/chef/effortless/node_policygroup.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   node.policy_group == "foo"
         #
         class CookbookUsesPolicygroups < Base

data/lib/rubocop/cop/chef/effortless/node_roles.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   node.role?('web_server')
         #   node.roles.include?('web_server')
         #

data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   search(:node, 'chef_environment:foo')
         #   search(:node, 'role:bar')
         #

data/lib/rubocop/cop/chef/effortless/search_used.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   search(:node, 'run_list:recipe\[bacula\:\:server\]')
         #
         class CookbookUsesSearch < Base

data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   def action_create
         #    # :create action code here
         #   end
         #
-        #   # good
+        #   #### correct
         #   action :create do
         #    # :create action code here
         #   end

data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   def initialize(*args)
         #     super
         #     @actions = [ :create, :add ]
@@ -35,7 +35,7 @@ module RuboCop
         #     @allowed_actions = [ :create, :add ]
         #   end
         #
-        #   # good
+        #   #### correct
         #   allowed_actions [ :create, :add ]
         #
         class AllowedActionsFromInitialize < Base

data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb CHANGED Viewed

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   include_recipe 'apt::default'
         #   include_recipe 'apt'
         #
-        #   # good
+        #   #### correct
         #   apt_update
         #
         class IncludingAptDefaultRecipe < Base

data/lib/rubocop/cop/chef/modernize/berksfile_source.rb CHANGED Viewed

@@ -19,19 +19,17 @@ module RuboCop
   module Cop
     module Chef
       module Modernize
-        # Over the course of years there have been many different valid community site / Supermarket
-        # URLs to use in a cookbook's Berksfile. These old URLs continue to function via redirects,
-        # but should be updated to point to the latest Supermarket URL.
+        # There have been many different valid community site / Supermarket URLs to use in a cookbook's Berksfile. These old URLs continue to function via redirects, but should be updated to point to the latest Supermarket URL.
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   source 'http://community.opscode.com/api/v3'
         #   source 'https://supermarket.getchef.com'
         #   source 'https://api.berkshelf.com'
         #   site :opscode
         #
-        #   # good
+        #   #### correct
         #   source 'https://supermarket.chef.io'
         #
         class LegacyBerksfileSource < Base

data/lib/rubocop/cop/chef/modernize/build_essential.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   depends 'build-essential'
         #   include_recipe 'build-essential::default'
         #   include_recipe 'build-essential'
         #
-        #   # good
+        #   #### correct
         #   build_essential 'install compilation tools'
         #
         class UseBuildEssentialResource < Base

data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   depends 'build-essential'
         #   depends 'chef_handler'
         #   depends 'chef_hostname'

data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   chef_gem 'nokogiri'
         #
         class ChefGemNokogiri < Base

data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   build_essential 'install build tools' do
         #    action :nothing
         #   end.run_action(:install)
         #
-        #   # good
+        #   #### correct
         #   build_essential 'install build tools' do
         #    compile_time true
         #   end

data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb CHANGED Viewed

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   only_if 'test -f /bin/foo'
         #
-        #   # good
+        #   #### correct
         #   only_if { ::File.exist?('bin/foo') }
         #
         class ConditionalUsingTest < Base

data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   template '/etc/cron.d/backup' do
         #     source 'cron_backup_job.erb'
         #     owner 'root'
@@ -48,7 +48,7 @@ module RuboCop
         #     action :delete
         #   end
         #
-        #   # good
+        #   #### correct
         #   cron_d 'backup' do
         #     minute '1'
         #     hour '1'

data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb CHANGED Viewed

@@ -19,14 +19,14 @@ module RuboCop
   module Cop
     module Chef
       module Modernize
-        # The cron_manage resource was renamed to cron_access in the 6.1 release of the cron
-        # cookbook, and later shipped in Chef Infra Client 14.4. The new resource name should
-        # be used.
+        # The cron_manage resource was renamed to cron_access in the 6.1 release of the cron cookbook, and later shipped in Chef Infra Client 14.4. The new resource name should be used.
         #
-        #   # bad
+        # @example
+        #
+        #   #### incorrect
         #   cron_manage 'mike'
         #
-        #   # good
+        #   #### correct
         #   cron_access 'mike'
         #
         class CronManageResource < Base