RubyGems - cookstyle - Versions diffs - 7.5.2 → 7.8.3 - Mend

cookstyle 7.5.2 → 7.8.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (226) hide show

data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb CHANGED Viewed

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   not_if { File.exist?('/etc/foo/bar') }
         #
-        #   # good
+        #   #### correct
         #   not_if { ::File.exist?('/etc/foo/bar') }
         #
         class ScopedFileExist < Base

data/lib/rubocop/cop/chef/correctness/service_resource.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example when command starts a service
         #
-        #   # bad
+        #   #### incorrect
         #   command "/etc/init.d/mysql start"
         #   command "/sbin/service/memcached start"
         #

data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb CHANGED Viewed

@@ -24,10 +24,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   supports 'redhat', '> 8'
         #
-        #   # good
+        #   #### correct
         #   supports 'redhat', '> 8.0'
         #
         class SupportsMustBeFloat < Base

data/lib/rubocop/cop/chef/correctness/tmp_path.rb CHANGED Viewed

@@ -23,13 +23,12 @@ module RuboCop
         #
         # @example downloading a large file into /tmp/
         #
-        #   # bad
+        #   #### incorrect
         #   remote_file '/tmp/large-file.tar.gz' do
         #
-        #   # good
+        #   #### correct
         #   remote_file "#{Chef::Config[:file_cache_path]}/large-file.tar.gz" do
         #
-        #
         class TmpPath < Base
           MSG = 'Use file_cache_path rather than hard-coding tmp paths'
           RESTRICT_ON_SEND = [:remote_file].freeze

data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   module MyCookbook
         #     class MyCookbookService < Chef::Resource
         #       use_automatic_resource_name

data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb CHANGED Viewed

@@ -23,11 +23,11 @@ module RuboCop
       #
       # @example
       #
-      #   # bad
+      #   #### incorrect
       #   name 'foo'
       #   depends 'foo'
       #
-      #   # good
+      #   #### correct
       #   name 'foo'
       #
       module Deprecations

data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   include_recipe 'chef_handler'
         #   include_recipe 'chef_handler::default'
         #

data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb CHANGED Viewed

@@ -24,12 +24,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   chef_handler 'whatever' do
         #     supports start: true, report: true, exception: true
         #   end0
         #
-        #   # good
+        #   #### correct
         #   chef_handler 'whatever' do
         #     type start: true, report: true, exception: true
         #   end

data/lib/rubocop/cop/chef/deprecation/chef_rest.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   require 'chef/rest'
         #   Chef::REST::RESTRequest.new(:GET, FOO, nil).call
         #

data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb CHANGED Viewed

@@ -26,12 +26,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   include Chef::ShellOut
         #   require 'chef/shellout'
         #   Chef::ShellOut.new('some_command')
         #
-        #   # good
+        #   #### correct
         #   include Mixlib::ShellOut
         #   require 'mixlib/shellout'
         #   Mixlib::ShellOut.new('some_command')

data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
       #
       # @example
       #
-      #   # bad
+      #   #### incorrect
       #   vagrant_key?
       #   vagrant_domain?
       #   vagrant_user?

data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb CHANGED Viewed

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   Chef::Platform.windows?
         #
-        #   # good
+        #   #### correct
         #   platform?('windows')
         #   platform_family?('windows')
         #

data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb CHANGED Viewed

@@ -24,14 +24,14 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   ChefDK::CLI
         #   ChefDK::Generator::TemplateHelper
         #   module ChefDK
         #     ...
         #   end
         #
-        #   # good
+        #   #### correct
         #   ChefCLI::CLI
         #   ChefCLI::Generator::TemplateHelper
         #   module ChefCLI

data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #
         #   at_exit { ChefSpec::Coverage.report! }
         #

data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #
         #   describe 'foo::default' do
         #     subject { ChefSpec::Runner.new.converge(described_recipe) }
@@ -32,7 +32,7 @@ module RuboCop
         #     # some spec code
         #   end
         #
-        #   # good
+        #   #### correct
         #
         #   describe 'foo::default' do
         #     subject { ChefSpec::ServerRunner.new.converge(described_recipe) }

data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb CHANGED Viewed

@@ -24,12 +24,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   chocolatey_package 'nginx' do
         #     action :uninstall
         #   end
         #
-        #   # good
+        #   #### correct
         #   chocolatey_package 'nginx' do
         #     action :remove
         #   end

data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   depends 'compat_resource'
         #
         class CookbookDependsOnCompatResource < Base

data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   depends 'partial_search'
         #
         class CookbookDependsOnPartialSearch < Base

data/lib/rubocop/cop/chef/deprecation/depends_poise.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   depends 'poise'
         #   depends 'poise-service'
         #

data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb CHANGED Viewed

@@ -64,7 +64,7 @@ module RuboCop
             'opensuse' => {
               '< 14' => true,
               '~> 42.0' => true,
-              '= 15.0' => '15',
+              '~> 15.0, < 15.2' => '15',
             },
             'debian' => {
               '< 9' => true,
@@ -73,12 +73,12 @@ module RuboCop
             'centos' => {
               '< 6.0' => true,
               '~> 6.0, < 6.10' => '6',
-              '~> 7.0, < 7.6 ' => '7',
+              '~> 7.0, < 7.7 ' => '7',
             },
             'redhat' => {
               '< 6.0' => true,
               '~> 6.0, < 6.10' => '6',
-              '~> 7.0, < 7.6' => '7',
+              '~> 7.0, < 7.7' => '7',
             },
             'oracle' => {
               '< 6.0' => true,

data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   include Chef::Mixin::LanguageIncludeAttribute
         #   include Chef::Mixin::RecipeDefinitionDSLCore
         #   include Chef::Mixin::LanguageIncludeRecipe

data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   resource = Chef::Resource::File.new("/tmp/foo.xyz", run_context)
         #   provider = Chef::Platform.provider_for_resource(resource, :create)
         #
@@ -36,7 +36,7 @@ module RuboCop
         #
         #   Chef::Platform.set :platform => :mac_os_x, :resource => :package, :provider => Chef::Provider::Package::Homebrew
         #
-        #   # good
+        #   #### correct
         #   resource = Chef::Resource::File.new("/tmp/foo.xyz", run_context)
         #   provider = resource.provider_for_action(:create)
         #

data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   shell_out_compact('foo')
         #   shell_out_compact!('foo')
         #   shell_out_with_timeout('foo')
@@ -34,7 +34,7 @@ module RuboCop
         #   shell_out_compact_timeout('foo')
         #   shell_out_compact_timeout!('foo')
         #
-        #   # good
+        #   #### correct
         #   shell_out('foo')
         #   shell_out!('foo')
         #   shell_out!('foo', default_env: false) # replaces shell_out_with_systems_locale

data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   if older_than_win_2012_or_8?
         #     # do some legacy things
         #   end

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     baseurl 'http://artifacts.ourco.org/foo/bar'
@@ -31,7 +31,7 @@ module RuboCop
         #     action :add
         #   end
         #
-        #   # good
+        #   #### correct
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     baseurl 'http://artifacts.ourco.org/foo/bar'

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     url 'http://artifacts.ourco.org/foo/bar'
@@ -32,7 +32,7 @@ module RuboCop
         #     action :create
         #   end
         #
-        #   # good
+        #   #### correct
         #   yum_repository 'OurCo' do
         #     description 'OurCo yum repository'
         #     baseurl 'http://artifacts.ourco.org/foo/bar'

data/lib/rubocop/cop/chef/deprecation/easy_install.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   easy_install "my_thing" do
         #     bar
         #   end

data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   control_group 'Baseline' do
         #     control 'SSH' do
         #       it 'should be listening on port 22' do

data/lib/rubocop/cop/chef/deprecation/epic_fail.rb CHANGED Viewed

@@ -24,12 +24,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   package "foo" do
         #     epic_fail true
         #   end
         #
-        #   # good
+        #   #### correct
         #   package "foo" do
         #     ignore_failure true
         #   end

data/lib/rubocop/cop/chef/deprecation/erl_call.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   erl_call "foo" do
         #     bar
         #   end

data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb CHANGED Viewed

@@ -24,12 +24,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   execute 'some_cmd' do
         #     path '/foo/bar'
         #   end
         #
-        #   # good
+        #   #### correct
         #   execute 'some_cmd' do
         #     environment {path: '/foo/bar'}
         #   end

data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb CHANGED Viewed

@@ -24,12 +24,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   execute 'some_cmd' do
         #     creates 'something'
         #   end
         #
-        #   # good
+        #   #### correct
         #   execute 'some_cmd' do
         #     creates '/tmp/something'
         #   end