RubyGems - cookstyle - Versions diffs - 7.5.2 → 7.8.3 - Mend

cookstyle 7.5.2 → 7.8.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (226) hide show

data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   cookbook_file '/logs/foo/error.log' do
         #     source 'error.log'
         #     only_if { system('wget https://www.bar.com/foobar.txt -O /dev/null') }
@@ -34,7 +34,7 @@ module RuboCop
         #     only_if { shell_out('wget https://www.bar.com/foobar.txt -O /dev/null').exitstatus == 0 }
         #   end
         #
-        #   # good
+        #   #### correct
         #   cookbook_file '/logs/foo/error.log' do
         #     source 'error.log'
         #     only_if 'wget https://www.bar.com/foobar.txt -O /dev/null'

data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb CHANGED Viewed

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   dnf_package 'nginx' do
         #     version '1.2.3'
         #     allow_downgrades true
         #   end
         #
-        #   # good
+        #   #### correct
         #   dnf_package 'nginx' do
         #     version '1.2.3'
         #   end

data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb CHANGED Viewed

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   ::Chef::Recipe.send(:include, Filebeat::Helpers)
         #   ::Chef::Provider.send(:include, Filebeat::Helpers)
         #   ::Chef::Recipe.include Filebeat::Helpers
         #   ::Chef::Provider.include Filebeat::Helpers
         #
-        #   # good
+        #   #### correct
         #   ::Chef::DSL::Recipe.send(:include, Filebeat::Helpers) # covers previous Recipe & Provider classes
         #
         class IncorrectLibraryInjection < Base

data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb CHANGED Viewed

@@ -23,10 +23,10 @@ module RuboCop
       #
       # @example
       #
-      #   # bad
+      #   #### incorrect
       #   default_action 'create'
       #
-      #   # good
+      #   #### correct
       #   default_action :create
       #
       module Correctness

data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb CHANGED Viewed

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #
         #   template '/etc/www/configures-apache.conf' do
         #     notifies :restart, 'service[apache]', :nope
         #   end
         #
-        #   # good
+        #   #### correct
         #
         #   template '/etc/www/configures-apache.conf' do
         #     notifies :restart, 'service[apache]', :immediately

data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb CHANGED Viewed

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   platform_family?('redhat')
         #   platform_family?('sles')
         #
-        #   # bad
+        #   #### incorrect
         #   platform_family?('rhel')
         #   platform_family?('suse')
         #

data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   case node['platform_family']
         #   when 'redhat'
         #     puts "I'm on a RHEL-like system"

data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   platform?('darwin')
         #   platform?('rhel)
         #   platform?('sles')
         #
-        #   # good
+        #   #### correct
         #   platform?('mac_os_x')
         #   platform?('redhat)
         #   platform?('suse')

data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb CHANGED Viewed

@@ -24,11 +24,11 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   supports 'darwin'
         #   supports 'mswin'
         #
-        #   # good
+        #   #### correct
         #   supports 'mac_os_x'
         #   supports 'windows'
         #

data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   case node['platform']
         #   when 'rhel'
         #     puts "I'm on a Red Hat system!"

data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb CHANGED Viewed

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   value_for_platform_family(
         #     %w(rhel sles) => 'foo',
         #     %w(mac) => 'foo'
         #   )
         #
-        #   # good
+        #   #### correct
         #   value_for_platform_family(
         #     %w(rhel suse) => 'foo',
         #     %w(mac_os_x) => 'foo'

data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   value_for_platform(
         #     %w(rhel mac_os_x_server) => { 'default' => 'foo' },
         #     %w(sles) => { 'default' => 'bar' }
         #   )
-        #   # good
+        #   #### correct
         #   value_for_platform(
         #     %w(redhat mac_os_x) => { 'default' => 'foo' },
         #     %w(opensuseleap) => { 'default' => 'bar' }

data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb CHANGED Viewed

@@ -24,10 +24,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   version '1.2.3.4'
         #
-        #   # good
+        #   #### correct
         #   version '1.2.3'
         #
         class InvalidVersionMetadata < Base

data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb CHANGED Viewed

@@ -24,10 +24,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   property :Something, String, default: node['hostname']
         #
-        #   # good
+        #   #### correct
         #   property :Something, String, default: lazy { node['hostname'] }
         #
         class LazyEvalNodeAttributeDefaults < Base

data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb CHANGED Viewed

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   template '/etc/foo' do
         #     mode '0644'
         #     source 'foo.erb'
         #     only_if { lazy { ::File.exist?('/etc/foo')} }
         #   end
         #
-        #   # good
+        #   #### correct
         #   template '/etc/foo' do
         #     mode '0644'
         #     source 'foo.erb'

data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb CHANGED Viewed

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   macos_userdefaults 'set a value' do
         #     global true
         #     key 'key'
         #     type 'boolean'
         #   end
         #
-        #   # good
+        #   #### correct
         #   macos_userdefaults 'set a value' do
         #     global true
         #     key 'key'

data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   value_for_platform(
         #     %w(redhat oracle) => 'baz'
         #   )
         #
-        #   # good
+        #   #### correct
         #   value_for_platform(
         #     %w(redhat oracle) => {
         #       '5' => 'foo',

data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb CHANGED Viewed

@@ -23,7 +23,7 @@ module RuboCop
       #
       # @example
       #
-      #   # good
+      #   #### correct
       #   name 'foo'
       #
       module Correctness

data/lib/rubocop/cop/chef/correctness/node_normal.rb CHANGED Viewed

@@ -28,10 +28,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   node.normal['foo'] = true
         #
-        #   # good
+        #   #### correct
         #   node.default['foo'] = true
         #   node.override['foo'] = true
         #   node.force_default['foo'] = true

data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb CHANGED Viewed

@@ -28,10 +28,10 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   node.normal_unless['foo'] = true
         #
-        #   # good
+        #   #### correct
         #   node.default_unless['foo'] = true
         #   node.override_unless['foo'] = true
         #   node.force_default_unless['foo'] = true

data/lib/rubocop/cop/chef/correctness/node_save.rb CHANGED Viewed

@@ -25,7 +25,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   node.save
         #
         class CookbookUsesNodeSave < Base

data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb CHANGED Viewed

@@ -24,7 +24,7 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   execute 'some command' do
         #     notifies 'restart', 'service[httpd]', 'delayed'
         #   end
@@ -33,7 +33,7 @@ module RuboCop
         #     subscribes 'restart', 'service[httpd]', 'delayed'
         #   end
         #
-        #   # good
+        #   #### correct
         #   execute 'some command' do
         #     notifies :restart, 'service[httpd]', 'delayed'
         #   end

data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb CHANGED Viewed

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   file '/etc/some_file' do
         #     mode '0o755'
         #   end
         #
-        #   # good
+        #   #### correct
         #   file '/etc/some_file' do
         #     mode '0755'
         #   end

data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb CHANGED Viewed

@@ -21,7 +21,7 @@ module RuboCop
       module Correctness
         # The openSSL cookbook provides a deprecated `secure_password` helper in the `Opscode::OpenSSL::Password` class, which should not longer be used. This helper would generate a random password that would be used when a data bag or attribute was no present. The practice of generating passwords to be stored on the node is bad security as it exposes the password to anyone that can view the nodes, and deleting a node deletes the password. Passwords should be retrieved from a secure source for use in cookbooks.
         #
-        #   # bad
+        #   #### incorrect
         #   ::Chef::Recipe.send(:include, Opscode::OpenSSL::Password)
         #   basic_auth_password = secure_password
         #

data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb CHANGED Viewed

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   powershell_script 'Cleanup old files' do
         #     code 'Remove-Item C:\Windows\foo\bar.txt'
         #     only_if { ::File.exist?('C:\\Windows\\foo\\bar.txt') }
         #   end
         #
-        #  # good
+        #  #### correct
         #  file 'C:\Windows\foo\bar.txt' do
         #    action :delete
         #  end

data/lib/rubocop/cop/chef/correctness/property_without_type.rb CHANGED Viewed

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   property :size, regex: /^\d+[KMGTP]$/
         #   attribute :size, regex: /^\d+[KMGTP]$/
         #
-        #   # good
+        #   #### correct
         #   property :size, String, regex: /^\d+[KMGTP]$/
         #   attribute :size, kind_of: String, regex: /^\d+[KMGTP]$/
         #

data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb CHANGED Viewed

@@ -25,13 +25,13 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   service 'foo' do
         #     running true
         #     action [:start, :enable]
         #   end
         #
-        #   # good
+        #   #### correct
         #   service 'foo' do
         #     action [:start, :enable]
         #   end

data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb CHANGED Viewed

@@ -20,17 +20,16 @@ module RuboCop
   module Cop
     module Chef
       module Correctness
-        # Use name properties instead of setting the name property in a resource. Setting the name property
-        # directly causes notification and reporting issues.
+        # Use name properties instead of setting the name property in a resource. Setting the name property directly causes notification and reporting issues.
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   service 'foo' do
         #    name 'bar'
         #   end
         #
-        #   # good
+        #   #### correct
         #   service 'foo' do
         #    service_name 'bar'
         #   end

data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb CHANGED Viewed

@@ -24,12 +24,12 @@ module RuboCop
         #
         # @example
         #
-        #   # bad
+        #   #### incorrect
         #   service 'foo' do
         #    action :none
         #   end
         #
-        #   # good
+        #   #### correct
         #   service 'foo' do
         #    action :nothing
         #   end