cookstyle 7.5.2 → 7.8.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (226) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -1
  3. data/bin/cookstyle +7 -2
  4. data/config/cookstyle.yml +240 -231
  5. data/config/disable_all.yml +22 -0
  6. data/config/upstream.yml +137 -31
  7. data/lib/cookstyle/version.rb +2 -2
  8. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +4 -4
  9. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -2
  10. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +2 -2
  11. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -2
  12. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +2 -2
  13. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +2 -2
  14. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -2
  15. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
  16. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  17. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -2
  18. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
  19. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
  21. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
  22. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -2
  23. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -2
  24. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +2 -2
  25. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +2 -2
  26. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +2 -2
  27. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  28. data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -2
  29. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -2
  30. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +2 -2
  32. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +2 -2
  33. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +2 -2
  35. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +2 -2
  36. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -2
  37. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +3 -4
  38. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -2
  39. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -2
  40. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +2 -2
  42. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -3
  43. data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb +1 -1
  44. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +2 -2
  45. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  46. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +2 -2
  47. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
  48. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +2 -2
  49. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
  50. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
  51. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +2 -2
  52. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -2
  54. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -2
  55. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  57. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +3 -3
  59. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
  60. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -2
  61. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -2
  62. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +2 -2
  64. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -2
  65. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  66. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  67. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -2
  68. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +2 -2
  70. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +2 -2
  71. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  72. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +4 -4
  73. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +2 -2
  74. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -2
  75. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +3 -3
  76. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -2
  80. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +2 -2
  81. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -2
  82. data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +4 -4
  83. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -2
  84. data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -2
  85. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -2
  86. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
  87. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +2 -2
  88. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -2
  89. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
  90. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -2
  91. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -2
  92. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
  93. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +2 -2
  94. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  95. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +3 -3
  97. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +2 -2
  98. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -2
  99. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -2
  100. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +2 -2
  101. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  102. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +2 -2
  103. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
  104. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -2
  105. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -2
  106. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +2 -2
  107. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +2 -2
  108. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -2
  109. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  110. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  111. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +6 -6
  112. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  113. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  114. data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
  115. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
  116. data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
  117. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  118. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  119. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +2 -2
  120. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
  121. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
  122. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +3 -5
  123. data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -2
  124. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  125. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
  126. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -2
  127. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +2 -2
  128. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +2 -2
  129. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +5 -5
  130. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -2
  131. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +3 -3
  132. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  133. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  134. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +3 -1
  135. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +5 -4
  137. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +6 -4
  138. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +4 -2
  139. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +4 -2
  140. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +5 -4
  141. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  142. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -2
  143. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +2 -2
  145. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +5 -4
  146. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  147. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
  148. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -2
  149. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +2 -4
  150. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +5 -4
  151. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +5 -4
  152. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +5 -4
  153. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +2 -3
  154. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -2
  155. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +3 -4
  156. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +3 -4
  157. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -2
  158. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +2 -2
  159. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
  160. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +3 -5
  161. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +3 -5
  162. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +4 -2
  163. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +3 -4
  164. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +2 -2
  165. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -2
  166. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +6 -4
  167. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  168. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -2
  169. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
  170. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +2 -2
  171. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +4 -2
  172. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  173. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
  174. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
  175. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +4 -2
  178. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  179. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
  180. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -2
  181. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +4 -2
  182. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +4 -2
  183. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  184. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  185. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  186. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +4 -2
  187. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  188. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  189. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +2 -2
  190. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +2 -3
  191. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +2 -2
  192. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +2 -2
  193. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -2
  194. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  195. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  196. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  197. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  198. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +3 -1
  199. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -2
  200. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  201. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -2
  202. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  203. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
  204. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +2 -2
  205. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -2
  206. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +2 -2
  207. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  208. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  209. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +2 -2
  210. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +57 -3
  211. data/lib/rubocop/cop/chef/style/attribute_keys.rb +4 -4
  212. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -2
  213. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +9 -9
  214. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -2
  215. data/lib/rubocop/cop/chef/style/comments_format.rb +2 -2
  216. data/lib/rubocop/cop/chef/style/file_mode.rb +2 -2
  217. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -2
  218. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +2 -2
  219. data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -2
  220. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -2
  221. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +2 -2
  222. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
  223. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +2 -2
  224. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +2 -2
  225. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +2 -2
  226. metadata +5 -5
@@ -25,19 +25,19 @@ module RuboCop
25
25
  #
26
26
  # @example when configuration is `EnforcedStyle: symbols`
27
27
  #
28
- # # bad
28
+ # #### incorrect
29
29
  # node['foo']
30
30
  # node["foo"]
31
31
  #
32
- # # good
32
+ # #### correct
33
33
  # node[:foo]
34
34
  #
35
35
  # @example when configuration is `EnforcedStyle: strings`
36
36
  #
37
- # # bad
37
+ # #### incorrect
38
38
  # node[:foo]
39
39
  #
40
- # # good
40
+ # #### correct
41
41
  # node['foo']
42
42
  # node["foo"]
43
43
  #
@@ -24,11 +24,11 @@ module RuboCop
24
24
  #
25
25
  # @example
26
26
  #
27
- # # bad
27
+ # #### incorrect
28
28
  # Chef makes software
29
29
  # Chef configures your systems
30
30
  #
31
- # # good
31
+ # #### correct
32
32
  # Chef Software makes software
33
33
  # Chef Infra configures your systems
34
34
  #
@@ -24,18 +24,18 @@ module RuboCop
24
24
  #
25
25
  # @example
26
26
  #
27
- # # bad (assuming current year is 2019)
28
- # Copyright:: 2013-2019 Opscode, Inc.
29
- # Copyright:: 2013-2019 Chef Inc.
30
- # Copyright:: 2013-2019 Chef Software Inc.
31
- # Copyright:: 2009-2010 2013-2019 Chef Software Inc.
27
+ # #### incorrect
28
+ # Copyright:: 2013-2022 Opscode, Inc.
29
+ # Copyright:: 2013-2022 Chef Inc.
30
+ # Copyright:: 2013-2022 Chef Software Inc.
31
+ # Copyright:: 2009-2010 2013-2022 Chef Software Inc.
32
32
  # Copyright:: Chef Software Inc.
33
33
  # Copyright:: Tim Smith
34
- # Copyright:: Copyright (c) 2015-2019 Chef Software, Inc.
34
+ # Copyright:: Copyright (c) 2015-2022 Chef Software, Inc.
35
35
  #
36
- # # good (assuming current year is 2019)
37
- # Copyright:: 2013-2019 Chef Software, Inc.
38
- # Copyright:: 2013-2019 Tim Smith
36
+ # #### correct
37
+ # Copyright:: 2013-2022 Chef Software, Inc.
38
+ # Copyright:: 2013-2022 Tim Smith
39
39
  # Copyright:: 2019 37Signals, Inc.
40
40
  #
41
41
  class CopyrightCommentFormat < Base
@@ -24,11 +24,11 @@ module RuboCop
24
24
  #
25
25
  # @example
26
26
  #
27
- # # bad
27
+ # #### incorrect
28
28
  # Copyright:: 2019 YOUR_NAME
29
29
  # Copyright:: 2019 YOUR_COMPANY_NAME
30
30
  #
31
- # # good
31
+ # #### correct
32
32
  # Copyright:: 2019 Tim Smith
33
33
  # Copyright:: 2019 Chef Software, Inc.
34
34
  #
@@ -24,7 +24,7 @@ module RuboCop
24
24
  #
25
25
  # @example
26
26
  #
27
- # # bad
27
+ # #### incorrect
28
28
  # Copyright 2013-2016 Chef Software, Inc.
29
29
  # Recipe default.rb
30
30
  # Attributes default.rb
@@ -33,7 +33,7 @@ module RuboCop
33
33
  # Cookbook Name:: Tomcat
34
34
  # Attributes File:: default
35
35
  #
36
- # # good
36
+ # #### correct
37
37
  # Copyright:: 2013-2016 Chef Software, Inc.
38
38
  # Recipe:: default.rb
39
39
  # Attributes:: default.rb
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # remote_directory '/etc/my.conf' do
28
28
  # content 'some content'
29
29
  # mode 0600
@@ -37,7 +37,7 @@ module RuboCop
37
37
  # action :create
38
38
  # end
39
39
  #
40
- # # good
40
+ # #### correct
41
41
  # remote_directory '/etc/my.conf' do
42
42
  # content 'some content'
43
43
  # mode '600'
@@ -23,13 +23,13 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  #
28
28
  # template '/etc/www/configures-apache.conf' do
29
29
  # notifies :restart, 'service[apache]', :immediate
30
30
  # end
31
31
  #
32
- # # good
32
+ # #### correct
33
33
  #
34
34
  # template '/etc/www/configures-apache.conf' do
35
35
  # notifies :restart, 'service[apache]', :immediately
@@ -24,10 +24,10 @@ module RuboCop
24
24
  #
25
25
  # @example
26
26
  #
27
- # # bad
27
+ # #### incorrect
28
28
  # include_recipe('foo::bar')
29
29
  #
30
- # # good
30
+ # #### correct
31
31
  # include_recipe 'foo::bar'
32
32
  #
33
33
  class IncludeRecipeWithParentheses < Base
@@ -23,12 +23,12 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # package 'legacy-sysv-deps' do
28
28
  # only_if { !systemd }
29
29
  # end
30
30
  #
31
- # # good
31
+ # #### correct
32
32
  # package 'legacy-sysv-deps' do
33
33
  # not_if { systemd }
34
34
  # end
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  #
28
28
  # %w( debian ubuntu ).each do |os|
29
29
  # supports os
@@ -33,7 +33,7 @@ module RuboCop
33
33
  # depends cb
34
34
  # end
35
35
  #
36
- # # good
36
+ # #### correct
37
37
  #
38
38
  # supports 'debian'
39
39
  # supports 'ubuntu'
@@ -23,13 +23,13 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # node['platform_version'].split('.').first
28
28
  # node['platform_version'].split('.')[0]
29
29
  # node['platform_version'].split('.').first.to_i
30
30
  # node['platform_version'].split('.')[0].to_i
31
31
  #
32
- # # good
32
+ # #### correct
33
33
  #
34
34
  # # check to see if we're on RHEL 7 on a RHEL 7.6 node where node['platform_version] is 7.6.1810
35
35
  # if node['platform_version'].to_i == 7
@@ -23,10 +23,10 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # property :foo, [TrueClass, FalseClass]
28
28
  #
29
- # # good
29
+ # #### correct
30
30
  # property :foo, [true, false]
31
31
  #
32
32
  class TrueClassFalseClassResourceProperties < Base
@@ -23,13 +23,13 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # node['os'] == 'darwin'
28
28
  # node['os'] == 'windows'
29
29
  # node['os'].eql?('aix')
30
30
  # %w(netbsd openbsd freebsd).include?(node['os'])
31
31
  #
32
- # # good
32
+ # #### correct
33
33
  # platform_family?('mac_os_x')
34
34
  # platform_family?('windows')
35
35
  # platform_family?('aix')
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # case node['platform']
28
28
  # when 'ubuntu'
29
29
  # log "We're on Ubuntu"
@@ -35,7 +35,7 @@ module RuboCop
35
35
  # include_recipe 'yum'
36
36
  # end
37
37
  #
38
- # # good
38
+ # #### correct
39
39
  # if platform?('ubuntu')
40
40
  # log "We're on Ubuntu"
41
41
  # apt_update
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # # bad
26
+ # #### incorrect
27
27
  # node['platform'] == 'ubuntu'
28
28
  # node['platform_family'] == 'debian'
29
29
  # node['platform'] != 'ubuntu'
@@ -31,7 +31,7 @@ module RuboCop
31
31
  # %w(rhel suse).include?(node['platform_family'])
32
32
  # node['platform'].eql?('ubuntu')
33
33
  #
34
- # # good
34
+ # #### correct
35
35
  # platform?('ubuntu')
36
36
  # !platform?('ubuntu')
37
37
  # platform_family?('debian')
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cookstyle
3
3
  version: !ruby/object:Gem::Version
4
- version: 7.5.2
4
+ version: 7.8.3
5
5
  platform: ruby
6
6
  authors:
7
7
  - Thom May
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2020-12-31 00:00:00.000000000 Z
12
+ date: 2021-02-17 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rubocop
@@ -17,14 +17,14 @@ dependencies:
17
17
  requirements:
18
18
  - - '='
19
19
  - !ruby/object:Gem::Version
20
- version: 1.7.0
20
+ version: 1.10.0
21
21
  type: :runtime
22
22
  prerelease: false
23
23
  version_requirements: !ruby/object:Gem::Requirement
24
24
  requirements:
25
25
  - - '='
26
26
  - !ruby/object:Gem::Version
27
- version: 1.7.0
27
+ version: 1.10.0
28
28
  description:
29
29
  email:
30
30
  - thom@chef.io
@@ -303,7 +303,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
303
303
  - !ruby/object:Gem::Version
304
304
  version: '0'
305
305
  requirements: []
306
- rubygems_version: 3.0.3
306
+ rubygems_version: 3.1.4
307
307
  signing_key:
308
308
  specification_version: 4
309
309
  summary: Cookstyle is a code linting tool that helps you to write better Chef Infra