cisco_node_utils 1.2.0 → 1.3.0

data/tests/test_vtp.rb

@@ -17,20 +17,16 @@ require_relative '../lib/cisco_node_utils/vtp'
 
 # TestVtp - Minitest for Vtp node utility class
 class TestVtp < CiscoTestCase
+  @skip_unless_supported = 'vtp'
+
   def setup
     super
-    no_feature_vtp
+    config('no feature vtp')
   end
 
   def teardown
-    no_feature_vtp
-    super
-  end
-
-  def no_feature_vtp
-    # VTP will raise an error if the domain is configured twice so we need to
-    # turn the feature off for a clean test.
     config('no feature vtp')
+    super
   end
 
   def vtp_domain(domain)
@@ -39,19 +35,19 @@ class TestVtp < CiscoTestCase
     vtp
   end
 
-  def test_vtp_disabled
+  def test_disabled
     vtp = Vtp.new(false)
     assert_empty(vtp.domain)
     assert_equal(vtp.default_password, vtp.password)
     assert_equal(vtp.default_filename, vtp.filename)
     assert_equal(vtp.default_version, vtp.version)
-    refute(Vtp.enabled, 'VTP feature was unexpectedly enabled?')
+    refute(Feature.vtp_enabled?, 'VTP feature was unexpectedly enabled?')
   end
 
-  def test_vtp_enabled_but_no_domain
+  def test_enabled_but_no_domain
     vtp = Vtp.new(false)
     config('feature vtp')
-    assert(Vtp.enabled)
+    assert(Feature.vtp_enabled?)
     assert_empty(vtp.domain)
     assert_equal(vtp.default_password, vtp.password)
     assert_equal(vtp.default_filename, vtp.filename)
@@ -62,12 +58,12 @@ class TestVtp < CiscoTestCase
     vtp.version = 1
     assert_equal(1, vtp.version)
     # Can't set any of the below without setting a domain first
-    assert_raises(RuntimeError) do
+    assert_raises(CliError) do
       vtp.password = 'hello'
     end
   end
 
-  def test_vtp_domain_enable_disable
+  def test_domain_enable_disable
     assert_empty(Vtp.domain)
     vtp = vtp_domain('enable')
     assert_equal('enable', Vtp.domain)
@@ -75,57 +71,41 @@ class TestVtp < CiscoTestCase
     assert_empty(Vtp.domain)
   end
 
-  def test_vtp_create_valid
-    vtp_domain('accounting')
-    s = @device.cmd("show run vtp | incl '^vtp domain'")
-    assert_match(/^vtp domain accounting/, s,
-                 'Error: failed to create vtp domain')
+  def test_create_valid
+    vtp = vtp_domain('accounting')
+    assert_equal('accounting', vtp.domain)
   end
 
-  def test_vtp_domain_name_change
+  def test_domain_name_change
     vtp = vtp_domain('accounting')
     vtp_domain('uplink')
     assert_equal('uplink', vtp.domain,
                  'Error: vtp domain name incorrect')
   end
 
-  def test_vtp_create_preconfig_no_change
-    config('feature vtp', 'vtp domain accounting')
+  def test_negative
+    assert_raises(ArgumentError) { vtp_domain(nil) }
+    assert_raises(ArgumentError) { vtp_domain('') }
 
+    # Create the same domain twice
     vtp = vtp_domain('accounting')
-    assert_equal('accounting', vtp.domain,
-                 'Error: vtp domain wrong')
-  end
+    assert_raises(Cisco::CliError) { vtp_domain('accounting') }
 
-  def test_vtp_create_double
-    vtp = vtp_domain('accounting')
-    vtp_new = vtp_domain('accounting')
+    # Set password to nil
+    assert_raises(TypeError) { vtp.password = nil }
 
-    assert_equal('accounting', vtp.domain,
-                 'Error: vtp domain wrong')
-    assert_equal('accounting', vtp_new.domain,
-                 'Error: vtp_new domain wrong')
-  end
-
-  def test_vtp_create_domain_invalid
-    assert_raises(ArgumentError) do
-      vtp_domain(node)
-    end
-  end
+    # Password too long
+    password = 'a' * (Vtp::MAX_VTP_PASSWORD_SIZE + 1)
+    assert_raises(ArgumentError) { vtp.password = password }
 
-  def test_vtp_create_domain_nil
-    assert_raises(ArgumentError) do
-      vtp_domain(nil)
-    end
-  end
+    # Set filename to nil
+    assert_raises(TypeError) { vtp.filename = nil }
 
-  def test_vtp_create_domain_empty
-    assert_raises(ArgumentError) do
-      vtp_domain('')
-    end
+    # Invalid version
+    assert_raises(Cisco::CliError) { vtp.version = 34 }
   end
 
-  def test_vtp_assignment
+  def test_assignment
     vtp = vtp_domain('accounting')
     vtp.password = 'copy_test'
     assert_equal('copy_test', vtp.password,
@@ -135,20 +115,13 @@ class TestVtp < CiscoTestCase
                  'Error: vtp password not set')
   end
 
-  def test_vtp_domain_get
+  def test_domain_get
     vtp = vtp_domain('accounting')
     assert_equal('accounting', vtp.domain,
                  'Error: vtp domain incorrect')
   end
 
-  def test_vtp_password_nil
-    vtp = vtp_domain('accounting')
-    assert_raises(TypeError) do
-      vtp.password = nil
-    end
-  end
-
-  def test_vtp_password_default
+  def test_password_default
     vtp = vtp_domain('accounting')
     vtp.password = 'test_me'
     assert_equal('test_me', vtp.password,
@@ -159,14 +132,14 @@ class TestVtp < CiscoTestCase
                  'Error: vtp password not correct')
   end
 
-  def test_vtp_password_zero_length
+  def test_password_zero_length
     vtp = vtp_domain('accounting')
     vtp.password = ''
     assert_equal('', vtp.password,
                  'Error: vtp password not empty')
   end
 
-  def test_vtp_password_get
+  def test_password_get
     vtp = vtp_domain('accounting')
 
     config('vtp password cisco123')
@@ -174,13 +147,13 @@ class TestVtp < CiscoTestCase
                  'Error: vtp password not correct')
   end
 
-  def test_vtp_password_get_not_set
+  def test_password_get_not_set
     vtp = vtp_domain('accounting')
     assert_equal('', vtp.password,
                  'Error: vtp password not empty')
   end
 
-  def test_vtp_password_clear
+  def test_password_clear
     vtp = vtp_domain('accounting')
     vtp.password = 'cisco123'
     assert_equal('cisco123', vtp.password,
@@ -191,7 +164,7 @@ class TestVtp < CiscoTestCase
                  'Error: vtp default password not set')
   end
 
-  def test_vtp_password_valid
+  def test_password_valid
     vtp = vtp_domain('accounting')
     alphabet = 'abcdefghijklmnopqrstuvwxyz0123456789'
     password = ''
@@ -203,33 +176,20 @@ class TestVtp < CiscoTestCase
     end
   end
 
-  def test_vtp_password_too_long
-    vtp = vtp_domain('accounting')
-    password = 'a' * (Vtp::MAX_VTP_PASSWORD_SIZE + 1)
-    assert_raises(ArgumentError) { vtp.password = password }
-  end
-
-  def test_vtp_password_special_characters
+  def test_password_special_characters
     vtp = vtp_domain('password')
     vtp.password = 'hello!//\\#%$x'
     assert_equal('hello!//\\#%$x', vtp.password)
   end
 
-  def test_vtp_filename_nil
-    vtp = vtp_domain('accounting')
-    assert_raises(TypeError) do
-      vtp.filename = nil
-    end
-  end
-
-  def test_vtp_filename_valid
+  def test_filename_valid
     vtp = vtp_domain('accounting')
     vtp.filename = 'bootflash:/test.dat'
     assert_equal('bootflash:/test.dat', vtp.filename,
                  'Error: vtp file content wrong')
   end
 
-  def test_vtp_filename_zero_length
+  def test_filename_zero_length
     vtp = vtp_domain('accounting')
     vtp.filename = vtp.default_filename
     assert_equal(node.config_get_default('vtp', 'filename'), vtp.filename,
@@ -242,30 +202,33 @@ class TestVtp < CiscoTestCase
                  'Error: vtp file content wrong')
   end
 
-  def test_vtp_filename_auto_enable
+  def test_filename_auto_enable
     vtp = Vtp.new(false)
-    refute(Vtp.enabled, 'VTP should not be enabled')
+    refute(Feature.vtp_enabled?, 'VTP should not be enabled')
     vtp.filename = 'bootflash:/foo.bar'
-    assert(Vtp.enabled)
+    assert(Feature.vtp_enabled?)
     assert_equal('bootflash:/foo.bar', vtp.filename)
   end
 
-  def test_vtp_version_valid
+  def test_version_valid
     vtp = vtp_domain('accounting')
     vtp.version = vtp.default_version
     assert_equal(node.config_get_default('vtp', 'version'), vtp.version,
                  'Error: vtp version not default')
   end
 
-  def test_vtp_version3_valid
+  def test_version3_valid
     vtp = vtp_domain('accounting')
 
     ref = cmd_ref.lookup('vtp', 'version')
     assert(ref, 'Error, reference not found for vtp version3')
 
-    assert_result(ref.test_config_result(3), 'Error: vtp version3 error') do
+    case node.product_id
+    when /N(5|6|7)K/
       vtp.version = 3
-      vtp.version
+      assert_equal(vtp.version, 3)
+    else
+      assert_raises(Cisco::CliError) { vtp.version = 3 }
     end
   end
 
@@ -282,14 +245,7 @@ class TestVtp < CiscoTestCase
     end
   end
 
-  def test_vtp_version_invalid
-    vtp = vtp_domain('accounting')
-    assert_raises(Cisco::CliError) do
-      vtp.version = 34
-    end
-  end
-
-  def test_vtp_version_default
+  def test_version_default
     vtp = vtp_domain('accounting')
     vtp.version = 2
     assert_equal(2, vtp.version,
@@ -299,19 +255,19 @@ class TestVtp < CiscoTestCase
                  'Error: vtp version not default')
   end
 
-  def test_vtp_version_auto_enable
+  def test_version_auto_enable
     vtp = Vtp.new(false)
-    refute(Vtp.enabled, 'VTP should not be enabled')
+    refute(Feature.vtp_enabled?, 'VTP should not be enabled')
     vtp.version = 1
-    assert(Vtp.enabled)
+    assert(Feature.vtp_enabled?)
     assert_equal(1, vtp.version)
   end
 
-  def test_vtp_feature_enable_disable
-    Vtp.new.enable
-    assert(Vtp.enabled, 'Error: vtp is not enabled')
+  def test_feature_enable_disable
+    Feature.vtp_enable
+    assert(Feature.vtp_enabled?, 'Error: vtp is not enabled')
 
-    Vtp.new.destroy
-    refute(Vtp.enabled, 'Error: vtp is not disabled')
+    Feature.vtp_disable
+    refute(Feature.vtp_enabled?, 'Error: vtp is not disabled')
   end
 end

data/tests/test_vxlan_vtep.rb

@@ -19,8 +19,10 @@ require_relative '../lib/cisco_node_utils/vdc'
 
 include Cisco
 
-# TestVxlanGlobal - Minitest for VxlanGlobal node utility
+# TestVxlanVtep - Minitest for VxlanVtep node utility
 class TestVxlanVtep < CiscoTestCase
+  @skip_unless_supported = 'vxlan_vtep'
+
   def setup
     super
     skip('Platform does not support MT-full or MT-lite') unless
@@ -28,37 +30,26 @@ class TestVxlanVtep < CiscoTestCase
   end
 
   def teardown
+    Feature.nv_overlay_disable
     return unless Vdc.vdc_support
     # Reset the vdc module type back to default
     v = Vdc.new('default')
     v.limit_resource_module_type = '' if v.limit_resource_module_type == 'f3'
   end
 
-  def compatible_interface?
-    # MT-full tests require a specific linecard; either because they need a
-    # compatible interface or simply to enable the features. Either way
-    # we will provide an appropriate interface name if the linecard is present.
-    # Example 'show mod' output to match against:
-    #   '9  12  10/40 Gbps Ethernet Module  N7K-F312FQ-25 ok'
-    sh_mod = @device.cmd("sh mod | i '^[0-9]+.*N7K-F3'")[/^(\d+)\s.*N7K-F3/]
-    slot = sh_mod.nil? ? nil : Regexp.last_match[1]
-    skip('Unable to find a compatible interface in chassis') if slot.nil?
-
-    "ethernet#{slot}/1"
-  end
-
   def mt_full_env_setup
     skip('Platform does not support MT-full') unless VxlanVtep.mt_full_support
-    compatible_interface?
+    vxlan_linecard?
     v = Vdc.new('default')
     v.limit_resource_module_type = 'f3' unless
       v.limit_resource_module_type == 'f3'
-    config('no feature nv overlay')
+    Feature.nv_overlay_disable
   end
 
   def mt_lite_env_setup
     skip('Platform does not support MT-lite') unless VxlanVtep.mt_lite_support
-    config('no feature nv overlay')
+    vxlan_linecard?
+    Feature.nv_overlay_disable
     config('no feature vn-segment-vlan-based')
   end
 
@@ -211,4 +202,34 @@ class TestVxlanVtep < CiscoTestCase
     vtep.source_interface = val
     assert_equal(val, vtep.source_interface)
   end
+
+  def test_source_interface_hold_down_time
+    mt_full_env_setup if VxlanVtep.mt_full_support
+    mt_lite_env_setup if VxlanVtep.mt_lite_support
+
+    vtep = VxlanVtep.new('nve1')
+    if validate_property_excluded?('vxlan_vtep', 'source_intf_hold_down_time')
+      assert_nil(vtep.source_interface_hold_down_time)
+      assert_nil(vtep.default_source_interface_hold_down_time)
+      assert_raises(Cisco::UnsupportedError) do
+        vtep.source_interface_hold_down_time = 50
+      end
+      return
+    end
+
+    # Set source_interface to non-default value
+    val = 'loopback55'
+    vtep.source_interface = val
+    assert_equal(val, vtep.source_interface)
+
+    # Set source_interface_hold_down_time
+    time = 50
+    vtep.source_interface_hold_down_time = time
+    assert_equal(time, vtep.source_interface_hold_down_time)
+
+    # Set source_interface_hold_down_time to default value
+    val = vtep.default_source_interface_hold_down_time
+    vtep.source_interface_hold_down_time = val
+    assert_equal(val, vtep.source_interface_hold_down_time)
+  end
 end

data/tests/test_vxlan_vtep_vni.rb

@@ -18,17 +18,35 @@ require_relative '../lib/cisco_node_utils/vxlan_vtep_vni'
 
 include Cisco
 
-# TestVxlanGlobal - Minitest for VxlanGlobal node utility
+# TestVxlanVtepVni - Minitest for VxlanVtepVni node utility
 class TestVxlanVtepVni < CiscoTestCase
+  @skip_unless_supported = 'vxlan_vtep_vni'
+  @@pre_clean_needed = true # rubocop:disable Style/ClassVars
+
   def setup
     super
-    config('no feature nv overlay')
-    config('feature nv overlay')
-    config('interface nve1')
+    return unless @@pre_clean_needed
+    # Disable features on initial cleanup only as it's too expensive
+    # to do a disable for every testcase.
+    Feature.nv_overlay_disable
+    # nv overlay is slow on some platforms
+    sleep 1
+    vxlan_linecard?
+    if VxlanVtep.mt_full_support
+      return unless Vdc.vdc_support
+      v = Vdc.new('default')
+      v.limit_resource_module_type = 'f3' unless
+        v.limit_resource_module_type == 'f3'
+    else
+      config_no_warn('no feature vn-segment-vlan-based')
+    end
+    Feature.nv_overlay_enable
+    config_no_warn('feature vn-segment-vlan-based') if VxlanVtep.mt_lite_support
+    @@pre_clean_needed = false # rubocop:disable Style/ClassVars
   end
 
   def teardown
-    config('no feature nv overlay')
+    config_no_warn('no interface nve1')
     super
   end
 
@@ -49,6 +67,7 @@ class TestVxlanVtepVni < CiscoTestCase
   end
 
   def test_vnis
+    VxlanVtep.new('nve1')
     skip('Platform does not support vnis') if VxlanVtepVni.vnis['nve1'].nil?
 
     # Test empty case
@@ -92,6 +111,10 @@ class TestVxlanVtepVni < CiscoTestCase
 
   def test_ingress_replication
     vni = VxlanVtepVni.new('nve1', '5000')
+    if validate_property_excluded?('vxlan_vtep_vni', 'ingress_replication')
+      assert_raises(Cisco::UnsupportedError) { vni.ingress_replication = 'bgp' }
+      return
+    end
 
     # Test non-default values
     vni.ingress_replication = 'static'
@@ -127,11 +150,13 @@ class TestVxlanVtepVni < CiscoTestCase
 
     # Test the case where an existing ingress_replication is removed before
     # configuring multicast_group
-    vni1.ingress_replication = 'static'
-    assert_equal('static', vni1.ingress_replication)
+    unless validate_property_excluded?('vxlan_vtep_vni', 'ingress_replication')
+      vni1.ingress_replication = 'static'
+      assert_equal('static', vni1.ingress_replication)
 
-    vni1.multicast_group = '224.1.1.1'
-    assert_equal('224.1.1.1', vni1.multicast_group)
+      vni1.multicast_group = '224.1.1.1'
+      assert_equal('224.1.1.1', vni1.multicast_group)
+    end
 
     # Test multicast group range
     vni2.multicast_group = '224.1.1.1 224.1.1.200'
@@ -146,6 +171,10 @@ class TestVxlanVtepVni < CiscoTestCase
 
   def test_peer_list
     vni = VxlanVtepVni.new('nve1', '6000')
+    if validate_property_excluded?('vxlan_vtep_vni', 'ingress_replication')
+      assert_raises(Cisco::UnsupportedError) { vni.peer_list = ['1.1.1.1'] }
+      return
+    end
 
     peer_list = ['1.1.1.1', '2.2.2.2', '3.3.3.3', '4.4.4.4']
 
@@ -180,6 +209,7 @@ class TestVxlanVtepVni < CiscoTestCase
 
   def test_suppress_arp
     vni = VxlanVtepVni.new('nve1', '6000')
+    VxlanVtep.new('nve1').host_reachability = 'evpn'
 
     # Test: Check suppress_arp is not configured.
     refute(vni.suppress_arp, 'suppress_arp should be disabled')
@@ -198,4 +228,26 @@ class TestVxlanVtepVni < CiscoTestCase
     vni.suppress_arp = vni.default_suppress_arp
     refute(vni.suppress_arp, 'suppress_arp should be disabled')
   end
+
+  def test_suppress_uuc
+    vni = VxlanVtepVni.new('nve1', '6000')
+    VxlanVtep.new('nve1').host_reachability = 'evpn'
+    if validate_property_excluded?('vxlan_vtep_vni', 'suppress_uuc')
+      assert_nil(vni.suppress_uuc)
+      assert_nil(vni.default_suppress_uuc)
+      assert_raises(Cisco::UnsupportedError) { vni.suppress_uuc = true }
+      return
+    end
+
+    # Test: Check suppress_uuc is not configured.
+    refute(vni.suppress_uuc, 'suppress_uuc should be disabled')
+
+    # Test: Enable suppress_uuc
+    vni.suppress_uuc = true
+    assert(vni.suppress_uuc, 'suppress_uuc should be enabled')
+
+    # Test: Default
+    vni.suppress_uuc = vni.default_suppress_uuc
+    refute(vni.suppress_uuc, 'suppress_uuc should be disabled')
+  end
 end