cisco_node_utils 1.2.0 → 1.3.0

data/tests/test_pim.rb

@@ -45,6 +45,8 @@ include Cisco
 
 # TestPim - Minitest for Pim Feature
 class TestPim < CiscoTestCase
+  @skip_unless_supported = 'pim'
+
   @@pre_clean_needed = true # rubocop:disable Style/ClassVars
 
   # Enables feature pim

data/tests/test_pim_group_list.rb

@@ -32,6 +32,8 @@ include Cisco
 
 # TestPim - Minitest for PimGrouplist
 class TestPimGroupList < CiscoTestCase
+  @skip_unless_supported = 'pim'
+
   # Enables feature pim
   #--------------------
   def setup

data/tests/test_pim_rp_address.rb

@@ -31,6 +31,8 @@ include Cisco
 
 # TestPimRpAddress - Minitest for PimRpAddress
 class TestPimRpAddress < CiscoTestCase
+  @skip_unless_supported = 'pim'
+
   # Enables feature pim
   #--------------------
   def setup

data/tests/test_platform.rb

@@ -17,15 +17,40 @@ require_relative '../lib/cisco_node_utils/platform'
 
 # TestPlatform - Minitest for Platform class
 class TestPlatform < CiscoTestCase
+  def test_image_version
+    case platform
+    when :ios_xr
+      refute_empty(Platform.image_version)
+
+    when :nexus
+      # Supported Images:
+      # N3/9k: 7.0(3)I2(*), 7.0(3)I3(1)
+      # N7k:   7.3(1)D1(1)
+      # N5/6k: 7.3(0)N1(1)
+
+      in_pat = '(^  NXOS: version |^  system:    version)'
+      s = @device.cmd("show version | i '#{in_pat}'")
+
+      out_pat = %r{/(\d\.\d\(\d\)[IDN])\d\(\d\)/}
+      show = s.match(out_pat).to_s
+      plat = Platform.image_version.match(out_pat).to_s
+      assert_equal(show, plat)
+    end
+  end
+
   def test_system_image
-    s = @device.cmd('show version | i image').scan(/ (\S+)$/).flatten.first
-    assert_equal(s, Platform.system_image)
+    if platform == :ios_xr
+      assert_nil(Platform.system_image)
+    elsif platform == :nexus
+      s = @device.cmd('show version | i image').scan(/ (\S+)$/).flatten.first
+      assert_equal(s, Platform.system_image)
+    end
   end
 
   def test_packages
     # [['pack1', 'state1'], ['pack2', 'state2'], ...]
     # 'state' should always be a variant of Active or Inactive
-    pkgs = @device.cmd('sh inst patch | no-more')
+    pkgs = @device.cmd('sh inst patch')
            .scan(/\n(\S+)\s+(\S*[aA]ctive.*)\n/)
     # convert to hash with key pkg_name and value pkg_state
     pkg_hsh = {}
@@ -34,7 +59,13 @@ class TestPlatform < CiscoTestCase
   end
 
   def test_hardware_type
-    s = @device.cmd('sh ver | no-m').scan(/Hardware\n\s+(.*)\n/).flatten.first
+    if platform == :ios_xr
+      s = @device.cmd('show inv | inc "Rack 0"').scan(/DESCR: "(.*)"/)
+    elsif platform == :nexus
+      s = @device.cmd('sh ver').scan(/Hardware\n\s+(.*)\n/)
+    end
+    s = s.flatten.first
+    refute_empty(Platform.hardware_type)
     # hardware type returns a different value depending on whether you use the
     # ascii or show output of nxapi, but show appears to be substring of ascii
     assert(s.include?(Platform.hardware_type),
@@ -42,45 +73,60 @@ class TestPlatform < CiscoTestCase
   end
 
   def test_cpu
-    s = @device.cmd('sh ver | no-m').scan(
+    s = @device.cmd('sh ver').scan(
       /Hardware\n\s+.*\n\s+(.*) with/).flatten.first
     assert_equal(s, Platform.cpu)
   end
 
   def test_memory
-    arr = @device.cmd('sh sys reso').scan(
-      /(\S+) total.* (\S+) used.* (\S+) free/).flatten
-    mem_hsh = { 'total' => arr[0],
-                'used'  => arr[1],
-                'free'  => arr[2] }
-    # used and free memory change rapidly, compare total and sums of free + used
+    if platform == :ios_xr
+      arr = @device.cmd('sh mem summ').scan(
+        /Physical Memory: (\S+) total.*\((\S+) available/).flatten
+      mem_hsh = { 'total' => arr[0],
+                  'used'  => nil,
+                  'free'  => arr[1] }
+    elsif platform == :nexus
+      arr = @device.cmd('sh sys reso').scan(
+        /(\S+) total.* (\S+) used.* (\S+) free/).flatten
+      mem_hsh = { 'total' => arr[0],
+                  'used'  => arr[1],
+                  'free'  => arr[2] }
+    end
     assert_equal(mem_hsh['total'], Platform.memory['total'])
-    assert_equal(mem_hsh['used'].to_i + mem_hsh['free'].to_i,
-                 Platform.memory['used'].to_i + Platform.memory['free'].to_i)
-    # assert(Platform.memory.has_key?('used'),
-    #        "Platform memory has no key 'used'")
-    # assert(Platform.memory.has_key?('free'),
-    #        "Platform memory has no key 'free'")
+    if platform == :nexus
+      # used and free mem change rapidly, compare total and sums of free + used
+      assert_equal(mem_hsh['used'].to_i + mem_hsh['free'].to_i,
+                   Platform.memory['used'].to_i + Platform.memory['free'].to_i)
+    end
+    assert(Platform.memory.key?('used'),
+           "Platform memory has no key 'used'")
+    assert(Platform.memory.key?('free'),
+           "Platform memory has no key 'free'")
   end
 
   def test_board
-    s = @device.cmd('sh ver | no-m').scan(/Board ID (\S+)/).flatten.first
+    s = @device.cmd('sh ver').scan(/Board ID (\S+)/).flatten.first
     assert_equal(s, Platform.board)
   end
 
   def test_uptime
-    s = @device.cmd('sh ver | no-m').scan(/uptime is (.*)/).flatten.first
+    s = @device.cmd('sh ver').scan(/uptime is (.*)/).flatten.first
     # compare without seconds
     assert_equal(s.gsub(/\d+ sec/, ''), Platform.uptime.gsub(/\d+ sec/, ''))
   end
 
   def test_last_reset
-    s = @device.cmd('sh ver | no-m').scan(/usecs after\s+(.*)/).flatten.first
-    assert_equal(s, Platform.last_reset)
+    s = @device.cmd('sh ver').scan(/usecs after\s+(.*)/).flatten.first
+    if Utils.nexus_i2_image
+      # Platform issue CSCuy72214, uncertain if this will ever be fixed in I2
+      assert_nil(Platform.last_reset)
+    else
+      assert_equal(s, Platform.last_reset)
+    end
   end
 
   def test_reset_reason
-    s = @device.cmd('sh ver | no-m').scan(/Reason: (.*)/).flatten.first
+    s = @device.cmd('sh ver').scan(/Reason: (.*)/).flatten.first
     assert_equal(s, Platform.reset_reason)
   end
 
@@ -103,25 +149,34 @@ class TestPlatform < CiscoTestCase
   # Everything from DESCR onwards follows the same general format so we
   # can define a single base regexp and extend it as needed for Chassis, Slot,
   # Power Supply, and Fan inventory entries.
-  def inv_cmn_re
-    /.*DESCR:\s+"(.*)"\s*\nPID:\s+(\S+).*VID:\s+(\S+).*SN:\s+(\S+)/
+  #
+  # On some platforms, some fields may be empty:
+  # NAME: "Chassis",  DESCR: "NX-OSv Chassis"
+  # PID: N9K-NXOSV           ,  VID:     ,  SN:
+  def inv_cmn_re(name_expr)
+    /NAME:\s+"#{name_expr}",\s+
+     DESCR:\s+"(.*)"\s*
+     \n
+     PID:\s+(\S*)\s*,\s*
+     VID:\s+(\S*)\s*,\s*
+     SN:\s+(\S*)\s*
+     $/x
   end
 
   def test_chassis
-    arr = @device.cmd('sh inv | no-m').scan(/NAME:\s+"Chassis"#{inv_cmn_re}/)
+    arr = @device.cmd('sh inv').scan(inv_cmn_re('Chassis'))
     arr = arr.flatten
     # convert to hash
     chas_hsh = { 'descr' => arr[0],
                  'pid'   => arr[1],
                  'vid'   => arr[2],
                  'sn'    => arr[3],
-    }
+    } unless arr.empty?
     assert_equal(chas_hsh, Platform.chassis)
   end
 
   def test_slots
-    slots_arr_arr = @device.cmd('sh inv | no-m')
-                    .scan(/NAME:\s+"(Slot \d+)"#{inv_cmn_re}/)
+    slots_arr_arr = @device.cmd('sh inv').scan(inv_cmn_re('(Slot\s+\d+)'))
     # convert to array of slot hashes
     slots_hsh_hsh = {}
     slots_arr_arr.each do |slot|
@@ -135,10 +190,8 @@ class TestPlatform < CiscoTestCase
   end
 
   def test_power_supplies
-    pwr_arr_arr = @device.cmd('sh inv | no-m')
-                  .scan(/NAME:\s+"(Power Supply \d+)"#{inv_cmn_re}/)
-    refute_empty(pwr_arr_arr,
-                 'Regex scan failed to match show inventory output')
+    pwr_arr_arr = @device.cmd('sh inv')
+                  .scan(inv_cmn_re('(Power\s+Supply\s+\d+)'))
 
     # convert to array of power supply hashes
     pwr_hsh_hsh = {}
@@ -153,10 +206,7 @@ class TestPlatform < CiscoTestCase
   end
 
   def test_fans
-    fan_arr_arr = @device.cmd('sh inv | no-m')
-                  .scan(/NAME:\s+"(Fan \d+)"#{inv_cmn_re}/)
-    refute_empty(fan_arr_arr,
-                 'Regex scan failed to match show inventory output')
+    fan_arr_arr = @device.cmd('sh inv').scan(inv_cmn_re('(Fan\s+\d+)'))
 
     # convert to array of fan hashes
     fan_hsh_hsh = {}
@@ -171,9 +221,6 @@ class TestPlatform < CiscoTestCase
   end
 
   def test_virtual_services
-    skip('Skip test: No virtual-services installed') unless
-      @device.cmd('show virtual-service list')[/Name\s+Status\s+Package Name/]
-
     # this would be beyond ugly to parse from ascii, utilize config_get
     vir_arr = node.config_get('virtual_service', 'services')
     vir_arr = [vir_arr] if vir_arr.is_a? Hash

data/tests/test_portchannel_global.rb

@@ -17,24 +17,26 @@ require_relative '../lib/cisco_node_utils/portchannel_global'
 
 # TestX__CLASS_NAME__X - Minitest for X__CLASS_NAME__X node utility class
 class TestPortchannelGlobal < CiscoTestCase
-  # TESTS
-
+  @skip_unless_supported = 'portchannel_global'
+  @@cleaned = false # rubocop:disable Style/ClassVars
   DEFAULT_NAME = 'default'
 
   def setup
     super
-    config 'no port-channel load-balance' unless n6k_platform?
-    config 'no port-channel load-balance ethernet' unless
-    n9k_platform? || n7k_platform?
+    cleanup unless @@cleaned
+    @@cleaned = true # rubocop:disable Style/ClassVars
   end
 
   def teardown
-    config 'no port-channel load-balance' unless n6k_platform?
-    config 'no port-channel load-balance ethernet' unless
-    n9k_platform? || n7k_platform?
+    cleanup
     super
   end
 
+  def cleanup
+    ethernet = node.product_id[/N(3|7|8|9)/] ? '' : 'ethernet'
+    config_no_warn "no port-channel load-balance #{ethernet}"
+  end
+
   def n3k_in_n3k_mode?
     return unless /N3/ =~ node.product_id
     mode = config('show system switch-mode')
@@ -44,159 +46,233 @@ class TestPortchannelGlobal < CiscoTestCase
     mode[Regexp.union(patterns)] ? true : false
   end
 
-  def n7k_platform?
-    /N7/ =~ node.product_id
-  end
-
-  def n9k_platform?
-    /N(3|9)/ =~ node.product_id
-  end
-
-  def n6k_platform?
-    /N(5|6)/ =~ node.product_id
-  end
-
   def create_portchannel_global(name=DEFAULT_NAME)
     PortChannelGlobal.new(name)
   end
 
-  def test_get_hash_distribution
-    skip('Platform does not support this property') if n6k_platform? ||
-                                                       n9k_platform?
-    @global = create_portchannel_global
-    @global.hash_distribution = 'fixed'
-    assert_equal('fixed', @global.hash_distribution)
-    @global.hash_distribution =
-      @global.default_hash_distribution
-    assert_equal(@global.default_hash_distribution,
-                 @global.hash_distribution)
+  def test_hash_distribution
+    global = create_portchannel_global
+    if validate_property_excluded?('portchannel_global', 'hash_distribution')
+      assert_raises(Cisco::UnsupportedError) do
+        global.hash_distribution = 'fixed'
+      end
+      assert_nil(global.hash_distribution)
+    else
+      global.hash_distribution = 'fixed'
+      assert_equal('fixed', global.hash_distribution)
+      global.hash_distribution =
+        global.default_hash_distribution
+      assert_equal(global.default_hash_distribution,
+                   global.hash_distribution)
+    end
   end
 
-  def test_get_set_load_defer
-    skip('Platform does not support this property') if n6k_platform? ||
-                                                       n9k_platform?
-    @global = create_portchannel_global
-    @global.load_defer = 1000
-    assert_equal(1000, @global.load_defer)
-    @global.load_defer =
-      @global.default_load_defer
-    assert_equal(@global.default_load_defer,
-                 @global.load_defer)
+  def test_load_defer
+    global = create_portchannel_global
+    if validate_property_excluded?('portchannel_global', 'load_defer')
+      assert_raises(Cisco::UnsupportedError) do
+        global.load_defer = 1000
+      end
+      assert_nil(global.load_defer)
+    else
+      global.load_defer = 1000
+      assert_equal(1000, global.load_defer)
+      global.load_defer =
+        global.default_load_defer
+      assert_equal(global.default_load_defer,
+                   global.load_defer)
+    end
   end
 
-  def test_get_set_resilient
-    skip('Platform does not support this property') if n6k_platform? ||
-                                                       n7k_platform?
-    @global = create_portchannel_global
-    @global.resilient = true
-    assert_equal(true, @global.resilient)
-    @global.resilient = @global.default_resilient
-    assert_equal(@global.default_resilient, @global.resilient)
+  def test_resilient
+    global = create_portchannel_global
+    if validate_property_excluded?('portchannel_global', 'resilient')
+      assert_raises(Cisco::UnsupportedError) { global.resilient = true }
+      assert_nil(global.resilient)
+      return
+    end
+
+    # Verify that hardware supports feature. Unfortunately the current cli
+    # only displays a warning and does not raise an error so we have to
+    # test for it explicitly.
+    cmd = 'port-channel load-balance resilient'
+    skip('Skip test: Feature is not supported on this device') if
+      config(cmd)[/Resilient Hashing Mode unsupported/]
+    global = create_portchannel_global
+    # For n3k the default is different from n9k
+    if n3k_in_n3k_mode?
+      global.resilient = false
+      refute(global.resilient)
+      global.resilient = global.default_resilient
+      assert_equal(global.default_resilient, global.resilient)
+    else
+      config('no ' + cmd)
+      global = create_portchannel_global
+      global.resilient = true
+      assert(global.resilient)
+      global.resilient = global.default_resilient
+      assert_equal(global.default_resilient, global.resilient)
+    end
   end
 
-  def test_get_set_port_channel_load_balance_sym_concat_rot
-    skip('Platform does not support this property') if
-      n6k_platform? || n7k_platform? || n3k_in_n3k_mode?
-    @global = create_portchannel_global
-    @global.send(:port_channel_load_balance=,
-                 'src-dst', 'ip-l4port', nil, nil, true, true, 4)
+  def test_load_balance_no_rotate
+    skip('Test not supported on this platform') unless n3k_in_n3k_mode?
+
+    global = create_portchannel_global
+    global.send(:port_channel_load_balance=,
+                'src-dst', 'ip-only', nil, nil, true, nil, nil)
     assert_equal('src-dst',
-                 @global.bundle_select)
-    assert_equal('ip-l4port',
-                 @global.bundle_hash)
-    assert_equal(true, @global.symmetry)
-    assert_equal(true, @global.concatenation)
-    assert_equal(4, @global.rotate)
-    @global.send(
+                 global.bundle_select)
+    assert_equal('ip-only',
+                 global.bundle_hash)
+    assert_equal(true, global.symmetry)
+    global.send(
       :port_channel_load_balance=,
-      @global.default_bundle_select,
-      @global.default_bundle_hash,
+      global.default_bundle_select,
+      global.default_bundle_hash,
       nil,
       nil,
-      @global.default_symmetry,
-      @global.default_concatenation,
-      @global.default_rotate)
-    assert_equal(
-      @global.default_bundle_select,
-      @global.bundle_select)
+      global.default_symmetry,
+      nil,
+      nil)
     assert_equal(
-      @global.default_bundle_hash,
-      @global.bundle_hash)
+      global.default_bundle_select,
+      global.bundle_select)
     assert_equal(
-      @global.default_symmetry,
-      @global.symmetry)
+      global.default_bundle_hash,
+      global.bundle_hash)
     assert_equal(
-      @global.default_concatenation,
-      @global.concatenation)
-    assert_equal(@global.default_rotate,
-                 @global.rotate)
+      global.default_symmetry,
+      global.symmetry)
   end
 
-  def test_get_set_port_channel_load_balance_hash_poly
-    skip('Platform does not support this property') if n7k_platform? ||
-                                                       n9k_platform?
-    @global = create_portchannel_global
-    @global.send(:port_channel_load_balance=,
-                 'src-dst', 'ip-only', 'CRC10c', nil, nil, nil, nil)
-    assert_equal('src-dst',
-                 @global.bundle_select)
-    assert_equal('ip-only',
-                 @global.bundle_hash)
-    assert_equal('CRC10c', @global.hash_poly)
-    @global.send(:port_channel_load_balance=,
-                 'dst', 'mac', 'CRC10a', nil, nil, nil, nil)
-    assert_equal('dst',
-                 @global.bundle_select)
-    assert_equal('mac',
-                 @global.bundle_hash)
-    assert_equal('CRC10a', @global.hash_poly)
-    @global.send(
-      :port_channel_load_balance=,
-      @global.default_bundle_select,
-      @global.default_bundle_hash,
-      @global.default_hash_poly,
-      nil, nil, nil, nil)
-    assert_equal(
-      @global.default_bundle_select,
-      @global.bundle_select)
-    assert_equal(
-      @global.default_bundle_hash,
-      @global.bundle_hash)
-    assert_equal(@global.default_hash_poly,
-                 @global.hash_poly)
-  end
+  def test_load_balance_sym_concat_rot
+    # rubocop:disable Style/MultilineOperationIndentation
+    skip('Test not supported on this platform') if n3k_in_n3k_mode? ||
+      validate_property_excluded?('portchannel_global', 'symmetry')
+    # rubocop:enable Style/MultilineOperationIndentation
 
-  def test_get_set_port_channel_load_balance_asym_rot
-    skip('Platform does not support this property') if n6k_platform? ||
-                                                       n9k_platform?
-    @global = create_portchannel_global
-    @global.send(:port_channel_load_balance=,
-                 'src-dst', 'ip-vlan', nil, true, nil, nil, 4)
+    global = create_portchannel_global
+    global.send(:port_channel_load_balance=,
+                'src-dst', 'ip-l4port', nil, nil, true, true, 4)
     assert_equal('src-dst',
-                 @global.bundle_select)
-    assert_equal('ip-vlan',
-                 @global.bundle_hash)
-    assert_equal(true, @global.asymmetric)
-    assert_equal(4, @global.rotate)
-    @global.send(
+                 global.bundle_select)
+    assert_equal('ip-l4port',
+                 global.bundle_hash)
+    assert_equal(true, global.symmetry)
+    assert_equal(true, global.concatenation)
+    assert_equal(4, global.rotate)
+    global.send(
       :port_channel_load_balance=,
-      @global.default_bundle_select,
-      @global.default_bundle_hash,
+      global.default_bundle_select,
+      global.default_bundle_hash,
       nil,
-      @global.default_asymmetric,
       nil,
-      nil,
-      @global.default_rotate)
+      global.default_symmetry,
+      global.default_concatenation,
+      global.default_rotate)
+    assert_equal(
+      global.default_bundle_select,
+      global.bundle_select)
     assert_equal(
-      @global.default_bundle_select,
-      @global.bundle_select)
+      global.default_bundle_hash,
+      global.bundle_hash)
     assert_equal(
-      @global.default_bundle_hash,
-      @global.bundle_hash)
+      global.default_symmetry,
+      global.symmetry)
     assert_equal(
-      @global.default_asymmetric,
-      @global.asymmetric)
-    assert_equal(@global.default_rotate,
-                 @global.rotate)
+      global.default_concatenation,
+      global.concatenation)
+    assert_equal(global.default_rotate,
+                 global.rotate)
+  end
+
+  # assert_hash_poly_crc
+  # Depending on the chipset, hash_poly may have have a different
+  # default value within the same platform family (this is done to
+  # avoid polarization) but there is currently no command available
+  # to dynamically determine the default state. As a result the
+  # getter simply hard-codes a default value which means it may
+  # encounter occasional idempotence issues.
+  # For testing purposes this becomes a best-effort test; i.e. we expect the
+  # hash_poly test to pass for all asserts except the one that matches the
+  # default value for that chipset.
+  def assert_hash_poly_crc(exp, actual)
+    assert_equal(exp, actual) if exp == actual
+  end
+
+  def test_load_balance_hash_poly
+    global = create_portchannel_global
+    if validate_property_excluded?('portchannel_global', 'hash_poly')
+      skip('Test not supported on this platform')
+      return
+    end
+
+    global.send(:port_channel_load_balance=,
+                'src-dst', 'ip-only', 'CRC10c', nil, nil, nil, nil)
+    assert_equal('src-dst', global.bundle_select)
+    assert_equal('ip-only', global.bundle_hash)
+    assert_hash_poly_crc('CRC10c', global.hash_poly)
+
+    global.send(:port_channel_load_balance=,
+                'dst', 'mac', 'CRC10a', nil, nil, nil, nil)
+    assert_equal('dst', global.bundle_select)
+    assert_equal('mac', global.bundle_hash)
+    assert_hash_poly_crc('CRC10a', global.hash_poly)
+
+    global.send(:port_channel_load_balance=,
+                global.default_bundle_select,
+                global.default_bundle_hash,
+                'CRC10b', nil, nil, nil, nil)
+    assert_equal(global.default_bundle_select, global.bundle_select)
+    assert_equal(global.default_bundle_hash, global.bundle_hash)
+    assert_hash_poly_crc('CRC10b', global.hash_poly)
+  end
+
+  def test_load_balance_asym_rot
+    global = create_portchannel_global
+    if validate_property_excluded?('portchannel_global', 'asymmetric')
+      skip('Test not supported on this platform')
+      return
+    end
+
+    global.send(:port_channel_load_balance=,
+                'src-dst', 'ip-vlan', nil, true, nil, nil, 4)
+    assert_equal('src-dst', global.bundle_select)
+    assert_equal('ip-vlan', global.bundle_hash)
+    assert_equal(true, global.asymmetric)
+    assert_equal(4, global.rotate)
+
+    global.send(:port_channel_load_balance=,
+                global.default_bundle_select,
+                global.default_bundle_hash,
+                nil, global.default_asymmetric,
+                nil, nil, global.default_rotate)
+    assert_equal(global.default_bundle_select, global.bundle_select)
+    assert_equal(global.default_bundle_hash, global.bundle_hash)
+    assert_equal(global.default_asymmetric, global.asymmetric)
+    assert_equal(global.default_rotate, global.rotate)
+  end
+
+  def test_load_balance_no_hash_rot
+    global = create_portchannel_global
+    if validate_property_excluded?('portchannel_global', 'rotate')
+      skip('Test not supported on this platform')
+      return
+    end
+    global.send(:port_channel_load_balance=,
+                'src-dst', 'ip-vlan', nil, nil, nil, nil, 4)
+    assert_equal('src-dst', global.bundle_select)
+    assert_equal('ip-vlan', global.bundle_hash)
+    assert_equal(4, global.rotate)
+
+    global.send(:port_channel_load_balance=,
+                global.default_bundle_select,
+                global.default_bundle_hash,
+                nil, nil,
+                nil, nil, global.default_rotate)
+    assert_equal(global.default_bundle_select, global.bundle_select)
+    assert_equal(global.default_bundle_hash, global.bundle_hash)
+    assert_equal(global.default_rotate, global.rotate)
   end
 end