cisco_node_utils 1.2.0 → 1.3.0

data/tests/test_router_ospf.rb

@@ -17,117 +17,40 @@ require_relative '../lib/cisco_node_utils/router_ospf'
 
 # TestRouterOspf - Minitest for the RouterOspf node utility class.
 class TestRouterOspf < CiscoTestCase
+  @skip_unless_supported = 'ospf'
+
   def setup
     super
-    @default_show_command = "show run | include '^router ospf .*'"
-  end
-
-  def routerospf_routers_destroy(routers)
-    routers.each_value(&:destroy)
-  end
-
-  def test_routerospf_collection_empty
-    config('no feature ospf')
-    routers = RouterOspf.routers
-    assert_equal(true, routers.empty?,
-                 'RouterOspf collection is not empty')
-  end
-
-  def test_routerospf_collection_not_empty
-    config('feature ospf', 'router ospf TestOSPF', 'router ospf 100')
-    routers = RouterOspf.routers
-    assert_equal(false, routers.empty?,
-                 'RouterOspf collection is empty')
-    # validate the collection
-    routers.each_key do |name|
-      assert_show_match(pattern: /router ospf #{name}/)
-    end
-    routerospf_routers_destroy(routers)
-  end
-
-  def test_routerospf_create_name_zero_length
-    assert_raises(ArgumentError) do
-      RouterOspf.new('')
-    end
-  end
-
-  def test_routerospf_create_valid
-    name = 'ospfTest'
-    ospf = RouterOspf.new(name)
-    assert_show_match(pattern: /router ospf #{name}/,
-                      msg:     "'router ospf ospfTest' not configured")
-    ospf.destroy
-  end
-
-  def test_routerospf_create_valid_no_feature
-    name = 'ospfTest'
-    ospf = RouterOspf.new(name)
-    assert_show_match(pattern: /router ospf #{name}/,
-                      msg:     "'router ospf ospfTest' not configured")
-    ospf.destroy
-
-    refute_show_match(command: 'show run all | inc feature | no-more',
-                      pattern: /feature ospf/,
-                      msg:     "Error: 'feature ospf' still configured")
-  end
-
-  def test_routerospf_create_valid_multiple
-    name = 'ospfTest_1'
-    ospf_1 = RouterOspf.new(name)
-    assert_show_match(pattern: /router ospf #{name}/)
-
-    name = 'ospfTest_2'
-    ospf_2 = RouterOspf.new(name)
-    assert_show_match(pattern: /router ospf #{name}/)
-
-    ospf_1.destroy
-    ospf_2.destroy
+    remove_all_ospfs
   end
 
-  def test_routerospf_get_name
-    name = 'ospfTest'
-    ospf = RouterOspf.new(name)
-    line = assert_show_match(pattern: /router ospf #{name}/)
-    name = line.to_s.split(' ').last
-    # puts "name from cli: #{name}"
-    # puts "name from get: #{routerospf.name}"
-    assert_equal(name, ospf.name,
-                 'Error: router name not correct')
-    ospf.destroy
-  end
+  def test_create_destroy
+    assert_empty(RouterOspf.routers, 'RouterOspf.routers should be empty')
 
-  def test_routerospf_destroy
-    name = 'ospfTest'
-    ospf = RouterOspf.new(name)
-    ospf.destroy
-    refute_show_match(pattern: /router ospf #{name}/,
-                      msg:     "'router ospf ospfTest' not destroyed")
-  end
+    # Create two ospf instances
+    o1_name = 'ospf1'
+    o1 = RouterOspf.new(o1_name)
+    assert(RouterOspf.routers[o1_name],
+           "router ospf #{o1_name} not present")
+    assert_equal(o1_name, o1.name)
 
-  def test_routerospf_create_valid_multiple_delete_one
-    name = 'ospfTest_1'
-    ospf_1 = RouterOspf.new(name)
-    assert_show_match(pattern: /router ospf #{name}/,
-                      msg:     "Error: #{name}, not configured")
+    o2_name = 'ospf2'
+    o2 = RouterOspf.new(o2_name)
+    assert(RouterOspf.routers[o2_name],
+           "router ospf #{o2_name} not present")
 
-    name = 'ospfTest_2'
-    ospf_2 = RouterOspf.new(name)
-    assert_show_match(pattern: /router ospf #{name}/,
-                      msg:     "Error: #{name}, not configured")
+    # Destroy each in turn
+    o1.destroy
+    assert_nil(RouterOspf.routers[o1_name],
+               "router ospf #{o1_name} still present")
+    assert(RouterOspf.routers[o2_name],
+           "router ospf #{o2_name} not present")
 
-    ospf_1.destroy
+    o2.destroy
+    assert_nil(RouterOspf.routers[o2_name],
+               "router ospf #{o2_name} still present")
 
-    # Remove one router then check that we only have one router left
-    routers = RouterOspf.routers
-    assert_equal(false, routers.empty?,
-                 'Error: RouterOspf collection is empty')
-    assert_equal(1, routers.size,
-                 'Error: RouterOspf collection is not one')
-    assert_equal(true, routers.key?(name),
-                 "Error: #{name}, not found in the collection")
-    # validate the collection
-    assert_show_match(pattern: /router ospf #{name}/,
-                      msg:     "Error: #{name}, instance not found")
-    ospf_2.destroy
+    # Negative
+    assert_raises(ArgumentError) { RouterOspf.new('') }
   end
 end

data/tests/test_router_ospf_vrf.rb

@@ -18,15 +18,17 @@ require_relative '../lib/cisco_node_utils/router_ospf_vrf'
 
 # TestRouterOspfVrf - Minitest for RouterOspfVrf node utility class
 class TestRouterOspfVrf < CiscoTestCase
+  @skip_unless_supported = 'ospf'
+  @@pre_clean_needed = true # rubocop:disable Style/ClassVars
+
   def setup
-    # Disable feature ospf before each test to ensure we
-    # are starting with a clean slate for each test.
     super
-    config('no feature ospf')
+    remove_all_ospfs if @@pre_clean_needed
+    @@pre_clean_needed = false # rubocop:disable Style/ClassVars
   end
 
   def teardown
-    config('no feature ospf')
+    remove_all_ospfs
     super
   end
 
@@ -107,7 +109,7 @@ class TestRouterOspfVrf < CiscoTestCase
     config(*cfg)
   end
 
-  def test_routerospfvrf_collection_size
+  def test_collection_size
     create_routerospfvrf('green')
     vrfs = RouterOspfVrf.vrfs
     assert_equal(1, vrfs.size, 'Error: Collection is not one')
@@ -144,7 +146,7 @@ class TestRouterOspfVrf < CiscoTestCase
   )
   # rubocop:enable Style/AlignHash
 
-  def test_routerospfvrf_collection_not_empty_valid
+  def test_collection_not_empty_valid
     # pre-populate values
     config_from_hash(MULTIPLE_OSPFS)
 
@@ -176,11 +178,11 @@ class TestRouterOspfVrf < CiscoTestCase
     end
   end
 
-  def test_routerospfvrf_create_vrf_nil
+  def test_create_vrf_nil
     assert_raises(TypeError) { RouterOspfVrf.new(nil, 'testvrf') }
   end
 
-  def test_routerospfvrf_create_name_zero_length
+  def test_create_name_zero_length
     routerospf = RouterOspf.new('testOspf')
     assert_raises(ArgumentError) do
       RouterOspfVrf.new('testOspf', '')
@@ -188,9 +190,9 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_create_valid
+  def test_create_valid
     ospfname = 'ospfTest'
-    # routerospf = RouterOspf.new(ospfname)
+
     vrfname = 'default'
     vrf = RouterOspfVrf.new(ospfname, vrfname)
     assert_match_vrf_line(ospfname, vrfname)
@@ -199,7 +201,7 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_get_parent_name
+  def test_get_parent_name
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     assert_equal(routerospf.name, vrf.parent.name,
@@ -207,7 +209,7 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_get_name
+  def test_get_name
     vrfname = 'default'
     vrf = create_routerospfvrf('green')
     assert_match_vrf_line('green', vrfname)
@@ -216,7 +218,7 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_destroy
+  def test_destroy
     vrfname = 'default'
     vrf = create_routerospfvrf
     assert_raises(RuntimeError) do
@@ -226,10 +228,10 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_auto_cost
+  def test_auto_cost
     vrf = create_routerospfvrf
     auto_cost_value = [400_000, RouterOspfVrf::OSPF_AUTO_COST[:mbps]]
-    # set auto-cost
+
     vrf.auto_cost_set(auto_cost_value[0], :mbps)
     pattern = /\s+auto-cost reference-bandwidth #{auto_cost_value[0]}/
     assert_match_vrf_line(vrf.parent.name, vrf.name, pattern)
@@ -238,12 +240,12 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_auto_cost_multiple_vrf
+  def test_auto_cost_multiple_vrf
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
     auto_cost_value = [600_000, RouterOspfVrf::OSPF_AUTO_COST[:mbps]]
-    # set auto-cost
+
     vrf.auto_cost_set(auto_cost_value[0], :mbps)
     pattern = /\s+auto-cost reference-bandwidth #{auto_cost_value[0]}/
     assert_match_vrf_line(routerospf.name, vrf.name, pattern)
@@ -252,7 +254,7 @@ class TestRouterOspfVrf < CiscoTestCase
 
     # vrf 1
     auto_cost_value = [500_000, RouterOspfVrf::OSPF_AUTO_COST[:mbps]]
-    # set cost
+
     vrf1.auto_cost_set(auto_cost_value[0], :mbps)
     pattern = /\s+auto-cost reference-bandwidth #{auto_cost_value[0]}/
     assert_match_vrf_line(routerospf.name, vrf1.name, pattern)
@@ -261,7 +263,7 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_get_default_auto_cost
+  def test_get_default_auto_cost
     vrf = create_routerospfvrf
     # NXOS specific
     auto_cost_value = [40, RouterOspfVrf::OSPF_AUTO_COST[:gbps]]
@@ -272,7 +274,7 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_default_metric
+  def test_default_metric
     vrf = create_routerospfvrf
     metric = 30_000
     vrf.default_metric = metric
@@ -280,18 +282,18 @@ class TestRouterOspfVrf < CiscoTestCase
     assert_match_vrf_line(vrf.parent.name, vrf.name, pattern)
     assert_equal(metric, vrf.default_metric,
                  "Error: #{vrf.name} vrf, default-metric get value mismatch")
-    # set default metric
+
     vrf.default_metric = vrf.default_default_metric
     refute_match_vrf_line(vrf.parent.name, vrf.name, pattern)
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_default_metric_multiple_vrf
+  def test_default_metric_multiple_vrf
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
     metric = 35_000
-    # set metric
+
     vrf.default_metric = metric
     pattern = /\s+default-metric #{metric}/
     assert_match_vrf_line(routerospf.name, vrf.name, pattern)
@@ -309,7 +311,7 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_log_adjacency_changes
+  def test_log_adjacency_changes
     vrf = create_routerospfvrf
 
     assert_equal(:none, vrf.log_adjacency,
@@ -328,18 +330,17 @@ class TestRouterOspfVrf < CiscoTestCase
                  "Error: #{vrf.name} vrf, " \
                  'log-adjacency detail get value mismatch')
 
-    # set default log adjacency
     vrf.log_adjacency = vrf.default_log_adjacency
     pattern = /\s+log-adjacency-changes(.*)/
     refute_match_vrf_line(vrf.parent.name, vrf.name, pattern)
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_log_adjacency_multiple_vrf
+  def test_log_adjacency_multiple_vrf
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
-    # set log_adjacency
+
     vrf.log_adjacency = :log
     pattern = /\s+log-adjacency-changes/
     assert_match_vrf_line(routerospf.name, vrf.name, pattern)
@@ -347,7 +348,6 @@ class TestRouterOspfVrf < CiscoTestCase
                  "Error: #{vrf.name} vrf, log-adjacency get value mismatch")
 
     # vrf 1
-    # set log_adjacency
     vrf1.log_adjacency = :detail
     pattern = /\s+log-adjacency-changes/
     assert_match_vrf_line(routerospf.name, vrf1.name, pattern)
@@ -357,20 +357,19 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_log_adjacency_multiple_vrf_2
+  def test_log_adjacency_multiple_vrf_2
     routerospf = create_routerospf
     vrf_default = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
     # DO NOT set log_adjacency for default vrf
     # DO set log_adjacency for non-default vrf
-    # set log_adjacency
+
     vrf1.log_adjacency = :detail
     pattern = /\s+log-adjacency-changes/
     assert_match_vrf_line(routerospf.name, vrf1.name, pattern)
     assert_equal(:detail, vrf1.log_adjacency,
                  "Error: #{vrf1.name} vrf, log-adjacency get value mismatch")
 
-    # Make sure default vrf is set to :none
     assert_equal(:none, vrf_default.log_adjacency,
                  "Error: #{vrf_default.name} vrf_default, " \
                  'log-adjacency get value mismatch')
@@ -378,7 +377,7 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_router_id
+  def test_router_id
     vrf = create_routerospfvrf
     id = '8.1.1.3'
     vrf.router_id = id
@@ -386,18 +385,18 @@ class TestRouterOspfVrf < CiscoTestCase
     assert_match_vrf_line(vrf.parent.name, vrf.name, pattern)
     assert_equal(id, vrf.router_id,
                  "Error: #{vrf.name} vrf, router-id get value mismatch")
-    # set default router id
+
     vrf.router_id = vrf.default_router_id
     refute_match_vrf_line(vrf.parent.name, vrf.name, pattern)
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_router_id_multiple_vrf
+  def test_router_id_multiple_vrf
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
     id = '8.1.1.3'
-    # set id
+
     vrf.router_id = id
     pattern = /\s+router-id #{id}/
     assert_match_vrf_line(routerospf.name, vrf.name, pattern)
@@ -406,7 +405,7 @@ class TestRouterOspfVrf < CiscoTestCase
 
     # vrf 1
     id = '10.1.1.3'
-    # set id
+
     vrf1.router_id = id
     pattern = /\s+router-id #{id}/
     assert_match_vrf_line(routerospf.name, vrf1.name, pattern)
@@ -416,11 +415,11 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_timer_throttle_lsa
+  def test_timer_throttle_lsa
     vrf = create_routerospfvrf
     lsa = [] << 100 << 500 << 1000
     vrf.timer_throttle_lsa_set(lsa[0], lsa[1], lsa[2])
-    # vrf.send(:timer_throttle_lsa=, lsa[0], lsa[1], lsa[2])
+
     pattern = /\s+timers throttle lsa #{lsa[0]} #{lsa[1]} #{lsa[2]}/
     assert_match_vrf_line(vrf.parent.name, vrf.name, pattern)
     assert_equal(lsa, vrf.timer_throttle_lsa,
@@ -429,14 +428,13 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_timer_throttle_lsa_multiple_vrf
+  def test_timer_throttle_lsa_multiple_vrf
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
     lsa = [] << 100 << 500 << 1000
-    # set lsa
+
     vrf.timer_throttle_lsa_set(lsa[0], lsa[1], lsa[2])
-    # vrf.send(:timer_throttle_lsa=, lsa[0], lsa[1], lsa[2])
     pattern = /\s+timers throttle lsa #{lsa[0]} #{lsa[1]} #{lsa[2]}/
     assert_match_vrf_line(routerospf.name, vrf.name, pattern)
     assert_equal(lsa, vrf.timer_throttle_lsa,
@@ -444,9 +442,8 @@ class TestRouterOspfVrf < CiscoTestCase
                  'get values mismatch')
 
     lsa = [] << 300 << 700 << 2000
-    # set lsa
+
     vrf1.timer_throttle_lsa_set(lsa[0], lsa[1], lsa[2])
-    # vrf1.send(:timer_throttle_lsa=, lsa[0], lsa[1], lsa[2])
     pattern = /\s+timers throttle lsa #{lsa[0]} #{lsa[1]} #{lsa[2]}/
     assert_match_vrf_line(routerospf.name, vrf1.name, pattern)
     assert_equal(lsa, vrf1.timer_throttle_lsa,
@@ -456,7 +453,7 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_get_default_timer_throttle_lsa
+  def test_get_default_timer_throttle_lsa
     vrf = create_routerospfvrf
     lsa = [0, 5000, 5000]
     assert_equal(lsa[0], vrf.timer_throttle_lsa_start,
@@ -474,10 +471,10 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_timer_throttle_spf
+  def test_timer_throttle_spf
     vrf = create_routerospfvrf
     spf = [250, 500, 1000]
-    # vrf.send(:timer_throttle_spf=, spf[0], spf[1], spf[2])
+
     vrf.timer_throttle_spf_set(spf[0], spf[1], spf[2])
     pattern = /\s+timers throttle spf #{spf[0]} #{spf[1]} #{spf[2]}/
     assert_match_vrf_line(vrf.parent.name, vrf.name, pattern)
@@ -487,14 +484,13 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_timer_throttle_spf_multiple_vrf
+  def test_timer_throttle_spf_multiple_vrf
     routerospf = create_routerospf
     vrf = create_routerospfvrf(routerospf.name)
     vrf1 = create_routerospfvrf(routerospf.name, 'testvrf')
     spf = [] << 250 << 500 << 1000
-    # set spf
+
     vrf.timer_throttle_spf_set(spf[0], spf[1], spf[2])
-    # vrf.send(:timer_throttle_spf=, spf[0], spf[1], spf[2])
     pattern = /\s+timers throttle spf #{spf[0]} #{spf[1]} #{spf[2]}/
     assert_match_vrf_line(routerospf.name, vrf.name, pattern)
     assert_equal(spf, vrf.timer_throttle_spf,
@@ -502,9 +498,8 @@ class TestRouterOspfVrf < CiscoTestCase
                  'get values mismatch')
 
     spf = [] << 300 << 700 << 2000
-    # set spf
+
     vrf1.timer_throttle_spf_set(spf[0], spf[1], spf[2])
-    # vrf1.send(:timer_throttle_spf=, spf[0], spf[1], spf[2])
     pattern = /\s+timers throttle spf #{spf[0]} #{spf[1]} #{spf[2]}/
     assert_match_vrf_line(routerospf.name, vrf1.name, pattern)
     assert_equal(spf, vrf1.timer_throttle_spf,
@@ -514,7 +509,7 @@ class TestRouterOspfVrf < CiscoTestCase
     routerospf.destroy
   end
 
-  def test_routerospfvrf_get_default_timer_throttle_spf
+  def test_get_default_timer_throttle_spf
     vrf = create_routerospfvrf
     spf = [200, 1000, 5000]
     assert_equal(spf[0], vrf.default_timer_throttle_spf_start,
@@ -535,7 +530,7 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_create_valid_destroy_default
+  def test_create_valid_destroy_default
     ospfname = 'ospfTest'
     routerospf = RouterOspf.new(ospfname)
     vrfname = 'default'
@@ -576,7 +571,7 @@ class TestRouterOspfVrf < CiscoTestCase
   )
   # rubocop:enable Style/AlignHash
 
-  def test_routerospfvrf_collection_router_multi_vrfs
+  def test_collection_router_multi_vrfs
     config_from_hash(MULTIPLE_OSPFS_MULTIPLE_VRFS)
     routers = RouterOspf.routers
     # validate the collection
@@ -609,7 +604,7 @@ class TestRouterOspfVrf < CiscoTestCase
     end
   end
 
-  def test_routerospfvrf_timer_throttle_lsa_start_hold_max
+  def test_timer_throttle_lsa_start_hold_max
     vrf = create_routerospfvrf
     vrf.timer_throttle_lsa_set(250, 900, 5001)
     assert_equal(250, vrf.timer_throttle_lsa_start,
@@ -621,7 +616,7 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_timer_throttle_spf_start_hold_max
+  def test_timer_throttle_spf_start_hold_max
     vrf = create_routerospfvrf
     vrf.timer_throttle_spf_set(250, 900, 5001)
     assert_equal(250, vrf.timer_throttle_spf_start,
@@ -633,7 +628,7 @@ class TestRouterOspfVrf < CiscoTestCase
     vrf.parent.destroy
   end
 
-  def test_routerospfvrf_noninstantiated
+  def test_noninstantiated
     routerospf = create_routerospf
     vrf = RouterOspfVrf.new('absent', 'absent', false)
     vrf.auto_cost