cisco_node_utils 1.2.0 → 1.3.0

data/tests/test_bgp_neighbor_af.rb

@@ -22,7 +22,6 @@ require_relative '../lib/cisco_node_utils/cisco_cmn_utils'
 require_relative '../lib/cisco_node_utils/bgp'
 require_relative '../lib/cisco_node_utils/bgp_neighbor'
 require_relative '../lib/cisco_node_utils/bgp_neighbor_af'
-require_relative '../lib/cisco_node_utils/feature'
 
 # TestBgpNeighborAF - Minitest for RouterBgpNeighborAF class
 class TestBgpNeighborAF < CiscoTestCase
@@ -35,12 +34,16 @@ class TestBgpNeighborAF < CiscoTestCase
     super
     remove_all_bgps if @@pre_clean_needed
     @@pre_clean_needed = false # rubocop:disable Style/ClassVars
-    setup_nv_overlay_evpn
+    if platform == :nexus
+      setup_nv_overlay_evpn
+    else
+      setup_ios_xr
+    end
   end
 
   def teardown
-    super
     remove_all_bgps
+    super
   end
 
   def setup_nv_overlay_evpn
@@ -72,6 +75,58 @@ class TestBgpNeighborAF < CiscoTestCase
     [obj_af, dbg]
   end
 
+  # One time setup for XR
+  # this doesn't support the matrix very well but
+  # really only need to test 3 cases (ipv4 uni, l2vpn and a vrf)
+  def setup_ios_xr
+    return if platform == :nexus
+    asn   = 1
+    vrf   = 'aa'
+    nbr   = '1.1.1.1'
+    af_v4 = 'ipv4 unicast'
+    af_v6 = 'ipv6 unicast'
+    vpn   = 'vpnv4 unicast'
+    evpn  = 'l2vpn evpn'
+
+    cfg = []
+
+    # Global requirements
+    # route policies
+    str1 = 'route-map-in-name'
+    str2 = 'route-map-out-name'
+    cfg << "route-policy #{str1}" << 'end-policy'
+    cfg << "route-policy #{str2}" << 'end-policy'
+    cfg << "route-policy #{str1.reverse}" << 'end-policy'
+    cfg << "route-policy #{str2.reverse}" << 'end-policy'
+    cfg << 'route-policy foo_bar' << 'end-policy'
+    cfg << 'route-policy baz_inga' << 'end-policy'
+    cfg << 'rd-set auto' << 'end-set'
+
+    # If any of the above config already exists, we will get a
+    # CLI warning message about replacing existing configuration.
+    # Ignore these warnings, as they're intentional.
+    config_no_warn(*cfg)
+
+    cfg = []
+
+    # router-id and address-family under the global bgp
+    # remote-as under the neighbor
+    # VRF statements
+    cfg << "router bgp #{asn}"
+    cfg << "router bgp #{asn} bgp router-id 1.1.1.1"
+    cfg << "router bgp #{asn} neighbor #{nbr} remote-as #{asn}"
+    cfg << "router bgp #{asn} address-family #{af_v4}"
+    cfg << "router bgp #{asn} address-family #{af_v6}"
+    cfg << "router bgp #{asn} address-family #{vpn}"
+    cfg << "router bgp #{asn} address-family vpnv6 unicast"
+    cfg << "router bgp #{asn} address-family #{evpn}"
+    cfg << "router bgp #{asn} vrf #{vrf} rd auto"
+    cfg << "router bgp #{asn} vrf #{vrf} address-family #{af_v4}"
+    cfg << "router bgp #{asn} vrf #{vrf} neighbor #{nbr} remote-as #{asn}"
+
+    config(*cfg)
+  end
+
   # def test_foo
   #   af, dbg = clean_af([2, 'red', '1.1.1.1', %w(ipv4 unicast)])
   #   foo(af, dbg)
@@ -80,7 +135,7 @@ class TestBgpNeighborAF < CiscoTestCase
   # AF test matrix
   @@matrix = { # rubocop:disable Style/ClassVars
     # 1     => [1, 'default', '10:1::1', %w(ipv4 multicast)], # UNSUPPORTED
-    # 2     => [1, 'default', '10:1::1', %w(ipv4 unicast)],
+    # 2     => [1, 'default', '10:1::1', %w(ipv4 unicast)], # UNSUPPORTED in XR
     # 3     => [1, 'default', '10:1::1', %w(ipv6 multicast)],
     # 4     => [1, 'default', '10:1::1', %w(ipv6 unicast)],
     # 5     => [1, 'default', '1.1.1.1', %w(ipv4 multicast)],
@@ -88,7 +143,7 @@ class TestBgpNeighborAF < CiscoTestCase
     # 7     => [1, 'default', '1.1.1.1', %w(ipv6 multicast)],
     8     => [1, 'default', '1.1.1.1', %w(ipv6 unicast)],
     # 9     => [1, 'aa', '2.2.2.2', %w(ipv4 multicast)],
-    # 10    => [1, 'aa', '2.2.2.2', %w(ipv4 unicast)],
+    10    => [1, 'aa', '1.1.1.1', %w(ipv4 unicast)],
     # 11    => [1, 'bb', '2.2.2.2', %w(ipv6 multicast)],
     # 12    => [1, 'bb', '2.2.2.2', %w(ipv6 unicast)],
     # 13    => [1, 'cc', '10:1::2', %w(ipv4 multicast)], # UNSUPPORTED
@@ -100,14 +155,16 @@ class TestBgpNeighborAF < CiscoTestCase
 
   # ---------------------------------
   def test_nbr_af_create_destroy
-    config('no feature bgp', 'feature bgp')
-
     # Creates
     obj = {}
     @@matrix.each do |k, v|
       asn, vrf, nbr, af = v
       dbg = sprintf('[VRF %s NBR %s AF %s]', vrf, nbr, af)
       obj[k] = RouterBgpNeighborAF.new(asn, vrf, nbr, af, true)
+      # TBD: This flush should not be needed but we see an intermittent problem
+      # with certain rake test seed values, where 'afs' below is not detecting
+      # vrf 'aa' AF.
+      node.cache_flush
       afs = RouterBgpNeighborAF.afs
       assert(afs[asn][vrf][nbr].key?(af),
              "#{dbg} Failed to create AF")
@@ -126,16 +183,28 @@ class TestBgpNeighborAF < CiscoTestCase
 
   # ---------------------------------
   def test_nbrs_with_masks
-    config('no feature bgp', 'feature bgp')
-
     # Creates
     obj = {}
     @@matrix.each do |k, v|
       asn, vrf, nbr, af = v
       nbr += (nbr[/:/]) ? '/64' : '/16'
+      if platform == :ios_xr
+        # XR does not do slash masks and neighbors
+        # so make sure to catch the error
+        assert_raises(UnsupportedError,
+                      'Neighbors do not support slash notation') do
+          RouterBgpNeighborAF.new(asn, vrf, nbr, af, true)
+        end
+        next
+      end
+      next if platform == :ios_xr
       dbg = sprintf('[VRF %s NBR %s AF %s]', vrf, nbr, af.join('/'))
       obj[k] = RouterBgpNeighborAF.new(asn, vrf, nbr, af, true)
       nbr_munged = Utils.process_network_mask(nbr)
+      # TBD: This flush should not be needed but we see an intermittent problem
+      # with certain rake test seed values, where 'afs' below is not detecting
+      # vrf 'aa' AF.
+      node.cache_flush
       afs = RouterBgpNeighborAF.afs
       assert(afs[asn][vrf][nbr_munged].key?(af),
              "#{dbg} Failed to create AF")
@@ -145,6 +214,13 @@ class TestBgpNeighborAF < CiscoTestCase
     @@matrix.each do |k, v|
       asn, vrf, nbr, af = v
       nbr += (nbr[/:/]) ? '/64' : '/16'
+      if platform == :ios_xr
+        assert_raises(UnsupportedError,
+                      'Neighbors do not support slash notation') do
+          RouterBgpNeighborAF.new(asn, vrf, nbr, af, true)
+        end
+        next
+      end
       dbg = sprintf('[VRF %s NBR %s AF %s]', vrf, nbr, af.join('/'))
       obj[k].destroy
       nbr_munged = Utils.process_network_mask(nbr)
@@ -166,15 +242,21 @@ class TestBgpNeighborAF < CiscoTestCase
   def props_bool(af, dbg)
     # These properties have simple boolean states. As such we can use a common
     # set of tests to validate each property.
+    # XR the only properties supported (under all af's) are:
+    # :as_override,
+    # :next_hop_self,
+    # Nexus they are all supported, except when a l2vpn, in which case
+    # only disable_peer_as_check is supported.
     props = [
       :as_override,
-      :disable_peer_as_check,
       :next_hop_self,
-      :next_hop_third_party,
-      :suppress_inactive,
     ]
 
-    props = [:disable_peer_as_check] if dbg.include?('l2vpn/evpn')
+    if platform == :nexus
+      props << :next_hop_third_party
+      props << :suppress_inactive
+      props = [:disable_peer_as_check] if dbg.include?('l2vpn/evpn')
+    end
 
     # Call setter to false, then validate with getter
     props.each { |k| af.send("#{k}=", false) }
@@ -207,19 +289,23 @@ class TestBgpNeighborAF < CiscoTestCase
   end
 
   def props_string(af, dbg)
-    # These properties have a common string value (route-map), allowing them
-    # to use a common set of tests to validate each property.
-    props = {
-      filter_list_in:  'filt-in-name',
-      filter_list_out: 'filt-out-name',
-      prefix_list_in:  'pref-in-name',
-      prefix_list_out: 'pref-out-name',
-      route_map_in:    'route-map-in-name',
-      route_map_out:   'route-map-out-name',
-      unsuppress_map:  'unsupp-map-name',
-    }
-
-    props.delete(:unsuppress_map) if dbg.include?('l2vpn/evpn')
+    if platform == :nexus
+      props = {
+        filter_list_in:  'filt-in-name',
+        filter_list_out: 'filt-out-name',
+        prefix_list_in:  'pref-in-name',
+        prefix_list_out: 'pref-out-name',
+        route_map_in:    'route-map-in-name',
+        route_map_out:   'route-map-out-name',
+        unsuppress_map:  'unsupp-map-name',
+      }
+      props.delete(:unsuppress_map) if dbg.include?('l2vpn/evpn')
+    else
+      props = {
+        route_map_in:  'route-map-in-name',
+        route_map_out: 'route-map-out-name',
+      }
+    end
 
     props.each do |k, v|
       # Call setter.
@@ -247,32 +333,36 @@ class TestBgpNeighborAF < CiscoTestCase
   #   soft_reconfiguration_in
 
   def supports_soft_reconfig_always?
-    return true if node.product_id[/N(3|9)K/]
-    false
+    str = node.cmd_ref.lookup('bgp_neighbor_af',
+                              'soft_reconfiguration_in').set_value
+    str.to_s[/always/]
   end
 
   def test_tri_states
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
-
       next if dbg.include?('l2vpn/evpn')
       %w(additional_paths_receive additional_paths_send).each do |k|
-        [:enable, :disable, :inherit, 'enable', 'disable', 'inherit',
-         af.send("default_#{k}")
-        ].each do |val|
-          af.send("#{k}=", val)
-          assert_equal(val.to_sym, af.send(k), "#{dbg} Error: #{k}")
+        if validate_property_excluded?('bgp_neighbor_af', k)
+          assert_raises(UnsupportedError) { af.send("#{k}=", 'enable') }
+        else
+          [:enable, :disable, :inherit,
+           'enable', 'disable', 'inherit',
+           af.send("default_#{k}")
+          ].each do |val|
+            af.send("#{k}=", val)
+            assert_equal(val.to_sym, af.send(k), "#{dbg} Error: #{k}")
+          end
         end
       end
 
-      # The 'always' keyword is not supported on N6K / N7K
       %w(soft_reconfiguration_in).each do |k|
-        if supports_soft_reconfig_always?
-          array = [:enable, :always, :inherit, 'enable', 'always', 'inherit',
-                   af.send("default_#{k}")]
-        else
-          array = [:enable, :inherit, 'enable', 'inherit',
-                   af.send("default_#{k}")]
+        array = [:enable, :always, :inherit,
+                 'enable', 'always', 'inherit',
+                 af.send("default_#{k}")]
+        unless supports_soft_reconfig_always?
+          array.delete(:always)
+          array.delete('always')
         end
 
         array.each do |val|
@@ -287,7 +377,7 @@ class TestBgpNeighborAF < CiscoTestCase
   def test_advertise_map
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
-      next if dbg.include?('l2vpn/evpn')
+      next if dbg.include?('l2vpn/evpn') && platform == :nexus
       advertise_map(af, dbg)
     end
   end
@@ -295,6 +385,12 @@ class TestBgpNeighborAF < CiscoTestCase
   def advertise_map(af, dbg)
     %w(advertise_map_exist advertise_map_non_exist).each do |k|
       v = %w(foo bar)
+      if platform == :ios_xr
+        assert_raises(UnsupportedError) do
+          af.send("#{k}=", v)
+        end
+        next
+      end
       af.send("#{k}=", v)
       assert_equal(v, af.send(k),
                    "Test 1. #{dbg} [#{k}=] did not set strings '#{v}'")
@@ -367,7 +463,6 @@ class TestBgpNeighborAF < CiscoTestCase
     af.default_originate_set(true)
     assert(af.default_originate,
            "Test 1. #{dbg} Failed to set state to True")
-
     # Test true with route-map
     af.default_originate_set(true, 'foo_bar')
     assert_equal('foo_bar', af.default_originate_route_map,
@@ -388,8 +483,6 @@ class TestBgpNeighborAF < CiscoTestCase
     af.default_originate_set(true, af.default_default_originate_route_map)
     refute(af.default_originate_route_map,
            "Test 5. #{dbg} Failed to set default route-map from existing")
-
-    # Test default_state
     af.default_originate_set(af.default_default_originate)
     refute(af.default_originate,
            "Test 6. #{dbg} Failed to set state to default")
@@ -430,7 +523,7 @@ class TestBgpNeighborAF < CiscoTestCase
                  "Test 3c. #{dbg} Failed to set interval to '#{interval}'")
 
     limit = 97
-    threshold = nil
+    threshold = platform == :nexus ? nil : 75
     warning = true
     af.max_prefix_set(limit, threshold, warning)
     assert_equal(limit, af.max_prefix_limit,
@@ -441,7 +534,7 @@ class TestBgpNeighborAF < CiscoTestCase
                  "Test 4c. #{dbg} Failed to set warning to '#{warning}'")
 
     limit = 96
-    threshold = nil
+    threshold = platform == :nexus ? nil : 75
     interval = 26
     af.max_prefix_set(limit, threshold, interval)
     assert_equal(limit, af.max_prefix_limit,
@@ -487,7 +580,7 @@ class TestBgpNeighborAF < CiscoTestCase
                  "Test 9a. #{dbg} Failed to set limit to '#{limit}'")
     assert_equal(threshold, af.max_prefix_threshold,
                  "Test 9b. #{dbg} Failed to set threshold to '#{threshold}'")
-    assert_equal(warning, af.max_prefix_warning,
+    assert_equal((platform == :nexus ? warning : nil), af.max_prefix_warning,
                  "Test 9c. #{dbg} Failed to set warning to '#{warning}'")
 
     af.max_prefix_set(nil)
@@ -522,16 +615,14 @@ class TestBgpNeighborAF < CiscoTestCase
 
   # ---------------------------------
   def test_send_community
-    # iBGP only, do extra cleanup
-    config('no feature bgp', 'feature bgp')
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
-      send_community(af, dbg)
+      send_comm(af, dbg)
     end
     @@pre_clean_needed = true # rubocop:disable Style/ClassVars
   end
 
-  def send_community(af, dbg)
+  def send_comm(af, dbg)
     v = 'both'
     af.send_community = v
     assert_equal(v, af.send_community,
@@ -553,7 +644,6 @@ class TestBgpNeighborAF < CiscoTestCase
     af.send_community = v
     assert_equal(v, af.send_community,
                  "Test 3b. #{dbg} Failed to set '#{v}' from 'standard'")
-
     v = 'extended'
     af.send_community = v
     assert_equal(v, af.send_community,
@@ -563,7 +653,6 @@ class TestBgpNeighborAF < CiscoTestCase
     af.send_community = v
     assert_equal(v, af.send_community,
                  "Test 5. #{dbg} Failed to set '#{v}' from 'extended'")
-
     v = 'standard'
     af.send_community = v
     assert_equal(v, af.send_community,
@@ -572,7 +661,6 @@ class TestBgpNeighborAF < CiscoTestCase
     af.send_community = v
     assert_equal(v, af.send_community,
                  "Test 7. #{dbg} Failed to set '#{v}' from 'standard'")
-
     v = 'none'
     af.send_community = v
     assert_equal(v, af.send_community,
@@ -580,7 +668,7 @@ class TestBgpNeighborAF < CiscoTestCase
 
     v = 'both'
     af.send_community = v
-    assert_equal(v, af.send_community,
+    assert_equal('both', af.send_community,
                  "Test 9. #{dbg} Failed to set '#{v}' from None")
 
     v = af.default_send_community
@@ -600,37 +688,50 @@ class TestBgpNeighborAF < CiscoTestCase
   def soo(af, dbg)
     val = '1.1.1.1:1'
 
-    if dbg.include?('default')
-      assert_raises(CliError, "Test 1. #{dbg}[soo=] did not raise CliError") do
+    if platform == :ios_xr
+      assert_raises(Cisco::UnsupportedError) do
         af.soo = val
       end
-      # SOO is only allowed in non-default VRF
-      return
+    else
+      if dbg.include?('default')
+        str = "Test 1. #{dbg}[soo=] did not raise CliError"
+        assert_raises(CliError, str) do
+          af.soo = val
+        end
+        # SOO is only allowed in non-default VRF
+        return
+      end
     end
 
-    # Set initial
-    af.soo = val
-    assert_equal(val, af.soo,
-                 "Test 2. #{dbg} Failed to set '#{val}'")
-
-    # Change to new string
-    val = '2:2'
-    af.soo = val
-    assert_equal(val, af.soo,
-                 "Test 3. #{dbg} Failed to change to '#{val}'")
-
-    # Set to default
-    val = af.default_soo
-    af.soo = val
-    assert_empty(af.soo,
-                 "Test 4. #{dbg} Failed to set default '#{val}'")
+    if platform == :nexus
+      # Set initial
+      af.soo = val
+      assert_equal(val, af.soo,
+                   "Test 2. #{dbg} Failed to set '#{val}'")
+
+      # Change to new string
+      val = '2:2'
+      af.soo = val
+      assert_equal(val, af.soo,
+                   "Test 3. #{dbg} Failed to change to '#{val}'")
+
+      # Set to default
+      val = af.default_soo
+      af.soo = val
+      assert_empty(af.soo,
+                   "Test 4. #{dbg} Failed to set default '#{val}'")
+    else
+      assert_raises(Cisco::UnsupportedError) do
+        af.soo = val
+      end
+    end
   end
 
   # --------------------------------
   def test_weight
     @@matrix.values.each do |af_args|
       af, dbg = clean_af(af_args)
-      weight(af, dbg) unless dbg.include?('l2vpn/evpn')
+      weight(af, dbg) unless dbg.include?('l2vpn/evpn') && platform == :nexus
     end
   end