capybara 3.3.1 → 3.4.0

data/spec/rspec/views_spec.rb

@@ -2,10 +2,10 @@
 
 require 'spec_helper'
 
-RSpec.describe "capybara/rspec", type: :view do
-  it "allows matchers to be used on strings" do
+RSpec.describe 'capybara/rspec', type: :view do
+  it 'allows matchers to be used on strings' do
     html = %(<h1>Test header</h1>)
-    expect(html).to have_css("h1", text: "Test header")
+    expect(html).to have_css('h1', text: 'Test header')
   end
 
   it "doesn't include RSpecMatcherProxies" do

data/spec/rspec_matchers_spec.rb

@@ -3,22 +3,22 @@
 require 'spec_helper'
 
 RSpec.describe 'Capybara RSpec Matchers', type: :feature do
-  context "after called on session" do
-    it "HaveSelector should allow getting a description of the matcher" do
+  context 'after called on session' do
+    it 'HaveSelector should allow getting a description of the matcher' do
       visit('/with_html')
       matcher = have_selector(:css, 'h2.head', minimum: 3)
       expect(page).to matcher
       expect { matcher.description }.not_to raise_error
     end
 
-    it "HaveText should allow getting a description" do
+    it 'HaveText should allow getting a description' do
       visit('/with_html')
-      matcher = have_text("Lorem")
+      matcher = have_text('Lorem')
       expect(page).to matcher
       expect { matcher.description }.not_to raise_error
     end
 
-    it "should produce the same error for .to have_no_xxx and .not_to have_xxx" do
+    it 'should produce the same error for .to have_no_xxx and .not_to have_xxx' do
       visit('/with_html')
       not_to_msg = error_msg_for { expect(page).not_to have_selector(:css, '#referrer') }
       have_no_msg = error_msg_for { expect(page).to have_no_selector(:css, '#referrer') }
@@ -30,8 +30,8 @@ RSpec.describe 'Capybara RSpec Matchers', type: :feature do
     end
   end
 
-  context "after called on element" do
-    it "HaveSelector should allow getting a description" do
+  context 'after called on element' do
+    it 'HaveSelector should allow getting a description' do
       visit('/with_html')
       el = find(:css, '#first')
       matcher = have_selector(:css, 'a#foo')
@@ -39,7 +39,7 @@ RSpec.describe 'Capybara RSpec Matchers', type: :feature do
       expect { matcher.description }.not_to raise_error
     end
 
-    it "MatchSelector should allow getting a description" do
+    it 'MatchSelector should allow getting a description' do
       visit('/with_html')
       el = find(:css, '#first')
       matcher = match_selector(:css, '#first')
@@ -47,10 +47,10 @@ RSpec.describe 'Capybara RSpec Matchers', type: :feature do
       expect { matcher.description }.not_to raise_error
     end
 
-    it "HaveText should allow getting a description" do
+    it 'HaveText should allow getting a description' do
       visit('/with_html')
       el = find(:css, '#first')
-      matcher = have_text("Lorem")
+      matcher = have_text('Lorem')
       expect(el).to matcher
       expect { matcher.description }.not_to raise_error
     end

data/spec/rspec_spec.rb

@@ -3,69 +3,69 @@
 require 'spec_helper'
 
 RSpec.describe 'capybara/rspec' do
-  context "Feature", type: :feature do
-    it "should include Capybara in rspec" do
+  context 'Feature', type: :feature do
+    it 'should include Capybara in rspec' do
       visit('/foo')
       expect(page.body).to include('Another World')
     end
 
-    it "should include RSpec matcher proxies" do
+    it 'should include RSpec matcher proxies' do
       expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
     end
 
-    context "resetting session" do
-      it "sets a cookie in one example..." do
+    context 'resetting session' do
+      it 'sets a cookie in one example...' do
         visit('/set_cookie')
         expect(page.body).to include('Cookie set to test_cookie')
       end
 
-      it "...then it is not available in the next" do
+      it '...then it is not available in the next' do
         visit('/get_cookie')
         expect(page.body).not_to include('test_cookie')
       end
     end
 
-    context "setting the current driver" do
-      it "sets the current driver in one example..." do
+    context 'setting the current driver' do
+      it 'sets the current driver in one example...' do
         Capybara.current_driver = :selenium
       end
 
-      it "...then it has returned to the default in the next example" do
+      it '...then it has returned to the default in the next example' do
         expect(Capybara.current_driver).to eq(:rack_test)
       end
     end
 
-    it "switches to the javascript driver when giving it as metadata", js: true do
+    it 'switches to the javascript driver when giving it as metadata', js: true do
       expect(Capybara.current_driver).to eq(Capybara.javascript_driver)
     end
 
-    it "switches to the given driver when giving it as metadata", driver: :culerity do
+    it 'switches to the given driver when giving it as metadata', driver: :culerity do
       expect(Capybara.current_driver).to eq(:culerity)
     end
 
-    context "#all" do
-      it "allows access to the Capybara finder" do
+    context '#all' do
+      it 'allows access to the Capybara finder' do
         visit('/with_html')
         found = all(:css, 'h2') { |element| element[:class] == 'head' }
         expect(found.size).to eq(5)
       end
 
-      it "allows access to the RSpec matcher" do
+      it 'allows access to the RSpec matcher' do
         visit('/with_html')
         strings = %w[test1 test2]
         expect(strings).to all(be_a(String))
       end
     end
 
-    context "#within" do
-      it "allows access to the Capybara scoper" do
+    context '#within' do
+      it 'allows access to the Capybara scoper' do
         visit('/with_html')
         expect do
-          within(:css, "#does_not_exist") { click_link "Go to simple" }
+          within(:css, '#does_not_exist') { click_link 'Go to simple' }
         end.to raise_error(Capybara::ElementNotFound)
       end
 
-      it "allows access to the RSpec matcher" do
+      it 'allows access to the RSpec matcher' do
         visit('/with_html')
         # This reads terribly, but must call #within
         expect(find(:css, 'span.number').text.to_i).to within(1).of(41)
@@ -74,7 +74,7 @@ RSpec.describe 'capybara/rspec' do
   end
 
   context 'Type: Other', type: :other do
-    context "when RSpec::Matchers is included after Capybara::DSL" do
+    context 'when RSpec::Matchers is included after Capybara::DSL' do
       before do
         class DSLMatchersTest
           include Capybara::DSL
@@ -84,28 +84,28 @@ RSpec.describe 'capybara/rspec' do
         @test_class_instance = DSLMatchersTest.new
       end
 
-      context "#all" do
-        it "allows access to the Capybara finder" do
+      context '#all' do
+        it 'allows access to the Capybara finder' do
           @test_class_instance.visit('/with_html')
           expect(@test_class_instance.all(:css, 'h2.head').size).to eq(5)
         end
 
-        it "allows access to the RSpec matcher" do
+        it 'allows access to the RSpec matcher' do
           @test_class_instance.visit('/with_html')
           strings = %w[test1 test2]
           expect(strings).to @test_class_instance.all(be_a(String))
         end
       end
 
-      context "#within" do
-        it "allows access to the Capybara scoper" do
+      context '#within' do
+        it 'allows access to the Capybara scoper' do
           @test_class_instance.visit('/with_html')
           expect do
-            @test_class_instance.within(:css, "#does_not_exist") { @test_class_instance.click_link "Go to simple" }
+            @test_class_instance.within(:css, '#does_not_exist') { @test_class_instance.click_link 'Go to simple' }
           end.to raise_error(Capybara::ElementNotFound)
         end
 
-        it "allows access to the RSpec matcher" do
+        it 'allows access to the RSpec matcher' do
           @test_class_instance.visit('/with_html')
           # This reads terribly, but must call #within
           expect(@test_class_instance.find(:css, 'span.number').text.to_i).to @test_class_instance.within(1).of(41)
@@ -113,14 +113,14 @@ RSpec.describe 'capybara/rspec' do
       end
     end
 
-    it "should not include Capybara" do
+    it 'should not include Capybara' do
       expect { visit('/') }.to raise_error(NoMethodError)
     end
   end
 end
 
-feature "Feature DSL" do
-  scenario "is pulled in" do
+feature 'Feature DSL' do
+  scenario 'is pulled in' do
     visit('/foo')
     expect(page.body).to include('Another World')
   end

data/spec/selector_spec.rb

@@ -61,17 +61,17 @@ RSpec.describe Capybara do
       end
     end
 
-    it "supports `filter` as an alias for `node_filter`" do
+    it 'supports `filter` as an alias for `node_filter`' do
       expect do
         Capybara.add_selector :filter_alias_selector do
-          css { |_unused| "div" }
+          css { |_unused| 'div' }
           filter(:something) { |_node, _value| true }
         end
       end.not_to raise_error
     end
 
-    describe "adding a selector" do
-      it "can set default visiblity" do
+    describe 'adding a selector' do
+      it 'can set default visiblity' do
         Capybara.add_selector :hidden_field do
           visible :hidden
           css { |_sel| 'input[type="hidden"]' }
@@ -82,8 +82,8 @@ RSpec.describe Capybara do
       end
     end
 
-    describe "modify_selector" do
-      it "allows modifying a selector" do
+    describe 'modify_selector' do
+      it 'allows modifying a selector' do
         el = string.find(:custom_selector, 'a')
         expect(el.tag_name).to eq 'div'
         Capybara.modify_selector :custom_selector do
@@ -103,21 +103,21 @@ RSpec.describe Capybara do
       end
     end
 
-    describe "builtin selectors" do
-      context "when locator is nil" do
-        it "devolves to just finding element types" do
+    describe 'builtin selectors' do
+      context 'when locator is nil' do
+        it 'devolves to just finding element types' do
           selectors = {
             field: ".//*[self::input | self::textarea | self::select][not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]",
-            fieldset: ".//fieldset",
-            link: ".//a[./@href]",
+            fieldset: './/fieldset',
+            link: './/a[./@href]',
             link_or_button: ".//a[./@href] | .//input[./@type = 'submit' or ./@type = 'reset' or ./@type = 'image' or ./@type = 'button'] | .//button",
             fillable_field: ".//*[self::input | self::textarea][not(./@type = 'submit' or ./@type = 'image' or ./@type = 'radio' or ./@type = 'checkbox' or ./@type = 'hidden' or ./@type = 'file')]",
             radio_button: ".//input[./@type = 'radio']",
             checkbox: ".//input[./@type = 'checkbox']",
-            select: ".//select",
-            option: ".//option",
+            select: './/select',
+            option: './/option',
             file_field: ".//input[./@type = 'file']",
-            table: ".//table"
+            table: './/table'
           }
           selectors.each do |selector, xpath|
             results = string.all(selector, nil).to_a.map(&:native)
@@ -127,53 +127,53 @@ RSpec.describe Capybara do
         end
       end
 
-      context "with :id option" do
-        it "works with compound css selectors" do
-          expect(string.all(:custom_css_selector, "div, h1", id: 'page').size).to eq 1
-          expect(string.all(:custom_css_selector, "h1, div", id: 'page').size).to eq 1
+      context 'with :id option' do
+        it 'works with compound css selectors' do
+          expect(string.all(:custom_css_selector, 'div, h1', id: 'page').size).to eq 1
+          expect(string.all(:custom_css_selector, 'h1, div', id: 'page').size).to eq 1
         end
 
         it "works with 'special' characters" do
-          expect(string.find(:custom_css_selector, "div", id: "#special")[:id]).to eq '#special'
-          expect(string.find(:custom_css_selector, "input", id: "2checkbox")[:id]).to eq '2checkbox'
+          expect(string.find(:custom_css_selector, 'div', id: '#special')[:id]).to eq '#special'
+          expect(string.find(:custom_css_selector, 'input', id: '2checkbox')[:id]).to eq '2checkbox'
         end
 
-        it "accepts XPath expression for xpath based selectors" do
+        it 'accepts XPath expression for xpath based selectors' do
           expect(string.find(:custom_xpath_selector, './/div', id: XPath.contains('peci'))[:id]).to eq '#special'
           expect(string.find(:custom_xpath_selector, './/input', id: XPath.ends_with('box'))[:id]).to eq '2checkbox'
         end
 
-        it "errors XPath expression for CSS based selectors" do
-          expect { string.find(:custom_css_selector, "div", id: XPath.contains('peci')) }
+        it 'errors XPath expression for CSS based selectors' do
+          expect { string.find(:custom_css_selector, 'div', id: XPath.contains('peci')) }
             .to raise_error(ArgumentError, /not supported/)
         end
       end
 
-      context "with :class option" do
-        it "works with compound css selectors" do
-          expect(string.all(:custom_css_selector, "div, h1", class: 'a').size).to eq 2
-          expect(string.all(:custom_css_selector, "h1, div", class: 'a').size).to eq 2
+      context 'with :class option' do
+        it 'works with compound css selectors' do
+          expect(string.all(:custom_css_selector, 'div, h1', class: 'a').size).to eq 2
+          expect(string.all(:custom_css_selector, 'h1, div', class: 'a').size).to eq 2
         end
 
-        it "handles negated classes" do
-          expect(string.all(:custom_css_selector, "div, p", class: ['b', '!c']).size).to eq 2
-          expect(string.all(:custom_css_selector, "div, p", class: ['!c', '!d', 'b']).size).to eq 1
+        it 'handles negated classes' do
+          expect(string.all(:custom_css_selector, 'div, p', class: ['b', '!c']).size).to eq 2
+          expect(string.all(:custom_css_selector, 'div, p', class: ['!c', '!d', 'b']).size).to eq 1
           expect(string.all(:custom_xpath_selector, XPath.descendant(:div, :p), class: ['b', '!c']).size).to eq 2
           expect(string.all(:custom_xpath_selector, XPath.descendant(:div, :p), class: ['!c', '!d', 'b']).size).to eq 1
         end
 
         it "works with 'special' characters" do
-          expect(string.find(:custom_css_selector, "input", class: ".special")[:id]).to eq 'file'
-          expect(string.find(:custom_css_selector, "input", class: "2checkbox")[:id]).to eq '2checkbox'
+          expect(string.find(:custom_css_selector, 'input', class: '.special')[:id]).to eq 'file'
+          expect(string.find(:custom_css_selector, 'input', class: '2checkbox')[:id]).to eq '2checkbox'
         end
 
-        it "accepts XPath expression for xpath based selectors" do
+        it 'accepts XPath expression for xpath based selectors' do
           expect(string.find(:custom_xpath_selector, './/div', class: XPath.contains('dom wor'))[:id]).to eq 'random_words'
           expect(string.find(:custom_xpath_selector, './/div', class: XPath.ends_with('words'))[:id]).to eq 'random_words'
         end
 
-        it "errors XPath expression for CSS based selectors" do
-          expect { string.find(:custom_css_selector, "div", class: XPath.contains('random')) }
+        it 'errors XPath expression for CSS based selectors' do
+          expect { string.find(:custom_css_selector, 'div', class: XPath.contains('random')) }
             .to raise_error(ArgumentError, /not supported/)
         end
       end
@@ -181,96 +181,96 @@ RSpec.describe Capybara do
       # :css, :xpath, :id, :field, :fieldset, :link, :button, :link_or_button, :fillable_field, :radio_button, :checkbox, :select,
       # :option, :file_field, :label, :table, :frame
 
-      describe ":css selector" do
-        it "finds by CSS locator" do
-          expect(string.find(:css, "input#my_text_input")[:name]).to eq 'form[my_text_input]'
+      describe ':css selector' do
+        it 'finds by CSS locator' do
+          expect(string.find(:css, 'input#my_text_input')[:name]).to eq 'form[my_text_input]'
         end
       end
 
-      describe ":xpath selector" do
-        it "finds by XPath locator" do
+      describe ':xpath selector' do
+        it 'finds by XPath locator' do
           expect(string.find(:xpath, './/input[@id="my_text_input"]')[:name]).to eq 'form[my_text_input]'
         end
       end
 
-      describe ":id selector" do
-        it "finds by locator" do
-          expect(string.find(:id, "my_text_input")[:name]).to eq 'form[my_text_input]'
+      describe ':id selector' do
+        it 'finds by locator' do
+          expect(string.find(:id, 'my_text_input')[:name]).to eq 'form[my_text_input]'
         end
       end
 
-      describe ":field selector" do
-        it "finds by locator" do
+      describe ':field selector' do
+        it 'finds by locator' do
           expect(string.find(:field, 'My Text Input')[:id]).to eq 'my_text_input'
           expect(string.find(:field, 'my_text_input')[:id]).to eq 'my_text_input'
           expect(string.find(:field, 'form[my_text_input]')[:id]).to eq 'my_text_input'
         end
 
-        it "finds by id" do
+        it 'finds by id' do
           expect(string.find(:field, id: 'my_text_input')[:name]).to eq 'form[my_text_input]'
         end
 
-        it "finds by name" do
+        it 'finds by name' do
           expect(string.find(:field, name: 'form[my_text_input]')[:id]).to eq 'my_text_input'
         end
 
-        it "finds by placeholder" do
+        it 'finds by placeholder' do
           expect(string.find(:field, placeholder: 'my text')[:id]).to eq 'my_text_input'
         end
 
-        it "finds by type" do
+        it 'finds by type' do
           expect(string.find(:field, type: 'file')[:id]).to eq 'file'
           expect(string.find(:field, type: 'select')[:id]).to eq 'select'
         end
       end
 
-      describe ":option selector" do
-        it "finds disabled options" do
+      describe ':option selector' do
+        it 'finds disabled options' do
           expect(string.find(:option, disabled: true).value).to eq 'b'
         end
 
-        it "finds selected options" do
+        it 'finds selected options' do
           expect(string.find(:option, selected: true).value).to eq 'c'
         end
 
-        it "finds not selected and not disabled options" do
+        it 'finds not selected and not disabled options' do
           expect(string.find(:option, disabled: false, selected: false).value).to eq 'a'
         end
       end
 
-      describe ":button selector" do
-        it "finds by value" do
+      describe ':button selector' do
+        it 'finds by value' do
           expect(string.find(:button, 'click me').value).to eq 'click me'
         end
 
-        it "finds by title" do
+        it 'finds by title' do
           expect(string.find(:button, 'submit button').value).to eq 'click me'
         end
 
-        it "includes non-matching parameters in failure message" do
+        it 'includes non-matching parameters in failure message' do
           expect { string.find(:button, 'click me', title: 'click me') }.to raise_error(/with title click me/)
         end
       end
 
-      describe ":element selector" do
-        it "finds by any attributes" do
+      describe ':element selector' do
+        it 'finds by any attributes' do
           expect(string.find(:element, 'input', type: 'submit').value).to eq 'click me'
         end
 
-        it "still works with system keys" do
+        it 'still works with system keys' do
           expect { string.all(:element, 'input', type: 'submit', count: 1) }.not_to raise_error
         end
 
-        it "includes wildcarded keys in description" do
+        it 'includes wildcarded keys in description' do
           expect { string.find(:element, 'input', not_there: 'bad', count: 1) }
             .to(raise_error do |e|
               expect(e).to be_a(Capybara::ElementNotFound)
-              expect(e.message).to include "not_there => bad"
-              expect(e.message).not_to include "count 1"
+              expect(e.message).to include 'not_there => bad'
+              expect(e.message).not_to include 'count 1'
             end)
         end
 
-        it "accepts XPath::Expression" do
+        it 'accepts XPath::Expression' do
           expect(string.find(:element, 'input', type: XPath.starts_with('subm')).value).to eq 'click me'
           expect(string.find(:element, 'input', type: XPath.ends_with('ext'))[:type]).to eq 'text'
           expect(string.find(:element, 'input', type: XPath.contains('ckb'))[:type]).to eq 'checkbox'