capybara 3.3.1 → 3.4.0

data/spec/dsl_spec.rb

@@ -7,9 +7,14 @@ class TestClass
   include Capybara::DSL
 end
 
-Capybara::SpecHelper.run_specs TestClass.new, "DSL", capybara_skip: %i[
+Capybara::SpecHelper.run_specs TestClass.new, 'DSL', capybara_skip: %i[
   js modals screenshot frames windows send_keys server hover about_scheme psc download css
-]
+] do |example|
+  case example.metadata[:full_description]
+  when /doesn't raise exception on a nil current_url$/
+    skip 'Only makes sense when there is a real driver'
+  end
+end
 
 RSpec.describe Capybara::DSL do
   after do
@@ -21,42 +26,42 @@ RSpec.describe Capybara::DSL do
   end
 
   describe '#default_driver' do
-    it "should default to rack_test" do
+    it 'should default to rack_test' do
       expect(Capybara.default_driver).to eq(:rack_test)
     end
 
-    it "should be changeable" do
+    it 'should be changeable' do
       Capybara.default_driver = :culerity
       expect(Capybara.default_driver).to eq(:culerity)
     end
   end
 
   describe '#current_driver' do
-    it "should default to the default driver" do
+    it 'should default to the default driver' do
       expect(Capybara.current_driver).to eq(:rack_test)
       Capybara.default_driver = :culerity
       expect(Capybara.current_driver).to eq(:culerity)
     end
 
-    it "should be changeable" do
+    it 'should be changeable' do
       Capybara.current_driver = :culerity
       expect(Capybara.current_driver).to eq(:culerity)
     end
   end
 
   describe '#javascript_driver' do
-    it "should default to selenium" do
+    it 'should default to selenium' do
       expect(Capybara.javascript_driver).to eq(:selenium)
     end
 
-    it "should be changeable" do
+    it 'should be changeable' do
       Capybara.javascript_driver = :culerity
       expect(Capybara.javascript_driver).to eq(:culerity)
     end
   end
 
   describe '#use_default_driver' do
-    it "should restore the default driver" do
+    it 'should restore the default driver' do
       Capybara.current_driver = :culerity
       Capybara.use_default_driver
       expect(Capybara.current_driver).to eq(:rack_test)
@@ -84,8 +89,8 @@ RSpec.describe Capybara::DSL do
     it 'should reset the driver even if an exception occurs' do
       driver_before_block = Capybara.current_driver
       begin
-        Capybara.using_driver(:selenium) { raise "ohnoes!" }
-      rescue Exception # rubocop:disable Lint/RescueException
+        Capybara.using_driver(:selenium) { raise 'ohnoes!' }
+      rescue Exception # rubocop:disable Lint/RescueException,Lint/HandleExceptions
       end
       expect(Capybara.current_driver).to eq(driver_before_block)
     end
@@ -117,7 +122,7 @@ RSpec.describe Capybara::DSL do
       Capybara.default_max_wait_time = @previous_wait_time
     end
 
-    it "should switch the wait time and switch it back" do
+    it 'should switch the wait time and switch it back' do
       in_block = nil
       Capybara.using_wait_time 6 do
         in_block = Capybara.default_max_wait_time
@@ -126,40 +131,40 @@ RSpec.describe Capybara::DSL do
       expect(Capybara.default_max_wait_time).to eq(@previous_wait_time)
     end
 
-    it "should ensure wait time is reset" do
+    it 'should ensure wait time is reset' do
       expect do
         Capybara.using_wait_time 6 do
-          raise "hell"
+          raise 'hell'
         end
-      end.to raise_error(RuntimeError, "hell")
+      end.to raise_error(RuntimeError, 'hell')
       expect(Capybara.default_max_wait_time).to eq(@previous_wait_time)
     end
   end
 
   describe '#app' do
-    it "should be changeable" do
-      Capybara.app = "foobar"
+    it 'should be changeable' do
+      Capybara.app = 'foobar'
       expect(Capybara.app).to eq('foobar')
     end
   end
 
   describe '#current_session' do
-    it "should choose a session object of the current driver type" do
+    it 'should choose a session object of the current driver type' do
       expect(Capybara.current_session).to be_a(Capybara::Session)
     end
 
-    it "should use #app as the application" do
+    it 'should use #app as the application' do
       Capybara.app = proc {}
       expect(Capybara.current_session.app).to eq(Capybara.app)
     end
 
-    it "should change with the current driver" do
+    it 'should change with the current driver' do
       expect(Capybara.current_session.mode).to eq(:rack_test)
       Capybara.current_driver = :selenium
       expect(Capybara.current_session.mode).to eq(:selenium)
     end
 
-    it "should be persistent even across driver changes" do
+    it 'should be persistent even across driver changes' do
       object_id = Capybara.current_session.object_id
       expect(Capybara.current_session.object_id).to eq(object_id)
       Capybara.current_driver = :selenium
@@ -170,7 +175,7 @@ RSpec.describe Capybara::DSL do
       expect(Capybara.current_session.object_id).to eq(object_id)
     end
 
-    it "should change when changing application" do
+    it 'should change when changing application' do
       object_id = Capybara.current_session.object_id
       expect(Capybara.current_session.object_id).to eq(object_id)
       Capybara.app = proc {}
@@ -178,7 +183,7 @@ RSpec.describe Capybara::DSL do
       expect(Capybara.current_session.app).to eq(Capybara.app)
     end
 
-    it "should change when the session name changes" do
+    it 'should change when the session name changes' do
       object_id = Capybara.current_session.object_id
       Capybara.session_name = :administrator
       expect(Capybara.session_name).to eq(:administrator)
@@ -189,8 +194,8 @@ RSpec.describe Capybara::DSL do
     end
   end
 
-  describe "#using_session" do
-    it "should change the session name for the duration of the block" do
+  describe '#using_session' do
+    it 'should change the session name for the duration of the block' do
       expect(Capybara.session_name).to eq(:default)
       Capybara.using_session(:administrator) do
         expect(Capybara.session_name).to eq(:administrator)
@@ -198,23 +203,23 @@ RSpec.describe Capybara::DSL do
       expect(Capybara.session_name).to eq(:default)
     end
 
-    it "should reset the session to the default, even if an exception occurs" do
+    it 'should reset the session to the default, even if an exception occurs' do
       begin
         Capybara.using_session(:raise) do
           raise
         end
-      rescue Exception # rubocop:disable Lint/RescueException
+      rescue Exception # rubocop:disable Lint/RescueException,Lint/HandleExceptions
       end
       expect(Capybara.session_name).to eq(:default)
     end
 
-    it "should yield the passed block" do
+    it 'should yield the passed block' do
       called = false
       Capybara.using_session(:administrator) { called = true }
       expect(called).to eq(true)
     end
 
-    it "should be nestable" do
+    it 'should be nestable' do
       Capybara.using_session(:outer) do
         expect(Capybara.session_name).to eq(:outer)
         Capybara.using_session(:inner) do
@@ -226,8 +231,8 @@ RSpec.describe Capybara::DSL do
     end
   end
 
-  describe "#session_name" do
-    it "should default to :default" do
+  describe '#session_name' do
+    it 'should default to :default' do
       expect(Capybara.session_name).to eq(:default)
     end
   end
@@ -237,7 +242,7 @@ RSpec.describe Capybara::DSL do
       @session = Class.new { include Capybara::DSL }.new
     end
 
-    it "should be possible to include it in another class" do
+    it 'should be possible to include it in another class' do
       @session.visit('/with_html')
       @session.click_link('ullamco')
       expect(@session.body).to include('Another World')

data/spec/filter_set_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Capybara::Selector::FilterSet do
     Capybara::Selector::FilterSet.remove(:test)
   end
 
-  it "allows node filters" do
+  it 'allows node filters' do
     fs = Capybara::Selector::FilterSet.add(:test) do
       node_filter(:node_test, :boolean) { |_node, _value| true }
       expression_filter(:expression_test, :boolean) { |_expr, _value| true }
@@ -17,7 +17,7 @@ RSpec.describe Capybara::Selector::FilterSet do
     expect(fs.node_filters.keys).not_to include(:expression_test)
   end
 
-  it "allows expression filters" do
+  it 'allows expression filters' do
     fs = Capybara::Selector::FilterSet.add(:test) do
       node_filter(:node_test, :boolean) { |_node, _value| true }
       expression_filter(:expression_test, :boolean) { |_expr, _value| true }
@@ -27,7 +27,7 @@ RSpec.describe Capybara::Selector::FilterSet do
     expect(fs.expression_filters.keys).not_to include(:node_test)
   end
 
-  it "allows node filter and expression filter with the same name" do
+  it 'allows node filter and expression filter with the same name' do
     fs = Capybara::Selector::FilterSet.add(:test) do
       node_filter(:test, :boolean) { |_node, _value| true }
       expression_filter(:test, :boolean) { |_expr, _value| true }
@@ -36,7 +36,7 @@ RSpec.describe Capybara::Selector::FilterSet do
     expect(fs.expression_filters[:test]).not_to eq fs.node_filters[:test]
   end
 
-  it "allows `filter` as an alias of `node_filter`" do
+  it 'allows `filter` as an alias of `node_filter`' do
     fs = Capybara::Selector::FilterSet.add(:test) do
       filter(:node_test, :boolean) { |_node, _value| true }
     end

data/spec/fixtures/selenium_driver_rspec_failure.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 require 'selenium-webdriver'
 
 RSpec.describe Capybara::Selenium::Driver do
-  it "should exit with a non-zero exit status" do
+  it 'should exit with a non-zero exit status' do
     options = { browser: (ENV['SELENIUM_BROWSER'] || :firefox).to_sym }
     browser = Capybara::Selenium::Driver.new(TestApp, options).browser
     expect(browser).to be_truthy

data/spec/fixtures/selenium_driver_rspec_success.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 require 'selenium-webdriver'
 
 RSpec.describe Capybara::Selenium::Driver do
-  it "should exit with a zero exit status" do
+  it 'should exit with a zero exit status' do
     options = { browser: (ENV['SELENIUM_BROWSER'] || :firefox).to_sym }
     browser = Capybara::Selenium::Driver.new(TestApp, options).browser
     expect(browser).to be_truthy

data/spec/minitest_spec.rb

@@ -36,9 +36,9 @@ class MinitestTest < Minitest::Test
 
   def test_assert_xpath
     assert_xpath('.//select[@id="form_title"]')
-    assert_xpath('.//select', count: 1) { |el| el[:id] == "form_title" }
+    assert_xpath('.//select', count: 1) { |el| el[:id] == 'form_title' }
     assert_no_xpath('.//select[@id="not_form_title"]')
-    assert_no_xpath('.//select') { |el| el[:id] == "not_form_title" }
+    assert_no_xpath('.//select') { |el| el[:id] == 'not_form_title' }
     refute_xpath('.//select[@id="not_form_title"]')
   end
 
@@ -126,12 +126,12 @@ RSpec.describe 'capybara/minitest' do
     Capybara.app = TestApp
   end
 
-  it "should support minitest" do
+  it 'should support minitest' do
     output = StringIO.new
     reporter = Minitest::SummaryReporter.new(output)
     reporter.start
     MinitestTest.run reporter, {}
     reporter.report
-    expect(output.string).to include("18 runs, 44 assertions, 0 failures, 0 errors, 1 skips")
+    expect(output.string).to include('18 runs, 44 assertions, 0 failures, 0 errors, 1 skips')
   end
 end

data/spec/minitest_spec_spec.rb

@@ -16,7 +16,7 @@ class MinitestSpecTest < Minitest::Spec
     Capybara.reset_sessions!
   end
 
-  it "supports text expectations" do
+  it 'supports text expectations' do
     page.must_have_text('Form', minimum: 1)
     page.wont_have_text('Not a form')
     form = find(:css, 'form', text: 'Title')
@@ -24,28 +24,28 @@ class MinitestSpecTest < Minitest::Spec
     form.wont_have_text('Some other email')
   end
 
-  it "supports current_path expectations" do
+  it 'supports current_path expectations' do
     page.must_have_current_path('/form')
     page.wont_have_current_path('/form2')
   end
 
-  it "supports title expectations" do
+  it 'supports title expectations' do
     visit('/with_title')
     page.must_have_title('Test Title')
     page.wont_have_title('Not the title')
   end
 
-  it "supports xpath expectations" do
+  it 'supports xpath expectations' do
     page.must_have_xpath('.//input[@id="customer_email"]')
     page.wont_have_xpath('.//select[@id="not_form_title"]')
-    page.wont_have_xpath('.//input[@id="customer_email"]') { |el| el[:id] == "not_customer_email" }
+    page.wont_have_xpath('.//input[@id="customer_email"]') { |el| el[:id] == 'not_customer_email' }
     select = find(:select, 'form_title')
     select.must_have_xpath('.//option[@class="title"]')
     select.must_have_xpath('.//option', count: 1) { |option| option[:class] != 'title' && !option.disabled? }
     select.wont_have_xpath('.//input[@id="customer_email"]')
   end
 
-  it "support css expectations" do
+  it 'support css expectations' do
     page.must_have_css('input#customer_email')
     page.wont_have_css('select#not_form_title')
     el = find(:select, 'form_title')
@@ -53,71 +53,71 @@ class MinitestSpecTest < Minitest::Spec
     el.wont_have_css('input#customer_email')
   end
 
-  it "supports link expectations" do
+  it 'supports link expectations' do
     visit('/with_html')
     page.must_have_link('A link')
     page.wont_have_link('Not on page')
   end
 
-  it "supports button expectations" do
+  it 'supports button expectations' do
     page.must_have_button('fresh_btn')
     page.wont_have_button('not_btn')
   end
 
-  it "supports field expectations" do
+  it 'supports field expectations' do
     page.must_have_field('customer_email')
     page.wont_have_field('not_on_the_form')
   end
 
-  it "supports select expectations" do
+  it 'supports select expectations' do
     page.must_have_select('form_title')
     page.wont_have_select('not_form_title')
   end
 
-  it "supports checked_field expectations" do
+  it 'supports checked_field expectations' do
     page.must_have_checked_field('form_pets_dog')
     page.wont_have_checked_field('form_pets_cat')
   end
 
-  it "supports unchecked_field expectations" do
+  it 'supports unchecked_field expectations' do
     page.must_have_unchecked_field('form_pets_cat')
     page.wont_have_unchecked_field('form_pets_dog')
   end
 
-  it "supports table expectations" do
+  it 'supports table expectations' do
     visit('/tables')
     page.must_have_table('agent_table')
     page.wont_have_table('not_on_form')
   end
 
-  it "supports all_of_selectors expectations" do
+  it 'supports all_of_selectors expectations' do
     page.must_have_all_of_selectors(:css, 'select#form_other_title', 'input#form_last_name')
   end
 
-  it "supports none_of_selectors expectations" do
+  it 'supports none_of_selectors expectations' do
     page.must_have_none_of_selectors(:css, 'input#not_on_page', 'input#also_not_on_page')
   end
 
-  it "supports match_selector expectations" do
+  it 'supports match_selector expectations' do
     find(:field, 'customer_email').must_match_selector(:field, 'customer_email')
     find(:select, 'form_title').wont_match_selector(:field, 'customer_email')
   end
 
-  it "supports match_css expectations" do
+  it 'supports match_css expectations' do
     find(:select, 'form_title').must_match_css('select#form_title')
     find(:select, 'form_title').wont_match_css('select#form_other_title')
   end
 
-  it "supports match_xpath expectations" do
+  it 'supports match_xpath expectations' do
     find(:select, 'form_title').must_match_xpath('.//select[@id="form_title"]')
     find(:select, 'form_title').wont_match_xpath('.//select[@id="not_on_page"]')
   end
 
-  it "handles failures" do
+  it 'handles failures' do
     page.must_have_select('non_existing_form_title')
   end
 
-  it "supports style expectations" do
+  it 'supports style expectations' do
     skip "Rack test doesn't support style" if Capybara.current_driver == :rack_test
     visit('/with_html')
     find(:css, '#second').must_have_style('display' => 'inline')
@@ -130,14 +130,14 @@ RSpec.describe 'capybara/minitest/spec' do
     Capybara.app = TestApp
   end
 
-  it "should support minitest spec" do
+  it 'should support minitest spec' do
     output = StringIO.new
     reporter = Minitest::SummaryReporter.new(output)
     reporter.start
     MinitestSpecTest.run reporter, {}
     reporter.report
-    expect(output.string).to include("19 runs, 41 assertions, 1 failures, 0 errors, 1 skips")
+    expect(output.string).to include('19 runs, 41 assertions, 1 failures, 0 errors, 1 skips')
     # Make sure error messages are displayed
-    expect(output.string).to include('expected to find visible select box "non_existing_form_title" that is not disabled but there were no matches')
+    expect(output.string).to include('expected to find select box "non_existing_form_title" but there were no matches')
   end
 end

data/spec/per_session_config_spec.rb

@@ -4,8 +4,8 @@ require 'spec_helper'
 require 'capybara/dsl'
 
 RSpec.describe Capybara::SessionConfig do
-  describe "threadsafe" do
-    it "defaults to global session options" do
+  describe 'threadsafe' do
+    it 'defaults to global session options' do
       Capybara.threadsafe = true
       session = Capybara::Session.new(:rack_test, TestApp)
       %i[default_host app_host always_include_port run_server
@@ -19,7 +19,7 @@ RSpec.describe Capybara::SessionConfig do
 
     it "doesn't change global session when changed" do
       Capybara.threadsafe = true
-      host = "http://my.example.com"
+      host = 'http://my.example.com'
       session = Capybara::Session.new(:rack_test, TestApp) do |config|
         config.default_host = host
         config.automatic_label_click = !config.automatic_label_click
@@ -35,7 +35,7 @@ RSpec.describe Capybara::SessionConfig do
       Capybara.threadsafe = false
       expect do
         Capybara::Session.new(:rack_test, TestApp) { |config| }
-      end.to raise_error "A configuration block is only accepted when Capybara.threadsafe == true"
+      end.to raise_error 'A configuration block is only accepted when Capybara.threadsafe == true'
     end
 
     it "doesn't allow session config when false" do
@@ -49,7 +49,7 @@ RSpec.describe Capybara::SessionConfig do
       end.to raise_error(/Session configuration is only supported when Capybara.threadsafe == true/)
     end
 
-    it "uses the config from the session" do
+    it 'uses the config from the session' do
       Capybara.threadsafe = true
       session = Capybara::Session.new(:rack_test, TestApp) do |config|
         config.default_selector = :link