capybara 3.3.1 → 3.4.0

data/lib/capybara/spec/session/has_style_spec.rb

@@ -5,19 +5,19 @@ Capybara::SpecHelper.spec '#has_style?', requires: [:css] do
     @session.visit('/with_html')
   end
 
-  it "should be true if the element has the given style" do
+  it 'should be true if the element has the given style' do
     expect(@session.find(:css, '#first')).to have_style(display: 'block')
     expect(@session.find(:css, '#first').has_style?(display: 'block')).to be true
     expect(@session.find(:css, '#second')).to have_style('display' => 'inline')
     expect(@session.find(:css, '#second').has_style?('display' => 'inline')).to be true
   end
 
-  it "should be false if the element does not have the given style" do
+  it 'should be false if the element does not have the given style' do
     expect(@session.find(:css, '#first').has_style?('display' => 'inline')).to be false
     expect(@session.find(:css, '#second').has_style?(display: 'block')).to be false
   end
 
-  it "allows Regexp for value matching" do
+  it 'allows Regexp for value matching' do
     expect(@session.find(:css, '#first')).to have_style(display: /^bl/)
     expect(@session.find(:css, '#first').has_style?('display' => /^bl/)).to be true
     expect(@session.find(:css, '#first').has_style?(display: /^in/)).to be false

data/lib/capybara/spec/session/has_table_spec.rb

@@ -5,13 +5,13 @@ Capybara::SpecHelper.spec '#has_table?' do
     @session.visit('/tables')
   end
 
-  it "should be true if the table is on the page" do
+  it 'should be true if the table is on the page' do
     expect(@session).to have_table('Villain')
     expect(@session).to have_table('villain_table')
     expect(@session).to have_table(:villain_table)
   end
 
-  it "should be false if the table is not on the page" do
+  it 'should be false if the table is not on the page' do
     expect(@session).not_to have_table('Monkey')
   end
 end
@@ -21,12 +21,12 @@ Capybara::SpecHelper.spec '#has_no_table?' do
     @session.visit('/tables')
   end
 
-  it "should be false if the table is on the page" do
+  it 'should be false if the table is on the page' do
     expect(@session).not_to have_no_table('Villain')
     expect(@session).not_to have_no_table('villain_table')
   end
 
-  it "should be true if the table is not on the page" do
+  it 'should be true if the table is not on the page' do
     expect(@session).to have_no_table('Monkey')
   end
 end

data/lib/capybara/spec/session/has_text_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Capybara::SpecHelper.spec '#has_text?' do
-  it "should be true if the given text is on the page at least once" do
+  it 'should be true if the given text is on the page at least once' do
     @session.visit('/with_html')
     expect(@session).to have_text('est')
     expect(@session).to have_text('Lorem')
@@ -9,32 +9,32 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).to have_text(:Redirect)
   end
 
-  it "should be true if scoped to an element which has the text" do
+  it 'should be true if scoped to an element which has the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).to have_text('labore')
     end
   end
 
-  it "should be false if scoped to an element which does not have the text" do
+  it 'should be false if scoped to an element which does not have the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).not_to have_text('monkey')
     end
   end
 
-  it "should ignore tags" do
+  it 'should ignore tags' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('exercitation <a href="/foo" id="foo">ullamco</a> laboris')
     expect(@session).to have_text('exercitation ullamco laboris')
   end
 
-  it "should search correctly normalized text" do
+  it 'should search correctly normalized text' do
     @session.visit('/with_html')
     expect(@session).to have_text('text with   whitespace')
   end
 
-  it "should be false if the given text is not on the page" do
+  it 'should be false if the given text is not on the page' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('xxxxyzzz')
     expect(@session).not_to have_text('monkey')
@@ -66,23 +66,23 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).not_to have_text('aVar')
   end
 
-  it "should be false if the given text is on the page but not visible" do
+  it 'should be false if the given text is on the page but not visible' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('Inside element with hidden ancestor')
   end
 
-  it "should be true if :all given and text is invisible." do
+  it 'should be true if :all given and text is invisible.' do
     @session.visit('/with_html')
     expect(@session).to have_text(:all, 'Some of this text is hidden!')
   end
 
-  it "should be true if `Capybara.ignore_hidden_elements = false` and text is invisible." do
+  it 'should be true if `Capybara.ignore_hidden_elements = false` and text is invisible.' do
     Capybara.ignore_hidden_elements = false
     @session.visit('/with_html')
     expect(@session).to have_text('Some of this text is hidden!')
   end
 
-  it "should be true if the text in the page matches given regexp" do
+  it 'should be true if the text in the page matches given regexp' do
     @session.visit('/with_html')
     expect(@session).to have_text(/Lorem/)
   end
@@ -92,50 +92,50 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).not_to have_text(/xxxxyzzz/)
   end
 
-  context "with exact: true option" do
-    it "should be true if text matches exactly" do
+  context 'with exact: true option' do
+    it 'should be true if text matches exactly' do
       @session.visit('/with_html')
-      expect(@session.find(:id, "h2one")).to have_text("Header Class Test One", exact: true)
+      expect(@session.find(:id, 'h2one')).to have_text('Header Class Test One', exact: true)
     end
 
     it "should be false if text doesn't match exactly" do
       @session.visit('/with_html')
-      expect(@session.find(:id, "h2one")).not_to have_text("Header Class Test On", exact: true)
+      expect(@session.find(:id, 'h2one')).not_to have_text('Header Class Test On', exact: true)
     end
   end
 
-  it "should escape any characters that would have special meaning in a regexp" do
+  it 'should escape any characters that would have special meaning in a regexp' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('.orem')
   end
 
-  it "should accept non-string parameters" do
+  it 'should accept non-string parameters' do
     @session.visit('/with_html')
     expect(@session).to have_text(42)
   end
 
-  it "should be true when passed nil" do
+  it 'should be true when passed nil' do
     # nil is converted to '' when to_s is invoked
     @session.visit('/with_html')
     expect(@session).to have_text(nil)
   end
 
-  it "should wait for text to appear", requires: [:js] do
+  it 'should wait for text to appear', requires: [:js] do
     Capybara.using_wait_time(3) do
       @session.visit('/with_js')
       @session.click_link('Click me')
-      expect(@session).to have_text("Has been clicked")
+      expect(@session).to have_text('Has been clicked')
     end
   end
 
-  context "with between" do
-    it "should be true if the text occurs within the range given" do
+  context 'with between' do
+    it 'should be true if the text occurs within the range given' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', between: 1..3)
       expect(@session).to have_text(/count/, between: 2..2)
     end
 
-    it "should be false if the text occurs more or fewer times than range" do
+    it 'should be false if the text occurs more or fewer times than range' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', between: 0..1)
       expect(@session).not_to have_text('count', between: 3..10)
@@ -143,76 +143,76 @@ Capybara::SpecHelper.spec '#has_text?' do
     end
   end
 
-  context "with count" do
-    it "should be true if the text occurs the given number of times" do
+  context 'with count' do
+    it 'should be true if the text occurs the given number of times' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', count: 2)
     end
 
-    it "should be false if the text occurs a different number of times than the given" do
+    it 'should be false if the text occurs a different number of times than the given' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', count: 0)
       expect(@session).not_to have_text('count', count: 1)
       expect(@session).not_to have_text(/count/, count: 3)
     end
 
-    it "should coerce count to an integer" do
+    it 'should coerce count to an integer' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', count: '2')
       expect(@session).not_to have_text('count', count: '3')
     end
   end
 
-  context "with maximum" do
-    it "should be true when text occurs same or fewer times than given" do
+  context 'with maximum' do
+    it 'should be true when text occurs same or fewer times than given' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', maximum: 2)
       expect(@session).to have_text(/count/, maximum: 3)
     end
 
-    it "should be false when text occurs more times than given" do
+    it 'should be false when text occurs more times than given' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', maximum: 1)
       expect(@session).not_to have_text('count', maximum: 0)
     end
 
-    it "should coerce maximum to an integer" do
+    it 'should coerce maximum to an integer' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', maximum: '2')
       expect(@session).not_to have_text('count', maximum: '1')
     end
   end
 
-  context "with minimum" do
-    it "should be true when text occurs same or more times than given" do
+  context 'with minimum' do
+    it 'should be true when text occurs same or more times than given' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', minimum: 2)
       expect(@session).to have_text(/count/, minimum: 0)
     end
 
-    it "should be false when text occurs fewer times than given" do
+    it 'should be false when text occurs fewer times than given' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', minimum: 3)
     end
 
-    it "should coerce minimum to an integer" do
+    it 'should coerce minimum to an integer' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', minimum: '2')
       expect(@session).not_to have_text('count', minimum: '3')
     end
   end
 
-  context "with wait", requires: [:js] do
-    it "should find element if it appears before given wait duration" do
+  context 'with wait', requires: [:js] do
+    it 'should find element if it appears before given wait duration' do
       Capybara.using_wait_time(0.1) do
         @session.visit('/with_js')
         @session.click_link('Click me')
-        expect(@session).to have_text('Has been clicked', wait: 0.9)
+        expect(@session).to have_text('Has been clicked', wait: 2)
       end
     end
   end
 
-  it "should raise an error if an invalid option is passed" do
+  it 'should raise an error if an invalid option is passed' do
     @session.visit('/with_html')
     expect do
       expect(@session).to have_text('Lorem', invalid: true)
@@ -221,34 +221,34 @@ Capybara::SpecHelper.spec '#has_text?' do
 end
 
 Capybara::SpecHelper.spec '#has_no_text?' do
-  it "should be false if the given text is on the page at least once" do
+  it 'should be false if the given text is on the page at least once' do
     @session.visit('/with_html')
     expect(@session).not_to have_no_text('est')
     expect(@session).not_to have_no_text('Lorem')
     expect(@session).not_to have_no_text('Redirect')
   end
 
-  it "should be false if scoped to an element which has the text" do
+  it 'should be false if scoped to an element which has the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).not_to have_no_text('labore')
     end
   end
 
-  it "should be true if scoped to an element which does not have the text" do
+  it 'should be true if scoped to an element which does not have the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).to have_no_text('monkey')
     end
   end
 
-  it "should ignore tags" do
+  it 'should ignore tags' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('exercitation <a href="/foo" id="foo">ullamco</a> laboris')
     expect(@session).not_to have_no_text('exercitation ullamco laboris')
   end
 
-  it "should be true if the given text is not on the page" do
+  it 'should be true if the given text is not on the page' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('xxxxyzzz')
     expect(@session).to have_no_text('monkey')
@@ -280,17 +280,17 @@ Capybara::SpecHelper.spec '#has_no_text?' do
     expect(@session).to have_no_text('aVar')
   end
 
-  it "should be true if the given text is on the page but not visible" do
+  it 'should be true if the given text is on the page but not visible' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('Inside element with hidden ancestor')
   end
 
-  it "should be false if :all given and text is invisible." do
+  it 'should be false if :all given and text is invisible.' do
     @session.visit('/with_html')
     expect(@session).not_to have_no_text(:all, 'Some of this text is hidden!')
   end
 
-  it "should be false if `Capybara.ignore_hidden_elements = false` and text is invisible." do
+  it 'should be false if `Capybara.ignore_hidden_elements = false` and text is invisible.' do
     Capybara.ignore_hidden_elements = false
     @session.visit('/with_html')
     expect(@session).not_to have_no_text('Some of this text is hidden!')
@@ -301,24 +301,25 @@ Capybara::SpecHelper.spec '#has_no_text?' do
     expect(@session).to have_no_text(/xxxxyzzz/)
   end
 
-  it "should be false if the text in the page  matches given regexp" do
+  it 'should be false if the text in the page  matches given regexp' do
     @session.visit('/with_html')
     expect(@session).not_to have_no_text(/Lorem/)
   end
 
-  it "should escape any characters that would have special meaning in a regexp" do
+  it 'should escape any characters that would have special meaning in a regexp' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('.orem')
   end
 
-  it "should wait for text to disappear", requires: [:js] do
+  it 'should wait for text to disappear', requires: [:js] do
+    Capybara.default_max_wait_time = 2
     @session.visit('/with_js')
     @session.click_link('Click me')
-    expect(@session).to have_no_text("I changed it")
+    expect(@session).to have_no_text('I changed it')
   end
 
-  context "with wait", requires: [:js] do
-    it "should not find element if it appears after given wait duration" do
+  context 'with wait', requires: [:js] do
+    it 'should not find element if it appears after given wait duration' do
       @session.visit('/with_js')
       @session.click_link('Click me')
       expect(@session).to have_no_text('Has been clicked', wait: 0.05)

data/lib/capybara/spec/session/has_title_spec.rb

@@ -5,35 +5,35 @@ Capybara::SpecHelper.spec '#has_title?' do
     @session.visit('/with_js')
   end
 
-  it "should be true if the page has the given title" do
+  it 'should be true if the page has the given title' do
     expect(@session).to have_title('with_js')
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).to have_title(/w[a-z]{3}_js/)
     expect(@session).not_to have_title(/monkey/)
   end
 
-  it "should wait for title", requires: [:js] do
-    @session.click_link("Change title")
-    expect(@session).to have_title("changed title")
+  it 'should wait for title', requires: [:js] do
+    @session.click_link('Change title')
+    expect(@session).to have_title('changed title')
   end
 
-  it "should be false if the page has not the given title" do
+  it 'should be false if the page has not the given title' do
     expect(@session).not_to have_title('monkey')
   end
 
-  it "should default to exact: false matching" do
+  it 'should default to exact: false matching' do
     expect(@session).to have_title('with_js', exact: false)
     expect(@session).to have_title('with_', exact: false)
   end
 
-  it "should match exactly if exact: true option passed" do
+  it 'should match exactly if exact: true option passed' do
     expect(@session).to have_title('with_js', exact: true)
     expect(@session).not_to have_title('with_', exact: true)
   end
 
-  it "should match partial if exact: false option passed" do
+  it 'should match partial if exact: false option passed' do
     expect(@session).to have_title('with_js', exact: false)
     expect(@session).to have_title('with_', exact: false)
   end
@@ -44,23 +44,23 @@ Capybara::SpecHelper.spec '#has_no_title?' do
     @session.visit('/with_js')
   end
 
-  it "should be false if the page has the given title" do
+  it 'should be false if the page has the given title' do
     expect(@session).not_to have_no_title('with_js')
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).not_to have_no_title(/w[a-z]{3}_js/)
     expect(@session).to have_no_title(/monkey/)
   end
 
-  it "should wait for title to disappear", requires: [:js] do
+  it 'should wait for title to disappear', requires: [:js] do
     Capybara.using_wait_time(5) do
-      @session.click_link("Change title") # triggers title change after 400ms
+      @session.click_link('Change title') # triggers title change after 400ms
       expect(@session).to have_no_title('with_js')
     end
   end
 
-  it "should be true if the page has not the given title" do
+  it 'should be true if the page has not the given title' do
     expect(@session).to have_no_title('monkey')
   end
 end

data/lib/capybara/spec/session/has_xpath_spec.rb

@@ -5,31 +5,31 @@ Capybara::SpecHelper.spec '#has_xpath?' do
     @session.visit('/with_html')
   end
 
-  it "should be true if the given selector is on the page" do
-    expect(@session).to have_xpath("//p")
+  it 'should be true if the given selector is on the page' do
+    expect(@session).to have_xpath('//p')
     expect(@session).to have_xpath("//p//a[@id='foo']")
     expect(@session).to have_xpath("//p[contains(.,'est')]")
   end
 
-  it "should be false if the given selector is not on the page" do
-    expect(@session).not_to have_xpath("//abbr")
+  it 'should be false if the given selector is not on the page' do
+    expect(@session).not_to have_xpath('//abbr')
     expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']")
     expect(@session).not_to have_xpath("//p[contains(.,'thisstringisnotonpage')]")
   end
 
-  it "should use xpath even if default selector is CSS" do
+  it 'should use xpath even if default selector is CSS' do
     Capybara.default_selector = :css
     expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']")
   end
 
-  it "should respect scopes" do
+  it 'should respect scopes' do
     @session.within "//p[@id='first']" do
       expect(@session).to have_xpath(".//a[@id='foo']")
       expect(@session).not_to have_xpath(".//a[@id='red']")
     end
   end
 
-  it "should wait for content to appear", requires: [:js] do
+  it 'should wait for content to appear', requires: [:js] do
     Capybara.using_wait_time(3) do
       @session.visit('/with_js')
       @session.click_link('Click me') # updates page after 500ms
@@ -37,31 +37,31 @@ Capybara::SpecHelper.spec '#has_xpath?' do
     end
   end
 
-  context "with count" do
-    it "should be true if the content occurs the given number of times" do
-      expect(@session).to have_xpath("//p", count: 3)
+  context 'with count' do
+    it 'should be true if the content occurs the given number of times' do
+      expect(@session).to have_xpath('//p', count: 3)
       expect(@session).to have_xpath("//p//a[@id='foo']", count: 1)
       expect(@session).to have_xpath("//p[contains(.,'est')]", count: 1)
       expect(@session).to have_xpath("//p//a[@id='doesnotexist']", count: 0)
     end
 
-    it "should be false if the content occurs a different number of times than the given" do
-      expect(@session).not_to have_xpath("//p", count: 6)
+    it 'should be false if the content occurs a different number of times than the given' do
+      expect(@session).not_to have_xpath('//p', count: 6)
       expect(@session).not_to have_xpath("//p//a[@id='foo']", count: 2)
       expect(@session).not_to have_xpath("//p[contains(.,'est')]", count: 5)
       expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']", count: 1)
     end
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is not contained" do
-      expect(@session).to have_xpath("//p//a", text: "Redirect", count: 1)
-      expect(@session).not_to have_xpath("//p", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is not contained' do
+      expect(@session).to have_xpath('//p//a', text: 'Redirect', count: 1)
+      expect(@session).not_to have_xpath('//p', text: 'Doesnotexist')
     end
 
-    it "should discard all matches where the given regexp is not matched" do
-      expect(@session).to have_xpath("//p//a", text: /re[dab]i/i, count: 1)
-      expect(@session).not_to have_xpath("//p//a", text: /Red$/)
+    it 'should discard all matches where the given regexp is not matched' do
+      expect(@session).to have_xpath('//p//a', text: /re[dab]i/i, count: 1)
+      expect(@session).not_to have_xpath('//p//a', text: /Red$/)
     end
   end
 end
@@ -71,61 +71,62 @@ Capybara::SpecHelper.spec '#has_no_xpath?' do
     @session.visit('/with_html')
   end
 
-  it "should be false if the given selector is on the page" do
-    expect(@session).not_to have_no_xpath("//p")
+  it 'should be false if the given selector is on the page' do
+    expect(@session).not_to have_no_xpath('//p')
     expect(@session).not_to have_no_xpath("//p//a[@id='foo']")
     expect(@session).not_to have_no_xpath("//p[contains(.,'est')]")
   end
 
-  it "should be true if the given selector is not on the page" do
-    expect(@session).to have_no_xpath("//abbr")
+  it 'should be true if the given selector is not on the page' do
+    expect(@session).to have_no_xpath('//abbr')
     expect(@session).to have_no_xpath("//p//a[@id='doesnotexist']")
     expect(@session).to have_no_xpath("//p[contains(.,'thisstringisnotonpage')]")
   end
 
-  it "should use xpath even if default selector is CSS" do
+  it 'should use xpath even if default selector is CSS' do
     Capybara.default_selector = :css
     expect(@session).to have_no_xpath("//p//a[@id='doesnotexist']")
   end
 
-  it "should respect scopes" do
+  it 'should respect scopes' do
     @session.within "//p[@id='first']" do
       expect(@session).not_to have_no_xpath(".//a[@id='foo']")
       expect(@session).to have_no_xpath(".//a[@id='red']")
     end
   end
 
-  it "should wait for content to disappear", requires: [:js] do
+  it 'should wait for content to disappear', requires: [:js] do
+    Capybara.default_max_wait_time = 2
     @session.visit('/with_js')
     @session.click_link('Click me')
     expect(@session).to have_no_xpath("//p[@id='change']")
   end
 
-  context "with count" do
-    it "should be false if the content occurs the given number of times" do
-      expect(@session).not_to have_no_xpath("//p", count: 3)
+  context 'with count' do
+    it 'should be false if the content occurs the given number of times' do
+      expect(@session).not_to have_no_xpath('//p', count: 3)
       expect(@session).not_to have_no_xpath("//p//a[@id='foo']", count: 1)
       expect(@session).not_to have_no_xpath("//p[contains(.,'est')]", count: 1)
       expect(@session).not_to have_no_xpath("//p//a[@id='doesnotexist']", count: 0)
     end
 
-    it "should be true if the content occurs a different number of times than the given" do
-      expect(@session).to have_no_xpath("//p", count: 6)
+    it 'should be true if the content occurs a different number of times than the given' do
+      expect(@session).to have_no_xpath('//p', count: 6)
       expect(@session).to have_no_xpath("//p//a[@id='foo']", count: 2)
       expect(@session).to have_no_xpath("//p[contains(.,'est')]", count: 5)
       expect(@session).to have_no_xpath("//p//a[@id='doesnotexist']", count: 1)
     end
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is contained" do
-      expect(@session).not_to have_no_xpath("//p//a", text: "Redirect", count: 1)
-      expect(@session).to have_no_xpath("//p", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is contained' do
+      expect(@session).not_to have_no_xpath('//p//a', text: 'Redirect', count: 1)
+      expect(@session).to have_no_xpath('//p', text: 'Doesnotexist')
     end
 
-    it "should discard all matches where the given regexp is matched" do
-      expect(@session).not_to have_no_xpath("//p//a", text: /re[dab]i/i, count: 1)
-      expect(@session).to have_no_xpath("//p//a", text: /Red$/)
+    it 'should discard all matches where the given regexp is matched' do
+      expect(@session).not_to have_no_xpath('//p//a', text: /re[dab]i/i, count: 1)
+      expect(@session).to have_no_xpath('//p//a', text: /Red$/)
     end
   end
 end