capybara 3.3.1 → 3.4.0

data/lib/capybara/spec/session/first_spec.rb

@@ -5,128 +5,128 @@ Capybara::SpecHelper.spec '#first' do
     @session.visit('/with_html')
   end
 
-  it "should find the first element using the given locator" do
+  it 'should find the first element using the given locator' do
     expect(@session.first('//h1').text).to eq('This is a test')
     expect(@session.first("//input[@id='test_field']").value).to eq('monkey')
   end
 
-  it "should raise ElementNotFound when nothing was found" do
+  it 'should raise ElementNotFound when nothing was found' do
     expect do
       @session.first('//div[@id="nosuchthing"]')
     end.to raise_error Capybara::ElementNotFound
   end
 
-  it "should return nil when nothing was found if count options allow no results" do
+  it 'should return nil when nothing was found if count options allow no results' do
     expect(@session.first('//div[@id="nosuchthing"]', minimum: 0)).to be_nil
     expect(@session.first('//div[@id="nosuchthing"]', count: 0)).to be_nil
     expect(@session.first('//div[@id="nosuchthing"]', between: (0..3))).to be_nil
   end
 
-  it "should accept an XPath instance" do
+  it 'should accept an XPath instance' do
     @session.visit('/form')
     @xpath = Capybara::Selector.all[:fillable_field].call('First Name')
     expect(@xpath).to be_a(::XPath::Union)
     expect(@session.first(@xpath).value).to eq('John')
   end
 
-  it "should raise when unused parameters are passed" do
+  it 'should raise when unused parameters are passed' do
     expect do
       @session.first(:css, 'h1', 'unused text')
     end.to raise_error ArgumentError, /Unused parameters passed.*unused text/
   end
 
-  context "with css selectors" do
-    it "should find the first element using the given selector" do
+  context 'with css selectors' do
+    it 'should find the first element using the given selector' do
       expect(@session.first(:css, 'h1').text).to eq('This is a test')
       expect(@session.first(:css, "input[id='test_field']").value).to eq('monkey')
     end
   end
 
-  context "with xpath selectors" do
-    it "should find the first element using the given locator" do
+  context 'with xpath selectors' do
+    it 'should find the first element using the given locator' do
       expect(@session.first(:xpath, '//h1').text).to eq('This is a test')
       expect(@session.first(:xpath, "//input[@id='test_field']").value).to eq('monkey')
     end
   end
 
-  context "with css as default selector" do
+  context 'with css as default selector' do
     before { Capybara.default_selector = :css }
 
-    it "should find the first element using the given locator" do
+    it 'should find the first element using the given locator' do
       expect(@session.first('h1').text).to eq('This is a test')
       expect(@session.first("input[id='test_field']").value).to eq('monkey')
     end
   end
 
-  context "with visible filter" do
-    it "should only find visible nodes when true" do
+  context 'with visible filter' do
+    it 'should only find visible nodes when true' do
       expect do
-        @session.first(:css, "a#invisible", visible: true)
+        @session.first(:css, 'a#invisible', visible: true)
       end.to raise_error Capybara::ElementNotFound
     end
 
-    it "should find nodes regardless of whether they are invisible when false" do
-      expect(@session.first(:css, "a#invisible", visible: false)).to be_truthy
-      expect(@session.first(:css, "a#invisible", visible: false, text: 'hidden link')).to be_truthy
-      expect(@session.first(:css, "a#visible", visible: false)).to be_truthy
+    it 'should find nodes regardless of whether they are invisible when false' do
+      expect(@session.first(:css, 'a#invisible', visible: false)).to be_truthy
+      expect(@session.first(:css, 'a#invisible', visible: false, text: 'hidden link')).to be_truthy
+      expect(@session.first(:css, 'a#visible', visible: false)).to be_truthy
     end
 
-    it "should find nodes regardless of whether they are invisible when :all" do
-      expect(@session.first(:css, "a#invisible", visible: :all)).to be_truthy
-      expect(@session.first(:css, "a#invisible", visible: :all, text: 'hidden link')).to be_truthy
-      expect(@session.first(:css, "a#visible", visible: :all)).to be_truthy
+    it 'should find nodes regardless of whether they are invisible when :all' do
+      expect(@session.first(:css, 'a#invisible', visible: :all)).to be_truthy
+      expect(@session.first(:css, 'a#invisible', visible: :all, text: 'hidden link')).to be_truthy
+      expect(@session.first(:css, 'a#visible', visible: :all)).to be_truthy
     end
 
-    it "should find only hidden nodes when :hidden" do
-      expect(@session.first(:css, "a#invisible", visible: :hidden)).to be_truthy
-      expect(@session.first(:css, "a#invisible", visible: :hidden, text: 'hidden link')).to be_truthy
+    it 'should find only hidden nodes when :hidden' do
+      expect(@session.first(:css, 'a#invisible', visible: :hidden)).to be_truthy
+      expect(@session.first(:css, 'a#invisible', visible: :hidden, text: 'hidden link')).to be_truthy
       expect do
-        @session.first(:css, "a#invisible", visible: :hidden, text: 'not hidden link')
+        @session.first(:css, 'a#invisible', visible: :hidden, text: 'not hidden link')
       end.to raise_error Capybara::ElementNotFound
       expect do
-        @session.first(:css, "a#visible", visible: :hidden)
+        @session.first(:css, 'a#visible', visible: :hidden)
       end.to raise_error Capybara::ElementNotFound
     end
 
-    it "should find only visible nodes when :visible" do
+    it 'should find only visible nodes when :visible' do
       expect do
-        @session.first(:css, "a#invisible", visible: :visible)
+        @session.first(:css, 'a#invisible', visible: :visible)
       end.to raise_error Capybara::ElementNotFound
       expect do
-        @session.first(:css, "a#invisible", visible: :visible, text: 'hidden link')
+        @session.first(:css, 'a#invisible', visible: :visible, text: 'hidden link')
       end.to raise_error Capybara::ElementNotFound
-      expect(@session.first(:css, "a#visible", visible: :visible)).to be_truthy
+      expect(@session.first(:css, 'a#visible', visible: :visible)).to be_truthy
     end
 
-    it "should default to Capybara.ignore_hidden_elements" do
+    it 'should default to Capybara.ignore_hidden_elements' do
       Capybara.ignore_hidden_elements = true
       expect do
-        @session.first(:css, "a#invisible")
+        @session.first(:css, 'a#invisible')
       end.to raise_error Capybara::ElementNotFound
       Capybara.ignore_hidden_elements = false
-      expect(@session.first(:css, "a#invisible")).to be_truthy
-      expect(@session.first(:css, "a")).to be_truthy
+      expect(@session.first(:css, 'a#invisible')).to be_truthy
+      expect(@session.first(:css, 'a')).to be_truthy
     end
   end
 
-  context "within a scope" do
+  context 'within a scope' do
     before do
       @session.visit('/with_scope')
     end
 
-    it "should find the first element using the given locator" do
+    it 'should find the first element using the given locator' do
       @session.within(:xpath, "//div[@id='for_bar']") do
         expect(@session.first('.//form')).to be_truthy
       end
     end
   end
 
-  context "waiting behavior", requires: [:js] do
+  context 'waiting behavior', requires: [:js] do
     before do
       @session.visit('/with_js')
     end
 
-    it "should not wait if minimum: 0" do
+    it 'should not wait if minimum: 0' do
       @session.click_link('clickable')
       Capybara.using_wait_time(3) do
         start_time = Time.now
@@ -135,14 +135,14 @@ Capybara::SpecHelper.spec '#first' do
       end
     end
 
-    it "should wait for at least one match by default" do
+    it 'should wait for at least one match by default' do
       Capybara.using_wait_time(3) do
         @session.click_link('clickable')
         expect(@session.first(:css, 'a#has-been-clicked')).not_to be_nil
       end
     end
 
-    it "should raise an error after waiting if no match" do
+    it 'should raise an error after waiting if no match' do
       @session.click_link('clickable')
       Capybara.using_wait_time(3) do
         start_time = Time.now

data/lib/capybara/spec/session/frame/frame_title_spec.rb

@@ -5,19 +5,19 @@ Capybara::SpecHelper.spec '#frame_title', requires: [:frames] do
     @session.visit('/within_frames')
   end
 
-  it "should return the title in a frame" do
-    @session.within_frame("frameOne") do
+  it 'should return the title in a frame' do
+    @session.within_frame('frameOne') do
       expect(@session.driver.frame_title).to eq 'This is the title of frame one'
     end
   end
 
-  it "should return the title in FrameTwo" do
-    @session.within_frame("frameTwo") do
+  it 'should return the title in FrameTwo' do
+    @session.within_frame('frameTwo') do
       expect(@session.driver.frame_title).to eq 'This is the title of frame two'
     end
   end
 
-  it "should return the title in the main frame" do
+  it 'should return the title in the main frame' do
     expect(@session.driver.frame_title).to eq 'With Frames'
   end
 end

data/lib/capybara/spec/session/frame/frame_url_spec.rb

@@ -5,19 +5,19 @@ Capybara::SpecHelper.spec '#frame_url', requires: [:frames] do
     @session.visit('/within_frames')
   end
 
-  it "should return the url in a frame" do
-    @session.within_frame("frameOne") do
+  it 'should return the url in a frame' do
+    @session.within_frame('frameOne') do
       expect(@session.driver.frame_url).to end_with '/frame_one'
     end
   end
 
-  it "should return the url in FrameTwo" do
-    @session.within_frame("frameTwo") do
+  it 'should return the url in FrameTwo' do
+    @session.within_frame('frameTwo') do
       expect(@session.driver.frame_url).to end_with '/frame_two'
     end
   end
 
-  it "should return the url in the main frame" do
+  it 'should return the url in the main frame' do
     expect(@session.driver.frame_url).to end_with('/within_frames')
   end
 end

data/lib/capybara/spec/session/frame/switch_to_frame_spec.rb

@@ -10,45 +10,45 @@ Capybara::SpecHelper.spec '#switch_to_frame', requires: [:frames] do
     @session.switch_to_frame(:top)
   end
 
-  it "should find the div in frameOne" do
-    frame = @session.find(:frame, "frameOne")
+  it 'should find the div in frameOne' do
+    frame = @session.find(:frame, 'frameOne')
     @session.switch_to_frame(frame)
     expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
   end
 
-  it "should find the div in FrameTwo" do
-    frame = @session.find(:frame, "frameTwo")
+  it 'should find the div in FrameTwo' do
+    frame = @session.find(:frame, 'frameTwo')
     @session.switch_to_frame(frame)
     expect(@session.find("//*[@id='divInFrameTwo']").text).to eql 'This is the text of divInFrameTwo'
   end
 
-  it "should return to the parent frame when told to" do
-    frame = @session.find(:frame, "frameOne")
+  it 'should return to the parent frame when told to' do
+    frame = @session.find(:frame, 'frameOne')
     @session.switch_to_frame(frame)
     @session.switch_to_frame(:parent)
     expect(@session.find("//*[@id='divInMainWindow']").text).to eql 'This is the text for divInMainWindow'
   end
 
-  it "should be able to switch to nested frames" do
-    frame = @session.find(:frame, "parentFrame")
+  it 'should be able to switch to nested frames' do
+    frame = @session.find(:frame, 'parentFrame')
     @session.switch_to_frame frame
-    frame = @session.find(:frame, "childFrame")
+    frame = @session.find(:frame, 'childFrame')
     @session.switch_to_frame frame
-    frame = @session.find(:frame, "grandchildFrame1")
+    frame = @session.find(:frame, 'grandchildFrame1')
     @session.switch_to_frame frame
     expect(@session).to have_selector(:css, '#divInFrameOne', text: 'This is the text of divInFrameOne')
   end
 
-  it "should reset scope when changing frames" do
+  it 'should reset scope when changing frames' do
     frame = @session.find(:frame, 'parentFrame')
     @session.within(:css, '#divInMainWindow') do
       @session.switch_to_frame(frame)
-      expect(@session.has_selector?(:css, "iframe#childFrame")).to be true
+      expect(@session.has_selector?(:css, 'iframe#childFrame')).to be true
       @session.switch_to_frame(:parent)
     end
   end
 
-  it "works if the frame is closed", requires: %i[frames js] do
+  it 'works if the frame is closed', requires: %i[frames js] do
     frame = @session.find(:frame, 'parentFrame')
     @session.switch_to_frame frame
     frame = @session.find(:frame, 'childFrame')
@@ -61,10 +61,10 @@ Capybara::SpecHelper.spec '#switch_to_frame', requires: [:frames] do
     @session.switch_to_frame :parent # Go back to top
   end
 
-  it "can return to the top frame", requires: [:frames] do
-    frame = @session.find(:frame, "parentFrame")
+  it 'can return to the top frame', requires: [:frames] do
+    frame = @session.find(:frame, 'parentFrame')
     @session.switch_to_frame frame
-    frame = @session.find(:frame, "childFrame")
+    frame = @session.find(:frame, 'childFrame')
     @session.switch_to_frame frame
     @session.switch_to_frame :top
     expect(@session.find("//*[@id='divInMainWindow']").text).to eql 'This is the text for divInMainWindow'
@@ -94,7 +94,7 @@ Capybara::SpecHelper.spec '#switch_to_frame', requires: [:frames] do
     frame = @session.find(:frame, 'parentFrame')
     @session.switch_to_frame(frame)
     @session.within(:css, '#parentBody') do
-      @session.switch_to_frame(@session.find(:frame, "childFrame"))
+      @session.switch_to_frame(@session.find(:frame, 'childFrame'))
       expect do
         @session.switch_to_frame(:top)
       end.to raise_error(Capybara::ScopeError, "`switch_to_frame(:top)` cannot be called from inside a descendant frame's `within` block.")

data/lib/capybara/spec/session/frame/within_frame_spec.rb

@@ -5,56 +5,70 @@ Capybara::SpecHelper.spec '#within_frame', requires: [:frames] do
     @session.visit('/within_frames')
   end
 
-  it "should find the div in frameOne" do
-    @session.within_frame("frameOne") do
+  it 'should find the div in frameOne' do
+    @session.within_frame('frameOne') do
       expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
     end
   end
 
-  it "should find the div in FrameTwo" do
-    @session.within_frame("frameTwo") do
+  it 'should find the div in FrameTwo' do
+    @session.within_frame('frameTwo') do
       expect(@session.find("//*[@id='divInFrameTwo']").text).to eql 'This is the text of divInFrameTwo'
     end
   end
 
-  it "should find the text div in the main window after finding text in frameOne" do
-    @session.within_frame("frameOne") do
+  it 'should find the text div in the main window after finding text in frameOne' do
+    @session.within_frame('frameOne') do
       expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
     end
     expect(@session.find("//*[@id='divInMainWindow']").text).to eql 'This is the text for divInMainWindow'
   end
 
-  it "should find the text div in the main window after finding text in frameTwo" do
-    @session.within_frame("frameTwo") do
+  it 'should find the text div in the main window after finding text in frameTwo' do
+    @session.within_frame('frameTwo') do
       expect(@session.find("//*[@id='divInFrameTwo']").text).to eql 'This is the text of divInFrameTwo'
     end
     expect(@session.find("//*[@id='divInMainWindow']").text).to eql 'This is the text for divInMainWindow'
   end
 
-  it "should return the result of executing the block" do
-    expect(@session.within_frame("frameOne") { "return value" }).to eql "return value"
+  it 'should return the result of executing the block' do
+    expect(@session.within_frame('frameOne') { 'return value' }).to eql 'return value'
   end
 
-  it "should find the div given Element" do
+  it 'should find the div given Element' do
     element = @session.find(:id, 'frameOne')
     @session.within_frame element do
       expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
     end
   end
 
-  it "should find the div given selector and locator" do
+  it 'should find the div given selector and locator' do
     @session.within_frame(:css, '#frameOne') do
       expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
     end
   end
 
-  it "should default to the :frame selector kind when only options passed" do
+  it 'should default to the :frame selector kind when only options passed' do
     @session.within_frame(name: 'my frame one') do
       expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
     end
   end
 
-  it "should find multiple nested frames" do
+  it 'should default to the :frame selector when no options passed' do
+    container = @session.find(:css, '#divInMainWindow')
+    @session.within(container) do
+      # Ensure only one frame in scope
+      @session.within_frame do
+        expect(@session).to have_css('body#parentBody')
+      end
+    end
+    expect do
+      # Multiple frames in scope here
+      @session.within_frame { ; }
+    end.to raise_error Capybara::Ambiguous
+  end
+
+  it 'should find multiple nested frames' do
     @session.within_frame 'parentFrame' do
       @session.within_frame 'childFrame' do
         @session.within_frame 'grandchildFrame1' do
@@ -67,15 +81,15 @@ Capybara::SpecHelper.spec '#within_frame', requires: [:frames] do
     end
   end
 
-  it "should reset scope when changing frames" do
+  it 'should reset scope when changing frames' do
     @session.within(:css, '#divInMainWindow') do
       @session.within_frame 'innerParentFrame' do
-        expect(@session.has_selector?(:css, "iframe#childFrame")).to be true
+        expect(@session.has_selector?(:css, 'iframe#childFrame')).to be true
       end
     end
   end
 
-  it "works if the frame is closed", requires: %i[frames js] do
+  it 'works if the frame is closed', requires: %i[frames js] do
     @session.within_frame 'parentFrame' do
       @session.within_frame 'childFrame' do
         @session.click_link 'Close Window'

data/lib/capybara/spec/session/go_back_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Capybara::SpecHelper.spec '#go_back', requires: [:js] do
-  it "should fetch a response from the driver from the previous page" do
+  it 'should fetch a response from the driver from the previous page' do
     @session.visit('/')
     expect(@session).to have_content('Hello world!')
     @session.visit('/foo')

data/lib/capybara/spec/session/go_forward_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 Capybara::SpecHelper.spec '#go_forward', requires: [:js] do
-  it "should fetch a response from the driver from the previous page" do
+  it 'should fetch a response from the driver from the previous page' do
     @session.visit('/')
     expect(@session).to have_content('Hello world!')
     @session.visit('/foo')

data/lib/capybara/spec/session/has_all_selectors_spec.rb

@@ -5,26 +5,26 @@ Capybara::SpecHelper.spec '#have_all_selectors' do
     @session.visit('/with_html')
   end
 
-  it "should be true if the given selectors are on the page" do
-    expect(@session).to have_all_of_selectors(:css, "p a#foo", "h2#h2one", "h2#h2two")
+  it 'should be true if the given selectors are on the page' do
+    expect(@session).to have_all_of_selectors(:css, 'p a#foo', 'h2#h2one', 'h2#h2two')
   end
 
-  it "should be false if any of the given selectors are not on the page" do
+  it 'should be false if any of the given selectors are not on the page' do
     expect do
-      expect(@session).to have_all_of_selectors(:css, "p a#foo", "h2#h2three", "h2#h2one")
+      expect(@session).to have_all_of_selectors(:css, 'p a#foo', 'h2#h2three', 'h2#h2one')
     end.to raise_error ::RSpec::Expectations::ExpectationNotMetError
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@session).to have_all_of_selectors("p a#foo", "h2#h2two", "h2#h2one")
+    expect(@session).to have_all_of_selectors('p a#foo', 'h2#h2two', 'h2#h2one')
     expect do
-      expect(@session).to have_all_of_selectors("p a#foo", "h2#h2three", "h2#h2one")
+      expect(@session).to have_all_of_selectors('p a#foo', 'h2#h2three', 'h2#h2one')
     end.to raise_error ::RSpec::Expectations::ExpectationNotMetError
   end
 
-  context "should respect scopes" do
-    it "when used with `within`" do
+  context 'should respect scopes' do
+    it 'when used with `within`' do
       @session.within "//p[@id='first']" do
         expect(@session).to have_all_of_selectors(".//a[@id='foo']")
         expect do
@@ -33,7 +33,7 @@ Capybara::SpecHelper.spec '#have_all_selectors' do
       end
     end
 
-    it "when called on elements" do
+    it 'when called on elements' do
       el = @session.find "//p[@id='first']"
       expect(el).to have_all_of_selectors(".//a[@id='foo']")
       expect do
@@ -42,8 +42,8 @@ Capybara::SpecHelper.spec '#have_all_selectors' do
     end
   end
 
-  context "with options" do
-    it "should apply options to all locators" do
+  context 'with options' do
+    it 'should apply options to all locators' do
       expect(@session).to have_all_of_selectors(:field, 'normal', 'additional_newline', type: :textarea)
       expect do
         expect(@session).to have_all_of_selectors(:field, 'normal', 'test_field', 'additional_newline', type: :textarea)
@@ -51,19 +51,19 @@ Capybara::SpecHelper.spec '#have_all_selectors' do
     end
   end
 
-  context "with wait", requires: [:js] do
-    it "should not raise error if all the elements appear before given wait duration" do
+  context 'with wait', requires: [:js] do
+    it 'should not raise error if all the elements appear before given wait duration' do
       Capybara.using_wait_time(0.1) do
         @session.visit('/with_js')
         @session.click_link('Click me')
-        expect(@session).to have_all_of_selectors(:css, "a#clickable", "a#has-been-clicked", '#drag', wait: 0.9)
+        expect(@session).to have_all_of_selectors(:css, 'a#clickable', 'a#has-been-clicked', '#drag', wait: 5)
       end
     end
   end
 
-  it "cannot be negated" do
+  it 'cannot be negated' do
     expect do
-      expect(@session).not_to have_all_of_selectors(:css, "p a#foo", "h2#h2one", "h2#h2two")
+      expect(@session).not_to have_all_of_selectors(:css, 'p a#foo', 'h2#h2one', 'h2#h2two')
     end.to raise_error ArgumentError
   end
 end