browse-everything 0.10.5 → 0.11.0

data/spec/unit/retriever_spec.rb

@@ -1,94 +1,93 @@
-describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record: :none,  } do
+describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record: :none } do
   subject { BrowseEverything::Retriever.new }
-  let(:datafile) { File.expand_path('../../fixtures/file_system/file_1.pdf',__FILE__) }
-  let(:datafile_with_spaces) { File.expand_path('../../fixtures/file_system/file 1.pdf',__FILE__) }
-  let(:data) { File.open(datafile,'rb',&:read) }
+  let(:datafile) { File.expand_path('../../fixtures/file_system/file_1.pdf', __FILE__) }
+  let(:datafile_with_spaces) { File.expand_path('../../fixtures/file_system/file 1.pdf', __FILE__) }
+  let(:data) { File.open(datafile, 'rb', &:read) }
   let(:data_with_spaces) { File.open(datafile_with_spaces, 'rb', &:read) }
   let(:size) { File.size(datafile) }
 
   context 'http://' do
-    let(:spec) {
+    let(:spec) do
       {
-        "0" => {
-          "url"=>"https://retrieve.cloud.example.com/some/dir/file.pdf",
-          "auth_header"=>{"Authorization"=>"Bearer ya29.kQCEAHj1bwFXr2AuGQJmSGRWQXpacmmYZs4kzCiXns3d6H1ZpIDWmdM8"},
-          "expires"=>(Time.now + 3600).xmlschema,
-          "file_name"=>"file.pdf",
-          "file_size"=>size.to_s
+        '0' => {
+          'url' => 'https://retrieve.cloud.example.com/some/dir/file.pdf',
+          'auth_header' => { 'Authorization' => 'Bearer ya29.kQCEAHj1bwFXr2AuGQJmSGRWQXpacmmYZs4kzCiXns3d6H1ZpIDWmdM8' },
+          'expires' => (Time.now + 3600).xmlschema,
+          'file_name' => 'file.pdf',
+          'file_size' => size.to_s
         }
       }
-    }
+    end
 
-    context "#retrieve" do
-      it "content" do
+    context '#retrieve' do
+      it 'content' do
         content = ''
-        subject.retrieve(spec['0']) { |chunk, retrieved, total| content << chunk }
+        subject.retrieve(spec['0']) { |chunk, _retrieved, _total| content << chunk }
         expect(content).to eq(data)
       end
 
-      it "callbacks" do
+      it 'callbacks' do
         expect { |block| subject.retrieve(spec['0'], &block) }.to yield_with_args(data, data.length, data.length)
       end
     end
 
-    context "#download" do
-      it "content" do
+    context '#download' do
+      it 'content' do
         file = subject.download(spec['0'])
-        expect(File.open(file,'rb',&:read)).to eq(data)
+        expect(File.open(file, 'rb', &:read)).to eq(data)
       end
 
-      it "callbacks" do
+      it 'callbacks' do
         expect { |block| subject.download(spec['0'], &block) }.to yield_with_args(String, data.length, data.length)
       end
     end
   end
 
   context 'file://' do
-    let(:spec) {
+    let(:spec) do
       {
-        "0" => {
-          "url"=>"file://#{datafile}",
-          "file_name"=>"file.pdf",
-          "file_size"=>size.to_s
+        '0' => {
+          'url' => "file://#{datafile}",
+          'file_name' => 'file.pdf',
+          'file_size' => size.to_s
         },
-	"1" => {
-	  "url" => "file://#{datafile_with_spaces}",
-	  "file_name" => "file.pdf",
-	  "file_size" => size.to_s
-	}
+        '1' => {
+          'url' => "file://#{datafile_with_spaces}",
+          'file_name' => 'file.pdf',
+          'file_size' => size.to_s
+        }
       }
-    }
+    end
 
-    context "#retrieve" do
-      it "content" do
+    context '#retrieve' do
+      it 'content' do
         content = ''
-        subject.retrieve(spec['0']) { |chunk, retrieved, total| content << chunk }
+        subject.retrieve(spec['0']) { |chunk, _retrieved, _total| content << chunk }
         expect(content).to eq(data)
       end
 
-      it "content with spaces" do
+      it 'content with spaces' do
         content = ''
-	subject.retrieve(spec['1']) { |chunk, retrieved, total| content << chunk }
-	expect(content).to eq(data_with_spaces)
+        subject.retrieve(spec['1']) { |chunk, _retrieved, _total| content << chunk }
+        expect(content).to eq(data_with_spaces)
       end
 
-      it "callbacks" do
+      it 'callbacks' do
         expect { |block| subject.retrieve(spec['0'], &block) }.to yield_with_args(data, data.length, data.length)
       end
     end
 
-    context "#download" do
-      it "content" do
+    context '#download' do
+      it 'content' do
         file = subject.download(spec['0'])
-        expect(File.open(file,'rb',&:read)).to eq(data)
+        expect(File.open(file, 'rb', &:read)).to eq(data)
       end
 
-      it "callbacks" do
+      it 'callbacks' do
         expect { |block| subject.download(spec['0'], &block) }.to yield_with_args(String, data.length, data.length)
       end
     end
   end
 
   context ''
-
 end

data/spec/unit/s3_spec.rb

@@ -0,0 +1,77 @@
+include BrowserConfigHelper
+
+describe BrowseEverything::Driver::FileSystem do
+  before(:all)  { stub_configuration   }
+  after(:all)   { unstub_configuration }
+  let(:browser) { BrowseEverything::Browser.new(url_options) }
+  let(:provider) { browser.providers['s3'] }
+
+  it '#validate_config' do
+    expect { BrowseEverything::Driver::S3.new({}) }.to raise_error(BrowseEverything::InitializationError)
+  end
+
+  describe '#contents' do
+    context 'root directory' do
+      before do
+        Aws.config[:s3] = {
+          stub_responses: {
+            list_objects: { is_truncated: false, marker: "", next_marker: nil, contents: [], name: "s3.bucket", prefix: "", delimiter: "/", max_keys: 1000, common_prefixes: [ { prefix: 'foo/' }, { prefix: 'bar/'} ], encoding_type: "url" },
+          }
+        }
+      end
+      
+      let(:contents) { provider.contents('') }
+      context '[0]' do
+        subject { contents[0] }
+        its(:name) { should == 'bar'     }
+        specify    { should be_container }
+      end
+      context '[1]' do
+        subject { contents[1] }
+        its(:name) { should == 'foo'     }
+        specify    { should be_container }
+      end
+    end
+    
+    context 'subdirectory' do
+      before do
+        Aws.config[:s3] = {
+          stub_responses: {
+            list_objects: 
+              {
+                is_truncated: false, marker: "", next_marker: nil, name: "s3.bucket", prefix: "foo/", delimiter: "/", max_keys: 1000, common_prefixes: [], encoding_type: "url",
+                contents: [
+                  { key: "foo/", last_modified: Time.parse('2014-02-03 16:27:01 UTC'), etag: "\"d41d8cd98f00b204e9800998ecf8427e\"", size: 0, storage_class: "STANDARD", owner: { display_name: "mbklein" } },
+                  { key: "foo/baz.jpg", last_modified: Time.parse('2016-10-31 20:12:32 UTC'), etag: "\"4e2ad532e659a65e8f106b350255a7ba\"", size: 52645, storage_class: "STANDARD", owner: { display_name: "mbklein" } },
+                  { key: "foo/quux.png", last_modified: Time.parse('2016-10-31 22:08:12 UTC'), etag: "\"a92bbe23736ebdbd37bdc795e7d570ad\"", size: 1511860, storage_class: "STANDARD", owner: { display_name: "mbklein" } }
+                ]
+              }
+          }
+        }
+      end
+      
+      let(:contents) { provider.contents('foo/') }
+      context '[0]' do
+        subject { contents[0] }
+        its(:name) { should == '..'      }
+        specify    { should be_container }
+      end
+      context '[1]' do
+        subject { contents[1] }
+        its(:name)     { should == 'baz.jpg' }
+        its(:location) { should == "s3:foo/baz.jpg"  }
+        its(:type)     { should == 'image/jpeg'      }
+        its(:size)     { should == 52645             }
+        specify        { should_not be_container     }
+      end
+      context '[2]' do
+        subject { contents[2] }
+        its(:name)     { should == 'quux.png' }
+        its(:location) { should == "s3:foo/quux.png" }
+        its(:type)     { should == 'image/png'       }
+        its(:size)     { should == 1511860           }
+        specify        { should_not be_container     }
+      end
+    end
+  end
+end

data/spec/unit/sky_drive_spec.rb

@@ -2,50 +2,50 @@ describe BrowseEverything::Driver::SkyDrive do
   include BrowseEverything::Engine.routes.url_helpers
 
   def provider_yml
-    {client_id: "CLIENTID", client_secret: "CLIENTSECRET", url_options:{ :port=>"3000", :protocol=>"http://", host:"example.com"}}
+    { client_id: 'CLIENTID', client_secret: 'CLIENTSECRET', url_options: { port: '3000', protocol: 'http://', host: 'example.com' } }
   end
 
   def redirect_url
     connector_response_url(provider_yml[:url_options])
   end
 
-  it "can connect" do
-    stub_request(:post, "https://login.live.com/oauth20_token.srf").
-        with(:body => {"client_id"=>"CLIENTID", "client_secret"=>"CLIENTSECRET", "code"=>"code", "grant_type"=>"authorization_code", "redirect_uri"=>"#{redirect_url}"}).
-        to_return(:status => 200,
-                  :body => {
-                      "token_type"            =>  "bearer",
-                      "expires_at"            =>  (Time.now +  (60 * 60 * 24)).to_i,
-                      "scope"                 =>  "wl.skydrive_update,wl.offline_access",
-                      "access_token"          =>  "access_token",
-                      "refresh_token"         =>  "refresh_token",
-                      "authentication_token"  =>  "authentication_token"
-                  }.to_json,
-                  :headers  => {
-                      "content-type"          =>  "application/json"})
+  it 'can connect' do
+    stub_request(:post, 'https://login.live.com/oauth20_token.srf')
+        .with(body: { 'client_id' => 'CLIENTID', 'client_secret' => 'CLIENTSECRET', 'code' => 'code', 'grant_type' => 'authorization_code', 'redirect_uri' => redirect_url.to_s })
+        .to_return(status: 200,
+                   body: {
+                     'token_type'            =>  'bearer',
+                     'expires_at'            =>  (Time.now + (60 * 60 * 24)).to_i,
+                     'scope'                 =>  'wl.skydrive_update,wl.offline_access',
+                     'access_token'          =>  'access_token',
+                     'refresh_token'         =>  'refresh_token',
+                     'authentication_token'  =>  'authentication_token'
+                   }.to_json,
+                   headers: {
+                     'content-type'          =>  'application/json' })
 
     driver = BrowseEverything::Driver::SkyDrive.new(provider_yml)
-    driver.connect({code:"code"},{})
+    driver.connect({ code: 'code' }, {})
     driver.authorized?.should == true
   end
 
-  it "can connect but expires" do
-    stub_request(:post, "https://login.live.com/oauth20_token.srf").
-        with(:body => {"client_id"=>"CLIENTID", "client_secret"=>"CLIENTSECRET", "code"=>"code", "grant_type"=>"authorization_code", "redirect_uri"=>"#{redirect_url}"}).
-        to_return(:status => 200,
-                  :body => {
-                      "token_type"            =>  "bearer",
-                      "expires_at"            =>  (Time.now -  (60 * 60 * 24)).to_i,
-                      "scope"                 =>  "wl.skydrive_update,wl.offline_access",
-                      "access_token"          =>  "access_token",
-                      "refresh_token"         =>  "refresh_token",
-                      "authentication_token"  =>  "authentication_token"
-                  }.to_json,
-                  :headers  => {
-                      "content-type"          =>  "application/json"})
+  it 'can connect but expires' do
+    stub_request(:post, 'https://login.live.com/oauth20_token.srf')
+        .with(body: { 'client_id' => 'CLIENTID', 'client_secret' => 'CLIENTSECRET', 'code' => 'code', 'grant_type' => 'authorization_code', 'redirect_uri' => redirect_url.to_s })
+        .to_return(status: 200,
+                   body: {
+                     'token_type'            =>  'bearer',
+                     'expires_at'            =>  (Time.now - (60 * 60 * 24)).to_i,
+                     'scope'                 =>  'wl.skydrive_update,wl.offline_access',
+                     'access_token'          =>  'access_token',
+                     'refresh_token'         =>  'refresh_token',
+                     'authentication_token'  =>  'authentication_token'
+                   }.to_json,
+                   headers: {
+                     'content-type'          =>  'application/json' })
 
     driver = BrowseEverything::Driver::SkyDrive.new(provider_yml)
-    driver.connect({code:"code"},{})
+    driver.connect({ code: 'code' }, {})
     driver.authorized?.should == false
   end
 end

data/spec/views/browse_everything/_file.html.erb_spec.rb

@@ -1,71 +1,71 @@
 describe 'browse_everything/_file.html.erb', type: :view do
-  let(:file)  {
-                BrowseEverything::FileEntry.new(
-                     'file_id_01234', 'my_provider:/location/pa/th/file.m4v',
-                     'file.m4v', 1024*1024*1024, Time.now, false
-                   )
-               }
-  let(:container) {
-                BrowseEverything::FileEntry.new(
-                     'dir_id_01234', 'my_provider:/location/pa/th/dir',
-                     'dir', 0, Time.now, true
-                   )
-               }
-  let(:provider) { double("provider") }
+  let(:file) do
+    BrowseEverything::FileEntry.new(
+      'file_id_01234', 'my_provider:/location/pa/th/file.m4v',
+      'file.m4v', 1024 * 1024 * 1024, Time.now, false
+    )
+  end
+  let(:container) do
+    BrowseEverything::FileEntry.new(
+      'dir_id_01234', 'my_provider:/location/pa/th/dir',
+      'dir', 0, Time.now, true
+    )
+  end
+  let(:provider) { double('provider') }
   let(:page) { Capybara::Node::Simple.new(rendered) }
 
   before do
     allow(view).to receive(:browse_everything_engine).and_return(BrowseEverything::Engine.routes.url_helpers)
     allow(view).to receive(:provider).and_return(provider)
-    allow(view).to receive(:path).and_return("path")
-    allow(view).to receive(:parent).and_return("parent")
-    allow(view).to receive(:provider_name).and_return("my provider")
+    allow(view).to receive(:path).and_return('path')
+    allow(view).to receive(:parent).and_return('parent')
+    allow(view).to receive(:provider_name).and_return('my provider')
     allow(provider).to receive(:config).and_return(config)
   end
 
-  describe "a file" do
+  describe 'a file' do
     before do
       allow(view).to receive(:file).and_return(file)
       render
     end
-    context "file not too big" do
-      let(:config) { { max_upload_file_size: (5*1024*1024*1024) } }
-      it "should draw link" do
-        expect(page).to have_selector("a.ev-link")
+    context 'file not too big' do
+      let(:config) { { max_upload_file_size: (5 * 1024 * 1024 * 1024) } }
+      it 'should draw link' do
+        expect(page).to have_selector('a.ev-link')
       end
     end
 
-    context "max not configured" do
-      let(:config) { { } }
-      it "should draw link" do
-        expect(page).to have_selector("a.ev-link")
+    context 'max not configured' do
+      let(:config) { {} }
+      it 'should draw link' do
+        expect(page).to have_selector('a.ev-link')
       end
     end
 
-    context "file too big" do
+    context 'file too big' do
       let(:config) { { max_upload_file_size: 1024 } }
-      it "should draw link" do
-        expect(page).not_to have_selector("a.ev-link")
+      it 'should draw link' do
+        expect(page).not_to have_selector('a.ev-link')
       end
     end
 
-    context "multi-select" do
-      let(:config) { { } }
-      it "should not have a checkbox" do
-        expect(page).not_to have_selector("input.ev-select-all")
+    context 'multi-select' do
+      let(:config) { {} }
+      it 'should not have a checkbox' do
+        expect(page).not_to have_selector('input.ev-select-all')
       end
     end
   end
 
-  describe "a directory" do
+  describe 'a directory' do
     before do
       allow(view).to receive(:file).and_return(container)
       render
     end
-    context "multi-select" do
-      let(:config) { { } }
-      it "should have the select-all checkbox" do
-        expect(page).to have_selector("input.ev-select-all")
+    context 'multi-select' do
+      let(:config) { {} }
+      it 'should have the select-all checkbox' do
+        expect(page).to have_selector('input.ev-select-all')
       end
     end
   end

data/tasks/ci.rake

@@ -1,5 +1,5 @@
-desc "Run all RSpec tests."
-task :ci => ['engine_cart:generate'] do
+desc 'Run all RSpec tests.'
+task ci: ['engine_cart:generate'] do
   RSpec::Core::RakeTask.new(:spec)
-  Rake::Task["spec"].invoke
+  Rake::Task['spec'].invoke
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 0.10.5
+  version: 0.11.0
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-23 00:00:00.000000000 Z
+date: 2016-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -133,14 +133,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.6
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.6
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: signet
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -155,6 +169,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -197,6 +225,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -393,6 +435,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
@@ -400,7 +444,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- app/.DS_Store
 - app/assets/javascripts/browse_everything.js
 - app/assets/javascripts/browse_everything/behavior.js.coffee
 - app/assets/stylesheets/browse_everything.scss
@@ -409,7 +452,6 @@ files:
 - app/controllers/browse_everything_controller.rb
 - app/helpers/bootstrap_version_helper.rb
 - app/helpers/browse_everything_helper.rb
-- app/views/.DS_Store
 - app/views/browse_everything/_auth.html.erb
 - app/views/browse_everything/_file.html.erb
 - app/views/browse_everything/_files.html.erb
@@ -430,6 +472,7 @@ files:
 - lib/browse_everything/driver/dropbox.rb
 - lib/browse_everything/driver/file_system.rb
 - lib/browse_everything/driver/google_drive.rb
+- lib/browse_everything/driver/s3.rb
 - lib/browse_everything/driver/sky_drive.rb
 - lib/browse_everything/engine.rb
 - lib/browse_everything/file_entry.rb
@@ -468,6 +511,7 @@ files:
 - spec/unit/file_entry_spec.rb
 - spec/unit/file_system_spec.rb
 - spec/unit/retriever_spec.rb
+- spec/unit/s3_spec.rb
 - spec/unit/sky_drive_spec.rb
 - spec/views/browse_everything/_file.html.erb_spec.rb
 - tasks/ci.rake
@@ -494,7 +538,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: AJAX/Rails engine file browser for cloud storage services
@@ -527,5 +571,6 @@ test_files:
 - spec/unit/file_entry_spec.rb
 - spec/unit/file_system_spec.rb
 - spec/unit/retriever_spec.rb
+- spec/unit/s3_spec.rb
 - spec/unit/sky_drive_spec.rb
 - spec/views/browse_everything/_file.html.erb_spec.rb