browse-everything 0.10.5 → 0.11.0

data/lib/browse_everything/engine.rb

@@ -2,7 +2,7 @@ module BrowseEverything
   class Engine < ::Rails::Engine
     config.assets.paths << config.root.join('vendor', 'assets', 'javascripts')
     config.assets.paths << config.root.join('vendor', 'assets', 'stylesheets')
-    config.assets.precompile += %w{ browse_everything.js }
-    config.assets.precompile += %w{ browse_everything.css }
+    config.assets.precompile += %w(browse_everything.js)
+    config.assets.precompile += %w(browse_everything.css)
   end
 end

data/lib/browse_everything/file_entry.rb

@@ -2,20 +2,20 @@ module BrowseEverything
   class FileEntry
     attr_reader :id, :location, :name, :size, :mtime, :type
 
-    def initialize(id, location, name, size, mtime, container, type=nil)
+    def initialize(id, location, name, size, mtime, container, type = nil)
       @id        = id
       @location  = location
       @name      = name
       @size      = size
       @mtime     = mtime
       @container = container
-      @type      = type || @container ? 'application/x-directory' : Rack::Mime.mime_type(File.extname(name))
+      @type      = type || (@container ? 'application/x-directory' : Rack::Mime.mime_type(File.extname(name)))
     end
 
     def relative_parent_path?
       name =~ /^\.\.?$/ ? true : false
     end
-    
+
     def container?
       @container
     end

data/lib/browse_everything/retriever.rb

@@ -4,38 +4,38 @@ require 'tempfile'
 module BrowseEverything
   class Retriever
     attr_accessor :chunk_size
-    
+
     def initialize
       @chunk_size = 16384
     end
-    
-    def download(spec, target=nil)
+
+    def download(spec, target = nil)
       if target.nil?
         ext = File.extname(spec['file_name'])
-        base = File.basename(spec['file_name'],ext)
-        target = Dir::Tmpname.create([base,ext]) {}
+        base = File.basename(spec['file_name'], ext)
+        target = Dir::Tmpname.create([base, ext]) {}
       end
-      
+
       File.open(target, 'wb') do |output|
-        self.retrieve(spec) do |chunk, retrieved, total| 
-          output.write(chunk) 
+        retrieve(spec) do |chunk, retrieved, total|
+          output.write(chunk)
           yield(target, retrieved, total) if block_given?
         end
       end
-      return target
+      target
     end
-    
-    def retrieve(spec, &block)
-      if spec.has_key?('expires') and Time.parse(spec['expires']) < Time.now
+
+    def retrieve(spec)
+      if spec.key?('expires') && Time.parse(spec['expires']) < Time.now
         raise ArgumentError, "Download spec expired at #{spec['expires']}"
       end
-      
+
       url = Addressable::URI.parse(spec['url'])
       retrieved = 0
       case url.scheme
       when 'file'
-        File.open(url.path,'rb') do |f|
-          while not f.eof?
+        File.open(url.path, 'rb') do |f|
+          until f.eof?
             chunk = f.read(chunk_size)
             retrieved += chunk.length
             yield(chunk, retrieved, spec['file_size'].to_i)
@@ -43,11 +43,11 @@ module BrowseEverything
         end
       when /https?/
         headers = spec['auth_header'] || {}
-        headers.each_pair do |k,v|
-          headers[k] = v.gsub(/\+/,' ')
+        headers.each_pair do |k, v|
+          headers[k] = v.tr('+', ' ')
         end
-        
-        HTTParty.get(url.to_s, headers: headers) do |chunk| 
+
+        HTTParty.get(url.to_s, headers: headers) do |chunk|
           retrieved += chunk.length
           yield(chunk, retrieved, spec['file_size'].to_i)
         end
@@ -55,6 +55,5 @@ module BrowseEverything
         raise URI::BadURIError, "Unknown URI scheme: #{uri.scheme}"
       end
     end
-
   end
 end

data/lib/browse_everything/version.rb

@@ -1,3 +1,3 @@
 module BrowseEverything
-  VERSION = "0.10.5"
+  VERSION = '0.11.0'.freeze
 end

data/lib/generators/browse_everything/assets_generator.rb

@@ -2,13 +2,11 @@
 require 'rails/generators'
 
 class BrowseEverything::AssetsGenerator < Rails::Generators::Base
-  desc """
-    This generator installs the browse_everything CSS assets into your application
-       """
+  desc 'This generator installs the browse_everything CSS assets into your application'
 
   source_root File.expand_path('../templates', __FILE__)
 
   def inject_css
-    copy_file "browse_everything.scss", "app/assets/stylesheets/browse_everything.scss"
+    copy_file 'browse_everything.scss', 'app/assets/stylesheets/browse_everything.scss'
   end
 end

data/lib/generators/browse_everything/config_generator.rb

@@ -2,27 +2,27 @@
 require 'rails/generators'
 
 class BrowseEverything::ConfigGenerator < Rails::Generators::Base
-    desc """
-  This generator makes the following changes to your application:
-   1. Creates config/browse_everything_providers.yml with a placeholder value
-   2. Modifies your app's routes.rb to mount BrowseEverything at /browse
-         """
+  desc <<-END_OF_DESC
+This generator makes the following changes to your application:
+ 1. Creates config/browse_everything_providers.yml with a placeholder value
+ 2. Modifies your app's routes.rb to mount BrowseEverything at /browse
+  END_OF_DESC
   source_root File.expand_path('../templates', __FILE__)
 
   def inject_routes
-   insert_into_file "config/routes.rb", :after => ".draw do" do
-%{
-  mount BrowseEverything::Engine => '/browse'}
-   end
+    insert_into_file 'config/routes.rb', after: '.draw do' do
+      %(
+        mount BrowseEverything::Engine => '/browse')
+    end
   end
 
   def copy_example_config
-    copy_file "browse_everything_providers.yml.example", "config/browse_everything_providers.yml"
+    copy_file 'browse_everything_providers.yml.example', 'config/browse_everything_providers.yml'
   end
 
   def insert_file_system_path
-    insert_into_file "config/browse_everything_providers.yml", :before => "# dropbox:" do
-      YAML.dump({ 'file_system' => { :home => Rails.root.to_s }})
+    insert_into_file 'config/browse_everything_providers.yml', before: '# dropbox:' do
+      YAML.dump('file_system' => { home: Rails.root.to_s })
     end
   end
 end

data/lib/generators/browse_everything/install_generator.rb

@@ -2,11 +2,9 @@
 require 'rails/generators'
 
 class BrowseEverything::InstallGenerator < Rails::Generators::Base
-  class_option :'skip-assets', type: :boolean, default: false, desc: "Skip generating javascript and css assets into the application"
+  class_option :'skip-assets', type: :boolean, default: false, desc: 'Skip generating javascript and css assets into the application'
 
-  desc """
-    This generator installs the browse everything configuration and assets into your application
-       """
+  desc 'This generator installs the browse everything configuration and assets into your application'
 
   source_root File.expand_path('../templates', __FILE__)
 

data/lib/generators/browse_everything/templates/browse_everything_providers.yml.example

@@ -11,6 +11,12 @@
 # google_drive:
 #   :client_id: YOUR_GOOGLE_API_CLIENT_ID
 #   :client_secret: YOUR_GOOGLE_API_CLIENT_SECRET
+# s3:
+#   :app_key: YOUR_AWS_S3_KEY
+#   :app_secret: YOUR_AWS_S3_SECRET
+#   :bucket: YOUR_AWS_S3_BUCKET
+#   :region: YOUR_AWS_S3_REGION # default: us-east-1
+#   :signed_url: true # set to false for public urls
 # sky_drive:
 #   :client_id: YOUR_MS_LIVE_CONNECT_CLIENT_ID
 #   :client_secret: YOUR_MS_LIVE_CONNECT_CLIENT_SECRET

data/spec/features/select_files_spec.rb

@@ -1,6 +1,6 @@
 require 'capybara/poltergeist'
 
-describe "Choosing files", :type => :feature do
+describe 'Choosing files', type: :feature do
   before do
     Capybara.register_driver :poltergeist do |app|
       Capybara::Poltergeist::Driver.new(app, js_errors: true, timeout: 90)
@@ -9,27 +9,27 @@ describe "Choosing files", :type => :feature do
     visit '/'
   end
 
-  shared_examples "browseable files" do
-    it "selects files from the filesystem" do
+  shared_examples 'browseable files' do
+    it 'selects files from the filesystem' do
       click_button('Browse')
       sleep(5)
-      click_link("README.rdoc")
-      within(".modal-footer") do
-        expect(page).to have_selector("span", text: "1 file selected")
-        click_button("Submit")
+      click_link('Gemfile.lock')
+      within('.modal-footer') do
+        expect(page).to have_selector('span', text: '1 file selected')
+        click_button('Submit')
       end
       sleep(5)
-      expect(page).to have_selector("#status", text: "1 items selected")
+      expect(page).to have_selector('#status', text: '1 items selected')
     end
   end
 
-  context "when Turbolinks are enabled" do
+  context 'when Turbolinks are enabled' do
     before { click_link('Enter Test App (Turbolinks)') }
-    it_behaves_like "browseable files"
+    it_behaves_like 'browseable files'
   end
 
-  context "when Turbolinks are disabled" do
+  context 'when Turbolinks are disabled' do
     before { click_link('Enter Test App (No Turbolinks)') }
-    it_behaves_like "browseable files"
+    it_behaves_like 'browseable files'
   end
 end

data/spec/features/test_compiling_stylesheets_spec.rb

@@ -1,5 +1,5 @@
-describe "Compiling the stylesheets", :type => :feature do
-  it "should not raise errors" do
+describe 'Compiling the stylesheets', type: :feature do
+  it 'should not raise errors' do
     visit '/'
     expect(page).not_to have_content 'Sass::SyntaxError'
   end

data/spec/helper/browse_everything_controller_helper_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper',__FILE__)
+require File.expand_path('../../spec_helper', __FILE__)
 
 include BrowserConfigHelper
 
@@ -6,7 +6,7 @@ describe BrowseEverythingController, type: :controller do
   before(:all)  { stub_configuration   }
   after(:all)   { unstub_configuration }
 
-  let(:helper_context) {controller.view_context}
+  let(:helper_context) { controller.view_context }
   let(:browser) { BrowseEverything::Browser.new(url_options) }
 
   before do
@@ -16,9 +16,9 @@ describe BrowseEverythingController, type: :controller do
   context 'dropbox' do
     let(:provider) { browser.providers['dropbox'] }
 
-    describe "auth_link" do
-      subject {helper_context.auth_link}
-      it "has a single state" do
+    describe 'auth_link' do
+      subject { helper_context.auth_link }
+      it 'has a single state' do
         expect(subject.scan(/state/).length).to eq 1
       end
     end
@@ -27,9 +27,9 @@ describe BrowseEverythingController, type: :controller do
   context 'box' do
     let(:provider) { browser.providers['box'] }
 
-    describe "auth_link" do
-      subject {helper_context.auth_link}
-      it "has a single state" do
+    describe 'auth_link' do
+      subject { helper_context.auth_link }
+      it 'has a single state' do
         expect(subject.scan(/state/).length).to eq 1
       end
     end

data/spec/javascripts/jasmine_spec.rb

@@ -2,15 +2,15 @@ require 'rake'
 
 # Run the jasmine tests by running the jasmine:ci rake command and parses the output for failures.
 # The spec will fail if any jasmine tests fails.
-describe "Jasmine" do
-  it "expects all jasmine tests to pass" do
+describe 'Jasmine' do
+  it 'expects all jasmine tests to pass' do
     load_rake_environment ["#{jasmine_path}/lib/jasmine/tasks/jasmine.rake"]
     jasmine_out = run_task 'jasmine:ci'
-    unless jasmine_out.include? "0 failures"
-      puts "Some of the Jasmine tests failed"
+    unless jasmine_out.include? '0 failures'
+      puts 'Some of the Jasmine tests failed'
       puts jasmine_out
     end
-    expect(jasmine_out).to include "0 failures"
+    expect(jasmine_out).to include '0 failures'
   end
 end
 

data/spec/javascripts/support/jasmine_helper.rb

@@ -1,15 +1,15 @@
-#Use this file to set/override Jasmine configuration options
-#You can remove it if you don't need it.
-#This file is loaded *after* jasmine.yml is interpreted.
+# Use this file to set/override Jasmine configuration options
+# You can remove it if you don't need it.
+# This file is loaded *after* jasmine.yml is interpreted.
 #
-#Example: using a different boot file.
-#Jasmine.configure do |config|
+# Example: using a different boot file.
+# Jasmine.configure do |config|
 #   config.boot_dir = '/absolute/path/to/boot_dir'
 #   config.boot_files = lambda { ['/absolute/path/to/boot_dir/file.js'] }
-#end
+# end
 #
-#Example: prevent PhantomJS auto install, uses PhantomJS already on your path.
-#Jasmine.configure do |config|
+# Example: prevent PhantomJS auto install, uses PhantomJS already on your path.
+# Jasmine.configure do |config|
 #   config.prevent_phantom_js_auto_install = true
-#end
+# end
 #

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 require 'engine_cart'
-require File.expand_path("config/environment", EngineCart.destination)
+require File.expand_path('config/environment', EngineCart.destination)
 require 'rspec'
 require 'rspec/rails'
 require 'rspec/its'
@@ -15,7 +15,7 @@ Coveralls.wear!
 EngineCart.load_application!
 
 SimpleCov.start do
-  add_filter "/spec/"
+  add_filter '/spec/'
 end
 
 VCR.configure do |c|
@@ -45,27 +45,30 @@ module BrowserConfigHelper
   end
 
   def stub_configuration
-    BrowseEverything.configure({
-      "file_system" => {
-        home: File.expand_path('../fixtures/file_system',__FILE__)
-      },
-      "box" => {
-        client_id: "BoxClientId",
-        client_secret: "BoxClientSecret"
-      },
-      "dropbox" => {
-        app_key: "DropboxAppKey",
-        app_secret: "DropboxAppSecret"
-      },
-      "google_drive" => {
-        client_id: "GoogleClientId",
-        client_secret: "GoogleClientSecret"
-      },
-      "sky_drive" => {
-        client_id: "SkyDriveClientId",
-        client_secret: "SkyDriveClientSecret"
-      }
-    })
+    BrowseEverything.configure('file_system' => {
+                                 home: File.expand_path('../fixtures/file_system', __FILE__)
+                               },
+                               'box' => {
+                                 client_id: 'BoxClientId',
+                                 client_secret: 'BoxClientSecret'
+                               },
+                               'dropbox' => {
+                                 app_key: 'DropboxAppKey',
+                                 app_secret: 'DropboxAppSecret'
+                               },
+                               'google_drive' => {
+                                 client_id: 'GoogleClientId',
+                                 client_secret: 'GoogleClientSecret'
+                               },
+                               'sky_drive' => {
+                                 client_id: 'SkyDriveClientId',
+                                 client_secret: 'SkyDriveClientSecret'
+                               },
+                               's3' => {
+                                 app_key: 'S3AppKey',
+                                 app_secret: 'S3AppSecret',
+                                 bucket: 's3.bucket'
+                               })
   end
 
   def unstub_configuration

data/spec/support/app/controllers/file_handler_controller.rb

@@ -4,8 +4,8 @@ class FileHandlerController < ApplicationController
 
   def main
   end
-    
+
   def update
-    render :json => params[:selected_files].to_json
+    render json: params[:selected_files].to_json
   end
-end
+end

data/spec/support/rake.rb

@@ -5,7 +5,7 @@ module RakeHelper
     @rake = Rake::Application.new
     Rake.application = @rake
     Rake::Task.define_task(:environment)
-    files.each {|file| load file}
+    files.each { |file| load file }
   end
 
   def run_task(task)

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -1,47 +1,46 @@
 require 'rails/generators'
 
 class TestAppGenerator < Rails::Generators::Base
-  source_root File.expand_path("../../../../spec/support", __FILE__)
-  
+  source_root File.expand_path('../../../../spec/support', __FILE__)
+
   def run_config_generator
-    generate "browse_everything:config"
+    generate 'browse_everything:config'
   end
-  
+
   def inject_css
-    copy_file File.expand_path("app/assets/stylesheets/application.css", ENV['RAILS_ROOT']), "app/assets/stylesheets/application.css.scss"
-    remove_file "app/assets/stylesheets/application.css"
-    insert_into_file "app/assets/stylesheets/application.css.scss", :after => '*/' do
-      %{\n\n@import "browse_everything"}
+    copy_file File.expand_path('app/assets/stylesheets/application.css', ENV['RAILS_ROOT']), 'app/assets/stylesheets/application.css.scss'
+    remove_file 'app/assets/stylesheets/application.css'
+    insert_into_file 'app/assets/stylesheets/application.css.scss', after: '*/' do
+      %(\n\n@import "browse_everything")
     end
   end
-  
+
   def inject_javascript
-    insert_into_file "app/assets/javascripts/application.js", :after => '//= require_tree .' do
+    insert_into_file 'app/assets/javascripts/application.js', after: '//= require_tree .' do
       "\n//= require browse_everything"
     end
   end
-  
+
   def inject_application
-    insert_into_file "config/application.rb", :after => 'Rails::Application' do
+    insert_into_file 'config/application.rb', after: 'Rails::Application' do
       "\nconfig.autoload_paths+=[File.join(Rails.root,'../../lib')]"
     end
   end
-  
+
   def inject_routes
-    insert_into_file "config/routes.rb", :after => ".draw do" do
-      %{
-        
+    insert_into_file 'config/routes.rb', after: '.draw do' do
+      %(
+
         root :to => "file_handler#index"
         get '/main', :to => "file_handler#main"
         post '/file', :to => "file_handler#update"
-      }
+      )
     end
   end
-  
+
   def create_test_route
-    copy_file "app/controllers/file_handler_controller.rb", "app/controllers/file_handler_controller.rb"
-    copy_file "app/views/file_handler/main.html.erb", "app/views/file_handler/main.html.erb"
-    copy_file "app/views/file_handler/index.html.erb", "app/views/file_handler/index.html.erb"
+    copy_file 'app/controllers/file_handler_controller.rb', 'app/controllers/file_handler_controller.rb'
+    copy_file 'app/views/file_handler/main.html.erb', 'app/views/file_handler/main.html.erb'
+    copy_file 'app/views/file_handler/index.html.erb', 'app/views/file_handler/index.html.erb'
   end
-  
 end