browse-everything 0.10.5 → 0.11.0

data/spec/unit/base_spec.rb

@@ -3,23 +3,23 @@ include BrowserConfigHelper
 describe BrowseEverything::Driver::Base do
   subject { BrowseEverything::Driver::Base.new({}) }
 
-  describe "simple properties" do
+  describe 'simple properties' do
     its(:name)      { should == 'Base'         }
     its(:key)       { should == 'base'         }
     its(:icon)      { should be_a(String)      }
     its(:auth_link) { should be_empty          }
     specify         { should_not be_authorized }
   end
-  context "#connect" do
-    specify { subject.connect({},{}).should be_blank }
+  context '#connect' do
+    specify { subject.connect({}, {}).should be_blank }
   end
-  context "#contents" do
+  context '#contents' do
     specify { subject.contents('').should be_empty }
   end
-  context "#details" do
+  context '#details' do
     specify { subject.details('/path/to/foo.txt').should be_nil }
   end
-  context "#link_for" do
+  context '#link_for' do
     specify { subject.link_for('/path/to/foo.txt').should == ['/path/to/foo.txt', { file_name: 'foo.txt' }] }
   end
 end

data/spec/unit/browse_everything_helper_spec.rb

@@ -1,37 +1,37 @@
 describe BrowseEverythingHelper do
-  let(:test_class) {
+  let(:test_class) do
     Class.new do
       include BrowseEverythingHelper
       attr_reader :params
-      def initialize params
+      def initialize(params)
         @params = params
       end
     end
-  }
+  end
 
   let(:test_file) { BrowseEverything::FileEntry.new 0, '/path/to/file.mp4', 'file.mp4', 12345, Time.now, false }
 
-  it "should match a full type" do
+  it 'should match a full type' do
     expect(test_class.new(accept: 'video/mp4').is_acceptable?(test_file)).to eq(true)
   end
 
-  it "should match a wildcard type" do
+  it 'should match a wildcard type' do
     expect(test_class.new(accept: 'video/*').is_acceptable?(test_file)).to eq(true)
   end
 
-  it "should not match the wrong full type" do
+  it 'should not match the wrong full type' do
     expect(test_class.new(accept: 'video/mpeg').is_acceptable?(test_file)).to eq(false)
   end
 
-  it "should not match the wrong wildcard type" do
+  it 'should not match the wrong wildcard type' do
     expect(test_class.new(accept: 'audio/*').is_acceptable?(test_file)).to eq(false)
   end
 
-  it "should match a type list" do
+  it 'should match a type list' do
     expect(test_class.new(accept: 'audio/*, video/mp4').is_acceptable?(test_file)).to eq(true)
   end
 
-  it "should not match the wrong type list" do
+  it 'should not match the wrong type list' do
     expect(test_class.new(accept: 'audio/*, application/json').is_acceptable?(test_file)).to eq(false)
   end
 end

data/spec/unit/browser_spec.rb

@@ -1,72 +1,72 @@
 include BrowserConfigHelper
 
 describe BrowseEverything::Browser do
-  let(:file_config) {
+  let(:file_config) do
     {
       file_system: { home: '/file/config/home' },
       dropbox:    { app_key: 'FileConfigKey', app_secret: 'FileConfigSecret' }
     }.to_yaml
-  }
+  end
 
-  let(:global_config) {
+  let(:global_config) do
     {
       file_system: { home: '/global/config/home' },
       dropbox:    { app_key: 'GlobalConfigKey', app_secret: 'GlobalConfigSecret' }
     }
-  }
+  end
 
-  let(:local_config) {
+  let(:local_config) do
     {
       file_system: { home: '/local/config/home' },
       dropbox:    { app_key: 'LocalConfigKey', app_secret: 'LocalConfigSecret' },
       url_options: url_options
     }
-  }
+  end
 
-  describe "file config" do
+  describe 'file config' do
     before(:each) { allow(File).to receive(:read).and_return(file_config) }
     subject { BrowseEverything::Browser.new(url_options) }
 
-    it "should have 2 providers" do
+    it 'should have 2 providers' do
       expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
 
-    it "should use the file configuration" do
+    it 'should use the file configuration' do
       expect(subject.providers[:dropbox].config[:app_key]).to eq('FileConfigKey')
     end
   end
 
-  describe "global config" do
+  describe 'global config' do
     before(:each) { BrowseEverything.configure(global_config) }
     subject { BrowseEverything::Browser.new(url_options) }
 
-    it "should have 2 providers" do
+    it 'should have 2 providers' do
       expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
 
-    it "should use the global configuration" do
+    it 'should use the global configuration' do
       expect(subject.providers[:dropbox].config[:app_key]).to eq('GlobalConfigKey')
     end
   end
 
-  describe "local config" do
+  describe 'local config' do
     subject { BrowseEverything::Browser.new(local_config) }
 
-    it "should have 2 providers" do
+    it 'should have 2 providers' do
       expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
 
-    it "should use the local configuration" do
+    it 'should use the local configuration' do
       expect(subject.providers[:dropbox].config[:app_key]).to eq('LocalConfigKey')
     end
   end
 
-  describe "unknown provider" do
-    subject {
+  describe 'unknown provider' do
+    subject do
       BrowseEverything::Browser.new(local_config.merge(foo: { key: 'bar', secret: 'baz' }))
-    }
+    end
 
-    it "should complain but continue" do
+    it 'should complain but continue' do
       allow(Rails.logger).to receive(:warn).with('Unknown provider: foo')
       expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end

data/spec/unit/dropbox_spec.rb

@@ -6,113 +6,114 @@ describe BrowseEverything::Driver::Dropbox, vcr: { cassette_name: 'dropbox', rec
 
   let(:browser) { BrowseEverything::Browser.new(url_options) }
   let(:provider) { browser.providers['dropbox'] }
-  let(:auth_params) { {
+  let(:auth_params) do {
     'code' => 'FakeDropboxAuthorizationCodeABCDEFG',
     'state' => 'GjDcUhPNZrZzdsw%2FghBy2A%3D%3D|dropbox'
-  } }
-  let(:csrf_data) { {'token' => 'GjDcUhPNZrZzdsw%2FghBy2A%3D%3D'} }
+  }
+  end
+  let(:csrf_data) { { 'token' => 'GjDcUhPNZrZzdsw%2FghBy2A%3D%3D' } }
 
-  it "#validate_config" do
+  it '#validate_config' do
     expect { BrowseEverything::Driver::Dropbox.new({}) }.to raise_error(BrowseEverything::InitializationError)
   end
 
-  describe "simple properties" do
-    subject    { provider                 }
+  describe 'simple properties' do
+    subject    { provider }
     its(:name) { should == 'Dropbox'     }
     its(:key)  { should == 'dropbox'     }
-    its(:icon) { should be_a(String)      }
+    its(:icon) { should be_a(String) }
   end
 
-  context "authorization" do
+  context 'authorization' do
     subject { provider }
 
     specify { should_not be_authorized }
 
-    context "#auth_link" do
+    context '#auth_link' do
       specify { subject.auth_link[0].should start_with('https://www.dropbox.com/1/oauth2/authorize') }
       specify { subject.auth_link[0].should include('browse%2Fconnect') }
       specify { subject.auth_link[0].should include('state') }
     end
 
-    it "should authorize" do
-      subject.connect(auth_params,csrf_data)
+    it 'should authorize' do
+      subject.connect(auth_params, csrf_data)
       expect(subject).to be_authorized
     end
   end
 
-  describe "#contents" do
-    before(:each) { provider.connect(auth_params,csrf_data) }
+  describe '#contents' do
+    before(:each) { provider.connect(auth_params, csrf_data) }
 
-    context "root directory" do
+    context 'root directory' do
       let(:contents) { provider.contents('') }
-      context "[0]" do
+      context '[0]' do
         subject { contents[0] }
         its(:name) { should == 'Apps'    }
         specify    { should be_container }
       end
-      context "[1]" do
+      context '[1]' do
         subject { contents[1] }
         its(:name) { should == 'Books'   }
         specify    { should be_container }
       end
-      context "[4]" do
+      context '[4]' do
         subject { contents[4] }
-        its(:name)     { should == 'iPad intro.pdf'           }
-        its(:size)     { should == 208218                 }
-        its(:location) { should == "dropbox:/iPad intro.pdf" }
-        its(:type)     { should == "application/pdf"          }
+        its(:name)     { should == 'iPad intro.pdf' }
+        its(:size)     { should == 208218 }
+        its(:location) { should == 'dropbox:/iPad intro.pdf' }
+        its(:type)     { should == 'application/pdf'          }
         specify        { should_not be_container              }
       end
     end
 
-    context "subdirectory" do
+    context 'subdirectory' do
       let(:contents) { provider.contents('/Writer') }
-      context "[0]" do
+      context '[0]' do
         subject { contents[0] }
         its(:name) { should == '..'      }
         specify    { should be_container }
       end
-      context "[1]" do
+      context '[1]' do
         subject { contents[1] }
-        its(:name)     { should == 'About Writer.txt'      }
-        its(:location) { should == "dropbox:/Writer/About Writer.txt" }
-        its(:type)     { should == "text/plain"      }
+        its(:name)     { should == 'About Writer.txt' }
+        its(:location) { should == 'dropbox:/Writer/About Writer.txt' }
+        its(:type)     { should == 'text/plain'      }
         specify        { should_not be_container     }
       end
-      context "[2]" do
+      context '[2]' do
         subject { contents[2] }
-        its(:name)     { should == 'Markdown Test.txt'      }
-        its(:location) { should == "dropbox:/Writer/Markdown Test.txt" }
-        its(:type)     { should == "text/plain"      }
+        its(:name)     { should == 'Markdown Test.txt' }
+        its(:location) { should == 'dropbox:/Writer/Markdown Test.txt' }
+        its(:type)     { should == 'text/plain'      }
         specify        { should_not be_container     }
       end
-      context "[3]" do
+      context '[3]' do
         subject { contents[3] }
-        its(:name)     { should == 'Writer FAQ.txt'      }
-        its(:location) { should == "dropbox:/Writer/Writer FAQ.txt" }
-        its(:type)     { should == "text/plain"      }
+        its(:name)     { should == 'Writer FAQ.txt' }
+        its(:location) { should == 'dropbox:/Writer/Writer FAQ.txt' }
+        its(:type)     { should == 'text/plain'      }
         specify        { should_not be_container     }
       end
     end
 
-    context "#details" do
+    context '#details' do
       subject { provider.details('') }
-      its(:name) { should == 'Apps'    }
+      its(:name) { should == 'Apps' }
     end
   end
 
-  describe "#link_for" do
-    before(:each) { provider.connect(auth_params,csrf_data) }
+  describe '#link_for' do
+    before(:each) { provider.connect(auth_params, csrf_data) }
 
-    context "[0]" do
+    context '[0]' do
       subject { provider.link_for('/Writer/Writer FAQ.txt') }
-      specify { subject[0].should == "https://dl.dropboxusercontent.com/1/view/FakeDropboxAccessPath/Writer/Writer%20FAQ.txt" }
+      specify { subject[0].should == 'https://dl.dropboxusercontent.com/1/view/FakeDropboxAccessPath/Writer/Writer%20FAQ.txt' }
       specify { subject[1].should have_key(:expires) }
     end
 
-    context "[1]" do
+    context '[1]' do
       subject { provider.link_for('/Writer/Markdown Test.txt') }
-      specify { subject[0].should == "https://dl.dropboxusercontent.com/1/view/FakeDropboxAccessPath/Writer/Markdown%20Test.txt" }
+      specify { subject[0].should == 'https://dl.dropboxusercontent.com/1/view/FakeDropboxAccessPath/Writer/Markdown%20Test.txt' }
       specify { subject[1].should have_key(:expires) }
     end
   end

data/spec/unit/file_entry_spec.rb

@@ -1,88 +1,88 @@
 describe BrowseEverything::FileEntry do
   let(:mtime) { Time.now }
-  describe "regular file" do
-    subject {
+  describe 'regular file' do
+    subject do
       BrowseEverything::FileEntry.new(
         'file_id_01234', 'my_provider:/location/pa/th/file.m4v',
         'file.m4v', '1.2 GB', mtime, false
       )
-    }
+    end
 
-    it "should be a BrowseEverything::FileEntry" do
+    it 'should be a BrowseEverything::FileEntry' do
       expect(subject).to be_a BrowseEverything::FileEntry
     end
 
-    it "#id" do
-      expect(subject.id).to eq("file_id_01234")
+    it '#id' do
+      expect(subject.id).to eq('file_id_01234')
     end
 
-    it "#location" do
-      expect(subject.location).to eq("my_provider:/location/pa/th/file.m4v")
+    it '#location' do
+      expect(subject.location).to eq('my_provider:/location/pa/th/file.m4v')
     end
 
-    it "#name" do
-      expect(subject.name).to eq("file.m4v")
+    it '#name' do
+      expect(subject.name).to eq('file.m4v')
     end
 
-    it "#size" do
-      expect(subject.size).to eq("1.2 GB")
+    it '#size' do
+      expect(subject.size).to eq('1.2 GB')
     end
 
-    it "#mtime" do
+    it '#mtime' do
       expect(subject.mtime).to eq(mtime)
     end
 
-    it "#type" do
-      expect(subject.type).to eq("video/mp4")
+    it '#type' do
+      expect(subject.type).to eq('video/mp4')
     end
 
-    it "#container?" do
+    it '#container?' do
       expect(subject.container?).to be false
     end
 
-    it "#relative_parent_path?" do
+    it '#relative_parent_path?' do
       expect(subject.relative_parent_path?).to be false
     end
   end
 
-  describe "directory" do
-    subject {
+  describe 'directory' do
+    subject do
       BrowseEverything::FileEntry.new(
         'directory_id_1234', 'my_provider:/location/pa/th',
         'th', '', mtime, true
       )
-    }
+    end
 
-    it "#type" do
-      expect(subject.type).to eq("application/x-directory")
+    it '#type' do
+      expect(subject.type).to eq('application/x-directory')
     end
 
-    it "#container?" do
+    it '#container?' do
       expect(subject.container?).to be true
     end
 
-    it "#relative_parent_path?" do
+    it '#relative_parent_path?' do
       expect(subject.relative_parent_path?).to be false
     end
   end
 
-  describe "parent path" do
-    subject {
+  describe 'parent path' do
+    subject do
       BrowseEverything::FileEntry.new(
         'directory_id_1234', 'my_provider:/location/pa/th',
         '..', '', mtime, true
       )
-    }
+    end
 
-    it "#type" do
-      expect(subject.type).to eq("application/x-directory")
+    it '#type' do
+      expect(subject.type).to eq('application/x-directory')
     end
 
-    it "#container?" do
+    it '#container?' do
       expect(subject.container?).to be true
     end
 
-    it "#relative_parent_path?" do
+    it '#relative_parent_path?' do
       expect(subject.relative_parent_path?).to be true
     end
   end

data/spec/unit/file_system_spec.rb

@@ -7,11 +7,11 @@ describe BrowseEverything::Driver::FileSystem do
   let(:browser) { BrowseEverything::Browser.new(url_options) }
   let(:provider) { browser.providers['file_system'] }
 
-  it "#validate_config" do
+  it '#validate_config' do
     expect { BrowseEverything::Driver::FileSystem.new({}) }.to raise_error(BrowseEverything::InitializationError)
   end
 
-  describe "simple properties" do
+  describe 'simple properties' do
     subject    { provider                }
     its(:name) { should == 'File System' }
     its(:key)  { should == 'file_system' }
@@ -19,66 +19,66 @@ describe BrowseEverything::Driver::FileSystem do
     specify    { should be_authorized    }
   end
 
-  describe "#contents" do
-    context "root directory" do
+  describe '#contents' do
+    context 'root directory' do
       let(:contents) { provider.contents('/') }
-      context "[0]" do
+      context '[0]' do
         subject { contents[0] }
         its(:name) { should == 'dir_1'   }
         specify    { should be_container }
       end
-      context "[1]" do
+      context '[1]' do
         subject { contents[1] }
         its(:name) { should == 'dir_2'   }
         specify    { should be_container }
       end
-      context "[2]" do
+      context '[2]' do
         subject { contents[2] }
         its(:name)     { should == 'file 1.pdf'              }
         its(:size)     { should == 2256                      }
-        its(:location) { should == "file_system:#{File.join(home,'file 1.pdf')}" }
-        its(:type)     { should == "application/pdf"         }
+        its(:location) { should == "file_system:#{File.join(home, 'file 1.pdf')}" }
+        its(:type)     { should == 'application/pdf'         }
         specify        { should_not be_container             }
       end
-      context "[3]" do
+      context '[3]' do
         subject { contents[3] }
         its(:name)     { should == 'file_1.pdf'              }
         its(:size)     { should == 2256                      }
-        its(:location) { should == "file_system:#{File.join(home,'file_1.pdf')}" }
-        its(:type)     { should == "application/pdf"         }
+        its(:location) { should == "file_system:#{File.join(home, 'file_1.pdf')}" }
+        its(:type)     { should == 'application/pdf'         }
         specify        { should_not be_container             }
       end
-     end
+    end
 
-    context "subdirectory" do
+    context 'subdirectory' do
       let(:contents) { provider.contents('/dir_1') }
-      context "[0]" do
+      context '[0]' do
         subject { contents[0] }
         its(:name) { should == '..'      }
         specify    { should be_container }
       end
-      context "[1]" do
+      context '[1]' do
         subject { contents[1] }
         its(:name) { should == 'dir_3'   }
         specify    { should be_container }
       end
-      context "[2]" do
+      context '[2]' do
         subject { contents[2] }
-        its(:name)     { should == 'file_2.txt'      }
-        its(:location) { should == "file_system:#{File.join(home,'dir_1/file_2.txt')}" }
-        its(:type)     { should == "text/plain"      }
+        its(:name)     { should == 'file_2.txt' }
+        its(:location) { should == "file_system:#{File.join(home, 'dir_1/file_2.txt')}" }
+        its(:type)     { should == 'text/plain'      }
         specify        { should_not be_container     }
       end
     end
 
-    context "single file" do
+    context 'single file' do
       let(:contents) { provider.contents('/dir_1/dir_3/file_3.m4v') }
-      context "[0]" do
+      context '[0]' do
         subject { contents[0] }
-        its(:name)     { should == 'file_3.m4v'      }
-        its(:location) { should == "file_system:#{File.join(home,'dir_1/dir_3/file_3.m4v')}" }
+        its(:name)     { should == 'file_3.m4v' }
+        its(:location) { should == "file_system:#{File.join(home, 'dir_1/dir_3/file_3.m4v')}" }
         its(:size)     { should == 3879              }
-        its(:type)     { should == "video/mp4"       }
+        its(:type)     { should == 'video/mp4'       }
         specify        { should_not be_container     }
       end
     end
@@ -86,6 +86,6 @@ describe BrowseEverything::Driver::FileSystem do
 
   describe "#link_for('/path/to/file')" do
     subject { provider.link_for('/path/to/file') }
-    it { should == ["file:///path/to/file", {:file_name=>"file", :file_size=>0}] }
+    it { should == ['file:///path/to/file', { file_name: 'file', file_size: 0 }] }
   end
 end