browse-everything 0.10.5 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ecf1f6e239a55eaca19d11c80ba83cb833df9ac
-  data.tar.gz: 59e99e140a5520feb8345928b7080b90b4ad914b
+  metadata.gz: bd86609268e38b37eda9ee75faf2f90e5fef7637
+  data.tar.gz: a400f9f867fd8e000161e0af09eed01289c03e7c
 SHA512:
-  metadata.gz: b8b0e5d8b7f8705cf017530760bb12a73a23e4217c452c07dc33f5bf1e449085353df70bbf9567fe5d239d5f21cde4abf2a213385874ab2b43c705e5d951430e
-  data.tar.gz: dc27c56cd04044728ef80665eb8f5c9e500db68904e2b36c98248086c456649fdf8a48378a7a419a899ebc1dad8b75c7aea6ab0f01b58593c8dff0ede70b62bc
+  metadata.gz: 49c3014931d7a17505ddc3ce40ea8eff8d8380eeb4f4b3fb6936be68f25f974857fe5b5068e6f44a0bc1d3cf5f3a433a39b77bf39a2fcd0b2648d8d058b21464
+  data.tar.gz: 33074434868353d2f5a92bfcdf1cf9deaf97587597a66c97f9e6a76d50a978a922f62c27fd8f5ef71d747f05411a093ca558283c156b030c3aac491f601b1263

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+.DS_Store
 Gemfile.lock
 InstalledFiles
 _yardoc

data/.rubocop.yml

@@ -0,0 +1,16 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Exclude:
+    - db/migrate/**
+    - db/schema.rb
+
+Rails:
+  Enabled: true
+
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 180
+
+Style/NumericLiterals:
+  MinDigits: 7

data/.rubocop_todo.yml

@@ -0,0 +1,149 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-09-28 11:47:17 -0700 using RuboCop version 0.42.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Lint/Loop:
+  Exclude:
+    - 'lib/browse_everything/driver/google_drive.rb'
+
+# Offense count: 10
+Metrics/AbcSize:
+  Max: 32
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 101
+
+# Offense count: 3
+Metrics/CyclomaticComplexity:
+  Max: 7
+
+# Offense count: 14
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 26
+
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 7
+
+# Offense count: 1
+Metrics/PerceivedComplexity:
+  Max: 9
+
+# Offense count: 1
+Rails/OutputSafety:
+  Exclude:
+    - 'app/helpers/browse_everything_helper.rb'
+
+# Offense count: 14
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
+  Exclude:
+    - 'lib/browse_everything/driver/box.rb'
+    - 'lib/browse_everything/driver/dropbox.rb'
+    - 'lib/browse_everything/driver/google_drive.rb'
+    - 'lib/browse_everything/driver/sky_drive.rb'
+    - 'lib/browse_everything/retriever.rb'
+    - 'spec/unit/browse_everything_helper_spec.rb'
+    - 'spec/unit/file_entry_spec.rb'
+    - 'spec/unit/retriever_spec.rb'
+    - 'spec/unit/sky_drive_spec.rb'
+    - 'spec/views/browse_everything/_file.html.erb_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'lib/generators/browse_everything/assets_generator.rb'
+    - 'lib/generators/browse_everything/config_generator.rb'
+    - 'lib/generators/browse_everything/install_generator.rb'
+
+# Offense count: 18
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
+Style/FileName:
+  Exclude:
+    - 'lib/browse-everything.rb'
+
+# Offense count: 5
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/browse_everything/driver/box.rb'
+    - 'lib/browse_everything/driver/dropbox.rb'
+    - 'lib/browse_everything/driver/file_system.rb'
+    - 'lib/browse_everything/driver/google_drive.rb'
+    - 'lib/browse_everything/driver/sky_drive.rb'
+
+# Offense count: 1
+Style/MultilineBlockChain:
+  Exclude:
+    - 'lib/browse_everything/driver/google_drive.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MultilineBlockLayout:
+  Exclude:
+    - 'spec/unit/dropbox_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: symmetrical, new_line, same_line
+Style/MultilineHashBraceLayout:
+  Exclude:
+    - 'spec/unit/sky_drive_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented, indented_relative_to_receiver
+Style/MultilineMethodCallIndentation:
+  Exclude:
+    - 'spec/unit/sky_drive_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/helpers/browse_everything_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/browse_everything/driver/box.rb'
+    - 'lib/browse_everything/driver/dropbox.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Exclude:
+    - 'lib/browse_everything/driver/file_system.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  Exclude:
+    - 'browse-everything.gemspec'

data/.travis.yml

@@ -4,7 +4,6 @@ cache:
   bundler: true
   directories:
     - "travis_phantomjs"
-
 before_install:
   - "phantomjs --version"
   - "export PATH=$PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH"
@@ -14,20 +13,20 @@ before_install:
   - "if [ $(phantomjs --version) != '2.1.1' ]; then tar -xvf $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis_phantomjs; fi"
   - "phantomjs --version"
 rvm:
-  - 2.2
+  - "2.2.2"
+# rack 2 requires Ruby version >= 2.2.2
 env:
   global:
     - NOKOGIRI_USE_SYSTEM_LIBRARIES=true
   matrix:
     - "RAILS_VERSION=4.1.10"
     - "RAILS_VERSION=4.2.1"
-
+    - "RAILS_VERSION=5.0.0.1"
 matrix:
   include:
+    - rvm: "2.3.0"
+      env: "RAILS_VERSION=5.0.0.1"
     - rvm: 2.1
       env: "RAILS_VERSION=4.2.1"
     - rvm: 2.0
       env: "RAILS_VERSION=4.2.1"
-
-notifications:
-  irc: "irc.freenode.org#projecthydra"

data/Rakefile

@@ -1,5 +1,5 @@
 #!/usr/bin/env rake
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 
 Dir.glob('tasks/*.rake').each { |r| import r }
 
@@ -15,4 +15,4 @@ task :setup_test_server do
   EngineCart.load_application!
 end
 
-task :default => [:ci]
+task default: [:ci]

data/app/controllers/browse_everything_controller.rb

@@ -1,36 +1,35 @@
-require File.expand_path('../../helpers/browse_everything_helper',__FILE__)
+require File.expand_path('../../helpers/browse_everything_helper', __FILE__)
 
 class BrowseEverythingController < ActionController::Base
   layout 'browse_everything'
   helper BrowseEverythingHelper
 
-  after_filter {session["#{provider_name}_token"] = provider.token unless provider.nil? }
-  
+  after_action { session["#{provider_name}_token"] = provider.token unless provider.nil? }
+
   def index
-    render :layout => !request.xhr?
+    render layout: !request.xhr?
   end
 
   def show
-    render :layout => !request.xhr?
+    render layout: !request.xhr?
   end
-  
+
   def auth
-    code = params[:code]
-    session["#{provider_name}_token"] = provider.connect(params,session["#{provider_name}_data"])
+    session["#{provider_name}_token"] = provider.connect(params, session["#{provider_name}_data"])
   end
 
   def resolve
     selected_files = params[:selected_files] || []
-    @links = selected_files.collect { |file| 
-      p,f = file.split(/:/) 
-      (url,extra) = browser.providers[p].link_for(f)
+    @links = selected_files.collect do |file|
+      p, f = file.split(/:/)
+      (url, extra) = browser.providers[p].link_for(f)
       result = { url: url }
       result.merge!(extra) unless extra.nil?
       result
-    }
-    respond_to do |format|  
-      format.html { render :layout => false }
-      format.json { render :json => @links }
+    end
+    respond_to do |format|
+      format.html { render layout: false }
+      format.json { render json: @links }
     end
   end
 
@@ -38,13 +37,11 @@ class BrowseEverythingController < ActionController::Base
 
   def auth_link
     @auth_link ||= if provider.present?
-      link, data = provider.auth_link
-      session["#{provider_name}_data"] = data
-      link = "#{link}&state=#{provider.key}" unless link.include?("state")
-      link
-    else
-      nil
-    end
+                     link, data = provider.auth_link
+                     session["#{provider_name}_data"] = data
+                     link = "#{link}&state=#{provider.key}" unless link.to_s.include?('state')
+                     link
+                   end # else nil, implicitly
   end
 
   def browser

data/app/helpers/bootstrap_version_helper.rb

@@ -1,35 +1,33 @@
 module BootstrapVersionHelper
-
   def bootstrap_three?
     Bundler.environment.specs['bootstrap-sass'].first.version >= Gem::Version.new('3')
   end
 
   def bs2(if2)
-    bs2or3(if2,'')
+    bs2or3(if2, '')
   end
 
   def bs3(if3)
-    bs2or3('',if3)
+    bs2or3('', if3)
   end
 
-  def bs2or3(if2,if3)
+  def bs2or3(if2, if3)
     bootstrap_three? ? if3 : if2
   end
 
   def font_awesome_four?
     Bundler.environment.specs['font-awesome-rails'].first.version >= Gem::Version.new('4')
   end
-  
+
   def fa3(if3)
-    fa3or4(if3,'')
+    fa3or4(if3, '')
   end
-  
+
   def fa4(if4)
-    fa3or4('',if4)
+    fa3or4('', if4)
   end
-  
-  def fa3or4(if3,if4)
+
+  def fa3or4(if3, if4)
     font_awesome_four? ? if4 : if3
   end
-
 end

data/app/helpers/browse_everything_helper.rb

@@ -1,36 +1,25 @@
 module BrowseEverythingHelper
-
-  def array_to_hidden_fields(array,key)
+  def array_to_hidden_fields(array, key)
     fields = array.to_query(key).split(Rack::Utils::DEFAULT_SEP).collect do |pair|
-      key,value=pair.split('=', 2).map { |str| Rack::Utils.unescape(str) }
-      hidden_field_tag(key,value)
+      key, value = pair.split('=', 2).map { |str| Rack::Utils.unescape(str) }
+      hidden_field_tag(key, value)
     end
     fields.join("\n").html_safe
   end
 
-  # Extracted from Rack::Mime 1.5.2 for use with earlier versions
-  # of Rack/Rails
+  # Extracted from Rack::Mime 1.5.2 for use with earlier versions of Rack/Rails
+  # @param [String] value
+  # @param [String] matcher
+  # @return [TrueClass,FalseClass]
   def mime_match?(value, matcher)
     v1, v2 = value.split('/', 2)
     m1, m2 = matcher.split('/', 2)
-
-    if m1 == '*'
-      if m2.nil? || m2 == '*'
-        return true
-      elsif m2 == v2
-        return true
-      else
-        return false
-      end
-    end
-
-    return false if v1 != m1
-
-    return true if m2.nil? || m2 == '*'
-
-    m2 == v2
+    return false if m1 != '*' && v1 != m1
+    m2.nil? || m2 == '*' || m2 == v2
   end
 
+  # @param [BrowseEverything::FileEntry] file
+  # @return [TrueClass,FalseClass]
   def is_acceptable?(file)
     acceptable = params[:accept] || '*/*'
     acceptable_types = acceptable.split(/,\s*/)

data/app/views/browse_everything/_file.html.erb

@@ -1,13 +1,10 @@
-<% unless file.relative_parent_path? %>
-
-  <% if file.container? || provider.config[:max_upload_file_size].blank? #never disable a folder or if no maximum is set
-     disabled = false
-   else
-     max_size = provider.config[:max_upload_file_size].to_i
-     disabled = file.size > max_size
-   end
-  %>
-
+<% if file.container? || provider.config[:max_upload_file_size].blank? # never disable a folder or if no maximum is set
+   disabled = false
+ else
+   max_size = provider.config[:max_upload_file_size].to_i
+   disabled = file.size > max_size
+ end
+%>
 <tr role="row" tabindex="-1" data-ev-location="<%= file.location %>" data-tt-id="<%=path%>" data-tt-parent-id="<%=parent%>" data-tt-branch="<%=file.container? ? 'true' : 'false'%>">
   <td role="gridcell" class="<%=file.container? ? 'ev-container' : 'ev-file'%> ev-file-name">
     <% if disabled %>
@@ -36,4 +33,3 @@
     <%= file.mtime.strftime('%F %R') %>
   </td>
 </tr>
-<% end %>

data/app/views/browse_everything/_files.html.erb

@@ -1,4 +1,3 @@
-<% if provider.present? %>
   <div class="progress" id="loading_progress" aria-live="polite">
     <div class="progress-bar" role="progressbar" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100" style="width: 100%;">
       100% Complete
@@ -14,11 +13,9 @@
         <th role="columnheader">Modified</th>
       </tr>
     </thead>
-    <% provider.contents(browse_path).each_with_index do |file,index| %>
-      <% if is_acceptable?(file) %>
-        <%= render :partial => 'file', :locals => { :file => file, :index => index, 
-          :path => browse_everything_engine.contents_path(provider_name,file.id), :parent => params[:parent] } %>
-      <% end %>
+    <% provider.contents(browse_path).each_with_index do |file, index| %>
+      <% next if file.relative_parent_path? %>
+      <%= render :partial => 'file', :locals => { :file => file, :index => index,
+        :path => browse_everything_engine.contents_path(provider_name, file.id), :parent => params[:parent] } %>
     <% end %>
   </table>
-<% end %>