briard 2.4.2 → 2.6.0

data/lib/briard/readers/bibtex_reader.rb

@@ -3,97 +3,97 @@
 module Briard
   module Readers
     module BibtexReader
-      BIB_TO_CP_TRANSLATIONS = {
-        "article" => "article-journal",
-        "phdthesis" => "thesis"
-      }
+      BIB_TO_CP_TRANSLATIONS = { 'article' => 'article-journal', 'phdthesis' => 'thesis' }.freeze
 
       BIB_TO_RIS_TRANSLATIONS = {
-        "article" => "JOUR",
-        "book" => "BOOK",
-        "inbook" => "CHAP",
-        "inproceedings" => "CPAPER",
-        "manual" => nil,
-        "misc" => "GEN",
-        "phdthesis" => "THES",
-        "proceedings" => "CONF",
-        "techreport" => "RPRT",
-        "unpublished" => "UNPD"
-      }
+        'article' => 'JOUR',
+        'book' => 'BOOK',
+        'inbook' => 'CHAP',
+        'inproceedings' => 'CPAPER',
+        'manual' => nil,
+        'misc' => 'GEN',
+        'phdthesis' => 'THES',
+        'proceedings' => 'CONF',
+        'techreport' => 'RPRT',
+        'unpublished' => 'UNPD'
+      }.freeze
 
-      BIB_TO_SO_TRANSLATIONS = {
-        "article" => "ScholarlyArticle",
-        "phdthesis" => "Thesis"
-      }
+      BIB_TO_SO_TRANSLATIONS = { 'article' => 'ScholarlyArticle', 'phdthesis' => 'Thesis' }.freeze
 
       def read_bibtex(string: nil, **options)
-        read_options = ActiveSupport::HashWithIndifferentAccess.new(options.except(:doi, :id, :url, :sandbox, :validate, :ra))
+        read_options = ActiveSupport::HashWithIndifferentAccess.new(options.except(:doi, :id, :url,
+                                                                                   :sandbox, :validate, :ra))
 
         meta = string.present? ? BibTeX.parse(string).first : OpenStruct.new
 
         bibtex_type = meta.try(:type).to_s
-        schema_org = BIB_TO_SO_TRANSLATIONS[bibtex_type] || "ScholarlyArticle"
+        schema_org = BIB_TO_SO_TRANSLATIONS[bibtex_type] || 'ScholarlyArticle'
         types = {
-          "resourceTypeGeneral" => Metadata::BIB_TO_DC_TRANSLATIONS[bibtex_type],
-          "resourceType" => Briard::Utils::BIB_TO_CR_TRANSLATIONS[meta.try(:type).to_s] || meta.try(:type).to_s,
-          "schemaOrg" => schema_org,
-          "bibtex" => bibtex_type,
-          "citeproc" => BIB_TO_CP_TRANSLATIONS[meta.try(:type).to_s] || "misc",
-          "ris" => BIB_TO_RIS_TRANSLATIONS[meta.try(:type).to_s] || "GEN"
+          'resourceTypeGeneral' => Metadata::BIB_TO_DC_TRANSLATIONS[bibtex_type],
+          'resourceType' => Briard::Utils::BIB_TO_CR_TRANSLATIONS[meta.try(:type).to_s] || meta.try(:type).to_s,
+          'schemaOrg' => schema_org,
+          'bibtex' => bibtex_type,
+          'citeproc' => BIB_TO_CP_TRANSLATIONS[meta.try(:type).to_s] || 'misc',
+          'ris' => BIB_TO_RIS_TRANSLATIONS[meta.try(:type).to_s] || 'GEN'
         }.compact
         doi = meta.try(:doi).to_s.presence || options[:doi]
 
         creators = Array(meta.try(:author)).map do |a|
-          { "nameType" => "Personal",
-            "name" => [a.last, a.first].join(", "),
-            "givenName" => a.first,
-            "familyName" => a.last }.compact
+          { 'nameType' => 'Personal',
+            'name' => [a.last, a.first].join(', '),
+            'givenName' => a.first,
+            'familyName' => a.last }.compact
         end
 
         related_identifiers = if meta.try(:journal).present? && meta.try(:issn).to_s.presence
-                                [{ "type" => "Periodical",
-                                  "relationType" => "IsPartOf",
-                                  "relatedIdentifierType" => "ISSN",
-                                  "title" => meta.journal.to_s,
-                                  "relatedIdentifier" => meta.try(:issn).to_s.presence }.compact]
+                                [{ 'type' => 'Periodical',
+                                   'relationType' => 'IsPartOf',
+                                   'relatedIdentifierType' => 'ISSN',
+                                   'title' => meta.journal.to_s,
+                                   'relatedIdentifier' => meta.try(:issn).to_s.presence }.compact]
                               end
 
         container = if meta.try(:journal).present?
-                      first_page = meta.try(:pages).present? ? meta.try(:pages).split("-").map(&:strip)[0] : nil
-                      last_page = meta.try(:pages).present? ? meta.try(:pages).split("-").map(&:strip)[1] : nil
+                      first_page = meta.try(:pages).present? ? meta.try(:pages).split('-').map(&:strip)[0] : nil
+                      last_page = meta.try(:pages).present? ? meta.try(:pages).split('-').map(&:strip)[1] : nil
 
-                      { "type" => "Journal",
-                        "title" => meta.journal.to_s,
-                        "identifier" => meta.try(:issn).to_s.presence,
-                        "identifierType" => meta.try(:issn).present? ? "ISSN" : nil,
-                        "volume" => meta.try(:volume).to_s.presence,
-                        "firstPage" => first_page,
-                        "lastPage" => last_page }.compact
+                      { 'type' => 'Journal',
+                        'title' => meta.journal.to_s,
+                        'identifier' => meta.try(:issn).to_s.presence,
+                        'identifierType' => meta.try(:issn).present? ? 'ISSN' : nil,
+                        'volume' => meta.try(:volume).to_s.presence,
+                        'firstPage' => first_page,
+                        'lastPage' => last_page }.compact
                     end
 
-        state = meta.try(:doi).to_s.present? || read_options.present? ? "findable" : "not_found"
+        state = meta.try(:doi).to_s.present? || read_options.present? ? 'findable' : 'not_found'
         dates = if meta.try(:date).present? && Date.edtf(meta.date.to_s).present?
-                  [{ "date" => meta.date.to_s,
-                    "dateType" => "Issued" }]
+                  [{ 'date' => meta.date.to_s,
+                     'dateType' => 'Issued' }]
                 end
-        publication_year =  meta.try(:date).present? ? meta.date.to_s[0..3] : nil
-        rights_list = meta.try(:copyright).present? ? [hsh_to_spdx("rightsURI" => meta[:copyright])] : []
+        publication_year = meta.try(:date).present? ? meta.date.to_s[0..3] : nil
+        rights_list = meta.try(:copyright).present? ? [hsh_to_spdx('rightsURI' => meta[:copyright])] : []
 
-        { "id" => normalize_doi(doi),
-          "types" => types,
-          "doi" => doi,
-          "url" => meta.try(:url).to_s.presence,
-          "titles" => meta.try(:title).present? ? [{ "title" => meta.try(:title).to_s }] : [],
-          "creators" => creators,
-          "container" => container,
-          "publisher" => meta.try(:publisher).to_s.presence,
-          "related_identifiers" => related_identifiers,
-          "dates" => dates,
-          "publication_year" => publication_year,
-          "descriptions" => meta.try(:abstract).present? ? [{ "description" => meta.try(:abstract) && sanitize(meta.abstract.to_s).presence, "descriptionType" => "Abstract" }] : [],
-          "rights_list" => rights_list,
-          "state" => state
-        }.merge(read_options)
+        { 'id' => normalize_doi(doi),
+          'types' => types,
+          'doi' => doi,
+          'url' => meta.try(:url).to_s.presence,
+          'titles' => meta.try(:title).present? ? [{ 'title' => meta.try(:title).to_s }] : [],
+          'creators' => creators,
+          'container' => container,
+          'publisher' => meta.try(:publisher).to_s.presence,
+          'related_identifiers' => related_identifiers,
+          'dates' => dates,
+          'publication_year' => publication_year,
+          'descriptions' => if meta.try(:abstract).present?
+                              [{
+                                'description' => meta.try(:abstract) && sanitize(meta.abstract.to_s).presence, 'descriptionType' => 'Abstract'
+                              }]
+                            else
+                              []
+                            end,
+          'rights_list' => rights_list,
+          'state' => state }.merge(read_options)
       end
     end
   end

data/lib/briard/readers/cff_reader.rb

@@ -3,119 +3,137 @@
 module Briard
   module Readers
     module CffReader
-      def get_cff(id: nil, **options)
-        return { "string" => nil, "state" => "not_found" } unless id.present?
+      def get_cff(id: nil, **_options)
+        return { 'string' => nil, 'state' => 'not_found' } unless id.present?
+
         id = normalize_id(id)
-        response = Maremma.get(github_as_cff_url(id), accept: "json", raw: true)
-        data = response.body.fetch("data", nil)
+        response = Maremma.get(github_as_cff_url(id), accept: 'json', raw: true)
+        data = response.body.fetch('data', nil)
         # Dates are parsed to date object, need to convert to iso8601 later
         string = Psych.safe_load(data, permitted_classes: [Date])
-        { "string" => string }
+        { 'string' => string }
       end
 
       def read_cff(string: nil, **options)
-        read_options = ActiveSupport::HashWithIndifferentAccess.new(options.except(:doi, :id, :url, :sandbox, :validate, :ra))
+        read_options = ActiveSupport::HashWithIndifferentAccess.new(options.except(:doi, :id, :url,
+                                                                                   :sandbox, :validate, :ra))
         meta = string.is_a?(String) ? Psych.safe_load(string, permitted_classes: [Date]) : string
 
-        identifiers = Array.wrap(meta.fetch("identifiers", nil)).map do |r|
+        identifiers = Array.wrap(meta.fetch('identifiers', nil)).map do |r|
           r = normalize_id(r) if r.is_a?(String)
-          if r.is_a?(String) && !r.start_with?("https://doi.org")
-              { "identifierType" => "URL", "identifier" => r }
+          if r.is_a?(String) && URI(r).host != 'doi.org'
+            { 'identifierType' => 'URL', 'identifier' => r }
           elsif r.is_a?(Hash)
-            { "identifierType" => get_identifier_type(r["propertyID"]), "identifier" => r["value"] }
+            { 'identifierType' => get_identifier_type(r['propertyID']), 'identifier' => r['value'] }
           end
         end.compact.uniq
 
-        id = normalize_id(options[:doi] || meta.fetch("doi", nil) || Array.wrap(meta.fetch("identifiers", nil)).find { |i| i["type"] == "doi"}.fetch("value", nil))
-        url = normalize_id(meta.fetch("repository-code", nil))
-        creators = cff_creators(Array.wrap(meta.fetch("authors", nil)))
+        id = normalize_id(options[:doi] || meta.fetch('doi',
+                                                      nil) || Array.wrap(meta.fetch('identifiers', nil)).find do |i|
+                                                                i['type'] == 'doi'
+                                                              end.fetch('value', nil))
+        url = normalize_id(meta.fetch('repository-code', nil))
+        creators = cff_creators(Array.wrap(meta.fetch('authors', nil)))
 
         dates = []
-        dates << { "date" => meta.fetch("date-released", nil).iso8601, "dateType" => "Issued" } if meta.fetch("date-released", nil).present?
-        publication_year = meta.fetch("date-released").iso8601[0..3] if meta.fetch("date-released", nil).present?
-        publisher = url.to_s.starts_with?("https://github.com") ? "GitHub" : nil
-        state = meta.present? || read_options.present? ? "findable" : "not_found"
+        if meta.fetch('date-released', nil).present?
+          dates << { 'date' => meta.fetch('date-released', nil).iso8601, 'dateType' => 'Issued' }
+        end
+        publication_year = meta.fetch('date-released').iso8601[0..3] if meta.fetch('date-released',
+                                                                                   nil).present?
+        publisher = url.to_s.starts_with?('https://github.com') ? 'GitHub' : nil
+        state = meta.present? || read_options.present? ? 'findable' : 'not_found'
         types = {
-          "resourceTypeGeneral" => "Software",
-          "resourceType" => nil,
-          "schemaOrg" => "SoftwareSourceCode",
-          "citeproc" => "article-journal",
-          "bibtex" => "misc",
-          "ris" => "COMP"
+          'resourceTypeGeneral' => 'Software',
+          'resourceType' => nil,
+          'schemaOrg' => 'SoftwareSourceCode',
+          'citeproc' => 'article-journal',
+          'bibtex' => 'misc',
+          'ris' => 'COMP'
         }.compact
-        subjects = Array.wrap(meta.fetch("keywords", nil)).reduce([]) do |sum, subject|
+        subjects = Array.wrap(meta.fetch('keywords', nil)).reduce([]) do |sum, subject|
           sum += name_to_fos(subject)
 
           sum
         end
 
-        titles =  meta.fetch("title", nil).present? ?  [{ "title" => meta.fetch("title", nil) }] : []
-        related_identifiers = Array.wrap(cff_references(meta.fetch("references", nil)))
-        rights_list = meta.fetch("license", nil).present? ? [hsh_to_spdx("rightsIdentifier" => meta.fetch("license"))] : nil
+        titles = if meta.fetch('title', nil).present?
+                   [{ 'title' => meta.fetch('title', nil) }]
+                 else
+                   []
+                 end
+        related_identifiers = Array.wrap(cff_references(meta.fetch('references', nil)))
+        rights_list = if meta.fetch('license', nil).present?
+                        [hsh_to_spdx('rightsIdentifier' => meta.fetch('license'))]
+                      end
 
-        { "id" => id,
-          "types" => types,
-          "identifiers" => identifiers,
-          "doi" => doi_from_url(id),
-          "url" => url,
-          "titles" => titles,
-          "creators" => creators,
-          "publisher" => publisher,
-          "related_identifiers" => related_identifiers,
-          "dates" => dates,
-          "publication_year" => publication_year,
-          "descriptions" => meta.fetch("abstract", nil).present? ? [{ "description" => sanitize(meta.fetch("abstract")), "descriptionType" => "Abstract" }] : nil,
-          "rights_list" => rights_list,
-          "version_info" => meta.fetch("version", nil),
-          "subjects" => subjects,
-          "state" => state
-        }.merge(read_options)
+        { 'id' => id,
+          'types' => types,
+          'identifiers' => identifiers,
+          'doi' => doi_from_url(id),
+          'url' => url,
+          'titles' => titles,
+          'creators' => creators,
+          'publisher' => publisher,
+          'related_identifiers' => related_identifiers,
+          'dates' => dates,
+          'publication_year' => publication_year,
+          'descriptions' => if meta.fetch('abstract', nil).present?
+                              [{ 'description' => sanitize(meta.fetch('abstract')),
+                                 'descriptionType' => 'Abstract' }]
+                            end,
+          'rights_list' => rights_list,
+          'version_info' => meta.fetch('version', nil),
+          'subjects' => subjects,
+          'state' => state }.merge(read_options)
       end
 
       def cff_creators(creators)
         Array.wrap(creators).map do |a|
-          name_identifiers = normalize_orcid(parse_attributes(a["orcid"])).present? ? [{ "nameIdentifier" => normalize_orcid(parse_attributes(a["orcid"])), "nameIdentifierScheme" => "ORCID", "schemeUri"=>"https://orcid.org" }] : nil
-          if a["given-names"].present? || a["family-names"].present? || name_identifiers.present?
-            given_name = parse_attributes(a["given-names"])
-            family_name = parse_attributes(a["family-names"])
-            affiliation = Array.wrap(a["affiliation"]).map do |a|
+          name_identifiers = if normalize_orcid(parse_attributes(a['orcid'])).present?
+                               [{
+                                 'nameIdentifier' => normalize_orcid(parse_attributes(a['orcid'])), 'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org'
+                               }]
+                             end
+          if a['given-names'].present? || a['family-names'].present? || name_identifiers.present?
+            given_name = parse_attributes(a['given-names'])
+            family_name = parse_attributes(a['family-names'])
+            affiliation = Array.wrap(a['affiliation']).map do |a|
               if a.is_a?(Hash)
                 a
-              elsif a.is_a?(Hash) && a.key?("__content__") && a["__content__"].strip.blank?
+              elsif a.is_a?(Hash) && a.key?('__content__') && a['__content__'].strip.blank?
                 nil
-              elsif a.is_a?(Hash) && a.key?("__content__")
-                { "name" => a["__content__"] }
+              elsif a.is_a?(Hash) && a.key?('__content__')
+                { 'name' => a['__content__'] }
               elsif a.strip.blank?
                 nil
               elsif a.is_a?(String)
-                { "name" => a }
+                { 'name' => a }
               end
             end.compact
 
-            { "nameType" => "Personal",
-              "nameIdentifiers" => name_identifiers,
-              "name" => [family_name, given_name].compact.join(", "),
-              "givenName" => given_name,
-              "familyName" => family_name,
-              "affiliation" => affiliation.presence }.compact
+            { 'nameType' => 'Personal',
+              'nameIdentifiers' => name_identifiers,
+              'name' => [family_name, given_name].compact.join(', '),
+              'givenName' => given_name,
+              'familyName' => family_name,
+              'affiliation' => affiliation.presence }.compact
           else
-            { "nameType" => "Organizational",
-              "name" => a["name"] || a["__content__"] }
+            { 'nameType' => 'Organizational',
+              'name' => a['name'] || a['__content__'] }
           end
         end
       end
 
       def cff_references(references)
         Array.wrap(references).map do |r|
-          identifier = Array.wrap(r["identifiers"]).find { |i| i["type"] == "doi" }
-          
-          if identifier.present?
-            { "relatedIdentifier" => normalize_id(parse_attributes(identifier["value"])),
-              "relationType" => "References",
-              "relatedIdentifierType" => "DOI" }.compact
-          else
-            nil
-          end
+          identifier = Array.wrap(r['identifiers']).find { |i| i['type'] == 'doi' }
+
+          next unless identifier.present?
+
+          { 'relatedIdentifier' => normalize_id(parse_attributes(identifier['value'])),
+            'relationType' => 'References',
+            'relatedIdentifierType' => 'DOI' }.compact
         end.compact.unwrap
       end
     end

data/lib/briard/readers/citeproc_reader.rb

@@ -4,115 +4,121 @@ module Briard
   module Readers
     module CiteprocReader
       CP_TO_SO_TRANSLATIONS = {
-        "song" => "AudioObject",
-        "post-weblog" => "BlogPosting",
-        "dataset" => "Dataset",
-        "graphic" => "ImageObject",
-        "motion_picture" => "Movie",
-        "article-journal" => "ScholarlyArticle",
-        "broadcast" => "VideoObject",
-        "webpage" => "WebPage"
-      }
+        'song' => 'AudioObject',
+        'post-weblog' => 'BlogPosting',
+        'dataset' => 'Dataset',
+        'graphic' => 'ImageObject',
+        'motion_picture' => 'Movie',
+        'article-journal' => 'ScholarlyArticle',
+        'broadcast' => 'VideoObject',
+        'webpage' => 'WebPage'
+      }.freeze
 
       CP_TO_RIS_TRANSLATIONS = {
-        "post-weblog" => "BLOG",
-        "dataset" => "DATA",
-        "graphic" => "FIGURE",
-        "book" => "BOOK",
-        "motion_picture" => "MPCT",
-        "article-journal" => "JOUR",
-        "broadcast" => "MPCT",
-        "webpage" => "ELEC"
-      }
+        'post-weblog' => 'BLOG',
+        'dataset' => 'DATA',
+        'graphic' => 'FIGURE',
+        'book' => 'BOOK',
+        'motion_picture' => 'MPCT',
+        'article-journal' => 'JOUR',
+        'broadcast' => 'MPCT',
+        'webpage' => 'ELEC'
+      }.freeze
 
       def read_citeproc(string: nil, **options)
         if string.present?
           errors = jsonlint(string)
-          return { "errors" => errors } if errors.present?
+          return { 'errors' => errors } if errors.present?
         end
 
-        read_options = ActiveSupport::HashWithIndifferentAccess.new(options.except(:doi, :id, :url, :sandbox, :validate, :ra))
+        read_options = ActiveSupport::HashWithIndifferentAccess.new(options.except(:doi, :id, :url,
+                                                                                   :sandbox, :validate, :ra))
 
         meta = string.present? ? Maremma.from_json(string) : {}
 
-        citeproc_type = meta.fetch("type", nil)
-        schema_org = CP_TO_SO_TRANSLATIONS[citeproc_type] || "CreativeWork"
+        citeproc_type = meta.fetch('type', nil)
+        schema_org = CP_TO_SO_TRANSLATIONS[citeproc_type] || 'CreativeWork'
         types = {
-          "resourceTypeGeneral" => Briard::Utils::CP_TO_DC_TRANSLATIONS[citeproc_type],
-          "reourceType" => meta.fetch("additionalType", nil),
-          "schemaOrg" => schema_org,
-          "citeproc" => citeproc_type,
-          "bibtex" => Briard::Utils::SO_TO_BIB_TRANSLATIONS[schema_org] || "misc",
-          "ris" => CP_TO_RIS_TRANSLATIONS[schema_org] || "GEN"
+          'resourceTypeGeneral' => Briard::Utils::CP_TO_DC_TRANSLATIONS[citeproc_type],
+          'reourceType' => meta.fetch('additionalType', nil),
+          'schemaOrg' => schema_org,
+          'citeproc' => citeproc_type,
+          'bibtex' => Briard::Utils::SO_TO_BIB_TRANSLATIONS[schema_org] || 'misc',
+          'ris' => CP_TO_RIS_TRANSLATIONS[schema_org] || 'GEN'
         }.compact
 
-        creators = if meta.fetch("author", nil).present?
-          get_authors(from_citeproc(Array.wrap(meta.fetch("author", nil))))
-        else
-          [{ "nameType" => "Organizational", "name" => ":(unav)" }]
-        end
-        contributors = get_authors(from_citeproc(Array.wrap(meta.fetch("editor", nil))))
-        dates = if date = get_date_from_date_parts(meta.fetch("issued", nil))
-                  if Date.edtf(date).present?
-                    [{ "date" => date,
-                      "dateType" => "Issued" }]
-                  end
+        creators = if meta.fetch('author', nil).present?
+                     get_authors(from_citeproc(Array.wrap(meta.fetch('author', nil))))
+                   else
+                     [{ 'nameType' => 'Organizational', 'name' => ':(unav)' }]
+                   end
+        contributors = get_authors(from_citeproc(Array.wrap(meta.fetch('editor', nil))))
+        dates = if (date = get_date_from_date_parts(meta.fetch('issued',
+                                                               nil))) && Date.edtf(date).present?
+                  [{ 'date' => date,
+                     'dateType' => 'Issued' }]
                 end
-        publication_year = get_date_from_date_parts(meta.fetch("issued", nil)).to_s[0..3]
-        rights_list = if meta.fetch("copyright", nil)
-                        [hsh_to_spdx("rightsURI" => meta.fetch("copyright"))]
+        publication_year = get_date_from_date_parts(meta.fetch('issued', nil)).to_s[0..3]
+        rights_list = if meta.fetch('copyright', nil)
+                        [hsh_to_spdx('rightsURI' => meta.fetch('copyright'))]
                       end
-        related_identifiers = if meta.fetch("container-title", nil).present? && meta.fetch("ISSN", nil).present?
-                                [{ "type" => "Periodical",
-                                  "relationType" => "IsPartOf",
-                                  "relatedIdentifierType" => "ISSN",
-                                  "title" => meta.fetch("container-title", nil),
-                                  "relatedIdentifier" => meta.fetch("ISSN", nil) }.compact]
+        related_identifiers = if meta.fetch('container-title',
+                                            nil).present? && meta.fetch('ISSN', nil).present?
+                                [{ 'type' => 'Periodical',
+                                   'relationType' => 'IsPartOf',
+                                   'relatedIdentifierType' => 'ISSN',
+                                   'title' => meta.fetch('container-title', nil),
+                                   'relatedIdentifier' => meta.fetch('ISSN', nil) }.compact]
                               end
-        container = if meta.fetch("container-title", nil).present?
-          first_page = meta.fetch("page", nil).present? ? meta.fetch("page").split("-").map(&:strip)[0] : nil
-          last_page = meta.fetch("page", nil).present? ? meta.fetch("page").split("-").map(&:strip)[1] : nil
+        container = if meta.fetch('container-title', nil).present?
+                      first_page = if meta.fetch('page', nil).present?
+                                     meta.fetch('page').split('-').map(&:strip)[0]
+                                   end
+                      last_page = if meta.fetch('page', nil).present?
+                                    meta.fetch('page').split('-').map(&:strip)[1]
+                                  end
 
-          { "type" => "Periodical",
-            "title" => meta.fetch("container-title", nil),
-            "identifier" => meta.fetch("ISSN", nil),
-            "identifierType" => meta.fetch("ISSN", nil).present? ? "ISSN" : nil,
-            "volume" => meta.fetch("volume", nil),
-            "issue" => meta.fetch("issue", nil),
-            "firstPage" => first_page,
-            "lastPage" => last_page
-           }.compact
-        else
-          nil
-        end
+                      { 'type' => 'Periodical',
+                        'title' => meta.fetch('container-title', nil),
+                        'identifier' => meta.fetch('ISSN', nil),
+                        'identifierType' => meta.fetch('ISSN', nil).present? ? 'ISSN' : nil,
+                        'volume' => meta.fetch('volume', nil),
+                        'issue' => meta.fetch('issue', nil),
+                        'firstPage' => first_page,
+                        'lastPage' => last_page }.compact
+                    end
 
-        id = normalize_id(meta.fetch("id", nil) || meta.fetch("DOI", nil))
+        id = normalize_id(meta.fetch('id', nil) || meta.fetch('DOI', nil))
 
-        state = id.present? || read_options.present? ? "findable" : "not_found"
-        subjects = Array.wrap(meta.fetch("categories", nil)).reduce([]) do |sum, subject|
+        state = id.present? || read_options.present? ? 'findable' : 'not_found'
+        subjects = Array.wrap(meta.fetch('categories', nil)).reduce([]) do |sum, subject|
           sum += name_to_fos(subject)
 
           sum
         end
 
-        { "id" => id,
-          "types" => types,
-          "doi" => doi_from_url(id),
-          "url" => normalize_id(meta.fetch("URL", nil)),
-          "titles" => [{ "title" => meta.fetch("title", nil) }],
-          "creators" => creators,
-          "contributors" => contributors,
-          "container" => container,
-          "publisher" => meta.fetch("publisher", nil),
-          "related_identifiers" => related_identifiers,
-          "dates" => dates,
-          "publication_year" => publication_year,
-          "descriptions" => meta.fetch("abstract", nil).present? ? [{ "description" => sanitize(meta.fetch("abstract")), "descriptionType" => "Abstract" }] : [],
-          "rights_list" => rights_list,
-          "version_info" => meta.fetch("version", nil),
-          "subjects" => subjects,
-          "state" => state
-        }.merge(read_options)
+        { 'id' => id,
+          'types' => types,
+          'doi' => doi_from_url(id),
+          'url' => normalize_id(meta.fetch('URL', nil)),
+          'titles' => [{ 'title' => meta.fetch('title', nil) }],
+          'creators' => creators,
+          'contributors' => contributors,
+          'container' => container,
+          'publisher' => meta.fetch('publisher', nil),
+          'related_identifiers' => related_identifiers,
+          'dates' => dates,
+          'publication_year' => publication_year,
+          'descriptions' => if meta.fetch('abstract', nil).present?
+                              [{ 'description' => sanitize(meta.fetch('abstract')),
+                                 'descriptionType' => 'Abstract' }]
+                            else
+                              []
+                            end,
+          'rights_list' => rights_list,
+          'version_info' => meta.fetch('version', nil),
+          'subjects' => subjects,
+          'state' => state }.merge(read_options)
       end
     end
   end