briard 2.4.2 → 2.6.0

data/spec/writers/csv_writer_spec.rb

@@ -3,92 +3,92 @@
 require 'spec_helper'
 
 describe Briard::Metadata, vcr: true do
-  context "write metadata as csv" do
-    it "with data citation" do
-      input = "10.7554/eLife.01567"
-      subject = Briard::Metadata.new(input: input, from: "crossref")
-      csv = (subject.csv).parse_csv
+  context 'write metadata as csv' do
+    it 'with data citation' do
+      input = '10.7554/eLife.01567'
+      subject = described_class.new(input: input, from: 'crossref')
+      csv = subject.csv.parse_csv
 
-      expect(csv[0]).to eq("10.7554/elife.01567")
-      expect(csv[1]).to eq("https://elifesciences.org/articles/01567")
-      expect(csv[2]).to eq("2018-08-23")
-      expect(csv[3]).to eq("findable")
-      expect(csv[4]).to eq("JournalArticle")
-      expect(csv[5]).to eq("JournalArticle")
-      expect(csv[6]).to eq("Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth")
-      expect(csv[7]).to eq("Sankar, Martial and Nieminen, Kaisa and Ragni, Laura and Xenarios, Ioannis and Hardtke, Christian S")
-      expect(csv[8]).to eq("eLife Sciences Publications, Ltd")
-      expect(csv[9]).to eq("2014")
+      expect(csv[0]).to eq('10.7554/elife.01567')
+      expect(csv[1]).to eq('https://elifesciences.org/articles/01567')
+      expect(csv[2]).to eq('2018-08-23')
+      expect(csv[3]).to eq('findable')
+      expect(csv[4]).to eq('JournalArticle')
+      expect(csv[5]).to eq('JournalArticle')
+      expect(csv[6]).to eq('Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth')
+      expect(csv[7]).to eq('Sankar, Martial and Nieminen, Kaisa and Ragni, Laura and Xenarios, Ioannis and Hardtke, Christian S')
+      expect(csv[8]).to eq('eLife Sciences Publications, Ltd')
+      expect(csv[9]).to eq('2014')
     end
 
-    it "with pages" do
-      input = "https://doi.org/10.1155/2012/291294"
-      subject = Briard::Metadata.new(input: input, from: "crossref")
-      csv = (subject.csv).parse_csv
+    it 'with pages' do
+      input = 'https://doi.org/10.1155/2012/291294'
+      subject = described_class.new(input: input, from: 'crossref')
+      csv = subject.csv.parse_csv
 
-      expect(csv[0]).to eq("10.1155/2012/291294")
-      expect(csv[1]).to eq("http://www.hindawi.com/journals/pm/2012/291294/")
-      expect(csv[2]).to eq("2016-08-02")
-      expect(csv[3]).to eq("findable")
-      expect(csv[4]).to eq("JournalArticle")
-      expect(csv[5]).to eq("JournalArticle")
-      expect(csv[6]).to eq("Delineating a Retesting Zone Using Receiver Operating Characteristic Analysis on Serial QuantiFERON Tuberculosis Test Results in US Healthcare Workers")
-      expect(csv[7]).to eq("Thanassi, Wendy and Noda, Art and Hernandez, Beatriz and Newell, Jeffery and Terpeluk, Paul and Marder, David and Yesavage, Jerome A.")
-      expect(csv[8]).to eq("Hindawi Limited")
-      expect(csv[9]).to eq("2012")
+      expect(csv[0]).to eq('10.1155/2012/291294')
+      expect(csv[1]).to eq('http://www.hindawi.com/journals/pm/2012/291294/')
+      expect(csv[2]).to eq('2016-08-02')
+      expect(csv[3]).to eq('findable')
+      expect(csv[4]).to eq('JournalArticle')
+      expect(csv[5]).to eq('JournalArticle')
+      expect(csv[6]).to eq('Delineating a Retesting Zone Using Receiver Operating Characteristic Analysis on Serial QuantiFERON Tuberculosis Test Results in US Healthcare Workers')
+      expect(csv[7]).to eq('Thanassi, Wendy and Noda, Art and Hernandez, Beatriz and Newell, Jeffery and Terpeluk, Paul and Marder, David and Yesavage, Jerome A.')
+      expect(csv[8]).to eq('Hindawi Limited')
+      expect(csv[9]).to eq('2012')
     end
 
-    it "text" do
-      input = "https://doi.org/10.3204/desy-2014-01645"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
+    it 'text' do
+      input = 'https://doi.org/10.3204/desy-2014-01645'
+      subject = described_class.new(input: input, from: 'datacite')
 
       expect(subject.valid?).to be true
-      csv = (subject.csv).parse_csv
+      csv = subject.csv.parse_csv
 
-      expect(csv[0]).to eq("10.3204/desy-2014-01645")
-      expect(csv[1]).to eq("http://bib-pubdb1.desy.de/record/166827")
-      expect(csv[2]).to eq("2018-01-25")
-      expect(csv[3]).to eq("findable")
-      expect(csv[4]).to eq("Text")
-      expect(csv[5]).to eq("Dissertation")
-      expect(csv[6]).to eq("Dynamics of colloids in molecular glass forming liquids studied via X-ray photon correlation spectroscopy")
-      expect(csv[7]).to eq("Conrad, Heiko")
-      expect(csv[9]).to eq("2014")
+      expect(csv[0]).to eq('10.3204/desy-2014-01645')
+      expect(csv[1]).to eq('http://bib-pubdb1.desy.de/record/166827')
+      expect(csv[2]).to eq('2018-01-25')
+      expect(csv[3]).to eq('findable')
+      expect(csv[4]).to eq('Text')
+      expect(csv[5]).to eq('Dissertation')
+      expect(csv[6]).to eq('Dynamics of colloids in molecular glass forming liquids studied via X-ray photon correlation spectroscopy')
+      expect(csv[7]).to eq('Conrad, Heiko')
+      expect(csv[9]).to eq('2014')
     end
 
-    it "climate data" do
-      input = "https://doi.org/10.5067/altcy-tj122"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
+    it 'climate data' do
+      input = 'https://doi.org/10.5067/altcy-tj122'
+      subject = described_class.new(input: input, from: 'datacite')
       expect(subject.valid?).to be true
-      csv = (subject.csv).parse_csv
+      csv = subject.csv.parse_csv
 
-      expect(csv[0]).to eq("10.5067/altcy-tj122")
-      expect(csv[1]).to eq("http://podaac.jpl.nasa.gov/dataset/MERGED_TP_J1_OSTM_OST_CYCLES_V2")
-      expect(csv[2]).to eq("2014-01-15")
-      expect(csv[3]).to eq("findable")
-      expect(csv[4]).to eq("Dataset")
-      expect(csv[5]).to eq("Dataset")
-      expect(csv[6]).to eq("Integrated Multi-Mission Ocean Altimeter Data for Climate Research Version 2")
-      expect(csv[7]).to eq("{GSFC}")
-      expect(csv[8]).to eq("NASA Physical Oceanography DAAC")
-      expect(csv[9]).to eq("2012")
+      expect(csv[0]).to eq('10.5067/altcy-tj122')
+      expect(csv[1]).to eq('http://podaac.jpl.nasa.gov/dataset/MERGED_TP_J1_OSTM_OST_CYCLES_V2')
+      expect(csv[2]).to eq('2014-01-15')
+      expect(csv[3]).to eq('findable')
+      expect(csv[4]).to eq('Dataset')
+      expect(csv[5]).to eq('Dataset')
+      expect(csv[6]).to eq('Integrated Multi-Mission Ocean Altimeter Data for Climate Research Version 2')
+      expect(csv[7]).to eq('{GSFC}')
+      expect(csv[8]).to eq('NASA Physical Oceanography DAAC')
+      expect(csv[9]).to eq('2012')
     end
 
-    it "maremma" do
-      input = "https://github.com/datacite/maremma"
-      subject = Briard::Metadata.new(input: input, from: "codemeta")
-      csv = (subject.csv).parse_csv
+    it 'maremma' do
+      input = 'https://github.com/datacite/maremma'
+      subject = described_class.new(input: input, from: 'codemeta')
+      csv = subject.csv.parse_csv
 
-      expect(csv[0]).to eq("10.5438/qeg0-3gm3")
-      expect(csv[1]).to eq("https://github.com/datacite/maremma")
-      expect(csv[2]).to be_nil
-      expect(csv[3]).to eq("findable")
-      expect(csv[4]).to eq("Software")
-      expect(csv[5]).to be_nil
-      expect(csv[6]).to eq("Maremma: a Ruby library for simplified network calls")
-      expect(csv[7]).to eq("Fenner, Martin")
-      expect(csv[8]).to eq("DataCite")
-      expect(csv[9]).to eq("2017")
+      expect(csv[0]).to eq('10.5438/qeg0-3gm3')
+      expect(csv[1]).to eq('https://github.com/datacite/maremma')
+      expect(csv[2].nil?).to be(true)
+      expect(csv[3]).to eq('findable')
+      expect(csv[4]).to eq('Software')
+      expect(csv[5].nil?).to be(true)
+      expect(csv[6]).to eq('Maremma: a Ruby library for simplified network calls')
+      expect(csv[7]).to eq('Fenner, Martin')
+      expect(csv[8]).to eq('DataCite')
+      expect(csv[9]).to eq('2017')
     end
   end
 end

data/spec/writers/datacite_json_writer_spec.rb

@@ -3,94 +3,104 @@
 require 'spec_helper'
 
 describe Briard::Metadata, vcr: true do
-  context "write metadata as datacite json" do
-    it "with data citation" do
-      input = "10.7554/eLife.01567"
-      subject = Briard::Metadata.new(input: input, from: "crossref")
+  context 'write metadata as datacite json' do
+    it 'with data citation' do
+      input = '10.7554/eLife.01567'
+      subject = described_class.new(input: input, from: 'crossref')
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("url")).to eq("https://elifesciences.org/articles/01567")
-      expect(datacite.fetch("types")).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceType"=>"JournalArticle", "resourceTypeGeneral"=>"JournalArticle", "ris"=>"JOUR", "schemaOrg"=>"ScholarlyArticle")
-      expect(datacite.fetch("titles")).to eq([{"title"=>"Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth"}])
-      expect(datacite.fetch("relatedIdentifiers").length).to eq(28)
-      expect(datacite.fetch("relatedIdentifiers").first).to eq("relatedIdentifier"=>"2050-084X", "relatedIdentifierType"=>"ISSN", "relationType"=>"IsPartOf", "resourceTypeGeneral"=>"Collection")
-      expect(datacite.fetch("rightsList")).to eq([{"rights"=>"Creative Commons Attribution 3.0 Unported",
-        "rightsIdentifier"=>"cc-by-3.0",
-        "rightsIdentifierScheme"=>"SPDX",
-        "rightsUri"=>"https://creativecommons.org/licenses/by/3.0/legalcode",
-        "schemeUri"=>"https://spdx.org/licenses/"}])
+      expect(datacite.fetch('url')).to eq('https://elifesciences.org/articles/01567')
+      expect(datacite.fetch('types')).to eq('bibtex' => 'article', 'citeproc' => 'article-journal',
+                                            'resourceType' => 'JournalArticle', 'resourceTypeGeneral' => 'JournalArticle', 'ris' => 'JOUR', 'schemaOrg' => 'ScholarlyArticle')
+      expect(datacite.fetch('titles')).to eq([{ 'title' => 'Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth' }])
+      expect(datacite.fetch('relatedIdentifiers').length).to eq(28)
+      expect(datacite.fetch('relatedIdentifiers').first).to eq('relatedIdentifier' => '2050-084X',
+                                                               'relatedIdentifierType' => 'ISSN', 'relationType' => 'IsPartOf', 'resourceTypeGeneral' => 'Collection')
+      expect(datacite.fetch('rightsList')).to eq([{ 'rights' => 'Creative Commons Attribution 3.0 Unported',
+                                                    'rightsIdentifier' => 'cc-by-3.0',
+                                                    'rightsIdentifierScheme' => 'SPDX',
+                                                    'rightsUri' => 'https://creativecommons.org/licenses/by/3.0/legalcode',
+                                                    'schemeUri' => 'https://spdx.org/licenses/' }])
     end
 
-    it "with ORCID ID" do
-      input = "https://doi.org/10.1155/2012/291294"
-      subject = Briard::Metadata.new(input: input, from: "crossref")
+    it 'with ORCID ID' do
+      input = 'https://doi.org/10.1155/2012/291294'
+      subject = described_class.new(input: input, from: 'crossref')
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("url")).to eq("http://www.hindawi.com/journals/pm/2012/291294/")
-      expect(datacite.fetch("types")).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceType"=>"JournalArticle", "resourceTypeGeneral"=>"JournalArticle", "ris"=>"JOUR", "schemaOrg"=>"ScholarlyArticle")
-      expect(datacite.fetch("creators").length).to eq(7)
-      expect(datacite.fetch("creators").first).to eq("nameType"=>"Personal", "name"=>"Thanassi, Wendy", "givenName"=>"Wendy", "familyName"=>"Thanassi", "affiliation" => [{"name"=>"Department of Medicine, Veterans Affairs Palo Alto Health Care System, 3801 Miranda Avenue MC-, Palo Alto, CA 94304-1207, USA"}, {"name"=>"Occupational Health Strategic Health Care Group, Office of Public Health, Veterans Health Administration, Washington, DC 20006, USA"}, {"name"=>"Division of Emergency Medicine, Stanford University School of Medicine, Stanford, CA 94304, USA"}, {"name"=>"War Related Illness and Injury Study Center (WRIISC) and Mental Illness Research Education and Clinical Center (MIRECC), Department of Veterans Affairs, Palo Alto, CA 94304, USA"}])
+      expect(datacite.fetch('url')).to eq('http://www.hindawi.com/journals/pm/2012/291294/')
+      expect(datacite.fetch('types')).to eq('bibtex' => 'article', 'citeproc' => 'article-journal',
+                                            'resourceType' => 'JournalArticle', 'resourceTypeGeneral' => 'JournalArticle', 'ris' => 'JOUR', 'schemaOrg' => 'ScholarlyArticle')
+      expect(datacite.fetch('creators').length).to eq(7)
+      expect(datacite.fetch('creators').first).to eq('nameType' => 'Personal',
+                                                     'name' => 'Thanassi, Wendy', 'givenName' => 'Wendy', 'familyName' => 'Thanassi', 'affiliation' => [{ 'name' => 'Department of Medicine, Veterans Affairs Palo Alto Health Care System, 3801 Miranda Avenue MC-, Palo Alto, CA 94304-1207, USA' }, { 'name' => 'Occupational Health Strategic Health Care Group, Office of Public Health, Veterans Health Administration, Washington, DC 20006, USA' }, { 'name' => 'Division of Emergency Medicine, Stanford University School of Medicine, Stanford, CA 94304, USA' }, { 'name' => 'War Related Illness and Injury Study Center (WRIISC) and Mental Illness Research Education and Clinical Center (MIRECC), Department of Veterans Affairs, Palo Alto, CA 94304, USA' }])
     end
 
-    it "Crossref DOI" do
-      input = fixture_path + "crossref.bib"
-      subject = Briard::Metadata.new(input: input, from: "bibtex")
+    it 'Crossref DOI' do
+      input = "#{fixture_path}crossref.bib"
+      subject = described_class.new(input: input, from: 'bibtex')
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("types")).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceType"=>"JournalArticle", "resourceTypeGeneral"=>"JournalArticle", "ris"=>"JOUR", "schemaOrg"=>"ScholarlyArticle")
-      expect(datacite.fetch("titles")).to eq([{"title"=>"Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth"}])
-      expect(datacite.dig("descriptions", 0, "description")).to start_with("Among various advantages, their small size makes model organisms preferred subjects of investigation.")
-      expect(datacite.fetch("creators").length).to eq(5)
-      expect(datacite.fetch("creators").first).to eq("nameType"=>"Personal", "name"=>"Sankar, Martial", "givenName"=>"Martial", "familyName"=>"Sankar")
+      expect(datacite.fetch('types')).to eq('bibtex' => 'article', 'citeproc' => 'article-journal',
+                                            'resourceType' => 'JournalArticle', 'resourceTypeGeneral' => 'JournalArticle', 'ris' => 'JOUR', 'schemaOrg' => 'ScholarlyArticle')
+      expect(datacite.fetch('titles')).to eq([{ 'title' => 'Automated quantitative histology reveals vascular morphodynamics during Arabidopsis hypocotyl secondary growth' }])
+      expect(datacite.dig('descriptions', 0,
+                          'description')).to start_with('Among various advantages, their small size makes model organisms preferred subjects of investigation.')
+      expect(datacite.fetch('creators').length).to eq(5)
+      expect(datacite.fetch('creators').first).to eq('nameType' => 'Personal',
+                                                     'name' => 'Sankar, Martial', 'givenName' => 'Martial', 'familyName' => 'Sankar')
     end
 
-    it "BlogPosting Citeproc JSON" do
-      input = fixture_path + "citeproc.json"
-      subject = Briard::Metadata.new(input: input, from: "citeproc")
+    it 'BlogPosting Citeproc JSON' do
+      input = "#{fixture_path}citeproc.json"
+      subject = described_class.new(input: input, from: 'citeproc')
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("types")).to eq("bibtex"=>"article", "citeproc"=>"post-weblog", "resourceTypeGeneral"=>"Text", "ris"=>"GEN", "schemaOrg"=>"BlogPosting")
-      expect(datacite.fetch("titles")).to eq([{"title"=>"Eating your own Dog Food"}])
-      expect(datacite.dig("descriptions", 0, "description")).to start_with("Eating your own dog food")
-      expect(datacite.fetch("creators")).to eq([{"familyName"=>"Fenner", "givenName"=>"Martin", "name"=>"Fenner, Martin"}])
+      expect(datacite.fetch('types')).to eq('bibtex' => 'article', 'citeproc' => 'post-weblog',
+                                            'resourceTypeGeneral' => 'Text', 'ris' => 'GEN', 'schemaOrg' => 'BlogPosting')
+      expect(datacite.fetch('titles')).to eq([{ 'title' => 'Eating your own Dog Food' }])
+      expect(datacite.dig('descriptions', 0,
+                          'description')).to start_with('Eating your own dog food')
+      expect(datacite.fetch('creators')).to eq([{ 'familyName' => 'Fenner', 'givenName' => 'Martin',
+                                                  'name' => 'Fenner, Martin' }])
     end
 
-    it "rdataone" do
-      input = fixture_path + 'codemeta.json'
-      subject = Briard::Metadata.new(input: input, from: "codemeta")
+    it 'rdataone' do
+      input = "#{fixture_path}codemeta.json"
+      subject = described_class.new(input: input, from: 'codemeta')
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("titles")).to eq([{"title"=>"R Interface to the DataONE REST API"}])
-      expect(datacite.fetch("creators").length).to eq(3)
-      expect(datacite.fetch("creators").first).to eq("affiliation"=>[{"name"=>"NCEAS"}], "nameType"=>"Personal", "name" => "Jones, Matt",
-        "nameIdentifiers" => [{"nameIdentifier"=>"https://orcid.org/0000-0003-0077-4738", "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}], "givenName"=>"Matt", "familyName"=>"Jones")
-      expect(datacite.fetch("version")).to eq("2.0.0")
+      expect(datacite.fetch('titles')).to eq([{ 'title' => 'R Interface to the DataONE REST API' }])
+      expect(datacite.fetch('creators').length).to eq(3)
+      expect(datacite.fetch('creators').first).to eq('affiliation' => [{ 'name' => 'NCEAS' }], 'nameType' => 'Personal', 'name' => 'Jones, Matt',
+                                                     'nameIdentifiers' => [{ 'nameIdentifier' => 'https://orcid.org/0000-0003-0077-4738', 'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org' }], 'givenName' => 'Matt', 'familyName' => 'Jones')
+      expect(datacite.fetch('version')).to eq('2.0.0')
     end
 
-    it "maremma" do
-      input = "https://github.com/datacite/maremma"
-      subject = Briard::Metadata.new(input: input, from: "codemeta")
+    it 'maremma' do
+      input = 'https://github.com/datacite/maremma'
+      subject = described_class.new(input: input, from: 'codemeta')
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("titles")).to eq([{"title"=>"Maremma: a Ruby library for simplified network calls"}])
-      expect(datacite.fetch("creators")).to eq([{"affiliation"=>[{"name"=>"DataCite"}],
-        "familyName"=>"Fenner",
-        "givenName"=>"Martin",
-        "name"=>"Fenner, Martin",
-        "nameIdentifiers"=>
-         [{"nameIdentifier"=>"https://orcid.org/0000-0003-0077-4738",
-           "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}],
-        "nameType"=>"Personal"}])
+      expect(datacite.fetch('titles')).to eq([{ 'title' => 'Maremma: a Ruby library for simplified network calls' }])
+      expect(datacite.fetch('creators')).to eq([{ 'affiliation' => [{ 'name' => 'DataCite' }],
+                                                  'familyName' => 'Fenner',
+                                                  'givenName' => 'Martin',
+                                                  'name' => 'Fenner, Martin',
+                                                  'nameIdentifiers' =>
+         [{ 'nameIdentifier' => 'https://orcid.org/0000-0003-0077-4738',
+            'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org' }],
+                                                  'nameType' => 'Personal' }])
     end
 
-    it "from schema.org" do
-      input = "https://blog.front-matter.io/posts/eating-your-own-dog-food/"
-      subject = Briard::Metadata.new(input: input, from: "schema_org")
+    it 'from schema.org' do
+      input = 'https://blog.front-matter.io/posts/eating-your-own-dog-food/'
+      subject = described_class.new(input: input, from: 'schema_org')
       expect(subject.valid?).to be true
       datacite = JSON.parse(subject.datacite_json)
-      expect(datacite.fetch("titles")).to eq([{"title"=>"Eating your own Dog Food"}])
-      expect(datacite.fetch("creators")).to eq([{"affiliation"=>[],
-      "familyName"=>"Fenner",
-      "givenName"=>"Martin",
-      "name"=>"Fenner, Martin",
-      "nameIdentifiers"=>
-       [{"nameIdentifier"=>"https://orcid.org/0000-0003-1419-2405",
-         "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}],
-      "nameType"=>"Personal"}])
+      expect(datacite.fetch('titles')).to eq([{ 'title' => 'Eating your own Dog Food' }])
+      expect(datacite.fetch('creators')).to eq([{ 'affiliation' => [],
+                                                  'familyName' => 'Fenner',
+                                                  'givenName' => 'Martin',
+                                                  'name' => 'Fenner, Martin',
+                                                  'nameIdentifiers' =>
+       [{ 'nameIdentifier' => 'https://orcid.org/0000-0003-1419-2405',
+          'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org' }],
+                                                  'nameType' => 'Personal' }])
     end
   end
 end