briard 2.4.2 → 2.6.0

data/spec/author_utils_spec.rb

@@ -3,188 +3,207 @@
 require 'spec_helper'
 
 describe Briard::Metadata, vcr: true do
-  let(:input) { "https://doi.org/10.1101/097196" }
+  subject { described_class.new(input: input, from: 'crossref') }
 
-  subject { Briard::Metadata.new(input: input, from: "crossref") }
+  let(:input) { 'https://doi.org/10.1101/097196' }
 
-  context "is_personal_name?" do
-    it "has type organization" do
-      author = {"email"=>"info@ucop.edu", "name"=>"University of California, Santa Barbara", "role"=>{"namespace"=>"http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode", "roleCode"=>"copyrightHolder"}, "nameType"=>"Organizational" }
+  context 'is_personal_name?' do
+    it 'has type organization' do
+      author = { 'email' => 'info@ucop.edu', 'name' => 'University of California, Santa Barbara',
+                 'role' => { 'namespace' => 'http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode', 'roleCode' => 'copyrightHolder' }, 'nameType' => 'Organizational' }
       expect(subject.is_personal_name?(author)).to be false
     end
 
-    it "has id" do
-      author = {"id"=>"http://orcid.org/0000-0003-1419-2405", "givenName"=>"Martin", "familyName"=>"Fenner", "name"=>"Martin Fenner" }
+    it 'has id' do
+      author = { 'id' => 'http://orcid.org/0000-0003-1419-2405', 'givenName' => 'Martin', 'familyName' => 'Fenner', 'name' => 'Martin Fenner' }
       expect(subject.is_personal_name?(author)).to be true
     end
 
-    it "has orcid id" do
-      author = { "creatorName"=>"Fenner, Martin", "givenName"=>"Martin", "familyName"=>"Fenner", "nameIdentifier"=>{"schemeURI"=>"http://orcid.org/", "nameIdentifierScheme"=>"ORCID", "__content__"=>"0000-0003-1419-2405"}}
+    it 'has orcid id' do
+      author = { 'creatorName' => 'Fenner, Martin', 'givenName' => 'Martin', 'familyName' => 'Fenner',
+                 'nameIdentifier' => { 'schemeURI' => 'http://orcid.org/', 'nameIdentifierScheme' => 'ORCID', '__content__' => '0000-0003-1419-2405' } }
       expect(subject.is_personal_name?(author)).to be true
     end
-    it "has family name" do
-      author = {"givenName"=>"Martin", "familyName"=>"Fenner", "name"=>"Martin Fenner" }
+
+    it 'has family name' do
+      author = { 'givenName' => 'Martin', 'familyName' => 'Fenner', 'name' => 'Martin Fenner' }
       expect(subject.is_personal_name?(author)).to be true
     end
 
-    it "has comma" do
-      author = {"name"=>"Fenner, Martin" }
+    it 'has comma' do
+      author = { 'name' => 'Fenner, Martin' }
       expect(subject.is_personal_name?(author)).to be true
     end
 
-    it "has known given name" do
-      author = {"name"=>"Martin Fenner" }
+    it 'has known given name' do
+      author = { 'name' => 'Martin Fenner' }
       expect(subject.is_personal_name?(author)).to be true
     end
 
-    it "has no info" do
-      author = {"name"=>"M Fenner" }
+    it 'has no info' do
+      author = { 'name' => 'M Fenner' }
       expect(subject.is_personal_name?(author)).to be false
     end
   end
 
-  context "get_one_author" do
-    it "has familyName" do
-      input = "https://doi.org/10.5438/4K3M-NYVG"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("nameIdentifiers" => [{"nameIdentifier"=>"https://orcid.org/0000-0003-1419-2405", "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}], "name"=>"Fenner, Martin", "givenName"=>"Martin", "familyName"=>"Fenner")
-    end
-
-    it "has name in sort-order" do
-      input = "https://doi.org/10.5061/dryad.8515"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator").first)
-      expect(response).to eq("nameType"=>"Personal", "name"=>"Ollomo, Benjamin", "givenName"=>"Benjamin", "familyName"=>"Ollomo", "nameIdentifiers" => [], "affiliation" => [{"affiliationIdentifier"=>"https://ror.org/01wyqb997", "affiliationIdentifierScheme"=>"ROR", "name"=>"Centre International de Recherches Médicales de Franceville"}])
-    end
-
-    it "has name in display-order" do
-      input = "https://doi.org/10.5281/ZENODO.48440"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("nameType"=>"Personal", "name"=>"Garza, Kristian", "givenName"=>"Kristian", "familyName"=>"Garza", "nameIdentifiers" => [], "affiliation" => [])
-    end
-
-    it "has name in display-order with ORCID" do
-      input = "https://doi.org/10.6084/M9.FIGSHARE.4700788"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("nameType"=>"Personal", "nameIdentifiers" => [{"nameIdentifier"=>"https://orcid.org/0000-0003-4881-1606", "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}], "name"=>"Bedini, Andrea", "givenName"=>"Andrea", "familyName"=>"Bedini", "affiliation" => [])
-    end
-
-    it "has name in Thai" do
-      input = "https://doi.org/10.14457/KMITL.res.2006.17"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("name"=>"กัญจนา แซ่เตียว", "nameIdentifiers" => [], "affiliation" => [])
-    end
-
-    it "multiple author names in one field" do
-      input = "https://doi.org/10.7910/dvn/eqtqyo"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_authors(meta.dig("creators", "creator"))
-      expect(response).to eq([{"name" => "Enos, Ryan (Harvard University); Fowler, Anthony (University Of Chicago); Vavreck, Lynn (UCLA)", "nameIdentifiers" => [], "affiliation" => []}])
-    end
-
-    it "hyper-authorship" do
-      input = "https://doi.org/10.17182/HEPDATA.77274.V1"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_authors(meta.dig("creators", "creator"))
-      expect(response).to eq( [{"affiliation"=>[], "name"=>"ALICE Collaboration", "nameIdentifiers"=>[], "nameType"=>"Organizational"}])
-    end
-
-    it "is organization" do
-      author = {"email"=>"info@ucop.edu", "creatorName"=> { "__content__" => "University of California, Santa Barbara", "nameType" => "Organizational" }, "role"=>{"namespace"=>"http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode", "roleCode"=>"copyrightHolder"} }
+  context 'get_one_author' do
+    it 'has familyName' do
+      input = 'https://doi.org/10.5438/4K3M-NYVG'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq(
+        'nameIdentifiers' => [{ 'nameIdentifier' => 'https://orcid.org/0000-0003-1419-2405',
+                                'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org' }], 'name' => 'Fenner, Martin', 'givenName' => 'Martin', 'familyName' => 'Fenner'
+      )
+    end
+
+    it 'has name in sort-order' do
+      input = 'https://doi.org/10.5061/dryad.8515'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator').first)
+      expect(response).to eq('nameType' => 'Personal', 'name' => 'Ollomo, Benjamin',
+                             'givenName' => 'Benjamin', 'familyName' => 'Ollomo', 'nameIdentifiers' => [], 'affiliation' => [{ 'affiliationIdentifier' => 'https://ror.org/01wyqb997', 'affiliationIdentifierScheme' => 'ROR', 'name' => 'Centre International de Recherches Médicales de Franceville' }])
+    end
+
+    it 'has name in display-order' do
+      input = 'https://doi.org/10.5281/ZENODO.48440'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('nameType' => 'Personal', 'name' => 'Garza, Kristian',
+                             'givenName' => 'Kristian', 'familyName' => 'Garza', 'nameIdentifiers' => [], 'affiliation' => [])
+    end
+
+    it 'has name in display-order with ORCID' do
+      input = 'https://doi.org/10.6084/M9.FIGSHARE.4700788'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('nameType' => 'Personal',
+                             'nameIdentifiers' => [{ 'nameIdentifier' => 'https://orcid.org/0000-0003-4881-1606', 'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org' }], 'name' => 'Bedini, Andrea', 'givenName' => 'Andrea', 'familyName' => 'Bedini', 'affiliation' => [])
+    end
+
+    it 'has name in Thai' do
+      input = 'https://doi.org/10.14457/KMITL.res.2006.17'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('name' => 'กัญจนา แซ่เตียว', 'nameIdentifiers' => [],
+                             'affiliation' => [])
+    end
+
+    it 'multiple author names in one field' do
+      input = 'https://doi.org/10.7910/dvn/eqtqyo'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_authors(meta.dig('creators', 'creator'))
+      expect(response).to eq([{
+                               'name' => 'Enos, Ryan (Harvard University); Fowler, Anthony (University Of Chicago); Vavreck, Lynn (UCLA)', 'nameIdentifiers' => [], 'affiliation' => []
+                             }])
+    end
+
+    it 'hyper-authorship' do
+      input = 'https://doi.org/10.17182/HEPDATA.77274.V1'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_authors(meta.dig('creators', 'creator'))
+      expect(response).to eq([{ 'affiliation' => [], 'name' => 'ALICE Collaboration',
+                                'nameIdentifiers' => [], 'nameType' => 'Organizational' }])
+    end
+
+    it 'is organization' do
+      author = { 'email' => 'info@ucop.edu',
+                 'creatorName' => { '__content__' => 'University of California, Santa Barbara', 'nameType' => 'Organizational' }, 'role' => { 'namespace' => 'http://www.ngdc.noaa.gov/metadata/published/xsd/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode', 'roleCode' => 'copyrightHolder' } }
       response = subject.get_one_author(author)
-      expect(response).to eq("nameType"=>"Organizational", "name"=>"University Of California, Santa Barbara", "nameIdentifiers" => [], "affiliation" => [])
+      expect(response).to eq('nameType' => 'Organizational',
+                             'name' => 'University Of California, Santa Barbara', 'nameIdentifiers' => [], 'affiliation' => [])
     end
 
-    it "name with affiliation" do
-      input = "10.11588/DIGLIT.6130"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("nameType"=>"Organizational", "name"=>"Dr. Störi, Kunstsalon", "nameIdentifiers" => [], "affiliation" => [])
+    it 'name with affiliation' do
+      input = '10.11588/DIGLIT.6130'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('nameType' => 'Organizational', 'name' => 'Dr. Störi, Kunstsalon',
+                             'nameIdentifiers' => [], 'affiliation' => [])
     end
 
-    it "name with affiliation and country" do
-      input = "10.16910/jemr.9.1.2"
-      subject = Briard::Metadata.new(input: input, from: "crossref")
+    it 'name with affiliation and country' do
+      input = '10.16910/jemr.9.1.2'
+      subject = described_class.new(input: input, from: 'crossref')
       response = subject.get_one_author(subject.creators.first)
-      expect(response).to eq("familyName" => "Eraslan",
-        "givenName" => "Sukru",
-        "name" => "Eraslan, Sukru")
+      expect(response).to eq('familyName' => 'Eraslan',
+                             'givenName' => 'Sukru',
+                             'name' => 'Eraslan, Sukru')
     end
 
-    it "name with role" do
-      input = "10.14463/GBV:873056442"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("affiliation" => [],
-        "name" => "Unknown",
-        "nameIdentifiers" => [])
+    it 'name with role' do
+      input = '10.14463/GBV:873056442'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('affiliation' => [], 'name' => 'Unknown', 'nameIdentifiers' => [])
     end
 
-    it "multiple name_identifier" do
-      input = "10.24350/CIRM.V.19028803"
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("nameType"=>"Personal", "name"=>"Dubos, Thomas", "givenName"=>"Thomas", "familyName"=>"Dubos", "affiliation" => [{"name"=>"École Polytechnique Laboratoire de Météorologie Dynamique"}], "nameIdentifiers" => [{"nameIdentifier"=>"http://isni.org/isni/0000 0003 5752 6882", "nameIdentifierScheme"=>"ISNI", "schemeUri"=>"http://isni.org/isni/"}, {"nameIdentifier"=>"https://orcid.org/0000-0003-4514-4211", "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}])
+    it 'multiple name_identifier' do
+      input = '10.24350/CIRM.V.19028803'
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('nameType' => 'Personal', 'name' => 'Dubos, Thomas',
+                             'givenName' => 'Thomas', 'familyName' => 'Dubos', 'affiliation' => [{ 'name' => 'École Polytechnique Laboratoire de Météorologie Dynamique' }], 'nameIdentifiers' => [{ 'nameIdentifier' => 'http://isni.org/isni/0000 0003 5752 6882', 'nameIdentifierScheme' => 'ISNI', 'schemeUri' => 'http://isni.org/isni/' }, { 'nameIdentifier' => 'https://orcid.org/0000-0003-4514-4211', 'nameIdentifierScheme' => 'ORCID', 'schemeUri' => 'https://orcid.org' }])
     end
 
-    it "nameType organizational" do
-      input = fixture_path + 'gtex.xml'
-      subject = Briard::Metadata.new(input: input, from: "datacite")
-      meta = Maremma.from_xml(subject.raw).fetch("resource", {})
-      response = subject.get_one_author(meta.dig("creators", "creator"))
-      expect(response).to eq("nameType"=>"Organizational", "name"=>"The GTEx Consortium", "nameIdentifiers" => [], "affiliation" => [])
+    it 'nameType organizational' do
+      input = "#{fixture_path}gtex.xml"
+      subject = described_class.new(input: input, from: 'datacite')
+      meta = Maremma.from_xml(subject.raw).fetch('resource', {})
+      response = subject.get_one_author(meta.dig('creators', 'creator'))
+      expect(response).to eq('nameType' => 'Organizational', 'name' => 'The GTEx Consortium',
+                             'nameIdentifiers' => [], 'affiliation' => [])
     end
 
-    it "only familyName and givenName" do
-      input = "https://doi.pangaea.de/10.1594/PANGAEA.836178"
-      subject = Briard::Metadata.new(input: input, from: "schema_org")
-      expect(subject.creators.first).to eq("nameType" => "Personal", "name"=>"Johansson, Emma", "givenName"=>"Emma", "familyName"=>"Johansson")
+    it 'only familyName and givenName' do
+      input = 'https://doi.pangaea.de/10.1594/PANGAEA.836178'
+      subject = described_class.new(input: input, from: 'schema_org')
+      expect(subject.creators.first).to eq('nameType' => 'Personal', 'name' => 'Johansson, Emma',
+                                           'givenName' => 'Emma', 'familyName' => 'Johansson')
     end
   end
 
-  context "authors_as_string" do
-    let(:author_with_organization) { [{"type"=>"Person",
-                                       "id"=>"http://orcid.org/0000-0003-0077-4738",
-                                       "name"=>"Matt Jones"},
-                                      {"type"=>"Person",
-                                       "id"=>"http://orcid.org/0000-0002-2192-403X",
-                                       "name"=>"Peter Slaughter"},
-                                      {"type"=>"Organization",
-                                       "id"=>"http://orcid.org/0000-0002-3957-2474",
-                                       "name"=>"University of California, Santa Barbara"}] }
-
-    it "author" do
+  context 'authors_as_string' do
+    let(:author_with_organization) do
+      [{ 'type' => 'Person',
+         'id' => 'http://orcid.org/0000-0003-0077-4738',
+         'name' => 'Matt Jones' },
+       { 'type' => 'Person',
+         'id' => 'http://orcid.org/0000-0002-2192-403X',
+         'name' => 'Peter Slaughter' },
+       { 'type' => 'Organization',
+         'id' => 'http://orcid.org/0000-0002-3957-2474',
+         'name' => 'University of California, Santa Barbara' }]
+    end
+
+    it 'author' do
       response = subject.authors_as_string(subject.creators)
-      expect(response).to eq("Fenner, Martin and Crosas, Merc?? and Grethe, Jeffrey and Kennedy, David and Hermjakob, Henning and Rocca-Serra, Philippe and Durand, Gustavo and Berjon, Robin and Karcher, Sebastian and Martone, Maryann and Clark, Timothy")
+      expect(response).to eq('Fenner, Martin and Crosas, Merc?? and Grethe, Jeffrey and Kennedy, David and Hermjakob, Henning and Rocca-Serra, Philippe and Durand, Gustavo and Berjon, Robin and Karcher, Sebastian and Martone, Maryann and Clark, Timothy')
     end
 
-    it "single author" do
+    it 'single author' do
       response = subject.authors_as_string(subject.creators.first)
-      expect(response).to eq("Fenner, Martin")
+      expect(response).to eq('Fenner, Martin')
     end
 
-    it "no author" do
+    it 'no author' do
       response = subject.authors_as_string(nil)
-      expect(response).to be_nil
+      expect(response.nil?).to be(true)
     end
 
-    it "with organization" do
+    it 'with organization' do
       response = subject.authors_as_string(author_with_organization)
-      expect(response).to eq("Matt Jones and Peter Slaughter and {University of California, Santa Barbara}")
+      expect(response).to eq('Matt Jones and Peter Slaughter and {University of California, Santa Barbara}')
     end
   end
 end