arpa 0.2.0 → 0.3.0

data/spec/lib/arpa/services/resources/create/resource_creator_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Services::Resources::Create::ResourceCreator, type: :service, fast: true do
-
   let(:resource_entity_class) { Arpa::Entities::Resource }
   let(:resource)              { double full_name: 'UsersController' }
   let(:resourceable)          { double }
@@ -11,7 +10,7 @@ describe Arpa::Services::Resources::Create::ResourceCreator, type: :service, fas
   let(:validator_class)  { Arpa::Validators::ResourceValidator }
   let(:validator)        { instance_double validator_class }
 
-  let(:finder_repo_class) { Arpa::Repositories::Resources::Finder}
+  let(:finder_repo_class) { Arpa::Repositories::Resources::Finder }
   let(:finder_repo)       { instance_double finder_repo_class }
 
   before do
@@ -24,7 +23,6 @@ describe Arpa::Services::Resources::Create::ResourceCreator, type: :service, fas
   end
 
   describe 'creating a new resource' do
-
     context 'when resource is invalid' do
       let(:errors) { instance_double('ActiveModel::Errors') }
 
@@ -40,7 +38,6 @@ describe Arpa::Services::Resources::Create::ResourceCreator, type: :service, fas
           expect(error.errors).not_to be_nil
         }
       end
-
     end
 
     context 'when resouce already exists' do
@@ -71,7 +68,6 @@ describe Arpa::Services::Resources::Create::ResourceCreator, type: :service, fas
       end
 
       context 'when build the resource with resourceable' do
-
         it 'entity resource should call new method' do
           expect(resource_entity_class).to have_received(:new).once
         end
@@ -80,8 +76,6 @@ describe Arpa::Services::Resources::Create::ResourceCreator, type: :service, fas
           expect(resource).to have_received(:build_correct_name).once
         end
       end
-
     end
-
   end
 end

data/spec/lib/arpa/services/resources/remove/resource_remover_spec.rb

@@ -1,17 +1,15 @@
 require 'spec_helper'
 
 describe Arpa::Services::Resources::Remove::ResourceRemover, type: :service, fast: true do
-
   let(:resource_001) { double full_name: 'UsersController' }
   let(:resource_002) { double full_name: 'OldContactsController' }
-  let(:resources)    { [resource_001, resource_002]}
+  let(:resources)    { [resource_001, resource_002] }
 
   let(:resourceable_001) { double to_s: 'UsersController' }
   let(:resourceable_002) { double to_s: 'ContactsController' }
-  let(:resourceables)    { [resourceable_001, resourceable_002]}
+  let(:resourceables)    { [resourceable_001, resourceable_002] }
 
   describe 'removing nonexistent resources' do
-
     let(:finder_repo_class) { Arpa::Repositories::Resources::Finder }
     let(:finder_repo)       { instance_double finder_repo_class }
 
@@ -44,7 +42,5 @@ describe Arpa::Services::Resources::Remove::ResourceRemover, type: :service, fas
       expect(remover_repo).to have_received(:destroy).once
       expect(remover_repo).to have_received(:destroy).with(resource_002).once
     end
-
   end
-
 end

data/spec/lib/arpa/services/resources/resource_manager_creator_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe Arpa::Services::Resources::ResourceManagerCreator, type: :service, fast: true do
-
   let(:action_remover)   { double }
   let(:resource_remover) { double }
   let(:resource_creator) { double }
   let(:action_creator)   { double }
   let(:element)          { double }
   let(:resourceables)    { [resourceable_001, resourceable_002] }
-  let(:params)           { {resourceables: resourceables, except_action_methods: ['some_method']} }
+  let(:params)           { { resourceables: resourceables, except_action_methods: ['some_method'] } }
   let(:success_proc)     { ->(r) {} }
-  let(:callback)         { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)         { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:resourceable_001) { double action_methods: [] }
-  let(:resourceable_002) { double action_methods: []}
+  let(:resourceable_002) { double action_methods: [] }
   let(:resource_created) { double }
 
   let(:setup_creators) do
@@ -52,7 +51,7 @@ describe Arpa::Services::Resources::ResourceManagerCreator, type: :service, fast
   end
 
   it 'action_remover should call :remove_nonexistent_actions with :action_params as parameter' do
-    expect(action_remover).to have_received(:remove_nonexistent_actions).with({resource: resource_created, actions_names: []}).twice
+    expect(action_remover).to have_received(:remove_nonexistent_actions).with(resource: resource_created, actions_names: []).twice
   end
 
   it 'resource_creator should call :create with :resourceable as parameter' do
@@ -61,11 +60,10 @@ describe Arpa::Services::Resources::ResourceManagerCreator, type: :service, fast
   end
 
   it 'action_creator should call :create_many with :action_params as parameter' do
-    expect(action_creator).to have_received(:create_many).with({resource: resource_created, actions_names: []}).twice
+    expect(action_creator).to have_received(:create_many).with(resource: resource_created, actions_names: []).twice
   end
 
   it 'success callback should be called with Array of resources as parameter' do
     expect(success_proc).to have_received(:call).with([resource_created, resource_created])
   end
-
 end

data/spec/lib/arpa/services/roles/create/role_creator_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Services::Roles::Create::RoleCreator, type: :service, fast: true do
-
   let(:role_entity_class) { Arpa::Entities::Role }
   let(:role)              { double }
   let(:params)            { double }
@@ -16,7 +15,6 @@ describe Arpa::Services::Roles::Create::RoleCreator, type: :service, fast: true
   end
 
   describe 'creating a new role' do
-
     context 'when role is invalid' do
       let(:errors) { instance_double('ActiveModel::Errors') }
 
@@ -32,7 +30,6 @@ describe Arpa::Services::Roles::Create::RoleCreator, type: :service, fast: true
           expect(error.errors).not_to be_nil
         }
       end
-
     end
 
     context 'when role is valid' do
@@ -55,14 +52,10 @@ describe Arpa::Services::Roles::Create::RoleCreator, type: :service, fast: true
       end
 
       context 'when build the role' do
-
         it 'entity role should call new method' do
           expect(role_entity_class).to have_received(:new).once
         end
-
       end
-
     end
-
   end
 end

data/spec/lib/arpa/services/roles/remove/role_remover_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
 describe Arpa::Services::Roles::Remove::RoleRemover, type: :service, fast: true do
-
   let(:role) { double }
 
   describe 'removing role' do
     let(:remover_repo_class) { Arpa::Repositories::Roles::Remover }
     let(:remover_repo)       { instance_double remover_repo_class }
-    let(:setup)              {  }
+    let(:setup)              {}
 
     before do
       allow(remover_repo_class).to receive(:new).and_return(remover_repo)
@@ -16,7 +15,6 @@ describe Arpa::Services::Roles::Remove::RoleRemover, type: :service, fast: true
     end
 
     context 'when role has no profiles' do
-
       let(:setup) do
         allow(role).to receive(:has_profile?).and_return(false)
         allow(remover_repo).to receive(:destroy)
@@ -29,11 +27,9 @@ describe Arpa::Services::Roles::Remove::RoleRemover, type: :service, fast: true
       it 'remover repository should call :new once' do
         expect(remover_repo_class).to have_received(:new).once
       end
-
     end
 
     context 'when role has profiles' do
-
       let(:setup) do
         allow(role).to receive(:has_profile?).and_return(true)
         allow(remover_repo).to receive(:disable)
@@ -42,9 +38,6 @@ describe Arpa::Services::Roles::Remove::RoleRemover, type: :service, fast: true
       it 'remover repository should call :disable once' do
         expect(remover_repo).to have_received(:disable).once
       end
-
     end
-
   end
-
 end

data/spec/lib/arpa/services/roles/role_manager_creator_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper'
 
 describe Arpa::Services::Roles::RoleManagerCreator, type: :service, fast: true do
-
   let(:role_creator) { double }
-  let(:params)           { {role: {name: 'role_name', description: 'role_description', action_ids: [1, 2]}} }
+  let(:params)           { { role: { name: 'role_name', description: 'role_description', action_ids: [1, 2] } } }
   let(:success_proc)     { ->(r) {} }
-  let(:callback)         { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)         { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:setup_creators) do
     allow(Arpa::Services::Roles::Create::RoleCreator).to receive(:new).and_return(role_creator)
@@ -27,5 +26,4 @@ describe Arpa::Services::Roles::RoleManagerCreator, type: :service, fast: true d
   it 'role_creator should call :create with parameters' do
     expect(role_creator).to have_received(:create).with(params[:role]).once
   end
-
 end

data/spec/lib/arpa/services/roles/role_manager_remover_spec.rb

@@ -1,12 +1,11 @@
 require 'spec_helper'
 
 describe Arpa::Services::Roles::RoleManagerRemover, type: :service, fast: true do
-
   let(:role_remover) { double }
   let(:role)         { double }
-  let(:params)       { {role: role} }
+  let(:params)       { { role: role } }
   let(:success_proc) { ->(r) {} }
-  let(:callback)     { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)     { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:setup_updaters) do
     allow(Arpa::Services::Roles::Remove::RoleRemover).to receive(:new).and_return(role_remover)
@@ -28,5 +27,4 @@ describe Arpa::Services::Roles::RoleManagerRemover, type: :service, fast: true d
   it 'role_remover should call :remove with role as parameter' do
     expect(role_remover).to have_received(:remove).with(role).once
   end
-
 end

data/spec/lib/arpa/services/roles/role_manager_updater_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper'
 
 describe Arpa::Services::Roles::RoleManagerUpdater, type: :service, fast: true do
-
   let(:role_updater) { double }
-  let(:params)       { {role: {name: 'role_name', description: 'role_description', action_ids: [1, 2]}} }
+  let(:params)       { { role: { name: 'role_name', description: 'role_description', action_ids: [1, 2] } } }
   let(:success_proc) { ->(r) {} }
-  let(:callback)     { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)     { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:setup_updaters) do
     allow(Arpa::Services::Roles::Update::RoleUpdater).to receive(:new).and_return(role_updater)
@@ -27,5 +26,4 @@ describe Arpa::Services::Roles::RoleManagerUpdater, type: :service, fast: true d
   it 'role_updater should call :update with parameters' do
     expect(role_updater).to have_received(:update).with(params[:role]).once
   end
-
 end

data/spec/lib/arpa/services/roles/update/role_updater_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Services::Roles::Update::RoleUpdater, type: :service, fast: true do
-
   let(:role_entity_class) { Arpa::Entities::Role }
   let(:role)              { double }
   let(:params)            { double }
@@ -16,7 +15,6 @@ describe Arpa::Services::Roles::Update::RoleUpdater, type: :service, fast: true
   end
 
   describe 'updating a role' do
-
     context 'when role is invalid' do
       let(:errors) { instance_double('ActiveModel::Errors') }
 
@@ -32,7 +30,6 @@ describe Arpa::Services::Roles::Update::RoleUpdater, type: :service, fast: true
           expect(error.errors).not_to be_nil
         }
       end
-
     end
 
     context 'when role is valid' do
@@ -55,14 +52,10 @@ describe Arpa::Services::Roles::Update::RoleUpdater, type: :service, fast: true
       end
 
       context 'when build the role' do
-
         it 'entity role should call new method' do
           expect(role_entity_class).to have_received(:new).once
         end
-
       end
-
     end
-
   end
 end

data/spec/lib/arpa/services/verifier_spec.rb

@@ -1,14 +1,13 @@
 require 'spec_helper'
 
 describe Arpa::Services::Verifier do
-  let(:current_user) { double is_arpa_admin?: false, profile_ids: [1,2,3] }
+  let(:current_user) { double is_arpa_admin?: false, profile_ids: [1, 2, 3] }
 
   subject(:verifier) { Arpa::Services::Verifier.new(current_user) }
 
   describe '#has_access?' do
-
     context 'when current_user is a arpa admin' do
-      let(:current_user) { double is_arpa_admin?: true, profile_ids: [1,2,3] }
+      let(:current_user) { double is_arpa_admin?: true, profile_ids: [1, 2, 3] }
 
       it 'should has access' do
         expect(subject.has_access?('home', 'some_action')).to be_truthy
@@ -38,10 +37,8 @@ describe Arpa::Services::Verifier do
       end
 
       it 'should be called :permissions from Arpa::Repositories::Actions::Finder' do
-        expect(action_finder).to have_received(:permission).with('users', 'index', [1,2,3]).once
+        expect(action_finder).to have_received(:permission).with('users', 'index', [1, 2, 3]).once
       end
-
     end
-
   end
 end

data/spec/lib/arpa/validators/action_validator_spec.rb

@@ -11,5 +11,4 @@ describe Arpa::Validators::ActionValidator, type: :validator, fast: true do
     it { expect(subject.errors).to be_added(:name, :blank) }
     it { expect(subject.errors).to be_added(:resource_id, :blank) }
   end
-
 end

data/spec/lib/arpa/validators/profile_validator_spec.rb

@@ -10,7 +10,6 @@ describe Arpa::Validators::ProfileValidator, type: :validator, fast: true do
   context 'when require' do
     it { expect(subject.errors).to be_added(:name, :blank) }
     it { expect(subject.errors).to be_added(:description, :blank) }
-    it { expect(subject.errors).to be_added(:role_ids, :many_blank) }
+    it { expect(subject.errors).to be_added(:role_ids, :blank) }
   end
-
 end

data/spec/lib/arpa/validators/resource_validator_spec.rb

@@ -11,5 +11,4 @@ describe Arpa::Validators::ResourceValidator, type: :validator, fast: true do
     it { expect(subject.errors).to be_added(:full_name, :blank) }
     it { expect(subject.errors).to be_added(:name, :blank) }
   end
-
 end

data/spec/lib/arpa/validators/role_validator_spec.rb

@@ -10,7 +10,6 @@ describe Arpa::Validators::RoleValidator, type: :validator, fast: true do
   context 'when require' do
     it { expect(subject.errors).to be_added(:name, :blank) }
     it { expect(subject.errors).to be_added(:description, :blank) }
-    it { expect(subject.errors).to be_added(:action_ids, :many_blank) }
+    it { expect(subject.errors).to be_added(:action_ids, :blank) }
   end
-
 end

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
 require 'active_record'
 require 'arpa'
 require 'database_cleaner'
-require 'factory_girl'
+require 'factory_bot'
 require 'support/repositories/test_repository'
 require 'i18n'
 
@@ -11,13 +11,12 @@ ActiveRecord::Base.establish_connection(adapter:  'sqlite3',
 load File.dirname(__FILE__) + '/support/schema.rb'
 
 I18n.config.enforce_available_locales = true
-I18n.load_path << File.expand_path('../../lib/config/locales/arpa.en.yml', __FILE__)
+I18n.load_path << File.expand_path('../lib/config/locales/arpa.en.yml', __dir__)
 I18n.reload!
 
 RSpec.configure do |config|
-
-  config.include FactoryGirl::Syntax::Methods
-  FactoryGirl.find_definitions
+  config.include FactoryBot::Syntax::Methods
+  FactoryBot.find_definitions
 
   config.before(:suite) do
     DatabaseCleaner.strategy = :transaction
@@ -29,5 +28,4 @@ RSpec.configure do |config|
       example.run
     end
   end
-
 end

data/spec/support/schema.rb

@@ -1,18 +1,18 @@
 ActiveRecord::Schema.define do
   self.verbose = false
 
-  create_table :test_repositories, :force => true do |t|
+  create_table :test_repositories, force: true do |t|
     t.string :name
     t.timestamps null: false
   end
 
-  create_table :repository_resources, :force => true do |t|
+  create_table :repository_resources, force: true do |t|
     t.string :name
     t.string :full_name
     t.timestamps null: false
   end
 
-  create_table :repository_actions, :force => true do |t|
+  create_table :repository_actions, force: true do |t|
     t.string :name
     t.references :repository_resource, index: true
     t.timestamps null: false
@@ -20,42 +20,41 @@ ActiveRecord::Schema.define do
 
   add_foreign_key :repository_actions, :repository_resources
 
-  create_table :repository_roles, :force => true do |t|
+  create_table :repository_roles, force: true do |t|
     t.string :name
     t.string :description
     t.boolean :removed, default: false
     t.timestamps null: false
   end
 
-  create_join_table :repository_actions, :repository_roles, :force => true do |t|
+  create_join_table :repository_actions, :repository_roles, force: true do |t|
     t.index :repository_action_id, name: 'action_role_id'
     t.index :repository_role_id, name: 'role_action_id'
   end
 
-  create_table :repository_profiles, :force => true do |t|
+  create_table :repository_profiles, force: true do |t|
     t.string :name
     t.string :description
     t.boolean :removed, default: false
     t.timestamps null: false
   end
 
-  create_join_table :repository_roles, :repository_profiles, :force => true do |t|
+  create_join_table :repository_roles, :repository_profiles, force: true do |t|
     t.index :repository_role_id, name: 'role_profile_id'
     t.index :repository_profile_id, name: 'profile_role_ids'
   end
 
-  create_table :users, :force => true do |t|
+  create_table :users, force: true do |t|
     t.string :name
     t.string :email
     t.timestamps null: false
   end
 
-  create_join_table :repository_profiles, :users, :force => true do |t|
+  create_join_table :repository_profiles, :users, force: true do |t|
     t.index :repository_profile_id, name: 'profile_user_id'
     t.index :user_id, name: 'user_profile_id'
   end
 
   add_column :repository_profiles, :entity_id, :integer, default: nil
   add_column :repository_profiles, :entity_class, :string, default: nil
-
 end