arpa 0.2.0 → 0.3.0

data/spec/lib/arpa/entities/role_spec.rb

@@ -1,13 +1,9 @@
 require 'spec_helper'
 
 describe Arpa::Entities::Role, type: :entity, fast: true do
-
   describe 'initializing' do
-
     describe 'setting default values' do
-
       context 'when pass some parameters as nil' do
-
         it 'attribute :action_ids should be an empty Array' do
           expect(subject.action_ids).to eq []
         end
@@ -27,7 +23,7 @@ describe Arpa::Entities::Role, type: :entity, fast: true do
     end
 
     context 'when pass some parameters as empty' do
-      let(:attrs) { {action_ids: '', actions: '', profiles: '', removed: ''} }
+      let(:attrs) { { action_ids: '', actions: '', profiles: '', removed: '' } }
       subject { Arpa::Entities::Role.new attrs }
 
       it 'attribute :action_ids should be an empty Array' do
@@ -46,7 +42,5 @@ describe Arpa::Entities::Role, type: :entity, fast: true do
         expect(subject.removed).to be_falsey
       end
     end
-
   end
-
 end

data/spec/lib/arpa/repositories/actions/finder_spec.rb

@@ -1,10 +1,9 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Actions::Finder, type: :repository, slow: true do
-
   let(:resource_record)   { create :repository_resource, :user }
   let(:action_record_001) { create :repository_action, :index, resource: resource_record }
-  let(:action_record_002) { create :repository_action, :show, resource: resource_record}
+  let(:action_record_002) { create :repository_action, :show, resource: resource_record }
 
   before do
     action_record_001
@@ -12,9 +11,7 @@ describe Arpa::Repositories::Actions::Finder, type: :repository, slow: true do
   end
 
   describe '#by_name_and_resource' do
-
     context 'when exist with the params' do
-
       let(:result) { subject.by_name_and_resource('index', resource_record) }
 
       it 'should return a resource with name "index"' do
@@ -27,14 +24,12 @@ describe Arpa::Repositories::Actions::Finder, type: :repository, slow: true do
     end
 
     context 'when nonexist with the params' do
-
       let(:result) { subject.by_name_and_resource('nonexist_action', resource_record) }
 
       it 'the result should return nil' do
         expect(result).to be_nil
       end
     end
-
   end
 
   describe 'getting permission from action_name, resource_name and profile_ids' do
@@ -71,11 +66,9 @@ describe Arpa::Repositories::Actions::Finder, type: :repository, slow: true do
     end
 
     context 'when action and resource not belogns to any profile' do
-
       it 'should not return any permission' do
         expect(result).to be_nil
       end
     end
   end
-
 end

data/spec/lib/arpa/repositories/base_spec.rb

@@ -5,33 +5,25 @@ class BaseImplementationTest
 end
 
 describe Arpa::Repositories::Base, type: :repository, fast: true do
-
   let(:base_implementation) { BaseImplementationTest.new }
 
   context 'when Implementation class do not override methods from Base' do
-
     context 'when call :mapper_instance' do
-
       it 'should raise NotImplementedError' do
         expect { base_implementation.mapper_instance }.to raise_error do |error|
           expect(error).to be_a NotImplementedError
           expect(error.message).to eql 'This BaseImplementationTest cannot respond :mapper_instance'
         end
       end
-
     end
 
     context 'when call :repository_class' do
-
       it 'should raise NotImplementedError' do
-        expect { base_implementation.repository_class}.to raise_error do |error|
+        expect { base_implementation.repository_class }.to raise_error do |error|
           expect(error).to be_a NotImplementedError
           expect(error.message).to eql 'This BaseImplementationTest cannot respond :repository_class'
         end
       end
-
     end
-
   end
-
 end

data/spec/lib/arpa/repositories/profiles/finder_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Profiles::Finder, type: :repository, slow: true do
-
   let(:record_001) { create :repository_profile, name: 'profile_01' }
   let(:record_002) { create :repository_profile, name: 'profile_02' }
 
@@ -20,7 +19,6 @@ describe Arpa::Repositories::Profiles::Finder, type: :repository, slow: true do
     it 'the result should be an Arpa::Entities::Profile' do
       expect(result).to be_an Arpa::Entities::Profile
     end
-
   end
 
   describe '#all' do
@@ -37,11 +35,9 @@ describe Arpa::Repositories::Profiles::Finder, type: :repository, slow: true do
     it 'the result should be an Array of Arpa::Entities::Profile' do
       expect(result.first).to be_an Arpa::Entities::Profile
     end
-
   end
 
   describe '#all_by_entity' do
-
     context 'when have profiles with differents entities' do
       let(:entity_001) { create :entity }
       let(:record_003) { create :repository_profile, name: 'profile_03', entity_id: entity_001.id, entity_class: entity_001.class }
@@ -72,8 +68,6 @@ describe Arpa::Repositories::Profiles::Finder, type: :repository, slow: true do
         expect(third.entity_id).to be == entity_001.id
         expect(third.entity_class).to eql entity_001.class.to_s
       end
-
     end
   end
-
 end

data/spec/lib/arpa/repositories/profiles/remover_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Profiles::Remover, type: :repository, slow: true do
-
   let(:created_profile) { create :repository_profile }
 
   before { created_profile }
@@ -12,7 +11,6 @@ describe Arpa::Repositories::Profiles::Remover, type: :repository, slow: true do
     it 'should destroy the role' do
       expect { destroy_profile }.to change(Arpa::Repositories::Profiles::RepositoryProfile, :count).by(-1)
     end
-
   end
 
   describe '#disable' do
@@ -25,7 +23,5 @@ describe Arpa::Repositories::Profiles::Remover, type: :repository, slow: true do
     it 'role should be setted to removed: true' do
       expect(disable_profile.removed).to be_truthy
     end
-
   end
-
 end

data/spec/lib/arpa/repositories/resources/finder_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Resources::Finder, type: :repository, slow: true do
-
   let(:record_001) { create :repository_resource, :user }
   let(:record_002) { create :repository_resource, :contact }
 
@@ -15,7 +14,6 @@ describe Arpa::Repositories::Resources::Finder, type: :repository, slow: true do
     it 'the result should be an Arpa::Entities::Resource' do
       expect(result).to be_an Arpa::Entities::Resource
     end
-
   end
 
   describe '#all' do
@@ -26,7 +24,6 @@ describe Arpa::Repositories::Resources::Finder, type: :repository, slow: true do
       record_002
     end
 
-
     it 'should return size 2' do
       expect(result.size).to be == 2
     end
@@ -38,18 +35,15 @@ describe Arpa::Repositories::Resources::Finder, type: :repository, slow: true do
     it 'the result should be an Array of Arpa::Entities::Resource' do
       expect(result.first).to be_an Arpa::Entities::Resource
     end
-
   end
 
   describe '#by_full_name' do
-
     before do
       record_001
       record_002
     end
 
     context 'when exist with the full_name' do
-
       let(:result) { subject.by_full_name('UsersController') }
 
       it 'should return a resource with name "users"' do
@@ -62,13 +56,11 @@ describe Arpa::Repositories::Resources::Finder, type: :repository, slow: true do
     end
 
     context 'when nonexist with the full_name' do
-
       let(:result) { subject.by_full_name('NonessController') }
 
       it 'the result should return nil' do
         expect(result).to be_nil
       end
     end
-
   end
 end

data/spec/lib/arpa/repositories/resources/remover_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Resources::Remover, type: :repository, slow: true do
-
   let(:resource_001)     { create :repository_resource, :user }
   let(:destroy_resource) { subject.destroy(resource_001) }
 
   describe '#destroy' do
-
     context 'when resource has no actions associate' do
       let(:actions) { [] }
 
@@ -31,8 +29,6 @@ describe Arpa::Repositories::Resources::Remover, type: :repository, slow: true d
       it 'should destroy all actions associate with resource' do
         expect { destroy_resource }.to change(Arpa::Repositories::Actions::RepositoryAction, :count).by(-2)
       end
-
     end
-
   end
 end

data/spec/lib/arpa/repositories/roles/finder_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Roles::Finder, type: :repository, slow: true do
-
   let(:record_001) { create :repository_role, name: 'role_01' }
   let(:record_002) { create :repository_role, name: 'role_02' }
 
@@ -20,7 +19,6 @@ describe Arpa::Repositories::Roles::Finder, type: :repository, slow: true do
     it 'the result should be an Arpa::Entities::Role' do
       expect(result).to be_an Arpa::Entities::Role
     end
-
   end
 
   describe '#all' do
@@ -37,7 +35,5 @@ describe Arpa::Repositories::Roles::Finder, type: :repository, slow: true do
     it 'the result should be an Array of Arpa::Entities::Role' do
       expect(result.first).to be_an Arpa::Entities::Role
     end
-
   end
-
 end

data/spec/lib/arpa/repositories/roles/remover_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Repositories::Roles::Remover, type: :repository, slow: true do
-
   let(:created_role) { create :repository_role }
 
   before { created_role }
@@ -12,7 +11,6 @@ describe Arpa::Repositories::Roles::Remover, type: :repository, slow: true do
     it 'should destroy the role' do
       expect { destroy_role }.to change(Arpa::Repositories::Roles::RepositoryRole, :count).by(-1)
     end
-
   end
 
   describe '#disable' do
@@ -25,7 +23,5 @@ describe Arpa::Repositories::Roles::Remover, type: :repository, slow: true do
     it 'role should be setted to removed: true' do
       expect(disable_role.removed).to be_truthy
     end
-
   end
-
 end

data/spec/lib/arpa/requests/profiles/create_request_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe "Create Profile", type: [:request, :profile] do
+RSpec.describe 'Create Profile', type: %i[request profile] do
   let(:finder_profile_repo)      { Arpa::Repositories::Profiles::Finder.new }
   let(:finder_resource_repo)     { Arpa::Repositories::Resources::Finder.new }
   let(:finder_role_repo)         { Arpa::Repositories::Roles::Finder.new }
@@ -8,28 +8,28 @@ RSpec.describe "Create Profile", type: [:request, :profile] do
   let(:creator_role_service)     { Arpa::Services::Roles::RoleManagerCreator.new }
   let(:creator_profile_service)  { Arpa::Services::Profiles::ProfileManagerCreator.new }
   let(:success_proc)             { ->(r) {} }
-  let(:callback)                 { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)                 { { success: success_proc, fail: ->(e) { raise e } } }
 
   context 'when have no created resources or actions' do
     let(:resourceable_001)  { double to_s: 'UsersController', action_methods: [:index, :show, 'edit'] }
     let(:resourceable_002)  { double to_s: 'ContactsController', action_methods: [:index, 'edit'] }
     let(:resourceables)     { [resourceable_001, resourceable_002] }
-    let(:created_resources) { creator_resource_service.create({resourceables: resourceables}, callback) }
+    let(:created_resources) { creator_resource_service.create({ resourceables: resourceables }, callback) }
 
-    let(:action_ids) { finder_resource_repo.all.first.actions.collect{ |action| action.id} }
-    let(:role_001_params)   { {role: {name: 'role_name_001', description: 'role_description_001', action_ids: action_ids}} }
-    let(:role_002_params)   { {role: {name: 'role_name_002', description: 'role_description_002', action_ids: action_ids}} }
+    let(:action_ids) { finder_resource_repo.all.first.actions.collect(&:id) }
+    let(:role_001_params)   { { role: { name: 'role_name_001', description: 'role_description_001', action_ids: action_ids } } }
+    let(:role_002_params)   { { role: { name: 'role_name_002', description: 'role_description_002', action_ids: action_ids } } }
     let(:created_roles) do
       creator_role_service.create(role_001_params, callback)
       creator_role_service.create(role_002_params, callback)
     end
 
-    let(:role_ids) { finder_role_repo.all.map { |r| r.id } }
+    let(:role_ids) { finder_role_repo.all.map(&:id) }
 
     before do
       created_resources
       created_roles
-      profile_params = {profile: {name: 'profile_name', description: 'profile_description', role_ids: role_ids}}
+      profile_params = { profile: { name: 'profile_name', description: 'profile_description', role_ids: role_ids } }
       creator_profile_service.create(profile_params, callback)
     end
 
@@ -42,10 +42,8 @@ RSpec.describe "Create Profile", type: [:request, :profile] do
     end
 
     context 'names of associated roles' do
-      it {expect(finder_profile_repo.all.first.roles.first.name).to eql 'role_name_001'}
-      it {expect(finder_profile_repo.all.first.roles.second.name).to eql 'role_name_002'}
+      it { expect(finder_profile_repo.all.first.roles.first.name).to eql 'role_name_001' }
+      it { expect(finder_profile_repo.all.first.roles.second.name).to eql 'role_name_002' }
     end
-
   end
-
 end

data/spec/lib/arpa/requests/profiles/remove_request_spec.rb

@@ -1,36 +1,31 @@
 require 'spec_helper'
 
-RSpec.describe "Remove Profile", type: [:request, :profile] do
+RSpec.describe 'Remove Profile', type: %i[request profile] do
   let(:finder_profile_repo)     { Arpa::Repositories::Profiles::Finder.new }
   let(:remover_profile_service) { Arpa::Services::Profiles::ProfileManagerRemover.new }
   let(:success_proc)            { ->(r) {} }
-  let(:callback)                { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)                { { success: success_proc, fail: ->(e) { raise e } } }
 
   describe 'removing a Profile' do
-
     before do
       create :repository_profile
       remover_profile_service.remove(profile_params_to_remove, callback)
     end
 
     context 'when need destroy a Profile' do
-      let(:profile_params_to_remove) { {profile: finder_profile_repo.all.first } }
+      let(:profile_params_to_remove) { { profile: finder_profile_repo.all.first } }
 
       it 'record should be removed ' do
         expect(finder_profile_repo.all.size).to be == 0
       end
-
     end
 
     context 'when need disable a Profile' do
-      let(:profile_params_to_remove) { {profile: finder_profile_repo.all.first, disable: true } }
+      let(:profile_params_to_remove) { { profile: finder_profile_repo.all.first, disable: true } }
 
       it 'record should be removed ' do
         expect(finder_profile_repo.all.size).to be == 0
       end
-
     end
-
   end
-
 end

data/spec/lib/arpa/requests/resources/create_request_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-RSpec.describe "Create Resource", type: [:request, :resource] do
+RSpec.describe 'Create Resource', type: %i[request resource] do
   let(:finder_repo)     { Arpa::Repositories::Resources::Finder.new }
   let(:creator_service) { Arpa::Services::Resources::ResourceManagerCreator.new }
   let(:success_proc)    { ->(r) {} }
-  let(:callback)        { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)        { { success: success_proc, fail: ->(e) { raise e } } }
 
   context 'when have no created resources or actions' do
     let(:resourceable_001) { double to_s: 'UsersController', action_methods: [:index, :show, 'edit'] }
@@ -12,7 +12,7 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
     let(:resourceables)    { [resourceable_001, resourceable_002] }
 
     before do
-      creator_service.create({resourceables: resourceables}, callback)
+      creator_service.create({ resourceables: resourceables }, callback)
     end
 
     it 'should be recorded two resources' do
@@ -20,8 +20,8 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
     end
 
     context 'names of resources' do
-      it {expect(finder_repo.all.first.name).to eql('contacts') }
-      it {expect(finder_repo.all.second.name).to eql('users') }
+      it { expect(finder_repo.all.first.name).to eql('contacts') }
+      it { expect(finder_repo.all.second.name).to eql('users') }
     end
 
     context 'Contacts resource' do
@@ -32,8 +32,8 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
       end
 
       context 'names of actions' do
-        it {expect(contacts_resource.actions.first.name).to eql('edit') }
-        it {expect(contacts_resource.actions.second.name).to eql('index') }
+        it { expect(contacts_resource.actions.first.name).to eql('edit') }
+        it { expect(contacts_resource.actions.second.name).to eql('index') }
       end
     end
 
@@ -45,11 +45,10 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
       end
 
       context 'names of actions' do
-        it {expect(users_resource.actions.first.name).to eql('edit') }
-        it {expect(users_resource.actions.second.name).to eql('index') }
-        it {expect(users_resource.actions.third.name).to eql('show') }
+        it { expect(users_resource.actions.first.name).to eql('edit') }
+        it { expect(users_resource.actions.second.name).to eql('index') }
+        it { expect(users_resource.actions.third.name).to eql('show') }
       end
-
     end
   end
 
@@ -63,8 +62,8 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
     let(:new_resourceables) { [resourceable_003, resourceable_004] }
 
     before do
-      creator_service.create({resourceables: created_resourceables}, callback)
-      creator_service.create({resourceables: new_resourceables}, callback)
+      creator_service.create({ resourceables: created_resourceables }, callback)
+      creator_service.create({ resourceables: new_resourceables }, callback)
     end
 
     it 'should be recorded two resources' do
@@ -72,8 +71,8 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
     end
 
     context 'names of resources' do
-      it {expect(finder_repo.all.first.name).to eql('arpa/new_users') }
-      it {expect(finder_repo.all.second.name).to eql('contacts') }
+      it { expect(finder_repo.all.first.name).to eql('arpa/new_users') }
+      it { expect(finder_repo.all.second.name).to eql('contacts') }
     end
 
     context 'Contacts resource' do
@@ -84,8 +83,8 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
       end
 
       context 'names of actions' do
-        it {expect(contacts_resource.actions.first.name).to eql('index') }
-        it {expect(contacts_resource.actions.second.name).to eql('new_edit') }
+        it { expect(contacts_resource.actions.first.name).to eql('index') }
+        it { expect(contacts_resource.actions.second.name).to eql('new_edit') }
       end
     end
 
@@ -97,11 +96,9 @@ RSpec.describe "Create Resource", type: [:request, :resource] do
       end
 
       context 'names of actions' do
-        it {expect(users_resource.actions.first.name).to eql('edit') }
-        it {expect(users_resource.actions.second.name).to eql('show') }
+        it { expect(users_resource.actions.first.name).to eql('edit') }
+        it { expect(users_resource.actions.second.name).to eql('show') }
       end
-
     end
   end
-
 end