arpa 0.2.0 → 0.3.0

data/spec/lib/arpa/requests/roles/create_request_spec.rb

@@ -1,24 +1,24 @@
 require 'spec_helper'
 
-RSpec.describe "Create Role", type: [:request, :role] do
+RSpec.describe 'Create Role', type: %i[request role] do
   let(:finder_role_repo)         { Arpa::Repositories::Roles::Finder.new }
   let(:finder_resource_repo)     { Arpa::Repositories::Resources::Finder.new }
   let(:creator_resource_service) { Arpa::Services::Resources::ResourceManagerCreator.new }
   let(:creator_role_service)     { Arpa::Services::Roles::RoleManagerCreator.new }
   let(:success_proc)             { ->(r) {} }
-  let(:callback)                 { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)                 { { success: success_proc, fail: ->(e) { raise e } } }
 
   context 'when have no created resources or actions' do
     let(:resourceable_001)  { double to_s: 'UsersController', action_methods: [:index, :show, 'edit'] }
     let(:resourceable_002)  { double to_s: 'ContactsController', action_methods: [:index, 'edit'] }
     let(:resourceables)     { [resourceable_001, resourceable_002] }
-    let(:created_resources) { creator_resource_service.create({resourceables: resourceables}, callback) }
+    let(:created_resources) { creator_resource_service.create({ resourceables: resourceables }, callback) }
 
-    let(:action_ids) { finder_resource_repo.all.first.actions.collect {|action| action.id} }
+    let(:action_ids) { finder_resource_repo.all.first.actions.collect(&:id) }
 
     before do
       created_resources
-      role_params = {role: {name: 'role_name', description: 'role_description', action_ids: action_ids}}
+      role_params = { role: { name: 'role_name', description: 'role_description', action_ids: action_ids } }
       creator_role_service.create(role_params, callback)
     end
 
@@ -31,10 +31,8 @@ RSpec.describe "Create Role", type: [:request, :role] do
     end
 
     context 'names of associated actions' do
-      it {expect(finder_role_repo.all.first.actions.first.name).to eql 'edit'}
-      it {expect(finder_role_repo.all.first.actions.second.name).to eql 'index'}
+      it { expect(finder_role_repo.all.first.actions.first.name).to eql 'edit' }
+      it { expect(finder_role_repo.all.first.actions.second.name).to eql 'index' }
     end
-
   end
-
 end

data/spec/lib/arpa/requests/roles/remove_request_spec.rb

@@ -1,23 +1,20 @@
 require 'spec_helper'
 
-RSpec.describe "Remove Role", type: [:request, :role] do
+RSpec.describe 'Remove Role', type: %i[request role] do
   let(:finder_role_repo)     { Arpa::Repositories::Roles::Finder.new }
   let(:remover_role_service) { Arpa::Services::Roles::RoleManagerRemover.new }
   let(:success_proc)         { ->(r) {} }
-  let(:callback)             { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)             { { success: success_proc, fail: ->(e) { raise e } } }
 
   describe 'removing a Role' do
-
     before do
       create :repository_role
-      role_params_to_remove = {role: finder_role_repo.all.first }
+      role_params_to_remove = { role: finder_role_repo.all.first }
       remover_role_service.remove(role_params_to_remove, callback)
     end
 
     it 'record should be removed ' do
       expect(finder_role_repo.all.size).to be == 0
     end
-
   end
-
 end

data/spec/lib/arpa/requests/roles/update_request_spec.rb

@@ -1,31 +1,31 @@
 require 'spec_helper'
 
-RSpec.describe "Update Role", type: [:request, :role] do
+RSpec.describe 'Update Role', type: %i[request role] do
   let(:finder_role_repo)         { Arpa::Repositories::Roles::Finder.new }
   let(:finder_resource_repo)     { Arpa::Repositories::Resources::Finder.new }
   let(:creator_resource_service) { Arpa::Services::Resources::ResourceManagerCreator.new }
   let(:creator_role_service)     { Arpa::Services::Roles::RoleManagerCreator.new }
   let(:updater_role_service)     { Arpa::Services::Roles::RoleManagerUpdater.new }
   let(:success_proc)             { ->(r) {} }
-  let(:callback)                 { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)                 { { success: success_proc, fail: ->(e) { raise e } } }
 
   context 'updating a Role' do
     let(:resourceable_001)  { double to_s: 'UsersController', action_methods: [:index, :show, 'edit'] }
     let(:resourceable_002)  { double to_s: 'ContactsController', action_methods: [:index, 'edit'] }
     let(:resourceables)     { [resourceable_001, resourceable_002] }
-    let(:created_resources) { creator_resource_service.create({resourceables: resourceables}, callback) }
-    let(:action_ids) { finder_resource_repo.all.first.actions.collect {|action| action.id} }
+    let(:created_resources) { creator_resource_service.create({ resourceables: resourceables }, callback) }
+    let(:action_ids) { finder_resource_repo.all.first.actions.collect(&:id) }
 
     let(:create_resources_and_role) do
       created_resources
-      role_params = {role: {name: 'role_name', description: 'role_description', action_ids: action_ids}}
+      role_params = { role: { name: 'role_name', description: 'role_description', action_ids: action_ids } }
       creator_role_service.create(role_params, callback)
     end
 
     before do
       create_resources_and_role
       found_role = finder_role_repo.all.first
-      role_params_to_update = {role: {id: found_role.id, name: 'updated_role_name', description: 'role_description', action_ids: [action_ids[0]] }}
+      role_params_to_update = { role: { id: found_role.id, name: 'updated_role_name', description: 'role_description', action_ids: [action_ids[0]] } }
       updater_role_service.update(role_params_to_update, callback)
     end
 
@@ -42,9 +42,7 @@ RSpec.describe "Update Role", type: [:request, :role] do
     end
 
     context 'names of associated actions' do
-      it {expect(finder_role_repo.all.first.actions.first.name).to eql 'edit'}
+      it { expect(finder_role_repo.all.first.actions.first.name).to eql 'edit' }
     end
-
   end
-
 end

data/spec/lib/arpa/services/actions/create/action_creator_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe Arpa::Services::Actions::Create::ActionCreator, type: :service, fast: true do
-
   let(:action_entity_class) { Arpa::Entities::Action }
   let(:action)              { double }
   let(:resource)            { double id: 1 }
-  let(:actions_names)       { ['index', 'new'] }
-  let(:params)              { {resource: resource, actions_names: actions_names} }
+  let(:actions_names)       { %w[index new] }
+  let(:params)              { { resource: resource, actions_names: actions_names } }
   let(:action_found)        { nil }
 
   let(:actions_created) { subject.create_many(params) }
   let(:validator_class) { Arpa::Validators::ActionValidator }
   let(:validator)       { instance_double validator_class }
 
-  let(:finder_repo_class) { Arpa::Repositories::Actions::Finder}
+  let(:finder_repo_class) { Arpa::Repositories::Actions::Finder }
   let(:finder_repo)       { instance_double finder_repo_class }
 
   before do
@@ -25,7 +24,6 @@ describe Arpa::Services::Actions::Create::ActionCreator, type: :service, fast: t
   end
 
   describe 'creating a new action' do
-
     context 'when resource is invalid' do
       let(:errors) { instance_double('ActiveModel::Errors') }
 
@@ -41,7 +39,6 @@ describe Arpa::Services::Actions::Create::ActionCreator, type: :service, fast: t
           expect(error.errors).not_to be_nil
         }
       end
-
     end
 
     context 'when actino already exists' do
@@ -50,7 +47,6 @@ describe Arpa::Services::Actions::Create::ActionCreator, type: :service, fast: t
       it 'should return the action found' do
         expect(actions_created).to eq [action_found, action_found]
       end
-
     end
 
     context 'when resource is valid' do
@@ -73,16 +69,11 @@ describe Arpa::Services::Actions::Create::ActionCreator, type: :service, fast: t
       end
 
       context 'when build an instance of action' do
-
         it 'entity action should call new method' do
-          expect(action_entity_class).to have_received(:new).with({resource_id: resource.id, name: 'index'}).once
-          expect(action_entity_class).to have_received(:new).with({resource_id: resource.id, name: 'new'}).once
+          expect(action_entity_class).to have_received(:new).with(resource_id: resource.id, name: 'index').once
+          expect(action_entity_class).to have_received(:new).with(resource_id: resource.id, name: 'new').once
         end
-
       end
-
     end
-
   end
-
 end

data/spec/lib/arpa/services/actions/remove/action_remover_spec.rb

@@ -1,15 +1,14 @@
 require 'spec_helper'
 
 describe Arpa::Services::Actions::Remove::ActionRemover, type: :service, fast: true do
-
   let(:action_001) { double name: 'index' }
   let(:action_002) { double name: 'old_index' }
-  let(:actions)    { [action_001, action_002]}
+  let(:actions)    { [action_001, action_002] }
   let(:resource)   { double actions: actions }
 
-  let(:actions_names) { ['index', 'show'] }
+  let(:actions_names) { %w[index show] }
 
-  let(:params) { {resource: resource, actions_names: actions_names} }
+  let(:params) { { resource: resource, actions_names: actions_names } }
 
   describe 'removing nonexistent actions' do
     let(:remover_repo_class) { Arpa::Repositories::Actions::Remover }
@@ -30,7 +29,5 @@ describe Arpa::Services::Actions::Remove::ActionRemover, type: :service, fast: t
       expect(remover_repo).to have_received(:destroy).once
       expect(remover_repo).to have_received(:destroy).with(action_002).once
     end
-
   end
-
 end

data/spec/lib/arpa/services/base_spec.rb

@@ -9,29 +9,27 @@ end
 class ManagerImplementationTest
   include Arpa::Services::Base
 
-  def create_raise callback
+  def create_raise(callback)
     manager_action callback do
-      raise Exceptions::RecordInvalid.new 'some error'
+      raise Exceptions::RecordInvalid, 'some error'
     end
   end
 
-  def create callback
+  def create(callback)
     manager_action callback do
       'success'
     end
   end
-
 end
 
 describe Arpa::Services::Base, type: :service, fast: true do
-
   let(:manager_implementation) { ManagerImplementationTest.new }
-  let(:callback) {
+  let(:callback) do
     {
-      success: -> (result) {},
-      fail: -> (exception){}
+      success: ->(result) {},
+      fail: ->(exception) {}
     }
-  }
+  end
 
   describe 'calling .transaction' do
     before do
@@ -47,7 +45,6 @@ describe Arpa::Services::Base, type: :service, fast: true do
       it 'transaction_class should call .transaction' do
         expect(transaction_class).to have_received(:transaction)
       end
-
     end
 
     context 'when use a custom transaction_class' do
@@ -57,7 +54,6 @@ describe Arpa::Services::Base, type: :service, fast: true do
       it 'transaction_class should call .transaction' do
         expect(transaction_class).to have_received(:transaction)
       end
-
     end
   end
 
@@ -83,12 +79,9 @@ describe Arpa::Services::Base, type: :service, fast: true do
         manager_implementation.create_raise callback
       end
 
-
       it 'should call the callback[:fail] with Exceptions::RecordInvalid' do
-        expect(callback[:fail]).to have_received(:call).with(kind_of StandardError)
+        expect(callback[:fail]).to have_received(:call).with(kind_of(StandardError))
       end
-
     end
   end
-
 end

data/spec/lib/arpa/services/profiles/create/profile_creator_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Services::Profiles::Create::ProfileCreator, type: :service, fast: true do
-
   let(:profile_entity_class) { Arpa::Entities::Profile }
   let(:profile)              { double }
   let(:params)               { double }
@@ -16,7 +15,6 @@ describe Arpa::Services::Profiles::Create::ProfileCreator, type: :service, fast:
   end
 
   describe 'creating a new profile' do
-
     context 'when profile is invalid' do
       let(:errors) { instance_double('ActiveModel::Errors') }
 
@@ -32,7 +30,6 @@ describe Arpa::Services::Profiles::Create::ProfileCreator, type: :service, fast:
           expect(error.errors).not_to be_nil
         }
       end
-
     end
 
     context 'when profile is valid' do
@@ -55,14 +52,10 @@ describe Arpa::Services::Profiles::Create::ProfileCreator, type: :service, fast:
       end
 
       context 'when build the profile' do
-
         it 'entity profile should call new method' do
           expect(profile_entity_class).to have_received(:new).once
         end
-
       end
-
     end
-
   end
 end

data/spec/lib/arpa/services/profiles/profile_manager_creator_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper'
 
 describe Arpa::Services::Profiles::ProfileManagerCreator, type: :service, fast: true do
-
   let(:profile_creator) { double }
-  let(:params)          { {profile: {name: 'profile_name', description: 'profile_description', role_ids: [1, 2]}} }
+  let(:params)          { { profile: { name: 'profile_name', description: 'profile_description', role_ids: [1, 2] } } }
   let(:success_proc)    { ->(r) {} }
-  let(:callback)        { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)        { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:setup_creators) do
     allow(Arpa::Services::Profiles::Create::ProfileCreator).to receive(:new).and_return(profile_creator)
@@ -27,5 +26,4 @@ describe Arpa::Services::Profiles::ProfileManagerCreator, type: :service, fast:
   it 'profile_creator should call :create with parameters' do
     expect(profile_creator).to have_received(:create).with(params[:profile]).once
   end
-
 end

data/spec/lib/arpa/services/profiles/profile_manager_remover_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper'
 
 describe Arpa::Services::Profiles::ProfileManagerRemover, type: :service, fast: true do
-
   let(:profile_remover) { double }
   let(:profile)         { double }
   let(:success_proc)    { ->(r) {} }
-  let(:callback)        { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)        { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:setup_updaters) do
     allow(Arpa::Services::Profiles::Remove::ProfileRemover).to receive(:new).and_return(profile_remover)
@@ -25,7 +24,7 @@ describe Arpa::Services::Profiles::ProfileManagerRemover, type: :service, fast:
   end
 
   context 'when is to destroy' do
-    let(:params) { {profile: profile} }
+    let(:params) { { profile: profile } }
 
     it 'profile_remover should call :remove with profile as parameter' do
       expect(profile_remover).to have_received(:remove).with(profile, nil).once
@@ -33,12 +32,10 @@ describe Arpa::Services::Profiles::ProfileManagerRemover, type: :service, fast:
   end
 
   context 'when is to disable' do
-    let(:params) { {profile: profile, disable: true} }
+    let(:params) { { profile: profile, disable: true } }
 
     it 'profile_remover should call :remove with profile and disable: true as parameter' do
       expect(profile_remover).to have_received(:remove).with(profile, true).once
     end
-
   end
-
 end

data/spec/lib/arpa/services/profiles/profile_manager_updater_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper'
 
 describe Arpa::Services::Profiles::ProfileManagerUpdater, type: :service, fast: true do
-
   let(:profile_updater) { double }
-  let(:params)          { {profile: {name: 'profile_name', description: 'profile_description', role_ids: [1, 2]}} }
+  let(:params)          { { profile: { name: 'profile_name', description: 'profile_description', role_ids: [1, 2] } } }
   let(:success_proc)    { ->(r) {} }
-  let(:callback)        { {success: success_proc, fail: ->(e) {raise e} } }
+  let(:callback)        { { success: success_proc, fail: ->(e) { raise e } } }
 
   let(:setup_updaters) do
     allow(Arpa::Services::Profiles::Update::ProfileUpdater).to receive(:new).and_return(profile_updater)
@@ -27,5 +26,4 @@ describe Arpa::Services::Profiles::ProfileManagerUpdater, type: :service, fast:
   it 'profile_updater should call :update with parameters' do
     expect(profile_updater).to have_received(:update).with(params[:profile]).once
   end
-
 end

data/spec/lib/arpa/services/profiles/remove/profile_remover_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Services::Profiles::Remove::ProfileRemover, type: :service, fast: true do
-
   let(:profile) { double }
 
   describe 'removing profile' do
@@ -26,7 +25,6 @@ describe Arpa::Services::Profiles::Remove::ProfileRemover, type: :service, fast:
       it 'remover repository should call :new once' do
         expect(remover_repo_class).to have_received(:new).once
       end
-
     end
 
     context 'when pass true as disable param' do
@@ -37,9 +35,6 @@ describe Arpa::Services::Profiles::Remove::ProfileRemover, type: :service, fast:
       it 'remover repository should call :disable once' do
         expect(remover_repo).to have_received(:disable).once
       end
-
     end
-
   end
-
 end

data/spec/lib/arpa/services/profiles/update/profile_updater_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Arpa::Services::Profiles::Update::ProfileUpdater, type: :service, fast: true do
-
   let(:role_entity_class) { Arpa::Entities::Profile }
   let(:profile)           { double }
   let(:params)            { double }
@@ -16,7 +15,6 @@ describe Arpa::Services::Profiles::Update::ProfileUpdater, type: :service, fast:
   end
 
   describe 'updating a profile' do
-
     context 'when profile is invalid' do
       let(:errors) { instance_double('ActiveModel::Errors') }
 
@@ -32,7 +30,6 @@ describe Arpa::Services::Profiles::Update::ProfileUpdater, type: :service, fast:
           expect(error.errors).not_to be_nil
         }
       end
-
     end
 
     context 'when profile is valid' do
@@ -55,14 +52,10 @@ describe Arpa::Services::Profiles::Update::ProfileUpdater, type: :service, fast:
       end
 
       context 'when build the profile' do
-
         it 'entity profile should call new method' do
           expect(role_entity_class).to have_received(:new).once
         end
-
       end
-
     end
-
   end
 end