arpa 0.2.0 → 0.3.0

data/lib/arpa/entities/profile.rb

@@ -1,9 +1,8 @@
 module Arpa
   module Entities
     class Profile
-
       attr_reader :id, :name, :description, :role_ids, :roles, :entity_id, :entity_class,
-        :created_at, :updated_at, :removed
+                  :created_at, :updated_at, :removed
 
       def initialize(attrs = {})
         attrs = attrs.with_indifferent_access
@@ -21,11 +20,11 @@ module Arpa
       end
 
       private
+
       def default_value_to_nil_or_empty(attr_value, default_value)
         return attr_value if attr_value.present?
         default_value
       end
-
     end
   end
 end

data/lib/arpa/entities/resource.rb

@@ -1,7 +1,6 @@
 module Arpa
   module Entities
     class Resource
-
       attr_reader :id, :full_name, :name, :created_at, :updated_at, :actions
 
       def initialize(attrs = {})
@@ -24,10 +23,10 @@ module Arpa
 
       def adjust_name(name)
         parts_of_name   = name.split '::'
-        refactored_name = String.new
+        refactored_name = ''
 
         parts_of_name.each_with_index do |part, index|
-          refactored_name << '/' if index > 0
+          refactored_name << '/' if index.positive?
           refactored_name << change_to_snake_case(part)
         end
 
@@ -42,17 +41,16 @@ module Arpa
 
       def change_to_snake_case(name)
         parts_of_name   = name.split(/(?=[A-Z])/) # Split at CamelCase
-        refactored_name = String.new
+        refactored_name = ''
 
         parts_of_name.each_with_index do |part, index|
           part.downcase!
-          refactored_name << '_' if index > 0
+          refactored_name << '_' if index.positive?
           refactored_name << part
         end
 
         refactored_name
       end
-
     end
   end
 end

data/lib/arpa/entities/role.rb

@@ -1,9 +1,8 @@
 module Arpa
   module Entities
     class Role
-
       attr_reader :id, :name, :description, :created_at, :updated_at, :removed,
-        :action_ids, :actions, :profiles
+                  :action_ids, :actions, :profiles
 
       def initialize(attrs = {})
         attrs = attrs.with_indifferent_access
@@ -24,11 +23,11 @@ module Arpa
       end
 
       private
+
       def default_value_to_nil_or_empty(attr_value, default_value)
         return attr_value if attr_value.present?
         default_value
       end
-
     end
   end
 end

data/lib/arpa/exceptions/record_invalid.rb

@@ -7,7 +7,6 @@ module Arpa
         super(args[:message])
         @errors = args[:errors]
       end
-
     end
   end
 end

data/lib/arpa/repositories/actions/creator.rb

@@ -11,7 +11,6 @@ module Arpa
         def repository_class
           RepositoryAction
         end
-
       end
     end
   end

data/lib/arpa/repositories/actions/finder.rb

@@ -11,11 +11,11 @@ module Arpa
 
         def permission(resource_name, action_name, profile_ids)
           record = repository_class
-            .distinct(true)
-            .joins(:resource, roles: :profiles)
-            .find_by(repository_profiles: {id: profile_ids},
-                     repository_resources: {name: resource_name},
-                     name: action_name)
+                   .distinct(true)
+                   .joins(:resource, roles: :profiles)
+                   .find_by(repository_profiles: { id: profile_ids },
+                            repository_resources: { name: resource_name },
+                            name: action_name)
           mapper_instance.map_to_entity(record) if record
         end
 
@@ -26,7 +26,6 @@ module Arpa
         def repository_class
           RepositoryAction
         end
-
       end
     end
   end

data/lib/arpa/repositories/actions/remover.rb

@@ -15,7 +15,6 @@ module Arpa
         def repository_class
           RepositoryAction
         end
-
       end
     end
   end

data/lib/arpa/repositories/actions/repository_action.rb

@@ -2,13 +2,12 @@ module Arpa
   module Repositories
     module Actions
       class RepositoryAction < ActiveRecord::Base
-        default_scope {order(name: :asc)}
+        default_scope { order(name: :asc) }
 
         alias_attribute :resource_id, :repository_resource_id
         belongs_to :resource, foreign_key: 'repository_resource_id', class_name: 'Arpa::Repositories::Resources::RepositoryResource'
 
         has_and_belongs_to_many :roles, class_name: 'Arpa::Repositories::Roles::RepositoryRole'
-
       end
     end
   end

data/lib/arpa/repositories/base.rb

@@ -1,7 +1,6 @@
 module Arpa
   module Repositories
     module Base
-
       def mapper_instance
         raise NotImplementedError, "This #{self.class} cannot respond :mapper_instance"
       end
@@ -9,7 +8,6 @@ module Arpa
       def repository_class
         raise NotImplementedError, "This #{self.class} cannot respond :repository_class"
       end
-
     end
   end
 end

data/lib/arpa/repositories/profiles/creator.rb

@@ -11,7 +11,6 @@ module Arpa
         def repository_class
           RepositoryProfile
         end
-
       end
     end
   end

data/lib/arpa/repositories/profiles/finder.rb

@@ -17,9 +17,9 @@ module Arpa
 
         def all_by_entity(entity_id, entity_class)
           repository_class
-            .where("( (entity_id is null AND entity_class is null) OR (entity_id = '#{entity_id}' AND entity_class = '#{entity_class}') )" )
+            .where("( (entity_id is null AND entity_class is null) OR (entity_id = '#{entity_id}' AND entity_class = '#{entity_class}') )")
             .collect do |record|
-              mapper_instance.map_to_entity(record)
+            mapper_instance.map_to_entity(record)
           end
         end
 
@@ -30,7 +30,6 @@ module Arpa
         def repository_class
           RepositoryProfile
         end
-
       end
     end
   end

data/lib/arpa/repositories/profiles/remover.rb

@@ -22,7 +22,6 @@ module Arpa
         def repository_class
           RepositoryProfile
         end
-
       end
     end
   end

data/lib/arpa/repositories/profiles/repository_profile.rb

@@ -2,10 +2,9 @@ module Arpa
   module Repositories
     module Profiles
       class RepositoryProfile < ActiveRecord::Base
-        default_scope {where(removed: false).order(name: :asc)}
+        default_scope { where(removed: false).order(name: :asc) }
 
         has_and_belongs_to_many :roles, class_name: 'Arpa::Repositories::Roles::RepositoryRole'
-
       end
     end
   end

data/lib/arpa/repositories/profiles/updater.rb

@@ -16,7 +16,6 @@ module Arpa
         def repository_class
           RepositoryProfile
         end
-
       end
     end
   end

data/lib/arpa/repositories/registrator.rb

@@ -4,9 +4,7 @@ module Arpa
       include Base
 
       def create(entity)
-        save(entity) do |record|
-          record.save!
-        end
+        save(entity, &:save!)
       end
 
       def update(entity)
@@ -24,10 +22,10 @@ module Arpa
 
       private
 
-      def save(entity, &block)
-        record = mapper_instance.map_to_record( entity)
+      def save(entity)
+        record = mapper_instance.map_to_record(entity)
         begin
-          block.call(record)
+          yield(record)
         rescue ActiveRecord::RecordInvalid => invalid
           raise Arpa::Exceptions::RecordInvalid.new(message: invalid.message, errors: invalid.record.errors)
         end
@@ -35,10 +33,7 @@ module Arpa
         mapper_instance.map_to_entity(record)
       end
 
-      def post_update(entity, record)
-      end
-
+      def post_update(entity, record); end
     end
   end
 end
-

data/lib/arpa/repositories/resources/creator.rb

@@ -11,7 +11,6 @@ module Arpa
         def repository_class
           RepositoryResource
         end
-
       end
     end
   end

data/lib/arpa/repositories/resources/finder.rb

@@ -27,7 +27,6 @@ module Arpa
         def repository_class
           RepositoryResource
         end
-
       end
     end
   end

data/lib/arpa/repositories/resources/remover.rb

@@ -15,7 +15,6 @@ module Arpa
         def repository_class
           RepositoryResource
         end
-
       end
     end
   end

data/lib/arpa/repositories/resources/repository_resource.rb

@@ -2,10 +2,9 @@ module Arpa
   module Repositories
     module Resources
       class RepositoryResource < ActiveRecord::Base
-        default_scope {order(name: :asc)}
+        default_scope { order(name: :asc) }
 
         has_many :actions, dependent: :destroy, class_name: 'Arpa::Repositories::Actions::RepositoryAction'
-
       end
     end
   end

data/lib/arpa/repositories/roles/creator.rb

@@ -11,7 +11,6 @@ module Arpa
         def repository_class
           RepositoryRole
         end
-
       end
     end
   end

data/lib/arpa/repositories/roles/finder.rb

@@ -22,7 +22,6 @@ module Arpa
         def repository_class
           RepositoryRole
         end
-
       end
     end
   end

data/lib/arpa/repositories/roles/remover.rb

@@ -22,7 +22,6 @@ module Arpa
         def repository_class
           RepositoryRole
         end
-
       end
     end
   end

data/lib/arpa/repositories/roles/repository_role.rb

@@ -2,11 +2,10 @@ module Arpa
   module Repositories
     module Roles
       class RepositoryRole < ActiveRecord::Base
-        default_scope {where(removed: false).order(name: :asc)}
+        default_scope { where(removed: false).order(name: :asc) }
 
         has_and_belongs_to_many :actions, class_name: 'Arpa::Repositories::Actions::RepositoryAction'
         has_and_belongs_to_many :profiles, class_name: 'Arpa::Repositories::Profiles::RepositoryProfile'
-
       end
     end
   end

data/lib/arpa/repositories/roles/updater.rb

@@ -16,7 +16,6 @@ module Arpa
         def repository_class
           RepositoryRole
         end
-
       end
     end
   end

data/lib/arpa/services/actions/create/action_creator.rb

@@ -3,7 +3,6 @@ module Arpa
     module Actions
       module Create
         class ActionCreator
-
           def create_many(params)
             params[:actions_names].collect do |action_name|
               create(action_params(params, action_name))
@@ -23,7 +22,7 @@ module Arpa
           private
 
           def action_params(params, action_name)
-            {name: action_name, resource_id: params[:resource].id}
+            { name: action_name, resource_id: params[:resource].id }
           end
 
           def action_instance(params)
@@ -42,7 +41,6 @@ module Arpa
           def creator_repo
             @creator_repo ||= Arpa::Repositories::Actions::Creator.new
           end
-
         end
       end
     end

data/lib/arpa/services/actions/remove/action_remover.rb

@@ -3,7 +3,6 @@ module Arpa
     module Actions
       module Remove
         class ActionRemover
-
           def remove_nonexistent_actions(params)
             params[:resource].actions.each do |action|
               exist = params[:actions_names].include?(action.name)
@@ -16,7 +15,6 @@ module Arpa
           def remover_repo
             @remover_repo ||= Arpa::Repositories::Actions::Remover.new
           end
-
         end
       end
     end

data/lib/arpa/services/base.rb

@@ -1,19 +1,16 @@
 module Arpa
   module Services
     module Base
-
       def self.included(base)
         base.extend ClassMethods
       end
 
-      def manager_action callback, &block
+      def manager_action(callback)
         begin_transaction do
-          begin
-            result = block.call
-            callback[:success].call result
-          rescue => e
-            callback[:fail].call e
-          end
+          result = yield
+          callback[:success].call result
+        rescue StandardError => e
+          callback[:fail].call e
         end
       end
 
@@ -26,7 +23,7 @@ module Arpa
       end
 
       module ClassMethods
-        def repository_transaction repository_transaction_class
+        def repository_transaction(repository_transaction_class)
           @repository_transaction = repository_transaction_class
         end
 
@@ -34,7 +31,6 @@ module Arpa
           @repository_transaction ||= 'ActiveRecord::Base'
           @repository_transaction.constantize
         end
-
       end
     end
   end

data/lib/arpa/services/profiles/create/profile_creator.rb

@@ -3,7 +3,6 @@ module Arpa
     module Profiles
       module Create
         class ProfileCreator
-
           def create(params)
             profile = profile_instance(params)
             validate_profile(profile)
@@ -24,7 +23,6 @@ module Arpa
           def creator_repo
             @creator_repo ||= Arpa::Repositories::Profiles::Creator.new
           end
-
         end
       end
     end