arachni 1.3.2 → 1.4

data/spec/arachni/element/form/dom_spec.rb

@@ -8,6 +8,7 @@ describe Arachni::Element::Form::DOM do
     it_should_behave_like 'with_node'
     it_should_behave_like 'with_auditor'
 
+    it_should_behave_like 'locatable_dom'
     it_should_behave_like 'submittable_dom'
     it_should_behave_like 'inputtable_dom', inputs: inputs
     it_should_behave_like 'mutable_dom',    inputs: inputs
@@ -69,28 +70,6 @@ describe Arachni::Element::Form::DOM do
         end
     end
 
-    describe '#locate' do
-        it 'locates the live element' do
-            called = false
-            subject.with_browser do |browser|
-                subject.browser = browser
-                browser.load subject.page
-
-                element = subject.locate
-                expect(element).to be_kind_of Watir::HTMLElement
-
-                expect(parent.class.from_document(
-                    parent.url, Nokogiri::HTML(element.html)
-                ).first).to eq(parent)
-
-                called = true
-            end
-
-            subject.auditor.browser_cluster.wait
-            expect(called).to be_truthy
-        end
-    end
-
     describe '#trigger' do
         it 'triggers the event required to submit the element' do
             inputs = { 'param'  => 'The.Dude' }

data/spec/arachni/element/form_spec.rb

@@ -61,17 +61,17 @@ describe Arachni::Element::Form do
     end
 
     describe '#initialize' do
-        describe :method do
+        describe ':method' do
             it 'defaults to :get' do
                 expect(described_class.new( url: url ).method).to eq(:get)
             end
         end
-        describe :name do
+        describe ':name' do
             it 'sets #name' do
                 expect(described_class.new( url: url, name: 'john' ).name).to eq('john')
             end
         end
-        describe :action do
+        describe ':action' do
             it 'sets #action' do
                 action = "#{url}stuff"
                 expect(described_class.new( url: url, action: action ).action).to eq(action)
@@ -121,7 +121,7 @@ describe Arachni::Element::Form do
     end
 
     describe '#audit' do
-        describe :each_mutation do
+        describe ':each_mutation' do
             it 'ignores #mutation_with_original_values' do
                 had_mutation_with_original_values = false
                 each_mutation = proc do |mutation|
@@ -235,7 +235,7 @@ describe Arachni::Element::Form do
         end
 
         context 'when #method is' do
-            describe :get do
+            describe ':get' do
                 let(:method) { :get }
 
                 it 'removes the URL query' do
@@ -260,7 +260,7 @@ describe Arachni::Element::Form do
                 end
             end
 
-            describe :post do
+            describe ':post' do
                 let(:method) { :post }
 
                 it 'preserves the URL query' do
@@ -532,7 +532,7 @@ describe Arachni::Element::Form do
             end
         end
 
-        describe :skip_original do
+        describe ':skip_original' do
             it 'does not add mutations with original nor default values' do
                 e = described_class.new( options )
                 mutations = e.mutations( @seed, skip_original: true )

data/spec/arachni/element/header_spec.rb

@@ -51,14 +51,14 @@ describe Arachni::Element::Header do
     end
 
     describe '#mutations' do
-        describe :parameter_names do
+        describe ':parameter_names' do
             it 'creates a new header' do
                 expect(subject.mutations( 'seed', parameter_names: true ).last.
                     inputs.keys).to eq(%w(seed))
             end
         end
 
-        describe :format do
+        describe ':format' do
             it 'does not include NULLs' do
                 expect(subject.mutations( 'seed' ).
                     select { |m| m.affected_input_value.include? "\0" }).to be_empty

data/spec/arachni/element/json_spec.rb

@@ -319,7 +319,7 @@ describe Arachni::Element::JSON do
 
     describe '#mutations' do
         context 'when #inputs have nested' do
-            context Hash do
+            context 'Hash' do
                 let(:inputs) do
                     {
                         'stuff' => 'blah',
@@ -380,7 +380,7 @@ describe Arachni::Element::JSON do
                 end
             end
 
-            context Array do
+            context 'Array' do
                 let(:inputs) do
                     {
                         'stuff' => 'blah',

data/spec/arachni/element/link/dom_spec.rb

@@ -8,6 +8,7 @@ describe Arachni::Element::Link::DOM do
     it_should_behave_like 'with_node'
     it_should_behave_like 'with_auditor'
 
+    it_should_behave_like 'locatable_dom'
     it_should_behave_like 'submittable_dom'
     it_should_behave_like 'inputtable_dom', inputs: inputs
     it_should_behave_like 'mutable_dom',    inputs: inputs
@@ -87,28 +88,6 @@ describe Arachni::Element::Link::DOM do
         end
     end
 
-    describe '#locate' do
-        it 'locates the live element' do
-            called = false
-            subject.with_browser do |browser|
-                subject.browser = browser
-                browser.load subject.page
-
-                element = subject.locate
-                expect(element).to be_kind_of Watir::HTMLElement
-
-                expect(parent.class.from_document(
-                    parent.url, Nokogiri::HTML(element.html)
-                ).first).to eq(parent)
-
-                called = true
-            end
-
-            subject.auditor.browser_cluster.wait
-            expect(called).to be_truthy
-        end
-    end
-
     describe '#trigger' do
         it 'triggers the event required to submit the element' do
             inputs = { 'param' => 'The.Dude' }

data/spec/arachni/element/link_spec.rb

@@ -53,7 +53,7 @@ describe Arachni::Element::Link do
     end
 
     describe '#initialize' do
-        describe :action do
+        describe ':action' do
             it 'sets #action' do
                 action = "#{url}stuff"
                 expect(described_class.new( url: url, action: action ).action).to eq(action)
@@ -214,6 +214,20 @@ describe Arachni::Element::Link do
                 expect(described_class.from_document( '', '' )).to be_empty
             end
         end
+
+        context 'when links have actions that just fragments' do
+            it 'ignores them' do
+                html = '
+                    <html>
+                        <body>
+                            <a href="#stuff"></a>
+                        </body>
+                    </html>'
+
+                expect(described_class.from_document( url, html )).to be_empty
+            end
+        end
+
         context 'when links have actions that are out of scope' do
             it 'ignores them' do
                 html = '
@@ -232,6 +246,7 @@ describe Arachni::Element::Link do
                 expect(links.first.action).to eq(url + 'stuff')
             end
         end
+
         context 'when the response contains links' do
             it 'should return an array of links' do
                 html = '
@@ -249,6 +264,7 @@ describe Arachni::Element::Link do
                     'param_two'  => 'value_two'
                 })
             end
+
             context 'and includes a base attribute' do
                 it 'should return an array of links with adjusted URIs' do
                     base_url = "#{url}this_is_the_base/"

data/spec/arachni/element/link_template/dom_spec.rb

@@ -8,6 +8,7 @@ describe Arachni::Element::LinkTemplate::DOM do
     it_should_behave_like 'with_node'
     it_should_behave_like 'with_auditor'
 
+    it_should_behave_like 'locatable_dom'
     it_should_behave_like 'submittable_dom'
     it_should_behave_like 'inputtable_dom', inputs: inputs
     it_should_behave_like 'mutable_dom',    inputs: inputs
@@ -92,28 +93,6 @@ describe Arachni::Element::LinkTemplate::DOM do
         end
     end
 
-    describe '#locate' do
-        it 'locates the live element' do
-            called = false
-            subject.with_browser do |browser|
-                subject.browser = browser
-                browser.load subject.page
-
-                element = subject.locate
-                expect(element).to be_kind_of Watir::HTMLElement
-
-                expect(parent.class.from_document(
-                    parent.url, Nokogiri::HTML(element.html)
-                ).first).to eq(parent)
-
-                called = true
-            end
-
-            subject.auditor.browser_cluster.wait
-            expect(called).to be_truthy
-        end
-    end
-
     describe '#trigger' do
         it 'triggers the event required to submit the element' do
             inputs = { 'param' => 'The.Dude' }

data/spec/arachni/element/link_template_spec.rb

@@ -63,8 +63,8 @@ describe Arachni::Element::LinkTemplate do
     let(:utilities) { Arachni::Utilities }
 
     describe '#initialize' do
-        describe :options do
-            describe :template do
+        describe ':options' do
+            describe ':template' do
                 it 'sets the #template' do
                     expect(described_class.new(
                         url:      url_with_inputs,
@@ -73,7 +73,7 @@ describe Arachni::Element::LinkTemplate do
                 end
             end
 
-            describe :inputs do
+            describe ':inputs' do
                 it 'sets the #inputs' do
                     expect(described_class.new(
                         url:      url_with_inputs,

data/spec/arachni/element/ui_form/{ui_form_dom_spec.rb → dom_spec.rb}

@@ -8,6 +8,7 @@ describe Arachni::Element::UIForm::DOM do
     it_should_behave_like 'with_node'
     it_should_behave_like 'with_auditor'
 
+    it_should_behave_like 'locatable_dom'
     it_should_behave_like 'submittable_dom'
     it_should_behave_like 'inputtable_dom', inputs: inputs
     it_should_behave_like 'mutable_dom',    inputs: inputs
@@ -79,28 +80,6 @@ describe Arachni::Element::UIForm::DOM do
         end
     end
 
-    describe '#locate' do
-        it 'locates the live element' do
-            called = false
-            subject.with_browser do |browser|
-                subject.browser = browser
-                browser.load subject.page
-
-                element = subject.locate
-                expect(element).to be_kind_of Watir::HTMLElement
-
-                expect(Arachni::Browser::ElementLocator.
-                           from_html( element.opening_tag ).attributes
-                ).to eq(subject.locator.attributes)
-
-                called = true
-            end
-
-            subject.auditor.browser_cluster.wait
-            expect(called).to be_truthy
-        end
-    end
-
     describe '#trigger' do
         let(:new_inputs) { { subject.inputs.keys.first  => 'The.Dude' } }
 
@@ -161,4 +140,75 @@ describe Arachni::Element::UIForm::DOM do
         end
     end
 
+    describe '#coverage_id' do
+        let(:action) { @page.url }
+        let(:method) { 'click' }
+        let(:source) { '<button id="insert">Insert into DOM</button>' }
+        let(:opening_tags) { {
+            'my-input' => "<input id=\"my-input\" type=\"text\" value=\"stuff\">"
+        } }
+        let(:options) do
+            {
+                method:       method,
+                action:       action,
+                source:       source,
+                inputs:       inputs,
+                opening_tags: opening_tags
+            }
+        end
+
+        def get_element( o = {} )
+            Arachni::Element::UIForm.new( options.merge( o ) ).dom
+        end
+
+        it 'takes the #method into consideration' do
+            s1 = get_element
+            s2 = get_element( method: 'mouseover' )
+
+            expect(s1.coverage_id).to_not eq s2.coverage_id
+        end
+
+        it 'takes the #locator into consideration' do
+            s1 = get_element
+            s2 = get_element( source: '<button id="insert2">Insert into DOM</button>' )
+
+            expect(s1.coverage_id).to_not eq s2.coverage_id
+        end
+    end
+
+    describe '#id' do
+        let(:action) { @page.url }
+        let(:method) { 'click' }
+        let(:source) { '<button id="insert">Insert into DOM</button>' }
+        let(:opening_tags) { {
+            'my-input' => "<input id=\"my-input\" type=\"text\" value=\"stuff\">"
+        } }
+        let(:options) do
+            {
+                method:       method,
+                action:       action,
+                source:       source,
+                inputs:       inputs,
+                opening_tags: opening_tags
+            }
+        end
+
+        def get_element( o = {} )
+            Arachni::Element::UIForm.new( options.merge( o ) ).dom
+        end
+
+        it 'takes the #method into consideration' do
+            s1 = get_element
+            s2 = get_element( method: 'mouseover' )
+
+            expect(s1.id).to_not eq s2.id
+        end
+
+        it 'takes the #locator into consideration' do
+            s1 = get_element
+            s2 = get_element( source: '<button id="insert2">Insert into DOM</button>' )
+
+            expect(s1.id).to_not eq s2.id
+        end
+    end
 end

data/spec/arachni/element/ui_form_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 describe Arachni::Element::UIForm do
     html = '<button id="insert">Insert into DOM</button'
 
+    it_should_behave_like 'with_auditor'
     it_should_behave_like 'dom_only', html
 
     def new_element( source )

data/spec/arachni/element/ui_input/dom_spec.rb

@@ -7,6 +7,7 @@ describe Arachni::Element::UIInput::DOM do
 
     it_should_behave_like 'with_node'
 
+    it_should_behave_like 'locatable_dom'
     it_should_behave_like 'submittable_dom'
     it_should_behave_like 'inputtable_dom', single_input: true, inputs: inputs
     it_should_behave_like 'mutable_dom',    single_input: true, inputs: inputs
@@ -72,28 +73,6 @@ describe Arachni::Element::UIInput::DOM do
         end
     end
 
-    describe '#locate' do
-        it 'locates the live element' do
-            called = false
-            subject.with_browser do |browser|
-                subject.browser = browser
-                browser.load subject.page
-
-                element = subject.locate
-                expect(element).to be_kind_of Watir::HTMLElement
-
-                expect(Arachni::Browser::ElementLocator.
-                           from_html( element.opening_tag ).attributes
-                ).to eq(subject.locator.attributes)
-
-                called = true
-            end
-
-            subject.auditor.browser_cluster.wait
-            expect(called).to be_truthy
-        end
-    end
-
     describe '#trigger' do
         let(:new_inputs) { { subject.inputs.keys.first  => 'The.Dude' } }
 
@@ -154,4 +133,67 @@ describe Arachni::Element::UIInput::DOM do
         end
     end
 
+    describe '#coverage_id' do
+        let(:action) { @page.url }
+        let(:method) { 'click' }
+        let(:source) { '<input oninput="handleOnInput();" id="my-input" name="my-input" value="1" />' }
+        let(:options) do
+            {
+                method: method,
+                action: action,
+                source: source,
+                inputs: inputs
+            }
+        end
+
+        def get_element( o = {} )
+            Arachni::Element::UIInput.new( options.merge( o ) ).dom
+        end
+
+        it 'takes the #method into consideration' do
+            s1 = get_element
+            s2 = get_element( method: 'mouseover' )
+
+            expect(s1.coverage_id).to_not eq s2.coverage_id
+        end
+
+        it 'takes the #locator into consideration' do
+            s1 = get_element
+            s2 = get_element( source: '<input oninput="handleOnInput();" id="my-input2" name="my-input" value="1" />' )
+
+            expect(s1.coverage_id).to_not eq s2.coverage_id
+        end
+    end
+
+    describe '#id' do
+        let(:action) { @page.url }
+        let(:method) { 'click' }
+        let(:source) { '<input oninput="handleOnInput();" id="my-input" name="my-input" value="1" />' }
+        let(:options) do
+            {
+                method: method,
+                action: action,
+                source: source,
+                inputs: inputs
+            }
+        end
+
+        def get_element( o = {} )
+            Arachni::Element::UIInput.new( options.merge( o ) ).dom
+        end
+
+        it 'takes the #method into consideration' do
+            s1 = get_element
+            s2 = get_element( method: 'mouseover' )
+
+            expect(s1.id).to_not eq s2.id
+        end
+
+        it 'takes the #locator into consideration' do
+            s1 = get_element
+            s2 = get_element( source: '<input oninput="handleOnInput();" id="my-input2" name="my-input" value="1" />' )
+
+            expect(s1.id).to_not eq s2.id
+        end
+    end
 end