arachni 1.3.2 → 1.4

data/spec/arachni/http/response/scope_spec.rb

@@ -16,7 +16,7 @@ describe Arachni::HTTP::Response::Scope do
         end
 
         context "when #{Arachni::URI::Scope}#out?" do
-            context true do
+            context 'true' do
                 it 'returns true' do
                     # We can't stub #out? because we also override it.
                     allow_any_instance_of(Arachni::URI::Scope).to receive(:exclude?) { true }
@@ -24,7 +24,7 @@ describe Arachni::HTTP::Response::Scope do
                 end
             end
 
-            context false do
+            context 'false' do
                 it 'returns false' do
                     allow_any_instance_of(Arachni::URI::Scope).to receive(:exclude?) { false }
                     expect(subject.out?).to be_falsey
@@ -33,14 +33,14 @@ describe Arachni::HTTP::Response::Scope do
         end
 
         context 'when #exclude_as_binary?' do
-            context true do
+            context 'true' do
                 it 'returns true' do
                     allow(subject).to receive(:exclude_as_binary?) { true }
                     expect(subject.out?).to be_truthy
                 end
             end
 
-            context false do
+            context 'false' do
                 it 'returns false' do
                     allow(subject).to receive(:exclude_as_binary?) { false }
                     expect(subject.out?).to be_falsey
@@ -49,14 +49,14 @@ describe Arachni::HTTP::Response::Scope do
         end
 
         context 'when #exclude_content?' do
-            context true do
+            context 'true' do
                 it 'returns true' do
                     allow(subject).to receive(:exclude_content?) { true }
                     expect(subject.out?).to be_truthy
                 end
             end
 
-            context false do
+            context 'false' do
                 it 'returns false' do
                     allow(subject).to receive(:exclude_content?) { false }
                     expect(subject.out?).to be_falsey
@@ -67,9 +67,9 @@ describe Arachni::HTTP::Response::Scope do
 
     describe '#exclude_as_binary?' do
         context 'when #text?' do
-            context true do
+            context 'true' do
                 context "and #{Arachni::OptionGroups::Scope}#exclude_binaries?" do
-                    context true do
+                    context 'true' do
                         it 'returns false' do
                             scope.exclude_binaries = true
                             allow(response).to receive(:text?) { true }
@@ -78,7 +78,7 @@ describe Arachni::HTTP::Response::Scope do
                         end
                     end
 
-                    context false do
+                    context 'false' do
                         it 'returns false' do
                             scope.exclude_binaries = false
                             allow(response).to receive(:text?) { true }
@@ -89,9 +89,9 @@ describe Arachni::HTTP::Response::Scope do
                 end
             end
 
-            context false do
+            context 'false' do
                 context "and #{Arachni::OptionGroups::Audit}#exclude_binaries?" do
-                    context true do
+                    context 'true' do
                         it 'returns true' do
                             scope.exclude_binaries = true
                             allow(response).to receive(:text?) { false }
@@ -100,7 +100,7 @@ describe Arachni::HTTP::Response::Scope do
                         end
                     end
 
-                    context false do
+                    context 'false' do
                         it 'returns false' do
                             scope.exclude_binaries = false
                             allow(response).to receive(:text?) { false }

data/spec/arachni/http/response_spec.rb

@@ -55,13 +55,13 @@ describe Arachni::HTTP::Response do
 
     describe '#modified?' do
         context 'when the #code is' do
-            describe 200 do
+            describe '200' do
                 it 'returns false' do
                     expect(described_class.new( url: @url, code: 200 )).to be_modified
                 end
             end
 
-            describe 304 do
+            describe '304' do
                 it 'returns true' do
                     expect(described_class.new( url: @url, code: 304 )).not_to be_modified
                 end
@@ -114,6 +114,64 @@ describe Arachni::HTTP::Response do
         end
     end
 
+    describe '#ok?' do
+        before do
+            subject.return_code = return_code
+        end
+
+        context 'when #return_code is' do
+            context ':ok' do
+                let(:return_code) { :ok }
+
+                expect_it { to be_ok }
+            end
+
+            context 'not :ok' do
+                let(:return_code) { :blah }
+
+                expect_it { to_not be_ok }
+            end
+
+            context 'missing' do
+                let(:return_code) { nil }
+
+                expect_it { to be_ok }
+            end
+        end
+    end
+
+    describe '#partial?' do
+        context 'when the response body does not match the content-lenth' do
+            it 'returns true' do
+                response = @http.get( "#{@url}/partial", mode: :sync )
+                expect(response).to be_partial
+            end
+        end
+
+        context 'when the response body matches the content-lenth' do
+            it 'returns false' do
+                response = @http.get( @url, mode: :sync )
+                expect(response).to_not be_partial
+            end
+        end
+
+        context 'when dealing with a stream' do
+            context 'that does not complete' do
+                it 'returns true' do
+                    response = @http.get( "#{@url}/partial_stream", mode: :sync )
+                    expect(response).to be_partial
+                end
+            end
+
+            context 'that completes' do
+                it 'returns false' do
+                    response = @http.get( "#{@url}/stream", mode: :sync )
+                    expect(response).to_not be_partial
+                end
+            end
+        end
+    end
+
     describe '#text?' do
         context 'when the content-type is' do
             context 'text/*' do
@@ -164,7 +222,7 @@ describe Arachni::HTTP::Response do
                 end
             end
 
-            context nil do
+            context 'nil' do
                 context 'and the response body is' do
                     context 'binary' do
                         it 'returns false' do
@@ -182,7 +240,7 @@ describe Arachni::HTTP::Response do
                                 url:  'http://test.com',
                                 body: 'stuff'
                             }
-                            expect(described_class.new( h ).text?).to be_truthy
+                            expect(described_class.new( h ).text?).to eq(true)
                         end
                     end
 

data/spec/arachni/issue_spec.rb

@@ -85,18 +85,18 @@ describe Arachni::Issue do
     [:page=, :referring_page=, :vector=].each do |m|
         describe "##{m}" do
             let(:obj) do
-                obj = Object.new
-                allow(obj).to receive(:deep_clone).and_return(obj)
-                allow(obj).to receive(:prepare_for_report)
-                obj
+                Factory[{ :page= => :page, :referring_page= => :page, :vector= => :vector }[m]]
             end
 
-            it 'calls #deep_clone' do
-                expect(obj).to receive(:deep_clone)
+            it 'clones the object' do
+                expect(obj).to receive(:rpc_clone).and_return(obj.rpc_clone)
                 empty_issue.send( "#{m}", obj )
             end
+
             it 'calls #prepare_for_report' do
+                expect(obj).to receive(:rpc_clone).and_return(obj)
                 expect(obj).to receive(:prepare_for_report)
+
                 empty_issue.send( "#{m}", obj )
             end
         end

data/spec/arachni/option_groups/audit_spec.rb

@@ -5,7 +5,8 @@ describe Arachni::OptionGroups::Audit do
     subject { described_class.new }
 
     %w(with_both_http_methods exclude_vector_patterns include_vector_patterns
-        links forms cookies cookies_extensively headers link_templates).each do |method|
+        links forms cookies cookies_extensively headers link_templates with_raw_payloads
+    ).each do |method|
         it { is_expected.to respond_to method }
         it { is_expected.to respond_to "#{method}=" }
     end
@@ -15,10 +16,10 @@ describe Arachni::OptionGroups::Audit do
             templates = %w(/param\/(?<param>\w+)/ /param2\/(?<param2>\w+)/)
 
             subject.link_templates = templates.first
-            expect(subject.link_templates).to eq([Regexp.new( templates.first )])
+            expect(subject.link_templates).to eq([Regexp.new( templates.first, Regexp::IGNORECASE )])
 
             subject.link_templates = templates
-            expect(subject.link_templates).to eq(templates.map { |p| Regexp.new( p ) })
+            expect(subject.link_templates).to eq(templates.map { |p| Regexp.new( p, Regexp::IGNORECASE ) })
         end
 
         context 'when given nil' do
@@ -47,6 +48,22 @@ describe Arachni::OptionGroups::Audit do
         end
     end
 
+    describe '#with_raw_payloads?' do
+        context 'when #with_raw_payloads is' do
+            it 'true' do
+                subject.with_raw_payloads = true
+                expect(subject.with_raw_payloads?).to eq(true)
+            end
+        end
+
+        context 'when #with_raw_payloads is' do
+            it 'returns false' do
+                subject.with_raw_payloads = false
+                expect(subject.with_raw_payloads?).to eq(false)
+            end
+        end
+    end
+
     describe '#link_templates?' do
         context 'when templates are available' do
             it 'returns true' do
@@ -66,14 +83,14 @@ describe Arachni::OptionGroups::Audit do
      :with_both_http_methods, :link_doms, :form_doms, :cookie_doms].each do |attribute|
         describe "#{attribute}?" do
             context "when ##{attribute} is" do
-                context true do
+                context 'true' do
                     it 'returns true' do
                         subject.send "#{attribute}=", true
                         expect(subject.send("#{attribute}?")).to eq(true)
                     end
                 end
 
-                context false do
+                context 'false' do
                     it 'returns false' do
                         subject.send "#{attribute}=", false
                         expect(subject.send("#{attribute}?")).to eq(false)
@@ -93,14 +110,14 @@ describe Arachni::OptionGroups::Audit do
     describe '#exclude_vector_patterns=' do
         it 'converts the argument to a flat array of Regexp' do
             subject.exclude_vector_patterns = [ [:test], 'string' ]
-            expect(subject.exclude_vector_patterns).to eq([/test/, /string/])
+            expect(subject.exclude_vector_patterns).to eq([/test/i, /string/i])
         end
     end
 
     describe '#include_vector_patterns=' do
         it 'converts the argument to a flat array of Regexp' do
             subject.include_vector_patterns = [ [:test], 'string' ]
-            expect(subject.include_vector_patterns).to eq([/test/, /string/])
+            expect(subject.include_vector_patterns).to eq([/test/i, /string/i])
         end
     end
 
@@ -324,7 +341,7 @@ describe Arachni::OptionGroups::Audit do
 
         it "converts 'link_templates' to strings" do
             subject.link_templates << /param\/(?<param>\w+)/
-            expect(data['link_templates']).to eq(subject.link_templates.map(&:to_s))
+            expect(data['link_templates']).to eq(subject.link_templates.map(&:source))
         end
     end
 end

data/spec/arachni/option_groups/browser_cluster_spec.rb

@@ -5,11 +5,37 @@ describe Arachni::OptionGroups::BrowserCluster do
     subject { described_class.new }
 
     %w(pool_size job_timeout worker_time_to_live ignore_images screen_width
-        screen_height local_storage).each do |method|
+        screen_height wait_for_elements local_storage).each do |method|
         it { is_expected.to respond_to method }
         it { is_expected.to respond_to "#{method}=" }
     end
 
+    context '#wait_for_elements' do
+        it 'converts the keys to Regexp' do
+            subject.wait_for_elements = {
+                'article' => '.articles'
+            }
+
+            expect(subject.wait_for_elements).to eq({
+                /article/i => '.articles'
+            })
+        end
+    end
+
+    describe '#to_rpc_data' do
+        let(:data) { subject.to_rpc_data }
+
+        it "converts 'wait_for_elements' to strings" do
+            subject.wait_for_elements = {
+                /stuff/ => '.my-element'
+            }
+
+            expect(data['wait_for_elements']).to eq({
+                'stuff' => '.my-element'
+            })
+        end
+    end
+
     describe '#local_storage' do
         context 'when passed a Hash' do
             it 'sets it' do

data/spec/arachni/option_groups/dispatcher_spec.rb

@@ -54,7 +54,7 @@ describe Arachni::OptionGroups::Dispatcher do
     end
 
     describe '#grid=' do
-        context true do
+        context 'true' do
             it 'is a shorthand for #grid_mode = :balance' do
                 subject.grid = true
                 expect(subject.grid_mode).to eq(:balance)
@@ -64,14 +64,14 @@ describe Arachni::OptionGroups::Dispatcher do
 
     describe '#grid_mode=' do
         context 'when given' do
-            context String do
+            context 'String' do
                 it 'converts it to Symbol and sets the option' do
                     subject.grid_mode = 'balance'
                     expect(subject.grid_mode).to eq(:balance)
                 end
             end
 
-            context Symbol do
+            context 'Symbol' do
                 it 'sets the option' do
                     subject.grid_mode = :aggregate
                     expect(subject.grid_mode).to eq(:aggregate)

data/spec/arachni/option_groups/input_spec.rb

@@ -16,7 +16,7 @@ describe Arachni::OptionGroups::Input do
             }
 
             expect(subject.values).to eq({
-                /article/ => 'my article'
+                /article/i => 'my article'
             })
         end
     end
@@ -28,7 +28,7 @@ describe Arachni::OptionGroups::Input do
             }
 
             expect(subject.default_values).to eq({
-                /article/ => 'my article'
+                /article/i => 'my article'
             })
         end
     end
@@ -41,7 +41,7 @@ describe Arachni::OptionGroups::Input do
 
     describe '#effective_values' do
         it 'merges the #default_values with the configured #values' do
-            subject.values = { /some stuff/ => '2' }
+            subject.values = { /some stuff/i => '2' }
             expect(subject.effective_values).to eq(
                 subject.default_values.merge( subject.values )
             )
@@ -63,8 +63,8 @@ describe Arachni::OptionGroups::Input do
         it 'updates #values from the given file' do
             subject.update_values_from_file( file )
             expect(subject.values).to eq({
-                /test/       => 'blah',
-                /other-test/ => 'blah2'
+                /test/        => 'blah',
+                /other-test/i => 'blah2'
             })
         end
     end
@@ -97,7 +97,7 @@ describe Arachni::OptionGroups::Input do
 
         context 'when no match could be found' do
             context "and 'use_default' is set to" do
-                context true do
+                context 'true' do
                     it 'returns the default' do
                         expect(subject.value_for_name( 'blahblah', true )).to eq(
                             described_class::DEFAULT
@@ -105,7 +105,7 @@ describe Arachni::OptionGroups::Input do
                     end
                 end
 
-                context false do
+                context 'false' do
                     it 'returns nil' do
                         expect(subject.value_for_name( 'blahblah', false )).to eq(nil)
                     end
@@ -193,12 +193,12 @@ describe Arachni::OptionGroups::Input do
             values = { /article/ => 'my article' }
             subject.values = values
 
-            expect(data['values']).to eq({ /article/.to_s => 'my article' })
+            expect(data['values']).to eq({ 'article' => 'my article' })
         end
 
         it "converts 'default_values' to strings" do
             expect(data['default_values'].keys).to eq(
-                subject.default_values.keys.map(&:to_s)
+                subject.default_values.keys.map(&:source)
             )
         end
     end

data/spec/arachni/option_groups/paths_spec.rb

@@ -14,7 +14,7 @@ describe Arachni::OptionGroups::Paths do
         end
     end
 
-    let(:paths_config_file) { "#{Dir.tmpdir}/paths-#{Process.pid}.yml" }
+    let(:paths_config_file) { "#{Arachni.tmpdir}/paths-#{Process.pid}.yml" }
 
     %w(root arachni components logs checks reporters plugins services
         path_extractors fingerprinters lib support mixins snapshots).each do |method|
@@ -79,7 +79,7 @@ describe Arachni::OptionGroups::Paths do
     describe '.config' do
         let(:config) { described_class.config }
 
-        it 'expands ~ to $HOME' do
+        it 'expands ~ to $HOME', if: !Arachni.windows? do
             yaml = {
                 'stuff' => {
                     'blah' => "~/foo-#{Process.pid}/"