arachni 1.3.2 → 1.4

data/spec/arachni/rpc/server/active_options_spec.rb

@@ -6,10 +6,18 @@ require Arachni::Options.paths.lib + 'rpc/server/instance'
 describe Arachni::RPC::Server::ActiveOptions do
     before( :all ) do
         @utils = Arachni::Utilities
-        @instance = instance_spawn
     end
 
-    before( :each ) { @instance.service.clear_cookies }
+    before :each do
+        @instance = instance_spawn
+        @instance.service.clear_cookies
+    end
+    after :each do
+        if @instance
+            @instance.service.shutdown
+            @instance = nil
+        end
+    end
 
     describe '#set' do
         it 'sets options by hash' do
@@ -36,16 +44,9 @@ describe Arachni::RPC::Server::ActiveOptions do
             h = @instance.options.to_h
 
             expect(h['url'].to_s).to eq(@utils.normalize_url( opts['url'] ))
-            expect(h['scope']['exclude_path_patterns']).to eq(
-                opts['scope']['exclude_path_patterns'].map { |s| Regexp.new(s).to_s }
-            )
-            expect(h['scope']['include_path_patterns']).to eq(
-                opts['scope']['include_path_patterns'].map { |s| Regexp.new(s).to_s }
-            )
-            expect(h['scope']['redundant_path_patterns']).to eq(
-                opts['scope']['redundant_path_patterns'].
-                    inject({}) { |hh, (k, v)| hh[Regexp.new(k).to_s] = v.to_s; hh }
-            )
+            expect(h['scope']['exclude_path_patterns']).to eq( opts['scope']['exclude_path_patterns'] )
+            expect(h['scope']['include_path_patterns']).to eq( opts['scope']['include_path_patterns'] )
+            expect(h['scope']['redundant_path_patterns']).to eq( opts['scope']['redundant_path_patterns'] )
 
             expect(h['datastore']).to eq(opts['datastore'])
 
@@ -56,5 +57,55 @@ describe Arachni::RPC::Server::ActiveOptions do
                 Arachni::Cookie.new( url: opts['url'], inputs: { 'name4'  => 'value4' } )
             ])
         end
+
+        context 'when the scan is in progress' do
+            before do
+                @url = web_server_url_for( :framework_multi )
+                @instance.service.scan( url: @url )
+            end
+
+            it 'resets HTTP options' do
+                opts = {
+                    'http' => {
+                        'request_concurrency' => 1111
+                    }
+                }
+                @instance.options.set( opts )
+
+                expect(@instance.service.progress[:statistics][:http][:max_concurrency]).to eq 1111
+            end
+
+            it 'removes out of scope sitemap entries' do
+                sleep 1 while @instance.service.sitemap.size < 10
+
+                opts = {
+                    'scope' => {
+                        'exclude_path_patterns' => [
+                            '.'
+                        ]
+                    }
+                }
+                @instance.options.set( opts )
+
+                expect(@instance.service.sitemap).to be_empty
+            end
+
+            it 'pushes new extend paths' do
+                opts = {
+                    'scope' => {
+                        'extend_paths' => [
+                            '/my/path/1',
+                            '/my/path/2'
+                        ]
+                    }
+                }
+                @instance.options.set( opts )
+
+                sleep 1 while @instance.service.busy?
+
+                expect(@instance.service.sitemap).to include "#{@url}/my/path/1"
+                expect(@instance.service.sitemap).to include "#{@url}/my/path/2"
+            end
+        end
     end
 end

data/spec/arachni/rpc/server/base_spec.rb

@@ -11,7 +11,7 @@ describe Arachni::RPC::Server::Base do
         @server = Arachni::RPC::Server::Base.new( opts )
     end
 
-    it 'supports UNIX sockets' do
+    it 'supports UNIX sockets', if: Arachni::Reactor.supports_unix_sockets? do
         opts = Arachni::Options.instance
         opts.rpc.server_address = nil
         opts.rpc.server_port    = nil

data/spec/arachni/rpc/server/framework/distributor_spec.rb

@@ -253,7 +253,7 @@ describe Arachni::RPC::Server::Framework::Distributor do
                     distributor.split_page_workload( pages )
 
                     pages.each do |page|
-                        page.body << 'stuff'
+                        page.body += 'stuff'
                     end
 
                     workload = []
@@ -272,7 +272,7 @@ describe Arachni::RPC::Server::Framework::Distributor do
                     distributor.split_page_workload( pages )
 
                     pages.each do |page|
-                        page.body << 'stuff'
+                        page.body += 'stuff'
                     end
 
                     workload = []

data/spec/arachni/rpc/server/framework_multi_spec.rb

@@ -213,7 +213,7 @@
 #         end
 #
 #         context 'when called with option' do
-#             describe :errors do
+#             describe ':errors' do
 #                 context 'when set to true' do
 #                     it 'includes all error messages' do
 #                         instance = instance_light_grid_spawn
@@ -241,7 +241,7 @@
 #                 end
 #             end
 #
-#             describe :sitemap do
+#             describe ':sitemap' do
 #                 context 'when set to true' do
 #                     it 'returns entire sitemap' do
 #                         expect(@instance_clean.framework.
@@ -260,7 +260,7 @@
 #                 end
 #             end
 #
-#             describe :statistics do
+#             describe ':statistics' do
 #                 context 'when set to false' do
 #                     it 'excludes statistics' do
 #                         expect(@instance_clean.framework.progress(
@@ -269,7 +269,7 @@
 #                     end
 #                 end
 #             end
-#             describe :issues do
+#             describe ':issues' do
 #                 context 'when set to false' do
 #                     it 'excludes issues' do
 #                         expect(@instance_clean.framework.progress(
@@ -278,7 +278,7 @@
 #                     end
 #                 end
 #             end
-#             describe :slaves do
+#             describe ':slaves' do
 #                 context 'when set to false' do
 #                     it 'excludes slave data' do
 #                         expect(@instance_clean.framework.progress(
@@ -287,7 +287,7 @@
 #                     end
 #                 end
 #             end
-#             describe :as_hash do
+#             describe ':as_hash' do
 #                 context 'when set to true' do
 #                     it 'includes issues as a hash' do
 #                         expect(@instance_clean.framework.

data/spec/arachni/rpc/server/framework_spec.rb

@@ -236,7 +236,7 @@ describe 'Arachni::RPC::Server::Framework' do
         end
 
         context 'when called with option' do
-            describe :errors do
+            describe ':errors' do
                 context 'when set to true' do
                     it 'includes all error messages' do
                         expect(@instance_clean.framework.
@@ -265,7 +265,7 @@ describe 'Arachni::RPC::Server::Framework' do
                 end
             end
 
-            describe :sitemap do
+            describe ':sitemap' do
                 context 'when set to true' do
                     it 'returns entire sitemap' do
                         expect(@instance_clean.framework.
@@ -294,7 +294,7 @@ describe 'Arachni::RPC::Server::Framework' do
                 end
             end
 
-            describe :issue do
+            describe ':issue' do
                 context 'when set to false' do
                     it 'excludes issues' do
                         expect(@instance_clean.framework.progress(
@@ -303,7 +303,7 @@ describe 'Arachni::RPC::Server::Framework' do
                     end
                 end
             end
-            describe :as_hash do
+            describe ':as_hash' do
                 context 'when set to true' do
                     it 'includes issues as a hash' do
                         expect(@instance_clean.framework.progress(

data/spec/arachni/rpc/server/instance_spec.rb

@@ -107,7 +107,7 @@ describe 'Arachni::RPC::Server::Instance' do
     describe '#suspended?' do
         context 'when the scan has not been suspended' do
             it 'returns false' do
-                expect(@shared_instance.service).not_to be_suspended
+                expect(@shared_instance.service.suspended?).to be_falsey
             end
         end
 
@@ -131,7 +131,7 @@ describe 'Arachni::RPC::Server::Instance' do
                     sleep 1 while @instance.service.status != :suspended
                 end
 
-                expect(@instance.service).to be_suspended
+                expect(@instance.service.suspended?).to be_truthy
             end
         end
     end
@@ -166,7 +166,7 @@ describe 'Arachni::RPC::Server::Instance' do
 
             File.delete snapshot_path
 
-            sleep 1 while @instance.service.busy?
+            sleep 1 while @instance.service.status != :scanning
 
             expect(@instance.service.report[:options]).to eq(options)
         end
@@ -357,11 +357,11 @@ describe 'Arachni::RPC::Server::Instance' do
                 end
             end
 
-            describe :spawns do
+            describe ':spawns' do
                 context 'when it has a Dispatcher' do
                     context 'which is a Grid member' do
                         context 'with OptionGroup::Dispatcher#grid_mode set to' do
-                            context :aggregate do
+                            context ':aggregate' do
                                 it 'requests slaves from grid members with unique Pipe-IDs' do
                                     @instance = instance = instance_grid_spawn
 
@@ -386,7 +386,7 @@ describe 'Arachni::RPC::Server::Instance' do
                                     expect(instance.service.report['issues']).to be_any
                                 end
                             end
-                            context :balance do
+                            context ':balance' do
                                 it 'requests its slaves from it' do
                                     @instance = instance = instance_grid_spawn
 
@@ -431,7 +431,7 @@ describe 'Arachni::RPC::Server::Instance' do
                         end
 
                         context 'with :grid set to' do
-                            context true do
+                            context 'true' do
                                 it 'it a shorthand for grid_mode: :balance' do
                                     @instance = instance = instance_grid_spawn
 
@@ -530,7 +530,7 @@ describe 'Arachni::RPC::Server::Instance' do
                 @progress_instance.service.scan(
                     url: web_server_url_for( :framework_multi ),
                     scope: {
-                        page_limit: 50
+                        page_limit: 10
                     },
                     audit:  { elements: [:links, :forms] },
                     checks: :test,
@@ -556,15 +556,15 @@ describe 'Arachni::RPC::Server::Instance' do
                 expect(p[:seed]).not_to be_empty
             end
 
-            describe :without do
-                describe :statistics do
+            describe ':without' do
+                describe ':statistics' do
                     it 'includes statistics' do
                         expect(@progress_instance.service.progress(
                             without: :statistics
                         )).not_to include :statistics
                     end
                 end
-                describe :issues do
+                describe ':issues' do
                     it 'does not include issues with the given Issue#digest hashes' do
                         p = @progress_instance.service.progress( with: :issues )
                         issue = p[:issues].first
@@ -596,8 +596,8 @@ describe 'Arachni::RPC::Server::Instance' do
                 end
             end
 
-            describe :with do
-                describe :issues do
+            describe ':with' do
+                describe ':issues' do
                     it 'includes issues' do
                         instance = @progress_instance
 
@@ -608,7 +608,7 @@ describe 'Arachni::RPC::Server::Instance' do
                     end
                 end
 
-                describe :instances do
+                describe ':instances' do
                     it 'includes instances' do
                         instance = @progress_instance
 
@@ -626,11 +626,11 @@ describe 'Arachni::RPC::Server::Instance' do
                         end
 
                         expect(stats1.size).to eq(2)
-                        expect(stats1).to eq(stats2)
+                        expect(stats1.to_s).to eq(stats2.to_s)
                     end
                 end
 
-                describe :sitemap do
+                describe ':sitemap' do
                     context 'when set to true' do
                         it 'returns entire sitemap' do
                             instance = @progress_instance
@@ -700,15 +700,15 @@ describe 'Arachni::RPC::Server::Instance' do
                 expect(p[:issues]).to be_nil
             end
 
-            describe :without do
-                describe :statistics do
+            describe ':without' do
+                describe ':statistics' do
                     it 'includes statistics' do
                         expect(@progress_instance.service.native_progress(
                             without: :statistics
                         )).not_to include :statistics
                     end
                 end
-                describe :issues do
+                describe ':issues' do
                     it 'does not include issues with the given Issue#digest hashes' do
                         p = @progress_instance.service.native_progress( with: :issues )
                         issue = p[:issues].first
@@ -740,8 +740,8 @@ describe 'Arachni::RPC::Server::Instance' do
                 end
             end
 
-            describe :with do
-                describe :issues do
+            describe ':with' do
+                describe ':issues' do
                     it 'includes issues as Arachni::Issue objects' do
                         instance = @progress_instance
 
@@ -751,7 +751,7 @@ describe 'Arachni::RPC::Server::Instance' do
                     end
                 end
 
-                describe :instances do
+                describe ':instances' do
                     it 'includes instances' do
                         instance = @progress_instance
 
@@ -769,7 +769,7 @@ describe 'Arachni::RPC::Server::Instance' do
                         end
 
                         expect(stats1.size).to eq(2)
-                        expect(stats1).to eq(stats2)
+                        expect(stats1.to_s).to eq(stats2.to_s)
                     end
                 end
 
@@ -798,7 +798,7 @@ describe 'Arachni::RPC::Server::Instance' do
                 expect(instance.service.shutdown).to be_truthy
                 sleep 4
 
-                expect { instance.service.alive? }.to raise_error
+                expect { instance.service.alive? }.to raise_error Arachni::RPC::Exceptions::ConnectionError
             end
         end
     end

data/spec/arachni/ruby/array_spec.rb

@@ -20,7 +20,7 @@ describe Array do
                 end
             end
 
-            context String do
+            context 'String' do
                 context 'when includes the given tag (as either a String or a Symbol)' do
                     it 'returns true' do
                         expect([ 1 ].includes_tags?( 1 )).to eq(true)
@@ -46,7 +46,7 @@ describe Array do
                 end
             end
 
-            context Array do
+            context 'Array' do
                 context 'when includes any of the given tags (as either a String or a Symbol)' do
                     it 'returns true' do
                         expect([ 1, 2, 3 ].includes_tags?( [1] )).to eq(true)

data/spec/arachni/ruby/string_spec.rb

@@ -26,6 +26,58 @@ describe String do
         }
     end
 
+    describe '#has_html_tag?' do
+        context 'when the string contains the given tag' do
+            subject { '<test> stuff' }
+
+            expect_it { to have_html_tag 'test' }
+        end
+
+        context 'when the name is preceded by whitespace' do
+            subject { '< test> stuff' }
+
+            expect_it { to have_html_tag 'test' }
+        end
+
+        context 'when the tag spans multiple lines' do
+            subject { "< \n test \n > stuff" }
+
+            expect_it { to have_html_tag 'test' }
+        end
+
+        context 'when the tag is mixed case' do
+            subject { "< \n tEsT \n > stuff" }
+
+            expect_it { to have_html_tag 'test' }
+        end
+
+        context 'when the tag does not close' do
+            subject { "< \n test \n stuff" }
+
+            expect_it { to_not have_html_tag 'test' }
+        end
+
+        context 'when attributes are given' do
+            context 'and the tag attributes match them' do
+                subject { '<input type="text">' }
+
+                expect_it { to have_html_tag 'input', /t[e]xt/ }
+            end
+
+            context 'and the tag attributes span multiple lines' do
+                subject { "<input \n type='text' \n>" }
+
+                expect_it { to have_html_tag 'input', /t[e]xt/ }
+            end
+
+            context 'and the tag attributes do notmatch them' do
+                subject { '<input type="text">' }
+
+                expect_it { to_not have_html_tag 'input', /blah/ }
+            end
+        end
+    end
+
     describe '#scan_in_groups' do
         it 'returns regexp matches in named groups' do
             expect(path.scan_in_groups( regex_with_names )).to eq({