arachni 1.3.2 → 1.4

data/spec/arachni/option_groups/scope_spec.rb

@@ -7,7 +7,7 @@ describe Arachni::OptionGroups::Scope do
     %w(directory_depth_limit dom_depth_limit page_limit restrict_paths extend_paths
         redundant_path_patterns auto_redundant_paths include_path_patterns
         exclude_path_patterns exclude_content_patterns include_subdomains https_only
-        url_rewrites exclude_binaries
+        url_rewrites exclude_binaries exclude_file_extensions
     ).each do |method|
         it { is_expected.to respond_to method }
         it { is_expected.to respond_to "#{method}=" }
@@ -20,7 +20,7 @@ describe Arachni::OptionGroups::Scope do
             }
 
             expect(subject.url_rewrites.to_s).to eq({
-                /\/article\/(\d+)/ => 'articles?id=\1'
+                /\/article\/(\d+)/i => 'articles?id=\1'
             }.to_s)
         end
     end
@@ -70,7 +70,7 @@ describe Arachni::OptionGroups::Scope do
             subject.redundant_path_patterns = { /pattern/ => '45', 'regexp' => 39 }
             expect(subject.redundant_path_patterns).to eq({
                 /pattern/ => 45,
-                /regexp/  => 39
+                /regexp/i => 39
             })
         end
     end
@@ -170,10 +170,22 @@ describe Arachni::OptionGroups::Scope do
             expect(subject.include_path_patterns).to eq([/test/])
 
             subject.include_path_patterns = include.first
-            expect(subject.include_path_patterns).to eq([Regexp.new( include.first )])
+            expect(subject.include_path_patterns).to eq([Regexp.new( include.first, Regexp::IGNORECASE )])
 
             subject.include_path_patterns = include
-            expect(subject.include_path_patterns).to eq(include.map { |p| Regexp.new( p ) })
+            expect(subject.include_path_patterns).to eq(include.map { |p| Regexp.new( p, Regexp::IGNORECASE ) })
+        end
+    end
+
+    describe '#exclude_file_extensions=' do
+        it 'converts its param to an array of strings' do
+            exclude_extensions = %w(my_extend_paths my_other_extend_paths)
+
+            subject.exclude_file_extensions = exclude_extensions.first
+            expect(subject.exclude_file_extensions).to eq(Set.new([exclude_extensions.first]))
+
+            subject.exclude_file_extensions = exclude_extensions
+            expect(subject.exclude_file_extensions).to eq(Set.new(exclude_extensions))
         end
     end
 
@@ -185,10 +197,10 @@ describe Arachni::OptionGroups::Scope do
             expect(subject.exclude_path_patterns).to eq([/test/])
 
             subject.exclude_path_patterns= exclude.first
-            expect(subject.exclude_path_patterns).to eq([Regexp.new( exclude.first )])
+            expect(subject.exclude_path_patterns).to eq([Regexp.new( exclude.first, Regexp::IGNORECASE )])
 
             subject.exclude_path_patterns= exclude
-            expect(subject.exclude_path_patterns).to eq(exclude.map { |p| Regexp.new( p ) })
+            expect(subject.exclude_path_patterns).to eq(exclude.map { |p| Regexp.new( p, Regexp::IGNORECASE ) })
         end
     end
 
@@ -200,10 +212,10 @@ describe Arachni::OptionGroups::Scope do
             expect(subject.exclude_content_patterns).to eq([/test/])
 
             subject.exclude_content_patterns = exclude_pages.first
-            expect(subject.exclude_content_patterns).to eq([Regexp.new( exclude_pages.first )])
+            expect(subject.exclude_content_patterns).to eq([Regexp.new( exclude_pages.first, Regexp::IGNORECASE )])
 
             subject.exclude_content_patterns = exclude_pages
-            expect(subject.exclude_content_patterns).to eq(exclude_pages.map { |p| Regexp.new( p ) })
+            expect(subject.exclude_content_patterns).to eq(exclude_pages.map { |p| Regexp.new( p, Regexp::IGNORECASE ) })
         end
     end
 
@@ -211,17 +223,21 @@ describe Arachni::OptionGroups::Scope do
         let(:data) { subject.to_rpc_data }
 
         it "converts 'redundant_path_patterns' to strings" do
-            values = { /redundant_path_patterns/ => 1 }
-            subject.redundant_path_patterns = values
+            subject.redundant_path_patterns = { /redundant_path_patterns/ => 1 }
 
-            expect(data['redundant_path_patterns']).to eq(values.my_stringify)
+            expect(data['redundant_path_patterns']).to eq({ 'redundant_path_patterns' => 1 })
         end
 
         it "converts 'url_rewrites' to strings" do
-            values = { /url_rewrites/ => 'test' }
-            subject.url_rewrites = values
+            subject.url_rewrites = { /url_rewrites/ => 'test' }
+
+            expect(data['url_rewrites']).to eq({ 'url_rewrites' => 'test' })
+        end
+
+        it "converts 'exclude_file_extensions' to Array of string" do
+            subject.exclude_file_extensions = Set.new( ['stuff'] )
 
-            expect(data['url_rewrites']).to eq(values.my_stringify)
+            expect(data['exclude_file_extensions']).to eq(['stuff'])
         end
 
         %w(exclude_path_patterns exclude_content_patterns include_path_patterns).each do |k|
@@ -229,7 +245,7 @@ describe Arachni::OptionGroups::Scope do
                 values = [/#{k}/]
                 subject.send( "#{k}=", values )
 
-                expect(data[k]).to eq([/#{k}/.to_s])
+                expect(data[k]).to eq([/#{k}/.source])
             end
         end
     end

data/spec/arachni/options_spec.rb

@@ -187,7 +187,7 @@ describe Arachni::Options do
                     scope: {
                         exclude_path_patterns:   [ 'exclude me2' ],
                         include_path_patterns:   [ 'include me2' ],
-                        redundant_path_patterns: { 'redundant' => 4 },
+                        redundant_path_patterns: { 'redundant' => 4 }
                     },
                     datastore: {
                         key2: 'val2'
@@ -196,9 +196,9 @@ describe Arachni::Options do
 
                 subject.update( opts )
 
-                expect(subject.scope.exclude_path_patterns).to eq([/exclude me2/])
-                expect(subject.scope.include_path_patterns).to eq([/include me2/])
-                expect(subject.scope.redundant_path_patterns).to eq({ /redundant/ => 4 })
+                expect(subject.scope.exclude_path_patterns).to eq([/exclude me2/i])
+                expect(subject.scope.include_path_patterns).to eq([/include me2/i])
+                expect(subject.scope.redundant_path_patterns).to eq({ /redundant/i => 4 })
                 expect(subject.datastore.to_h).to eq(opts[:datastore])
             end
         end

data/spec/arachni/page/dom/transition_spec.rb

@@ -36,7 +36,7 @@ describe Arachni::Page::DOM::Transition do
         end
 
         context 'when the element is a' do
-            context Symbol do
+            context 'Symbol' do
                 it 'restores it' do
                     original = described_class.new( :page, :load )
                     data     = Arachni::RPC::Serializer.rpc_data( original )
@@ -46,7 +46,7 @@ describe Arachni::Page::DOM::Transition do
                 end
             end
 
-            context Arachni::Browser::ElementLocator do
+            context 'Arachni::Browser::ElementLocator' do
                 it 'restores it' do
                     element = Arachni::Browser::ElementLocator.from_html(
                         '<div id="my-div" onclick="addForm();">'
@@ -97,7 +97,7 @@ describe Arachni::Page::DOM::Transition do
                 called = false
                 t = described_class.new :page, :load do
                     called = true
-                    sleep 1
+                    sleep 1.1
                 end
 
                 expect(called).to be_truthy
@@ -149,7 +149,7 @@ describe Arachni::Page::DOM::Transition do
                 called = false
                 t = empty_transition.start :page, :load do
                     called = true
-                    sleep 1
+                    sleep 1.1
                 end
 
                 expect(called).to be_truthy
@@ -164,14 +164,14 @@ describe Arachni::Page::DOM::Transition do
         end
 
         context 'when the element is' do
-            context String do
+            context 'String' do
                 it 'assigns it to #element' do
                     empty_transition.start 'http://test.com/stuff', :request
                     expect(empty_transition.element).to eq('http://test.com/stuff')
 
                 end
             end
-            context Symbol do
+            context 'Symbol' do
                 it 'assigns it to #element' do
                     empty_transition.start :page, :load
                     expect(empty_transition.element).to eq(:page)
@@ -206,7 +206,7 @@ describe Arachni::Page::DOM::Transition do
     describe '#complete' do
         it 'sets the #time' do
             running = Factory[:running_transition]
-            sleep 1
+            sleep 1.1
             expect(running.complete.time).to be > 1
         end
 
@@ -237,7 +237,7 @@ describe Arachni::Page::DOM::Transition do
 
     describe '#depth' do
         context 'when the event is' do
-            context :request do
+            context ':request' do
                 it 'returns 0' do
                     expect(empty_transition.start( 'http://test/', :request ).depth).to eq(0)
                 end
@@ -303,8 +303,15 @@ describe Arachni::Page::DOM::Transition do
 
         context 'when the transition has completed' do
             it 'returns the time it took for the transition' do
-                expect(completed_transition).not_to be_running
-                expect(completed_transition.time).to be > 0
+                expect(empty_transition).not_to be_running
+
+                t = empty_transition.start :page, :load do
+                    sleep 1.1
+                end
+
+                expect(t.time).to be > 1
+                expect(t).to be_completed
+                expect(t).not_to be_running
             end
         end
     end

data/spec/arachni/page/dom_spec.rb

@@ -200,6 +200,25 @@ describe Arachni::Page::DOM do
         end
     end
 
+    describe '#state' do
+        it 'returns a Page::DOM with enough info to reproduce the current state' do
+            expect(dom.digest).to_not be_empty
+            expect(dom.transitions).to_not be_empty
+            expect(dom.data_flow_sinks).to_not be_empty
+            expect(dom.execution_flow_sinks).to_not be_empty
+
+            state = dom.state
+
+            expect(state.page).to be_nil
+            expect(state.url).to eq dom.url
+            expect(state.digest).to eq dom.digest
+            expect(state.transitions).to eq dom.transitions
+            expect(state.skip_states).to eq dom.skip_states
+            expect(state.data_flow_sinks).to be_empty
+            expect(state.execution_flow_sinks).to be_empty
+        end
+    end
+
     describe '#to_hash' do
         it 'returns a hash with DOM data' do
             data = {

data/spec/arachni/page/scope_spec.rb

@@ -16,7 +16,7 @@ describe Arachni::Page::Scope do
         end
 
         context "when #{Arachni::HTTP::Response::Scope}#out?" do
-            context true do
+            context 'true' do
                 it 'returns true' do
                     # We can't stub #out? because we also override it.
                     allow_any_instance_of(Arachni::HTTP::Response::Scope).to receive(:exclude?) { true }
@@ -24,7 +24,7 @@ describe Arachni::Page::Scope do
                 end
             end
 
-            context false do
+            context 'false' do
                 it 'returns false' do
                     allow_any_instance_of(Arachni::HTTP::Response::Scope).to receive(:exclude?) { false }
                     expect(subject.out?).to be_falsey
@@ -33,14 +33,14 @@ describe Arachni::Page::Scope do
         end
 
         context 'when #dom_depth_limit_reached?' do
-            context true do
+            context 'true' do
                 it 'returns true' do
                     allow(subject).to receive(:dom_depth_limit_reached?) { true }
                     expect(subject.out?).to be_truthy
                 end
             end
 
-            context false do
+            context 'false' do
                 it 'returns false' do
                     allow(subject).to receive(:dom_depth_limit_reached?) { false }
                     expect(subject.out?).to be_falsey

data/spec/arachni/page_spec.rb

@@ -120,7 +120,7 @@ describe Arachni::Page do
             expect(restored.links.last.node.to_s).to eq(link.node.to_s)
         end
 
-        context Arachni::Page::DOM do
+        context 'Arachni::Page::DOM' do
             [:url, :skip_states, :transitions, :data_flow_sinks, :execution_flow_sinks].each do |m|
                 it "restores ##{m}" do
                     # Make sure we're not comparing nils.
@@ -140,7 +140,7 @@ describe Arachni::Page do
 
     describe '#initialize' do
         describe 'option' do
-            describe :response do
+            describe ':response' do
                 it 'uses it to populate the page data' do
                     page   = described_class.new( response: response )
                     parser = Arachni::Parser.new( response )
@@ -160,7 +160,7 @@ describe Arachni::Page do
                 end
             end
 
-            describe :parser do
+            describe ':parser' do
                 it 'uses it to populate the page data' do
                     parser = Arachni::Parser.new( response )
                     page   = described_class.new( parser: parser )
@@ -180,7 +180,7 @@ describe Arachni::Page do
                 end
             end
 
-            describe :dom do
+            describe ':dom' do
                 it 'uses it to populate the DOM data' do
                     dom = described_class.new(
                         url:      'http://test/',
@@ -229,22 +229,22 @@ describe Arachni::Page do
 
     describe '#update_element_audit_whitelist' do
         context 'when passed a' do
-            context Arachni::Element::Capabilities::Auditable do
+            context 'Arachni::Element::Capabilities::Auditable' do
                 it 'updates the #element_audit_whitelist' do
                     subject.update_element_audit_whitelist subject.elements.first
                     expect(subject.element_audit_whitelist).to include subject.elements.first.coverage_hash
                 end
             end
 
-            context Integer do
+            context 'Integer' do
                 it 'updates the #element_audit_whitelist' do
                     subject.update_element_audit_whitelist subject.elements.first.coverage_hash
                     expect(subject.element_audit_whitelist).to include subject.elements.first.coverage_hash
                 end
             end
 
-            context Array do
-                context Arachni::Element::Capabilities::Auditable do
+            context 'Array' do
+                context 'Arachni::Element::Capabilities::Auditable' do
                     it 'updates the #element_audit_whitelist' do
                         subject.update_element_audit_whitelist [subject.elements[0],subject.elements[1]]
                         expect(subject.element_audit_whitelist).to include subject.elements[0].coverage_hash
@@ -252,7 +252,7 @@ describe Arachni::Page do
                     end
                 end
 
-                context Integer do
+                context 'Integer' do
                     it 'updates the #element_audit_whitelist' do
                         subject.update_element_audit_whitelist [subject.elements[0].coverage_hash, subject.elements[1].coverage_hash]
                         expect(subject.element_audit_whitelist).to include subject.elements[0].coverage_hash
@@ -285,14 +285,14 @@ describe Arachni::Page do
         context 'when there is an #element_audit_whitelist' do
             context 'and the element is in it' do
                 context 'represented by' do
-                    context Integer do
+                    context 'Integer' do
                         it 'returns true' do
                             subject.update_element_audit_whitelist subject.elements.first
                             expect(subject.audit_element?( subject.elements.first.coverage_hash )).to be_truthy
                         end
                     end
 
-                    context Arachni::Element::Capabilities::Auditable do
+                    context 'Arachni::Element::Capabilities::Auditable' do
                         it 'returns true' do
                             subject.update_element_audit_whitelist subject.elements.first
                             expect(subject.audit_element?( subject.elements.first )).to be_truthy
@@ -302,14 +302,14 @@ describe Arachni::Page do
             end
             context 'and the element is not in it' do
                 context 'represented by' do
-                    context Integer do
+                    context 'Integer' do
                         it 'returns false' do
                             subject.update_element_audit_whitelist subject.elements.first
                             expect(subject.audit_element?( subject.elements.last.coverage_hash )).to be_falsey
                         end
                     end
 
-                    context Arachni::Element::Capabilities::Auditable do
+                    context 'Arachni::Element::Capabilities::Auditable' do
                         it 'returns false' do
                             subject.update_element_audit_whitelist subject.elements.first
                             expect(subject.audit_element?( subject.elements.last )).to be_falsey
@@ -894,7 +894,7 @@ describe Arachni::Page do
                 end
             end
 
-            context Arachni::Page::DOM do
+            context 'Arachni::Page::DOM' do
                 [:url, :skip_states, :transitions, :data_flow_sinks, :execution_flow_sinks].each do |m|
                     it "preserves ##{m}" do
                         dupped = subject.send(method)
@@ -937,7 +937,7 @@ describe Arachni::Page do
 
             data = {
                 url:  'http://test/',
-                body: 'test',
+                body: 'http://test/1 http://test/2',
                 paths: [ 'http://test/1', 'http://test/2' ],
                 links: [Arachni::Element::Link.new( elem_opts )],
                 forms: [Arachni::Element::Form.new( elem_opts )],

data/spec/arachni/platform/manager_spec.rb

@@ -90,7 +90,7 @@ describe Arachni::Platform::Manager do
         [page, page.response].each do |resource|
             context "when given a #{resource.class}" do
                 context 'when Options.fingerprint is set to' do
-                    context true do
+                    context 'true' do
                         context 'and it is text based' do
                             context 'and has not yet been fingerprinted' do
                                 context 'and is within scope' do
@@ -130,7 +130,7 @@ describe Arachni::Platform::Manager do
                         end
                     end
 
-                    context false do
+                    context 'false' do
                         it 'returns false' do
                             p = page
                             Arachni::Options.do_not_fingerprint

data/spec/arachni/plugin/base_spec.rb

@@ -4,6 +4,7 @@ describe Arachni::Plugin::Base do
     before( :each ) do
         reset_options
 
+        Arachni::Options.url = web_server_url_for(:framework)
         @framework = Arachni::Framework.new
         @framework.state.running = true
 

data/spec/arachni/reporter/base_spec.rb

@@ -36,7 +36,7 @@ describe Arachni::Reporter::Base do
 
     describe '#skip_responses?' do
         context 'when the :skip_responses option is' do
-            context true do
+            context 'true' do
                 it 'returns true' do
                     expect(described_class.new(
                         report,
@@ -45,7 +45,7 @@ describe Arachni::Reporter::Base do
                 end
             end
 
-            context false do
+            context 'false' do
                 it 'returns false' do
                     expect(described_class.new(
                         report,

data/spec/arachni/reporter/manager_spec.rb

@@ -36,7 +36,7 @@ describe Arachni::Reporter::Manager do
                 end
             end
 
-            context false do
+            context 'false' do
                 context 'and the report raises an exception' do
                     it 'does not raise it' do
                         expect { @reporters.run( :error, report, {}, false ) }.to_not raise_error
@@ -44,7 +44,7 @@ describe Arachni::Reporter::Manager do
                 end
             end
 
-            context true do
+            context 'true' do
                 context 'and the report raises an exception' do
                     it 'does not raise it' do
                         expect { @reporters.run( :error, report, {}, true ) }.to raise_error