alexandria-book-collection-manager 0.7.5 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41c8eead00b7524b5b74feaa6ac01f063faaac747b83fccad928afa9d8b28b58
-  data.tar.gz: 10fd8fa88a3deab629b885c31afae79984c5c706c5ae0bab4a41c7ddd35bf12a
+  metadata.gz: 0c194c4c3c57f9f5f3c5168f2e59cbe0f26be22040392ba5cc6640b2fe6bb917
+  data.tar.gz: a76de1e82e89789ffdf419a10fa601d3bdb4b507c58ea76e9ad8b4123627da04
 SHA512:
-  metadata.gz: 0710b1de59aadd9a781760b23b329f4369d42dbc4c77f1dc1f6fee5643a928cccb113390595ad675b766c865f4a8651ae290e1665bed32fb6af9b501d2a2bdec
-  data.tar.gz: b8f0ec703fd44905365c9d66bb28ddb5b4b8e46f3bd26ad9762d99e2e7f66e7ab4634314ec4a06890e0a28fc0cbe752dde704bf03be9371bbc73c5931eb8a605
+  metadata.gz: 367b0d80c25a8ece61d580cedb7806db56f9627c5adb151b63da5655b8495cf988a1e780fa27c88927c02c07b645ff5db452b96896d1720d82df542fb3cd3f1c
+  data.tar.gz: 88570773f1454e1f36c5d0268040f6ab30fd4acb41eb8c90fba9c3bb3488bc980d124705995493f7d7640f7dd9ee7e5355950b594759fd58ffc69a54e1302cbb

data/.github/dependabot.yml

@@ -0,0 +1,9 @@
+# Documentation for all configuration options:
+# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.gitignore

@@ -3,13 +3,16 @@ config.save
 alexandria.desktop
 alexandria.desktop.in.h
 .svn-authors
-lib/alexandria/default_preferences.rb
 Gemfile.lock
 .yardoc/
 share/locale/
 share/omf/alexandria/*.omf
+spec/examples.txt
 pkg/
 coverage/
 tmp/
+po/*.po~
+po/*.mo
+po/*.pot
 *.gem
 *.glade~

data/.rubocop.yml

@@ -3,13 +3,36 @@ inherit_from: .rubocop_todo.yml
 require:
   - rubocop-performance
   - rubocop-rspec
+  - rubocop-i18n
 
 AllCops:
   Exclude:
     - 'lib/alexandria/default_preferences.rb'
     - 'pkg/**/*'
+    - 'vendor/bundle/**/*'
+  NewCops: enable
   TargetRubyVersion: 2.5
 
+# Choose GetText-style I18n cops
+GetText:
+  Enabled: true
+  # Exclude non-user-facing code
+  Exclude:
+    - Rakefile
+    - 'util/**/*'
+    - 'spec/**/*'
+RailsI18n:
+  Enabled: false
+
+# This code has a lot of pre-existing translations with percent-style
+# formatting. Maybe one day someone will re-do all of them ...
+GetText/DecorateStringFormattingUsingPercent:
+  Enabled: false
+
+# Make BeginEndAlignment behavior match EndAlignment
+Layout/BeginEndAlignment:
+  EnforcedStyleAlignWith: begin
+
 Layout/HashAlignment:
   EnforcedColonStyle: key
   EnforcedHashRocketStyle: table
@@ -44,13 +67,10 @@ Lint/AmbiguousBlockAssociation:
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
-# Activate new cops from RuboCop 0.81 and 0.82
-Lint/RaiseException:
-  Enabled: true
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-Lint/StructNewOverride:
-  Enabled: true
+# This cop's reach is too broad
+# See https://github.com/rubocop-hq/rubocop/pull/8480
+Lint/MissingSuper:
+  Enabled: false
 
 # Blocks in specs can be any size
 Metrics/BlockLength:
@@ -64,34 +84,38 @@ Naming/AccessorMethodName:
 Naming/RescuedExceptionsVariableName:
   PreferredName: ex
 
+Performance/EndWith:
+  AutoCorrect: true
+
+Performance/StartWith:
+  AutoCorrect: true
+
+# End-to-end specs do not describe classes
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/end_to_end/**/*_spec.rb'
+
+RSpec/ExampleLength:
+  Max: 8
+  Exclude:
+    - 'spec/end_to_end/**/*_spec.rb'
+
 # Allow and/or for control flow only
 Style/AndOr:
   EnforcedStyle: conditionals
 
-# Activate new cop from RuboCop 0.82
-Style/ExponentialNotation:
-  Enabled: true
-
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2
 
-# Activate new cops from RuboCop 0.80
-Style/HashEachMethods:
-  Enabled: true
-Style/HashTransformKeys:
-  Enabled: true
-Style/HashTransformValues:
-  Enabled: true
+# Sometimes an if statement just looks better than next with a guard clause
+Style/Next:
+  Enabled: false
 
 # Not all objects that handle #== 0 also handle #zero?
 Style/NumericPredicate:
   Enabled: false
 
-# Sometimes an if statement just looks better than next with a guard clause
-Style/Next:
-  Enabled: false
-
 # Use older RuboCop default
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
@@ -105,6 +129,10 @@ Style/RedundantReturn:
 Style/SingleLineBlockParams:
   Enabled: false
 
+# Allow all ways to construct strings for now
+Style/StringConcatenation:
+  Enabled: false
+
 # Do not commit to use of interpolation
 Style/StringLiterals:
   EnforcedStyle: double_quotes
@@ -113,9 +141,7 @@ Style/StringLiterals:
 Style/SymbolArray:
   EnforcedStyle: brackets
 
-# Project-specific configuration goes here.
-
-# Accessors are only trivial if they match the ivar name.
+# Accessors are only trivial if they match the ivar name
 Style/TrivialAccessors:
   ExactNameMatch: true
 
@@ -126,7 +152,3 @@ Style/TrailingCommaInArrayLiteral:
 # Alexandria uses regular arrays
 Style/WordArray:
   Enabled: false
-
-# Not all objects that handle #length also handle #empty?
-Style/ZeroLengthPredicate:
-  Enabled: false

data/.rubocop_todo.yml

@@ -1,87 +1,52 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2020-02-22 15:02:18 +0100 using RuboCop version 0.80.0.
+# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
+# using RuboCop version 0.93.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-    - 'lib/alexandria/web_themes.rb'
-
-# Offense count: 1
-Lint/ShadowingOuterLocalVariable:
-  Exclude:
-    - 'lib/alexandria/ui/libraries_combo.rb'
-
-# Offense count: 1
-Lint/UriEscapeUnescape:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-
-# Offense count: 2
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-
-# Offense count: 160
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 159
+  Max: 111
 
-# Offense count: 21
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 67
+  Max: 64
 
-# Offense count: 8
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 31
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 994
+  Max: 990
 
-# Offense count: 63
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 22
+  Max: 27
 
-# Offense count: 214
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 113
+  Max: 98
 
-# Offense count: 1
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 346
+  Max: 361
 
-# Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 61
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 23
+  Max: 27
 
-# Offense count: 8
 Naming/BinaryOperatorParameterName:
   Exclude:
-    - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/models/book.rb'
-    - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/multi_drag_treeview.rb'
 
-# Offense count: 13
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -91,27 +56,6 @@ Naming/HeredocDelimiterNaming:
     - 'lib/alexandria/export_library.rb'
     - 'lib/alexandria/ui/about_dialog.rb'
 
-# Offense count: 2
-# Configuration parameters: EnforcedStyleForLeadingUnderscores.
-# SupportedStylesForLeadingUnderscores: disallowed, required, optional
-Naming/MemoizedInstanceVariableName:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-
-# Offense count: 10
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
-Naming/MethodParameterName:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/proxis.rb'
-    - 'lib/alexandria/book_providers/pseudomarc.rb'
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/callbacks.rb'
-    - 'lib/alexandria/ui/init.rb'
-    - 'util/rake/fileinstall.rb'
-
-# Offense count: 4
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_
@@ -124,56 +68,15 @@ Naming/PredicateName:
     - 'lib/alexandria/ui/smart_library_properties_dialog_base.rb'
     - 'lib/alexandria/web_themes.rb'
 
-# Offense count: 1
-RSpec/DescribeClass:
-  Exclude:
-    - 'spec/end_to_end/basic_run_spec.rb'
-
-# Offense count: 17
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Exclude:
-    - 'spec/alexandria/book_providers_spec.rb'
-    - 'spec/alexandria/book_spec.rb'
-    - 'spec/alexandria/console_spec.rb'
-    - 'spec/alexandria/export_library_spec.rb'
-    - 'spec/alexandria/library_spec.rb'
-    - 'spec/alexandria/library_store_spec.rb'
-    - 'spec/alexandria/ui/provider_preferences_dialog_spec.rb'
-    - 'spec/alexandria/ui/smart_library_properties_dialog_spec.rb'
-    - 'spec/end_to_end/basic_run_spec.rb'
-
-# Offense count: 1
-RSpec/ExpectInHook:
-  Exclude:
-    - 'spec/alexandria/export_library_spec.rb'
-
-# Offense count: 3
-# Configuration parameters: CustomTransform, IgnoreMethods.
+# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
 RSpec/FilePath:
   Exclude:
     - 'spec/alexandria/ui/iconview_spec.rb'
-    - 'spec/alexandria/ui/sidepane_manager_spec.rb'
     - 'spec/alexandria/ui/sound_spec.rb'
 
-# Offense count: 11
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/alexandria/export_library_spec.rb'
-
-# Offense count: 2
-RSpec/MultipleDescribes:
-  Exclude:
-    - 'spec/alexandria/ui/ui_utilities_spec.rb'
-    - 'spec/alexandria/utilities_spec.rb'
-
-# Offense count: 13
-# Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
-  Max: 11
+  Max: 7
 
-# Offense count: 34
 # Cop supports --auto-correct.
 # Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
 # SupportedStyles: inflected, explicit
@@ -184,18 +87,14 @@ RSpec/PredicateMatcher:
     - 'spec/alexandria/library_store_spec.rb'
     - 'spec/alexandria/scanners/cue_cat_spec.rb'
 
-# Offense count: 8
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
-    - 'lib/alexandria/ui/icons.rb'
-    - 'lib/alexandria/ui/import_dialog.rb'
     - 'lib/alexandria/ui/init.rb'
     - 'lib/alexandria/ui/provider_preferences_base_dialog.rb'
 
-# Offense count: 17
 Style/ClassVars:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
@@ -207,26 +106,9 @@ Style/ClassVars:
     - 'lib/alexandria/ui/book_properties_dialog_base.rb'
     - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 11
-Style/CommentedKeyword:
-  Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
-    - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/ui/new_book_dialog.rb'
-    - 'util/rake/fileinstall.rb'
-
-# Offense count: 112
 Style/Documentation:
   Enabled: false
 
-# Offense count: 2
-Style/DoubleNegation:
-  Exclude:
-    - 'lib/alexandria/ui/import_dialog.rb'
-    - 'lib/alexandria/ui/listview.rb'
-
-# Offense count: 10
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
@@ -236,23 +118,19 @@ Style/FormatStringToken:
     - 'lib/alexandria/ui/listview.rb'
     - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 27
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Offense count: 2
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_aws.rb'
-
-# Offense count: 1
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/alexandria/preferences.rb'
-
-# Offense count: 2
-Style/MissingRespondToMissing:
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/preferences.rb'
+    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
+    - 'lib/alexandria/book_providers/siciliano.rb'
+    - 'lib/alexandria/book_providers/thalia.rb'
+    - 'lib/alexandria/book_providers/worldcat.rb'
+    - 'lib/alexandria/console.rb'
+    - 'lib/alexandria/execution_queue.rb'
+    - 'lib/alexandria/export_format.rb'
+    - 'lib/alexandria/library_sort_order.rb'
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
+    - 'util/rake/fileinstall.rb'