alexandria-book-collection-manager 0.7.5 → 0.7.6

data/spec/alexandria/ui/error_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ErrorDialog do
   it "works" do

data/spec/alexandria/ui/export_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ExportDialog do
   it "works" do

data/spec/alexandria/ui/icons_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "spec_helper"
+
+RSpec.describe Alexandria::UI::Icons do
+  describe ".tag_icon" do
+    let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
+    let(:lib_version) { File.join(LIBDIR, "0.6.2") }
+
+    before do
+      FileUtils.cp_r(lib_version, TESTDIR)
+    end
+
+    it "returns a pixbuf" do
+      library = loader.load_all_libraries.first
+      icon = described_class.cover(library, library.first)
+
+      tagged_icon = described_class.tag_icon(icon, described_class::FAVORITE_TAG)
+      expect(tagged_icon).to be_a GdkPixbuf::Pixbuf
+    end
+  end
+end

data/spec/alexandria/ui/iconview_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::IconViewManager do
   it "works" do

data/spec/alexandria/ui/import_dialog_spec.rb

@@ -4,11 +4,38 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ImportDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
     described_class.new parent
   end
+
+  describe "#acquire" do
+    let(:import_dialog) { described_class.new parent }
+    let(:chooser) { import_dialog.dialog }
+
+    before do
+      allow(chooser).to receive(:filename).and_return("spec/data/isbns.txt")
+      allow(Alexandria::BookProviders).to receive(:isbn_search)
+        .and_raise Alexandria::BookProviders::SearchEmptyError
+      allow(Alexandria::BookProviders).to receive(:isbn_search).with("0595371086")
+        .and_return(an_artist_of_the_floating_world)
+    end
+
+    it "works when response is cancel" do
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      import_dialog.acquire {}
+    end
+
+    it "works when response is OK" do
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
+
+      result = nil
+      import_dialog.acquire { |*args| result = args }
+      expect(result.first.to_a).to eq [an_artist_of_the_floating_world]
+    end
+  end
 end

data/spec/alexandria/ui/keep_bad_isbn_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::KeepBadISBNDialog do
   it "works" do

data/spec/alexandria/ui/main_app_spec.rb

@@ -6,7 +6,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::MainApp do
   it "is a singleton" do

data/spec/alexandria/ui/new_book_dialog_manual_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewBookDialogManual do
   it "works" do

data/spec/alexandria/ui/new_provider_dialog_spec.rb

@@ -4,11 +4,27 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewProviderDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
     described_class.new parent
   end
+
+  describe "#acquire" do
+    let(:provider_dialog) { described_class.new parent }
+    let(:gtk_dialog) { provider_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      provider_dialog.acquire
+    end
+
+    it "works when response is accept" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::ACCEPT)
+      provider_dialog.acquire
+    end
+  end
 end

data/spec/alexandria/ui/new_smart_library_dialog_spec.rb

@@ -4,11 +4,36 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::NewSmartLibraryDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
+  let(:parent) { Gtk::Window.new :toplevel }
+
+  it "can be instantiated" do
     described_class.new parent
   end
+
+  describe "#acquire" do
+    let(:properties_dialog) { described_class.new parent }
+    let(:gtk_dialog) { properties_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      properties_dialog.acquire
+    end
+
+    it "returns a smart library that can be saved when response is ok" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+
+      # Make sure entered rule is valid
+      rules_box = properties_dialog.instance_variable_get("@rules_box")
+      entry = rules_box.children.first.children[2]
+      entry.text = "foo"
+
+      result = properties_dialog.acquire
+
+      expect(result).to be_a Alexandria::SmartLibrary
+      expect { result.save }.not_to raise_error
+    end
+  end
 end

data/spec/alexandria/ui/preferences_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::PreferencesDialog do
   it "works" do

data/spec/alexandria/ui/provider_preferences_dialog_spec.rb

@@ -4,16 +4,31 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ProviderPreferencesDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    preferences = instance_double(Alexandria::BookProviders::Preferences,
-                                  length: 0, read: [])
-    provider = instance_double(Alexandria::BookProviders::GenericProvider,
-                               fullname: "FooProvider",
-                               prefs: preferences)
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:preferences) do
+    instance_double(Alexandria::BookProviders::Preferences,
+                    length: 0, read: [])
+  end
+  let(:provider) do
+    instance_double(Alexandria::BookProviders::GenericProvider,
+                    fullname: "FooProvider",
+                    prefs: preferences)
+  end
+
+  it "can be instantiated" do
     described_class.new parent, provider
   end
+
+  describe "#acquire" do
+    it "works" do
+      preferences_dialog = described_class.new parent, provider
+      gtk_dialog = preferences_dialog.dialog
+      allow(gtk_dialog).to receive(:run)
+
+      preferences_dialog.acquire
+    end
+  end
 end

data/spec/alexandria/ui/really_delete_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ReallyDeleteDialog do
   it "works" do

data/spec/alexandria/ui/sidepane_manager_spec.rb

@@ -4,9 +4,9 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
-describe Alexandria::UI::SidePaneManager do
+describe Alexandria::UI::SidepaneManager do
   it "works" do
     library_listview = instance_double(Gtk::TreeView).as_null_object
     parent = instance_double(Alexandria::UI::UIManager, main_app: nil, append_library: nil)

data/spec/alexandria/ui/skip_entry_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::SkipEntryDialog do
   it "works" do

data/spec/alexandria/ui/smart_library_properties_dialog_spec.rb

@@ -4,15 +4,29 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::SmartLibraryPropertiesDialog do
-  it "works" do
-    parent = Gtk::Window.new :toplevel
-    smart_library = instance_double(Alexandria::SmartLibrary,
-                                    name: "Foo",
-                                    rules: [],
-                                    predicate_operator_rule: :any)
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
+  let(:smart_library) { Alexandria::SmartLibrary.new("Foo", [], :all, loader) }
+
+  it "can be instantiated" do
     described_class.new parent, smart_library
   end
+
+  describe "#acquire" do
+    let(:properties_dialog) { described_class.new parent, smart_library }
+    let(:gtk_dialog) { properties_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      properties_dialog.acquire
+    end
+
+    it "works when response is ok" do
+      allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::OK)
+      properties_dialog.acquire
+    end
+  end
 end

data/spec/alexandria/ui/ui_manager_spec.rb

@@ -4,11 +4,48 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::UIManager do
+  let(:main_app) { instance_double(Alexandria::UI::MainApp) }
+
   it "works" do
-    main_app = instance_double(Alexandria::UI::MainApp)
     described_class.new main_app
   end
+
+  describe "#on_new" do
+    it "works" do
+      ui = described_class.new main_app
+      libraries = ui.instance_variable_get("@libraries")
+      libraries_count = libraries.all_libraries.count
+      ui.on_new
+      expect(libraries.all_libraries.count).to eq libraries_count + 1
+    end
+  end
+
+  describe "#on_books_selection_changed" do
+    let(:lib_version) { File.join(LIBDIR, "0.6.2") }
+    let(:ui) { described_class.new main_app }
+    let(:libraries) { ui.instance_variable_get("@libraries") }
+    let(:regular_library) { libraries.all_regular_libraries.last }
+
+    before do
+      FileUtils.cp_r(lib_version, TESTDIR)
+    end
+
+    it "works when single book is selected" do
+      ui.select_a_library regular_library
+
+      # FIXME: This is needed because right now UIManager#refresh_books doesn't
+      # work without Gtk loop.
+      regular_library.each { |book| ui.append_book book }
+      ui.iconview.unfreeze
+      expect(ui.model.iter_n_children).to eq regular_library.count
+
+      # This triggers the #on_books_selection_changed callback
+      ui.select_a_book regular_library.first
+
+      expect(ui.iconview.selected_items).not_to be_empty
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -4,11 +4,11 @@
 #
 # See the file README.md for authorship and licensing information.
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "/../lib"))
-
+require "rspec"
 require "alexandria"
+require "webmock/rspec"
 
-LIBDIR = File.expand_path(File.join(File.dirname(__FILE__), "/data/libraries"))
+LIBDIR = File.expand_path("data/libraries", __dir__)
 TESTDIR = File.join(LIBDIR, "test")
 
 def an_artist_of_the_floating_world
@@ -19,12 +19,55 @@ def an_artist_of_the_floating_world
                        "Paperback")
 end
 
+def assert_correct_search_result(provider, query,
+                                 search_type = Alexandria::BookProviders::SEARCH_BY_ISBN)
+  begin
+    results = provider.instance.search(query, search_type)
+  rescue SocketError
+    skip "Service is offline"
+  end
+
+  expect(results).to be_instance_of(Array), "Results are not an array for #{provider}"
+  expect(results).not_to be_empty, "Results are empty for #{provider}"
+
+  if search_type == Alexandria::BookProviders::SEARCH_BY_ISBN
+    expect(results.length).to be <= 2, "Results are greater than 2 for #{provider}"
+
+    book = results.first
+
+    expect(book).to be_instance_of(Alexandria::Book),
+                    "Result is not a Book for #{provider}"
+
+    canonical_query = Alexandria::Library.canonicalise_ean(query)
+    canonical_result = Alexandria::Library.canonicalise_ean(book.isbn)
+    expect(canonical_query)
+      .to eq(canonical_result),
+          "Result's isbn #{book.isbn} is not equivalent" \
+          " to the requested isbn #{query} for #{provider}"
+
+    if results.length == 2
+      cover_url = results.last
+      if cover_url
+        expect(cover_url)
+          .to be_instance_of(String),
+              "Unexpected cover_url #{cover_url.inspect} for #{provider}"
+      end
+    end
+  else
+    expect(results.first.first)
+      .to be_instance_of(Alexandria::Book), "Result item is not a Book for #{provider}"
+  end
+  results
+end
+
 Alexandria::UI::Icons.init
 
 test_store = Alexandria::LibraryStore.new(TESTDIR)
 Alexandria::LibraryCollection.instance.library_store = test_store
 
 RSpec.configure do |config|
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
   config.before do
     FileUtils.rm_rf(TESTDIR)
   end

data/tasks/spec.rake

@@ -2,7 +2,7 @@
 
 # -*- ruby -*-
 #--
-# Copyright (C) 2011-2019 Matijs van Zuijlen
+# Copyright (C) 2011 Matijs van Zuijlen
 #
 # This file is part of the Alexandria build system.
 #
@@ -39,10 +39,8 @@ namespace "spec" do
     t.ruby_opts = ["-rbundler/setup -rsimplecov -Ilib -w"]
   end
 
-  RSpec::Core::RakeTask.new("all") do |t|
-    t.pattern = "spec/**/*_spec.rb"
-    t.ruby_opts = ["-rbundler/setup -rsimplecov -Ilib -w"]
-  end
+  desc "Runs all unit and end-to-end specs"
+  task "all" => ["spec:unit", "spec:end_to_end"]
 end
 
 task spec: "spec:all"