alexandria-book-collection-manager 0.7.5 → 0.7.6

data/spec/alexandria/console_spec.rb

@@ -10,14 +10,9 @@ RSpec.describe Alexandria do
   let(:lib_version) { File.join(LIBDIR, "0.6.2") }
 
   before do
-    FileUtils.rm_rf(TESTDIR)
     FileUtils.cp_r(lib_version, TESTDIR)
   end
 
-  after do
-    FileUtils.rm_rf(TESTDIR)
-  end
-
   describe ".list_books_on_console" do
     it "returns a string containing a list of all books" do
       expect(described_class.list_books_on_console).to eq <<~LIST

data/spec/alexandria/export_library_spec.rb

@@ -7,24 +7,23 @@
 require "spec_helper"
 
 RSpec.describe Alexandria::ExportLibrary do
-  let(:lib_version) { File.join(LIBDIR, "0.6.2") }
-
-  let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
-
+  let(:my_library) do
+    loader = Alexandria::LibraryStore.new(TESTDIR)
+    loader.load_library("My Library")
+  end
   let(:format) { Alexandria::ExportFormat.all.find { |it| it.message == message } }
-  let(:outfile_base) { format.ext ? "my-library.#{format.ext}" : "my-library" }
-  let(:outfile) { File.join(Dir.tmpdir, outfile_base) }
-
+  let(:outfile) do
+    outfile_base = format.ext ? "my-library.#{format.ext}" : "my-library"
+    File.join(Dir.tmpdir, outfile_base)
+  end
   let(:unsorted) { Alexandria::LibrarySortOrder::Unsorted.new }
 
   before do
-    FileUtils.cp_r(lib_version, TESTDIR)
-    @my_library = loader.load_library("My Library")
-    expect(@my_library.size).to eq 5
+    test_library = File.join(LIBDIR, "0.6.2")
+    FileUtils.cp_r(test_library, TESTDIR)
   end
 
   after do
-    FileUtils.rm_rf(TESTDIR)
     FileUtils.rm_rf(outfile) if File.exist? outfile
   end
 
@@ -32,44 +31,33 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_csv_list }
 
     def load_rows_from_csv
-      CSV.read(outfile, col_sep: ";")
+      CSV.read(outfile, col_sep: ";", headers: true)
     end
 
     it "can sort by title" do
       sort_by_title = Alexandria::LibrarySortOrder.new(:title)
-      format.invoke(@my_library, sort_by_title, outfile)
-      expect(File.exist?(outfile)).to be_truthy
+      format.invoke(my_library, sort_by_title, outfile)
       rows = load_rows_from_csv
-      rows.shift
-      expect(rows.size).to eq(@my_library.size)
-      title_index = 0
-      comparisons = rows.size - 1
-      comparisons.times do |index|
-        expect(rows[index][title_index]).to be <= rows[index + 1][title_index]
-      end
+      titles = rows.map { |it| it["Title"] }
+      expect(titles).to eq titles.sort
     end
 
     it "can sort in descending order" do
       sort_by_date_desc = Alexandria::LibrarySortOrder.new(:publishing_year, false)
-      format.invoke(@my_library, sort_by_date_desc, outfile)
-      expect(File.exist?(outfile)).to be_truthy
+      format.invoke(my_library, sort_by_date_desc, outfile)
       rows = load_rows_from_csv
-      rows.shift
-      expect(rows.size).to eq(@my_library.size)
-      date_index = 5
-      comparisons = rows.size - 1
-      comparisons.times do |index|
-        expect(rows[index][date_index]).to be >= rows[index + 1][date_index]
-      end
+      dates = rows.map { |it| it["Year Published"] }
+      expect(dates).to eq dates.sort.reverse
     end
   end
 
   describe "#export_as_html" do
     let(:message) { :export_as_html }
-    let(:index) { File.join(outfile, "index.html") }
 
     it "can export unsorted" do
-      format.invoke(@my_library, unsorted, outfile, Alexandria::WebTheme.all.first)
+      format.invoke(my_library, unsorted, outfile, Alexandria::WebTheme.all.first)
+      index = File.join(outfile, "index.html")
+
       aggregate_failures do
         expect(File.exist?(outfile)).to be_truthy
         expect(File.exist?(index)).to be_truthy
@@ -82,7 +70,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_onix_xml_archive }
 
     it "can export unsorted" do
-      format.invoke(@my_library, unsorted, outfile)
+      format.invoke(my_library, unsorted, outfile)
       aggregate_failures do
         expect(File.exist?(outfile)).to be_truthy
         expect(File.size(outfile)).to be_nonzero
@@ -94,7 +82,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_tellico_xml_archive }
 
     it "can export unsorted" do
-      format.invoke(@my_library, unsorted, outfile)
+      format.invoke(my_library, unsorted, outfile)
       aggregate_failures do
         expect(File.exist?(outfile)).to be_truthy
         expect(File.size(outfile)).to be_nonzero
@@ -106,7 +94,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_bibtex }
 
     it "can export unsorted" do
-      format.invoke(@my_library, unsorted, outfile)
+      format.invoke(my_library, unsorted, outfile)
       aggregate_failures do
         expect(File.exist?(outfile)).to be_truthy
         expect(File.size(outfile)).to be_nonzero
@@ -118,7 +106,7 @@ RSpec.describe Alexandria::ExportLibrary do
     let(:message) { :export_as_isbn_list }
 
     it "can export unsorted" do
-      format.invoke(@my_library, unsorted, outfile)
+      format.invoke(my_library, unsorted, outfile)
       aggregate_failures do
         expect(File.exist?(outfile)).to be_truthy
         expect(File.size(outfile)).to be_nonzero
@@ -128,10 +116,11 @@ RSpec.describe Alexandria::ExportLibrary do
 
   describe "#export_as_ipod_notes" do
     let(:message) { :export_as_ipod_notes }
-    let(:index) { File.join(outfile, "index.linx") }
 
     it "can export unsorted" do
-      format.invoke(@my_library, unsorted, outfile, nil)
+      format.invoke(my_library, unsorted, outfile, nil)
+      index = File.join(outfile, "index.linx")
+
       aggregate_failures do
         expect(File.exist?(outfile)).to be_truthy
         expect(File.size(index)).to be_nonzero

data/spec/alexandria/library_spec.rb

@@ -78,10 +78,6 @@ describe Alexandria::Library do
       FileUtils.mkdir(TESTDIR) unless File.exist? TESTDIR
     end
 
-    after do
-      FileUtils.rm_rf(TESTDIR)
-    end
-
     it "disallows multiple deletion of the same copy of a book" do
       first_copy = an_artist_of_the_floating_world
       my_library << first_copy
@@ -104,53 +100,64 @@ describe Alexandria::Library do
   end
 
   describe ".import_as_isbn_list" do
-    def __test_fake_import_isbns
+    before do
       libraries = Alexandria::LibraryCollection.instance
-      library = Alexandria::Library.new("Test Library")
+      library = described_class.new("Test Library")
       libraries.add_library(library)
-      [library, libraries]
+
+      allow(Alexandria::BookProviders)
+        .to receive(:isbn_search)
+        .and_raise Alexandria::BookProviders::SearchEmptyError
+      allow(Alexandria::BookProviders)
+        .to receive(:isbn_search).with("0595371086")
+        .and_return(an_artist_of_the_floating_world)
     end
 
-    it "doesn't work quite yet" do
-      skip
-      # Doesn't work quite yet.
-      on_iterate_cb = proc {}
-      on_error_cb = proc {}
-      library, _libraries = __test_fake_import_isbns
-      test_file = "data/isbns.txt"
-      library.import_as_isbn_list("Test Library", test_file, on_iterate_cb, on_error_cb)
+    it "imports books with correct isbn and search result" do
+      library, bad_isbns, failed_lookup_isbns =
+        described_class.import_as_isbn_list("Test Library", "spec/data/isbns.txt",
+                                            proc {}, proc {})
+
+      aggregate_failures do
+        expect(library.to_a).to eq [an_artist_of_the_floating_world]
+        expect(bad_isbns).to eq ["0911826449"]
+        expect(failed_lookup_isbns).to eq ["0740704923"]
+      end
     end
   end
 
   context "when importing from 0.6.1 data files" do
+    let(:libs) { loader.load_all_libraries }
+    let(:my_library) { libs[0] }
+
     before do
       lib_version = File.join(LIBDIR, "0.6.1")
       FileUtils.cp_r(lib_version, TESTDIR)
     end
 
-    after do
-      FileUtils.rm_rf(TESTDIR)
+    it "can be loaded" do
+      expect(libs.size).to eq(1)
+      expect(my_library.size).to eq(3)
     end
 
     it "imports cleanly from version 0.6.1 data format" do
-      libs = loader.load_all_libraries
-      expect(libs.size).to eq(1)
-      my_library = libs[0]
-      expect(my_library.size).to eq(3)
       # Malory
-      malory_book = my_library.select { |b| b.isbn == "9780192812179" }[0]
+      malory_book = my_library.find { |b| b.isbn == "9780192812179" }
       expect(malory_book.publisher).to eq("Oxford University Press")
       expect(malory_book.authors.include?("Vinaver")).to be_truthy
       expect(malory_book.version).to eq(Alexandria::DATA_VERSION)
 
       # Guide to LaTeX
-      latex_book = my_library.select { |b| b.title.include? "Latex" }[0]
+      latex_book = my_library.find { |b| b.title.include? "Latex" }
       expect(latex_book.isbn).to eq("9780201398250")
       expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
     end
   end
 
   context "when importing from 0.6.1 with books without an ISBN" do
+    let(:libs) { loader.load_all_libraries }
+    let(:my_library) { libs[0] }
+
     before do
       lib_version = File.join(LIBDIR, "0.6.1-noisbn")
       FileUtils.cp_r(lib_version, TESTDIR)
@@ -160,58 +167,63 @@ describe Alexandria::Library do
       FileUtils.rm_rf(TESTDIR)
     end
 
-    it "allows books to have no ISBN" do
-      libs = loader.load_all_libraries
+    it "can be loaded" do
       expect(libs.size).to eq(1)
-      my_library = libs[0]
       expect(my_library.size).to eq(2)
+    end
 
+    it "loads a book with ISBN" do
       # Guide to LaTeX
-      latex_book = my_library.select { |b| b.title.include? "Latex" }[0]
+      latex_book = my_library.find { |b| b.title.include? "Latex" }
       expect(latex_book.isbn).to eq("9780201398250")
       expect(latex_book.publisher).to eq("Addison Wesley") # note, no Ruby-Amazon cruft
       expect(latex_book.version).to eq(Alexandria::DATA_VERSION)
+    end
 
+    it "loads a book without ISBN" do
       # Lex and Yacc
-      lex_and_yacc_book = my_library.select { |b| b.title.include? "Lex" }[0]
+      lex_and_yacc_book = my_library.find { |b| b.title.include? "Lex" }
       expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
+    end
 
-      my_library.each do |book|
-        my_library.save(book, true)
-      end
-
-      libraries_reloaded = loader.load_all_libraries
-      my_library_reloaded = libraries_reloaded[0]
-
+    it "saves loaded books properly" do
+      my_library.each { |book| my_library.save(book, true) }
+      my_library_reloaded = loader.load_all_libraries[0]
       expect(my_library_reloaded.size).to eq(2)
 
-      latex_book = my_library_reloaded.select { |b| b.title.include? "Latex" }[0]
-      expect(latex_book).not_to be_nil
+      latex_book = my_library_reloaded.find { |b| b.title.include? "Latex" }
       expect(latex_book.publisher).to eq("Addison Wesley")
 
-      lex_and_yacc_book = my_library_reloaded.select { |b| b.title.include? "Lex" }[0]
-      expect(lex_and_yacc_book).not_to be_nil
+      lex_and_yacc_book = my_library_reloaded.find { |b| b.title.include? "Lex" }
       expect(lex_and_yacc_book.publisher).to eq("O'Reilley")
     end
   end
 
   describe ".move" do
+    let(:source) { loader.load_library("My Library") }
+    let(:target) { loader.load_library("Target") }
+    let(:book) { source.first }
+
     before do
       lib_version = File.join(LIBDIR, "0.6.2")
       FileUtils.cp_r(lib_version, TESTDIR)
     end
 
-    it "moves the given book from source to target" do
-      source = loader.load_library("My Library")
+    it "changes the number of books in the source and target libraries" do
       count = source.count
-      book = source.first
-      target = loader.load_library("Target")
 
-      described_class.move(source, target, source.first)
+      described_class.move(source, target, book)
 
       aggregate_failures do
         expect(source.count).to eq count - 1
         expect(target.count).to eq 1
+      end
+    end
+
+    it "moves the book files from source to target" do
+      described_class.move(source, target, book)
+
+      aggregate_failures do
         expect(File.exist?(source.yaml(book))).to be_falsey
         expect(File.exist?(source.cover(book))).to be_falsey
         expect(File.exist?(target.yaml(book))).to be_truthy

data/spec/alexandria/preferences_spec.rb

@@ -4,13 +4,39 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../spec_helper"
+require_relative "../spec_helper"
 
 describe Alexandria::Preferences do
   let(:instance) { described_class.instance }
 
-  it "returns nil fetching unknown setting" do
-    expect(instance.does_not_exist).to eq nil
+  describe "#get_variable" do
+    it "returns nil fetching unknown setting" do
+      expect(instance.get_variable("does_not_exist")).to eq nil
+    end
+
+    it "allows fetching by string" do
+      instance.toolbar_visible = false
+      expect(instance.get_variable("toolbar_visible")).to eq false
+    end
+
+    it "allows fetching by symbol" do
+      instance.toolbar_visible = true
+      expect(instance.get_variable(:toolbar_visible)).to eq true
+    end
+  end
+
+  describe "#set_variable" do
+    it "allows setting by string" do
+      instance.toolbar_visible = false
+      instance.set_variable("toolbar_visible", true)
+      expect(instance.toolbar_visible).to eq true
+    end
+
+    it "allows setting by symbol" do
+      instance.toolbar_visible = false
+      instance.set_variable(:toolbar_visible, true)
+      expect(instance.toolbar_visible).to eq true
+    end
   end
 
   it "allows setting known setting to false" do

data/spec/alexandria/scanners/cue_cat_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::Scanners::CueCat do
   let(:cuecat) { described_class.new }

data/spec/alexandria/ui/about_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::AboutDialog do
   it "works" do

data/spec/alexandria/ui/acquire_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::AcquireDialog do
   it "works" do

data/spec/alexandria/ui/alert_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::AlertDialog do
   it "works" do

data/spec/alexandria/ui/bad_isbns_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::BadIsbnsDialog do
   it "works" do

data/spec/alexandria/ui/book_properties_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::BookPropertiesDialog do
   it "works" do

data/spec/alexandria/ui/confirm_erase_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConfirmEraseDialog do
   it "works" do

data/spec/alexandria/ui/conflict_while_copying_dialog_spec.rb

@@ -4,7 +4,7 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require File.dirname(__FILE__) + "/../../spec_helper"
+require_relative "../../spec_helper"
 
 describe Alexandria::UI::ConflictWhileCopyingDialog do
   it "works" do