alexandria-book-collection-manager 0.7.3 → 0.7.8

data/lib/alexandria/book_providers/siciliano.rb

@@ -25,27 +25,27 @@
 # Almost completely rewritten by Cathal Mc Ginley (21 Feb 2009)
 # based on the new code for Palatina
 
-require 'net/http'
-require 'cgi'
-require 'alexandria/book_providers/web'
+require "net/http"
+require "cgi"
+require "alexandria/book_providers/web"
 
 module Alexandria
   class BookProviders
     class SicilianoProvider < WebsiteBasedProvider
       include Logging
 
-      SITE = 'http://www.siciliano.com.br'
+      SITE = "http://www.siciliano.com.br"
 
       # The string interpolations in this URL are the search term and search
       # type, respectively.
       BASE_SEARCH_URL = "#{SITE}/pesquisaweb/pesquisaweb.dll/pesquisa?" \
-        '&FIL_ID=102' \
-        '&PALAVRASN1=%s' \
-        '&FILTRON1=%s' \
-        '&ESTRUTN1=0301&ORDEMN2=E'
+        "&FIL_ID=102" \
+        "&PALAVRASN1=%s" \
+        "&FILTRON1=%s" \
+        "&ESTRUTN1=0301&ORDEMN2=E"
 
       def initialize
-        super('Siciliano', 'Livraria Siciliano (Brasil)')
+        super("Siciliano", "Livraria Siciliano (Brasil)")
         # no preferences for the moment
         prefs.read
       end
@@ -57,7 +57,7 @@ module Alexandria
       end
 
       def search(criterion, type)
-        criterion = criterion.encode('ISO-8859-1') # still needed??
+        criterion = criterion.encode("ISO-8859-1") # still needed??
         trying_again = false
         begin
           req = create_search_uri(type, criterion, trying_again)
@@ -71,13 +71,13 @@ module Alexandria
           else
             results.map { |result| get_book_from_search_result(result) }
           end
-        rescue NoResultsError => err
+        rescue NoResultsError => ex
           if (type == SEARCH_BY_ISBN) && (trying_again == false)
             trying_again = true
             retry
-          else
-            raise err
           end
+
+          raise ex
         end
       end
 
@@ -90,10 +90,10 @@ module Alexandria
       private
 
       def create_search_uri(search_type, search_term, trying_again = false)
-        (search_type_code = { SEARCH_BY_ISBN    => 'G',
-                              SEARCH_BY_TITLE   => 'A',
-                              SEARCH_BY_AUTHORS => 'B',
-                              SEARCH_BY_KEYWORD => 'X' }[search_type]) || 'X'
+        (search_type_code = { SEARCH_BY_ISBN    => "G",
+                              SEARCH_BY_TITLE   => "A",
+                              SEARCH_BY_AUTHORS => "B",
+                              SEARCH_BY_KEYWORD => "X" }[search_type]) || "X"
         search_term_encoded = if search_type == SEARCH_BY_ISBN
                                 if trying_again
                                   # on second attempt, try ISBN-10...
@@ -123,35 +123,33 @@ module Alexandria
         book_search_results = []
         # each result will be a dict with keys :title, :author, :publisher, :url
 
-        list_items = doc.search('div.pesquisa-item-lista-conteudo')
+        list_items = doc.search("div.pesquisa-item-lista-conteudo")
         list_items.each do |item|
-          begin
-            result = {}
+          result = {}
 
-            # author & publisher
-            author_publisher = ''
-            item.children.each do |node|
-              author_publisher += node.to_s if node.text?
-              author_publisher.strip!
-              break unless author_publisher.empty?
-            end
-            author, publisher = author_publisher.split('/')
-            result[:author] = author.strip if author
-            result[:publisher] = publisher.strip if publisher
+          # author & publisher
+          author_publisher = ""
+          item.children.each do |node|
+            author_publisher += node.to_s if node.text?
+            author_publisher.strip!
+            break unless author_publisher.empty?
+          end
+          author, publisher = author_publisher.split("/")
+          result[:author] = author.strip if author
+          result[:publisher] = publisher.strip if publisher
 
-            # title & url
-            link = item % 'a'
-            result[:title] = link.inner_text.strip
-            link_to_description = link['href']
-            slash = ''
-            slash = '/' unless link_to_description =~ /^\//
-            result[:url] = "#{SITE}#{slash}#{link_to_description}"
+          # title & url
+          link = item % "a"
+          result[:title] = link.inner_text.strip
+          link_to_description = link["href"]
+          slash = ""
+          slash = "/" unless link_to_description.start_with?("/")
+          result[:url] = "#{SITE}#{slash}#{link_to_description}"
 
-            book_search_results << result
-          rescue StandardError => ex
-            trace = ex.backtrace.join("\n> ")
-            log.error { "Failed parsing Siciliano search page #{ex.message}\n#{trace}" }
-          end
+          book_search_results << result
+        rescue StandardError => ex
+          trace = ex.backtrace.join("\n> ")
+          log.error { "Failed parsing Siciliano search page #{ex.message}\n#{trace}" }
         end
 
         book_search_results
@@ -161,51 +159,49 @@ module Alexandria
         # checked against Siciliano website 21 Feb 2009
         doc = html_to_doc(html)
         # title
-        title_div = doc % 'div#conteudo//div.titulo'
+        title_div = doc % "div#conteudo//div.titulo"
         raise NoResultsError unless title_div
 
-        title_h = title_div % 'h2'
+        title_h = title_div % "h2"
         title = title_h.inner_text if title_h
         # title = first_non_empty_text_node(title_div)
         # author_spans = doc/'span.rotulo'
-        author_hs = title_div / 'h3.autor'
+        author_hs = title_div / "h3.autor"
         authors = []
         author_hs.each do |h|
           authors << h.inner_text.strip
         end
         ## synopsis_div = doc % 'div#sinopse'
-        details_div = doc % 'div#tab-caracteristica'
+        details_div = doc % "div#tab-caracteristica"
         details = string_array_to_map(lines_of_text_as_array(details_div))
         # ISBN
-        isbn =  details['ISBN']
+        isbn =  details["ISBN"]
         ## ean = details["CdBarras"]
-        translator = details['Tradutor']
+        translator = details["Tradutor"]
         authors << translator if translator
-        binding = details['Acabamento']
+        binding = details["Acabamento"]
         publisher = search_result[:publisher]
         # publish year
         publish_year = nil
-        edition = details['Edio']
-        if edition
-          publish_year = Regexp.last_match[1].to_i if edition =~ /([12][0-9]{3})/ # publication date
-        end
+        edition = details["Edio"]
+        # publication date
+        publish_year = Regexp.last_match[1].to_i if edition && edition =~ /([12][0-9]{3})/
         # cover
         # ImgSrc[1]="/imagem/imagem.dll?pro_id=1386929&PIM_Id=658849";
         image_urls = []
-        (doc / 'script').each do |script|
+        (doc / "script").each do |script|
           next if script.children.nil?
 
           script.children.each do |ch|
             ch_text = ch.to_s
-            if ch_text =~ /ImgSrc\[[\d]\]="(.+)";/
+            if ch_text =~ /ImgSrc\[\d\]="(.+)";/
               img_link = Regexp.last_match[1]
               image_urls << img_link
             end
           end
         end
         book = Book.new(title, authors, isbn, publisher, publish_year, binding)
-        result = [book, image_urls.first]
-        result
+        [book, image_urls.first]
       rescue StandardError => ex
         trace = ex.backtrace.join("\n> ")
         log.error { "Failed parsing Siciliano product page #{ex.message}\n#{trace}" }
@@ -213,7 +209,7 @@ module Alexandria
       end
 
       def first_non_empty_text_node(elem)
-        text = ''
+        text = ""
         elem.children.each do |node|
           next unless node.text?
 
@@ -225,28 +221,28 @@ module Alexandria
 
       def lines_of_text_as_array(elem)
         lines = []
-        current_text = ''
+        current_text = ""
         elem.children.each do |e|
           if e.text?
             current_text += e.to_s
-          elsif e.name == 'br'
+          elsif e.name == "br"
             lines << current_text.strip
-            current_text = ''
+            current_text = ""
           else
             current_text += e.inner_text
           end
         end
         lines << current_text.strip
-        lines.delete('')
+        lines.delete("")
         lines
       end
 
       def string_array_to_map(arr)
         map = {}
         arr.each do |str|
-          key, val = str.split(':')
+          key, val = str.split(":")
           # a real hack for not handling encoding properly :^)
-          map[key.gsub(/[^a-zA-Z]/, '')] = val.strip if val
+          map[key.gsub(/[^a-zA-Z]/, "")] = val.strip if val
         end
         map
       end

data/lib/alexandria/book_providers/thalia_provider.rb

@@ -0,0 +1,161 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+# http://de.wikipedia.org/wiki/Thalia_%28Buchhandel%29
+# Thalia.de bought the Austrian book trade chain Amadeus
+
+# New Thalia provider, taken from Palatina MetaDataSource and modified
+# for Alexandria. (21 Dec 2009)
+
+require "net/http"
+require "cgi"
+require "alexandria/book_providers/web"
+
+module Alexandria
+  class BookProviders
+    class ThaliaProvider < WebsiteBasedProvider
+      include Logging
+
+      SITE = "https://www.thalia.de"
+      BASE_SEARCH_URL = "#{SITE}/shop/bde_bu_hg_startseite/suche/?%s=%s" # type,term
+
+      def initialize
+        super("Thalia", "Thalia (Germany)")
+        # no preferences for the moment
+        prefs.read
+      end
+
+      def url(book)
+        create_search_uri(SEARCH_BY_ISBN, book.isbn)
+      end
+
+      def search(criterion, type)
+        req = create_search_uri(type, criterion)
+        log.debug { req }
+        html_data = transport.get_response(URI.parse(req))
+        if type == SEARCH_BY_ISBN
+          parse_result_data(html_data.body, criterion)
+        else
+          results = parse_search_result_data(html_data.body)
+          raise NoResultsError if results.empty?
+
+          results.map { |result| get_book_from_search_result(result) }
+        end
+      end
+
+      def create_search_uri(search_type, search_term)
+        (search_type_code = {
+          SEARCH_BY_ISBN    => "sq",
+          SEARCH_BY_AUTHORS => "sa", # Autor
+          SEARCH_BY_TITLE   => "st", # Titel
+          SEARCH_BY_KEYWORD => "ssw" # Schlagwort
+        }[search_type]) || ""
+        search_type_code = CGI.escape(search_type_code)
+        search_term_encoded = if search_type == SEARCH_BY_ISBN
+                                # search_term_encoded = search_term.as_isbn_13
+                                Library.canonicalise_isbn(search_term) # check this!
+                              else
+                                CGI.escape(search_term)
+                              end
+        format(BASE_SEARCH_URL, search_type_code, search_term_encoded)
+      end
+
+      def parse_search_result_data(html)
+        doc = html_to_doc(html)
+        book_search_results = []
+
+        results_items = doc / "ul.weitere-formate li.format"
+
+        results_items.each do |item|
+          result = {}
+          item_link = item % "a"
+          result[:lookup_url] = "#{SITE}#{item_link['href']}"
+          book_search_results << result
+        end
+        book_search_results
+      end
+
+      def data_from_label(node, label_text)
+        label_node = node % "th[text()*='#{label_text}']"
+        return "" unless label_node
+
+        item_node = label_node.parent % "td"
+        item_node.inner_text.strip
+      end
+
+      def get_book_from_search_result(result)
+        log.debug { "Fetching book from #{result[:lookup_url]}" }
+        html_data = transport.get_response(URI.parse(result[:lookup_url]))
+        parse_result_data(html_data.body, "noisbn", recursing: true)
+      end
+
+      def parse_result_data(html, isbn, recursing: false)
+        doc = html_to_doc(html)
+
+        results_divs = doc / "ul.weitere-formate"
+        unless results_divs.empty?
+          if recursing
+            # already recursing, avoid doing so endlessly second time
+            # around *should* lead to a book description, not a result
+            # list
+            return
+          end
+
+          # ISBN-lookup results in multiple results
+          results = parse_search_result_data(html)
+          chosen = results.first # fallback!
+          html_data = transport.get_response(URI.parse(chosen[:lookup_url]))
+          return parse_result_data(html_data.body, isbn, recursing: true)
+        end
+
+        begin
+          if (div = doc % "section#sbe-product-details")
+            title = div["data-titel"]
+
+            if (author_p = doc % "p.aim-author")
+              authors = []
+              author_links = author_p / :a
+              author_links.each do |a|
+                authors << a.inner_text.strip
+              end
+            end
+
+            item_details = doc % "section.artikeldetails"
+            isbns = []
+            isbns << data_from_label(item_details, "EAN")
+            isbns << data_from_label(item_details, "ISBN")
+            isbns.reject!(&:empty?)
+
+            year = nil
+            date = data_from_label(item_details, "Erscheinungsdatum")
+            year = Regexp.last_match[1].to_i if date =~ /(\d{4})/
+
+            book_binding = data_from_label(item_details, "Einband")
+
+            publisher = data_from_label(item_details, "Verlag")
+
+            book = Book.new(title, authors, isbns.first,
+                            publisher, year, book_binding)
+
+            image_url = nil
+            if (image = doc % "section.imagesPreview img")
+              image_url = image["src"]
+            end
+
+            [book, image_url]
+          end
+        rescue StandardError => ex
+          trace = ex.backtrace.join("\n> ")
+          log.warn do
+            "Failed parsing search results for Thalia " \
+            "#{ex.message} #{trace}"
+          end
+          raise NoResultsError
+        end
+      end
+    end
+  end
+end

data/lib/alexandria/book_providers/web.rb

@@ -4,8 +4,8 @@
 #
 # See the file README.md for authorship and licensing information.
 
-require 'hpricot'
-require 'htmlentities'
+require "hpricot"
+require "htmlentities"
 
 module Alexandria
   class BookProviders
@@ -15,9 +15,9 @@ module Alexandria
         @htmlentities = HTMLEntities.new
       end
 
-      def html_to_doc(html, source_data_charset = 'ISO-8859-1')
+      def html_to_doc(html, source_data_charset = "ISO-8859-1")
         html.force_encoding source_data_charset
-        utf8_html = html.encode('utf-8')
+        utf8_html = html.encode("utf-8")
         normalized_html = @htmlentities.decode(utf8_html)
         Hpricot(normalized_html)
       end
@@ -33,7 +33,7 @@ module Alexandria
             nil
           else
             node_text = node.children.map { |n| text_of(n) }.join
-            node_text.strip.squeeze(' ')
+            node_text.strip.squeeze(" ")
           end
         end
         # node.inner_html.strip

data/lib/alexandria/book_providers/worldcat.rb

@@ -1,24 +1,9 @@
 # frozen_string_literal: true
 
-# -*- ruby -*-
+# This file is part of Alexandria.
 #
-# Copyright (C) 2009 Cathal Mc Ginley
-# Copyright (C) 2011, 2014 Matijs van Zuijlen
-#
-# Alexandria is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of the
-# License, or (at your option) any later version.
-#
-# Alexandria is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
-# License along with Alexandria; see the file COPYING.  If not,
-# write to the Free Software Foundation, Inc., 51 Franklin Street,
-# Fifth Floor, Boston, MA 02110-1301 USA.
+# See the file README.md for authorship and licensing information.
+# frozen_string_literal: true
 
 # http://en.wikipedia.org/wiki/WorldCat
 # See http://www.oclc.org/worldcat/policies/terms/
@@ -30,34 +15,27 @@
 # Updated from Palatina, to reflect changes in the worldcat website.
 # (1 Sep 2009)
 
-require 'cgi'
-require 'alexandria/net'
-require 'alexandria/book_providers/web'
+require "cgi"
+require "alexandria/net"
+require "alexandria/book_providers/web"
 
 module Alexandria
   class BookProviders
     class WorldCatProvider < WebsiteBasedProvider
-      include Alexandria::Logging
+      include Logging
 
-      SITE = 'http://www.worldcat.org'
+      SITE = "https://www.worldcat.org"
       BASE_SEARCH_URL = "#{SITE}/search?q=%s%s&qt=advanced" # type, term
 
       def initialize
-        super('WorldCat', 'WorldCat')
-        # prefs.add("enabled", _("Enabled"), true, [true,false])
+        super("WorldCat", "WorldCat")
         prefs.read
       end
 
       def search(criterion, type)
-        # puts create_search_uri(type, criterion)
         req = create_search_uri(type, criterion)
-        puts req if $DEBUG
         html_data = transport.get_response(URI.parse(req))
-        # Note: I tried to use Alexandria::WWWAgent,
-        #       but this caused failures here (empty pages...)
-        #       find out how the requests differ
 
-        # puts html_data.class
         if type == SEARCH_BY_ISBN
           parse_result_data(html_data.body, criterion)
         else
@@ -70,18 +48,15 @@ module Alexandria
 
       def url(book)
         create_search_uri(SEARCH_BY_ISBN, book.isbn)
-      rescue StandardError => ex
-        log.warn { "Cannot create url for book #{book}; #{ex.message}" }
-        nil
       end
 
       private
 
       def create_search_uri(search_type, search_term)
-        (search_type_code = { SEARCH_BY_ISBN    => 'isbn:',
-                              SEARCH_BY_AUTHORS => 'au:',
-                              SEARCH_BY_TITLE   => 'ti:',
-                              SEARCH_BY_KEYWORD => '' }[search_type]) || ''
+        (search_type_code = { SEARCH_BY_ISBN    => "isbn:",
+                              SEARCH_BY_AUTHORS => "au:",
+                              SEARCH_BY_TITLE   => "ti:",
+                              SEARCH_BY_KEYWORD => "" }[search_type]) || ""
         search_type_code = CGI.escape(search_type_code)
         search_term_encoded = if search_type == SEARCH_BY_ISBN
                                 Library.canonicalise_ean(search_term) # isbn-13
@@ -98,19 +73,18 @@ module Alexandria
       end
 
       def parse_search_result_data(html)
-        doc = html_to_doc(html, 'UTF-8')
+        doc = html_to_doc(html, "UTF-8")
         book_search_results = []
         begin
-          result_cells = doc / 'td.result/div.name/..'
-          # puts result_cells.length
+          result_cells = doc / "td.result/div.name/.."
           result_cells.each do |td|
-            type_icon = (td % 'div.type/img.icn')
-            next unless type_icon && type_icon['src'] =~ /icon-bks/
+            type_icon = (td % "div.type/img.icn")
+            next unless type_icon && type_icon["src"].include?("icon-bks")
 
-            name_div = td % 'div.name'
+            name_div = td % "div.name"
             title = name_div.inner_text
             anchor = name_div % :a
-            url = anchor['href'] if anchor
+            url = anchor["href"] if anchor
             lookup_url = "#{SITE}#{url}"
             result = {}
             result[:title] = title
@@ -120,29 +94,29 @@ module Alexandria
           end
         rescue StandardError => ex
           trace = ex.backtrace.join("\n> ")
-          log.warn {
-            'Failed parsing search results for WorldCat ' \
+          log.warn do
+            "Failed parsing search results for WorldCat " \
                     "#{ex.message} #{trace}"
-          }
+          end
         end
         book_search_results
       end
 
       def parse_result_data(html, search_isbn = nil, recursing = false)
-        doc = html_to_doc(html, 'UTF-8')
+        doc = html_to_doc(html, "UTF-8")
 
         begin
-          if doc % 'div#div-results-none'
-            log.debug { 'WorldCat reports no results' }
+          if doc % "div#div-results-none"
+            log.debug { "WorldCat reports no results" }
             raise NoResultsError
           end
 
-          if doc % 'table.table-results'
+          if doc % "table.table-results"
             if recursing
-              log.warn { 'Infinite loop prevented redirecting through WorldCat' }
+              log.warn { "Infinite loop prevented redirecting through WorldCat" }
               raise NoResultsError
             end
-            log.info { 'Found multiple results for lookup: checking each' }
+            log.info { "Found multiple results for lookup: checking each" }
             search_results = parse_search_result_data(html)
             book = nil
             cover_url = nil
@@ -154,40 +128,39 @@ module Alexandria
               html2 = rslt2.body
 
               book, cover_url = parse_result_data(html2, search_isbn, true)
-              first_result = [book, cover_url] if first_result.nil?
 
               log.debug { "got book #{book}" }
 
-              if search_isbn
-                search_isbn_canon = Library.canonicalise_ean(search_isbn)
-                rslt_isbn_canon = Library.canonicalise_ean(book.isbn)
-                if search_isbn_canon == rslt_isbn_canon
-                  log.info { "book #{book} is a match" }
-                  return [book, cover_url]
-                end
-                log.debug { 'not a match, checking next' }
-              else
-                # no constraint to match isbn, just return first result
+              return [book, cover_url] unless search_isbn
+
+              first_result = [book, cover_url] if first_result.nil?
+
+              search_isbn_canon = Library.canonicalise_ean(search_isbn)
+              rslt_isbn_canon = Library.canonicalise_ean(book.isbn)
+              if search_isbn_canon == rslt_isbn_canon
+                log.info { "book #{book} is a match" }
                 return [book, cover_url]
               end
+              log.debug { "not a match, checking next" }
             end
 
             # gone through all and no ISBN match, so just return first result
-            log.info { 'no more results to check. Returning first result, just an approximation' }
+            log.info do
+              "no more results to check. Returning first result, just an approximation"
+            end
             return first_result
-
           end
 
-          title_header = doc % 'h1.title'
+          title_header = doc % "h1.title"
           title = title_header.inner_text if title_header
           unless title
-            log.warn { 'Unexpected lack of title from WorldCat lookup' }
+            log.warn { "Unexpected lack of title from WorldCat lookup" }
             raise NoResultsError
           end
           log.info { "Found book #{title} at WorldCat" }
 
           authors = []
-          authors_tr = doc % 'tr#details-allauthors'
+          authors_tr = doc % "tr#details-allauthors"
           if authors_tr
             (authors_tr / :a).each do |a|
               authors << a.inner_text
@@ -195,17 +168,17 @@ module Alexandria
           end
 
           # can we do better? get the City name?? or multiple publishers?
-          bibdata = doc % 'div#bibdata'
+          bibdata = doc % "div#bibdata"
           bibdata_table = bibdata % :table
-          publisher_row = bibdata_table % 'th[text()*=Publisher]/..'
+          publisher_row = bibdata_table % "th[text()*=Publisher]/.."
 
           if publisher_row
-            publication_info = (publisher_row / 'td').last.inner_text
+            publication_info = (publisher_row / "td").last.inner_text
 
-            publication_info =~ if publication_info.index(';')
-                                  /;[\s]*([^\d]+)[\s]*[\d]*/
-                                elsif publication_info.index(':')
-                                  /:[\s]*([^;:,]+)/
+            publication_info =~ if publication_info.index(";")
+                                  /;\s*([^\d]+)\s*\d*/
+                                elsif publication_info.index(":")
+                                  /:\s*([^;:,]+)/
                                 else
                                   /([^;,]+)/
                                 end
@@ -218,35 +191,33 @@ module Alexandria
             year = nil
           end
 
-          isbn = search_isbn
-          unless isbn
-            isbn_row = doc % 'tr#details-standardno' # #bibdata_table % 'th[text()*=ISBN]/..'
-            if isbn_row
-              isbns = (isbn_row / 'td').last.inner_text.split
-              isbn = Library.canonicalise_isbn(isbns.first)
-            else
-              log.warn { 'No ISBN found on page' }
-            end
+          isbn_row = doc % "tr#details-standardno"
+          if isbn_row
+            isbns = (isbn_row / "td").last.inner_text.split
+            isbn = Library.canonicalise_isbn(isbns.first)
+          else
+            log.warn { "No ISBN found on page" }
+            isbn = search_isbn
           end
 
-          binding = '' # not given on WorldCat website (as far as I can tell)
+          book_binding = "" # not given on WorldCat website (as far as I can tell)
 
-          book = Book.new(title, authors, isbn, publisher, year, binding)
+          book = Book.new(title, authors, isbn, publisher, year, book_binding)
 
           image_url = nil # hm, it's on the website, but uses JavaScript...
 
-          return [book, image_url]
+          [book, image_url]
         rescue StandardError => ex
           raise ex if ex.instance_of? NoResultsError
 
           trace = ex.backtrace.join("\n> ")
-          log.warn {
-            'Failed parsing search results for WorldCat ' \
+          log.warn do
+            "Failed parsing search results for WorldCat " \
                     "#{ex.message} #{trace}"
-          }
+          end
           raise NoResultsError
         end
       end
-    end # class WorldCatProvider
-  end # class BookProviders
-end # module Alexandria
+    end
+  end
+end