alexandria-book-collection-manager 0.7.3 → 0.7.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c5ce199935fd434ee40793e79cf4f8ad31c4f140e26844ae0bad7f6d111d5486
-  data.tar.gz: 76f857b281f0b11c6485d4196b2f47e3980eb4ff8ea7fe89797e7321388f0cf2
+  metadata.gz: 86ff53adf7e1792c32534b149370ab80a99a24c8a363273a1ca3d3f83e2c73c0
+  data.tar.gz: 6a38d050f6cf13a9d86e0c387cdbe472442a02c33f74563f4902f4338deac228
 SHA512:
-  metadata.gz: 4f49799facc13291bac2d34f82af36fc2cd9461eddf21b0f2cb30fa089517f4f5f2ed41713cba354c72a9143df5273059614969257834836ea604213fe05f47a
-  data.tar.gz: 89ab1a4b55b5df6b1ae9c2ec5f0ebcf82ad79e10208c6ff51572f59ccfa59ebeed51dfecac96b15e4442ffe081c5f717b2491478d3cad870aa1ae9be0012572e
+  metadata.gz: fbd36ea7f9caaabff7979e3ab57471e27a6a1a5daa33ce140d4a8df590b07d91f4302267db64c601281f3513401e5726a1874dba622a4d9e72a361c7898c1284
+  data.tar.gz: 87c17e9d9bc4c4bd057a1013068d034a48ca38e3fcd5784a743a1c1d971671165df4347bcb2aa710dd4a636ecc3d1bfdbee1f0bfe7a4eb7fccd7d4fb8acddd77

data/.github/dependabot.yml

@@ -0,0 +1,9 @@
+# Documentation for all configuration options:
+# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.github/workflows/ruby.yml

@@ -0,0 +1,77 @@
+# This workflow will download a prebuilt Ruby version, install dependencies and
+# run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: [2.5, 2.6, 2.7]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install non-ruby dependencies
+      run: |
+        # Needed for gtk3 gem
+        sudo apt-get install libgtk-3-dev
+        # Needed for gstreamer gem
+        sudo apt-get install libgstreamer1.0-dev
+        # Needed for GooCanvas::Canvas widget
+        sudo apt-get install libgoocanvas-2.0-dev
+        # Needed for zoom gem
+        sudo apt-get install libyaz-dev
+        # Needed for intltool-merge executable
+        sudo apt-get install intltool
+        # Needed for gconftool-2 executable
+        sudo apt-get install gconf2
+        # Needed to provide A11y dbus service to silence warnings
+        sudo apt-get install at-spi2-core
+        # Needed to set up sound player pipeline
+        sudo apt-get install gstreamer1.0-plugins-good
+        # Needed to play sound
+        sudo apt-get install pulseaudio
+        # Provides xvfb-run
+        sudo apt-get install xvfb
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - name: Run unit tests
+      run: xvfb-run bundle exec rake spec:unit
+    - name: Run end-to-end tests in a dbus session
+      run: xvfb-run dbus-run-session bundle exec rake spec:end_to_end
+
+  rubocop:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install non-ruby dependencies
+      run: |
+        # Needed for gtk3 gem
+        sudo apt-get install libgtk-3-dev
+        # Needed for gstreamer gem
+        sudo apt-get install libgstreamer1.0-dev
+        # Needed for zoom gem
+        sudo apt-get install libyaz-dev
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+        bundler-cache: true
+    - name: Run RuboCop
+      run: bundle exec rubocop -P

data/.gitignore

@@ -3,13 +3,16 @@ config.save
 alexandria.desktop
 alexandria.desktop.in.h
 .svn-authors
-lib/alexandria/default_preferences.rb
 Gemfile.lock
 .yardoc/
 share/locale/
 share/omf/alexandria/*.omf
+spec/examples.txt
 pkg/
 coverage/
 tmp/
+po/*.po~
+po/*.mo
+po/*.pot
 *.gem
 *.glade~

data/.rubocop.yml

@@ -1,18 +1,47 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-performance
+  - rubocop-rspec
+  - rubocop-i18n
+
 AllCops:
   Exclude:
     - 'lib/alexandria/default_preferences.rb'
     - 'pkg/**/*'
-  TargetRubyVersion: 2.3
+    - 'vendor/bundle/**/*'
+  NewCops: enable
+  TargetRubyVersion: 2.5
+
+# Choose GetText-style I18n cops
+GetText:
+  Enabled: true
+  # Exclude non-user-facing code
+  Exclude:
+    - Rakefile
+    - 'util/**/*'
+    - 'spec/**/*'
+RailsI18n:
+  Enabled: false
 
-# Dot at end of line makes it clearer that the line is not done
-Layout/DotPosition:
-  EnforcedStyle: trailing
+# This code has a lot of pre-existing translations with percent-style
+# formatting. Maybe one day someone will re-do all of them ...
+GetText/DecorateStringFormattingUsingPercent:
+  Enabled: false
 
-# Multi-line assignment should be simply indented. Aligning them makes it even
-# harder to keep a sane line length.
-Layout/MultilineOperationIndentation:
-  EnforcedStyle: indented
+# Make BeginEndAlignment behavior match EndAlignment
+Layout/BeginEndAlignment:
+  EnforcedStyleAlignWith: begin
+
+Layout/HashAlignment:
+  EnforcedColonStyle: key
+  EnforcedHashRocketStyle: table
+
+# Be lenient with line length
+Layout/LineLength:
+  Max: 92
 
+# Don't force lonely closing parentheses
 Layout/MultilineMethodCallBraceLayout:
   EnforcedStyle: same_line
 
@@ -21,71 +50,98 @@ Layout/MultilineMethodCallBraceLayout:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-# Make syntax for empty and filled blocks consistent
+# Multi-line assignment should be simply indented. Aligning them makes it even
+# harder to keep a sane line length.
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+# Force consistent spacing independent of block contents
 Layout/SpaceBeforeBlockBraces:
   EnforcedStyleForEmptyBraces: space
 
-Layout/AlignHash:
-  EnforcedColonStyle: key
-  EnforcedHashRocketStyle: table
+# Assume the programmer knows how bracketed block syntax works
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
 
 # Allow if (foo = get_foo) style
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
+# This cop's reach is too broad
+# See https://github.com/rubocop-hq/rubocop/pull/8480
+Lint/MissingSuper:
+  Enabled: false
+
 # Blocks in specs can be any size
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
 
-# Be lenient with line length
-Metrics/LineLength:
-  Max: 110
-
 Naming/AccessorMethodName:
   Enabled: false
 
-# Allow multi-line blocks of all sorts
-Style/BlockDelimiters:
-  Enabled: false
+# Avoid one-letter exception variable name
+Naming/RescuedExceptionsVariableName:
+  PreferredName: ex
+
+Performance/EndWith:
+  AutoCorrect: true
+
+Performance/StartWith:
+  AutoCorrect: true
+
+# End-to-end specs do not describe classes
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/end_to_end/**/*_spec.rb'
+
+RSpec/ExampleLength:
+  Max: 8
+  Exclude:
+    - 'spec/end_to_end/**/*_spec.rb'
 
 # Allow and/or for control flow only
 Style/AndOr:
-  Enabled: conditionals
+  EnforcedStyle: conditionals
 
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2
 
-# Not all objects that handle #== 0 also handle #zero?
-Style/NumericPredicate:
-  Enabled: false
-
 # Sometimes an if statement just looks better than next with a guard clause
 Style/Next:
   Enabled: false
 
+# Not all objects that handle #== 0 also handle #zero?
+Style/NumericPredicate:
+  Enabled: false
+
 # Use older RuboCop default
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
+    '%W': ()
     '%w': ()
 
 # Allow explicit return with multiple return values
 Style/RedundantReturn:
   AllowMultipleReturnValues: true
 
-# Always use raise to raise exceptions
-Style/SignalException:
-  EnforcedStyle: only_raise
-
 Style/SingleLineBlockParams:
   Enabled: false
 
-# I like to have symbols always look like symbols
+# Allow all ways to construct strings for now
+Style/StringConcatenation:
+  Enabled: false
+
+# Do not commit to use of interpolation
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+# Prefer symbols to look like symbols
 Style/SymbolArray:
   EnforcedStyle: brackets
 
-# Accessors are only trivial if they match the ivar name.
+# Accessors are only trivial if they match the ivar name
 Style/TrivialAccessors:
   ExactNameMatch: true
 
@@ -96,9 +152,3 @@ Style/TrailingCommaInArrayLiteral:
 # Alexandria uses regular arrays
 Style/WordArray:
   Enabled: false
-
-# Not all objects that handle #length also handle #empty?
-Style/ZeroLengthPredicate:
-  Enabled: false
-
-inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,136 +1,100 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2019-02-27 08:50:25 +0100 using RuboCop version 0.65.0.
+# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
+# using RuboCop version 0.93.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-    - 'lib/alexandria/web_themes.rb'
-
-# Offense count: 1
-Lint/UriEscapeUnescape:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-
-# Offense count: 2
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
-
-# Offense count: 165
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 161
+  Max: 111
 
-# Offense count: 21
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 66
+  Max: 64
 
-# Offense count: 13
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 32
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 985
+  Max: 997
 
-# Offense count: 65
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 22
+  Max: 27
 
-# Offense count: 212
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 109
+  Max: 98
 
-# Offense count: 1
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 338
+  Max: 361
 
-# Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 62
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 23
+  Max: 27
 
-# Offense count: 8
 Naming/BinaryOperatorParameterName:
   Exclude:
-    - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/models/book.rb'
-    - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/multi_drag_treeview.rb'
 
-# Offense count: 13
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'Rakefile'
     - 'bin/alexandria'
     - 'lib/alexandria/export_library.rb'
-    - 'lib/alexandria/ui/dialogs/about_dialog.rb'
-
-# Offense count: 2
-# Configuration parameters: EnforcedStyleForLeadingUnderscores.
-# SupportedStylesForLeadingUnderscores: disallowed, required, optional
-Naming/MemoizedInstanceVariableName:
-  Exclude:
-    - 'lib/alexandria/logging.rb'
+    - 'lib/alexandria/ui/about_dialog.rb'
 
-# Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/smart_library_properties_dialog_base.rb'
     - 'lib/alexandria/web_themes.rb'
 
-# Offense count: 10
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
+RSpec/FilePath:
   Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/proxis.rb'
-    - 'lib/alexandria/book_providers/pseudomarc.rb'
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/callbacks.rb'
-    - 'lib/alexandria/ui/init.rb'
-    - 'util/rake/fileinstall.rb'
+    - 'spec/alexandria/ui/iconview_spec.rb'
+    - 'spec/alexandria/ui/sound_spec.rb'
+
+RSpec/MultipleExpectations:
+  Max: 7
 
-# Offense count: 8
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
+  Exclude:
+    - 'spec/alexandria/export_library_spec.rb'
+    - 'spec/alexandria/library_spec.rb'
+    - 'spec/alexandria/library_store_spec.rb'
+    - 'spec/alexandria/scanners/cue_cat_spec.rb'
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
-    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
-    - 'lib/alexandria/ui/icons.rb'
     - 'lib/alexandria/ui/init.rb'
+    - 'lib/alexandria/ui/provider_preferences_base_dialog.rb'
 
-# Offense count: 17
 Style/ClassVars:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
@@ -138,101 +102,34 @@ Style/ClassVars:
     - 'lib/alexandria/logging.rb'
     - 'lib/alexandria/models/library.rb'
     - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
-
-# Offense count: 11
-Style/CommentedKeyword:
-  Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
-    - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
-    - 'util/rake/fileinstall.rb'
+    - 'lib/alexandria/ui/acquire_dialog.rb'
+    - 'lib/alexandria/ui/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 112
 Style/Documentation:
   Enabled: false
 
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: each, for
-Style/For:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/douban.rb'
-    - 'lib/alexandria/book_providers/renaud.rb'
-    - 'spec/alexandria/library_spec.rb'
-
-# Offense count: 65
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/ui/callbacks.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/keep_bad_isbn_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/misc_dialogs.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog_manual.rb'
-    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog.rb'
+    - 'lib/alexandria/ui/acquire_dialog.rb'
     - 'lib/alexandria/ui/dndable.rb'
     - 'lib/alexandria/ui/listview.rb'
-    - 'lib/alexandria/ui/sidepane.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
-
-# Offense count: 34
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Offense count: 2
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'lib/alexandria/book_providers/amazon_aws.rb'
+    - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 1
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/alexandria/preferences.rb'
-
-# Offense count: 2
-Style/MissingRespondToMissing:
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/preferences.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: Whitelist.
-# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'spec/alexandria/library_spec.rb'
-    - 'spec/alexandria/library_store_spec.rb'
-
-# Offense count: 21
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/alexandria/book_providers/adlibris.rb'
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/book_providers/douban.rb'
-    - 'lib/alexandria/book_providers/proxis.rb'
-    - 'lib/alexandria/book_providers/pseudomarc.rb'
-    - 'lib/alexandria/book_providers/renaud.rb'
+    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
     - 'lib/alexandria/book_providers/siciliano.rb'
-    - 'lib/alexandria/book_providers/thalia.rb'
-    - 'lib/alexandria/library_store.rb'
-    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
-    - 'lib/alexandria/ui/sidepane.rb'
+    - 'lib/alexandria/book_providers/worldcat.rb'
+    - 'lib/alexandria/console.rb'
+    - 'lib/alexandria/execution_queue.rb'
+    - 'lib/alexandria/export_format.rb'
+    - 'lib/alexandria/library_sort_order.rb'
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
     - 'util/rake/fileinstall.rb'
-    - 'util/rake/gettextgenerate.rb'