alexandria-book-collection-manager 0.7.3 → 0.7.8

data/.simplecov

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 SimpleCov.start do
-  track_files 'lib/**/*.rb'
-  add_filter '/spec/'
+  add_group "Main", "lib"
+  add_group "Specs", "spec"
+  enable_coverage :branch
 end

data/CHANGELOG.md

@@ -1,5 +1,50 @@
 # Changelog
 
+## 0.7.8 / 2020-11-29
+
+* Fix ThaliaProvider
+* Avoid warnings for calendar popup
+* Make Rename menu item work
+* Fix crash when changing covers
+* Make alerts show alert details if available
+
+## 0.7.7 / 2020-11-15
+
+* Update Polish translation ([#88] by [Piotr Drąg][piotrdrag])
+* Fix hiding of progress bar of import dialog
+* Fix calendar popups in Smart Library and Book Properties dialogs
+* Fix crashes when activating Export and Import menu items
+
+## 0.7.6 / 2020-11-01
+
+* Make more strings translatable with help from rubocop-i18n
+* Code quality and testing infrastructure improvements
+* Update Polish translation ([#51] and [#64], by [Piotr Drąg][piotrdrag])
+* Update Dutch translation
+* Make several dialogs that stopped appearing appear again
+* Remove ability to enable and disable providers through a pop-up menu
+* Fix New Library functionality
+* Update dependencies on gtk3, gstreamer, and psych
+* Fix issues in preferences, smart library dialog, and book selection
+* Improve installation instructions
+* Improve README ([#83] by [Happy][HappyFacade])
+
+## 0.7.5 / 2020-05-11
+
+* Avoid crash when opening Import dialog
+* Avoid crash during export
+* Add support for Ruby 2.7
+* Drop support for Ruby 2.4
+* Remove broken Renaud provider
+
+## 0.7.4 / 2019-10-24
+
+* Drop support for Ruby 2.3
+* Avoid passing nil to Gtk method #visible=, which expects a boolean
+  ([#22], by [Joseph Haig][jrmhaig])
+* Update dependencies on gtk3 and gstreamer to 3.4.1
+* Fix WorldCat provider to use https
+
 ## 0.7.3 / 2019-02-27
 
 * Remove DeaStore provider since the site is no longer online
@@ -64,6 +109,15 @@
   Amazon's Product Advertising API. Thanks to Stephen McCamant for
   providing the patch.
 
-<!-- references -->
-
+<!-- contributors -->
+[jrmhaig]: https://github.com/jrmhaig
+[piotrdrag]: https://github.com/piotrdrag
+[HappyFacade]: https://github.com/HappyFacade
+
+<!-- issues and pull requests -->
+[#88]: https://github.com/mvz/alexandria-book-collection-manager/pull/88
+[#83]: https://github.com/mvz/alexandria-book-collection-manager/pull/83
+[#64]: https://github.com/mvz/alexandria-book-collection-manager/pull/64
+[#51]: https://github.com/mvz/alexandria-book-collection-manager/pull/51
+[#23]: https://github.com/mvz/alexandria-book-collection-manager/pull/23
 [#19]: https://github.com/mvz/alexandria-book-collection-manager/issues/19

data/Gemfile

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # The gem's dependencies are specified in the gemspec
 gemspec
 
 group :development, :test do
-  gem 'simplecov'
-  gem 'yard', '~> 0.9.5'
+  gem "pry"
+  gem "simplecov"
+  gem "yard", "~> 0.9.5"
 end

data/INSTALL.md

@@ -56,23 +56,35 @@ to merge translations into generated files (and to extract
 translatable string from xml files during development).
 
 Note that these files are pre-generated in tar.gz releases, so you'll
-only need them if you're building from the SVN version, or want to
+only need them if you're building from the Git version, or want to
 change the translations.
 
+For support of the Z38.50 protocol you will need the
+[`yaz`](http://www.indexdata.dk/yaz) package.
+
+Alexandria also uses the outdate gconf2 configuration storage system, so you'll
+need to install `gconf2`.
+
+On Debian/Ubuntu systems, you can install the needed dependencies by running
+
+```
+apt-get install gettext intltool libyaz-dev gconf2
+```
+
 ### Ruby/ZOOM and Yaz
 
-For Z39.50 support and and the *Library of Congress* and
-*British Library* book providers you will need
-[`ruby-zoom`](http://ruby-zoom.rubyforge.org), which in turn
-requires the non-Ruby package [`yaz`](http://www.indexdata.dk/yaz).
+For Z39.50 support and the *Library of Congress* and *British Library* book
+providers you will need [`ruby-zoom`](http://ruby-zoom.rubyforge.org), which in
+turn requires the non-Ruby package [`yaz`](http://www.indexdata.dk/yaz) (see
+Native Dependencies above).
 
-Note that if you install the recent Ruby/ZOOM as the `zoom` gem, you
-will also need to install the `marc` gem. (Older implementations of
-ruby-zoom contained their own implementation of MARC.)
+Note that if you install the recent Ruby/ZOOM as the `zoom` gem, you will also
+need to install the `marc` gem. (Older implementations of ruby-zoom contained
+their own implementation of MARC.)
 
-The Z39.50 Object-Orientation Model (ZOOM) is an international
-standard for communication between computer systems, particularly
-libraries and information-related systems.
+The Z39.50 Object-Orientation Model (ZOOM) is an international standard for
+communication between computer systems, particularly libraries and
+information-related systems.
 
 ### image_size
 

data/README.md

@@ -4,7 +4,7 @@ Alexandria is a GNOME application for managing collections of books.
 
 Alexandria is written in Ruby, and is free software, distributed under
 the terms of the GNU General Public License, version 2 or later. See
-the file COPYING for more information.
+the file [COPYING](COPYING) for more information.
 
 What is Alexandria?
 ===================
@@ -39,49 +39,50 @@ Alexandria is a simple program designed to allow individuals to keep a
 catalogue of their book collection. In addition, it enables users to
 keep track of books which are on loan.
 
-    * retrieves and displays book information (sometimes with cover
-      pictures) from several online libraries and bookshops, such as
-          o Amazon
-          o Proxis
-          o AdLibris
-          o Spanish Ministry of Culture
-          o Livraria Siciliano
-          o WorldCat
-          o US Library of Congress
-          o British Library
-    * allows books to be added and updated by hand
-    * enables searches either by ISBN, title, author or keyword
-    * supports the Z39.50 standard and allow you to manage your own
-      sources (e.g. university libraries)
-    * saves data using the plain-text YAML format
-    * can import and export data into ONIX, Tellico, ISBN-list
-      and GoodReads CSV formats
-    * can export XHTML web pages of your libraries, themable with CSS
-    * allows marking your books as loaned, each with the loan-date and
-      the name of the person who has borrowed them
-    * features a HIG-compliant user interface
-    * shows books in different views (standard list or icons list),
-      that can be filtered and/or sorted
-    * handles book rating and notes
-    * supports CueCat and standard "keyboard wedge" barcode readers
-    * includes translations for several languages
-    * is documented in a complete manual (at the moment only in
-      English and Japanese)
-
-Alexandria is not without problems. See doc/BUGS for a summary of issues.
+* retrieves and displays book information (sometimes with cover
+  pictures) from several online libraries and bookshops, such as
+   - Amazon
+   - Proxis
+   - AdLibris
+   - Spanish Ministry of Culture
+   - Livraria Siciliano
+   - WorldCat
+   - US Library of Congress
+   - British Library
+* allows books to be added and updated by hand
+* enables searches either by ISBN, title, author or keyword
+* supports the Z39.50 standard and allow you to manage your own
+  sources (e.g. university libraries)
+* saves data using the plain-text YAML format
+* can import and export data into ONIX, Tellico, ISBN-list
+  and GoodReads CSV formats
+* can export XHTML web pages of your libraries, themable with CSS
+* allows marking your books as loaned, each with the loan-date and
+  the name of the person who has borrowed them
+* features a HIG-compliant user interface
+* shows books in different views (standard list or icons list),
+  that can be filtered and/or sorted
+* handles book rating and notes
+* supports CueCat and standard "keyboard wedge" barcode readers
+* includes translations for several languages
+* is documented in a complete manual (at the moment only in
+  English and Japanese)
+
+Alexandria is not without problems. See [doc/BUGS](doc/BUGS) for a
+summary of issues.
 
 ## Installation
 
 There are full instructions for installing Alexandria from source in the
-file INSTALL, including information about all the dependencies.
+file [INSTALL](INSTALL), including information about all the dependencies.
 
 If you are installing on a Debian-based system, things should be
 easier as the dependencies can be handled automatically.
 
 To run the program, just type
-    alexandria
+    `alexandria`
 or, to get verbose debugging information,
-    alexandria --debug
+    `alexandria --debug`
 
 If you are running GNOME, Alexandria should appear under the
 'Applications > Office' menu.
@@ -99,6 +100,7 @@ The following people have contributed to Alexandria over the years:
 * Constantine Evans <cevans@costinet.org>
 * Dafydd Harries <daf@muse.19inch.net>
 * Javier Fernandez-Sanguino Pena <jfs@debian.org>
+* Joseph Haig <josephhaig@gmail.com>
 * Joseph Method <tristil@gmail.com>
 * Kevin Schultz <schultkl@ieee.org>
 * Laurent Sansonetti <lrz@gnome.org>
@@ -119,6 +121,11 @@ The following people have contributed to Alexandria over the years:
 * Cathal Mc Ginley <cathal.alexandria@gnostai.org>
 * Liam Davison <registrations@liamjdavison.info>
 
+### Artists
+
+* Andreas Nilsson <nisses.mail@home.se>
+* Stefanie Dijoux <stefanie.dijoux@gmail.com>
+
 ### Translators
 
 * Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)
@@ -140,20 +147,24 @@ The following people have contributed to Alexandria over the years:
 * Piotr Drąg <piotrdrag@gmail.com> (pl)
 * Serhij Dubyk <dubyk@library.lviv.ua> (uk)
 
-### Artists
-
-* Andreas Nilsson <nisses.mail@home.se>
-* Stefanie Dijoux <stefanie.dijoux@gmail.com>
+### Former translators
+* David Weinehall <tao@debian.org> (sv)
+* Jiří Pejchal <jiri.pejchal@gmail.com> (cs)
+* Laurent Sansonetti <lrz@gnome.org> (fr)
+* Lucas Rocha <lucasr@im.ufba.br> (pt_BR)
+* Marco Costantini <costanti@science.unitn.it> (it)
+* Masao Mutoh <mutoh@highway.ne.jp> (ja)
+* Mirko Maischberger <mirko@lilik.it> (it)
 
 ## License
 
 Unless otherwise noted, the following license applies to all files that are
 part of Alexandria:
 
-Copyright (C) 2004-2006 Laurent Sansonetti
-Copyright (C) 2007-2010,2014-2018 Alexandria Contributors
+Copyright (C) 2004 Laurent Sansonetti
+Copyright (C) 2005-2010,2014-2020 Alexandria Contributors
 
 Alexandria is free software; you can redistribute it and/or modify it under the
 terms of the GNU General Public License as published by the Free Software
 Foundation; either version 2 of the License, or (at your option) any later
-version. See the file COPYING for details.
+version. See the file [COPYING](COPYING) for details.

data/Rakefile

@@ -4,55 +4,55 @@
 #
 # See the file README.md for authorship and licensing information.
 
-load 'tasks/setup.rb'
+load "tasks/setup.rb"
 
-require 'rake/packagetask'
+require "rake/packagetask"
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), 'util/rake'))
-require 'fileinstall'
-require 'gettextgenerate'
-require 'omfgenerate'
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "util/rake"))
+require "fileinstall"
+require "gettextgenerate"
+require "omfgenerate"
 
-require_relative 'lib/alexandria/version'
+require_relative "lib/alexandria/version"
 
-stage_dir = ENV['DESTDIR'] || 'tmp'
-prefix_dir = ENV['PREFIX'] || '/usr'
+stage_dir = ENV["DESTDIR"] || "tmp"
+prefix_dir = ENV["PREFIX"] || "/usr"
 
-PROJECT = 'alexandria'
+PROJECT = "alexandria"
 PREFIX = prefix_dir
-share_dir = ENV['SHARE'] || "#{PREFIX}/share"
+share_dir = ENV["SHARE"] || "#{PREFIX}/share"
 SHARE = share_dir
 
 GettextGenerateTask.new(PROJECT) do |g|
-  g.generate_po_files('po', 'po/*.po', 'share/locale')
-  g.generate_desktop('alexandria.desktop.in', 'alexandria.desktop')
+  g.generate_po_files("po", "po/*.po", "share/locale")
+  g.generate_desktop("alexandria.desktop.in", "alexandria.desktop")
 end
 
 OmfGenerateTask.new(PROJECT) do |o|
   o.gnome_helpfiles_dir = "#{SHARE}/gnome/help"
-  o.generate_omf('data/omf/alexandria', 'share/omf/alexandria/*.in')
+  o.generate_omf("data/omf/alexandria", "share/omf/alexandria/*.in")
 end
 
-SHARE_FILE_GLOBS = ['data/alexandria/**/*', 'data/gnome/**/*.*',
-                    'data/locale/**/*.mo', 'data/omf/**/*.omf',
-                    'data/sounds/**/*.ogg'].freeze # , 'data/menu/*']
+SHARE_FILE_GLOBS = ["data/alexandria/**/*", "data/gnome/**/*.*",
+                    "data/locale/**/*.mo", "data/omf/**/*.omf",
+                    "data/sounds/**/*.ogg"].freeze # , 'data/menu/*']
 
-ICON_FILE_GLOBS = ['data/app-icon/**/*.png',
-                   'data/app-icon/scalable/*.svg'].freeze
+ICON_FILE_GLOBS = ["data/app-icon/**/*.png",
+                   "data/app-icon/scalable/*.svg"].freeze
 
-PIXMAP_GLOBS = 'data/app-icon/32x32/*.xpm'
+PIXMAP_GLOBS = "data/app-icon/32x32/*.xpm"
 
 def install_common(install_task)
-  install_task.install_exe('bin', 'bin/*', "#{PREFIX}/bin")
-  install_task.install('lib', 'lib/**/*.rb', install_task.rubylib)
+  install_task.install_exe("bin", "bin/*", "#{PREFIX}/bin")
+  install_task.install("lib", "lib/**/*.rb", install_task.rubylib)
 
-  install_task.install('data', SHARE_FILE_GLOBS, SHARE)
+  install_task.install("data", SHARE_FILE_GLOBS, SHARE)
   install_task.install_icons(ICON_FILE_GLOBS, "#{SHARE}/icons")
-  install_task.install('data/app-icon/32x32', PIXMAP_GLOBS, "#{SHARE}/pixmaps")
+  install_task.install("data/app-icon/32x32", PIXMAP_GLOBS, "#{SHARE}/pixmaps")
 
-  install_task.install('', 'schemas/alexandria.schemas', "#{SHARE}/gconf")
-  install_task.install('', 'alexandria.desktop', "#{SHARE}/applications")
-  install_task.install('doc', 'doc/alexandria.1', "#{SHARE}/man/man1")
+  install_task.install("", "schemas/alexandria.schemas", "#{SHARE}/gconf")
+  install_task.install("", "alexandria.desktop", "#{SHARE}/applications")
+  install_task.install("doc", "doc/alexandria.1", "#{SHARE}/man/man1")
 end
 
 FileInstallTask.new(:package_staging, stage_dir, true) do |i|
@@ -65,10 +65,10 @@ FileInstallTask.new(:package) do |j|
   install_common(j)
 
   docs = %w(README.rdoc CHANGELOG.md INSTALL.md COPYING TODO.md)
-  devel_docs = ['doc/AUTHORS', 'doc/BUGS', 'doc/FAQ',
-                'doc/cuecat_support.rdoc']
-  j.install('', docs, "#{SHARE}/doc/#{PROJECT}")
-  j.install('doc', devel_docs, "#{SHARE}/doc/#{PROJECT}")
+  devel_docs = ["doc/AUTHORS", "doc/BUGS", "doc/FAQ",
+                "doc/cuecat_support.rdoc"]
+  j.install("", docs, "#{SHARE}/doc/#{PROJECT}")
+  j.install("doc", devel_docs, "#{SHARE}/doc/#{PROJECT}")
 
   j.uninstall_empty_dirs(["#{SHARE}/**/#{PROJECT}/",
                           "#{j.rubylib}/#{PROJECT}/"])
@@ -83,14 +83,14 @@ end
 def autogen_comment
   lines = [
     "This file is automatically generated by the #{PROJECT} installer.",
-    'Do not edit it directly.'
+    "Do not edit it directly."
   ]
   result = lines.map { |line| "# #{line}" }
   result.join("\n") + "\n\n"
 end
 
 def generate(filename)
-  File.open(filename, 'w') do |file|
+  File.open(filename, "w") do |file|
     puts "Generating #{filename}"
     file.print autogen_comment
     file_contents = yield
@@ -101,55 +101,57 @@ end
 # generate default_preferences.rb
 def convert_with_type(value, type)
   case type
-  when 'int'
+  when "int"
     value.to_i
-  when 'float'
+  when "float"
     value.to_f
-  when 'bool'
-    value == 'true'
+  when "bool"
+    value == "true"
+  when "string"
+    value.to_s.strip
   else
-    value.strip
+    raise NotImplementedError, "Unknown type #{type}"
   end
 end
 
-SCHEMA_PATH = 'schemas/alexandria.schemas'
+SCHEMA_PATH = "schemas/alexandria.schemas"
 
 # This generates default_preferences.rb by copying over values from
 # providers_priority key in alexandria.schemas (necessary?)
 
-file 'lib/alexandria/default_preferences.rb' => [SCHEMA_PATH] do |f|
-  require 'rexml/document'
+file "lib/alexandria/default_preferences.rb" => ["Rakefile", SCHEMA_PATH] do |f|
+  require "rexml/document"
   generated_lines = []
 
   doc = REXML::Document.new(IO.read(SCHEMA_PATH))
-  doc.elements.each('gconfschemafile/schemalist/schema') do |element|
-    default = element.elements['default'].text
-    next unless default
+  doc.elements.each("gconfschemafile/schemalist/schema") do |element|
+    default = element.elements["default"].text
 
-    varname = File.basename(element.elements['key'].text)
-    type = element.elements['type'].text
+    varname = File.basename(element.elements["key"].text)
+    type = element.elements["type"].text
 
-    if (type == 'list') || (type == 'pair')
-      ary = default[1..-2].split(',')
+    if (type == "list") || (type == "pair")
+      ary = default[1..-2].split(",")
       next if ary.empty?
 
-      if type == 'list'
-        list_type = element.elements['list_type'].text
+      case type
+      when "list"
+        list_type = element.elements["list_type"].text
         ary.map! { |x| convert_with_type(x, list_type) }
-      elsif type == 'pair'
+      when "pair"
         next if ary.length != 2
 
         ary[0] = convert_with_type(ary[0],
-                                   element.elements['car_type'].text)
+                                   element.elements["car_type"].text)
         ary[1] = convert_with_type(ary[1],
-                                   element.elements['cdr_type'].text)
+                                   element.elements["cdr_type"].text)
       end
       default = ary.inspect
     else
       default = convert_with_type(default, type).inspect.to_s
     end
 
-    generated_lines << varname.inspect + ' => ' + default
+    generated_lines << varname.inspect + " => " + default
   end
 
   generate(f.name) do
@@ -165,10 +167,9 @@ file 'lib/alexandria/default_preferences.rb' => [SCHEMA_PATH] do |f|
   end
 end
 
-autogenerated_files = ['lib/alexandria/config.rb',
-                       'lib/alexandria/default_preferences.rb']
+autogenerated_files = ["lib/alexandria/default_preferences.rb"]
 
-desc 'Generate ruby files needed for the installation'
+desc "Generate ruby files needed for the installation"
 task autogen: autogenerated_files
 
 task :autogen_clobber do |_t|
@@ -197,13 +198,13 @@ end
 
 Rake::PackageTask.new(PROJECT, Alexandria::DISPLAY_VERSION) do |p|
   p.need_tar_gz = true
-  p.package_files.include('README.md', 'COPYING', 'CHANGELOG.md', 'INSTALL.md',
-                          'Rakefile', 'util/**/*',
-                          'TODO.md', 'alexandria.desktop',
-                          'alexandria.desktop.in',
-                          'bin/**/*', 'data/**/*', 'misc/**/*',
-                          'doc/**/*', 'lib/**/*', 'po/**/*',
-                          'schemas/**/*', 'spec/**/*')
+  p.package_files.include("README.md", "COPYING", "CHANGELOG.md", "INSTALL.md",
+                          "Rakefile", "util/**/*",
+                          "TODO.md", "alexandria.desktop",
+                          "alexandria.desktop.in",
+                          "bin/**/*", "data/**/*", "misc/**/*",
+                          "doc/**/*", "lib/**/*", "po/**/*",
+                          "schemas/**/*", "spec/**/*")
 end
 
 task tgz: [:build] do
@@ -214,35 +215,37 @@ end
 
 task pre_install: [:build]
 task :scrollkeeper do
-  unless system('which scrollkeeper-update')
-    raise 'scrollkeeper-update cannot be found, is Scrollkeeper correctly installed?'
+  unless system("which scrollkeeper-update")
+    raise "scrollkeeper-update cannot be found, is Scrollkeeper correctly installed?"
   end
 
-  system('scrollkeeper-update -q') || raise('Scrollkeeper update failed')
+  system("scrollkeeper-update -q") || raise("Scrollkeeper update failed")
 end
 
 task :gconf do
-  return if ENV['GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL']
+  return if ENV["GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL"]
 
-  raise 'gconftool-2 cannot be found, is GConf2 correctly installed?' unless system('which gconftool-2')
+  unless system("which gconftool-2")
+    raise "gconftool-2 cannot be found, is GConf2 correctly installed?"
+  end
 
-  ENV['GCONF_CONFIG_SOURCE'] = `gconftool-2 --get-default-source`.chomp
-  Dir['schemas/*.schemas'].each do |schema|
+  ENV["GCONF_CONFIG_SOURCE"] = `gconftool-2 --get-default-source`.chomp
+  Dir["schemas/*.schemas"].each do |schema|
     system("gconftool-2 --makefile-install-rule '#{schema}'")
   end
   # system("killall -HUP gconfd-2")
 end
 
 task :update_icon_cache do
-  system('gtk-update-icon-cache -f -t /usr/share/icons/hicolor') # HACK
+  system("gtk-update-icon-cache -f -t /usr/share/icons/hicolor") # HACK
 end
 
 task post_install: [:scrollkeeper, :gconf, :update_icon_cache]
 
-desc 'Install Alexandria'
+desc "Install Alexandria"
 task install: [:pre_install, :install_package, :post_install]
 
-desc 'Uninstall Alexandria'
+desc "Uninstall Alexandria"
 task uninstall: [:uninstall_package] # TODO: gconf etc...
 
-task default: [:spec, :dogtail]
+task default: [:spec]