alexandria-book-collection-manager 0.7.3 → 0.7.8

data/lib/alexandria/ui/provider_preferences_base_dialog.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+class Gtk::Entry
+  attr_writer :mandatory
+
+  def mandatory?
+    @mandatory
+  end
+end
+
+module Alexandria
+  module UI
+    class ProviderPreferencesBaseDialog
+      attr_reader :dialog
+
+      def initialize(title:, parent:, flags:, buttons:)
+        @dialog = Gtk::Dialog.new(title: title, parent: parent, flags: flags,
+                                 buttons: buttons)
+
+        @dialog.resizable = false
+        @dialog.child.border_width = 12
+
+        @controls = []
+      end
+
+      private
+
+      def fill_table(table, provider)
+        i = table.n_rows
+        table.resize(table.n_rows + provider.prefs.length,
+                     table.n_columns)
+        table.border_width = 12
+        table.row_spacings = 6
+        table.column_spacings = 12
+
+        @controls.clear
+
+        provider.prefs.read.each do |variable|
+          if variable.name == "piggyback"
+            next
+            # ULTRA-HACK!! for bug #13302
+            # not displaying the visual choice, as its usually unnecessary
+            # Either way, this is confusing to the user: FIX
+            #    -   Cathal Mc Ginley 2008-02-18
+          end
+
+          if variable.name == "enabled"
+            # also don't display Enabled/Disabled
+            next
+          end
+
+          label = Gtk::Label.new("_" + variable.description + ":")
+          label.use_underline = true
+          label.xalign = 0
+          table.attach_defaults(label, 0, 1, i, i + 1)
+
+          if variable.possible_values.nil?
+            entry = Gtk::Entry.new
+            entry.text = variable.value.to_s
+            entry.mandatory = variable.mandatory?
+          else
+            entry = Gtk::ComboBoxText.new
+            variable.possible_values.each do |value|
+              entry.append_text(value.to_s)
+            end
+            index = variable.possible_values.index(variable.value)
+            entry.active = index
+          end
+          label.mnemonic_widget = entry
+
+          @controls << [variable, entry]
+
+          table.attach_defaults(entry, 1, 2, i, i + 1)
+          i += 1
+        end
+        table
+      end
+
+      def sync_variables
+        @controls.each do |variable, entry|
+          variable.new_value = case entry
+                               when Gtk::ComboBox
+                                 variable.possible_values[entry.active]
+                               when Gtk::Entry
+                                 entry.text
+                               end
+        end
+      end
+    end
+  end
+end

data/lib/alexandria/ui/provider_preferences_dialog.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "alexandria/ui/provider_preferences_base_dialog"
+
+module Alexandria
+  module UI
+    class ProviderPreferencesDialog < ProviderPreferencesBaseDialog
+      include GetText
+      GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
+
+      def initialize(parent, provider)
+        super(title: _("Preferences for %s") % provider.fullname,
+              parent: parent,
+              flags: :modal,
+              buttons: [[Gtk::Stock::CLOSE, :close]])
+
+        table = Gtk::Table.new(0, 0)
+        fill_table(table, provider)
+        dialog.child.pack_start(table)
+
+        dialog.signal_connect("destroy") { sync_variables }
+      end
+
+      def acquire
+        dialog.show_all
+        dialog.run
+        dialog.destroy
+      end
+    end
+  end
+end

data/lib/alexandria/ui/{dialogs/misc_dialogs.rb → really_delete_dialog.rb}

@@ -4,34 +4,13 @@
 #
 # See the file README.md for authorship and licensing information.
 
+require "alexandria/ui/alert_dialog"
+
 module Alexandria
   module UI
-    class ConflictWhileCopyingDialog < AlertDialog
-      include GetText
-      GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
-
-      def initialize(parent, library, book)
-        super(parent,
-              format(_("The book '%s' already exists in '%s'. Would you like " \
-                'to replace it?'), book.title, library.name),
-              Gtk::Stock::DIALOG_QUESTION,
-              [[_('_Skip'), Gtk::ResponseType::CANCEL],
-               [_('_Replace'), Gtk::ResponseType::OK]],
-              _('If you replace the existing book, its contents will ' \
-                'be overwritten.'))
-        self.default_response = Gtk::ResponseType::CANCEL
-      end
-
-      def replace?
-        show_all && (@response = run)
-        destroy
-        @response == Gtk::ResponseType::OK
-      end
-    end
-
     class ReallyDeleteDialog < AlertDialog
       include GetText
-      GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
+      GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
 
       def initialize(parent, library, books = nil)
         # Deleting a library.
@@ -40,8 +19,8 @@ module Alexandria
           description = if library.is_a?(SmartLibrary) || library.empty?
                           nil
                         else
-                          n_('If you continue, %d book will be deleted.',
-                             'If you continue, %d books will be deleted.',
+                          n_("If you continue, %d book will be deleted.",
+                             "If you continue, %d books will be deleted.",
                              library.size) % library.size
                         end
           # Deleting books.
@@ -50,7 +29,7 @@ module Alexandria
                       format(_("Are you sure you want to delete '%s' " \
                         "from '%s'?"), books.first.title, library.name)
                     else
-                      _('Are you sure you want to delete the ' \
+                      _("Are you sure you want to delete the " \
                         "selected books from '%s'?") % library.name
                     end
           description = nil
@@ -61,7 +40,7 @@ module Alexandria
                [Gtk::Stock::DELETE, Gtk::ResponseType::OK]],
               description)
 
-        self.default_response = Gtk::ResponseType::CANCEL
+        dialog.default_response = Gtk::ResponseType::CANCEL
       end
 
       def ok?

data/lib/alexandria/ui/{sidepane.rb → sidepane_manager.rb}

@@ -4,12 +4,15 @@
 #
 # See the file README.md for authorship and licensing information.
 
+require "alexandria/ui/error_dialog"
+
 module Alexandria
   module UI
-    class SidePaneManager
+    class SidepaneManager
       include Logging
       include GetText
       attr_accessor :library_listview
+
       def initialize(library_listview, parent)
         @library_listview = library_listview
         @parent = parent
@@ -29,13 +32,12 @@ module Alexandria
       # if new_text contains disallowed char (/ or initial .), returns a MatchData object
       # otherwise returns nil
       def contains_illegal_character(new_text)
-        new_text.unpack('U*') # attempt to unpack as UTF-8 characters
-        match = /(^\.|\/)/.match(new_text)
+        new_text.unpack("U*") # attempt to unpack as UTF-8 characters
         # forbid / character (since Library names become dir names)
         # also no initial . since that hides the Library (hidden file)
         #      forbidding an initial dot also disallows "." and ".."
         #      which are of course pre-existing directories.
-        match
+        %r{(^\.|/)}.match(new_text)
       rescue StandardError => ex
         log.warn { "New library name not valid UTF-8: #{ex.message}" }
         true
@@ -44,42 +46,40 @@ module Alexandria
 
       def on_edited_library(cell, path_string, new_text)
         log.debug { "edited library name #{new_text}" }
-        ## new_text = new_text.reverse # for testing;
-        # a great way to generate broken UTF-8
-        if cell.text != new_text
-          if (match = contains_illegal_character(new_text))
-            if match.instance_of? MatchData
-              chars = match[1].gsub(/&/, '&')
-              ErrorDialog.new(@main_app, _("Invalid library name '%s'") % new_text,
-                              _('The name provided contains the ' \
-                                'disallowed character <b>%s</b> ') % chars).display
-            else
-              ErrorDialog.new(@main_app, _('Invalid library name'),
-                              _('The name provided contains ' \
-                                'invalid characters.')).display
-            end
-
-          elsif new_text.strip.empty?
-            log.debug { 'Empty text' }
-            ErrorDialog.new(@main_app, _('The library name ' \
-                                         'can not be empty')).display
-          elsif library_already_exists new_text
-            log.debug { 'Already exists' }
-            ErrorDialog.new(@main_app,
-                            _('The library can not be renamed'),
-                            _('There is already a library named ' \
-                              "'%s'.  Please choose a different " \
-                              'name.') % new_text.strip).display
+        return if cell.text == new_text
+
+        if (match = contains_illegal_character(new_text))
+          if match.instance_of? MatchData
+            chars = match[1].gsub(/&/, "&amp;")
+            ErrorDialog.new(@main_app, _("Invalid library name '%s'") % new_text,
+                            _("The name provided contains the " \
+                              "disallowed character <b>%s</b>") % chars).display
           else
-            log.debug { "Attempting to apply #{path_string}, #{new_text}" }
-            path = Gtk::TreePath.new(path_string)
-            iter = @library_listview.model.get_iter(path)
-            library_name = new_text.strip
-            log.info { "library name is #{library_name}" }
-            iter[1] = @parent.selected_library.name = library_name
-            @parent.setup_move_actions
-            @parent.refresh_libraries
+            ErrorDialog.new(@main_app, _("Invalid library name"),
+                            _("The name provided contains " \
+                              "invalid characters.")).display
           end
+
+        elsif new_text.strip.empty?
+          log.debug { "Empty text" }
+          ErrorDialog.new(@main_app, _("The library name " \
+                                       "can not be empty")).display
+        elsif library_already_exists new_text
+          log.debug { "Already exists" }
+          ErrorDialog.new(@main_app,
+                          _("The library can not be renamed"),
+                          _("There is already a library named " \
+                            "'%s'.  Please choose a different " \
+                            "name.") % new_text.strip).display
+        else
+          log.debug { "Attempting to apply #{path_string}, #{new_text}" }
+          path = Gtk::TreePath.new(path_string)
+          iter = @library_listview.model.get_iter(path)
+          library_name = new_text.strip
+          log.info { "library name is #{library_name}" }
+          iter[1] = @parent.selected_library.name = library_name
+          @parent.setup_move_actions
+          @parent.refresh_libraries
         end
       end
 
@@ -93,7 +93,7 @@ module Alexandria
         @libraries.all_smart_libraries.each { |x| @parent.append_library(x) }
 
         renderer = Gtk::CellRendererPixbuf.new
-        column = Gtk::TreeViewColumn.new(_('Library'))
+        column = Gtk::TreeViewColumn.new(_("Library"))
         column.pack_start(renderer, false)
         column.set_cell_data_func(renderer) do |_col, cell, _model, iter|
           # log.debug { "sidepane: cell_data_func #{col}, #{cell}, #{iter}" }
@@ -108,7 +108,9 @@ module Alexandria
           cell.editable = iter[2]
           # log.debug { "exit sidepane: editable #{cell}, #{iter}" }
         end
-        renderer.signal_connect('edited', &method(:on_edited_library))
+        renderer.signal_connect("edited") do |cell, path_string, new_text|
+          on_edited_library(cell, path_string, new_text)
+        end
         @library_listview.append_column(column)
 
         @library_listview.set_row_separator_func do |model, iter|
@@ -116,16 +118,17 @@ module Alexandria
           model.get_value(iter, 3)
         end
 
-        @library_listview.selection.signal_connect('changed') do
-          log.debug { 'changed' }
+        @library_listview.selection.signal_connect("changed") do
+          log.debug { "changed" }
           @parent.refresh_libraries
           @parent.refresh_books
         end
 
         @library_listview.enable_model_drag_dest(BOOKS_TARGET_TABLE, :move)
 
-        @library_listview.signal_connect('drag-motion') do |_widget, drag_context, x, y, time, _data|
-          log.debug { 'drag-motion' }
+        @library_listview
+          .signal_connect("drag-motion") do |_widget, drag_context, x, y, time, _data|
+          log.debug { "drag-motion" }
 
           path, column, =
             @library_listview.get_path_at_pos(x, y)
@@ -154,8 +157,9 @@ module Alexandria
                           time)
         end
 
-        @library_listview.signal_connect('drag-drop') do |widget, drag_context, _x, _y, time, _data|
-          log.debug { 'drag-drop' }
+        @library_listview
+          .signal_connect("drag-drop") do |widget, drag_context, _x, _y, time, _data|
+          log.debug { "drag-drop" }
 
           widget.drag_get_data(drag_context,
                                drag_context.targets.first,
@@ -163,8 +167,9 @@ module Alexandria
           true
         end
 
-        @library_listview.signal_connect('drag-data-received') do |_, drag_context, x, y, data, _, _|
-          log.debug { 'drag-data-received' }
+        @library_listview
+          .signal_connect("drag-data-received") do |_, drag_context, x, y, data, _, _|
+          log.debug { "drag-data-received" }
 
           success = false
           # FIXME: Ruby-GNOME2 should make comparison work without needing to

data/lib/alexandria/ui/skip_entry_dialog.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+require "alexandria/ui/alert_dialog"
+
+module Alexandria
+  module UI
+    class SkipEntryDialog < AlertDialog
+      include GetText
+      include Logging
+      GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
+
+      def initialize(parent, message)
+        super(parent, _("Error while importing"),
+              Gtk::Stock::DIALOG_QUESTION,
+              [[Gtk::Stock::CANCEL, Gtk::ResponseType::CANCEL],
+               [_("_Continue"), Gtk::ResponseType::OK]],
+              message)
+        log.debug { "Opened SkipEntryDialog #{inspect}" }
+        dialog.default_response = Gtk::ResponseType::CANCEL
+      end
+
+      def continue?
+        show_all && (@response = run)
+        destroy
+        @response == Gtk::ResponseType::OK
+      end
+    end
+  end
+end

data/lib/alexandria/ui/smart_library_properties_dialog.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+module Alexandria
+  module UI
+    class SmartLibraryPropertiesDialog < SmartLibraryPropertiesDialogBase
+      include GetText
+      GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
+
+      def initialize(parent, smart_library)
+        super(parent)
+
+        @smart_library = smart_library
+
+        dialog.add_buttons([Gtk::Stock::CANCEL, :cancel],
+                           [Gtk::Stock::SAVE, :ok])
+
+        dialog.title = _("Properties for '%s'") % @smart_library.name
+        # FIXME: Should accept just :cancel
+        dialog.default_response = Gtk::ResponseType::CANCEL
+        @smart_library.rules.each { |x| insert_new_rule(x) }
+        update_rules_header_box(@smart_library.predicate_operator_rule)
+      end
+
+      def acquire
+        dialog.show_all
+
+        while (response = dialog.run) != Gtk::ResponseType::CANCEL
+          case response
+          when Gtk::ResponseType::HELP
+            handle_help_response
+          when Gtk::ResponseType::OK
+            break if handle_ok_response
+          end
+        end
+
+        dialog.destroy
+      end
+
+      private
+
+      def handle_ok_response
+        user_confirms_possible_weirdnesses_before_saving? or return
+
+        @smart_library.rules = smart_library_rules
+        @smart_library.predicate_operator_rule =
+          predicate_operator_rule
+        @smart_library.save
+        true
+      end
+
+      def handle_help_response
+        Alexandria::UI.display_help(self, "edit-smart-library")
+      end
+    end
+  end
+end