alchemy_cms 3.2.1 → 3.3.0.rc1

data/spec/requests/alchemy/admin/site_requests_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+RSpec.describe 'Site requests' do
+  before do
+    authorize_user(:as_admin)
+  end
+
+  context 'a site with host' do
+    let!(:site) { create(:alchemy_site, :public, host: 'alchemy-cms.com') }
+    let(:another_site) { Alchemy::Site.default }
+
+    context 'in params' do
+      it 'loads dashboard of another site by id' do
+        get "http://#{site.host}/admin/dashboard?site_id=#{another_site.id}"
+        expect(assigns(:current_alchemy_site).id).to eq(another_site.id)
+      end
+    end
+  end
+end

data/spec/requests/alchemy/site_requests_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+RSpec.describe 'Site requests' do
+  context 'a site with host' do
+    let!(:site) { create(:alchemy_site, :public, host: 'alchemy-cms.com') }
+
+    let(:page) do
+      Alchemy::Site.current = site
+      root = create(:alchemy_page, :language_root, language: site.languages.last)
+      create(:alchemy_page, :public, parent: root)
+    end
+
+    it 'loads this site by host' do
+      get "http://#{site.host}/#{page.urlname}"
+      expect(assigns(:current_alchemy_site).host).to eq(site.host)
+    end
+  end
+end

data/spec/requests/alchemy/sitemap_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+RSpec.describe 'Requests for PagesController#sitemap' do
+  let!(:page) { create(:alchemy_page, :public, sitemap: true) }
+
+  it 'renders valid xml sitemap' do
+    get '/sitemap.xml'
+    expect(response.content_type).to eq(:xml)
+    xml_doc = Nokogiri::XML(response.body)
+    expect(xml_doc.namespaces).to have_key('xmlns')
+    expect(xml_doc.namespaces['xmlns']).to eq('http://www.sitemaps.org/schemas/sitemap/0.9')
+    expect(xml_doc.css('urlset url loc').length).to eq(2)
+  end
+
+  it 'lastmod dates are ISO 8601 timestamps' do
+    get '/sitemap.xml'
+    expect(response.content_type).to eq(:xml)
+    xml_doc = Nokogiri::XML(response.body)
+    xml_doc.css('urlset url lastmod').each do |timestamps|
+      expect(timestamps.text).to match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/)
+    end
+  end
+
+  context 'in multi language mode' do
+    let!(:root) { page.parent }
+    let!(:pages) { [root, page] }
+
+    before do
+      allow_any_instance_of(Alchemy::BaseController).to receive('prefix_locale?') { true }
+    end
+
+    it 'links in sitemap has locale code included' do
+      get '/sitemap.xml'
+      xml_doc = Nokogiri::XML(response.body)
+      xml_doc.css('urlset url').each_with_index do |node, i|
+        page = pages[i]
+        expect(node.css('loc').text).to match(/\/#{page.language_code}\//)
+      end
+    end
+
+    context 'if the default locale is the page locale' do
+      before do
+        allow_any_instance_of(Alchemy::BaseController).to receive('prefix_locale?') { false }
+      end
+
+      it 'links in sitemap has no locale code included' do
+        get '/sitemap.xml'
+        xml_doc = Nokogiri::XML(response.body)
+        xml_doc.css('urlset url').each_with_index do |node, i|
+          page = pages[i]
+          expect(node.css('loc').text).to_not match(/\/#{page.language_code}\//)
+        end
+      end
+    end
+  end
+end

data/spec/routing/api_routing_spec.rb

@@ -147,4 +147,4 @@ describe 'The API routes' do
       )
     end
   end
-end
+end

data/spec/routing/routing_spec.rb

@@ -3,6 +3,41 @@ require 'spec_helper'
 describe "The Routing" do
   routes { Alchemy::Engine.routes }
 
+  describe "root url" do
+    it "routes to pages_controller#index" do
+      expect({
+        get: "/"
+      }).to route_to(
+        controller: "alchemy/pages",
+        action: "index"
+      )
+    end
+
+    context 'with locale parameter' do
+      it 'routes to pages_controller#index' do
+        expect({
+          get: '/en'
+        }).to route_to(
+          controller: 'alchemy/pages',
+          action: 'index',
+          locale: 'en'
+        )
+      end
+
+      context 'that contains uppercase country code' do
+        it 'routes to pages_controller#index' do
+          expect({
+            get: '/en-UK'
+          }).to route_to(
+            controller: 'alchemy/pages',
+            action: 'index',
+            locale: 'en-UK'
+          )
+        end
+      end
+    end
+  end
+
   context "for downloads" do
     it "should have a named route" do
       expect({
@@ -123,9 +158,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped mask show action" do
-      expect(get(
-        "/pictures/3/show/300x300/crop/200x50/100x100/kitten.jpg"
-      )).to route_to(
+      expect(
+        get("/pictures/3/show/300x300/crop/200x50/100x100/kitten.jpg")
+      ).to route_to(
         controller: "alchemy/pictures",
         action: "show",
         id: "3",
@@ -139,9 +174,9 @@ describe "The Routing" do
     end
 
     it "should route to thumbnail action" do
-      expect(get(
-        "/pictures/3/thumbnails/small/kitten.jpg"
-      )).to route_to(
+      expect(
+        get("/pictures/3/thumbnails/small/kitten.jpg")
+      ).to route_to(
         controller: "alchemy/pictures",
         action: "thumbnail",
         id: "3",
@@ -152,9 +187,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped thumbnail action" do
-      expect(get(
-        "/pictures/3/thumbnails/small/crop/kitten.jpg"
-      )).to route_to(
+      expect(
+        get("/pictures/3/thumbnails/small/crop/kitten.jpg")
+      ).to route_to(
         controller: "alchemy/pictures",
         action: "thumbnail",
         id: "3",
@@ -166,9 +201,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped and masked thumbnail" do
-      expect(get(
-        "/pictures/3/thumbnails/small/0x0/200x200/kitten.jpg"
-      )).to route_to(
+      expect(
+        get("/pictures/3/thumbnails/small/0x0/200x200/kitten.jpg")
+      ).to route_to(
         controller: "alchemy/pictures",
         action: "thumbnail",
         id: "3",
@@ -181,9 +216,9 @@ describe "The Routing" do
     end
 
     it "should route to zoomed picture" do
-      expect(get(
-        "/pictures/3/zoom/kitten.jpg"
-      )).to route_to(
+      expect(
+        get("/pictures/3/zoom/kitten.jpg")
+      ).to route_to(
         controller: "alchemy/pictures",
         action: "zoom",
         id: "3",
@@ -201,6 +236,19 @@ describe "The Routing" do
     end
   end
 
+  describe "rss feed requests" do
+    it "should be handled by alchemy/pages controller" do
+      expect({
+        get: "/news.rss"
+      }).to route_to(
+        controller: "alchemy/pages",
+        action: "show",
+        urlname: "news",
+        format: "rss"
+      )
+    end
+  end
+
   describe "unknown formats" do
     it "should be handled by alchemy/pages controller" do
       expect({
@@ -231,4 +279,62 @@ describe "The Routing" do
       }).not_to be_routable
     end
   end
+
+  context "for admin interface" do
+    context "default" do
+      it "should route to admin dashboard" do
+        expect({
+          get: "/admin/dashboard"
+        }).to route_to(
+          controller: "alchemy/admin/dashboard",
+          action: "index"
+        )
+      end
+
+      it "should route to page preview" do
+        expect({
+          get: "/admin/pages/3/preview"
+        }).to route_to(
+          controller: "alchemy/admin/pages",
+          action: "preview",
+          id: "3"
+        )
+      end
+    end
+
+    context "customized" do
+      before(:all) do
+        Alchemy.admin_path = "/backend"
+        Alchemy.admin_constraints = {subdomain: "hidden"}
+        Rails.application.reload_routes!
+      end
+
+      it "should route to admin dashboard" do
+        expect({
+          get: "http://hidden.example.org/backend/dashboard"
+        }).to route_to(
+          controller: "alchemy/admin/dashboard",
+          action: "index",
+          subdomain: "hidden"
+        )
+      end
+
+      it "should route to page preview" do
+        expect({
+          get: "http://hidden.example.org/backend/pages/3/preview"
+        }).to route_to(
+          controller: "alchemy/admin/pages",
+          action: "preview",
+          id: "3",
+          subdomain: "hidden"
+        )
+      end
+
+      after(:all) do
+        Alchemy.admin_path = "/admin"
+        Alchemy.admin_constraints = {}
+        Rails.application.reload_routes!
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -24,6 +24,7 @@ require 'alchemy/test_support/essence_shared_examples'
 require 'alchemy/test_support/integration_helpers'
 require 'alchemy/test_support/factories'
 
+require_relative 'factories'
 require_relative "support/hint_examples.rb"
 require_relative "support/transformation_examples.rb"
 
@@ -52,7 +53,7 @@ RSpec.configure do |config|
   config.include ActiveSupport::Testing::TimeHelpers
   config.include Alchemy::Engine.routes.url_helpers
   config.include Alchemy::TestSupport::ControllerRequests, type: :controller
-  [:controller, :feature].each do |type|
+  [:controller, :feature, :request].each do |type|
     config.include Alchemy::TestSupport::IntegrationHelpers, type: type
   end
   config.include FactoryGirl::Syntax::Methods

data/spec/support/hint_examples.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 module Alchemy
   shared_examples_for "having a hint" do
-
     describe '#hint' do
       context 'with hint as text' do
         before do
@@ -17,7 +16,7 @@ module Alchemy
       context 'with hint set to true' do
         before do
           expect(subject).to receive(:definition).and_return({'hint' => true})
-          expect(I18n).to receive(:t).and_return('The hint')
+          expect(Alchemy).to receive(:t).and_return('The hint')
         end
 
         it "returns the hint from translation" do
@@ -25,6 +24,5 @@ module Alchemy
         end
       end
     end
-
   end
 end

data/spec/support/test_tweaks.rb

@@ -5,7 +5,7 @@ class ActiveRecord::Base
   @@shared_connection = nil
 
   def self.connection
-    @@shared_connection || ConnectionPool::Wrapper.new(:size => 1) { retrieve_connection }
+    @@shared_connection || ConnectionPool::Wrapper.new(size: 1) { retrieve_connection }
   end
 end
 ActiveRecord::Base.shared_connection = ActiveRecord::Base.connection
@@ -19,9 +19,9 @@ def truncate_all_tables
     connection.tables.each do |table_name|
       next if connection.select_value("SELECT count(*) FROM #{table_name}") == 0
       case config["adapter"]
-        when "mysql2", "postgresql"
+      when "mysql2", "postgresql"
           connection.execute("TRUNCATE #{table_name}")
-        when "sqlite3"
+      when "sqlite3"
           connection.execute("DELETE FROM #{table_name}")
           connection.execute("DELETE FROM sqlite_sequence where name='#{table_name}'")
       end

data/spec/support/transformation_examples.rb

@@ -1,15 +1,14 @@
 require 'spec_helper'
 
 module Alchemy
-  shared_examples_for "has image transformations"  do
-
+  shared_examples_for "has image transformations" do
     describe "#thumbnail_size" do
       context "picture is 300x400 and has no crop size" do
         it "should return the correct recalculated size value" do
           allow(picture).to receive(:image_file_width) { 400 }
           allow(picture).to receive(:image_file_height) { 300 }
 
-          expect(picture.thumbnail_size()).to eq('111x83')
+          expect(picture.thumbnail_size).to eq('111x83')
         end
       end
 
@@ -18,21 +17,21 @@ module Alchemy
           allow(picture).to receive(:image_file_width) { 300 }
           allow(picture).to receive(:image_file_height) { 400 }
 
-          expect(picture.thumbnail_size()).to eq('70x93')
+          expect(picture.thumbnail_size).to eq('70x93')
         end
       end
 
       context "picture has crop_size of 400x300" do
         it "scales to 400x300 if that is the size of the cropped image" do
           allow(picture).to receive(:crop_size) { "400x300" }
-          expect(picture.thumbnail_size()).to eq('111x83')
+          expect(picture.thumbnail_size).to eq('111x83')
         end
       end
 
       context "picture has crop_size of 0x0" do
         it "returns default thumbnail size" do
           allow(picture).to receive(:crop_size) { "0x0" }
-          expect(picture.thumbnail_size()).to eq('111x93')
+          expect(picture.thumbnail_size).to eq('111x93')
         end
       end
     end
@@ -112,7 +111,7 @@ module Alchemy
       end
 
       it "should return a Hash where all values are Integer" do
-        expect(picture.default_mask({ width: 13, height: 13 }).all? do |k, v|
+        expect(picture.default_mask({ width: 13, height: 13 }).all? do |_k, v|
           v.is_a? Integer
         end).to be_truthy
       end

data/spec/tasks/helpers_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 require 'alchemy/tasks/helpers'
 
 module Alchemy
-
   class Foo
     extend Tasks::Helpers
   end
@@ -19,7 +18,7 @@ module Alchemy
     end
 
     before do
-      allow(File).to receive(:exists?) { true }
+      allow(File).to receive(:exist?) { true }
       allow(File).to receive(:read) do
 <<-END
 test:
@@ -207,13 +206,12 @@ END
       end
 
       context 'for missing database config file' do
-        before { allow(File).to receive(:exists?).and_return( false) }
+        before { allow(File).to receive(:exist?).and_return( false) }
 
         it "raises error" do
           expect { Foo.database_config }.to raise_error(RuntimeError)
         end
       end
     end
-
   end
 end

data/spec/views/admin/pictures/show_spec.rb

@@ -0,0 +1,43 @@
+require "spec_helper"
+
+describe "alchemy/admin/pictures/show.html.erb" do
+  let(:image) do
+    fixture_file_upload(
+      File.expand_path('../../../../fixtures/animated.gif', __FILE__),
+      'image/gif'
+    )
+  end
+
+  let(:picture) do
+    build_stubbed(:alchemy_picture, {
+      image_file: image,
+      name: 'animated',
+      image_file_name: 'animated.gif'
+    })
+  end
+
+  before do
+    allow(view).to receive(:admin_picture_path).and_return("/path")
+    allow(view).to receive(:render_message) {}
+    view.extend Alchemy::Admin::FormHelper
+  end
+
+  it "displays picture in original format" do
+    assign(:picture, picture)
+    assign(:pages, [])
+
+    render
+
+    expect(rendered).to have_selector('img[src*="gif"]')
+  end
+
+  it "separates the tags with a comma" do
+    allow(picture).to receive(:tag_list).and_return(["one", "two", "three"])
+    assign(:picture, picture)
+    assign(:pages, [])
+
+    render
+
+    expect(rendered).to have_selector('input[value*="one,two,three"]')
+  end
+end