alchemy_cms 3.2.1 → 3.3.0.rc1

data/spec/controllers/alchemy/api/contents_controller_spec.rb

@@ -2,11 +2,10 @@ require 'spec_helper'
 
 module Alchemy
   describe Api::ContentsController do
-
     describe '#index' do
-      let!(:page)    { create(:page) }
-      let!(:element) { create(:element, page: page) }
-      let!(:content) { create(:content, element: element) }
+      let!(:page)    { create(:alchemy_page) }
+      let!(:element) { create(:alchemy_element, page: page) }
+      let!(:content) { create(:alchemy_content, element: element) }
 
       it "returns all public contents as json objects" do
         alchemy_get :index, format: :json
@@ -21,8 +20,8 @@ module Alchemy
       end
 
       context 'with element_id' do
-        let!(:other_element) { create(:element, page: page) }
-        let!(:other_content) { create(:content, element: other_element) }
+        let!(:other_element) { create(:alchemy_element, page: page) }
+        let!(:other_content) { create(:alchemy_content, element: other_element) }
 
         it "returns only contents from this element" do
           alchemy_get :index, element_id: other_element.id, format: :json
@@ -55,9 +54,9 @@ module Alchemy
 
     describe '#show' do
       context 'with no other params given' do
-        let(:page)    { create(:page) }
-        let(:element) { create(:element, page: page) }
-        let(:content) { create(:content, element: element) }
+        let(:page)    { create(:alchemy_page) }
+        let(:element) { create(:alchemy_element, page: page) }
+        let(:content) { create(:alchemy_content, element: element) }
 
         before do
           expect(Content).to receive(:find).and_return(content)
@@ -75,7 +74,7 @@ module Alchemy
         end
 
         context 'requesting an restricted content' do
-          let(:page) { create(:page, restricted: true) }
+          let(:page) { create(:alchemy_page, restricted: true) }
 
           it "responds with 403" do
             alchemy_get :show, id: content.id, format: :json
@@ -92,9 +91,9 @@ module Alchemy
       end
 
       context 'with element_id and name params given' do
-        let!(:page)    { create(:page) }
-        let!(:element) { create(:element, page: page) }
-        let!(:content) { create(:content, element: element) }
+        let!(:page)    { create(:alchemy_page) }
+        let!(:element) { create(:alchemy_element, page: page) }
+        let!(:content) { create(:alchemy_content, element: element) }
 
         it 'returns the named content from element with given id.' do
           alchemy_get :show, element_id: element.id, name: content.name, format: :json

data/spec/controllers/alchemy/api/elements_controller_spec.rb

@@ -2,12 +2,11 @@ require 'spec_helper'
 
 module Alchemy
   describe Api::ElementsController do
-
     describe '#index' do
-      let(:page) { create(:public_page) }
+      let(:page) { create(:alchemy_page, :public) }
 
       before do
-        2.times { create(:element, page: page) }
+        2.times { create(:alchemy_element, page: page) }
       end
 
       it "returns all public elements as json objects" do
@@ -23,8 +22,8 @@ module Alchemy
       end
 
       context 'with page_id param' do
-        let!(:other_page)    { create(:public_page) }
-        let!(:other_element) { create(:element, page: other_page) }
+        let!(:other_page)    { create(:alchemy_page, :public) }
+        let!(:other_element) { create(:alchemy_element, page: other_page) }
 
         it "returns only elements from this page" do
           alchemy_get :index, page_id: other_page.id, format: :json
@@ -55,7 +54,7 @@ module Alchemy
       end
 
       context 'with named param' do
-        let!(:other_element) { create(:element, page: page, name: 'news') }
+        let!(:other_element) { create(:alchemy_element, page: page, name: 'news') }
 
         it "returns only elements named like this." do
           alchemy_get :index, named: 'news', format: :json
@@ -87,8 +86,8 @@ module Alchemy
     end
 
     describe '#show' do
-      let(:page)    { build_stubbed(:page) }
-      let(:element) { build_stubbed(:element, page: page, position: 1) }
+      let(:page)    { build_stubbed(:alchemy_page) }
+      let(:element) { build_stubbed(:alchemy_element, page: page, position: 1) }
 
       before do
         expect(Element).to receive(:find).and_return(element)
@@ -106,7 +105,7 @@ module Alchemy
       end
 
       context 'requesting an restricted element' do
-        let(:page) { build_stubbed(:page, restricted: true) }
+        let(:page) { build_stubbed(:alchemy_page, restricted: true) }
 
         it "responds with 403" do
           alchemy_get :show, id: element.id, format: :json

data/spec/controllers/alchemy/api/pages_controller_spec.rb

@@ -2,9 +2,8 @@ require 'spec_helper'
 
 module Alchemy
   describe Api::PagesController do
-
     describe '#index' do
-      let!(:page) { create(:public_page) }
+      let!(:page) { create(:alchemy_page, :public) }
 
       it "returns all public pages as json objects" do
         alchemy_get :index, format: :json
@@ -19,7 +18,7 @@ module Alchemy
       end
 
       context 'with page_layout' do
-        let!(:other_page) { create(:public_page, page_layout: 'news') }
+        let!(:other_page) { create(:alchemy_page, :public, page_layout: 'news') }
 
         it "returns only page with this page layout" do
           alchemy_get :index, {page_layout: 'news', format: :json}
@@ -51,7 +50,7 @@ module Alchemy
 
     describe '#show' do
       context 'for existing page' do
-        let(:page) { build_stubbed(:public_page, urlname: 'a-page') }
+        let(:page) { build_stubbed(:alchemy_page, :public, urlname: 'a-page') }
 
         before do
           expect(Page).to receive(:find_by).and_return(page)
@@ -69,7 +68,7 @@ module Alchemy
         end
 
         context 'requesting an restricted page' do
-          let(:page) { build_stubbed(:page, restricted: true, urlname: 'a-page') }
+          let(:page) { build_stubbed(:alchemy_page, restricted: true, urlname: 'a-page') }
 
           it "responds with 403" do
             alchemy_get :show, {urlname: page.urlname, format: :json}
@@ -85,7 +84,7 @@ module Alchemy
         end
 
         context 'requesting a not public page' do
-          let(:page) { build_stubbed(:page, urlname: 'a-page') }
+          let(:page) { build_stubbed(:alchemy_page, urlname: 'a-page') }
 
           it "responds with 403" do
             alchemy_get :show, {urlname: page.urlname, format: :json}
@@ -113,10 +112,19 @@ module Alchemy
           expect(result).to have_key('error')
           expect(result['error']).to eq("Record not found")
         end
+
+        context "because of requesting not existing language" do
+          let(:page) { create(:alchemy_page, :public) }
+
+          it "responds with 404" do
+            alchemy_get :show, {urlname: page.urlname, locale: 'na', format: :json}
+            expect(response.status).to eq(404)
+          end
+        end
       end
 
       context 'requesting a page with id' do
-        let(:page) { create(:public_page) }
+        let(:page) { create(:alchemy_page, :public) }
 
         it "responds with json" do
           alchemy_get :show, {id: page.id, format: :json}
@@ -129,6 +137,31 @@ module Alchemy
           expect(result['id']).to eq(page.id)
         end
       end
+
+      context 'in an environment with multiple languages' do
+        let(:klingon) { create(:alchemy_language, :klingon) }
+
+        context 'having two pages with the same url names in different languages' do
+          let!(:english_page) { create(:alchemy_page, :public, language: Language.default, name: "same-name") }
+          let!(:klingon_page) { create(:alchemy_page, :public, language: klingon, name: "same-name") }
+
+          context 'when a locale is given' do
+            it 'renders the page related to its language' do
+              alchemy_get :show, {urlname: "same-name", locale: klingon_page.language_code, format: :json}
+              result = JSON.parse(response.body)
+              expect(result['id']).to eq(klingon_page.id)
+            end
+          end
+
+          context 'when no locale is given' do
+            it 'renders the page of the default language' do
+              alchemy_get :show, {urlname: "same-name", format: :json}
+              result = JSON.parse(response.body)
+              expect(result['id']).to eq(english_page.id)
+            end
+          end
+        end
+      end
     end
   end
 end

data/spec/controllers/{attachments_controller_spec.rb → alchemy/attachments_controller_spec.rb}

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 module Alchemy
   describe AttachmentsController do
-    let(:attachment) { build_stubbed(:attachment) }
+    let(:attachment) { build_stubbed(:alchemy_attachment) }
 
     it "should raise ActiveRecord::RecordNotFound for requesting not existing attachments" do
       expect { alchemy_get :download, id: 0 }.to raise_error(ActiveRecord::RecordNotFound)
@@ -14,13 +14,13 @@ module Alchemy
       end
 
       it "sends download as attachment." do
-        alchemy_get :download, :id => attachment.id
+        alchemy_get :download, id: attachment.id
         expect(response.status).to eq(200)
         expect(response.headers['Content-Disposition']).to match(/attachment/)
       end
 
       it "sends download inline." do
-        alchemy_get :show, :id => attachment.id
+        alchemy_get :show, id: attachment.id
         expect(response.status).to eq(200)
         expect(response.headers['Content-Disposition']).to match(/inline/)
       end
@@ -34,13 +34,13 @@ module Alchemy
 
       context 'as anonymous user' do
         it "should not be possible to download attachments from restricted pages" do
-          alchemy_get :download, :id => attachment.id
+          alchemy_get :download, id: attachment.id
           expect(response.status).to eq(302)
           expect(response).to redirect_to(Alchemy.login_path)
         end
 
         it "should not be possible to see attachments from restricted pages" do
-          alchemy_get :show, :id => attachment.id
+          alchemy_get :show, id: attachment.id
           expect(response.status).to eq(302)
           expect(response).to redirect_to(Alchemy.login_path)
         end
@@ -50,12 +50,12 @@ module Alchemy
         before { authorize_user(build(:alchemy_dummy_user)) }
 
         it "should be possible to download attachments from restricted pages" do
-          alchemy_get :download, :id => attachment.id
+          alchemy_get :download, id: attachment.id
           expect(response.status).to eq(200)
         end
 
         it "should be possible to see attachments from restricted pages" do
-          alchemy_get :show, :id => attachment.id
+          alchemy_get :show, id: attachment.id
           expect(response.status).to eq(200)
         end
       end

data/spec/controllers/alchemy/base_controller_spec.rb

@@ -0,0 +1,106 @@
+require 'spec_helper'
+
+module Alchemy
+  describe BaseController do
+    describe '#set_locale' do
+      context 'with Language.current set' do
+        let(:language) { create(:alchemy_language, :klingon) }
+
+        before { Alchemy::Language.current = language }
+
+        it "sets the ::I18n.locale to current language code" do
+          controller.send(:set_locale)
+          expect(::I18n.locale).to eq(language.code.to_sym)
+        end
+      end
+
+      context 'without Language.current set' do
+        before { Alchemy::Language.current = nil }
+
+        it "sets the ::I18n.locale to default language code" do
+          controller.send(:set_locale)
+          expect(::I18n.locale).to eq(Language.default.code.to_sym)
+        end
+      end
+    end
+
+    describe "#configuration" do
+      it "returns certain configuration options" do
+        allow(Config).to receive(:show).and_return({"some_option" => true})
+        expect(controller.configuration(:some_option)).to eq(true)
+      end
+    end
+
+    describe "#multi_language?" do
+      context "if more than one published language exists" do
+        it "returns true" do
+          allow(Alchemy::Language).to receive(:published).and_return double(count: 2)
+          expect(controller.multi_language?).to eq(true)
+        end
+      end
+
+      context "if less than two published languages exists" do
+        it "returns false" do
+          allow(Alchemy::Language).to receive(:published).and_return double(count: 1)
+          expect(controller.multi_language?).to eq(false)
+        end
+      end
+    end
+
+    describe "#prefix_locale?" do
+      subject(:prefix_locale?) { controller.prefix_locale? }
+
+      context "if multi_language? is true" do
+        before do
+          expect(controller).to receive(:multi_language?) { true }
+        end
+
+        context "and current language is not the default locale" do
+          before do
+            allow(Alchemy::Language).to receive(:current) { double(code: 'en') }
+            allow(::I18n).to receive(:default_locale) { :de }
+          end
+
+          it { expect(prefix_locale?).to be(true) }
+        end
+
+        context "and current language is the default locale" do
+          before do
+            allow(Alchemy::Language).to receive(:current) { double(code: 'de') }
+            allow(::I18n).to receive(:default_locale) { :de }
+          end
+
+          it { expect(prefix_locale?).to be(false) }
+        end
+
+        context "and passed in locale is not the default locale" do
+          subject(:prefix_locale?) { controller.prefix_locale?('en') }
+
+          before do
+            allow(::I18n).to receive(:default_locale) { :de }
+          end
+
+          it { expect(prefix_locale?).to be(true) }
+        end
+
+        context "and passed in locale is the default locale" do
+          subject(:prefix_locale?) { controller.prefix_locale?('de') }
+
+          before do
+            allow(::I18n).to receive(:default_locale) { :de }
+          end
+
+          it { expect(prefix_locale?).to be(false) }
+        end
+      end
+
+      context "if multi_language? is false" do
+        before do
+          expect(controller).to receive(:multi_language?) { false }
+        end
+
+        it { expect(prefix_locale?).to be(false) }
+      end
+    end
+  end
+end

data/spec/controllers/{elements_controller_spec.rb → alchemy/elements_controller_spec.rb}

@@ -2,10 +2,10 @@ require 'spec_helper'
 
 module Alchemy
   describe ElementsController do
-    let(:public_page)         { create(:public_page) }
-    let(:element)             { create(:element, page: public_page, name: 'download') }
-    let(:restricted_page)     { create(:public_page, restricted: true) }
-    let(:restricted_element)  { create(:element, page: restricted_page, name: 'download') }
+    let(:public_page)         { create(:alchemy_page, :public) }
+    let(:element)             { create(:alchemy_element, page: public_page, name: 'download') }
+    let(:restricted_page)     { create(:alchemy_page, :public, restricted: true) }
+    let(:restricted_element)  { create(:alchemy_element, page: restricted_page, name: 'download') }
 
     describe '#show' do
       it "should render available elements" do

data/spec/controllers/{messages_controller_spec.rb → alchemy/messages_controller_spec.rb}

@@ -13,14 +13,14 @@ module Alchemy
       let(:page) { mock_model('Page', {urlname: 'contact', page_layout: 'contact'}) }
 
       it "should redirect to @page" do
-        expect(alchemy_get :index).to redirect_to(show_page_path(urlname: page.urlname))
+        expect(alchemy_get(:index)).to redirect_to(show_page_path(urlname: page.urlname))
       end
     end
 
     describe "#new" do
       it "should render the alchemy/pages/show template" do
         alchemy_get :new
-        expect(alchemy_get :new).to render_template('alchemy/pages/show')
+        expect(alchemy_get(:new)).to render_template('alchemy/pages/show')
       end
     end
 
@@ -38,7 +38,6 @@ module Alchemy
       end
 
       context "if validation of message" do
-
         before do
           allow(Element).to receive(:find_by).and_return(element)
           allow(element).to receive(:ingredient).with(:success_page).and_return('thank-you')
@@ -51,7 +50,7 @@ module Alchemy
           end
 
           it "should render 'alchemy/pages/show' template" do
-            expect(alchemy_post :create).to render_template('alchemy/pages/show')
+            expect(alchemy_post(:create)).to render_template('alchemy/pages/show')
           end
         end
 
@@ -157,7 +156,9 @@ module Alchemy
               end
 
               it "should redirect to the given urlname" do
-                expect(alchemy_post :create).to redirect_to(show_page_path(urlname: 'success-page'))
+                expect(
+                  alchemy_post(:create)
+                ).to redirect_to(show_page_path(urlname: 'success-page'))
               end
             end
 
@@ -173,12 +174,14 @@ module Alchemy
                 end
 
                 it "redirect to the given success page" do
-                  expect(alchemy_post :create).to redirect_to(show_page_path(urlname: 'mailer-config-success-page'))
+                  expect(
+                    alchemy_post(:create)
+                  ).to redirect_to(show_page_path(urlname: 'mailer-config-success-page'))
                 end
               end
 
               context "and mailer_config has no instructions for success_page" do
-                let(:language) { mock_model('Language', code: 'en', pages: double(find_by: build_stubbed(:page))) }
+                let(:language) { mock_model('Language', code: 'en', locale: 'en', pages: double(find_by: build_stubbed(:alchemy_page))) }
 
                 before do
                   allow(controller).to receive(:mailer_config).and_return({})
@@ -186,8 +189,10 @@ module Alchemy
                 end
 
                 it "should redirect to the language root page" do
-                  expect(Language).to receive(:current).and_return(language)
-                  expect(alchemy_post :create).to redirect_to(show_page_path(urlname: 'lang-root'))
+                  allow(Language).to receive(:current).and_return(language)
+                  expect(
+                    alchemy_post(:create)
+                  ).to redirect_to(show_page_path(urlname: 'lang-root'))
                 end
               end
             end