alchemy_cms 3.2.1 → 3.3.0.rc1

data/spec/features/admin/picture_library_integration_spec.rb

@@ -6,8 +6,8 @@ RSpec.feature "Picture Library" do
   end
 
   describe "Tagging" do
-    let!(:picture_1) { create(:picture, tag_list: 'tag1', name: 'TaggedWith1') }
-    let!(:picture_2) { create(:picture, tag_list: 'tag2', name: 'TaggedWith2') }
+    let!(:picture_1) { create(:alchemy_picture, tag_list: 'tag1', name: 'TaggedWith1') }
+    let!(:picture_2) { create(:alchemy_picture, tag_list: 'tag2', name: 'TaggedWith2') }
 
     scenario "it's possible to filter tags by clicking on its name in the tag list." do
       visit alchemy.admin_pictures_path
@@ -43,7 +43,7 @@ RSpec.feature "Picture Library" do
   end
 
   describe "Filter by tag" do
-    let!(:picture) { create(:picture, tag_list: 'bla') }
+    let!(:picture) { create(:alchemy_picture, tag_list: 'bla') }
 
     scenario "lists all applied tags." do
       visit alchemy.admin_pictures_path

data/spec/features/admin/resources_integration_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
 describe "Resources" do
-  let(:event)        { FactoryGirl.create(:event) }
-  let(:second_event) { FactoryGirl.create(:event, :name => 'My second Event', :entrance_fee => 12.32) }
+  let(:event)        { create(:event) }
+  let(:second_event) { create(:event, name: 'My second Event', entrance_fee: 12.32) }
 
   before { authorize_user(:as_admin) }
 
   describe "index view" do
-
     it "should have a button for creating a new resource items" do
       visit '/admin/events'
       expect(page).to have_selector('#toolbar div.button_with_label a.icon_button span.icon.create')
@@ -27,7 +26,6 @@ describe "Resources" do
       visit '/admin/events'
       expect(page).to have_selector('div#archive_all table.list')
     end
-
   end
 
   describe "form for creating and updating items" do
@@ -53,12 +51,11 @@ describe "Resources" do
   end
 
   describe "create resource item" do
-
     context "when form filled with valid data" do
       before do
         visit '/admin/events/new'
-        fill_in 'event_name', :with => 'My second event'
-        fill_in 'event_starts_at', :with => DateTime.new(2012, 03, 03, 20, 00)
+        fill_in 'event_name', with: 'My second event'
+        fill_in 'event_starts_at', with: DateTime.new(2012, 03, 03, 20, 00)
         click_on 'Save'
       end
 
@@ -75,7 +72,7 @@ describe "Resources" do
     context "when form filled with invalid data" do
       before do
         visit '/admin/events/new'
-        fill_in 'event_name', :with => '' #invalid!
+        fill_in 'event_name', with: '' # invalid!
         click_on 'Save'
       end
 
@@ -91,13 +88,12 @@ describe "Resources" do
         expect(page).not_to have_content("successfully created")
       end
     end
-
   end
 
   describe "updating an item" do
     before do
       visit("/admin/events/#{event.id}/edit")
-      fill_in 'event_name', :with => 'New event name'
+      fill_in 'event_name', with: 'New event name'
       click_on 'Save'
     end
 
@@ -115,7 +111,7 @@ describe "Resources" do
       event
       second_event
       visit '/admin/events'
-      within('tr', :text => 'My second Event') do
+      within('tr', text: 'My second Event') do
         click_on 'Delete'
       end
     end
@@ -129,5 +125,4 @@ describe "Resources" do
       expect(page).to have_content("Succesfully removed")
     end
   end
-
 end

data/spec/features/admin/site_select_feature_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'Site select' do
-
   before do
     authorize_user(:as_admin)
   end
@@ -12,7 +11,7 @@ describe 'Site select' do
   end
 
   context "multiple sites" do
-    let!(:a_site) { FactoryGirl.create(:site) }
+    let!(:a_site) { create(:alchemy_site) }
 
     it "contains all sites in a selectbox" do
       visit admin_dashboard_path

data/spec/features/admin/tinymce_feature_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'TinyMCE Editor' do
-
   before do
     authorize_user(:as_admin)
   end

data/spec/features/page_feature_spec.rb

@@ -1,168 +1,61 @@
 require 'spec_helper'
 
 module Alchemy
-  describe 'Page' do
-    let(:default_language)      { Language.default }
-    let(:default_language_root) { create(:language_root_page, :language => default_language, :name => 'Home') }
-    let(:public_page_1)         { create(:public_page, :visible => true, :name => 'Page 1') }
-    let(:public_child)          { create(:public_page, :name => 'Public Child', :parent_id => public_page_1.id) }
+  describe 'Show page feature:' do
+    let!(:default_language) { Language.default }
 
-    before { default_language_root }
-
-    it "should include all its elements and contents" do
-      p = create(:public_page, :do_not_autogenerate => false)
-      article = p.elements.find_by_name('article')
-      article.content_by_name('intro').essence.update_attributes(:body => 'Welcome to Peters Petshop', :public => true)
-      visit "/#{p.urlname}"
-      within('div#content div.article div.intro') { expect(page).to have_content('Welcome to Peters Petshop') }
+    let!(:default_language_root) do
+      create(:alchemy_page, :language_root, language: default_language, name: 'Home')
     end
 
-    it "should show the navigation with all visible pages" do
-      pages = [
-        create(:public_page, :visible => true, :name => 'Page 1'),
-        create(:public_page, :visible => true, :name => 'Page 2')
-      ]
-      visit '/'
-      within('div#navigation ul') { expect(page).to have_selector('li a[href="/page-1"], li a[href="/page-2"]') }
+    let(:public_page) do
+      create(:alchemy_page, :public, visible: true, name: 'Page 1')
     end
 
-    describe "redirecting" do
-      context "in multi language mode" do
-        before do
-          allow(Config).to receive(:get) { |arg| arg == :url_nesting ? true : Config.parameter(arg) }
-          allow_any_instance_of(PagesController).to receive(:multi_language?).and_return(true)
-        end
-
-        let(:second_page) { create(:public_page, name: 'Second Page') }
-        let(:legacy_url)  { LegacyPageUrl.create(urlname: 'index.php?option=com_content&view=article&id=48&Itemid=69', page: second_page) }
-
-        it "should redirect legacy url with unknown format & query string" do
-          visit "/#{legacy_url.urlname}"
-          uri = URI.parse(page.current_url)
-          expect(uri.query).to be_nil
-          expect(uri.request_uri).to eq("/en/#{second_page.urlname}")
-        end
-
-        context "if no language params are given" do
-          it "should redirect to url with nested language code" do
-            visit "/#{public_page_1.urlname}"
-            expect(page.current_path).to eq("/#{public_page_1.language_code}/#{public_page_1.urlname}")
-          end
-        end
-
-        context "if requested page is unpublished" do
-          before do
-            allow(Config).to receive(:get) { |arg| arg == :url_nesting ? false : Config.parameter(arg) }
-            public_page_1.update_attributes(:public => false, :name => 'Not Public', :urlname => '')
-            public_child
-          end
-
-          it "should redirect to public child" do
-            visit "/#{default_language.code}/not-public"
-            expect(page.current_path).to eq("/#{default_language.code}/public-child")
-          end
-
-          context "and url has no language code" do
-            it "should redirect to url of public child with language code of default language" do
-              visit '/not-public'
-              expect(page.current_path).to eq("/#{default_language.code}/public-child")
-            end
-          end
-        end
-
-        context "if requested url is index url" do
-          it "should redirect to pages url with default language" do
-            visit '/'
-            expect(page.current_path).to eq("/#{default_language.code}/home")
-          end
-        end
-
-        context "if requested url is only the language code" do
-          it "should redirect to pages url with default language" do
-            visit "/#{default_language.code}"
-            expect(page.current_path).to eq("/#{default_language.code}/home")
-          end
-        end
-
-        context "requested url is only the urlname" do
-          it "then it should redirect to pages url with nested language." do
-            visit '/home'
-            expect(page.current_path).to eq('/en/home')
-          end
-        end
-
-        it "should keep additional params" do
-          visit "/#{public_page_1.urlname}?query=Peter"
-          expect(page.current_url).to match(/\?query=Peter/)
-        end
-
-        context "wrong language requested" do
-          before { allow(Alchemy.user_class).to receive(:admins).and_return([1, 2]) }
-
-          it "should render 404 if urlname and lang parameter do not belong to same page" do
-            create(:klingonian)
-            expect {
-              visit "/kl/#{public_page_1.urlname}"
-            }.to raise_error(ActionController::RoutingError)
-          end
+    let(:public_child) do
+      create(:alchemy_page, :public, name: 'Public Child', parent_id: public_page.id)
+    end
 
-          it "should render 404 if requested language does not exist" do
-            public_page_1
-            LegacyPageUrl.delete_all
-            expect {
-              visit "/fo/#{public_page_1.urlname}"
-            }.to raise_error(ActionController::RoutingError)
-          end
-        end
+    context "When no page is present" do
+      before do
+        Alchemy::Page.delete_all
       end
 
-      context "not in multi language mode" do
+      context "and no admin user is present yet" do
         before do
-          allow_any_instance_of(PagesController).to receive(:multi_language?).and_return(false)
-          allow(Config).to receive(:get) { |arg| arg == :url_nesting ? false : Config.parameter(arg) }
-        end
-
-        let(:second_page) { create(:public_page, name: 'Second Page') }
-        let(:legacy_url) { LegacyPageUrl.create(urlname: 'index.php?option=com_content&view=article&id=48&Itemid=69', page: second_page) }
-
-        it "should redirect legacy url with unknown format & query string" do
-          visit "/#{legacy_url.urlname}"
-          uri = URI.parse(page.current_url)
-          expect(uri.query).to be_nil
-          expect(uri.request_uri).to eq("/#{second_page.urlname}")
+          Alchemy.user_class.delete_all
         end
 
-        it "should redirect from nested language code url to normal url" do
-          visit "/en/#{public_page_1.urlname}"
-          expect(page.current_path).to eq("/#{public_page_1.urlname}")
+        it 'shows a welcome page' do
+          visit "/"
+          expect(page).to have_content('Welcome to Alchemy')
         end
+      end
+    end
 
-        context "should redirect to public child" do
-          before do
-            public_page_1.update_attributes(:public => false, :name => 'Not Public', :urlname => '')
-            public_child
-          end
-
-          it "if requested page is unpublished" do
-            visit '/not-public'
-            expect(page.current_path).to eq('/public-child')
-          end
+    context 'rendered' do
+      let(:public_page) { create(:alchemy_page, :public, do_not_autogenerate: false) }
+      let(:article) { public_page.elements.find_by_name('article') }
+      let(:essence) { article.content_by_name('intro').essence }
 
-          it "with normal url, if requested url has nested language code and is not public" do
-            visit '/en/not-public'
-            expect(page.current_path).to eq('/public-child')
-          end
-        end
+      before do
+        essence.update_attributes(body: 'Welcome to Peters Petshop', public: true)
+      end
 
-        it "should redirect to pages url, if requested url is index url" do
-          visit '/'
-          expect(page.current_path).to eq('/home')
+      it "should include all its elements and contents" do
+        visit "/#{public_page.urlname}"
+        within('div#content div.article div.intro') do
+          expect(page).to have_content('Welcome to Peters Petshop')
         end
+      end
+    end
 
-        it "should keep additional params" do
-          visit "/en/#{public_page_1.urlname}?query=Peter"
-          expect(page.current_url).to match(/\?query=Peter/)
-        end
+    it "should show the navigation with all visible pages" do
+      create(:alchemy_page, :public, visible: true, name: 'Page 1')
+      create(:alchemy_page, :public, visible: true, name: 'Page 2')
+      visit '/'
+      within('div#navigation ul') do
+        expect(page).to have_selector('li a[href="/page-1"], li a[href="/page-2"]')
       end
     end
 
@@ -188,7 +81,7 @@ module Alchemy
     describe "menubar" do
       context "rendering for guest users" do
         it "is prohibited" do
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
           within('body') { expect(page).not_to have_selector('#alchemy_menubar') }
         end
       end
@@ -196,7 +89,7 @@ module Alchemy
       context "rendering for members" do
         it "is prohibited" do
           authorize_user(build(:alchemy_dummy_user))
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
           within('body') { expect(page).not_to have_selector('#alchemy_menubar') }
         end
       end
@@ -204,7 +97,7 @@ module Alchemy
       context "rendering for authors" do
         it "is allowed" do
           authorize_user(:as_author)
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
           within('body') { expect(page).to have_selector('#alchemy_menubar') }
         end
       end
@@ -212,7 +105,7 @@ module Alchemy
       context "rendering for editors" do
         it "is allowed" do
           authorize_user(:as_editor)
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
           within('body') { expect(page).to have_selector('#alchemy_menubar') }
         end
       end
@@ -220,7 +113,7 @@ module Alchemy
       context "rendering for admins" do
         it "is allowed" do
           authorize_user(:as_admin)
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
           within('body') { expect(page).to have_selector('#alchemy_menubar') }
         end
       end
@@ -228,24 +121,26 @@ module Alchemy
       context "contains" do
         before do
           authorize_user(:as_admin)
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
         end
 
         it "a link to the admin area" do
           within('#alchemy_menubar') do
-            expect(page).to have_selector("li a[href='#{alchemy.admin_dashboard_path}']")
+            expect(page).to have_selector("li a[href='#{alchemy.admin_dashboard_url}']")
           end
         end
 
         it "a link to edit the current page" do
           within('#alchemy_menubar') do
-            expect(page).to have_selector("li a[href='#{alchemy.edit_admin_page_path(public_page_1)}']")
+            expect(page).to \
+              have_selector("li a[href='#{alchemy.edit_admin_page_url(public_page)}']")
           end
         end
 
         it "a form and button to logout of alchemy" do
           within('#alchemy_menubar') do
-            expect(page).to have_selector("li form[action='#{Alchemy.logout_path}'], li button[type='submit']")
+            expect(page).to \
+              have_selector("li form[action='#{Alchemy.logout_path}'], li button[type='submit']")
           end
         end
       end
@@ -253,10 +148,12 @@ module Alchemy
 
     describe 'navigation rendering' do
       context 'with page having an external url without protocol' do
-        let!(:external_page) { create(:page, urlname: 'google.com', page_layout: 'external', visible: true) }
+        let!(:external_page) do
+          create(:alchemy_page, urlname: 'google.com', page_layout: 'external', visible: true)
+        end
 
         it "adds an prefix to url" do
-          visit "/#{public_page_1.urlname}"
+          visit "/#{public_page.urlname}"
           within '#navigation' do
             expect(page.body).to match('http://google.com')
           end
@@ -265,7 +162,7 @@ module Alchemy
     end
 
     describe 'accessing restricted pages' do
-      let!(:restricted_page) { create(:restricted_page, public: true) }
+      let!(:restricted_page) { create(:alchemy_page, :restricted, public: true) }
 
       context 'as a guest user' do
         it "I am not able to visit the page" do
@@ -275,7 +172,9 @@ module Alchemy
       end
 
       context 'as a member user' do
-        before { authorize_user(create(:alchemy_dummy_user)) }
+        before do
+          authorize_user(create(:alchemy_dummy_user))
+        end
 
         it "I am able to visit the page" do
           visit restricted_page.urlname

data/spec/features/page_redirects_spec.rb

@@ -0,0 +1,358 @@
+require 'spec_helper'
+
+module Alchemy
+  describe 'Requesting a page' do
+    let!(:default_language) { Language.default }
+
+    let!(:default_language_root) do
+      create(:alchemy_page, :language_root, language: default_language, name: 'Home')
+    end
+
+    let(:public_page) do
+      create(:alchemy_page, :public, visible: true, name: 'Page 1')
+    end
+
+    let(:public_child) do
+      create(:alchemy_page, :public, name: 'Public Child', parent_id: public_page.id)
+    end
+
+    context "in multi language mode" do
+      let(:second_page) { create(:alchemy_page, :public, name: 'Second Page') }
+
+      let(:legacy_url) do
+        LegacyPageUrl.create(
+          urlname: 'index.php?option=com_content&view=article&id=48&Itemid=69',
+          page: second_page
+        )
+      end
+
+      before do
+        allow_any_instance_of(PagesController).to receive(:multi_language?).and_return(true)
+      end
+
+      context 'if language params are given' do
+        context "and page locale is default locale" do
+          it "redirects to unprefixed locale url" do
+            allow(::I18n).to receive(:default_locale) { public_page.language_code.to_sym }
+            visit("/#{public_page.language_code}/#{public_page.urlname}")
+            expect(page.current_path).to eq("/#{public_page.urlname}")
+          end
+        end
+
+        context "and page locale is not default locale" do
+          it "does not redirect" do
+            allow(::I18n).to receive(:default_locale).and_return(:de)
+            visit("/#{public_page.language_code}/#{public_page.urlname}")
+            expect(page.current_path).to eq("/#{public_page.language_code}/#{public_page.urlname}")
+          end
+        end
+      end
+
+      context 'if no language params are given' do
+        context "and page locale is default locale" do
+          it "doesn't prepend the url with the locale string" do
+            allow(::I18n).to receive(:default_locale) { public_page.language_code.to_sym }
+            visit("/#{public_page.urlname}")
+            expect(page.current_path).to eq("/#{public_page.urlname}")
+          end
+
+          it "redirects legacy url with unknown format & query string without locale prefix" do
+            allow(::I18n).to receive(:default_locale) { second_page.language_code.to_sym }
+            visit "/#{legacy_url.urlname}"
+            uri = URI.parse(page.current_url)
+            expect(uri.query).to be_nil
+            expect(uri.request_uri).to eq("/#{second_page.urlname}")
+          end
+        end
+
+        context "and page locale is not default locale" do
+          before do
+            allow(::I18n).to receive(:default_locale).and_return(:de)
+          end
+
+          it "redirects to url with the locale prefixed" do
+            visit("/#{public_page.urlname}")
+            expect(page.current_path).to eq("/en/#{public_page.urlname}")
+          end
+
+          it "redirects legacy url with unknown format & query string with locale prefix" do
+            visit "/#{legacy_url.urlname}"
+            uri = URI.parse(page.current_url)
+            expect(uri.query).to be_nil
+            expect(uri.request_uri).to eq("/en/#{second_page.urlname}")
+          end
+        end
+      end
+
+      context "if requested page is unpublished" do
+        before do
+          public_page.update_attributes(
+            public: false,
+            visible: false,
+            name: 'Not Public',
+            urlname: ''
+          )
+          public_child
+        end
+
+        it "redirects to public child" do
+          visit "/not-public"
+          expect(page.current_path).to eq("/public-child")
+        end
+
+        context "with only unpublished pages in page tree" do
+          before do
+            public_child.update_attributes(public: false)
+          end
+
+          it "should raise not found error" do
+            expect {
+              visit "/not-public"
+            }.to raise_error(ActionController::RoutingError)
+          end
+        end
+
+        context "if page locale is the default locale" do
+          it "redirects to public child with prefixed locale" do
+            allow(::I18n).to receive(:default_locale).and_return(:de)
+            visit "/not-public"
+            expect(page.current_path).to eq("/en/public-child")
+          end
+        end
+      end
+
+      context "if requested url is the index url" do
+        context 'and redirect_index is set to true' do
+          before do
+            allow(Config).to receive(:get) do |arg|
+              arg == :redirect_index ? true : Config.parameter(arg)
+            end
+            if Alchemy.version == "4.0.0.rc1"
+              raise "Remove deprecated `redirect_index` configuration!"
+            end
+            ActiveSupport::Deprecation.silenced = true
+          end
+
+          after do
+            ActiveSupport::Deprecation.silenced = false
+          end
+
+          context "and if page locale is the default locale" do
+            it "redirects to the default language root page without prefixed locale" do
+              visit '/'
+              expect(page.current_path).to eq('/home')
+            end
+
+            context "having additional parameter" do
+              it "redirects to the default language root page with prefixed locale while keeping the additional params" do
+                visit '/?search=kitten'
+                expect(page.current_url).to eq('http://www.example.com/home?search=kitten')
+              end
+            end
+          end
+
+          context "and if page locale is not the default locale" do
+            before do
+              allow(::I18n).to receive(:default_locale).and_return(:de)
+            end
+
+            it "redirects to the default language root page with prefixed locale" do
+              visit '/'
+              expect(page.current_path).to eq('/en/home')
+            end
+
+            context "having additional parameter" do
+              it "redirects to the default language root page with prefixed locale while keeping the additional params" do
+                visit '/?search=kitten'
+                expect(page.current_url).to eq('http://www.example.com/en/home?search=kitten')
+              end
+            end
+          end
+        end
+
+        context 'and redirect_index is set to false' do
+          before do
+            allow(Config).to receive(:get) do |arg|
+              arg == :redirect_index ? false : Config.parameter(arg)
+            end
+          end
+
+          it "does not redirect" do
+            visit '/'
+            expect(page.current_path).to eq('/')
+          end
+        end
+      end
+
+      context "if requested url is only the language code" do
+        context 'and redirect_index is set to true' do
+          before do
+            allow(Config).to receive(:get) do |arg|
+              arg == :redirect_index ? true : Config.parameter(arg)
+            end
+            if Alchemy.version == "4.0.0.rc1"
+              raise "Remove deprecated `redirect_index` configuration!"
+            end
+            ActiveSupport::Deprecation.silenced = true
+          end
+
+          after do
+            ActiveSupport::Deprecation.silenced = false
+          end
+
+          context "if page locale is the default locale" do
+            it "redirects to pages url without locale prefixed" do
+              visit "/#{default_language.code}"
+              expect(page.current_path).to eq("/home")
+            end
+          end
+
+          context "if page locale is not the default locale" do
+            it "redirects to the default language root url with prefixed locale" do
+              allow(::I18n).to receive(:default_locale).and_return(:de)
+              visit "/#{default_language.code}"
+              expect(page.current_path).to eq('/en/home')
+            end
+          end
+        end
+
+        context 'and redirect_index is set to false' do
+          before do
+            allow(Config).to receive(:get) do |arg|
+              arg == :redirect_index ? false : Config.parameter(arg)
+            end
+          end
+
+          context "if requested locale is the default locale" do
+            before do
+              allow(::I18n).to receive(:default_locale) { default_language.code }
+            end
+
+            it "redirects to '/'" do
+              visit "/#{default_language.code}"
+              expect(page.current_path).to eq('/')
+            end
+          end
+
+          context "if page locale is not the default locale" do
+            before do
+              allow(::I18n).to receive(:default_locale) { :de }
+            end
+
+            it "does not redirect" do
+              visit "/#{default_language.code}"
+              expect(page.current_path).to eq("/#{default_language.code}")
+            end
+          end
+        end
+      end
+
+      it "should keep additional params" do
+        visit "/#{public_page.urlname}?query=Peter"
+        expect(page.current_url).to match(/\?query=Peter/)
+      end
+
+      context "wrong language requested" do
+        before do
+          allow(Alchemy.user_class).to receive(:admins).and_return([1, 2])
+        end
+
+        it "should render 404 if urlname and lang parameter do not belong to same page" do
+          create(:alchemy_language, :klingon)
+          expect {
+            visit "/kl/#{public_page.urlname}"
+          }.to raise_error(ActionController::RoutingError)
+        end
+
+        it "should render 404 if requested language does not exist" do
+          public_page
+          LegacyPageUrl.delete_all
+          expect {
+            visit "/fo/#{public_page.urlname}"
+          }.to raise_error(ActionController::RoutingError)
+        end
+      end
+    end
+
+    context "not in multi language mode" do
+      let(:second_page) { create(:alchemy_page, :public, name: 'Second Page') }
+
+      let(:legacy_url) do
+        LegacyPageUrl.create(
+          urlname: 'index.php?option=com_content&view=article&id=48&Itemid=69',
+          page: second_page
+        )
+      end
+
+      before do
+        allow_any_instance_of(PagesController).to receive(:multi_language?).and_return(false)
+      end
+
+      it "redirects legacy url with unknown format & query string" do
+        visit "/#{legacy_url.urlname}"
+        uri = URI.parse(page.current_url)
+        expect(uri.query).to be_nil
+        expect(uri.request_uri).to eq("/#{second_page.urlname}")
+      end
+
+      it "redirects from nested language code url to normal url" do
+        visit "/en/#{public_page.urlname}"
+        expect(page.current_path).to eq("/#{public_page.urlname}")
+      end
+
+      context "redirects to public child" do
+        before do
+          public_page.update_attributes(
+            public: false,
+            visible: false,
+            name: 'Not Public',
+            urlname: ''
+          )
+          public_child
+        end
+
+        it "if requested page is unpublished" do
+          visit '/not-public'
+          expect(page.current_path).to eq('/public-child')
+        end
+
+        it "with normal url, if requested url has nested language code and is not public" do
+          visit '/en/not-public'
+          expect(page.current_path).to eq('/public-child')
+        end
+      end
+
+      context 'if requested url is index url' do
+        context "when locale is prefixed" do
+          it "redirects to normal url" do
+            visit "/en"
+            expect(page.current_path).to eq("/")
+          end
+        end
+
+        context "when redirect_index is enabled" do
+          before do
+            allow(Config).to receive(:get) do |arg|
+              arg == :redirect_index ? true : Config.parameter(arg)
+            end
+            if Alchemy.version == "4.0.0.rc1"
+              raise "Remove deprecated `redirect_index` configuration!"
+            end
+          end
+
+          it "redirects to pages url" do
+            ActiveSupport::Deprecation.silence do
+              visit '/'
+              expect(page.current_path).to eq('/home')
+            end
+          end
+        end
+      end
+
+      it "should keep additional params" do
+        visit "/en/#{public_page.urlname}?query=Peter"
+        expect(page.current_url).to match(/\?query=Peter/)
+      end
+    end
+  end
+end