adlint 1.16.0 → 1.18.0

data/features/message_detection/W0715.feature

@@ -0,0 +1,118 @@
+Feature: W0715
+
+  W0715 detects that operands of both sides of inclusive-or-expression is 
+  `effectively boolean'.
+
+  Scenario: relational expressions
+    Given a target source named "W0715.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a > b) | (c > d); /* W0715 */
+      }
+      """
+    When I successfully run `adlint W0715.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0572 | 3    | 20     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0715 | 3    | 20     |
+      | W0716 | 3    | 20     |
+      | W0628 | 1    | 12     |
+
+  Scenario: equality expressions
+    Given a target source named "W0715.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a == b) | (c != d); /* W0715 */
+      }
+      """
+    When I successfully run `adlint W0715.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0572 | 3    | 21     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0715 | 3    | 21     |
+      | W0716 | 3    | 21     |
+      | W0628 | 1    | 12     |
+
+  Scenario: logical expressions
+    Given a target source named "W0715.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a && b) | (c || d); /* W0715 */
+      }
+      """
+    When I successfully run `adlint W0715.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0572 | 3    | 21     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0715 | 3    | 21     |
+      | W0716 | 3    | 21     |
+      | W0628 | 1    | 12     |
+
+  Scenario: shift expressions
+    Given a target source named "W0715.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a << b) | (c ^ d); /* OK */
+      }
+      """
+    When I successfully run `adlint W0715.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0570 | 3    | 15     |
+      | W0572 | 3    | 15     |
+      | W0794 | 3    | 15     |
+      | W0572 | 3    | 26     |
+      | W0572 | 3    | 21     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: arithmetic expressions
+    Given a target source named "W0715.c" with:
+      """
+      static int foo(int a, int b, int c, int d)
+      {
+          return (a + b) | (c - d); /* OK */
+      }
+      """
+    When I successfully run `adlint W0715.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0723 | 3    | 25     |
+      | W0572 | 3    | 20     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0104 | 1    | 41     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0716.feature

@@ -59,6 +59,7 @@ Feature: W0716
       | W1076 | 1    | 12     |
       | W0570 | 3    | 20     |
       | W0572 | 3    | 20     |
+      | W0794 | 3    | 20     |
       | W0104 | 1    | 20     |
       | W0104 | 1    | 27     |
       | W0104 | 1    | 34     |

data/features/message_detection/W0717.feature

@@ -57,6 +57,7 @@ Feature: W0717
       | W1076 | 1    | 12     |
       | W0570 | 3    | 20     |
       | W0572 | 3    | 20     |
+      | W0794 | 3    | 20     |
       | W0104 | 1    | 21     |
       | W0104 | 1    | 28     |
       | W0104 | 1    | 35     |

data/features/message_detection/W0718.feature

@@ -57,6 +57,7 @@ Feature: W0718
       | W1076 | 1    | 12     |
       | W0570 | 3    | 14     |
       | W0572 | 3    | 14     |
+      | W0794 | 3    | 14     |
       | W0104 | 1    | 21     |
       | W0104 | 1    | 28     |
       | W0104 | 1    | 35     |

data/features/message_detection/W0719.feature

@@ -0,0 +1,154 @@
+Feature: W0719
+
+  W0719 detects that the right hand side of the shift-expression is greater
+  than the bit length of underlying type of the left hand side.
+
+  Scenario: 31-bit left shift-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      int foo(char c)
+      {
+          return c << 31; /* W0719 */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0123 | 3    | 12     |
+      | W0246 | 3    | 12     |
+      | W0116 | 3    | 14     |
+      | W0719 | 3    | 14     |
+      | W0104 | 1    | 14     |
+      | W0628 | 1    | 5      |
+
+  Scenario: 31-bit right shift-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      int foo(char c)
+      {
+          return c >> 31; /* W0719 */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0123 | 3    | 12     |
+      | W0246 | 3    | 12     |
+      | W0719 | 3    | 14     |
+      | W0104 | 1    | 14     |
+      | W0628 | 1    | 5      |
+
+  Scenario: 7-bit left shift-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      int foo(char c)
+      {
+          return c << 7; /* OK */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0123 | 3    | 12     |
+      | W0246 | 3    | 12     |
+      | W0116 | 3    | 14     |
+      | W0104 | 1    | 14     |
+      | W0628 | 1    | 5      |
+
+  Scenario: 7-bit right shift-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      int foo(char c)
+      {
+          return c >> 7; /* OK */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0123 | 3    | 12     |
+      | W0246 | 3    | 12     |
+      | W0104 | 1    | 14     |
+      | W0628 | 1    | 5      |
+
+  Scenario: 31-bit left shift compound-assignment-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      void foo(char c)
+      {
+          c <<= 31; /* W0719 */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0123 | 3    | 5      |
+      | W0246 | 3    | 5      |
+      | W0116 | 3    | 7      |
+      | W0719 | 3    | 7      |
+      | W0136 | 3    | 5      |
+      | W0165 | 3    | 5      |
+      | W0628 | 1    | 6      |
+
+  Scenario: 31-bit right shift-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      int foo(char c)
+      {
+          return c >> 31; /* W0719 */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0123 | 3    | 12     |
+      | W0246 | 3    | 12     |
+      | W0719 | 3    | 14     |
+      | W0104 | 1    | 14     |
+      | W0628 | 1    | 5      |
+
+  Scenario: 63-bit left shift compound-assignment-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      void foo(char c)
+      {
+          c <<= 63; /* OK but W0650 */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0123 | 3    | 5      |
+      | W0246 | 3    | 5      |
+      | W0116 | 3    | 7      |
+      | W0650 | 3    | 7      |
+      | W0136 | 3    | 5      |
+      | W0165 | 3    | 5      |
+      | W0628 | 1    | 6      |
+
+  Scenario: 63-bit right shift-expression of `char' value
+    Given a target source named "W0719.c" with:
+      """
+      int foo(char c)
+      {
+          return c >> 63; /* OK but W0650 */
+      }
+      """
+    When I successfully run `adlint W0719.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0123 | 3    | 12     |
+      | W0246 | 3    | 12     |
+      | W0650 | 3    | 14     |
+      | W0104 | 1    | 14     |
+      | W0628 | 1    | 5      |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0723.feature

@@ -9,8 +9,7 @@ Feature: W0723
       static unsigned int j = (unsigned int) &i + 1; /* OK */
       """
     When I successfully run `adlint W0723.c` on noarch
-    Then the output should not match with /2:.*:W0723/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W0567 | 2    | 25     |
       | W0167 | 2    | 45     |

data/features/message_detection/W0732.feature

@@ -82,8 +82,10 @@ Feature: W0732
       | W1076 | 1    | 13     |
       | W0570 | 5    | 12     |
       | W0572 | 5    | 12     |
+      | W0794 | 5    | 12     |
       | W0570 | 5    | 24     |
       | W0572 | 5    | 24     |
+      | W0794 | 5    | 24     |
       | W0571 | 6    | 12     |
       | W0572 | 6    | 12     |
       | W0571 | 6    | 24     |
@@ -98,6 +100,7 @@ Feature: W0732
       | W0572 | 11   | 24     |
       | W0570 | 12   | 12     |
       | W0572 | 12   | 12     |
+      | W0794 | 12   | 12     |
       | W0571 | 12   | 25     |
       | W0572 | 12   | 25     |
       | W0104 | 1    | 29     |

data/features/message_detection/W0733.feature

@@ -82,8 +82,10 @@ Feature: W0733
       | W1076 | 1    | 13     |
       | W0570 | 5    | 12     |
       | W0572 | 5    | 12     |
+      | W0794 | 5    | 12     |
       | W0570 | 5    | 24     |
       | W0572 | 5    | 24     |
+      | W0794 | 5    | 24     |
       | W0571 | 6    | 12     |
       | W0572 | 6    | 12     |
       | W0571 | 6    | 24     |
@@ -98,6 +100,7 @@ Feature: W0733
       | W0572 | 11   | 24     |
       | W0570 | 12   | 12     |
       | W0572 | 12   | 12     |
+      | W0794 | 12   | 12     |
       | W0571 | 12   | 25     |
       | W0572 | 12   | 25     |
       | W0104 | 1    | 29     |

data/features/message_detection/W0734.feature

@@ -181,6 +181,7 @@ Feature: W0734
       | W1076 | 1    | 13     |
       | W0570 | 5    | 12     |
       | W0572 | 5    | 12     |
+      | W0794 | 5    | 12     |
       | W0571 | 6    | 12     |
       | W0572 | 6    | 12     |
       | W0572 | 7    | 12     |
@@ -222,6 +223,7 @@ Feature: W0734
       | W1076 | 1    | 13     |
       | W0570 | 5    | 12     |
       | W0572 | 5    | 12     |
+      | W0794 | 5    | 12     |
       | W0571 | 6    | 12     |
       | W0572 | 6    | 12     |
       | W0572 | 7    | 12     |
@@ -263,6 +265,7 @@ Feature: W0734
       | W1076 | 1    | 13     |
       | W0570 | 5    | 12     |
       | W0572 | 5    | 12     |
+      | W0794 | 5    | 12     |
       | W0571 | 6    | 12     |
       | W0572 | 6    | 12     |
       | W0572 | 7    | 12     |
@@ -305,6 +308,7 @@ Feature: W0734
       | W1076 | 1    | 13     |
       | W0570 | 5    | 12     |
       | W0572 | 5    | 12     |
+      | W0794 | 5    | 12     |
       | W0571 | 6    | 12     |
       | W0572 | 6    | 12     |
       | W0572 | 7    | 12     |

data/features/message_detection/W0735.feature

@@ -181,6 +181,7 @@ Feature: W0735
       | W1076 | 1    | 13     |
       | W0570 | 5    | 17     |
       | W0572 | 5    | 17     |
+      | W0794 | 5    | 17     |
       | W0571 | 6    | 17     |
       | W0572 | 6    | 17     |
       | W0572 | 7    | 17     |
@@ -222,6 +223,7 @@ Feature: W0735
       | W1076 | 1    | 13     |
       | W0570 | 5    | 17     |
       | W0572 | 5    | 17     |
+      | W0794 | 5    | 17     |
       | W0571 | 6    | 17     |
       | W0572 | 6    | 17     |
       | W0572 | 7    | 17     |
@@ -263,6 +265,7 @@ Feature: W0735
       | W1076 | 1    | 13     |
       | W0570 | 5    | 24     |
       | W0572 | 5    | 24     |
+      | W0794 | 5    | 24     |
       | W0571 | 6    | 23     |
       | W0572 | 6    | 23     |
       | W0572 | 7    | 24     |
@@ -305,6 +308,7 @@ Feature: W0735
       | W1076 | 1    | 13     |
       | W0570 | 5    | 24     |
       | W0572 | 5    | 24     |
+      | W0794 | 5    | 24     |
       | W0571 | 6    | 23     |
       | W0572 | 6    | 23     |
       | W0572 | 7    | 24     |

data/features/message_detection/W0745.feature

@@ -0,0 +1,132 @@
+Feature: W0745
+
+  W0745 detects that an array subscript must cause out of bound access of the
+  array object.
+
+  Scenario: array-subscript-expression with non-constant subscript must cause
+            OOB access in an initializer
+    Given a target source named "W0745.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          if (i < 0) {
+              int j = a[i - 1]; /* W0745 */
+              return j;
+          }
+          return i;
+      }
+      """
+    When I successfully run `adlint W0745.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0745 | 6    | 21     |
+      | W0100 | 6    | 13     |
+      | W0104 | 3    | 13     |
+      | W1071 | 3    | 5      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with non-constant subscript must cause
+            OOB access in rhs operand of an assignment-expression
+    Given a target source named "W0745.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          int j = 0;
+          if (i > 4) {
+              j = a[i + 1]; /* W0745 */
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint W0745.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0723 | 7    | 17     |
+      | W0745 | 7    | 17     |
+      | W0104 | 3    | 13     |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with non-constant subscript must cause
+            OOB access in lhs operand of an assignment-expression
+    Given a target source named "W0745.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          if (i < -2) {
+              a[i + 2] = 0; /* W0745 */
+          }
+      }
+      """
+    When I successfully run `adlint W0745.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W0745 | 6    | 13     |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 6      |
+
+  Scenario: indirection-expression with non-constant subscript must cause OOB
+            access in rhs operand of an assignment-expression
+    Given a target source named "W0745.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          int j = 0;
+          if (i > 5) {
+              j = *(a + i + 2); /* W0745 */
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint W0745.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 7    | 19     |
+      | W0023 | 7    | 17     |
+      | W9003 | 7    | 23     |
+      | W0023 | 7    | 21     |
+      | W0745 | 7    | 14     |
+      | W0104 | 3    | 13     |
+      | W0628 | 3    | 5      |
+
+  Scenario: indirection-expression with non-constant subscript must cause OOB
+            access in lhs operand of an assignment-expression
+    Given a target source named "W0745.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          if (i < 0) {
+              *(i + a - 1) = 0; /* W0745 */
+          }
+      }
+      """
+    When I successfully run `adlint W0745.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W9003 | 6    | 11     |
+      | W9003 | 6    | 19     |
+      | W0024 | 6    | 17     |
+      | W0745 | 6    | 10     |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 6      |
+
+# vim:ts=2:sw=2:sts=2:et: