adlint 1.16.0 → 1.18.0

data/features/message_detection/W1047.feature

@@ -0,0 +1,163 @@
+Feature: W1047
+
+  W1047 detects that an initializer of struct, union or array variable contains
+  non-constant expressions.
+
+  Scenario: initializing array with non-constant expressions
+    Given a target source named "W1047.c" with:
+      """
+      int foo(int i, int j)
+      {
+          int a[] = { 0, i, j }; /* W1047 */
+          return a[1];
+      }
+      """
+    When I successfully run `adlint W1047.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W1047 | 3    | 9      |
+      | W0100 | 3    | 9      |
+      | W0104 | 1    | 13     |
+      | W0104 | 1    | 20     |
+      | W0628 | 1    | 5      |
+
+  Scenario: initializing struct with non-constant expressions
+    Given a target source named "W1047.c" with:
+      """
+      struct Coord {
+          int x;
+          int y;
+          int z;
+      };
+
+      int foo(int i, int j)
+      {
+          struct Coord c = { i, j, 0 }; /* W1047 */
+          return c.y;
+      }
+      """
+    When I successfully run `adlint W1047.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 7    | 5      |
+      | W1047 | 9    | 18     |
+      | W0100 | 9    | 18     |
+      | W0104 | 7    | 13     |
+      | W0104 | 7    | 20     |
+      | W0628 | 7    | 5      |
+
+  Scenario: initializing union with non-constant expressions
+    Given a target source named "W1047.c" with:
+      """
+      struct Color {
+          int r;
+          int g;
+          int b;
+      };
+
+      struct Coord {
+          int x;
+          int y;
+      };
+
+      struct Event {
+          int type;
+          union {
+              struct Color color;
+              struct Coord coord;
+          } body;
+      };
+
+      int foo(int i, int j)
+      {
+          struct Event ev = { 0, { i, j, 0 } }; /* W1047 */
+          return ev.body.color.g;
+      }
+      """
+    When I successfully run `adlint W1047.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 20   | 5      |
+      | W1047 | 22   | 18     |
+      | W0100 | 22   | 18     |
+      | W0104 | 20   | 13     |
+      | W0104 | 20   | 20     |
+      | W0551 | 14   | 5      |
+      | W0628 | 20   | 5      |
+
+  Scenario: initializing array with all constant expressions
+    Given a target source named "W1047.c" with:
+      """
+      int foo(void)
+      {
+          int a[] = { 0, 1, 2 }; /* OK */
+          return a[1];
+      }
+      """
+    When I successfully run `adlint W1047.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0100 | 3    | 9      |
+      | W0628 | 1    | 5      |
+
+  Scenario: initializing struct with all constant expressions
+    Given a target source named "W1047.c" with:
+      """
+      struct Coord {
+          int x;
+          int y;
+          int z;
+      };
+
+      int foo(void)
+      {
+          struct Coord c = { 2, 1, 0 }; /* OK */
+          return c.y;
+      }
+      """
+    When I successfully run `adlint W1047.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 7    | 5      |
+      | W0100 | 9    | 18     |
+      | W0628 | 7    | 5      |
+
+  Scenario: initializing union with all constant expressions
+    Given a target source named "W1047.c" with:
+      """
+      struct Color {
+          int r;
+          int g;
+          int b;
+      };
+
+      struct Coord {
+          int x;
+          int y;
+      };
+
+      struct Event {
+          int type;
+          union {
+              struct Color color;
+              struct Coord coord;
+          } body;
+      };
+
+      int foo(void)
+      {
+          struct Event ev = { 0, { 2, 1, 0 } }; /* OK */
+          return ev.body.color.g;
+      }
+      """
+    When I successfully run `adlint W1047.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 20   | 5      |
+      | W0100 | 22   | 18     |
+      | W0551 | 14   | 5      |
+      | W0628 | 20   | 5      |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W1066.feature

@@ -53,6 +53,7 @@ Feature: W1066
       | W0093 | 4    | 21     |
       | W0570 | 6    | 21     |
       | W0572 | 6    | 21     |
+      | W0794 | 6    | 21     |
       | W0572 | 7    | 21     |
       | W0104 | 1    | 24     |
       | W0104 | 1    | 33     |

data/features/message_detection/W1067.feature

@@ -53,6 +53,7 @@ Feature: W1067
       | W0093 | 4    | 26     |
       | W0570 | 6    | 26     |
       | W0572 | 6    | 26     |
+      | W0794 | 6    | 26     |
       | W0572 | 7    | 26     |
       | W0104 | 1    | 24     |
       | W0104 | 1    | 33     |

data/features/message_detection/W1068.feature

@@ -53,6 +53,7 @@ Feature: W1068
       | W0093 | 4    | 26     |
       | W0570 | 6    | 26     |
       | W0572 | 6    | 26     |
+      | W0794 | 6    | 26     |
       | W0572 | 7    | 26     |
       | W0104 | 1    | 25     |
       | W0104 | 1    | 35     |

data/features/message_detection/W1069.feature

@@ -22,6 +22,7 @@ Feature: W1069
       | mesg  | line | column |
       | W1076 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W1069 | 3    | 5      |
       | W0628 | 1    | 12     |
@@ -48,6 +49,7 @@ Feature: W1069
       | mesg  | line | column |
       | W1076 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W1069 | 3    | 5      |
       | W0628 | 1    | 12     |
@@ -76,6 +78,7 @@ Feature: W1069
       | mesg  | line | column |
       | W1076 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W0628 | 1    | 12     |
 
@@ -95,6 +98,7 @@ Feature: W1069
       | mesg  | line | column |
       | W1076 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W0628 | 1    | 12     |
 
@@ -119,6 +123,7 @@ Feature: W1069
       | mesg  | line | column |
       | W1076 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W0628 | 1    | 12     |
 

data/features/message_detection/W1070.feature

@@ -20,6 +20,7 @@ Feature: W1070
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W1070 | 3    | 5      |
       | W0628 | 1    | 12     |
@@ -43,6 +44,7 @@ Feature: W1070
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W0003 | 3    | 5      |
       | W1070 | 3    | 5      |
@@ -69,6 +71,7 @@ Feature: W1070
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W9001 | 5    | 9      |
       | W9001 | 6    | 13     |
@@ -118,6 +121,7 @@ Feature: W1070
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W9001 | 5    | 9      |
       | W9001 | 6    | 13     |
@@ -145,6 +149,7 @@ Feature: W1070
     Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 1    | 12     |
+      | W1071 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W0628 | 1    | 12     |
 

data/features/message_detection/W1071.feature

@@ -0,0 +1,83 @@
+Feature: W1071
+
+  W1071 detects that a function has multiple termination points.
+
+  Scenario: explicit returns and implicit return
+    Given a target source named "W1071.c" with:
+      """
+      void foo(int i) /* W1071 */
+      {
+          if (i == 0) {
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint W1071.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0104 | 1    | 14     |
+      | W1071 | 1    | 6      |
+      | W0628 | 1    | 6      |
+
+  Scenario: explicit return and no implicit return
+    Given a target source named "W1071.c" with:
+      """
+      void foo(int i) /* OK */
+      {
+          switch (i) {
+          default:
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint W1071.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0104 | 1    | 14     |
+      | W0781 | 3    | 5      |
+      | W0628 | 1    | 6      |
+
+  Scenario: dead explicit return and implicit return
+    Given a target source named "W1071.c" with:
+      """
+      void foo(unsigned int ui) /* OK */
+      {
+          if (ui < 0U) {
+              return; /* dead-code */
+          }
+      }
+      """
+    When I successfully run `adlint W1071.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 6      |
+      | W0613 | 3    | 12     |
+      | W0610 | 3    | 12     |
+      | W0104 | 1    | 23     |
+      | W9001 | 4    | 9      |
+      | W0628 | 1    | 6      |
+
+  Scenario: explicit returns and no implicit return
+    Given a target source named "W1071.c" with:
+      """
+      int foo(int i) /* W1071 */
+      {
+          if (i == 0) {
+              return 0;
+          }
+          else {
+              return 1;
+          }
+      }
+      """
+    When I successfully run `adlint W1071.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0104 | 1    | 13     |
+      | W1071 | 1    | 5      |
+      | W0628 | 1    | 5      |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W1073.feature

@@ -41,7 +41,7 @@ Feature: W1073
     Given a target source named "W1073.c" with:
       """
       extern int bar(void);
-      extern void baz(void);
+      extern int baz(void);
       static void foo(void)
       {
           int i;
@@ -52,7 +52,7 @@ Feature: W1073
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0118 | 1    | 12     |
-      | W0118 | 2    | 13     |
+      | W0118 | 2    | 12     |
       | W1076 | 3    | 13     |
       | W0100 | 5    | 9      |
       | W1073 | 6    | 13     |
@@ -100,6 +100,7 @@ Feature: W1073
       | mesg  | line | column |
       | W0118 | 1    | 12     |
       | W1076 | 2    | 13     |
+      | W1071 | 2    | 13     |
       | W0629 | 2    | 13     |
       | W0628 | 2    | 13     |
 

data/features/message_detection/W9003.feature

@@ -18,8 +18,7 @@ Feature: W9003
       }
       """
     When I successfully run `adlint W9003.c` on noarch
-    Then the output should match with /8:.*:W9003/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W0118 | 4    | 13     |
       | W1076 | 6    | 13     |
@@ -41,8 +40,7 @@ Feature: W9003
       }
       """
     When I successfully run `adlint W9003.c` on noarch
-    Then the output should match with /7:.*:W9003/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W0118 | 3    | 13     |
       | W1076 | 5    | 13     |
@@ -64,8 +62,7 @@ Feature: W9003
       }
       """
     When I successfully run `adlint W9003.c` on noarch
-    Then the output should match with /7:.*:W9003/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W0118 | 3    | 13     |
       | W1076 | 5    | 13     |
@@ -81,8 +78,7 @@ Feature: W9003
       int i = RED; /* W9003 */
       """
     When I successfully run `adlint W9003.c` on noarch
-    Then the output should match with /2:.*:W9003/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W9003 | 2    | 9      |
       | W0117 | 2    | 5      |
@@ -94,8 +90,7 @@ Feature: W9003
       enum Color c = 1; /* W9003 */
       """
     When I successfully run `adlint W9003.c` on noarch
-    Then the output should match with /2:.*:W9003/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W9003 | 2    | 16     |
       | W0117 | 2    | 12     |
@@ -116,8 +111,7 @@ Feature: W9003
       }
       """
     When I successfully run `adlint W9003.c` on noarch
-    Then the output should match with /6:.*:W9003/
-    And the output should exactly match with:
+    Then the output should exactly match with:
       | mesg  | line | column |
       | W1076 | 3    | 12     |
       | W0727 | 6    | 20     |
@@ -125,6 +119,7 @@ Feature: W9003
       | W9003 | 6    | 18     |
       | W1060 | 6    | 18     |
       | W0104 | 3    | 27     |
+      | W1071 | 3    | 12     |
       | W0629 | 3    | 12     |
       | W0490 | 5    | 9      |
       | W0497 | 5    | 9      |

data/features/step_definitions/message_detection_steps.rb

@@ -1,41 +1,14 @@
 Given /^a target source named "(.*)" with:$/ do |src_name, content|
-  write_file(src_name, content + "\n")
-end
-
-Given /^expected messages of "(.*)" are:$/ do |src_name, mesg_table|
-  write_file("#{src_name}.expected", mesg_table.hashes.map { |row|
-    "#{row[:mesg]} #{row[:line]} #{row[:column]}" }.join("\n"))
+  create_src_file(src_name, content)
 end
 
 When /^I successfully run `(.*)` on noarch$/ do |abbrev_cmd|
-  write_file("noarch_traits.yml", NOARCH_TRAITS)
-  write_file("empty_pinit.h", "\n")
-  write_file("empty_cinit.h", "\n")
-  run_simple(unescape(abbrev_cmd + " -t noarch_traits.yml"))
-end
-
-Then /^the output should match with \/(.*)\/$/ do |pattern|
-  all_output.should =~ /#{pattern}/
-end
-
-Then /^the output should not match with \/(.*)\/$/ do |pattern|
-  all_output.should_not =~ /#{pattern}/
-end
-
-Then /^the output should match with expected messages of "(.*)"$/ do |src_name|
-  prep_for_fs_check do
-    expected = File.read("#{src_name}.expected").each_line.map { |line|
-      fields = line.chomp.split(" ")
-      /#{fields[1]}:#{fields[2]}:.*:#{fields[0]}/
-    }
-    all_output.each_line.zip(expected).each do |line, pattern|
-      line.should =~ pattern
-    end
-  end
+  cmd, src = abbrev_cmd.split
+  run_adlint(cmd, src, "-t", "noarch_traits.yml")
 end
 
 Then /^the output should exactly match with:$/ do |mesg_table|
-  all_output.each_line.zip(mesg_table.hashes).each do |line, row|
+  $all_output.each_line.zip(mesg_table.hashes).each do |line, row|
     if row
       line.should =~ /#{row[:line]}:#{row[:column]}:.*:#{row[:mesg]}/
     else