adlint 1.16.0 → 1.18.0

data/features/message_detection/W0697.feature

@@ -33,6 +33,7 @@ Feature: W0697
       | W0117 | 1    | 12     |
       | W0697 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0628 | 1    | 12     |
 
   Scenario: `return' statements are only in a `if-else-if' statements chain
@@ -53,6 +54,7 @@ Feature: W0697
       | W0117 | 1    | 12     |
       | W0697 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W1069 | 3    | 5      |
       | W0628 | 1    | 12     |
 
@@ -80,6 +82,7 @@ Feature: W0697
       | W0117 | 1    | 12     |
       | W0697 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0628 | 1    | 12     |
 
   Scenario: a `return' statement in non-void function
@@ -112,6 +115,7 @@ Feature: W0697
       | mesg  | line | column |
       | W0117 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0628 | 1    | 12     |
 
   Scenario: no implicit termination in `if-else-if' statements chain
@@ -133,6 +137,7 @@ Feature: W0697
       | mesg  | line | column |
       | W0117 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0628 | 1    | 12     |
 
   Scenario: no implicit termination with `switch' statement
@@ -158,6 +163,7 @@ Feature: W0697
       | mesg  | line | column |
       | W0117 | 1    | 12     |
       | W0104 | 1    | 21     |
+      | W1071 | 1    | 12     |
       | W0628 | 1    | 12     |
 
   Scenario: no implicit termination with `goto' statement

data/features/message_detection/W0705.feature

@@ -0,0 +1,350 @@
+Feature: W0705
+
+  W0705 detects that an array subscript may cause out of bound access of the
+  array object.
+
+  Scenario: array-subscript-expression with non-constant subscript may cause
+            OOB access in an initializer
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          if (i >= 0 && i < 5) {
+              int j = a[i + 1]; /* W0705 */
+              return j;
+          }
+          return i;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0705 | 6    | 21     |
+      | W0100 | 6    | 13     |
+      | W0104 | 3    | 13     |
+      | W1071 | 3    | 5      |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with non-constant subscript may cause
+            OOB access in rhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          int j = 0;
+          if (i >= 0 && i < 4) {
+              j = a[i - 1]; /* W0705 */
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0705 | 7    | 17     |
+      | W0104 | 3    | 13     |
+      | W0490 | 6    | 9      |
+      | W0499 | 6    | 9      |
+      | W0502 | 6    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with non-constant subscript may cause
+            OOB access in lhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          if (i >= 0 && i < 3) {
+              a[i + 3] = 0; /* W0705 */
+          }
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W0705 | 6    | 13     |
+      | W0104 | 3    | 14     |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 6      |
+
+  Scenario: indirection-expression with non-constant subscript may cause OOB
+            access in rhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          int j = 0;
+          if (i >= 0 && i < 5) {
+              j = *(a + i - 1); /* W0705 */
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 7    | 19     |
+      | W9003 | 7    | 23     |
+      | W0024 | 7    | 21     |
+      | W0705 | 7    | 14     |
+      | W0104 | 3    | 13     |
+      | W0490 | 6    | 9      |
+      | W0499 | 6    | 9      |
+      | W0502 | 6    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: indirection-expression with non-constant subscript may cause OOB
+            access in lhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          if (i >= 0 && i < 5) {
+              *(2 + a + i - 1) = 0; /* W0705 */
+          }
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W9003 | 6    | 11     |
+      | W0023 | 6    | 13     |
+      | W9003 | 6    | 19     |
+      | W9003 | 6    | 23     |
+      | W0024 | 6    | 21     |
+      | W0705 | 6    | 10     |
+      | W0104 | 3    | 14     |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 6      |
+
+  Scenario: array-subscript-expression with non-constant subscript must not
+            cuase OOB access in initializer
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          if (i > 0 && i <= 5) {
+              int j = a[i - 1]; /* OK */
+              return j;
+          }
+          return i;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0100 | 6    | 13     |
+      | W0104 | 3    | 13     |
+      | W1071 | 3    | 5      |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with non-constant subscript must not
+            cause OOB access in rhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          int j = 0;
+          if (i >= 0 && i < 4) {
+              j = a[i + 1]; /* OK */
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0104 | 3    | 13     |
+      | W0490 | 6    | 9      |
+      | W0499 | 6    | 9      |
+      | W0502 | 6    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with non-constant subscript must not
+            cause OOB access in lhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          if (i >= 0 && i < 3) {
+              a[i + 2] = 0; /* OK */
+          }
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W0104 | 3    | 14     |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 6      |
+
+  Scenario: indirection-expression with non-constant subscript must not cause
+            OOB access in rhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          int j = 0;
+          if (i > 0 && i < 6) {
+              j = *(a + i - 1); /* OK */
+          }
+          return j;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 7    | 19     |
+      | W9003 | 7    | 23     |
+      | W0024 | 7    | 21     |
+      | W0104 | 3    | 13     |
+      | W0490 | 6    | 9      |
+      | W0499 | 6    | 9      |
+      | W0502 | 6    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: indirection-expression with non-constant subscript must not cause
+            OOB access in lhs operand of an assignment-expression
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          if (i >= 0 && i < 5) {
+              *(2 + a + i - 2) = 0; /* OK */
+          }
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W9003 | 6    | 11     |
+      | W0023 | 6    | 13     |
+      | W9003 | 6    | 19     |
+      | W9003 | 6    | 23     |
+      | W0023 | 6    | 21     |
+      | W0104 | 3    | 14     |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 6      |
+
+  Scenario: indirection-expression with non-constant subscript should not cause
+            OOB access in an initializer
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          if (i >= 0 && i < 5) {
+              int j = *(a + i++); /* OK */
+              int k = *(a + i - 1); /* OK */
+              return j;
+          }
+          return i;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 6    | 24     |
+      | W9003 | 7    | 23     |
+      | W9003 | 7    | 27     |
+      | W0024 | 7    | 25     |
+      | W0100 | 6    | 13     |
+      | W0100 | 7    | 13     |
+      | W1071 | 3    | 5      |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: indirection-expression with non-constant subscript may and should
+            not cause OOB access in an initializer
+    Given a target source named "W0705.c" with:
+      """
+      extern int a[5];
+
+      int foo(int i)
+      {
+          if (i >= 0 && i < 5) {
+              int j = *(a + ++i); /* W0705 */
+              int k = *(a + i - 1); /* OK */
+              return j;
+          }
+          return i;
+      }
+      """
+    When I successfully run `adlint W0705.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 6    | 23     |
+      | W0705 | 6    | 18     |
+      | W9003 | 7    | 23     |
+      | W9003 | 7    | 27     |
+      | W0024 | 7    | 25     |
+      | W0100 | 6    | 13     |
+      | W0100 | 7    | 13     |
+      | W1071 | 3    | 5      |
+      | W0490 | 5    | 9      |
+      | W0499 | 5    | 9      |
+      | W0502 | 5    | 9      |
+      | W0628 | 3    | 5      |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W0707.feature

@@ -0,0 +1,223 @@
+Feature: W0707
+
+  W0707 detects that a constant-expression array subscript must cause out of
+  bound access of the array object.
+
+  Scenario: array-subscript-expression with constant subscript must cause OOB
+            access in an initializer
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      int foo(void)
+      {
+          int i = a[5]; /* W0707 */
+          return i;
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0707 | 5    | 15     |
+      | W0100 | 5    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with constant subscript must cause OOB
+            access in rhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      int foo(void)
+      {
+          int i = 0;
+          i = a[-1]; /* W0707 */
+          return i;
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0707 | 6    | 11     |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with constant subscript must cause OOB
+            access in lhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          a[5] = i; /* W0707 */
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W0707 | 5    | 7      |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 6      |
+
+  Scenario: indirection-expression with constant subscript must cause OOB
+            access in rhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      int foo(void)
+      {
+          int i = 0;
+          i = *(a + 5 - 6); /* W0707 */
+          return i;
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 6    | 15     |
+      | W0023 | 6    | 13     |
+      | W9003 | 6    | 19     |
+      | W0023 | 6    | 17     |
+      | W0707 | 6    | 10     |
+      | W0628 | 3    | 5      |
+
+  Scenario: indirection-expression with constant subscript must cause OOB
+            access in lhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          *(a - 1 + 6) = i; /* W0707 */
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W9003 | 5    | 11     |
+      | W0024 | 5    | 9      |
+      | W9003 | 5    | 15     |
+      | W0023 | 5    | 13     |
+      | W0707 | 5    | 6      |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 6      |
+
+  Scenario: array-subscript-expression with constant subscript must not cause
+            OOB access in an initializer
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      int foo(void)
+      {
+          int i = a[3]; /* OK */
+          return i;
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0100 | 5    | 9      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with constant subscript must not cause
+            OOB access in rhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      int foo(void)
+      {
+          int i = 0;
+          i = a[0]; /* OK */
+          return i;
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W0628 | 3    | 5      |
+
+  Scenario: array-subscript-expression with constant subscript must not cause
+            OOB access in lhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          a[4] = i; /* OK */
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 6      |
+
+  Scenario: indirection-expression with constant subscript must not cause OOB
+            access in rhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      int foo(void)
+      {
+          int i = 0;
+          i = *(a - 2 + 3); /* OK */
+          return i;
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 5      |
+      | W9003 | 6    | 15     |
+      | W0023 | 6    | 13     |
+      | W9003 | 6    | 19     |
+      | W0023 | 6    | 17     |
+      | W0628 | 3    | 5      |
+
+  Scenario: indirection-expression with constant subscript must not cause OOB
+            access in lhs operand of an assignment-expression
+    Given a target source named "W0707.c" with:
+      """
+      extern int a[5];
+
+      void foo(int i)
+      {
+          *(a + 4 - 1) = i; /* OK */
+      }
+      """
+    When I successfully run `adlint W0707.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0117 | 3    | 6      |
+      | W9003 | 5    | 11     |
+      | W0023 | 5    | 9      |
+      | W9003 | 5    | 15     |
+      | W0024 | 5    | 13     |
+      | W0104 | 3    | 14     |
+      | W0628 | 3    | 6      |
+
+# vim:ts=2:sw=2:sts=2:et: