activeadmin 0.6.6 → 1.0.0.pre1

data/spec/unit/views/components/table_for_spec.rb

@@ -1,15 +1,101 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ActiveAdmin::Views::TableFor do
   describe "creating with the dsl" do
 
     let(:collection) do
-      [Post.new(:title => "First Post"), Post.new(:title => "Second Post"), Post.new(:title => "Third Post")]
+      [Post.new(title: "First Post", starred: true), Post.new(title: "Second Post"), Post.new(title: "Third Post", starred: false)]
     end
 
-    let(:assigns){ { :collection => collection } }
+    let(:assigns){ { collection: collection } }
     let(:helpers){ mock_action_view }
 
+    context "when creating a column using symbol argument" do
+      let(:table) do
+        render_arbre_component assigns, helpers do
+          table_for(collection, :title)
+        end
+      end
+
+      it "should create a table header based on the symbol" do
+        expect(table.find_by_tag("th").first.content).to eq "Title"
+      end
+
+      it "should create a table row for each element in the collection" do
+        expect(table.find_by_tag("tr").size).to eq 4 # 1 for head, 3 for rows
+      end
+
+      ["First Post", "Second Post", "Third Post"].each_with_index do |content, index|
+        it "should create a cell with #{content}" do
+          expect(table.find_by_tag("td")[index].content).to eq content
+        end
+      end
+    end
+
+    context "when creating many columns using symbol arguments" do
+      let(:table) do
+        render_arbre_component assigns, helpers do
+          table_for(collection, :title, :created_at)
+        end
+      end
+
+      it "should create a table header based on the symbol" do
+        expect(table.find_by_tag("th").first.content).to eq "Title"
+        expect(table.find_by_tag("th").last.content).to eq "Created At"
+      end
+
+      it "should add a class to each table header based on the col name" do
+        expect(table.find_by_tag("th").first.class_list.to_a.join(' ')).to eq "col col-title"
+        expect(table.find_by_tag("th").last.class_list.to_a.join(' ')).to eq "col col-created_at"
+      end
+
+      it "should create a table row for each element in the collection" do
+        expect(table.find_by_tag("tr").size).to eq 4 # 1 for head, 3 for rows
+      end
+
+      it "should create a cell for each column" do
+        expect(table.find_by_tag("td").size).to eq 6
+      end
+
+      it "should add a class for each cell based on the col name" do
+        expect(table.find_by_tag("td").first.class_list.to_a.join(' ')).to eq "col col-title"
+        expect(table.find_by_tag("td").last.class_list.to_a.join(' ')).to eq "col col-created_at"
+      end
+    end
+
+    context "when creating a column using symbol arguments and another using block" do
+      let(:table) do
+        render_arbre_component assigns, helpers do
+          table_for(collection, :title) do
+            column :created_at
+          end
+        end
+      end
+
+      it "should create a table header based on the symbol" do
+        expect(table.find_by_tag("th").first.content).to eq "Title"
+        expect(table.find_by_tag("th").last.content).to eq "Created At"
+      end
+
+      it "should add a class to each table header based on the col name" do
+        expect(table.find_by_tag("th").first.class_list.to_a.join(' ')).to eq "col col-title"
+        expect(table.find_by_tag("th").last.class_list.to_a.join(' ')).to eq "col col-created_at"
+      end
+
+      it "should create a table row for each element in the collection" do
+        expect(table.find_by_tag("tr").size).to eq 4 # 1 for head, 3 for rows
+      end
+
+      it "should create a cell for each column" do
+        expect(table.find_by_tag("td").size).to eq 6
+      end
+
+      it "should add a class for each cell based on the col name" do
+        expect(table.find_by_tag("td").first.class_list.to_a.join(' ')).to eq "col col-title"
+        expect(table.find_by_tag("td").last.class_list.to_a.join(' ')).to eq "col col-created_at"
+      end
+    end
+
     context "when creating a column with a symbol" do
       let(:table) do
         render_arbre_component assigns, helpers do
@@ -20,16 +106,16 @@ describe ActiveAdmin::Views::TableFor do
       end
 
       it "should create a table header based on the symbol" do
-        table.find_by_tag("th").first.content.should == "Title"
+        expect(table.find_by_tag("th").first.content).to eq "Title"
       end
 
       it "should create a table row for each element in the collection" do
-        table.find_by_tag("tr").size.should == 4 # 1 for head, 3 for rows
+        expect(table.find_by_tag("tr").size).to eq 4 # 1 for head, 3 for rows
       end
 
       ["First Post", "Second Post", "Third Post"].each_with_index do |content, index|
         it "should create a cell with #{content}" do
-          table.find_by_tag("td")[index].content.should == content
+          expect(table.find_by_tag("td")[index].content).to eq content
         end
       end
     end
@@ -45,26 +131,26 @@ describe ActiveAdmin::Views::TableFor do
       end
 
       it "should create a table header based on the symbol" do
-        table.find_by_tag("th").first.content.should == "Title"
-        table.find_by_tag("th").last.content.should == "Created At"
+        expect(table.find_by_tag("th").first.content).to eq "Title"
+        expect(table.find_by_tag("th").last.content).to eq "Created At"
       end
 
       it "should add a class to each table header based on the col name" do
-        table.find_by_tag("th").first.class_list.should include("title")
-        table.find_by_tag("th").last.class_list.should  include("created_at")
+        expect(table.find_by_tag("th").first.class_list.to_a.join(' ')).to eq "col col-title"
+        expect(table.find_by_tag("th").last.class_list.to_a.join(' ')).to eq "col col-created_at"
       end
 
       it "should create a table row for each element in the collection" do
-        table.find_by_tag("tr").size.should == 4 # 1 for head, 3 for rows
+        expect(table.find_by_tag("tr").size).to eq 4 # 1 for head, 3 for rows
       end
 
       it "should create a cell for each column" do
-        table.find_by_tag("td").size.should == 6
+        expect(table.find_by_tag("td").size).to eq 6
       end
 
       it "should add a class for each cell based on the col name" do
-        table.find_by_tag("td").first.class_list.should include("title")
-        table.find_by_tag("td").last.class_list.should  include("created_at")
+        expect(table.find_by_tag("td").first.class_list.to_a.join(' ')).to eq "col col-title"
+        expect(table.find_by_tag("td").last.class_list.to_a.join(' ')).to eq "col col-created_at"
       end
     end
 
@@ -80,14 +166,14 @@ describe ActiveAdmin::Views::TableFor do
       end
 
       it "should add a class to each table header based on the col name" do
-        table.find_by_tag("th").first.class_list.should include("title")
+        expect(table.find_by_tag("th").first.class_list).to include("col-title")
       end
 
       [ "<span>First Post</span>",
         "<span>Second Post</span>",
         "<span>Third Post</span>" ].each_with_index do |content, index|
         it "should create a cell with #{content}" do
-          table.find_by_tag("td")[index].content.strip.should == content
+          expect(table.find_by_tag("td")[index].content.strip).to eq content
         end
       end
     end
@@ -106,7 +192,7 @@ describe ActiveAdmin::Views::TableFor do
 
       3.times do |index|
         it "should create a cell with multiple elements in row #{index}" do
-          table.find_by_tag("td")[index].find_by_tag("span").size.should == 2
+          expect(table.find_by_tag("td")[index].find_by_tag("span").size).to eq 2
         end
       end
     end
@@ -117,25 +203,103 @@ describe ActiveAdmin::Views::TableFor do
         render_arbre_component assigns, helpers do
           table_for(collection) do
             column "My Custom Title", :title
-            column :created_at , :class=>"datetime"
+            column :created_at , class:"datetime"
           end
         end
       end
 
 
       it "should add a class to each table header  based on class option or the col name" do
-        table.find_by_tag("th").first.class_list.should  include("my_custom_title")
-        table.find_by_tag("th").last.class_list.should  include("datetime")
+        expect(table.find_by_tag("th").first.class_list.to_a.join(' ')).to eq "col col-my_custom_title"
+        expect(table.find_by_tag("th").last.class_list.to_a.join(' ')).to eq "col datetime"
       end
 
       it "should add a class to each cell based  on class option or the col name" do
-        table.find_by_tag("td").first.class_list.should include("my_custom_title")
-        table.find_by_tag("td").last.class_list.should  include("datetime")
+        expect(table.find_by_tag("td").first.class_list.to_a.join(' ')).to eq "col col-my_custom_title"
+        expect(table.find_by_tag("td").last.class_list.to_a.join(' ')).to eq "col datetime"
       end
+    end
 
+    context "when using a single record instead of a collection" do
+      let(:table) do
+        render_arbre_component nil, helpers do
+          table_for Post.new do
+            column :title
+          end
+        end
+      end
+      it "should render" do
+        expect(table.find_by_tag("th").first.content).to eq "Title"
+      end
+    end
 
+    context "when using a single Hash" do
+      let(:table) do
+        render_arbre_component nil, helpers do
+          table_for foo: 1, bar: 2 do
+            column :foo
+            column :bar
+          end
+        end
+      end
+      it "should render" do
+        expect(table.find_by_tag("th")[0].content).to eq "Foo"
+        expect(table.find_by_tag("th")[1].content).to eq "Bar"
+        expect(table.find_by_tag("td")[0].content).to eq "1"
+        expect(table.find_by_tag("td")[1].content).to eq "2"
+      end
+    end
+
+    context "when using an Array of Hashes" do
+      let(:table) do
+        render_arbre_component nil, helpers do
+          table_for [{foo: 1},{foo: 2}] do
+            column :foo
+          end
+        end
+      end
+      it "should render" do
+        expect(table.find_by_tag("th")[0].content).to eq "Foo"
+        expect(table.find_by_tag("td")[0].content).to eq "1"
+        expect(table.find_by_tag("td")[1].content).to eq "2"
+      end
     end
 
+    context "when record attribute is boolean" do
+      let(:table) do
+        render_arbre_component assigns, helpers do
+          table_for(collection) do
+            column :starred
+          end
+        end
+      end
+
+      it "should render boolean attribute within status tag" do
+        expect(table.find_by_tag("span").first.class_list.to_a.join(' ')).to eq "status_tag yes"
+        expect(table.find_by_tag("span").first.content).to eq "Yes"
+        expect(table.find_by_tag("span").last.class_list.to_a.join(' ')).to eq "status_tag no"
+        expect(table.find_by_tag("span").last.content).to eq "No"
+      end
+    end
+
+    context 'when row_class' do
+      let(:table) do
+        render_arbre_component assigns, helpers do
+          table_for(collection, row_class: -> e { 'starred' if e.starred }) do
+            column :starred
+          end
+        end
+      end
+
+      it 'should render boolean attribute within status tag' do
+        trs = table.find_by_tag('tr')
+        expect(trs.size).to eq 4
+        expect(trs.first.class_list.to_a.join(' ')).to eq ''
+        expect(trs.second.class_list.to_a.join(' ')).to eq 'odd starred'
+        expect(trs.third.class_list.to_a.join(' ')).to eq 'even'
+        expect(trs.fourth.class_list.to_a.join(' ')).to eq 'odd'
+      end
+    end
 
   end
 
@@ -149,34 +313,72 @@ describe ActiveAdmin::Views::TableFor do
 
     context "when default" do
       let(:table_column){ build_column(:username) }
-      it { should be_sortable }
-      its(:sort_key){ should == "username" }
+      it { is_expected.to be_sortable }
+
+      describe '#sort_key' do
+        subject { super().sort_key }
+        it{ is_expected.to eq("username") }
+      end
     end
 
     context "when a block given with no sort key" do
       let(:table_column){ build_column("Username"){ } }
-      it { should_not be_sortable }
+      it { is_expected.to be_sortable }
     end
 
     context "when a block given with a sort key" do
-      let(:table_column){ build_column("Username", :sortable => :username){ } }
-      it { should be_sortable }
-      its(:sort_key){ should == "username" }
+      let(:table_column){ build_column("Username", sortable: :username){ } }
+      it { is_expected.to be_sortable }
+
+      describe '#sort_key' do
+        subject { super().sort_key }
+        it{ is_expected.to eq("username") }
+      end
+    end
+
+    context 'when a block given with virtual attribute and no sort key' do
+      let(:table_column) { build_column(:virtual, nil, Post) { } }
+      it { is_expected.not_to be_sortable }
+    end
+
+    context 'when symbol given as a data column should be sortable' do
+      let(:table_column){ build_column('Username column', :username) }
+      it { is_expected.to be_sortable }
+
+      describe '#sort_key' do
+        subject { super().sort_key }
+        it { is_expected.to eq 'username' }
+      end
     end
 
-    context "when :sortable => false with a symbol" do
-      let(:table_column){ build_column(:username, :sortable => false) }
-      it { should_not be_sortable }
+    context 'when sortable: true with a symbol and string' do
+      let(:table_column){ build_column('Username column', :username, sortable: true) }
+      it { is_expected.to be_sortable }
+
+      describe '#sort_key' do
+        subject { super().sort_key }
+        it { is_expected.to eq 'username' }
+      end
     end
 
-    context "when :sortable => false with a symbol and string" do
-      let(:table_column){ build_column("Username", :username, :sortable => false) }
-      it { should_not be_sortable }
+    context "when sortable: false with a symbol" do
+      let(:table_column){ build_column(:username, sortable: false) }
+      it { is_expected.not_to be_sortable }
+    end
+
+    context "when sortable: false with a symbol and string" do
+      let(:table_column){ build_column("Username", :username, sortable: false) }
+      it { is_expected.not_to be_sortable }
     end
 
     context "when :sortable column is an association" do
       let(:table_column){ build_column("Category", :category, Post) }
-      it { should_not be_sortable }
+      it { is_expected.not_to be_sortable }
+    end
+
+    context 'when :sortable column is an association and block given' do
+      let(:table_column){ build_column('Category', :category, Post) { } }
+      it { is_expected.not_to be_sortable }
     end
   end
 end

data/spec/unit/views/components/tabs_spec.rb

@@ -0,0 +1,39 @@
+require 'rails_helper'
+
+describe ActiveAdmin::Views::Tabs do
+  describe "creating with the dsl" do
+    context "when creating tabs with a symbol" do
+      let(:tabs) do
+        render_arbre_component do
+          tabs do
+            tab :overview
+          end
+        end
+      end
+
+      it "should create a tab navigation bar based on the symbol" do
+        expect(tabs.find_by_tag('li').first.content).to include "Overview"
+      end
+    end
+
+    context "when creating a tab with a block" do
+      let(:tabs) do
+        render_arbre_component do
+          tabs do
+            tab :overview do
+              span 'tab 1'
+            end
+          end
+        end
+      end
+
+      it "should create a tab navigation bar based on the symbol" do
+        expect(tabs.find_by_tag('li').first.content).to include "Overview"
+      end
+
+      it "should create a tab with a span inside of it" do
+        expect(tabs.find_by_tag('span').first.content).to eq('tab 1')
+      end
+    end
+  end
+end

data/spec/unit/views/components/unsupported_browser_spec.rb

@@ -0,0 +1,47 @@
+require 'rails_helper'
+
+describe ActiveAdmin::Views::UnsupportedBrowser do
+
+  let(:helpers){ mock_action_view }
+  let(:namespace) { double :namespace, unsupported_browser_matcher: /MSIE [1-8]\.0/ }
+  let(:component) { double :unsupported_browser_component }
+  let(:view_factory) { double :view_factory, unsupported_browser: component }
+  let(:base) { ActiveAdmin::Views::Pages::Base.new }
+
+  def build_panel
+    render_arbre_component({}, helpers) do
+      insert_tag ActiveAdmin::Views::UnsupportedBrowser
+    end
+  end
+
+  it "should render the panel" do
+    expect(I18n).to receive(:t).and_return("headline", "recommendation" ,"turn_off_compatibility_view")
+    expect(build_panel.content.gsub(/\s+/, "")).to eq "<h1>headline</h1><p>recommendation</p><p>turn_off_compatibility_view</p>"
+  end
+
+  describe "ActiveAdmin::Views::Pages::Base behavior" do
+    context "when the reqex match" do
+
+      it "should build the unsupported browser panel" do
+        expect(base).to receive(:active_admin_namespace).and_return(namespace)
+        expect(base).to receive(:env).and_return({ "HTTP_USER_AGENT" => "Mozilla/5.0 (compatible; MSIE 7.0; Windows NT 6.2; Trident/6.0)" })
+        expect(base).to receive(:view_factory).and_return(view_factory)
+        expect(base).to receive(:insert_tag).with(component)
+        base.send(:build_unsupported_browser)
+      end
+
+    end
+
+    context "when the regex not match" do
+
+      it "should not build the unsupported browser panel" do
+        expect(base).to receive(:active_admin_namespace).and_return(namespace)
+        expect(base).to receive(:env).and_return({ "HTTP_USER_AGENT" => "Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0)" })
+        expect(base).to receive(:insert_tag).never
+        base.send(:build_unsupported_browser)
+      end
+
+    end
+  end
+
+end