activeadmin 0.6.6 → 1.0.0.pre1

data/spec/unit/resource/page_presenters_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ActiveAdmin::Resource::PagePresenters do
 
@@ -6,19 +6,19 @@ describe ActiveAdmin::Resource::PagePresenters do
   let(:resource){ namespace.register(Post) }
 
   it "should have an empty set of configs on initialize" do
-    resource.page_presenters.should == {}
+    expect(resource.page_presenters).to eq ({})
   end
 
   it "should add a show page presenter" do
     page_presenter = ActiveAdmin::PagePresenter.new
     resource.set_page_presenter(:show, page_presenter)
-    resource.page_presenters[:show].should == page_presenter
+    expect(resource.page_presenters[:show]).to eq page_presenter
   end
 
   it "should add an index page presenter" do
-    page_presenter = ActiveAdmin::PagePresenter.new({:as => :table})
+    page_presenter = ActiveAdmin::PagePresenter.new({as: :table})
     resource.set_page_presenter(:index, page_presenter)
-    resource.page_presenters[:index].default.should == page_presenter
+    expect(resource.page_presenters[:index].default).to eq page_presenter
   end
 
   describe "#get_page_presenter" do
@@ -26,17 +26,17 @@ describe ActiveAdmin::Resource::PagePresenters do
     it "should return a page config when set" do
       page_presenter = ActiveAdmin::PagePresenter.new
       resource.set_page_presenter(:index, page_presenter)
-      resource.get_page_presenter(:index).should == page_presenter
+      expect(resource.get_page_presenter(:index)).to eq page_presenter
     end
 
     it "should return a specific index page config when set" do
       page_presenter = ActiveAdmin::PagePresenter.new
       resource.set_page_presenter(:index, page_presenter)
-      resource.get_page_presenter(:index, "table").should == page_presenter
+      expect(resource.get_page_presenter(:index, "table")).to eq page_presenter
     end
 
     it "should return nil when no page config set" do
-      resource.get_page_presenter(:index).should == nil
+      expect(resource.get_page_presenter(:index)).to eq nil
     end
 
   end

data/spec/unit/resource/pagination_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 module ActiveAdmin
   describe Resource, "Pagination" do
@@ -14,24 +14,24 @@ module ActiveAdmin
 
     describe "#paginate" do
       it "should default to true" do
-        config.paginate.should == true
+        expect(config.paginate).to eq true
       end
 
       it "should be settable to false" do
         config.paginate = false
-        config.paginate.should == false
+        expect(config.paginate).to eq false
       end
     end
 
     describe "#per_page" do
       it "should default to namespace.default_per_page" do
-        namespace.should_receive(:default_per_page).and_return(5)
-        config.per_page.should == 5
+        expect(namespace).to receive(:default_per_page).and_return(5)
+        expect(config.per_page).to eq 5
       end
 
       it "should be settable" do
         config.per_page = 5
-        config.per_page.should == 5
+        expect(config.per_page).to eq 5
       end
     end
   end

data/spec/unit/resource/routes_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper' 
+require 'rails_helper' 
 
 module ActiveAdmin
   describe Resource::Routes do
@@ -10,27 +10,27 @@ module ActiveAdmin
         let(:category) { Category.new { |c| c.id = 123 } }
 
         it "should return the route prefix" do
-          config.route_prefix.should eq 'admin'
+          expect(config.route_prefix).to eq 'admin'
         end
 
         it "should return the route collection path" do
-          config.route_collection_path.should eq '/admin/categories'
+          expect(config.route_collection_path).to eq '/admin/categories'
         end
 
         it "should return the route instance path" do
-          config.route_instance_path(category).should eq '/admin/categories/123'
+          expect(config.route_instance_path(category)).to eq '/admin/categories/123'
         end
       end
 
       context "when in the root namespace" do
-        let!(:config) { ActiveAdmin.register Category, :namespace => false }
+        let!(:config) { ActiveAdmin.register Category, namespace: false }
         it "should have a nil route_prefix" do
-          config.route_prefix.should be_nil
+          expect(config.route_prefix).to be_nil
         end
 
         it "should generate a correct route" do
           reload_routes!
-          config.route_collection_path.should == "/categories"
+          expect(config.route_collection_path).to eq "/categories"
         end
       end
 
@@ -40,7 +40,7 @@ module ActiveAdmin
         before{ reload_routes! }
 
         it "should return the plural route with _index" do
-          config.route_collection_path.should == "/admin/news"
+          expect(config.route_collection_path).to eq "/admin/news"
         end
       end
 
@@ -61,11 +61,11 @@ module ActiveAdmin
         before{ reload_routes! }
 
         it "should nest the collection path" do
-          config.route_collection_path(category_id: 1).should == "/admin/categories/1/posts"
+          expect(config.route_collection_path(category_id: 1)).to eq "/admin/categories/1/posts"
         end
 
         it "should nest the instance path" do
-          config.route_instance_path(post).should == "/admin/categories/1/posts/3"
+          expect(config.route_instance_path(post)).to eq "/admin/categories/1/posts/3"
         end
       end
     end

data/spec/unit/resource/scopes_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 module ActiveAdmin
   describe Resource, "Scopes" do
@@ -16,26 +16,33 @@ module ActiveAdmin
 
       it "should add a scope" do
         config.scope :published
-        config.scopes.first.should be_a(ActiveAdmin::Scope)
-        config.scopes.first.name.should == "Published"
+        expect(config.scopes.first).to be_a(ActiveAdmin::Scope)
+        expect(config.scopes.first.name).to eq "Published"
       end
 
       it "should retrive a scope by its id" do
         config.scope :published
-        config.get_scope_by_id(:published).name.should == "Published"
+        expect(config.get_scope_by_id(:published).name).to eq "Published"
+      end
+
+      it "should retrieve a string scope with spaces by its id without conflicts" do
+        aspace_1 = config.scope "a space"
+        aspace_2 = config.scope "as pace"
+        expect(config.get_scope_by_id(aspace_1.id).name).to eq "a space"
+        expect(config.get_scope_by_id(aspace_2.id).name).to eq "as pace"
       end
 
       it "should not add a scope with the same name twice" do
         config.scope :published
         config.scope :published
-        config.scopes.size.should == 1
+        expect(config.scopes.size).to eq 1
       end
 
       it "should update a scope with the same id" do
         config.scope :published
-        config.scopes.first.scope_block.should be_nil
+        expect(config.scopes.first.scope_block).to be_nil
         config.scope(:published){  }
-        config.scopes.first.scope_block.should_not be_nil
+        expect(config.scopes.first.scope_block).to_not be_nil
       end
 
     end

data/spec/unit/resource/sidebars_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ActiveAdmin::Resource::Sidebars do
 
@@ -17,15 +17,15 @@ describe ActiveAdmin::Resource::Sidebars do
     end
 
     it "should add a sidebar section" do
-      resource.should have(1).sidebar_sections
+      expect(resource.sidebar_sections.size).to eq(1)
     end
 
   end
 
   describe "retrieving sections for a controller action" do
 
-    let(:only_index){ ActiveAdmin::SidebarSection.new(:help, :only => :index) }
-    let(:only_show){ ActiveAdmin::SidebarSection.new(:help, :only => :show) }
+    let(:only_index){ ActiveAdmin::SidebarSection.new(:help, only: :index) }
+    let(:only_show){ ActiveAdmin::SidebarSection.new(:help, only: :show) }
 
     before do
       resource.clear_sidebar_sections!
@@ -34,8 +34,8 @@ describe ActiveAdmin::Resource::Sidebars do
     end
 
     it "should only return the relevant action items" do
-      resource.should have(2).sidebar_sections
-      resource.sidebar_sections_for("index").should == [only_index]
+      expect(resource.sidebar_sections.size).to eq(2)
+      expect(resource.sidebar_sections_for("index")).to eq [only_index]
     end
 
   end

data/spec/unit/resource_collection_spec.rb

@@ -1,60 +1,53 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'active_admin/resource_collection'
 
 describe ActiveAdmin::ResourceCollection do
   let(:application) { ActiveAdmin::Application.new }
   let(:namespace)   { ActiveAdmin::Namespace.new application, :admin }
   let(:collection)  { ActiveAdmin::ResourceCollection.new }
+  let(:resource)    { double resource_name: "MyResource" }
 
-  it { should respond_to :[]       }
-  it { should respond_to :add      }
-  it { should respond_to :each     }
-  it { should respond_to :has_key? }
-  it { should respond_to :keys     }
-  it { should respond_to :values   }
-  it { should respond_to :size     }
-  it { should respond_to :to_a     }
+  it { is_expected.to respond_to :[]       }
+  it { is_expected.to respond_to :add      }
+  it { is_expected.to respond_to :each     }
+  it { is_expected.to respond_to :has_key? }
+  it { is_expected.to respond_to :keys     }
+  it { is_expected.to respond_to :values   }
+  it { is_expected.to respond_to :size     }
+  it { is_expected.to respond_to :to_a     }
 
   it "should have no resources when new" do
-    collection.should be_empty
+    expect(collection).to be_empty
   end
 
   it "should be enumerable" do
-    resource = mock :resource_name => "MyResource"
     collection.add(resource)
-    collection.each{ |r| r.should == resource }
+    collection.each{ |r| expect(r).to eq resource }
   end
 
   it "should return the available keys" do
-    resource = mock :resource_name => "MyResource"
     collection.add resource
-    collection.keys.should == [resource.resource_name]
+    expect(collection.keys).to eq [resource.resource_name]
   end
 
   describe "#add" do
-    let(:resource){ mock :resource_name => "MyResource" }
-
     it "should return the resource" do
-      collection.add(resource).should == resource
+      expect(collection.add(resource)).to eq resource
     end
 
     it "should add a new resource" do
       collection.add(resource)
-      collection.values.should == [resource]
+      expect(collection.values).to eq [resource]
     end
 
     it "should be available by name" do
       collection.add(resource)
-      collection[resource.resource_name].should == resource
+      expect(collection[resource.resource_name]).to eq resource
     end
-  end
-
-  describe "adding a new resource when the key already exists" do
-    let(:resource){ mock :resource_name => "MyResource" }
 
-    it "should not add a new resource" do
+    it "shouldn't happen twice" do
       collection.add(resource); collection.add(resource)
-      collection.values.should == [resource]
+      expect(collection.values).to eq [resource]
     end
 
     it "shouldn't allow a resource name mismatch to occur" do
@@ -78,13 +71,13 @@ describe ActiveAdmin::ResourceCollection do
       it "when the renamed version is added first" do
         collection.add renamed
         collection.add resource
-        collection.values.should include(resource, renamed)
+        expect(collection.values).to include(resource, renamed)
       end
 
       it "when the renamed version is added last" do
         collection.add resource
         collection.add renamed
-        collection.values.should include(resource, renamed)
+        expect(collection.values).to include(resource, renamed)
       end
     end
   end
@@ -104,27 +97,27 @@ describe ActiveAdmin::ResourceCollection do
       end
 
       it "should find resource by class" do
-        collection[resource_class].should == resource
+        expect(collection[resource_class]).to eq resource
       end
 
       it "should find resource by class string" do
-        collection[resource_class.to_s].should == resource
+        expect(collection[resource_class.to_s]).to eq resource
       end
 
       it "should find inherited resource by class" do
-        collection[inherited_resource_class].should == inherited_resource
+        expect(collection[inherited_resource_class]).to eq inherited_resource
       end
 
       it "should find inherited resource by class string" do
-        collection[inherited_resource_class.to_s].should == inherited_resource
+        expect(collection[inherited_resource_class.to_s]).to eq inherited_resource
       end
 
       it "should return nil when the resource_class does not respond to base_class and it is not in the collection" do
-        collection[mock].should == nil
+        expect(collection[double]).to eq nil
       end
 
       it "should return nil when a resource class is NOT in the collection" do
-        collection[unregistered_class].should == nil
+        expect(collection[unregistered_class]).to eq nil
       end
     end
 
@@ -134,7 +127,7 @@ describe ActiveAdmin::ResourceCollection do
       end
 
       it "should find resource by inherited class" do
-        collection[inherited_resource_class].should == resource
+        expect(collection[inherited_resource_class]).to eq resource
       end
     end
 
@@ -147,19 +140,19 @@ describe ActiveAdmin::ResourceCollection do
       end
 
       it "should find resource by class" do
-        collection[resource_class].should == renamed_resource
+        expect(collection[resource_class]).to eq renamed_resource
       end
 
       it "should find resource by class string" do
-        collection[resource_class.to_s].should == renamed_resource
+        expect(collection[resource_class.to_s]).to eq renamed_resource
       end
 
       it "should find resource by name" do
-        collection[name].should == renamed_resource
+        expect(collection[name]).to eq renamed_resource
       end
     end
   end
 
-  pending "specs for subclasses of Page and Resource"
+  skip "specs for subclasses of Page and Resource"
 
 end

data/spec/unit/resource_controller/data_access_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ActiveAdmin::ResourceController::DataAccess do
   let(:params) do
@@ -7,40 +7,40 @@ describe ActiveAdmin::ResourceController::DataAccess do
 
   let(:controller) do
     rc = Admin::PostsController.new
-    rc.stub!(:params) do
+    allow(rc).to receive(:params) do
       params
     end
     rc
   end
 
   describe "searching" do
-    let(:params){ {:q => {} }}
-
-    it "should call the metasearch method" do
-      chain = mock("ChainObj")
-      chain.should_receive(:metasearch).with(params[:q]).once.and_return(Post.search)
+    let(:params) {{ q: {} }}
+    it "should call the search method" do
+      chain = double "ChainObj"
+      expect(chain).to receive(:ransack).with(params[:q]).once.and_return(Post.ransack)
       controller.send :apply_filtering, chain
     end
-
   end
 
   describe "sorting" do
 
-    context "for table columns" do
-      let(:params){ {:order => "id_asc" }}
-      it "should prepend the table name" do
-        chain = mock("ChainObj")
-        chain.should_receive(:reorder).with("\"posts\".\"id\" asc").once.and_return(Post.search)
+    context "valid clause" do
+      let(:params) {{ order: "id_asc" }}
+
+      it "reorders chain" do
+        chain = double "ChainObj"
+        expect(chain).to receive(:reorder).with('"posts"."id" asc').once.and_return(Post.search)
         controller.send :apply_sorting, chain
       end
     end
 
-    context "for virtual columns" do
-      let(:params){ {:order => "virtual_id_asc" }}
-      it "should not prepend the table name" do
-        chain = mock("ChainObj")
-        chain.should_receive(:reorder).with("\"virtual_id\" asc").once.and_return(Post.search)
-        controller.send :apply_sorting, chain
+    context "invalid clause" do
+      let(:params) {{ order: "_asc" }}
+
+      it "returns chain untouched" do
+        chain = double "ChainObj"
+        expect(chain).not_to receive(:reorder)
+        expect(controller.send(:apply_sorting, chain)).to eq chain
       end
     end
 
@@ -50,25 +50,91 @@ describe ActiveAdmin::ResourceController::DataAccess do
 
     context "when no current scope" do
       it "should set collection_before_scope to the chain and return the chain" do
-        chain = mock("ChainObj")
-        controller.send(:apply_scoping, chain).should == chain
-        controller.send(:collection_before_scope).should == chain
+        chain = double "ChainObj"
+        expect(controller.send(:apply_scoping, chain)).to eq chain
+        expect(controller.send(:collection_before_scope)).to eq chain
       end
     end
 
     context "when current scope" do
       it "should set collection_before_scope to the chain and return the scoped chain" do
-        chain = mock("ChainObj")
-        scoped_chain = mock("ScopedChain")
-        current_scope = mock("CurrentScope")
-        controller.stub!(:current_scope) { current_scope }
-
-        controller.should_receive(:scope_chain).with(current_scope, chain) { scoped_chain }
-        controller.send(:apply_scoping, chain).should == scoped_chain
-        controller.send(:collection_before_scope).should == chain
+        chain = double "ChainObj"
+        scoped_chain = double "ScopedChain"
+        current_scope = double "CurrentScope"
+        allow(controller).to receive(:current_scope) { current_scope }
+
+        expect(controller).to receive(:scope_chain).with(current_scope, chain) { scoped_chain }
+        expect(controller.send(:apply_scoping, chain)).to eq scoped_chain
+        expect(controller.send(:collection_before_scope)).to eq chain
       end
     end
+  end
 
+  describe "includes" do
+    context "with no includes" do
+      it "should return the chain" do
+        chain = double "ChainObj"
+        expect(controller.send(:apply_includes, chain)).to eq chain
+      end
+    end
+
+    context "with includes" do
+      it "should return the chain with the includes" do
+        chain = double "ChainObj"
+        chain_with_includes = double "ChainObjWithIncludes"
+        expect(chain).to receive(:includes).with(:taggings, :author).and_return(chain_with_includes)
+        expect(controller.send(:active_admin_config)).to receive(:includes).twice.and_return([:taggings, :author])
+        expect(controller.send(:apply_includes, chain)).to eq chain_with_includes
+      end
+    end
   end
 
+  describe "find_collection" do
+    let(:appliers) do
+      ActiveAdmin::ResourceController::DataAccess::COLLECTION_APPLIES
+    end
+    let(:scoped_collection) do
+      double "ScopedCollectionChain"
+    end
+    before do
+      allow(controller).to receive(:scoped_collection).
+        and_return(scoped_collection)
+    end
+
+    it "should return chain with all appliers " do
+      appliers.each do |applier|
+        expect(controller).to receive("apply_#{applier}").
+          with(scoped_collection).
+          once.
+          and_return(scoped_collection)
+      end
+      expect(controller).to receive(:collection_applies).
+        with({}).and_call_original.once
+      controller.send :find_collection
+    end
+
+    describe "collection_applies" do
+      context "excepting appliers" do
+        let(:options) do
+          { except:
+              [:authorization_scope, :filtering, :scoping, :collection_decorator]
+          }
+        end
+
+        it "should except appliers" do
+          expect(controller.send :collection_applies, options).
+            to eq([:sorting, :includes, :pagination])
+        end
+      end
+
+      context "specifying only needed appliers" do
+        let(:options) do
+          { only: [:filtering, :scoping] }
+        end
+        it "should except appliers" do
+          expect(controller.send :collection_applies, options).to eq(options[:only])
+        end
+      end
+    end
+  end
 end