activeadmin 0.6.6 → 1.0.0.pre1

data/features/new_page.feature

@@ -8,7 +8,12 @@ Feature: New Page
     And I am logged in
     Given a configuration of:
     """
-      ActiveAdmin.register Post
+      ActiveAdmin.register Post do
+        if Rails::VERSION::MAJOR == 4
+          permit_params :custom_category_id, :author_id, :title,
+            :body, :position, :published_at, :starred
+        end
+      end
     """
     When I am on the index page for posts
 
@@ -22,13 +27,15 @@ Feature: New Page
     Then I should see "Post was successfully created."
     And I should see the attribute "Title" with "Hello World"
     And I should see the attribute "Body" with "This is the body"
-    And I should see the attribute "Category" with "Music"
+    #And I should see the attribute "Category" with "Music"
     And I should see the attribute "Author" with "John Doe"
 
   Scenario: Generating a custom form
     Given a configuration of:
     """
       ActiveAdmin.register Post do
+        permit_params :custom_category_id, :author_id, :title, :body, :published_at, :starred if Rails::VERSION::MAJOR == 4
+
         form do |f|
           f.inputs "Your Post" do
             f.input :title
@@ -63,6 +70,8 @@ Feature: New Page
     Given a configuration of:
     """
       ActiveAdmin.register Post do
+        permit_params :custom_category_id, :author_id, :title, :body, :published_at, :starred if Rails::VERSION::MAJOR == 4
+
         form :partial => "form"
       end
     """
@@ -78,6 +87,8 @@ Feature: New Page
     Given a configuration of:
     """
       ActiveAdmin.register Post do
+        permit_params :custom_category_id, :author_id, :title, :body, :published_at, :starred if Rails::VERSION::MAJOR == 4
+
         form do |f|
           f.inputs "Your Post" do
             if current_admin_user && false

data/features/registering_pages.feature

@@ -93,7 +93,7 @@ Feature: Registering Pages
     Given a configuration of:
     """
     ActiveAdmin.register_page "Status" do
-      action_item do
+      action_item :visit do
         link_to "Visit", "/"
       end
 

data/features/renamed_resource.feature

@@ -0,0 +1,32 @@
+Feature: Renamed Resource
+
+  Strong attributes for resources renamed with as: 'NewName'
+
+  Background:
+    Given a category named "Music" exists
+    Given a user named "John Doe" exists
+    And I am logged in
+    Given a configuration of:
+    """
+      ActiveAdmin.register Blog::Post, as: 'Post' do
+        if Rails::VERSION::MAJOR == 4
+          permit_params :custom_category_id, :author_id, :title,
+            :body, :position, :published_at, :starred
+        end
+      end
+    """
+    When I am on the index page for posts
+
+  Scenario: Default form with no config
+    Given I follow "New Post"
+    When I fill in "Title" with "Hello World"
+    And I fill in "Body" with "This is the body"
+    And I select "Music" from "Category"
+    And I select "John Doe" from "Author"
+    And I press "Create Post"
+    Then I should see "Post was successfully created."
+    And I should see the attribute "Title" with "Hello World"
+    And I should see the attribute "Body" with "This is the body"
+    #And I should see the attribute "Category" with "Music"
+    And I should see the attribute "Author" with "John Doe"
+

data/features/show/page_title.feature

@@ -45,3 +45,14 @@ Feature: Show - Page Title
       ActiveAdmin.register Tag
     """
     Then I should see the page title "Tag #"
+
+  Scenario: Set the title in controller
+    Given a show configuration of:
+    """
+      ActiveAdmin.register Post do
+        controller do
+          before_filter { @page_title = "List of #{resource_class.model_name.plural}" }
+        end
+      end
+    """
+    Then I should see the page title "List of posts"

data/features/show/tabs.feature

@@ -0,0 +1,27 @@
+Feature: Show - Tabs
+
+  Add tabs with different content to the page
+
+  Background:
+    Given a post with the title "Hello World" written by "Jane Doe" exists
+
+  Scenario: Set a method to be called on the resource as the title
+    Given a show configuration of:
+    """
+      ActiveAdmin.register Post do
+        show do
+          tabs do
+            tab :overview do
+              span "tab 1"
+            end
+
+            tab :details do
+              span "tab 2"
+            end
+          end
+        end
+      end
+    """
+    Then I should see two tabs "Overview" and "Details"
+    And I should see "tab 1"
+    And I should see "tab 2"

data/features/sidebar_sections.feature

@@ -196,3 +196,15 @@ Feature: Sidebar Sections
     When I am on the index page for posts
     Then I should see "Hello World from a custom partial" within the "Help" sidebar
 
+
+  Scenario: Position sidebar at the top using priority option
+    Given a configuration of:
+    """
+    ActiveAdmin.register Post do
+      sidebar :help, priority: 0 do
+        "Need help? Email us at help@example.com"
+      end
+    end
+    """
+    When I am on the index page for posts
+    Then I should see a sidebar titled "Help" above sidebar titled "Filters"

data/features/site_title.feature

@@ -11,12 +11,12 @@ Feature: Site title
     Given a configuration of:
     """
       ActiveAdmin.application.site_title = "My Great Site"
-      ActiveAdmin.application.site_title_link = "/"
+      ActiveAdmin.application.site_title_link = "/admin"
     """
     When I am on the dashboard
     And I should see the site title "My Great Site"
     When I follow "My Great Site"
-    Then I should see "Ruby on Rails: Welcome aboard"
+    Then I should see the site title "My Great Site"
 
   Scenario: Set the site title image
     Given a configuration of:

data/features/specifying_actions.feature

@@ -23,7 +23,7 @@ Feature: Specifying Actions
     Given a configuration of:
       """
         ActiveAdmin.register Post do
-          action_item(:only => :index) do
+          action_item(:import, :only => :index) do
             link_to('Import Posts', import_admin_posts_path)
           end
 
@@ -43,7 +43,7 @@ Feature: Specifying Actions
     Given a configuration of:
       """
         ActiveAdmin.register Post do
-          action_item(:only => :show) do
+          action_item(:review, :only => :show) do
             link_to('Review', review_admin_post_path)
           end
 
@@ -69,7 +69,7 @@ Feature: Specifying Actions
     Given a configuration of:
       """
         ActiveAdmin.register Post do
-          action_item(:only => :show) do
+          action_item(:review, :only => :show) do
             link_to('Review', review_admin_post_path)
           end
 

data/features/step_definitions/action_item_steps.rb

@@ -1,7 +1,7 @@
 Then /^I should see an action item link to "([^"]*)"$/ do |link|
-  page.should have_css('.action_item a', :text => link)
+  expect(page).to have_css('.action_item a', text: link)
 end
 
 Then /^I should not see an action item link to "([^"]*)"$/ do |link|
-  page.should_not have_css('.action_item a', :text => link)
+  expect(page).to_not have_css('.action_item a', text: link)
 end

data/features/step_definitions/action_link_steps.rb

@@ -1,7 +1,20 @@
 Then /^I should see a member link to "([^"]*)"$/ do |name|
-  page.should have_css("a.member_link", :text => name)
+  expect(page).to have_css('a.member_link', text: name)
 end
 
 Then /^I should not see a member link to "([^"]*)"$/ do |name|
   %{Then I should not see "#{name}" within "a.member_link"}
 end
+
+Then /^I should see the actions column with the class "([^"]*)" and the title "([^"]*)"$/ do |klass, title|
+  expect(page).to have_css "th#{'.'+klass}", text: title
+end
+
+Then /^I should see a dropdown menu item to "([^"]*)"$/ do |name|
+  expect(page).to have_css('ul.dropdown_menu_list li a', text: name)
+end
+
+Then /^I should not see a dropdown menu item to "([^"]*)"$/ do |name|
+  %{Then I should not see "#{name}" within "ul.dropdown_menu_list li a"}
+end
+

data/features/step_definitions/additional_web_steps.rb

@@ -1,17 +1,17 @@
 Then /^I should see a table header with "([^"]*)"$/ do |content|
-  page.should have_xpath('//th', :text => content)
+  expect(page).to have_xpath '//th', text: content
 end
 
 Then /^I should not see a table header with "([^"]*)"$/ do |content|
-  page.should_not have_xpath('//th', :text => content)
+  expect(page).to_not have_xpath '//th', text: content
 end
 
 Then /^I should see a sortable table header with "([^"]*)"$/ do |content|
-  page.should have_css('th.sortable', :text => content)
+  expect(page).to have_css 'th.sortable', text: content
 end
 
 Then /^I should not see a sortable table header with "([^"]*)"$/ do |content|
-  page.should_not have_css('th.sortable', :text => content)
+  expect(page).to_not have_css 'th.sortable', text: content
 end
 
 Then /^I should not see a sortable table header$/ do
@@ -19,32 +19,31 @@ Then /^I should not see a sortable table header$/ do
 end
 
 Then /^the table "([^"]*)" should have (\d+) rows/ do |selector, count|
-  table = page.find(selector)
-  table.all(:css, 'tr').size.should == count.to_i
+  trs = page.find(selector).all :css, 'tr'
+  expect(trs.size).to eq count.to_i
 end
 
 Then /^the table "([^"]*)" should have (\d+) columns/ do |selector, count|
-  table = page.find(selector)
-  row = table.find('tr:first')
-  row.all(:css, "td").size.should == count.to_i
+  tds = page.find(selector).find('tr:first').all :css, 'td'
+  expect(tds.size).to eq count.to_i
 end
 
 Then /^there should be (\d+) "([^"]*)" tags$/ do |count, tag|
-  page.all(:css, tag).size.should == count.to_i
+  expect(page.all(:css, tag).size).to eq count.to_i
 end
 
 Then /^I should see a link to "([^"]*)"$/ do |link|
-  page.should have_xpath('//a', :text => link)
+  expect(page).to have_xpath '//a', text: link
 end
 
 Then /^an "([^"]*)" exception should be raised when I follow "([^"]*)"$/ do |error, link|
-  lambda {
+  expect {
     step "I follow \"#{link}\""
-  }.should raise_error(error.constantize)
+  }.to raise_error(error.constantize)
 end
 
 Then /^I should be in the resource section for (.+)$/ do |resource_name|
-  current_url.should include resource_name.gsub(' ', '').underscore.pluralize
+  expect(current_url).to include resource_name.tr(' ', '').underscore.pluralize
 end
 
 Then /^I should wait and see "([^"]*)"(?: within "([^"]*)")?$/ do |text, selector|
@@ -56,27 +55,27 @@ end
 
 Then /^I should see the page title "([^"]*)"$/ do |title|
   within('h2#page_title') do
-    page.should have_content(title)
+    expect(page).to have_content title
   end
 end
 
 Then /^I should see a fieldset titled "([^"]*)"$/ do |title|
-  page.should have_css('fieldset legend', :text => title)
+  expect(page).to have_css 'fieldset legend', text: title
 end
 
 Then /^the "([^"]*)" field should contain the option "([^"]*)"$/ do |field, option|
   field = find_field(field)
-  field.should have_css("option", :text => option)
+  expect(field).to have_css 'option', text: option
 end
 
 Then /^I should see the content "([^"]*)"$/ do |content|
-  page.should have_css("#active_admin_content", :text => content)
+  expect(page).to have_css '#active_admin_content', text: content
 end
 
 Then /^I should see a validation error "([^"]*)"$/ do |error_message|
-  page.should have_css(".inline-errors", :text => error_message)
+  expect(page).to have_css '.inline-errors', text: error_message
 end
 
 Then /^I should see a table with id "([^"]*)"$/ do |dom_id|
-  page.should have_css('table', :id => dom_id)
+  page.find("table##{dom_id}")
 end

data/features/step_definitions/asset_steps.rb

@@ -3,13 +3,13 @@ Then /^I should see the css file "([^"]*)"$/ do |path|
 end
 
 Then /^I should see the css file "([^"]*)" of media "([^"]*)"$/ do |path, media|
-  page.should have_xpath("//link[contains(@href, /stylesheets/#{path}) and contains(@media, #{media})]")
+  expect(page).to have_xpath("//link[contains(@href, /stylesheets/#{path}) and contains(@media, #{media})]", visible: false)
 end
 
 Then /^I should see the js file "([^"]*)"$/ do |path|
-  page.should have_xpath("//script[contains(@src, /javascripts/#{path})]")
+  expect(page).to have_xpath("//script[contains(@src, /javascripts/#{path})]", visible: false)
 end
 
 Then /^I should see the favicon "([^"]*)"$/ do |path|
-  page.should have_xpath("//link[contains(@href, \"#{path}\")]")
+  expect(page).to have_xpath("//link[contains(@href, path)]", visible: false)
 end

data/features/step_definitions/attribute_steps.rb

@@ -1,13 +1,18 @@
 Then /^I should see the attribute "([^"]*)" with "([^"]*)"$/ do |title, value|
   elems = all ".attributes_table th:contains('#{title}') ~ td:contains('#{value}')"
-  elems.first.should_not be_nil, 'attribute missing'
+  expect(elems.first).to_not be_nil, 'attribute missing'
 end
 
 Then /^I should see the attribute "([^"]*)" with a nicely formatted datetime$/ do |title|
   text = all(".attributes_table th:contains('#{title}') ~ td").first.text
-  text.should match /\w+ \d{1,2}, \d{4} \d{2}:\d{2}/
+  expect(text).to match /\w+ \d{1,2}, \d{4} \d{2}:\d{2}/
+end
+
+Then /^the attribute "([^"]*)" should be empty$/ do |title|
+  elems = all ".attributes_table th:contains('#{title}') ~ td > span.empty"
+  expect(elems.first).to_not be_nil, 'attribute not empty'
 end
 
 Then /^I should not see the attribute "([^"]*)"$/ do |title|
-  page.should_not have_css('.attributes_table th', :text => title)
+  expect(page).to_not have_css '.attributes_table th', text: title
 end

data/features/step_definitions/batch_action_steps.rb

@@ -1,17 +1,22 @@
 Then /^I (should|should not) be asked to confirm "([^"]*)" for "([^"]*)"$/ do |maybe, confirmation, title|
   selector = "#batch_actions_popover a.batch_action:contains('#{title}')"
   selector << "[data-confirm='#{confirmation}']" if maybe == 'should'
-  page.send maybe.sub(' ', '_'), have_css(selector)
+
+  verb = maybe == 'should' ? :to : :to_not
+  expect(page).send verb, have_css(selector)
 end
 
 Then /^I (should|should not) see the batch action :([^\s]*) "([^"]*)"$/ do |maybe, sym, title|
-  selector = "#batch_actions_selector a.batch_action:contains('#{title}')"
+  selector = ".batch_actions_selector a.batch_action:contains('#{title}')"
   selector << "[href='#'][data-action='#{sym}']" if maybe == 'should'
-  page.send maybe.sub(' ', '_'), have_css(selector)
+
+  verb = maybe == 'should' ? :to : :to_not
+  expect(page).send verb, have_css(selector)
 end
 
 Then /^the (\d+)(?:st|nd|rd|th) batch action should be "([^"]*)"$/ do |index, title|
-  page.all("#batch_actions_selector a.batch_action")[index.to_i - 1].text.should match title
+  batch_action = page.all('.batch_actions_selector a.batch_action')[index.to_i - 1]
+  expect(batch_action.text).to match title
 end
 
 When /^I check the (\d+)(?:st|nd|rd|th) record$/ do |index|
@@ -23,17 +28,19 @@ When /^I toggle the collection selection$/ do
 end
 
 Then /^I should see that the batch action button is disabled$/ do
-  page.should have_css "#batch_actions_selector .dropdown_menu_button.disabled"
+  expect(page).to have_css ".batch_actions_selector .dropdown_menu_button.disabled"
 end
 
 Then /^I (should|should not) see the batch action (button|selector)$/ do |maybe, type|
-  selector = "div.table_tools #batch_actions_selector"
+  selector = "div.table_tools .batch_actions_selector"
   selector << ' .dropdown_menu_button' if maybe == 'should' && type == 'button'
-  page.send maybe.sub(' ', '_'), have_css(selector)
+
+  verb = maybe == 'should' ? :to : :to_not
+  expect(page).send verb, have_css(selector)
 end
 
 Then /^I should see the batch action popover exists$/ do
-  page.should have_css "#batch_actions_selector"
+  expect(page).to have_css '.batch_actions_selector'
 end
 
 Given /^I submit the batch action form with "([^"]*)"$/ do |action|
@@ -51,5 +58,15 @@ Given /^I submit the batch action form with "([^"]*)"$/ do |action|
 end
 
 Then /^I should not see checkboxes in the table$/ do
-  page.should_not have_css ".paginated_collection table input[type=checkbox]"
+  expect(page).to_not have_css '.paginated_collection table input[type=checkbox]'
+end
+
+Then /^I should be show a input with name "([^"]*)" and type "([^"]*)"$/ do |name, type|
+  selector = ".batch_actions_selector a.batch_action:first"
+  expect(page.find(selector)["data-inputs"]).to eq "{\"#{name}\":\"#{type}\"}"
+end
+
+Then /^I should be show a select with name "([^"]*)" with the values "([^"]*)"$/ do |name, values|
+  selector = ".batch_actions_selector a.batch_action:first"
+  expect(JSON[page.find(selector)["data-inputs"]]).to eq Hash[name, values.split(', ')]
 end

data/features/step_definitions/blog_steps.rb

@@ -0,0 +1,3 @@
+Then /^I should see a blog header "([^"]*)"$/ do |header_text|
+  expect(page).to have_css 'h3', text: header_text
+end

data/features/step_definitions/breadcrumb_steps.rb

@@ -1,3 +1,3 @@
 Then /^I should see a link to "([^"]*)" in the breadcrumb$/ do |text|
-  page.should have_css('.breadcrumb > a', :text => text)
+  expect(page).to have_css '.breadcrumb > a', text: text
 end

data/features/step_definitions/comment_steps.rb

@@ -8,5 +8,5 @@ When /^I add a comment "([^"]*)"$/ do |comment|
 end
 
 Given /^a tag with the name "([^"]*)" exists$/ do |tag_name|
-  Tag.create(:name => tag_name)
+  Tag.create(name: tag_name)
 end